[Bug 1209085] Re: update-smart-drivedb uses old download link
Trusty verification Confirming the problem: ubuntu@trusty-smart-1209085:~$ sudo apt-get install smartmontools --no-install-recommends Reading package lists... Done Building dependency tree Reading state information... Done The following packages were automatically installed and are no longer required: libfreetype6 os-prober Use 'apt-get autoremove' to remove them. Suggested packages: gsmartcontrol smart-notifier Recommended packages: mailx mailutils The following NEW packages will be installed: smartmontools 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 445 kB of archives. After this operation, 1,650 kB of additional disk space will be used. Get:1 http://br.archive.ubuntu.com/ubuntu/ trusty/main smartmontools amd64 6.2+svn3841-1.2 [445 kB] Fetched 445 kB in 0s (1,562 kB/s) Selecting previously unselected package smartmontools. (Reading database ... 25846 files and directories currently installed.) Preparing to unpack .../smartmontools_6.2+svn3841-1.2_amd64.deb ... Unpacking smartmontools (6.2+svn3841-1.2) ... Processing triggers for man-db (2.6.7.1-1ubuntu1) ... Processing triggers for ureadahead (0.100.0-16) ... Setting up smartmontools (6.2+svn3841-1.2) ... Processing triggers for ureadahead (0.100.0-16) ... ubuntu@trusty-smart-1209085:~$ sudo update-smart-drivedb /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible With the update installed: ubuntu@trusty-smart-1209085:~$ apt-cache policy smartmontools smartmontools: Installed: 6.2+svn3841-1.2ubuntu0.1 Candidate: 6.2+svn3841-1.2ubuntu0.1 Version table: *** 6.2+svn3841-1.2ubuntu0.1 0 500 http://br.archive.ubuntu.com/ubuntu/ trusty-proposed/main amd64 Packages 100 /var/lib/dpkg/status 6.2+svn3841-1.2 0 500 http://br.archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages Update script works: ubuntu@trusty-smart-1209085:~$ sudo update-smart-drivedb /var/lib/smartmontools/drivedb/drivedb.h updated from branches/RELEASE_6_2_DRIVEDB ubuntu@trusty-smart-1209085:~$ file /var/lib/smartmontools/drivedb/drivedb.h /var/lib/smartmontools/drivedb/drivedb.h: ASCII text ubuntu@trusty-smart-1209085:~$ file /var/lhead /var/lib/smartmontools/drivedb/drivedb.h /* * drivedb.h - smartmontools 6.1-6.3 drive database file * * Home page of code is: http://www.smartmontools.org * * Copyright (C) 2003-11 Philip Williams, Bruce Allen * Copyright (C) 2008-18 Christian Franke * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by ** Tags removed: verification-needed-trusty ** Tags added: verification-done-trusty -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
** Description changed: [Impact] Updating the smart driver db fails because the tool selected by the script (curl) is not called with a parameter that allows it to follow redirects. Since upstream changed the URL for that driver file, the script now fails. The fix is to just add -L to the curl command line. [Test Case] - sudo apt-get install smartmontools --no-install-recommends - sudo update-smart-drivedb + $ sudo apt-get install smartmontools --no-install-recommends + $ sudo update-smart-drivedb /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible The file /var/lib/smartmontools/drivedb/drivedb.h.error contains the redirect notice: 302 Found - The resource was found at https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw;>https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw; + The resource was found at https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw;>https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw; you should be redirected automatically. - Update the packages and run the command again, this time it will - succeed: - + Update the packages and run the command again, this time it will succeed: + $ sudo update-smart-drivedb + /var/lib/smartmontools/drivedb/drivedb.h updated from branches/RELEASE_6_2_DRIVEDB [Regression Potential] If there is a redirect loop, before it wouldn't be followed, and now it will. There is a default limit of 50, though (--max-redirs' default), so eventually it will stop and fail (correctly). [Other Info] Later supported releases of Ubuntu and Debian have dropped this script from the package, so no fix is necessary there. Following the spirit of the smallest change possible, I chose to not change the URL from where the file is downloaded. - [Original Description] Package: smartmontools-6.1+svn3812-1 and older. Due to sourceforge platform upgrades (http://sourceforge.net/blog /upgrades-april22/), the smartmontools SVN repository was moved to a new location. The update-smart-drivedb script from a smartmontools build before r3814 downloads drivedb.h from the old respository which is still present but set to R/O. Possible fix: - Update to smartmontools 6.2 (final, r3841), or - Replace update-smart-drivedb with a new one generated from 6.2 tarball. Adjust the branch version number in line 'BRANCH="RELEASE_6_2_DRIVEDB"'. This should work for smartmontools 5.40 to 6.1. These drivedb.h branches are still maintained. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
** Description changed: [Impact] - * An explanation of the effects of the bug on users and + Updating the smart driver db fails because the tool selected by the + script (curl) is not called with a parameter that allows it to follow + redirects. Since upstream changed the URL for that driver file, the + script now fails. - * justification for backporting the fix to the stable release. - - * In addition, it is helpful, but not required, to include an -explanation of how the upload fixes this bug. + The fix is to just add -L to the curl command line. [Test Case] + sudo apt-get install smartmontools --no-install-recommends + sudo update-smart-drivedb + /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible - * detailed instructions how to reproduce the bug + The file /var/lib/smartmontools/drivedb/drivedb.h.error contains the redirect notice: + 302 Found + The resource was found at https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw;>https://sourceforge.net/p/smartmontools/code/HEAD/tree/branches/RELEASE_6_2_DRIVEDB/smartmontools/drivedb.h?format=raw; + you should be redirected automatically. - * these should allow someone who is not familiar with the affected -package to reproduce the bug and verify that the updated package fixes -the problem. + Update the packages and run the command again, this time it will + succeed: + [Regression Potential] - - * discussion of how regressions are most likely to manifest as a result - of this change. - - * It is assumed that any SRU candidate patch is well-tested before -upload and has a low overall risk of regression, but it's important -to make the effort to think about what ''could'' happen in the -event of a regression. - - * This both shows the SRU team that the risks have been considered, -and provides guidance to testers in regression-testing the SRU. + If there is a redirect loop, before it wouldn't be followed, and now it will. There is a default limit of 50, though (--max-redirs' default), so eventually it will stop and fail (correctly). [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + Later supported releases of Ubuntu and Debian have dropped this script from the package, so no fix is necessary there. + + Following the spirit of the smallest change possible, I chose to not + change the URL from where the file is downloaded. [Original Description] Package: smartmontools-6.1+svn3812-1 and older. Due to sourceforge platform upgrades (http://sourceforge.net/blog /upgrades-april22/), the smartmontools SVN repository was moved to a new location. The update-smart-drivedb script from a smartmontools build before r3814 downloads drivedb.h from the old respository which is still present but set to R/O. Possible fix: - Update to smartmontools 6.2 (final, r3841), or - Replace update-smart-drivedb with a new one generated from 6.2 tarball. Adjust the branch version number in line 'BRANCH="RELEASE_6_2_DRIVEDB"'. This should work for smartmontools 5.40 to 6.1. These drivedb.h branches are still maintained. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
** Changed in: smartmontools (Ubuntu Trusty) Status: Triaged => In Progress ** Changed in: smartmontools (Ubuntu Trusty) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Description changed: + [Impact] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an +explanation of how the upload fixes this bug. + + [Test Case] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected +package to reproduce the bug and verify that the updated package fixes +the problem. + + [Regression Potential] + + * discussion of how regressions are most likely to manifest as a result + of this change. + + * It is assumed that any SRU candidate patch is well-tested before +upload and has a low overall risk of regression, but it's important +to make the effort to think about what ''could'' happen in the +event of a regression. + + * This both shows the SRU team that the risks have been considered, +and provides guidance to testers in regression-testing the SRU. + + [Other Info] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + + [Original Description] + Package: smartmontools-6.1+svn3812-1 and older. Due to sourceforge platform upgrades (http://sourceforge.net/blog /upgrades-april22/), the smartmontools SVN repository was moved to a new location. The update-smart-drivedb script from a smartmontools build before r3814 downloads drivedb.h from the old respository which is still present but set to R/O. Possible fix: - Update to smartmontools 6.2 (final, r3841), or - Replace update-smart-drivedb with a new one generated from 6.2 tarball. Adjust the branch version number in line 'BRANCH="RELEASE_6_2_DRIVEDB"'. This should work for smartmontools 5.40 to 6.1. These drivedb.h branches are still maintained. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
update-smart-drivedb was dropped in 6.4+svn4214-1:
smartmontools (6.4+svn4214-1) unstable; urgency=medium
...
[ Jonathan Dowland ]
...
* Get rid of update-smart-drivedb. Closes: #783317, #804299, #706909.
...
-- Jonathan Dowland Thu, 04 Feb 2016 23:21:58 +
So the last ubuntu release that is still supported and has this bug is trusty.
As others have pointed out, adding -L to curl's command line fixes that case:
--- a/update-smart-drivedb.in
+++ b/update-smart-drivedb.in
@@ -155,7 +155,7 @@ download()
case $tool in
curl)
- vrun curl ${q:+-s} -f --max-redirs 0 \
+ vrun curl ${q:+-s} -f -L --max-redirs 0 \
** Also affects: smartmontools (Ubuntu Trusty)
Importance: Undecided
Status: New
** Changed in: smartmontools (Ubuntu)
Status: Triaged => Fix Released
** Changed in: smartmontools (Ubuntu Trusty)
Status: New => Triaged
** Changed in: smartmontools (Ubuntu Trusty)
Importance: Undecided => Medium
** Tags removed: precise
** Tags added: bitesize trusty
--
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to smartmontools in Ubuntu.
https://bugs.launchpad.net/bugs/1209085
Title:
update-smart-drivedb uses old download link
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
Ubuntu Precise 12.04.5, update-smart-drivedb does not work. The error log is below. sudo update-smart-drivedb -v Download from branches/RELEASE_5_41_DRIVEDB % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 329 100 3290 0610 0 --:--:-- --:--:-- --:--:-- 1353 /usr/share/smartmontools/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible ** Tags added: precise -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
The attached patch worked for me.
Or just run
# sed -i
/^SRCEXPR/{s#=.*#='http://sourceforge.net/p/smartmontools/code/HEAD/tree/\$location/smartmontools/drivedb.h?format=raw'#}
$(which update-smart-drivedb)
** Patch added: current URI for drivedb.h
https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+attachment/4101226/+files/update-smart-drivedb.patch
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to smartmontools in Ubuntu.
https://bugs.launchpad.net/bugs/1209085
Title:
update-smart-drivedb uses old download link
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
The attachment current URI for drivedb.h seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1209085] Re: update-smart-drivedb uses old download link
What's up with this one? Can anyone take care of this annoyance? This is what happens on 13.10: ~$ sudo update-smart-drivedb -v Download from branches/RELEASE_6_2_DRIVEDB % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 329 100 3290 0 1245 0 --:--:-- --:--:-- --:--:-- 1246 /var/lib/smartmontools/drivedb/drivedb.h.error: rejected by /usr/sbin/smartctl, probably no longer compatible ~$ cat /var/lib/smartmontools/drivedb/drivedb.h.error !DOCTYPE HTML PUBLIC -//IETF//DTD HTML 2.0//EN htmlhead title302 Found/title /headbody h1Found/h1 pThe document has moved a href=http://sourceforge.net/p/smartmontools/code/;here/a./p hr addressApache/2.2.3 (CentOS) Server at smartmontools.svn.sourceforge.net Port 50043/address /body/html ~$ apt-cache show smartmontools [snip] Version: 6.1+svn3812-1 [snip] ~$ update-smart-drivedb -V smartmontools 6.2 drive database update script [snip] -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to smartmontools in Ubuntu. https://bugs.launchpad.net/bugs/1209085 Title: update-smart-drivedb uses old download link To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1209085/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
