Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-city-name-fix into lp:ubuntu-clock-app
Review: Abstain -- https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-city-name-fix/+merge/266153 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-city-name-fix into lp:ubuntu-clock-app
Just tested it now again and it works nicely without regressions and fixes the issues it set out to fix. Will approve after I finish my code review. Thanks for working on this! -- https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-city-name-fix/+merge/266153 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app
Review: Approve Running through the MP checklist, * Does the MP add/remove user visible strings? If Yes, has the pot file been updated? No user visible strings changed. * Does the MP change the UI? If Yes, has it been approved by design? No UI change. * Did you perform an exploratory manual test run of your code change and any related functionality? Yes, tested on N4, #95 image. Works correctly! * If the MP fixes a bug or implements a feature, are there accompanying unit and autopilot tests? Could do with a Unit test. But not a compulsory rule for now. But please do add unit tests next time for this feature. Quite easy to do. * Is the clock app trunk buildable and runnable using Qtcreator? Yes * Was the debian changelog updated? Yes * Was the copyright years updated if necessary? Yes LGTM! Approved! -- https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging into lp:ubuntu-clock-app
Review: Needs Information Here is what I'm missing with current StopWatch implementation: 1. Saving laps in database after pressing Lap or stop Button. After close and run Clock application, the results should be still there 2. When you start stopwatch the starttime should be stored in database. After closing Clock app, and reopening it, the time should be still counting (we could just calculate difference between starttime and current time). These features could be implemented later, but this is good input for UX approval -- https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging/+merge/266718 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:334 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/754/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/99 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/754/rebuild -- https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app
Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app. Commit message: Fix default alarm time issue (LP: #1484926) Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) Related bugs: Bug #1484926 in Ubuntu Clock App: "Default alarm time is wrongly set, if the current time minutes is multiply by 5" https://bugs.launchpad.net/ubuntu-clock-app/+bug/1484926 For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix/+merge/268069 Fix default alarm time issue (LP: #1484926) -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~gang65/ubuntu-clock-app/ubuntu-clock-default-alarm-time-fix into lp:ubuntu-clock-app. === modified file 'debian/changelog' --- debian/changelog 2015-08-13 13:45:21 + +++ debian/changelog 2015-08-14 12:28:28 + @@ -3,6 +3,7 @@ [Bartosz Kosiorek] * Disable automatic translation and update README.translations * Change "Silence after" to "Alarm stops afer" according to UX design + * Fix default alarm time issue (LP: #1484926) [Nekhelesh Ramananthan] * Increase the height of times in the alarm screen (LP: #1365428) -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/update-default-alarm-sound/+merge/267953 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint
Blueprint changed by David Planella: Whiteboard changed: Scratch pad at http://pad.ubuntu.com/loviewer + + Questions for 14 Aug 2015 (Stefano) + + * Status of a convergent UI/UX design for DocViewer. + Since our ultimate target is to get a DocViewer version, suitable for both PCs and devices, we'd need to have a up-to-date design pattern in order to know how to manage zooming with different input devices. + + * PDF plugin re-design. + Ideally, this should be take just a week, as the tiled rendering for LOK is completed (with SG paiting and zooming). + + This has been a critical argument during the past meetings, since it's + not considered a priority. There's a number of reason why I think it + would be an important thing to do. + + I decided to design the PDF plugin as I did in October, during the Washington D.C. sprint, mainly for three reasons: we needed to make it work ASAP, there were already a pre-existent code, and I was not so good in write a proper plugin from scratch. :) + We have considered to use a Poppler plugin written for the SailfishOS Document Viewer, but there were potential issues with the used license. + + So we went with the current implementation, which has some issue: + + - Multithreading is not perfectly working on all the Ubuntu phones + - Zoom management is a mess (see issues with centred zoom) \o/ + - We are using Qt5 private imports + - Consistence of the code would be a lot broken, when we'll go for adding overlays (i.e. hypertext links, copy/paste, and search - which are priorities for the PDF plugin) + - It is not convergence-friendly. Current zoom management would just be a mess on desktops (i.e. it doesn't follow the standard way to zoom a PDF document of desktop) + + * Is it worth to move directly from UITK 1.1 to UITK 1.3? + I know that it would be a bit uncomfortable for devs to work on docviewer from desktop. + This is just a generic question: since our target is to release the reboot series in late-September, I think we could do it. Feel free to say no! :) + + * Has Jenkyns been enabled for builds from the "reboot" branch? + + * Any news about a new application icon? :D -- Libreoffice Docviewer Integration blueprint https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint
Blueprint changed by David Planella:
Work items changed:
Work items for 2015-07-02:
[bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects
page breaks: DONE
[bjoern-michaelsen] Study the API and report on capabilities that would be
applicable to the LO viewer: INPROGRESS
[verzegnassi-stefano] Add capability to detect page breaks to go to a
particular page: BLOCKED
[verzegnassi-stefano] Investigate tile rendering approach: INPROGRESS
[mrqtros] Study the docviewer code: DONE
[mrqtros] Study the LibreOffice Kit API: DONE
[mrqtros] Implement error detection and recovery: POSTPONED
Work items for 2015-07-09:
[verzegnassi-stefano] Continue prototyping tile rendering approach
(https://www.youtube.com/watch?v=GAmBJy9RpQk): INPROGRESS
[mrqtros] Provide support to Stefano on writing/debugging/imroving
performance of the tiled rendering code: INPROGRESS
[bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work:
DONE
[verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a
short-term alternative: DONE
Work items for 2015-07-16:
[verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML
code as a short-term alternative: POSTPONED
[verzegnassi-stefano] Improve the logic that initialize the tiles: DONE
[verzegnassi-stefano] Implementing the double buffered cache: DONE
[bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO
Work items for 2015-07-23:
Placeholder: TODO
[verzegnassi-stefano] Finish zoom implementation: INPROGRESS
Work items for 2015-07-30:
Placeholder: TODO
Work items for 2015-08-06:
Placeholder: TODO
Work items for 2015-08-13:
[verzegnassi-stefano] Do a further check to ensure that all signals/slots
works properly for the zooming feature: DONE
[verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
[mrqtros] review LO plugin architecture and provide potential improvements:
TODO
[mrqtros] use SceneGraph for rendering: TODO
+ [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS
+ [popey] Clone Bjoern's small footprint LibreOffice build PPA: TODO
+ [popey] Set up an armhf LibreOffice build for the PPA: TODO
+ [popey] Include the armhf LibreOffice binaries in a docviewer click package:
TODO
Work items for 2015-08-20:
- Placeholder: TODO
+ [verzegnassi-stefano] Centering the zooming on the gesture/page center
("attempt-fix-zooming-1" branch): TODO
Work items for 2015-08-27:
- Placeholder: TODO
+ [verzegnassi-stefano] Investigate on future features (text selection and
keyboard/mouse/touch events): TODO
Work items for 2015-09-03:
- Placeholder: TODO
+ [verzegnassi-stefano] Switching from the content hub C++ API to the QML API:
TODO
Work items for 2015-09-10:
Placeholder: TODO
Work items for 2015-09-17:
Placeholder: TODO
Work items for 2015-09-24:
Final Placeholder: TODO
Work items:
Placeholder for un-targetted items: DONE
--
Libreoffice Docviewer Integration blueprint
https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/update-default-alarm-sound/+merge/267953 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app
Review: Approve It is working for me correctly. Previously I have volume of alarm tone set to low, which was causing these problems. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/update-default-alarm-sound/+merge/267953 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Blueprint libreoffice-docviewer-integration] Libreoffice Docviewer Integration blueprint
Blueprint changed by Stefano Verzegnassi: Work items changed: Work items for 2015-07-02: [bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects page breaks: DONE [bjoern-michaelsen] Study the API and report on capabilities that would be applicable to the LO viewer: INPROGRESS [verzegnassi-stefano] Add capability to detect page breaks to go to a particular page: BLOCKED [verzegnassi-stefano] Investigate tile rendering approach: INPROGRESS [mrqtros] Study the docviewer code: DONE [mrqtros] Study the LibreOffice Kit API: DONE [mrqtros] Implement error detection and recovery: POSTPONED Work items for 2015-07-09: [verzegnassi-stefano] Continue prototyping tile rendering approach (https://www.youtube.com/watch?v=GAmBJy9RpQk): INPROGRESS [mrqtros] Provide support to Stefano on writing/debugging/imroving performance of the tiled rendering code: INPROGRESS [bjoern-michaelsen] Publish blog post on the mobile LibreOffice viewer work: DONE [verzegnassi-stefano] Add PDF conversion support to the LOK plugin as a short-term alternative: DONE Work items for 2015-07-16: [verzegnassi-stefano] Implement PDF conversion support in DocViewer's QML code as a short-term alternative: POSTPONED [verzegnassi-stefano] Improve the logic that initialize the tiles: DONE [verzegnassi-stefano] Implementing the double buffered cache: DONE [bjoern-michaelsen] Investigate options/feasibility of LO in a click: TODO Work items for 2015-07-23: Placeholder: TODO [verzegnassi-stefano] Finish zoom implementation: INPROGRESS Work items for 2015-07-30: Placeholder: TODO Work items for 2015-08-06: Placeholder: TODO Work items for 2015-08-13: - [verzegnassi-stefano] Do a further check to ensure that all signals/slots works properly for the zooming feature: TODO + [verzegnassi-stefano] Do a further check to ensure that all signals/slots works properly for the zooming feature: DONE + [verzegnassi-stefano] Improve support for LO Impress documents: INPROGRESS [mrqtros] review LO plugin architecture and provide potential improvements: TODO [mrqtros] use SceneGraph for rendering: TODO Work items for 2015-08-20: Placeholder: TODO Work items for 2015-08-27: Placeholder: TODO Work items for 2015-09-03: Placeholder: TODO Work items for 2015-09-10: Placeholder: TODO Work items for 2015-09-17: Placeholder: TODO Work items for 2015-09-24: Final Placeholder: TODO Work items: Placeholder for un-targetted items: DONE -- Libreoffice Docviewer Integration blueprint https://blueprints.launchpad.net/ubuntu-docviewer-app/+spec/libreoffice-docviewer-integration -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2-upgrade into lp:ubuntu-calculator-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:221 http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/361/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3161 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3161/artifact/work/output/*zip*/output.zip SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/140 SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/83 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/361/rebuild -- https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2-upgrade/+merge/268046 Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2-upgrade into lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
