[Ubuntu-touch-coreapps-reviewers] [Bug 1482666] Re: Hidden files
No, on MX4 there is no place for SD card. I think that option for allowing to see hidden files isn't explained (there aren't any tutorial on screen). For now we must firstly unlock full access (or sth like that, can't check now - my screen is broken). -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1482666 Title: Hidden files Status in Ubuntu File Manager App: New Bug description: Hello, When I click to show hidden files, it not working. Option is 'ticked', but don't showing hidden files. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1482666/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-translate-owm into lp:ubuntu-weather-app/reboot
Review: Approve continuous-integration PASSED: Continuous integration, rev:103 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/223/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/193 SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/223 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/223/rebuild -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-translate-owm/+merge/268837 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-translate-owm into lp:ubuntu-weather-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-invalid-alarm-model into lp:ubuntu-clock-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:354 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/801/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/146 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/801/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-invalid-alarm-model/+merge/268838 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-invalid-alarm-model into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app. Commit message: Fixed non-notifyable warning shown when opening the edit alarm page. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Opening the edit alarm page used to result in the following warning shown, QQmlExpression: Expression file:///opt/click.ubuntu.com/com.ubuntu.clock/3.5.349/share/qml/alarm/EditAlarmPage.qml:271:17 depends on non-NOTIFYable properties: CustomAlarmSound::alarmSoundDirectory This was because the property alarmSoundDirectory did not notify QML of any changes since it supposed to be a constant variable. Fixed that minor issue. -- Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app. === modified file 'backend/modules/Clock/Utility/customalarmsound.h' --- backend/modules/Clock/Utility/customalarmsound.h 2015-08-22 21:19:54 + +++ backend/modules/Clock/Utility/customalarmsound.h 2015-08-23 10:02:01 + @@ -27,7 +27,8 @@ // READONLY Property to return the custom alarm sound directory path Q_PROPERTY( QString alarmSoundDirectory -READ alarmSoundDirectory) +READ alarmSoundDirectory +CONSTANT) public: CustomAlarmSound(QObject *parent = 0); -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-zoom into lp:ubuntu-docviewer-app/reboot
Mutex usage looks strange. It isn't common way to use it - declare local variable. Is it correct? -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-zoom/+merge/267982 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-lok-zoom into lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app
Review: Approve Lgtm. Clock Checklist passed -- https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181/+merge/266904 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Bug 1482666] Re: Hidden files
Hello, Maybe you are talking about SD card only. Can you confirm that it is not a file manager bug? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1482666 Title: Hidden files Status in Ubuntu File Manager App: New Bug description: Hello, When I click to show hidden files, it not working. Option is 'ticked', but don't showing hidden files. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1482666/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-autolanding/1/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3175/console FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-utopic-amd64-autolanding/1/console FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-autolanding/1/console -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181/+merge/266904 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:170 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/5/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3176/console FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-utopic-amd64-ci/5/console FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/5/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/5/rebuild -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency/+merge/268851 Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-invalid-alarm-model into lp:ubuntu-clock-app
Review: Approve It is working for me correctly. Unfortunately time needed to run is very high. You did everything what was needed according to checklist. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-invalid-alarm-model/+merge/268838 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot. Commit message: Added missing build dependency (libreofficekit-dev) Requested reviews: Ubuntu Document Viewer Developers (ubuntu-docviewer-dev) For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency/+merge/268851 Added missing build dependency (libreofficekit-dev) -- Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-deb-build-dependency into lp:ubuntu-docviewer-app/reboot. === modified file 'debian/control' --- debian/control 2015-02-23 12:49:52 + +++ debian/control 2015-08-23 14:37:54 + @@ -18,7 +18,8 @@ qtdeclarative5-qtquick2-plugin, qtdeclarative5-private-dev, qtbase5-private-dev, - qtdeclarative5-test-plugin + qtdeclarative5-test-plugin, + libreofficekit-dev Standards-Version: 3.9.6 Section: misc Homepage: https://launchpad.net/ubuntu-docviewer-app -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181/+merge/266904 -- Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181 into lp:ubuntu-docviewer-app/reboot
Review: Approve That's ok! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-merged-trunk-revno-181/+merge/266904 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:352 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/803/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/148/console Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/803/rebuild -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
Review: Approve continuous-integration -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
Review: Approve Looks ok to me. I think we could do not update changelog with such small issue. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-non-notifyable-warning/+merge/268846 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app
The proposal to merge lp:~nik90/ubuntu-clock-app/add-world-city-manual-test into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-world-city-manual-test/+merge/268844 -- Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app
Diff comments:
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt2015-06-14 23:34:29 +
+++ CMakeLists.txt2015-07-05 19:26:31 +
@@ -20,7 +20,7 @@
set(AUTOPILOT_DIR reminders)
set(APP_HARDCODE reminders)
set(MAIN_QML ${APP_HARDCODE}.qml)
-set(EXEC reminders %u)
+set(EXEC reminders %u -d JobQueue)
I think this is really useful for debugging issues that happen when syncing to
evernote. Should give us better logs from users.
set(UBUNTU_MANIFEST_PATH manifest.json.in CACHE INTERNAL Relative path to
the manifest file)
set(ACCOUNT_ICON_DIR ${CMAKE_INSTALL_DATADIR}/icons/hicolor/32x32/apps)
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml 2015-06-22 10:53:02 +
+++ src/app/qml/reminders.qml 2015-07-05 19:26:31 +
@@ -371,32 +371,35 @@
appId: root.applicationName + _reminders
onNotificationsChanged: {
-print(PushClient notification:, notifications)
-var notification = JSON.parse(notifications)[payload];
-
-if (notification[userId] != UserStore.userId) { // Yes, we
want type coercion here.
-console.warn(user mismatch:, notification[userId], !=,
UserStore.userId)
-return;
-}
-
-switch(notification[reason]) {
-case update:
-print(Note updated on server:, notification[guid])
-if (NotesStore.note(notification[guid]) === null) {
+print(Received PushClient notifications:, notifications.length)
+for (var i = 0; i notifications.length; i++) {
+print(notification, i, :, notifications[i])
+var notification = JSON.parse(notifications[i])[payload];
+
+if (notification[userId] != UserStore.userId) { // Yes, we
want type coercion here.
Push Notifications ans multiple accounts is not really tested yet. In any case,
this place is ok, as we only want to react to push notifications for the
currently logged user. The push-helper binary could/should be improved for
multiuser instead.
+console.warn(user mismatch:, notification[userId],
!=, UserStore.userId)
+return;
+}
+
+switch(notification[reason]) {
+case update:
+print(Note updated on server:, notification[guid])
+if (NotesStore.note(notification[guid]) === null) {
+NotesStore.refreshNotes();
+} else {
+NotesStore.refreshNoteContent(notification[guid]);
+}
+break;
+case create:
+print(New note appeared on server:,
notification[guid])
NotesStore.refreshNotes();
-} else {
-NotesStore.refreshNoteContent(notification[guid]);
+break;
+case notebook_update:
+NotesStore.refreshNotebooks();
+break;
+default:
+console.warn(Unhandled push notification:,
notification[reason])
}
-break;
-case create:
-print(New note appeared on server:, notification[guid])
-NotesStore.refreshNotes();
-break;
-case notebook_update:
-NotesStore.refreshNotebooks();
-break;
-default:
-console.warn(Unhandled push notification:,
notification[reason])
}
}
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-writeback-issue/+merge/263848
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:711 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1229/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/226 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1229/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation/+merge/268867 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:708 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1228/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/225 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1228/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app
Gary.Wang has proposed merging
lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into
lp:ubuntu-calendar-app.
Commit message:
Performance tunning for page transition.
Page Transition between different views will cause dynamic
creation(Qt.ResolvedUrl)
for qml object back and forth.Using Qt.CreateComponent for dynamic creation for
1st
time and reuse exsiting obj without re-creating.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation/+merge/268867
Performance tunning for page transition.
Page Transition between different views will cause dynamic
creation(Qt.ResolvedUrl)
for qml object back and forth.Using Qt.CreateComponent for dynamic creation for
1st
time and reuse exsiting obj without re-creating.
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into
lp:ubuntu-calendar-app.
=== modified file 'AgendaView.qml'
--- AgendaView.qml 2015-02-22 10:18:16 +
+++ AgendaView.qml 2015-08-24 03:08:58 +
@@ -60,7 +60,8 @@
commonHeaderActions.newEventAction,
commonHeaderActions.showCalendarAction,
commonHeaderActions.reloadAction,
-commonHeaderActions.syncCalendarAction
+commonHeaderActions.syncCalendarAction,
+commonHeaderActions.settingsAction
]
EventListModel {
=== modified file 'AllDayEventComponent.qml'
--- AllDayEventComponent.qml 2015-06-16 09:18:21 +
+++ AllDayEventComponent.qml 2015-08-24 03:08:58 +
@@ -40,6 +40,9 @@
for(var i = 0 ; i items.length ; ++i) {
var event = items[(i)];
if( event event.allDay ) {
+
+console.log(event.startDateTime, event.startDateTime,event.endDateTime,event.endDateTime);
+
for(var d = event.startDateTime; d event.endDateTime; d = d.addDays(1)) {
var key = Qt.formatDateTime(d, dd-MMM-);
if( !(key in map)) {
=== modified file 'ContactChoicePopup.qml'
--- ContactChoicePopup.qml 2014-09-20 10:45:35 +
+++ ContactChoicePopup.qml 2015-08-24 03:08:58 +
@@ -94,7 +94,7 @@
objectName: contactPopoverList
width: parent.width
model: contactModel
-height: units.gu(30)
+height: units.gu(15)
clip: true
delegate: Standard{
objectName: contactPopoverList%1.arg(index)
=== modified file 'DayView.qml'
--- DayView.qml 2015-02-18 19:27:20 +
+++ DayView.qml 2015-08-24 03:08:58 +
@@ -49,7 +49,8 @@
commonHeaderActions.newEventAction,
commonHeaderActions.showCalendarAction,
commonHeaderActions.reloadAction,
-commonHeaderActions.syncCalendarAction
+commonHeaderActions.syncCalendarAction,
+commonHeaderActions.settingsAction
]
contents: Label {
=== modified file 'EventActions.qml'
--- EventActions.qml 2015-04-13 19:40:48 +
+++ EventActions.qml 2015-08-24 03:08:58 +
@@ -26,6 +26,7 @@
property alias newEventAction: _newEventAction
property alias showCalendarAction: _showCalendarAction
property alias syncCalendarAction: _syncCalendarAction
+property alias settingsAction: _settingsAction
Action {
id: _syncCalendarAction
@@ -63,4 +64,14 @@
pageStack.currentPage.collectionUpdated.connect(eventModel.delayedApplyFilter);
}
}
+
+Action{
+id: _settingsAction
+objectName: settingsbutton
+iconName: settings
+text: i18n.tr(Settings)
+onTriggered: {
+pageStack.push(Qt.resolvedUrl(Settings.qml));
+}
+}
}
=== modified file 'EventBubble.qml'
--- EventBubble.qml 2015-01-22 19:34:59 +
+++ EventBubble.qml 2015-08-24 03:08:58 +
@@ -221,8 +221,8 @@
anchors.fill: parent
drag.target: isLiveEditing ? infoBubble : null
drag.axis: Drag.YAxis
-drag.minimumY: flickable.y
-drag.maximumY: flickable.contentHeight - infoBubble.height
+drag.minimumY: flickable === null? 0: flickable.y
+drag.maximumY: flickable === null? 0 :flickable.contentHeight - infoBubble.height
onReleased: parent.Drag.drop()
onClicked: {
if( isLiveEditing ) {
=== modified file 'EventListModel.qml'
--- EventListModel.qml 2015-08-02 03:59:08 +
+++ EventListModel.qml 2015-08-24 03:08:58 +
@@ -44,7 +44,7 @@
var newObject = Qt.createQmlObject(import QtQuick 2.3; Timer {interval: 1000; running: true; repeat: false;},
eventModel, EventListMode.qml);
newObject.onTriggered.connect( function(){
-var items = getItems(eventModel.startPeriod, eventModel.endPeriod);
+var items = itemsByTimePeriod(eventModel.startPeriod, eventModel.endPeriod);
Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app
Review: Approve continuous-integration PASSED: Continuous integration, rev:710 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1230/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/227 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1230/rebuild -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/optimization_tab_change/+merge/268873 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers More help : https://help.launchpad.net/ListHelp
[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app
Gary.Wang has proposed merging
lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into
lp:ubuntu-calendar-app.
Commit message:
Tab change will cause dynamic creation(Qt.ResolvedUrl) for qml object back and
forth.Using Qt.CreateComponent for dynamic creation for the first time and
reuse existing obj without re-creating.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/optimization_tab_change/+merge/268873
Tab change will cause dynamic creation(Qt.ResolvedUrl) for qml object back and
forth.Using Qt.CreateComponent for dynamic creation for the first time and
reuse existing obj without re-creating.
--
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into
lp:ubuntu-calendar-app.
=== modified file 'ContactChoicePopup.qml'
--- ContactChoicePopup.qml 2014-09-20 10:45:35 +
+++ ContactChoicePopup.qml 2015-08-24 05:15:53 +
@@ -94,7 +94,7 @@
objectName: contactPopoverList
width: parent.width
model: contactModel
-height: units.gu(30)
+height: units.gu(15)
clip: true
delegate: Standard{
objectName: contactPopoverList%1.arg(index)
=== modified file 'EventBubble.qml'
--- EventBubble.qml 2015-01-22 19:34:59 +
+++ EventBubble.qml 2015-08-24 05:15:53 +
@@ -221,8 +221,8 @@
anchors.fill: parent
drag.target: isLiveEditing ? infoBubble : null
drag.axis: Drag.YAxis
-drag.minimumY: flickable.y
-drag.maximumY: flickable.contentHeight - infoBubble.height
+drag.minimumY: flickable === null? 0: flickable.y
+drag.maximumY: flickable === null? 0 :flickable.contentHeight - infoBubble.height
onReleased: parent.Drag.drop()
onClicked: {
if( isLiveEditing ) {
=== modified file 'EventListModel.qml'
--- EventListModel.qml 2015-08-02 03:59:08 +
+++ EventListModel.qml 2015-08-24 05:15:53 +
@@ -44,7 +44,7 @@
var newObject = Qt.createQmlObject(import QtQuick 2.3; Timer {interval: 1000; running: true; repeat: false;},
eventModel, EventListMode.qml);
newObject.onTriggered.connect( function(){
-var items = getItems(eventModel.startPeriod, eventModel.endPeriod);
+var items = itemsByTimePeriod(eventModel.startPeriod, eventModel.endPeriod);
if( isLoading == true items.length === 0) {
isLoading = false;
modelChanged();
@@ -53,7 +53,6 @@
});
}
-
onModelChanged: {
isLoading = false
if(listeners === undefined){
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2015-08-04 02:18:52 +
+++ NewEvent.qml 2015-08-24 05:15:53 +
@@ -255,6 +255,7 @@
model.saveItem(event);
pageStack.pop();
+
root.eventAdded(event);
}
}
=== modified file 'YearView.qml'
--- YearView.qml 2015-02-18 19:27:20 +
+++ YearView.qml 2015-08-24 05:15:53 +
@@ -29,6 +29,12 @@
Keys.forwardTo: [yearPathView]
+function refreshCurrentYear(year) {
+currentYear = year;
+var yearViewDelegate = yearPathView.currentItem.item;
+yearViewDelegate.refresh();
+}
+
Action {
id: calendarTodayAction
objectName:todaybutton
@@ -85,7 +91,7 @@
scrollMonth: 0;
isCurrentItem: index == yearPathView.currentIndex
-year: (yearViewPage.currentYear + yearPathView.indexType(index))
+year: (currentYear + yearPathView.indexType(index))
anchors.fill: parent
}
=== modified file 'YearViewDelegate.qml'
--- YearViewDelegate.qml 2014-11-29 09:40:53 +
+++ YearViewDelegate.qml 2015-08-24 05:15:53 +
@@ -18,6 +18,19 @@
model: 12 /* months in a year */
onYearChanged: {
+refresh();
+}
+
+//scroll in case content height changed
+onHeightChanged: {
+yearView.positionViewAtIndex(scrollMonth, GridView.Beginning);
+}
+
+Component.onCompleted: {
+yearView.positionViewAtIndex(scrollMonth, GridView.Beginning);
+}
+
+function refresh() {
scrollMonth = 0;
var today = new Date();
if(year == today.getFullYear()) {
@@ -26,15 +39,6 @@
yearView.positionViewAtIndex(scrollMonth, GridView.Beginning);
}
-//scroll in case content height changed
-onHeightChanged: {
-yearView.positionViewAtIndex(scrollMonth, GridView.Beginning);
-}
-
-Component.onCompleted: {
-yearView.positionViewAtIndex(scrollMonth, GridView.Beginning);
-}
-
Connections{
target: yearPathView
onScrollUp: {
=== modified file 'calendar.qml'
--- calendar.qml 2015-06-11 12:29:28 +
+++
