from:"Stefano Verzegnassi"

I hope managers will decide to fix these problems with unmaintained projects. 
For now, let's suppose there has been a tacit approval.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into lp:ubuntu-terminal-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into lp:ubuntu-terminal-app

The proposal to merge lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 
into lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588/+merge/290031
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into lp:ubuntu-terminal-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation/+merge/287990
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into lp:ubuntu-terminal-app

The proposal to merge lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 
into lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892/+merge/290129
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1559892 into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app

2016-04-20 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app

2016-04-20 Thread Stefano Verzegnassi

I will mind to open a bug at ubuntu-ui-toolkit. I'm really missing the old 
PageHeadState behaviour too... :/
Thanks again for the review!
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into lp:ubuntu-docviewer-app

2016-04-17 Thread Stefano Verzegnassi

The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 
into lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into lp:ubuntu-docviewer-app

2016-04-14 Thread Stefano Verzegnassi

The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 
into lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app

UITK docs are not very clear on what to do when a Page have multiple
PageHeaders.
I used the clock-app code (more specifically, the alarm page) as reference,
since you already completed the migration to UC 1.3 at the time.

I'm not sure about the use of QML Loaders, since it would look a bit "dirty" to
me.
Well, it's not required to have the other headers loaded by default - that's
for sure - but at the moment we still have some logic inside the headers and
I'd like to avoid to add further bindings here and there.

However, I just gave a second check to the QtQuick docs, and my fix is actually
wrong.

A not-visible Item does not receive mouse inputs, but it's still able to
receive keyboard events and grab the focus.[1]
We rather need to set 'enabled: visible' in order to prevent that.

A small question:

With the older PageHeadState, the content of an header was unloaded as long as
the Page didn't change to that specific state. With the newer PageHeader, a
different approach has been used, and anything can be customized as the single
developer needs.

Anyway, there are a few behaviours that should be forced, and an inactive (i.e.
not visible) header should not receive any event by default.
Do you think it's worth to report a bug to the UITK project?

[1] http://doc.qt.io/qt-5/qquickitem.html#visible-prop
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into
lp:ubuntu-docviewer-app.

--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into lp:ubuntu-docviewer-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into 
lp:ubuntu-docviewer-app.

Commit message:
PdfViewer - Presentation mode: use a single-tap gesture (instead of double tap) 
to show/hide header

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1545142 in Ubuntu Document Viewer App: "Hard to guess how to close 
'presentation mode'"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1545142

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142/+merge/291293

PdfViewer - Presentation mode: use a single-tap gesture (instead of double tap) 
to show/hide header
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1545142 into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/pdfView/PdfPresentation.qml'
--- src/app/qml/pdfView/PdfPresentation.qml	2016-03-26 18:44:53 +
+++ src/app/qml/pdfView/PdfPresentation.qml	2016-04-07 18:11:47 +
@@ -85,7 +85,7 @@
 
 MouseArea {
 anchors.fill: parent
-onDoubleClicked: pdfPage.header.visible = !pdfPage.header.visible
+onClicked: pdfPage.header.visible = !pdfPage.header.visible
 
 // Hide mouse curson when there's no on-going mouse event
 hoverEnabled: true

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app

Review: Approve

LGTM, thanks!
-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app

Review: Needs Fixing

As to the colors, everything is okay except for a typo (see the diff comment).

Sidebar color is not set and it's shown as white, when "#f7f7f7" (porcelain) 
should be used instead.

Diff comments:

> 
> === modified file 'src/app/qml/components/PlacesSidebar.qml'
> --- src/app/qml/components/PlacesSidebar.qml  2016-02-02 00:35:27 +
> +++ src/app/qml/components/PlacesSidebar.qml  2016-04-06 16:06:20 +
> @@ -25,7 +25,7 @@
>  id: root
>  
>  //color: Qt.rgba(0.5,0.5,0.5,0.3)
> -color: "#F5F5F5"
> +color: UbuntuColors.Porcelain

This should be "UbuntuColors.porcelain" (the 'p' is lower case).

>  width: expanded ? (collapsed ? units.gu(8) : units.gu(22)) : 0
>  
>  property bool collapsed: collapsedSidebar


-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1554621 into lp:ubuntu-filemanager-app

Review: Needs Fixing

I still have to have a better look at the app color palette, anyway there's 
surely something which needs to be fixed:

$ grep -r "ubuntu-sdk" .
./manifest.json.in:"framework": "ubuntu-sdk-14.10",

The app is still using an old framework version.

Please update it to "ubuntu-sdk-15.04.4", since that's the only target which 
provides the new colors (e.g. slate, inkstone, graphite, etc.)
-- 
https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1554621/+merge/291133
Your team Ubuntu File Manager Developers is requested to review the proposed 
merge of lp:~popey/ubuntu-filemanager-app/fix-1554621 into 
lp:ubuntu-filemanager-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into lp:ubuntu-docviewer-app

2016-04-06 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into 
lp:ubuntu-docviewer-app.

Commit message:
Fixed wrong alignment of the peer picker in SharePage.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1566903 in Ubuntu Document Viewer App: "No margin between content peers 
and page header"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1566903

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142

Fixed wrong alignment of the peer picker in SharePage.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/documentPage/SharePage.qml'
--- src/app/qml/documentPage/SharePage.qml	2016-03-03 13:17:53 +
+++ src/app/qml/documentPage/SharePage.qml	2016-04-06 16:29:43 +
@@ -30,6 +30,7 @@
 
 ContentPeerPicker {
 id: picker
+anchors.topMargin: sharePage.header.height
 
 contentType: ContentType.Documents
 handler: ContentHandler.Share

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into lp:ubuntu-docviewer-app

2016-04-06 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into 
lp:ubuntu-docviewer-app.

Commit message:
Fixed the keyboard input issues in DocumentsPage, caused by the migration to 
the new PageHeader component. In particular:
* OSK visible on app start-up
* It was possible to type chars into the searchField (and then filter the 
document entries out) even if the searchFiled was not visible
* OSK still visible after the search header was closed (through the 'Cancel' 
button)

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1566899 in Ubuntu Document Viewer App: "OSK appears on app startup"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1566899
  Bug #1566902 in Ubuntu Document Viewer App: "OSK does not not automatically 
hide after pressing the cancel button"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1566902

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard/+merge/291139

Fixed the keyboard input issues in DocumentsPage, caused by the migration to 
the new PageHeader component. In particular:
* OSK visible on app start-up
* It was possible to type chars into the searchField (and then filter the 
document entries out) even if the searchFiled was not visible
* OSK still visible after the search header was closed (through the 'Cancel' 
button)
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-documents-page-keyboard into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/documentPage/DocumentPage.qml'
--- src/app/qml/documentPage/DocumentPage.qml	2016-03-03 13:17:53 +
+++ src/app/qml/documentPage/DocumentPage.qml	2016-04-06 16:24:27 +
@@ -33,6 +33,17 @@
 docModel.checkDefaultDirectories();
 }
 
+Component.onCompleted: {
+// WORKAROUND: We need to explicitely force the focus in order to avoid
+// that the TextField in DocumentPageSearchHeader is focused even if that
+// header is not visible.
+// With the deprecated UITK 1.2 PageHeadState this was not required since
+// the header content was "loaded" by demand.
+// With the new UITK 1.3 PageHeader, all the headers are always initialized,
+// so we need to put some extra care.
+scrollView.forceActiveFocus()
+}
+
 ScrollView {
 id: scrollView
 anchors.fill: parent
@@ -69,6 +80,20 @@
 DocumentPageSearchHeader {
 id: searchHeader
 visible: !mainView.pickMode && !view.ViewItems.selectMode && documentPage.searchMode
+
+onVisibleChanged: {
+// WORKAROUND: We need to explicitely force the focus in order to avoid
+// that the TextField in DocumentPageSearchHeader is focused even if that
+// header is not visible.
+// With the deprecated UITK 1.2 PageHeadState this was not required since
+// the header content was "loaded" by demand.
+// With the new UITK 1.3 PageHeader, all the headers are always initialized,
+// so we need to put some extra care.
+if (visible)
+textField.forceActiveFocus()
+else
+scrollView.forceActiveFocus()
+}
 }
 
 DocumentPageSelectionModeHeader {

=== modified file 'src/app/qml/documentPage/DocumentPageSearchHeader.qml'
--- src/app/qml/documentPage/DocumentPageSearchHeader.qml	2016-03-30 10:43:02 +
+++ src/app/qml/documentPage/DocumentPageSearchHeader.qml	2016-04-06 16:24:27 +
@@ -25,6 +25,8 @@
 property var view: parent.view
 property Page parentPage: parent
 
+property alias textField: searchField
+
 trailingActionBar {
 anchors.rightMargin: 0
 delegate: TextualButtonStyle {}

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into lp:ubuntu-docviewer-app

2016-04-05 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2/+merge/290962
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into lp:ubuntu-terminal-app

2016-04-05 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app has been updated.

Description changed to:

*** REQUIRES OTA-10 ***

Added a context property which allows terminal-app to know whether a keyboard 
or a mouse is attached to the device.

This is required to workaround a gap in the Ubuntu UI Toolkit, which makes 
impossible to use some of the new convergence features (e.g. bottom edge) in 
desktop mode.
This also allows us to automatically hide some components which are only useful 
in a context where only a touchscreen is available as input device.

Hopefully, this patch shouldn't be required anymore with OTA-11, when the 
support for devices detection will be available through UITK.

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into lp:ubuntu-docviewer-app

2016-04-05 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into 
lp:ubuntu-docviewer-app.

Commit message:
* Bumped framework to 15.04.4
* Fixed broken night mode (i.e. app background is still white when the mode is 
enabled)
* Updated changelog

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2/+merge/290962

* Bumped framework to 15.04.4
* Fixed broken night mode (i.e. app background is still white when the mode is 
enabled)
* Updated changelog
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1.2 into 
lp:ubuntu-docviewer-app.
=== modified file 'click/manifest.json.in'
--- click/manifest.json.in	2016-02-11 18:03:07 +
+++ click/manifest.json.in	2016-04-05 09:34:25 +
@@ -2,7 +2,7 @@
 "name": "com.ubuntu.docviewer",
 "title": "Document Viewer",
 "description": "Document Viewer application for Ubuntu devices",
-"framework": "ubuntu-sdk-15.04.3",
+"framework": "ubuntu-sdk-15.04.4",
 "architecture": "@CLICK_ARCH@",
 "icon": "@ICON@",
 "hooks": {

=== modified file 'debian/changelog'
--- debian/changelog	2016-02-11 18:03:07 +
+++ debian/changelog	2016-04-05 09:34:25 +
@@ -1,5 +1,7 @@
 ubuntu-docviewer-app (2.1) vivid; urgency=medium
 
+  * Fixed an issue with the documents list not updating the model entries (LP: #1483218)
+  * New theming/UI components in OTA-10 fully supported (LP: #1551259)
   * LibreOffice viewer: added support for spreadsheet documents with multiple sheets (LP: #1537755)
   * LibreOffice viewer: limited zoom value to a minimum/maximum value (LP: #1501424)
   * LibreOffice viewer: added a double-tap-to-zoom gesture (LP: #1541582)

=== modified file 'src/app/qml/ubuntu-docviewer-app.qml'
--- src/app/qml/ubuntu-docviewer-app.qml	2016-03-31 17:41:13 +
+++ src/app/qml/ubuntu-docviewer-app.qml	2016-04-05 09:34:25 +
@@ -180,6 +180,15 @@
 filter.property: "name"
 }
 
+// WORKAROUND: mainView backgroundColor is an alias for the window color, and does not
+// refer to a child QML Rectangle anymore. This breaks our night mode shader; for that
+// reason we need to re-add that QML Rectangle.
+Rectangle {
+anchors.fill: parent
+color: mainView.backgroundColor
+visible: nightModeEnabled
+}
+
 PageStack {
 id: pageStack
 }

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into lp:ubuntu-docviewer-app

2016-03-31 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page/+merge/290170
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into lp:ubuntu-docviewer-app

2016-03-30 Thread Stefano Verzegnassi

> Haha, are you enjoyed deleting this code? ;)
Ahah, you can be sure of it! :)

> Why did you switch it [PageHeader.flickable] off? Just for information.
I was having trouble in setting the anchors for the content of the 
ViewerPage[1], and the LibreOffice Viewer had strange bindings that were 
causing a continuous flickering and reloading of the document content, every 
time the header was changing its status (i.e. visible/hidden).

I spent some time on it again (after you review), and now it seems to behave 
correctly. Pushing the new commit...

[1] We load LOViewPage asynchronously, but the loading logic is placed in a 
different file.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page/+merge/290048
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 into lp:ubuntu-docviewer-app

2016-03-30 Thread Stefano Verzegnassi

> Should you remove FIXME? Is it wrapping itself now?
Yes, it wraps the text by default (it's limited to maximum one line of text 
though).

I kept the comment because we may want to reserve two lines for the document 
name in future, however the visual result is not so good (i.e. text is - of 
course - not aligned with other ListItemLayout which use only one line for 
title).

See https://imgur.com/bpf6cnE

Anyway, that bug in UITK has been fixed now, so I'm going to update that 
comment.

Thanks Roman for pointing it out! :)
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50/+merge/288555
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into lp:ubuntu-docviewer-app

2016-03-30 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview/+merge/290172
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into lp:ubuntu-docviewer-app

2016-03-27 Thread Stefano Verzegnassi

Yes, I'm moving all the pages to the new approach (there are already a few MPs 
for them).

Thanks for the review!
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview/+merge/289482
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into lp:ubuntu-docviewer-app

2016-03-26 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into 
lp:ubuntu-docviewer-app with 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 as a 
prerequisite.

Commit message:
Pdf viewer:
* Removed 'search' action (unused)
* Fixed keyboard hooks in the 'GoTo' dialog
* Fixed presentation mode color palette
* Use ScrollView component


Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview/+merge/290172

Pdf viewer:
* Removed 'search' action (unused)
* Fixed keyboard hooks in the 'GoTo' dialog
* Fixed presentation mode color palette
* Use ScrollView component

-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-pdfview into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/pdfView/PdfContentsPage.qml'
--- src/app/qml/pdfView/PdfContentsPage.qml	2016-03-26 18:44:11 +
+++ src/app/qml/pdfView/PdfContentsPage.qml	2016-03-26 18:44:11 +
@@ -24,7 +24,7 @@
 objectName: "pdfcontents"
 
 // this property will have to be removed when bug #1341671 will be fixed.
-property string testProperty: "for page name issue"  
+property string testProperty: "for page name issue"
 
 header: PageHeader {
 // TRANSLATORS: "Contents" refers to the "Table of Contents" of a PDF document.
@@ -50,74 +50,73 @@
 view.positionViewAtIndex(i, ListView.Center);
 }
 
-ListView {
-id: view
-objectName: "view"
+ScrollView {
 anchors.fill: parent
-clip: true
-
-model: poppler.tocModel
-
-delegate: ListItem {
-id: delegate
-objectName: "delegate" + index
-
-onClicked: {
-pdfView.positionAtIndex(model.pageIndex);
-contentsBottomEdge.collapse();
-}
-
-// Highlighted property of ListItem is read-only. In order to
-// provide an highlight for the current page, we need to duplicate
-// the overlay.
-Rectangle {
-anchors.fill: parent
-color: Qt.rgba(0, 0, 0, 0.05)
-visible: view.currentIndex == model.index
-}
-
-/* UITK 1.3 spec: Three slot layout (A-B-C)   */
-//  
-// |  | |   |
-// |   A  |  B  | C |
-// |__|__ __|___|
-//
-ListItemLayout {
-id: listItemLayout
-objectName: "listItemLayout" + index
-anchors.fill: parent
-anchors.leftMargin: model.level * units.gu(4)
-
-/* UITK 1.3 specs: Slot A */
-title {
-text: model.title
-elide: Text.ElideRight
-//font.weight: model.level == 0 ? Font.DemiBold : Font.Normal
-//color: (model.level == 0) ? UbuntuColors.midAubergine
-//  : theme.palette.normal.backgroundText
-}
-
-/* UITK 1.3 specs: Slot B */
-Icon {
-SlotsLayout.position: SlotsLayout.Trailing
-width: units.gu(2); height: width
-name: "tick"
-color: UbuntuColors.green
-visible: view.currentIndex == model.index
-}
-
-/* UITK 1.3 specs: Slot C */
-Label {
-objectName: "pageindex"
-SlotsLayout.position: SlotsLayout.Last
-text: model.pageIndex + 1
-//font.weight: model.level == 0 ? Font.DemiBold : Font.Normal
-//color: (model.level == 0) ? UbuntuColors.midAubergine
-//  : theme.palette.normal.backgroundText
+
+ListView {
+id: view
+objectName: "view"
+anchors.fill: parent
+clip: true
+
+model: poppler.tocModel
+
+delegate: ListItem {
+id: delegate
+objectName: "delegate" + index
+
+property bool __isCurrentIndex: view.currentIndex == model.index
+
+onClicked: {
+pdfView.positionAtIndex(model.pageIndex);
+contentsBottomEdge.collapse();
+}
+
+// Highlighted property of ListItem is read-only. In order to
+// provide an highlight for the current page, we need to duplicate
+

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into lp:ubuntu-docviewer-app

2016-03-26 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page into 
lp:ubuntu-docviewer-app.

Commit message:
* Use PageHeader and ScrollView in documents page

* Removed width limitation of units.gu(80) from documents page

* Code refactoring

* Use a 'Label' instead of the SD card icon.
Sure, it's a bit ugly but it has no alignment issue. In any case, we should 
replace the current documents view soon.

* Fixed a few typos in the pickMode header (i.e. we were pushing the wrong file 
through content-hub)

* UI changes to headers:
--- Search header: use search header style recently introduced in unity8-dash
--- Pick mode header: use textual buttons


Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1523114 in Ubuntu Document Viewer App: "[DocumentsPage] SD card icon not 
aligned in ListItemLayout"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1523114

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page/+merge/290170

* Use PageHeader and ScrollView in documents page

* Removed width limitation of units.gu(80) from documents page

* Code refactoring

* Use a 'Label' instead of the SD card icon.
Sure, it's a bit ugly but it has no alignment issue. In any case, we should 
replace the current documents view soon.

* Fixed a few typos in the pickMode header (i.e. we were pushing the wrong file 
through content-hub)

* UI changes to headers:
--- Search header: use search header style recently introduced in unity8-dash
--- Pick mode header: use textual buttons


-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-documents-page 
into lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/documentPage/DeleteFileDialog.qml'
--- src/app/qml/documentPage/DeleteFileDialog.qml	2015-10-23 11:19:19 +
+++ src/app/qml/documentPage/DeleteFileDialog.qml	2016-03-26 18:25:35 +
@@ -1,17 +1,17 @@
 /*
-  Copyright (C) 2013-2015 Stefano Verzegnassi
+  Copyright (C) 2013-2016 Stefano Verzegnassi
 
-This program is free software: you can redistribute it and/or modify
+  This program is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License 3 as published by
   the Free Software Foundation, either version 3 of the License, or
   (at your option) any later version.
 
-This program is distributed in the hope that it will be useful,
+  This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
   GNU General Public License for more details.
 
-You should have received a copy of the GNU General Public License
+  You should have received a copy of the GNU General Public License
   along with this program. If not, see http://www.gnu.org/licenses/.
 */
 
@@ -24,7 +24,7 @@
 id: deleteFileDialog
 
 property string path
-property var selectedIndices: viewLoader.item.ViewItems.selectedIndices;
+property var selectedIndices: view.ViewItems.selectedIndices
 property int deleteCount: selectedIndices.length
 
 // WORKAROUND: This property is only used when the dialog is opened from a
@@ -73,7 +73,7 @@
 docModel.rm(folderModel.get(selectedIndices[i]).path);
 }
 
-viewLoader.item.cancelSelection();
+view.cancelSelection();
 }
 
 PopupUtils.close(deleteFileDialog)

=== modified file 'src/app/qml/documentPage/DocumentListDelegate.qml'
--- src/app/qml/documentPage/DocumentListDelegate.qml	2015-12-29 17:13:25 +
+++ src/app/qml/documentPage/DocumentListDelegate.qml	2016-03-26 18:25:35 +
@@ -74,14 +74,15 @@
+ listItemLayout.title.baselineOffset - baselineOffset
 }
 
-Icon {
+Label {
 id: externalStorageLabel
-anchors.right: parent.right
-width: units.gu(2); height: width
-name: "sdcard-symbolic"
+text: i18n.tr("SD card")
+textSize: Label.Small
+color:  theme.palette.normal.backgroundSecondaryText
 visible: model.isFromExternalStorage
 y: listItemLayout.mainSlot.y + listItemLayout.subtitle.y
+ listItemLayout.subtitle.baselineOffset - baselineOffset
+anchors.right: parent.right
 }
 }
 }

=== modified file 'src/app/qml/documentPage/DocumentListView.qml'
--- src/app/qml/documentPage/DocumentListView.qml	2016-02-10 17:46:14 +
+++ src/app/qml/documentPage/DocumentListView.qml	2016-03-26

[Ubuntu-touch-coreapps-reviewers] [Bug 1559724] Re: [shorts] If night mode is enabled, the app background is still white

Hey Roman, I can think at three alternatives:

1) Set MainView.backgroundColor according to the nightMode status.

MainView {
backgroundColor: nightModeEnabled ? "black" : "white"
}

I'm almost sure you'll also have to disable auto-theming (i.e. UITK
switches the app theme between Ambiance and SuruDark according to the
set background color).

2) Add a QML Rectangle to the MainView, in order to restore the previous
code. Anyway, you'll lose the performance boost mentioned in the bug
report above.

MainView {
id: root

Rectangle {
anchors.fill: parent
color: root.backgroundColor
}
}

3) Don't use a shader on the whole view, but use individual shaders on
each QML Image (if required). Set the app theme according to the current
mode.

MainView {
property bool nightModeEnabled: true

theme.name: nightModeEnabled ? "Ubuntu.Components.Themes.SuruDark" :
"Ubuntu.Components.Themes.Ambiance"

ArticleItem {
Image {
[...]

layer.enabled: nightModeEnabled
layer.item: NightModeShader {}
}
}
}  



I'd probably choose 2), which is faster to implement and safer (i.e. less 
unexpected issues - that's how it used to work until now).
This is something we should fix in DocViewer too, but I'd probably move to a 
different solution (the first one) in a longer term.

I guess the shader usage (currently it's used only in DocViewer and Shorts) 
hasn't been considered by the SDK team when they did that change. So yes, we 
should fix it.
However, it could be worth to ask them which solution they would suggest (and 
eventually suggest a similar feature for the next UITK release).

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1559724

Title:
  [shorts] If night mode is enabled, the app background is still white

Status in Ubuntu Shorts App:
  Confirmed

Bug description:
  I think this is due to the new palette in the SDK landing in rc-
  proposed. The app background is white, which defeats the purpose of
  night mode. Also, articles are impossible to read for this reason.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1559724/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1377638] Re: [All Apps] Core apps should use the new splash screen features

** Changed in: ubuntu-terminal-app
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail, Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1377638

Title:
  [All Apps] Core apps should use the new splash screen features

Status in Dekko:
  Fix Released
Status in Dropping Letters:
  New
Status in FlashBack:
  New
Status in Ubuntu Music App:
  Fix Released
Status in Sudoku App:
  Fix Committed
Status in Ubuntu Calculator App:
  Fix Released
Status in Ubuntu Calendar App:
  Fix Released
Status in Ubuntu Clock App:
  Fix Released
Status in Ubuntu Document Viewer App:
  Fix Released
Status in Ubuntu File Manager App:
  Triaged
Status in Ubuntu Shorts App:
  Fix Released
Status in Ubuntu Terminal App:
  Fix Released
Status in Ubuntu UX:
  Fix Committed
Status in Ubuntu Weather App:
  Fix Released

Bug description:
  Unity8 has added some new splash screen customization features. At the
  moment all the core apps displays a default splash which is the app
  icon shown in the center of a black background.

  As of reporting this bug, I have noticed that AddressBook,
  SystemSettings app use the new splash screen features.

  Here is a sample MP from the addressbook-app which uses the new splash
  screen features, https://code.launchpad.net/~renatofilho/address-book-
  app/new-desktop-file/+merge/236364

  Some of the splash screen customization options are explained in
  https://lists.launchpad.net/ubuntu-phone/msg09996.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/dekko/+bug/1377638/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1288885] Re: App cannot be started on clean Trusty desktop

** Changed in: ubuntu-terminal-app
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
https://bugs.launchpad.net/bugs/125

Title:
  App cannot be started on clean Trusty desktop

Status in Dropping Letters:
  Fix Released
Status in Ubuntu Music App:
  Fix Released
Status in notes-app:
  New
Status in Stock Ticker App:
  Fix Committed
Status in Sudoku App:
  Fix Committed
Status in Ubuntu Calculator App:
  Fix Released
Status in Ubuntu Clock App:
  Fix Released
Status in Ubuntu File Manager App:
  Fix Released
Status in Ubuntu Terminal App:
  Fix Released
Status in notes-app package in Ubuntu:
  Fix Released

Bug description:
  On a clean Trusty desktop add the core apps ppa:-
  sudo add-apt-repository ppa:ubuntu-touch-coreapps-drivers/daily
  Install core apps from the ppa:-
  sudo apt-get install music-app ubuntu-calculator-app ubuntu-clock-app
  Attempt to start those apps:-

  $ ubuntu-clock-app
  $ ubuntu-calculator-app
  $ music-app

  Note they all fail to start with the same error:-

  qmlscene: could not exec '/usr/lib/i386-linux-gnu/qt4/bin/qmlscene':
  No such file or directory

To manage notifications about this bug go to:
https://bugs.launchpad.net/dropping-letters/+bug/125/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Bug 1559724] Re: [shorts] If night mode is enabled, the app background is still white

MainView now sets the background of the main window, instead of using a QML 
Rectangle.
Since the BG is not a child item of MainView anymore, the "night mode" shader 
can't alter the color.

Refs.
- https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1439133
- https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/fasterWindowColor

-- 
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1559724

Title:
  [shorts] If night mode is enabled, the app background is still white

Status in Ubuntu Shorts App:
  Confirmed

Bug description:
  I think this is due to the new palette in the SDK landing in rc-
  proposed. The app background is white, which defeats the purpose of
  night mode. Also, articles are impossible to read for this reason.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1559724/+subscriptions

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into lp:ubuntu-docviewer-app

2016-03-24 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into 
lp:ubuntu-docviewer-app.

Commit message:
* WORKAROUND: make the lok-viewer header static (avoid unpredictable binding)
* Use new PageHeader and ScrollView components
* UI: Show an empty header when loading LibreOffice

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page/+merge/290048

* WORKAROUND: make the lok-viewer header static (avoid unpredictable binding)
* Use new PageHeader and ScrollView components
* UI: Show an empty header when loading LibreOffice
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/common/ViewerPage.qml'
--- src/app/qml/common/ViewerPage.qml	2015-11-30 12:12:10 +
+++ src/app/qml/common/ViewerPage.qml	2016-03-24 15:02:54 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Stefano Verzegnassi <verzegnassi.stef...@gmail.com>
+ * Copyright (C) 2015, 2016 Stefano Verzegnassi <verzegnassi.stef...@gmail.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -36,7 +36,6 @@
 Loader {
 id: contentLoader
 anchors.fill: parent
-
 asynchronous: true
 sourceComponent: viewerPage.contents
 
@@ -46,7 +45,6 @@
 Item {
 id: splashScreenItem
 anchors.fill: parent
-
 visible: contentLoader.status != Loader.Ready
 enabled: visible
 }

=== modified file 'src/app/qml/loView/KeybHelper.js'
--- src/app/qml/loView/KeybHelper.js	2015-12-14 00:40:55 +
+++ src/app/qml/loView/KeybHelper.js	2016-03-24 15:02:54 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Stefano Verzegnassi
+ * Copyright (C) 2015, 2016 Stefano Verzegnassi
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,83 +14,59 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
  
+// Here we handle all the key events that are not
+// recognised by UITK ScrollView
+
 function parseEvent(event) {
-var pixelDiff = 5;
-
 var view = loPage.contentItem.loView
 var isPresentation = view.document.documentType === LibreOffice.Document.PresentationDocument
 
 if (event.key == Qt.Key_PageUp) {
-if (isPresentation)
+if (isPresentation) {
 view.currentPart -= 1
-else
-view.moveView("vertical", -view.height)
- 
+event.accepted = true
+}
 return;
 }
  
 if (event.key == Qt.Key_PageDown) {
-if (isPresentation)
+if (isPresentation) {
 view.currentPart += 1
-else
-view.moveView("vertical", view.height)
- 
+event.accepted = true
+}
 return;
 }
  
 if (event.key == Qt.Key_Home) {
-if (event.modifiers & Qt.ControlModifier) {
-view.contentX = 0
-view.contentY = 0
+if (event.modifiers & Qt.ControlModifier)
 view.currentPart = 0
-} else {
-view.contentX = 0
-view.contentY = 0
-}
+
+event.accepted = false
+return
 }
 
 if (event.key == Qt.Key_End) {
-if (event.modifiers & Qt.ControlModifier) {
-view.contentX = view.contentWidth - view.width
-view.contentY = view.contentHeight - view.height
-console.log(view.currentPart, view.document.partsCount - 1)
+if (event.modifiers & Qt.ControlModifier)
 view.currentPart = view.document.partsCount - 1
-} else {
-view.contentX = view.contentWidth - view.width
-view.contentY = view.contentHeight - view.height
-}
-}
 
-if (event.key == Qt.Key_Up) {
-view.moveView("vertical", -pixelDiff)
-return;
-}
- 
-if (event.key == Qt.Key_Down) {
-view.moveView("vertical", pixelDiff)
-return;
-}
- 
-if (event.key == Qt.Key_Left) {
-view.moveView("horizontal", -pixelDiff)
-return;
-}
- 
-if (event.key == Qt.Key_Right) {
-view.moveView("horizontal", pixelDiff)
-return;
+event.accepted = false
+return
 }
 
 if (event.key == Qt.Key_Plus) {
 if (event.modifiers & Qt.ControlModifier) {
-view.zoomFactor = Math.max(4.0, view.zoomFactor + 0.25)
+view.setZoom(Math.min(view.zoomSettings.maximumZoom, view.zoomSettings.zoomFactor + 0.25))
 }
+
+return
 }
 
 if (event.key ==

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into lp:ubuntu-terminal-app

2016-03-24 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into 
lp:ubuntu-terminal-app.

Commit message:
* Expose drag mode settings to QML
* Disabled drag support in ubuntu-terminal-app in order to workaround the 
missing support in Mir

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1488588 in Ubuntu Terminal App: "Terminal creates a new surface when 
selecting text"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1488588

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588/+merge/290031

* Expose drag mode settings to QML
* Disabled drag support in ubuntu-terminal-app in order to workaround the 
missing support in Mir
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into 
lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/TerminalComponent.qml'
--- src/app/qml/TerminalComponent.qml	2016-02-06 16:31:36 +
+++ src/app/qml/TerminalComponent.qml	2016-03-24 12:38:21 +
@@ -14,6 +14,10 @@
 font.family: settings.fontStyle
 font.pixelSize: FontUtils.sizeToPixels("medium") * settings.fontSize / 10
 
+// WORKAROUND: Mir/QtMir does not support drag yet, therefore we need
+// to disable this functionality (see lp:1488588).
+dragMode: QMLTermWidget.NoDrag
+
 signal sessionFinished(var session);
 
 session: QMLTermSession {

=== modified file 'src/plugin/qmltermwidget/lib/TerminalDisplay.cpp'
--- src/plugin/qmltermwidget/lib/TerminalDisplay.cpp	2016-02-08 21:51:41 +
+++ src/plugin/qmltermwidget/lib/TerminalDisplay.cpp	2016-03-24 12:38:21 +
@@ -329,7 +329,7 @@
 ,_cursorBlinking(false)
 ,_hasBlinkingCursor(false)
 ,_allowBlinkingText(true)
-,_ctrlDrag(false)
+,_dragMode(CtrlKeyDrag)
 ,_tripleClickMode(SelectWholeLine)
 ,_isFixedSize(false)
 ,_possibleTripleClick(false)
@@ -1804,7 +1804,8 @@
 
 selected =  _screenWindow->isSelected(pos.x(),pos.y());
 
-if ((!_ctrlDrag || ev->modifiers() & Qt::ControlModifier) && selected ) {
+if (((_dragMode == DragMode::CtrlKeyDrag && ev->modifiers() & Qt::ControlModifier) ||
+ _dragMode == DragMode::MouseDrag) && selected ) {
   // The user clicked inside selected text
   dragInfo.state = diPending;
   dragInfo.start = ev->pos();

=== modified file 'src/plugin/qmltermwidget/lib/TerminalDisplay.h'
--- src/plugin/qmltermwidget/lib/TerminalDisplay.h	2016-02-07 07:31:59 +
+++ src/plugin/qmltermwidget/lib/TerminalDisplay.h	2016-03-24 12:38:21 +
@@ -83,6 +83,7 @@
 class KONSOLEPRIVATE_EXPORT TerminalDisplay : public QQuickPaintedItem
 {
Q_OBJECT
+   Q_ENUMS(DragMode)
Q_PROPERTY(KSession* session READ getSession  WRITE setSession NOTIFY sessionChanged  )
Q_PROPERTY(QFont fontREAD getVTFont   WRITE setVTFont )
Q_PROPERTY(QString  colorScheme   WRITE setColorScheme)
@@ -95,7 +96,8 @@
Q_PROPERTY(int scrollbarMaximum  READ getScrollbarMaximum  NOTIFY scrollbarParamsChanged  )
Q_PROPERTY(int scrollbarMinimum  READ getScrollbarMinimum  NOTIFY scrollbarParamsChanged  )
Q_PROPERTY(QSize fontMetrics READ getFontMetrics   NOTIFY changedFontMetricSignal )
-   Q_PROPERTY(bool enableBoldWRITE setBoldIntense)
+   Q_PROPERTY(bool enableBoldWRITE setBoldIntense)
+   Q_PROPERTY(DragMode dragMode MEMBER _dragMode  NOTIFY dragModeChanged )
 
 public:
 /** Constructs a new terminal display widget with the specified parent. */
@@ -194,8 +196,11 @@
 /** Specifies whether or not text can blink. */
 void setBlinkingTextEnabled(bool blink);
 
-void setCtrlDrag(bool enable) { _ctrlDrag=enable; }
-bool ctrlDrag() { return _ctrlDrag; }
+enum DragMode {
+NoDrag, // drag disabled
+CtrlKeyDrag,// require Ctrl key for drag
+MouseDrag   // no additional key is required
+};
 
 /** 
  *  This enum describes the methods for selecting text when
@@ -614,6 +619,7 @@
 void imagePainted();
 void scrollbarValueChanged();
 void scrollbarParamsChanged(int value);
+void dragModeChanged();
 
 protected:
 virtual bool event( QEvent * );
@@ -821,7 +827,7 @@
 bool _cursorBlinking; // hide cursor in paintEvent
 bool _hasBlinkingCursor;  // has blinking cursor enabled
 bool _allowBlinkingText;  // allow text to blink
-bool _ctrlDrag;   // require Ctrl key for drag
+DragMode _dragMode;
 TripleClickMode _tripleClickMode;
 bool _isF

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app

Review: Approve

Looks good to me!
By the way, I just want to take the opportunity to thank you for the time 
you've spent on the core apps. Good luck with juju! :)
-- 
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into lp:ubuntu-docviewer-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into 
lp:ubuntu-docviewer-app.

Commit message:
[TextView] Switch to UITK 1.3 PageHeader component

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview/+merge/289482

[TextView] Switch to UITK 1.3 PageHeader component
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-textview into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/textView/TextView.qml'
--- src/app/qml/textView/TextView.qml	2015-12-26 18:27:13 +
+++ src/app/qml/textView/TextView.qml	2016-03-18 11:23:04 +
@@ -23,10 +23,11 @@
 
 Page {
 id: textPage
-title: DocumentViewer.getFileBaseNameFromPath(file.path)
 
-// Reset night mode shader settings when closing the page
-// Component.onDestruction: mainView.nightModeEnabled = false
+header: TextViewDefaultHeader {
+title: DocumentViewer.getFileBaseNameFromPath(file.path)
+activityRunning: textAreaMain.isLoading
+}
 
 TextArea {
 id: textAreaMain
@@ -34,7 +35,12 @@
 
 property bool isLoading: true
 
-anchors.fill: parent
+anchors {
+top: textPage.header.bottom
+left: parent.left
+right: parent.right
+bottom: parent.bottom
+}
 
 // FIXME: If set to true, some of the keyboard hooks are disabled
 // And it's not possible to move the cursor with arrow keys.
@@ -61,14 +67,4 @@
 background: Rectangle { color: "white" }
 }
 }
-
-// *** HEADER ***
-state: "default"
-states: [
-TextViewDefaultHeader {
-name: "default"
-targetPage: textPage
-activityRunning: textAreaMain.isLoading
-}
-]
 }

=== modified file 'src/app/qml/textView/TextViewDefaultHeader.qml'
--- src/app/qml/textView/TextViewDefaultHeader.qml	2015-11-13 21:19:46 +
+++ src/app/qml/textView/TextViewDefaultHeader.qml	2016-03-18 11:23:04 +
@@ -20,44 +20,30 @@
 import Ubuntu.Components.Popups 1.3
 import DocumentViewer 1.0
 
-PageHeadState {
+PageHeader {
 id: rootItem
 
-property Page targetPage
 property alias activityRunning: activity.running
 
-head: targetPage.head
-
-contents: RowLayout {
-anchors.fill: parent
-spacing: units.gu(1)
-
-ActivityIndicator { id: activity; visible: running }
-
-Column {
-id: layout
-Layout.fillWidth: true
-
-Label {
-width: parent.width
-//horizontalAlignment: Text.AlignHCenter
-elide: Text.ElideMiddle
-
-font.weight: Font.DemiBold
-text: targetPage.title
-}
-Label {
-width: parent.width
-//horizontalAlignment: Text.AlignHCenter
-elide: Text.ElideMiddle
-
-textSize: Label.Small
-text: file.mimetype.description
-}
-}
+contents: ListItemLayout {
+anchors.centerIn: parent
+
+ActivityIndicator {
+id: activity
+SlotsLayout.position: SlotsLayout.Leading
+visible: running
+}
+
+title {
+font.weight: Font.DemiBold
+elide: Text.ElideMiddle
+text: rootItem.title
+}
+
+subtitle.text: file.mimetype.description
 }
 
-actions: [
+trailingActionBar.actions: [
 Action {
 iconName: "night-mode"
 text: mainView.nightModeEnabled ? i18n.tr("Disable night mode") : i18n.tr("Enable night mode")

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page/+merge/288556
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into lp:ubuntu-docviewer-app

The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 
into lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218/+merge/288689
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into lp:ubuntu-docviewer-app

The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/restore-ap-template into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/restore-ap-template/+merge/288454
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app

The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app

The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into 
lp:ubuntu-docviewer-app has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app

The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-docviewer-app/create-cache into lp:ubuntu-docviewer-app

Review: Approve


-- 
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into lp:ubuntu-terminal-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into 
lp:ubuntu-terminal-app.

Commit message:
* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, instead of the QtQuick Text component
* Minor text margins fix in TabsPage

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation/+merge/287990

* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, instead of the QtQuick Text component
* Minor text margins fix in TabsPage
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into 
lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/CircularTransparentButton.qml'
--- src/app/qml/CircularTransparentButton.qml	2016-01-09 01:47:56 +
+++ src/app/qml/CircularTransparentButton.qml	2016-03-15 14:39:40 +
@@ -22,7 +22,7 @@
 active: action.text
 z: parent.z + 0.1
 anchors.centerIn: parent
-sourceComponent: Text {
+sourceComponent: Label {
 opacity: innerOpacity
 text: action.text
 color: textColor

=== modified file 'src/app/qml/ColorSchemePage.qml'
--- src/app/qml/ColorSchemePage.qml	2016-02-07 18:30:11 +
+++ src/app/qml/ColorSchemePage.qml	2016-03-15 14:39:40 +
@@ -23,38 +23,44 @@
 id: rootItem
 objectName: "colorSchemePage"
 
-title: i18n.tr("Color Scheme")
+header: PageHeader {
+title: i18n.tr("Color Scheme")
+flickable: listView
+}
 
 property alias model: listView.model
 property var namesModel
 
 readonly property string currentName: namesModel[listView.currentIndex]
 
-ListView {
-id: listView
+ScrollView {
 anchors.fill: parent
-model: settings.profilesList
-currentIndex: model.indexOf(settings.colorScheme)
-delegate: ListItem {
-ListItemLayout {
-anchors.verticalCenter: parent.verticalCenter
-title.text: namesModel[model.index]
-
-Icon {
-SlotsLayout.position: SlotsLayout.Last
-width: units.gu(2); height: units.gu(2)
-color: UbuntuColors.green
-name: "tick"
-
-visible: model.index === listView.currentIndex
+ListView {
+id: listView
+anchors.fill: parent
+model: settings.profilesList
+currentIndex: model.indexOf(settings.colorScheme)
+delegate: ListItem {
+ListItemLayout {
+anchors.verticalCenter: parent.verticalCenter
+title.text: namesModel[model.index]
+
+Icon {
+SlotsLayout.position: SlotsLayout.Last
+width: units.gu(2); height: units.gu(2)
+color: UbuntuColors.green
+name: "tick"
+
+visible: model.index === listView.currentIndex
+}
 }
-}
-
-onClicked: listView.currentIndex = model.index
-}
-
-onCurrentIndexChanged: {
-settings.colorScheme = model[currentIndex];
+
+onClicked: listView.currentIndex = model.index
+}
+
+onCurrentIndexChanged: {
+settings.colorScheme = model[currentIndex];
+}
 }
 }
 }

=== modified file 'src/app/qml/ExpandableButton.qml'
--- src/app/qml/ExpandableButton.qml	2016-01-09 01:47:56 +
+++ src/app/qml/ExpandableButton.qml	2016-03-15 14:39:40 +
@@ -61,7 +61,7 @@
 z: parent.z + 0.01
 anchors.centerIn: parent
 active: actions[index].text
-sourceComponent: Text {
+sourceComponent: Label {
 color: textColor
 text: actions[index].text
 }

=== modified file 'src/app/qml/KeyboardRows/ExpandableKeyboardButton.qml'
--- src/app/qml/KeyboardRows/ExpandableKeyboardButton.qml	2016-01-09 01:47:56 +
+++ src/app/qml/KeyboardRows/ExpandableKeyboardButton.qml	2016-03-15 14:39:40 +
@@ -18,7 +18,7 @@
 z: parent.z + 1
 }
 
-Text {
+Label {
 id: mainLabel
 anchors.centerIn: parent
 z: parent.z + 0.02

=== modified file 'src/app/qml/KeyboardRows/KeyboardButton.qml'
--- src/app/qml/KeyboardRows/KeyboardButton.qml	2016-01-09 01:47:56 +
+++ src/app/qml/KeyboardRows/KeyboardButton.qml	2016-03-15 14:39:40 +
@@ -7,7 +7,7 @@
 
 color: "black"
 
-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into lp:ubuntu-terminal-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app.

Commit message:
Added a context property which allows terminal-app to know whether a keyboard 
or a mouse is attached to the device.

This is required to workaround a gap in the Ubuntu UI Toolkit, which makes 
impossible to use some of the new convergence features (e.g. bottom edge) in 
desktop mode.
This also allows us to automatically hide some components which are only useful 
in a context where only a touchscreen is available as input device.

Hopefully, this patch shouldn't be required anymore with OTA-11, when the 
support for devices detection will be available through UITK.

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1465975 in Ubuntu Terminal App: "Do not show the keyboard button if 
running on the desktop"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1465975

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/device-detection/+merge/287985

*** REQUIRES OTA-10 ***

QUESTION: Should we hide keyboardBar too, if a physical keyboard is connected?

Added a context property which allows terminal-app to know whether a keyboard 
or a mouse is attached to the device.

This is required to workaround a gap in the Ubuntu UI Toolkit, which makes 
impossible to use some of the new convergence features (e.g. bottom edge) in 
desktop mode.
This also allows us to automatically hide some components which are only useful 
in a context where only a touchscreen is available as input device.

Hopefully, this patch shouldn't be required anymore with OTA-11, when the 
support for devices detection will be available through UITK.
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into 
lp:ubuntu-terminal-app.
=== modified file 'debian/control'
--- debian/control	2015-07-04 08:43:12 +
+++ debian/control	2016-03-15 14:20:39 +
@@ -24,6 +24,7 @@
  qtdeclarative5-pamauthentication0.1,
  qtdeclarative5-qtquick2-plugin,
  qtdeclarative5-ubuntu-ui-toolkit-plugin,
+ qml-module-qtsysteminfo (>= 5.0~),
 Description: Terminal application
  Core Terminal application
 

=== modified file 'src/app/qml/SettingsPage.qml'
--- src/app/qml/SettingsPage.qml	2016-02-07 18:30:11 +
+++ src/app/qml/SettingsPage.qml	2016-03-15 14:20:39 +
@@ -68,22 +68,6 @@
 }
 
 ListItem {
-ListItemLayout {
-anchors.fill: parent
-title.text: i18n.tr("Show Keyboard Button")
-
-Switch {
-id: keybButtonSwitch
-SlotsLayout.position: SlotsLayout.Trailing
-onCheckedChanged: settings.showKeyboardButton = checked;
-Component.onCompleted: checked = settings.showKeyboardButton;
-}
-}
-
-onClicked: keybButtonSwitch.trigger()
-}
-
-ListItem {
 height: units.gu(13)
 
 Label {

=== modified file 'src/app/qml/TerminalPage.qml'
--- src/app/qml/TerminalPage.qml	2016-03-03 23:14:40 +
+++ src/app/qml/TerminalPage.qml	2016-03-15 14:20:39 +
@@ -227,7 +227,7 @@
 
 Loader {
 id: keyboardButton
-active: settings.showKeyboardButton
+active: !QuickUtils.keyboardAttached
 anchors {right: parent.right; margins: units.gu(1)}
 
 y: parent.height - height - units.gu(1) - keyboardBarLoader.height

=== modified file 'src/app/qml/TerminalSettings.qml'
--- src/app/qml/TerminalSettings.qml	2016-02-06 18:09:05 +
+++ src/app/qml/TerminalSettings.qml	2016-03-15 14:20:39 +
@@ -9,7 +9,6 @@
 property alias fontStyle: innerSettings.fontStyle
 property alias colorScheme: innerSettings.colorScheme
 property alias showKeyboardBar: innerSettings.showKeyboardBar
-property alias showKeyboardButton: innerSettings.showKeyboardButton
 
 readonly property int defaultFontSize: 10
 readonly property int minFontSize: 4
@@ -40,7 +39,6 @@
 property string fontStyle: "Ubuntu Mono"
 property string colorScheme: "Ubuntu"
 property bool showKeyboardBar: true
-property bool showKeyboardButton: true
 property string jsonVisibleProfiles: "[]"
 }
 

=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
--- src/app/qml/ubuntu-terminal-app.qml	2016-03-06 00:27:33 +
+++ src/app/qml/ubuntu-terminal-app.qml	2016-03-15 14:20:39 +
@@ -5,6 +5,9 @@
 
 import QMLTermWidget 1.0
 
+// Mouse/Touchpad and keyboard support
+import QtSystemInfo 5.5
+
 MainView {
 // objectName for functional testing purposes (autopilot-qt5)
 id: mview
@@ -135,4 +138,33 @@
 wid

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/test into lp:ubuntu-docviewer-app

2016-03-10 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/test into lp:ubuntu-docviewer-app.

Commit message:
test

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/test/+merge/288729

test
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/test into 
lp:ubuntu-docviewer-app.
=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake	2016-02-22 22:44:48 +
+++ cmake/modules/Click.cmake	2016-03-11 00:19:34 +
@@ -19,6 +19,13 @@
 
   MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}") 
 
+execute_process(COMMAND stat ${GET_CLICK_DEPS_TOOL}
+OUTPUT_VARIABLE tmp
+)
+
+MESSAGE(${tmp})
+  
+
   if(NO_CACHE)
 # It has been specified not to cache .click dependencies on the machine.
 # This is meant to be used for automatic builds (e.g. Jenkins Bot).

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into lp:ubuntu-docviewer-app

2016-03-10 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into 
lp:ubuntu-docviewer-app.

Commit message:
emit DocumentModel::dataChanged()
Sometimes the UI was not notified about changes in model entries (e.g. file 
size still equals to zero after file has been successfully copied)

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1483218 in Ubuntu Document Viewer App: "Files show "0 bytes" immediately 
after loading to device"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1483218

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218/+merge/288689

emit DocumentModel::dataChanged()
Sometimes the UI was not notified about changes in model entries (e.g. file 
size still equals to zero after file has been successfully copied)
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1483218 into 
lp:ubuntu-docviewer-app.
=== modified file 'src/plugin/file-qml-plugin/documentmodel.cpp'
--- src/plugin/file-qml-plugin/documentmodel.cpp	2015-09-19 15:40:22 +
+++ src/plugin/file-qml-plugin/documentmodel.cpp	2016-03-10 19:51:54 +
@@ -65,6 +65,7 @@
 for (int i=0; i<m_docs.length(); i++) {
 if (m_docs.at(i).path == path) {
 m_docs[i] = createEntry(path);
+Q_EMIT dataChanged(index(i, 0), index(i, 0));
 
 break;
 }

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into lp:ubuntu-docviewer-app

2016-03-09 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into 
lp:ubuntu-docviewer-app.

Commit message:
Minor code style changes

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling/+merge/288557

Minor code style changes
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/minor-code-styling into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/common/HorizontalDivider.qml'
--- src/app/qml/common/HorizontalDivider.qml	2015-10-27 20:19:05 +
+++ src/app/qml/common/HorizontalDivider.qml	2016-03-09 18:21:13 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Canonical, Ltd.
+ * Copyright (C) 2015, 2016 Canonical, Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -20,9 +20,9 @@
 Rectangle {
 height: units.dp(2)
 gradient: Gradient {
-GradientStop { position: 0.0; color: Qt.rgba(0, 0, 0, 0.1)  }
-GradientStop { position: 0.49; color:  Qt.rgba(0, 0, 0, 0.1)  }
-GradientStop { position: 0.5; color: Qt.rgba(1, 1, 1, 0.4) }
-GradientStop { position: 1.0; color:  Qt.rgba(1, 1, 1, 0.4)  }
+GradientStop { position: 0.0;  color: Qt.rgba(0, 0, 0, 0.1) }
+GradientStop { position: 0.49; color: Qt.rgba(0, 0, 0, 0.1) }
+GradientStop { position: 0.5;  color: Qt.rgba(1, 1, 1, 0.4) }
+GradientStop { position: 1.0;  color: Qt.rgba(1, 1, 1, 0.4) }
 }
 }

=== modified file 'src/app/qml/common/ScalingMouseArea.qml'
--- src/app/qml/common/ScalingMouseArea.qml	2016-01-19 17:42:01 +
+++ src/app/qml/common/ScalingMouseArea.qml	2016-03-09 18:21:13 +
@@ -23,29 +23,26 @@
 
 scaleInfo.fromZoom = zoomValue
 
-if (zoomValue <= thresholdZoom) {
+if (zoomValue <= thresholdZoom)
 scaleInfo.toZoom = maximumZoom
-} else {
+else
 scaleInfo.toZoom = minimumZoom
-}
 
 scaleInfo.tempContentX = tpt.x * scaleInfo.effectiveZoom - (flick.width * 0.5)
 scaleInfo.tempContentY = tpt.y * scaleInfo.effectiveZoom - (flick.height * 0.5)
 
 scaleInfo.finalContentX = Math.max(0, Math.min(pt.x * scaleInfo.effectiveZoom - (flick.width * 0.5),
-(flick.contentWidth * scaleInfo.effectiveZoom) - flick.width))
+   (flick.contentWidth * scaleInfo.effectiveZoom) - flick.width))
 
 scaleInfo.finalContentY = Math.max(0, Math.min(pt.y * scaleInfo.effectiveZoom - (flick.height * 0.5),
-(flick.contentHeight * scaleInfo.effectiveZoom) - flick.height))
+   (flick.contentHeight * scaleInfo.effectiveZoom) - flick.height))
 
-if (zoomValue <= thresholdZoom) {
+if (zoomValue <= thresholdZoom)
 zoomInAnimation.start()
-} else {
+else
 zoomOutAnimation.start()
-}
 }
 
-
 QtObject {
 id: scaleInfo
 
@@ -62,7 +59,6 @@
 
 SequentialAnimation {
 id: zoomInAnimation
-
 ScriptAction { script: targetFlickable.interactive = false; }
 
 // Fake zooming
@@ -73,14 +69,12 @@
 duration: mouseArea.zoomDuration
 to: scaleInfo.effectiveZoom
 }
-
 NumberAnimation {
 target: targetFlickable
 property: "contentX"
 duration: mouseArea.zoomDuration
 to: scaleInfo.tempContentX
 }
-
 NumberAnimation {
 target: targetFlickable
 property: "contentY"
@@ -90,13 +84,10 @@
 }
 
 ScriptAction { script: targetFlickable.contentItem.scale = 1; }
-
 ScriptAction { script: totalScale = scaleInfo.toZoom; }
 ScriptAction { script: targetFlickable.contentX = scaleInfo.finalContentX; }
 ScriptAction { script: targetFlickable.contentY = scaleInfo.finalContentY; }
-
 ScriptAction { script: targetFlickable.returnToBounds(); }
-
 ScriptAction { script: targetFlickable.interactive = true; }
 }
 
@@ -104,13 +95,10 @@
 id: zoomOutAnimation
 
 ScriptAction { script: targetFlickable.interactive = false; }
-
 ScriptAction { script: totalScale = scaleInfo.toZoom; }
 ScriptAction { script: targetFlickable.contentX = scaleInfo.finalContentX; }
 ScriptAction { script: targetFlickable.contentY = scaleInfo.finalContentY; }
-
 ScriptAction { script: targetFlickable.returnToBounds(); }
-
 ScriptAction { script: ta

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into lp:ubuntu-docviewer-app

2016-03-09 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into 
lp:ubuntu-docviewer-app.

Commit message:
Use PageHeader and ScrollView in details page

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page/+merge/288556

Use PageHeader and ScrollView in details page
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-details-page into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/common/DetailsPage.qml'
--- src/app/qml/common/DetailsPage.qml	2015-12-27 12:10:06 +
+++ src/app/qml/common/DetailsPage.qml	2016-03-09 18:20:18 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013-2014 Canonical, Ltd.
+ * Copyright (C) 2013-2016 Canonical, Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,60 +17,59 @@
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 import DocumentViewer 1.0
+import QtQml.Models 2.1
 
 import "utils.js" as Utils
 
 Page {
 id: detailsPage
 objectName: "detailsPage"
-title: i18n.tr("Details")
-
-Flickable {
-id: flick
+
+header: PageHeader {
+title: i18n.tr("Details")
+flickable: view
+}
+
+ScrollView {
 anchors.fill: parent
-interactive: true
-
-contentWidth: parent.width
-contentHeight: layout.height
-
-Column {
-id: layout
-width: Math.min(units.gu(80), parent.width)
-anchors.horizontalCenter: parent.horizontalCenter
-
-SubtitledListItem {
-text: i18n.tr("File")
-subText: DocumentViewer.getFileNameFromPath(file.path)
-}
-
-SubtitledListItem {
-text: i18n.tr("Location")
-subText: DocumentViewer.getCanonicalPath(file.path)
-}
-
-SubtitledListItem {
-text: i18n.tr("Size")
-subText: Utils.printSize(i18n, file.info.size)
-}
-
-SubtitledListItem {
-text: i18n.tr("Created")
-subText: file.info.creationTime.toLocaleString(Qt.locale())
-}
-
-SubtitledListItem {
-text: i18n.tr("Last modified")
-subText: file.info.lastModified.toLocaleString(Qt.locale())
-}
-
-SubtitledListItem {
-// Used by Autopilot tests
-objectName: "mimetypeItem"
-text: i18n.tr("MIME type")
-subText: file.mimetype.name
+
+ListView {
+id: view
+anchors.fill: parent
+
+model: ObjectModel {
+SubtitledListItem {
+text: i18n.tr("File")
+subText: DocumentViewer.getFileNameFromPath(file.path)
+}
+
+SubtitledListItem {
+text: i18n.tr("Location")
+subText: DocumentViewer.getCanonicalPath(file.path)
+}
+
+SubtitledListItem {
+text: i18n.tr("Size")
+subText: Utils.printSize(i18n, file.info.size)
+}
+
+SubtitledListItem {
+text: i18n.tr("Created")
+subText: file.info.creationTime.toLocaleString(Qt.locale())
+}
+
+SubtitledListItem {
+text: i18n.tr("Last modified")
+subText: file.info.lastModified.toLocaleString(Qt.locale())
+}
+
+SubtitledListItem {
+// Used by Autopilot tests
+objectName: "mimetypeItem"
+text: i18n.tr("MIME type")
+subText: file.mimetype.name
+}
 }
 }
 }
-
-Scrollbar { flickableItem: flick }
 }

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 into lp:ubuntu-docviewer-app

2016-03-09 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 into 
lp:ubuntu-docviewer-app.

Commit message:
* Updated copyright
* Removed usage of deprecated colors (e.g. UbuntuColors.midAubergine)
* Align to the latest clock-app specs (i.e. don't use purple as accent color)
* Use the section divider from the latest calendar-app specs
* Don't use DemiBold in PDF ToC
* Fixed font color broken after UITK theming changes in Silo 50 (OTA 10)
* ResizeableSidebar: fixed vertical divider margins

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1551259 in Ubuntu Document Viewer App: "Potential document-viewer app 
updates needed due to a change in theming/UI toolkit in OTA10"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1551259

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50/+merge/288555

* Updated copyright
* Removed usage of deprecated colors (e.g. UbuntuColors.midAubergine)
* Align to the latest clock-app specs (i.e. don't use purple as accent color)
* Use the section divider from the latest calendar-app specs
* Don't use DemiBold in PDF ToC
* Fixed font color broken after UITK theming changes in Silo 50 (OTA 10)
* ResizeableSidebar: fixed vertical divider margins
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-theming-silo-50 into 
lp:ubuntu-docviewer-app.
=== modified file 'src/app/qml/common/ResizeableSidebar.qml'
--- src/app/qml/common/ResizeableSidebar.qml	2015-10-27 20:19:05 +
+++ src/app/qml/common/ResizeableSidebar.qml	2016-03-09 18:19:39 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Canonical, Ltd.
+ * Copyright (C) 2015, 2016 Canonical, Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -35,11 +35,9 @@
 bottom: parent.bottom
 right: resizeableSidebar.anchors.left ? parent.right : undefined
 left: resizeableSidebar.anchors.left ? undefined : parent.left
-leftMargin: units.dp(2)
-rightMargin: units.dp(2)
 }
-width: units.dp(2)
-color: Theme.palette.selected.background
+width: units.dp(1)
+color: theme.palette.normal.base
 
 // Stay above the sidebar content
 z: 10
@@ -68,7 +66,7 @@
 when: resizerSensing.pressed || resizerSensing.containsMouse
 PropertyChanges {
 target: verticalDivider
-color: Qt.darker(Theme.palette.normal.background, 1.5)
+color: Qt.darker(theme.palette.normal.background, 1.5)
 }
 }
 transitions: Transition {

=== modified file 'src/app/qml/common/SubtitledListItem.qml'
--- src/app/qml/common/SubtitledListItem.qml	2015-12-27 12:10:06 +
+++ src/app/qml/common/SubtitledListItem.qml	2016-03-09 18:19:39 +
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Canonical, Ltd.
+ * Copyright (C) 2015, 2016 Canonical, Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -26,12 +26,7 @@
 
 ListItemLayout {
 id: listItemLayout
-
-title {
-text: listItemSubtitled.text
-color: UbuntuColors.midAubergine
-}
-
+title.text: listItemSubtitled.text
 subtitle {
 text: listItemSubtitled.subText
 wrapMode: Text.WrapAtWordBoundaryOrAnywhere

=== modified file 'src/app/qml/documentPage/DocumentListDelegate.qml'
--- src/app/qml/documentPage/DocumentListDelegate.qml	2015-12-29 17:13:25 +
+++ src/app/qml/documentPage/DocumentListDelegate.qml	2016-03-09 18:19:39 +
@@ -1,5 +1,5 @@
 /*
-  Copyright (C) 2015 Stefano Verzegnassi
+  Copyright (C) 2015, 2016 Stefano Verzegnassi
 
 This program is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License 3 as published by
@@ -51,9 +51,6 @@
 // FIXME: We may want to reserve 2 lines for displaying the title.
 // 2015.12.29: that's not possible because of bug lp:1529909
 text: model.name
-elide: Text.ElideRight
-wrapMode: Text.WrapAnywhere
-color: UbuntuColors.midAubergine
 }
 
 subtitle.text: internal.formattedDateTime()

=== modified file 'src/app/qml/documentPage/SectionHeader.qml'
--- src/app/qml/documentPage/SectionHeader.qml	2015-10-23 14:00:16 +
+++ src/app/qml/documentPage/SectionHeader.qml	2016-03-09 18:19:39 +
@@ -1,29 +1,55 @@
 import QtQuick 2.4
 import Ubuntu.Components 1.3
-import Ubuntu.Components.ListItems 1.3 as ListItems
 import DocumentViewer 1.0
 
-ListItems.Header {
-text: {
-if (sortSetting

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app

2016-03-08 Thread Stefano Verzegnassi

The proposal to merge lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
-- 
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app

2016-03-08 Thread Stefano Verzegnassi

Review: Approve

Ok, thanks! LGTM
-- 
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-terminal-app/restore-autopilot into lp:ubuntu-terminal-app

2016-03-08 Thread Stefano Verzegnassi

Review: Needs Information

Tested on my PC and it works well.
My only question is about Python coding style: should we still refer to the 
pep8 conventions?

PS. One diff comment included (i.e. music-app typo).


==

$ pep8 ./tests
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:42:80: E501 line too 
long (94 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:45:80: E501 line too 
long (90 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:47:80: E501 line too 
long (89 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:72:80: E501 line too 
long (80 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:90:5: E303 too many 
blank lines (2)

Diff comments:

> === added file 'README.autopilot.md'
> --- README.autopilot.md   1970-01-01 00:00:00 +
> +++ README.autopilot.md   2016-03-07 22:19:53 +
> @@ -0,0 +1,74 @@
> +Running Autopilot tests
> +===
> +If you are looking for more info about Autopilot or writing AP tests, here 
> are some useful links to help you:
> +
> +- [Ubuntu - Quality](http://developer.ubuntu.com/start/quality)
> +- [Autopilot - 
> Python](https://developer.ubuntu.com/api/autopilot/python/1.5.0/)
> +
> +For help and options on running tests, see:
> +
> +- [Autopilot 
> tests](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
> +
> +Prerequisites
> +=
> +
> +Install the following autopilot packages required to run the tests,
> +
> +$ sudo apt-get install python3-autopilot libautopilot-qt 
> ubuntu-ui-toolkit-autopilot python3-autopilot-vis
> +
> +Running tests on the desktop
> +
> +
> +Using terminal:
> +
> +*  Branch the code
> +
> +$ bzr branch lp:ubuntu-terminal-app
> +
> +*  Navigate to the tests/autopilot directory.
> +
> +$ cd tests/autopilot
> +
> +*  run all tests.
> +
> +$ autopilot3 run -vv ubuntu_terminal_app
> +
> +* to list all tests:
> +
> +$ autopilot3 list ubuntu_terminal_app
> +
> + To run only one test
> +
> +$ autopilot3 run -vv ubuntu_terminal_app.tests.test_name
> +
> +* Debugging tests using autopilot vis
> +
> +$ autopilot3 launch -i Qt qmlscene src/app/terminal
> +
> +$ autopilot3 vis
> +
> +Running tests using Ubuntu SDK
> +==
> +
> +Refer this 
> [tutorial](https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/)
>  to run tests on Ubuntu SDK:
> +
> +Running tests on device or emulator:
> +
> +
> +Using autopkg:
> +
> +*  Branch the Music app code, for example,

You've missed a further reference a music-app

> +
> +$ bzr branch lp:ubuntu-terminal-app
> +
> +*  Navigate to the source directory.
> +
> +$ cd ubuntu-terminal-app
> +
> +*  Build a click package
> +
> +$ click-buddy .
> +
> +*  Run the tests on device (assumes only one click package in the directory)
> +
> +$ adt-run . *.click --- ssh -s adb -- -p 
> \ No newline at end of file


-- 
https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/restore-autopilot/+merge/288347
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into lp:ubuntu-terminal-app

2016-03-03 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into 
lp:ubuntu-terminal-app.

Commit message:
Hide terminal data until the access is granted (using a FastBlur).

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1488481 in Ubuntu Terminal App: "BQ (r24): terminal-app shows terminal 
data when asking for password"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1488481

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth/+merge/288040

Hide terminal data until the access is granted (using a FastBlur).

Screenshot (with 'top' command):
https://drive.google.com/open?id=0By4kAplbFcE6ek5XT2FiMXM2eWs
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into 
lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/AuthenticationService.qml'
--- src/app/qml/AuthenticationService.qml	2016-01-09 01:47:56 +
+++ src/app/qml/AuthenticationService.qml	2016-03-03 23:14:57 +
@@ -26,6 +26,9 @@
 Item {
 id: authenticationService
 
+property var __authDialog
+readonly property bool isDialogVisible: __authDialog != null
+
 signal granted()
 signal denied()
 
@@ -63,6 +66,8 @@
 
 authentication_dialog.passwordEntered.connect( verify_password );
 authentication_dialog.dialogCanceled.connect( denied );
+
+__authDialog = authentication_dialog
 }
 
 PamAuthentication {

=== modified file 'src/app/qml/TerminalPage.qml'
--- src/app/qml/TerminalPage.qml	2016-01-22 18:01:49 +
+++ src/app/qml/TerminalPage.qml	2016-03-03 23:14:57 +
@@ -3,6 +3,9 @@
 import Ubuntu.Components.Popups 1.3
 import QMLTermWidget 1.0
 
+// For FastBlur
+import QtGraphicalEffects 1.0
+
 Page {
 id: terminalPage
 property alias terminalContainer: terminalContainer
@@ -29,6 +32,12 @@
 right: parent.right;
 bottom: keyboardBarLoader.top
 }
+
+// Hide terminal data when the access is still not granted
+layer.enabled: authService.isDialogVisible
+layer.effect: FastBlur {
+radius: units.gu(6)
+}
 }
 
 

=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
--- src/app/qml/ubuntu-terminal-app.qml	2016-02-07 18:24:56 +
+++ src/app/qml/ubuntu-terminal-app.qml	2016-03-03 23:14:57 +
@@ -16,6 +16,7 @@
 height: units.gu(55)
 
 AuthenticationService {
+id: authService
 onDenied: Qt.quit();
 }
 

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app

2016-03-03 Thread Stefano Verzegnassi

Huh, mark the comment about the 2px value as WORKAROUND, in case we'll decide 
in a distant future to move from the current code to a more "QML-friendly" 
implementation.
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app

2016-03-03 Thread Stefano Verzegnassi

And here we go! I've found the reason of such strange behaviour!

Diff comments:

> 
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml   2016-02-07 18:24:56 +
> +++ src/app/qml/ubuntu-terminal-app.qml   2016-02-13 21:25:20 +
> @@ -12,8 +12,8 @@
>  applicationName: "com.ubuntu.terminal"
>  automaticOrientation: true
>  
> -width: units.gu(90)
> -height: units.gu(55)
> +width: 40 * settings.fontPixelSize()

1) It's well hidden in the thousands of lines, but at the end I've found the 
responsible one...

See for example:
http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/src/plugin/qmltermwidget/lib/TerminalDisplay.cpp#L2947

The terminal widget seems to reserve 2px for margins. The value is hardcoded 
and cannot be set from QML.
That's a good news, since we can write something like:


   // 2px is the size of the margins of the terminal canvas.
   // Hardcoded value from TerminalDisplay.h
   width = terminal.fontMetrics.width * 80 + 2
   height = terminal.fontMetrics.height * 24 + 2


2) Yeah, 'fontMetrics' returned by the terminal is a QSize, since it's a custom 
implementation. I forgot to mention it because it was a bit late in Italy and I 
was about to fall asleep :P

> +height: 24 * settings.fontPixelSize()
>  
>  AuthenticationService {
>  onDenied: Qt.quit();


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app

2016-03-02 Thread Stefano Verzegnassi

I replied to your question. :)

Diff comments:

> === modified file 'src/app/main.cpp'
> --- src/app/main.cpp  2016-01-25 12:37:14 +
> +++ src/app/main.cpp  2016-02-13 21:25:20 +
> @@ -53,7 +53,7 @@
>  {
>  QApplication a(argc, argv);
>  QQuickView view;
> -view.setResizeMode(QQuickView::SizeRootObjectToView);
> +view.setResizeMode(QQuickView::SizeViewToRootObject);

Legit! :)

>  
>  FileIO fileIO;
>  view.engine()->rootContext()->setContextProperty("fileIO", );
> 
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml   2016-02-07 18:24:56 +
> +++ src/app/qml/ubuntu-terminal-app.qml   2016-02-13 21:25:20 +
> @@ -12,8 +12,8 @@
>  applicationName: "com.ubuntu.terminal"
>  automaticOrientation: true
>  
> -width: units.gu(90)
> -height: units.gu(55)
> +width: 40 * settings.fontPixelSize()

Since Qt 5.4 there's a FontMetrics component that allows to do that (it returns 
width and height, so you have to make the division by yourself):
http://doc.qt.io/qt-5/qml-qtquick-fontmetrics.html

If you were talking about the terminal plugin, a signal is automatically 
emitted when the font size changes[1], so any property that has a QML binding 
on terminal.fontMetrics is automatically updated according to the size of the 
new font (i.e. the width and the height of the terminal window, in this case).
No need for adding a TODO. :)

[1] 
http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/src/plugin/qmltermwidget/lib/TerminalDisplay.h#L97

> +height: 24 * settings.fontPixelSize()
>  
>  AuthenticationService {
>  onDenied: Qt.quit();


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/improve_readmes into lp:ubuntu-terminal-app

2016-03-02 Thread Stefano Verzegnassi

Review: Needs Fixing

Overall it looks okay to me. Thanks for this merge proposal! :)

I left 5 diff comments + two further notes (here below):

1) In "README.md":
 - I like the idea of providing some information about the application plugins. 
However, I'd prefer to provide some more general information rather going into 
details.
   I'd suggest you to write something like: http://paste.ubuntu.com/15270696/

2) We actually don't have any automatic test (the one and only we have is just 
a fake), therefore "README.testing.md" is  is not necessary, for now at least - 
I hope to see some Pilot manual test coming in a near future. Please remove the 
file.

Your changes has been already reviewed by Andrew and David, and the fixes for 
their requests look okay, so I don't have any further note on your MP.

Thanks again, great work! :D



Diff comments:

> === added file 'README.contributing.md'
> --- README.contributing.md1970-01-01 00:00:00 +
> +++ README.contributing.md2016-02-06 01:33:52 +
> @@ -0,0 +1,71 @@
> +Contributing
> +
> +
> +Code style
> +==
> +
> +We are trying to use a common code style throughout the code base to maintain
> +uniformity and improve code clarity. Listed below are the code styles guides
> +that will be followed based on the language used.
> +
> +* [QML](http://qt-project.org/doc/qt-5/qml-codingconventions.html) 
> +* [JS, C++](https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)
> +* [Python](Code should follow PEP8 and Flake regulations)
> +
> +Note: In the QML code convention, ignore the Javascript code section 
> guidelines.
> +So the sections that should be taken into account in the QML conventions are 
> QML 
> +Object Declarations, Grouped Properties and Lists.
> +
> +Running tests

We actually don't have any automatic test (the one and only we have is just a 
fake).
Please remove this section.

> +=
> +
> +Please check README.autopilot and README.unittest on how to run the tests.
> +They are quite explanatory and will help you get started.
> +
> +Submitting changes
> +==
> +
> +After writing your code, here's how to submit it. Before doing this, make 
> sure
> +to run all the tests and make sure your code follows the style guidelines.
> +
> +If the tests fail, you will have to fix them before your change can be
> +approved and merged into trunk. If the tests pass then commit and push your
> +code by,
> +
> +$ bzr commit -m "Commit Message"
> +$ bzr push lp:~launchpadid/ubuntu-terminal-app/branch-name
> +
> +If you're submitting a bug fix, you can include the --fixes flag
> +$ bzr commit -m "Implemented bug fix" --fixes lp:bug-number
> +
> +After you push your code, you can submit a Merge Proposal
> +
> +Prerequisites to approving a Merge Proposal (MP)
> +
> +
> +Over time, it has been found that insufficient testing by reviewers sometimes
> +leads to terminal app trunk not being buildable in Qtcreator due to manifest 
> errors,
> +or translation pot file not updated. As such, please follow the checklist 
> below
> +before top-approving a MP.
> +
> +Checklist
> +=
> +
> +*   Does the MP add/remove user visible strings? If Yes, has the pot file 
> been updated?
> +
> +*   Does the MP change the UI? If Yes, has it been approved by design?
> +
> +*   Did you perform an exploratory manual test run of your code change and 
> any
> +related functionality?
> +
> +*   If the MP fixes a bug or implements a feature, are there accompanying 
> unit
> +and autopilot tests?
> +
> +*   Is the calendar app trunk buildable and runnable using Qtcreator?

You missed the last reference to calendar in the "Checklist" section :)

> +
> +*   Was the debian changelog updated?
> +
> +*   Was the copyright years updated if necessary?
> +
> +The above checklist is more of a guideline to help the terminal app trunk 
> stay
> +buildable, stable and up to date.
> 
> === added file 'README.publishing.md'
> --- README.publishing.md  1970-01-01 00:00:00 +
> +++ README.publishing.md  2016-02-06 01:33:52 +
> @@ -0,0 +1,73 @@
> +Building a click package
> +
> +
> +There are two alternative ways of building a click package.
> +
> +Using Qt Creator
> +
> +
> +1. Ensure you've selected the UbuntuSDK for armhf kit on Qt Creator's sidebar
> +2. Click on Publish on the sidebar
> +3. Click on "Create package"
> +4. If all goes well, you'll find the final click package in the build 
> directory
> +
> +Notes:
> +- You can see the output of the click build if you click on Edit on the 
> sidebar
> +  and then "Application Output" at the bottom. This is useful to identify any
> +  failures during the build
> +- To enable Click Package validation, run 
> +$ sudo apt-get install click-reviewers-tools
> +  in Qt Creator
> +  You might need to restart Qt Creator after you've
> +  installed them for it to detect them
>

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app

2016-02-28 Thread Stefano Verzegnassi

@Alan, any progress on this? Does it make sense to change the ownership of this 
branch, so that the team can finish the QML implementation?
-- 
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-control/+merge/282280
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into lp:ubuntu-docviewer-app

2016-02-25 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option into 
lp:ubuntu-docviewer-app.

Commit message:
Allow to disable .click dependencies caching through a CMake option

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
  Bug #1547059 in Ubuntu Document Viewer App: "needs no-cache option during 
cmake build"
  https://bugs.launchpad.net/ubuntu-docviewer-app/+bug/1547059

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option/+merge/287187

Allow to disable .click dependencies caching through a CMake option
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/cmake-click-cache-option 
into lp:ubuntu-docviewer-app.
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2016-02-05 22:57:24 +
+++ CMakeLists.txt	2016-02-25 15:13:53 +
@@ -14,6 +14,7 @@
 
 option(INSTALL_TESTS"Install the tests on make install" on)
 option(CLICK_MODE   "Installs to a contained location" on)
+option(NO_CACHE "Disable caching of click dependencies (CLICK_MODE only)" off)
 
 set(APP_NAMEubuntu-docviewer-app)
 set(DESKTOP_FILE"${PROJECT_NAME}.desktop")

=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake	2016-01-17 20:15:53 +
+++ cmake/modules/Click.cmake	2016-02-25 15:13:53 +
@@ -19,22 +19,33 @@
 
   MESSAGE("Grabbing upstream libs to ${UPSTREAM_LIBS_DIR}") 
 
-  get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
-  set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-docviewer/${BLD_CONFIGURATION_NAME})
-  MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")  
-
-  if(EXISTS "${UPSTREAM_CACHE}")
-MESSAGE("Upstream libs cache exists.") 
-file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
-  else()
-MESSAGE("Cache miss, downloading from network.") 
+  if(NO_CACHE)
+# It has been specified not to cache .click dependencies on the machine.
+# This is meant to be used for automatic builds (e.g. Jenkins Bot).
 execute_process(
   COMMAND mkdir ${UPSTREAM_LIBS_DIR}
   COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
 )
-# Cache for next usage.
-file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
-  endif()
+  else(NO_CACHE)
+# Cache the .click dependencies for next usage. (Default)
+# Useful on developer machine.
+get_filename_component(BLD_CONFIGURATION_NAME ${CMAKE_BINARY_DIR} NAME)
+set(UPSTREAM_CACHE $ENV{HOME}/dev/upstream-libs-docviewer/${BLD_CONFIGURATION_NAME})
+MESSAGE("Upstream libs cache path: ${UPSTREAM_CACHE}")
+
+if(EXISTS "${UPSTREAM_CACHE}")
+  MESSAGE("Upstream libs cache exists.")
+  file(COPY ${UPSTREAM_CACHE}/upstream-libs/ DESTINATION ${UPSTREAM_LIBS_DIR} PATTERN * )
+else()
+  MESSAGE("Cache miss, downloading from network.")
+  execute_process(
+COMMAND mkdir ${UPSTREAM_LIBS_DIR}
+COMMAND ${GET_CLICK_DEPS_TOOL} -d ${DEPS_MANIFEST} -c ${CUSTOM_SCRIPT} ${CLICK_ARCH} ${UPSTREAM_LIBS_DIR}
+  )
+  # Cache for next usage.
+  file(COPY ${UPSTREAM_LIBS_DIR} DESTINATION ${UPSTREAM_CACHE} )
+endif() #EXISTS "${UPSTREAM_CACHE}"
+  endif() #NO_CACHE
 
   MESSAGE("Installing upstream libs from ${UPSTREAM_LIBS_DIR}/usr/lib/${ARCH_TRIPLET}/ to ${DATA_DIR}lib/${ARCH_TRIPLET}")
   file(GLOB_RECURSE UPSTREAM_LIBS "${UPSTREAM_LIBS_DIR}/usr/lib/${ARCH_TRIPLET}/*")

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into lp:ubuntu-docviewer-app

2016-02-22 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility/+merge/286193
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/window-font-size into lp:ubuntu-terminal-app

2016-02-14 Thread Stefano Verzegnassi

Review: Needs Fixing

I left two inline comments.

As a summary, here's a diff with the changes I've proposed (line 73 is wrong - 
that "imports" is not required).

The big problem with this MP is the usage of QQuickView::SizeViewToRootObject.
In my opinion it creates a lot of problems (speaking in general terms) because 
it breaks the "Window > Contents" relationship which is at the base of a window 
system.

For that reason my review is a "Needs Fixing".

==

A few comments on my diff:

1) About the "Connections {}" in MainView:

It's not strictly required. I mean, in your comment above you said that you 
would like to reproduce that specific behaviour, but e.g. Konsole does not.

I've been a Kubuntu users in that past, and the GTK world and the KDE (Qt) 
world used to be very different on such things. That's why many GTK apps do 
things that the KDE counterpart do not, and vice versa.
Ubuntu, as a GTK distro which is moving to Qt/QML, stays in between.

So, if you want to adjust the window size after a font size change, I'd suggest 
you to keep the logic very simple as I do.

Things could be done better but, as long as we stay with QQuickView and don't 
move to QQmlApplicationEngine, that's the cleanest solution.


2) I've replaced your fontPixelSize() function with a read-only property. 
That's not really required, but I did it for prototyping.

3) That "onChangedFontMetricSignal" signal has a terrible name. Would you mind 
renaming it as "onFontMetricsChanged" in the QMLTermWidget?

Diff comments:

> === modified file 'src/app/main.cpp'
> --- src/app/main.cpp  2016-01-25 12:37:14 +
> +++ src/app/main.cpp  2016-02-13 21:25:20 +
> @@ -53,7 +53,7 @@
>  {
>  QApplication a(argc, argv);
>  QQuickView view;
> -view.setResizeMode(QQuickView::SizeRootObjectToView);
> +view.setResizeMode(QQuickView::SizeViewToRootObject);

Changing the resize mode is not a good idea, because of the way users interact 
with the window :)

1) Try to maximize the window with a font size = 10.
Result: Main QML item is not resized with the window.

2) Try to maximize the window with a very large font (e.g. 34)
Result: you can't access to the buttons that are usually displayed at the right 
of the window.
See screenshot: https://imgur.com/e6Gqjhi

3) If you change the size of the window by dragging its border (common 
operation on desktop), the QML object is not resized.

So please restore the old QQuickView::SizeRootObjectToView value.




Quote from your comment:

> Also, the window itself does not scale with the MainView if the font size
> is changed while running, so I need to do a bit of work to address that

Reverting to QQuickView::SizeRootObjectToView does not fix this.
But, for example, Konsole does not resize the window after a font size 
adjustment. :)

If you want to emulate the behaviour of gnome-terminal (given you're using 
QQuickView::SizeRootObjectToView), I'd suggest you to expose QQuickView's 
properties to QML.

Add in main.cpp:
// Expose QQuickView properties for window resize handling
view.engine()->rootContext()->setContextProperty("View", );

In TerminalPage.qml define the "terminal" property as QMLTermWidget type.

Then, in the MainView you can add something like:
Connections {
target: terminalPage.terminal
onChangedFontMetricSignal: {
View.width = mview.width
View.height = mview.height
}
}

So you can update the window size according the font size adjustment, only when 
the font has been adjusted (i.e. you avoid unpredictable bindings).

Anyway, we still don't get the same behaviour, since gnome-terminal always keep 
the same number of line/columns when the font size has changed.

e.g.
1) Open gnome-terminal. Default size is 80x24 (chars)
2) Manually resize the window. Let's say 100x24 (chars)
3) Increase font size. The window is still 100x24 (chars).

I wouldn't try to mimic gnome-terminal on this, since it would require some 
extra logic which is IMHO not good-looking on QML.

>  
>  FileIO fileIO;
>  view.engine()->rootContext()->setContextProperty("fileIO", );
> 
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml   2016-02-07 18:24:56 +
> +++ src/app/qml/ubuntu-terminal-app.qml   2016-02-13 21:25:20 +
> @@ -12,8 +12,8 @@
>  applicationName: "com.ubuntu.terminal"
>  automaticOrientation: true
>  
> -width: units.gu(90)
> -height: units.gu(55)
> +width: 40 * settings.fontPixelSize()

You sholudn't use the size specified in the settings, but you should get it 
from the terminal widget instead (of course, IMHO).
You've hardcoded the 1:2 ratio of the Ubuntu Mono font but not all Mono fonts 
use that ratio.

> +height: 24 * settings.fontPixelSize()
>  
>  AuthenticationService {
>  onDenied: Qt.quit();


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-13 Thread Stefano Verzegnassi

Review: Approve

Yes, it's more a workaround than a "rock-solid" solution, but it does the job 
well and don't require to change things where it's not strictly required.

Below the Timer {}, I see that you left the Component.onCompleted handler. It 
isn't necessary anymore.

Anyway, LGTM, so there's no reason why I shouldn't approve it. Great work! :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into lp:ubuntu-docviewer-app

2016-02-12 Thread Stefano Verzegnassi

Fixed!
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149/+merge/285641
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/splash-screen into lp:ubuntu-terminal-app

2016-02-11 Thread Stefano Verzegnassi

Review: Needs Fixing

Sorry Evan for being that hateful guy, but the branch surely needs a fix. :)

Line 9 of the diff should be:
_X-Ubuntu-Splash-Title=Terminal

Note the underscore before "X-Ubuntu-Splash-Title". That way "Terminal" can be 
properly translated into user's language.


As for the rest, I'm not sure if we really want to show an header since we 
don't have any header in the main page of terminal-app.
This is anyway not a important question, so feel free to choose the design you 
prefer :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into lp:ubuntu-docviewer-app

2016-02-11 Thread Stefano Verzegnassi

I think so too.
To be fair, we shouldn't have exceptions for accessing to the user's folders
too, because of this.

Ideally the platform should provide some service that creates a database with a
list of documents, and docviewer should be authorized to access only that
database, by default.
When the application asks to access to a specific file, content-hub should
mediate the request and ensure that only the single file (or a copy of that
file) is accessible.

Anyway, I created this branch a month ago because I thought we were able to
release a new version in the store earlier. Also, it wasn't meant to require an
unconfined template, but then I discovered that it was broken on the UT
platform.

So we can reject this merge proposal.
Let's wait for a fix in the ubuntu-sdk project, it should come soon I guess...

https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/device_detection/+merge/284282

P.S. If you can ask to the platform team when they expect to release the fix,
that would be great. Anyway, all the SDK apps (except addressbook-app) are in
the same situation, so I'm not that much worried.
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2/+merge/284901
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into lp:ubuntu-docviewer-app

2016-02-11 Thread Stefano Verzegnassi

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into 
lp:ubuntu-docviewer-app with 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 as a prerequisite.

Commit message:
* Release Ubuntu DocViewer 2.1
* Updated changelog

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1/+merge/285791

* Release Ubuntu DocViewer 2.1
* Updated changelog
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/release-2.1 into 
lp:ubuntu-docviewer-app.
=== modified file 'click/manifest.json.in'
--- click/manifest.json.in	2016-01-07 13:37:52 +
+++ click/manifest.json.in	2016-02-11 18:04:18 +
@@ -13,7 +13,7 @@
 "urls": "com.ubuntu.docviewer.url-dispatcher"
 }
 },
-"version": "2.0.@BZR_REVNO@",
+"version": "2.1.@BZR_REVNO@",
 "maintainer": "Ubuntu App Cats <ubuntu-touch-corea...@lists.launchpad.net>",
 "x-source": {
 "vcs-bzr": "@BZR_SOURCE@",

=== modified file 'debian/changelog'
--- debian/changelog	2015-12-19 19:54:58 +
+++ debian/changelog	2016-02-11 18:04:18 +
@@ -1,8 +1,21 @@
-ubuntu-docviewer-app (2.0ubuntu1) UNRELEASED; urgency=medium
+ubuntu-docviewer-app (2.1) vivid; urgency=medium
 
+  * LibreOffice viewer: added support for spreadsheet documents with multiple sheets (LP: #1537755)
+  * LibreOffice viewer: limited zoom value to a minimum/maximum value (LP: #1501424)
+  * LibreOffice viewer: added a double-tap-to-zoom gesture (LP: #1541582)
+  * LibreOffice viewer: use QQuickAsyncImageProvider for thumbnails
+  * LibreOffice viewer: show content at the center of the window (LP: #1515655)
+  * LibreOffice viewer: better support for HiDPI screens (LP: #1535264)
+  * More zoom options for LibreOffice presentations (LP: #1515649)
+  * A manual zoom (1.0x) is now default for Libreoffice spreadsheets (LP: #1513960)
+  * Resolved a content-hub issue that prevents users to export a document to another app (LP: #1544149)
+  * Resolved an issue occurring when the user tries to delete a document stored in a external media (LP: #1524293)
+  * Full-screen presentation mode for PDF documents (LP: #1534761)
+  * Updated night mode shader
   * Updated and expanded READMEs
+  * UI improvements
 
- -- Girish Rawat <emailgirishra...@gmail.com>  Sun, 20 Dec 2015 01:23:18 +0530
+ -- Stefano Verzegnassi <verzegnassi.stef...@gmail.com>  Thu, 11 Feb 2016 18:36:48 +0100
 
 ubuntu-docviewer-app (2.0) vivid; urgency=medium
 

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp:ubuntu-docviewer-app

2016-02-08 Thread Stefano Verzegnassi

@Alan: Now it should be okay. I've checked with a stopwatch and the screen 
saver is properly disabled.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver/+merge/283717
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into lp:ubuntu-terminal-app

2016-02-07 Thread Stefano Verzegnassi

Review: Approve

BTW, code looks good! Great work!
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into lp:ubuntu-terminal-app

2016-02-07 Thread Stefano Verzegnassi

@Niklas: Changing the behaviour of the .pot custom target (i.e. removing the 
"ALL" option) in CMake should be enough, assuming nothing else will be broken.

That would mean that you'd have to explicitely do:
  mkdir build && cd dir
  cmake ../
  make 
  (bzr commit & bzr push)

So it would be something you should do whenever you're about to release a new 
version of the app.
We may want to add a script in the root of the project for making this easier 
for new contributors.
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into lp:ubuntu-terminal-app

Ooh, the magical world of Launchpad trying to merge a .pot update when the
.pot has been updated in the meantime. :)

P.S. Now you know how a DocViewer developer feels, haha :'D

P.S. #2 We probably should prevent this from happening, by avoiding to
update translations every time the app is built in QtCreator
Il 06/feb/2016 21:01, "Evan McIntire"  ha scritto:

Wow, I made it worse. Just a moment, let me re-merge the trunk in and fix
all of this nonsense
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
You are reviewing the proposed merge of
lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app.

-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into lp:ubuntu-terminal-app

Review: Approve

Looks good to me. Thanks!
-- 
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

@Niklas: the current "Ubuntu" theme uses exactly the same palette of 
"DarkPastels".
The only differences are the background color[1] and the blue color (which in 
the Ubuntu theme is shown as red).

We could rename "Dark Pastels" as "Dark Pastels / Ubuntu (old)" (or something 
similar), but I don't think users will complain that the "old" Ubuntu theme 
does not exist anymore.


[1] Ubuntu theme: RGB(51,51,51)
Dark Pastels theme: RGB(44,44,44)
Visually the two colors are the same.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp:ubuntu-docviewer-app

Ok, I found some time for working on this.
I forgot to commit the AppArmor permission for keeping the screen on (as always 
the problem exists between the chair and the keyboard :D)

However, it keeps on turning the screen off...

-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver/+merge/283717
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into lp:ubuntu-terminal-app

Review: Approve

Tested on my BQ, and looks good. Nice job! :D

Having a look at Niklas' review, I guess the "needs-fixing" is about the 
conflict with .pot, so there shouldn't be any problem in getting this branch 
merged.

Anyway, here's some note for a further task:

1) I believe it's better to use the Qt APIs (instead of 
Ubuntu.Components.Clipboard) since currently the QML GUI does not handle the 
clipboard (everything is done internally in the terminal widget). This could 
change in future, but I don't think it's a good idea to change heavily the C++ 
terminal code yet (Filippo, the former terminal-app maintainer, aimed to keep 
the code in sync with the upstream project from LxQt).

2) I'd prefer to set "enabled: !terminal.isClipboardEmpty()" instead of 
"visible" in order to stay consistent with the rest of the platform (i.e. see 
TextField/TextArea popover).
   The entry in the popover should be always visible, but not triggerable if 
not necessary (I should check the UI specs though).

3) I'd expect to see a similar MP for the copy action too. Currently the action 
is still visible when no text is actually selected. (TBD in a different branch 
though)

4) Probably we'd like to redesign the whole popover, so that it looks similar 
to the popover used in the TextField/TextArea. We'd need to check if the 
component is publicly available or if we can get its style through a StyledItem.

About the .pot conflict:
If you don't need to update the translations in your branch, remember to "bzr 
revert po/*.pot" before committing. That way you're sure you won't get any 
annoying conflict.

Thank you again! :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into lp:ubuntu-docviewer-app

- So it seems. We've discussed about it some week ago, and it seems to keep 
everything in sync since it waits for the ImageResponse to complete its work on 
the returned image.

- I moved the code that calls the RenderEngine to the image provider. This way 
it is used from the GUI thread and there is no problem with ownership, etc...
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.

Commit message:
* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1452691 in Ubuntu Terminal App: "Standard ANSI blue color is red."
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1452691

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170

* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Comparison: (left: new color scheme - right: old color scheme) 
https://imgur.com/FqnT8GG

QUESTIONS:
* The background is much darker now. That's the background color used in 
SuruDark (UbuntuColors.jet).
  Let me know if we want to use a lighter color (e.g. the UbuntuColors.inkstone 
- currently used as Color0Intense)

* Should intense color be a bit lighter too?
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.
=== modified file 'src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme'
--- src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme	2014-11-16 22:38:02 +
+++ src/plugin/qmltermwidget/lib/color-schemes/Ubuntu.colorscheme	2016-02-05 10:33:19 +
@@ -1,103 +1,138 @@
+# UbuntuColors are taken from:
+# http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging/view/head:/src/Ubuntu/Components/1.3/UbuntuColors.qml
+
+# Colors that are not included in the official palette have been generated with:
+# http://www.color-hex.com/
+
+# Same as Color0 (Black)
 [Background]
 Bold=false
-Color=51,51,51
+Color=17,17,17
 Transparency=false
 
+# Same as Color0Intense (Black)
 [BackgroundIntense]
 Bold=true
-Color=51,51,51
+Color=59,59,59
 Transparency=false
 
+# Black: UbuntuColors.jet
 [Color0]
 Bold=false
-Color=63,63,63
+Color=17,17,17
 Transparency=false
 
+# BlackIntense: UbuntuColors.inkstone
 [Color0Intense]
 Bold=true
-Color=112,144,128
+Color=59,59,59
 Transparency=false
 
+# Red: UbuntuColors.red
 [Color1]
 Bold=false
-Color=112,80,80
+Color=237,49,70
 Transparency=false
 
+# RedIntense: a tint of UbuntuColors.red (#f05a6a)
+# http://www.color-hex.com/color/ed3146
 [Color1Intense]
 Bold=true
-Color=220,163,163
+Color=240,90,106
 Transparency=false
 
+#`Green: UbuntuColors.green
 [Color2]
 Bold=false
-Color=96,180,138
+Color=62,179,79
 Transparency=false
 
+#`GreenIntense: a tint of UbuntuColors.green (#64c272)
+# http://www.color-hex.com/color/3eb34f
 [Color2Intense]
 Bold=true
-Color=114,213,163
+Color=100,194,114
 Transparency=false
 
+# Yellow: analogous of UbuntuColors.orange (#e9b920)
+# http://www.color-hex.com/color/e95420
 [Color3]
 Bold=false
-Color=223,175,143
+Color=223,185,32
 Transparency=false
 
+# YellowIntense: a tint of the yellow above (#edc74c)
+# http://www.color-hex.com/color/e9b920
 [Color3Intense]
 Bold=true
-Color=240,223,175
+Color=237,199,76
 Transparency=false
 
+# Blue: UbuntuColors.blue
 [Color4]
 Bold=false
-Color=220,62,16
+Color=25,182,238
 Transparency=false
 
+# BlueIntense: a tint of UbuntuColors.blue (#46c4f1)
+# http://www.color-hex.com/color/19b6ee
 [Color4Intense]
 Bold=true
-Color=221,72,20
+Color=70,196,241
 Transparency=false
 
+# Magenta: complementary of UbuntuColors.green (#b33ea2)
+# http://www.color-hex.com/color/3eb34f
 [Color5]
 Bold=false
-Color=220,140,195
+Color=179,62,162
 Transparency=false
 
+# MagentaIntense: a tint of the magenta above (#c264b4)
+# http://www.color-hex.com/color/b33ea2
 [Color5Intense]
 Bold=true
-Color=236,147,211
+Color=194,100,180
 Transparency=false
 
+# Cyan: complementary of UbuntuColors.red (#31edd8)
+# http://www.color-hex.com/color/ed3146
 [Color6]
 Bold=false
-Color=140,208,211
+Color=49,237,216
 Transparency=false
 
+# CyanIntense: a tint of the cyan above (#5af0df)
+# http://www.color-hex.com/color/31edd8
 [Color6Intense]
 Bold=true
-Color=147,224,227
+Color=90,240,223
 Transparency=false
 
+# White: UbuntuColors.silk
 [Color7]
 Bold=false
-Color=220,220,204
+Color=193,193,193
 Transparency=false
 
+# WhiteIntense: 255 - UbuntuColors.jet
 [Color7Intense]
 Bold=true
-Color=255,255,255
+Color=236,236,236
 Transparency=false
 
+# Same as Color7 (White)
 [Foreground]
 Bold=false
-Color=220,220,204
+Color=193,193,193
 Transparency=false
 
+# Same as Color7Intense (White)
 [ForegroundIntense]
 Bold=true
-Color=220,220,204
+Color=236,236,236
 Transparency=false
 
 [General]
-Description=Dark Pastels
+Description=Ubuntu
 Opacity=1

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app has been updated.

Description changed to:

* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Comparison: (left: new color scheme - right: old color scheme)
https://imgur.com/FqnT8GG

QUESTIONS:
* The background is much darker now. That's the background color used in 
SuruDark (UbuntuColors.jet).
  Let me know if we want to use a lighter color (e.g. the UbuntuColors.inkstone 
- currently used as Color0Intense)

* Should intense color be a bit lighter too?

Alternatively, I can use the color of the new app-icon as background - RGB(65, 
65, 65).
Visually, it's more consistent with the current palette we're going to replace.

Alt. BG proposal - screenshot: https://imgur.com/Q0fGgY6

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app has been updated.

Description changed to:

* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Comparison: (left: new color scheme - right: old color scheme)
https://imgur.com/FqnT8GG

QUESTIONS:
* The background is much darker now. That's the background color used in 
SuruDark (UbuntuColors.jet).
  Let me know if we want to use a lighter color (e.g. the UbuntuColors.inkstone 
- currently used as Color0Intense)

* Should intense color be a bit lighter too?

Alternatively, I can use the color of the new app-icon as background - RGB(65, 
65, 65).
Visually, it's more consistent with the current palette we're going to replace.

Screenshot: https://imgur.com/Q0fGgY6

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into lp:ubuntu-terminal-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.

Commit message:
* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1452691 in Ubuntu Terminal App: "Standard ANSI blue color is red."
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1452691

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170

* Fixed standard ANSI blue color in the Ubuntu color scheme (previously it was 
red)
* Use the official Ubuntu palette (based on the UbuntuColors singleton of UITK)

Comparison: (left: new color scheme - right: old color scheme) 
https://imgur.com/FqnT8GG

QUESTIONS:
* The background is much darker now. That's the background color used in 
SuruDark (UbuntuColors.jet).
  Let me know if we want to use a lighter color (e.g. the UbuntuColors.inkstone 
- currently used as Color0Intense)

* Should intense color be a bit lighter too?
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into 
lp:ubuntu-terminal-app.
-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into lp:ubuntu-docviewer-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into 
lp:ubuntu-docviewer-app.

Commit message:
Better desktop/pocket-desktop support, by detecting the number of mice and 
touchpads connected to the device. This uses QInputInfo, available in the Qt 
snapshots - imported version from unity 8 trunk (rev.2080).

WORKAROUND: This makes new BottomEdge component fully working on desktop

Requested reviews:
  Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
  Stefano Verzegnassi (verzegnassi-stefano)
  Nicholas Skaggs (nskaggs)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2/+merge/284901

Better desktop/pocket-desktop support, by detecting the number of mice and 
touchpads connected to the device. This uses QInputInfo, available in the Qt 
snapshots - imported version from unity 8 trunk (rev.2080).

WORKAROUND: This makes new BottomEdge component fully working on desktop
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.
=== modified file 'debian/control'
--- debian/control	2016-01-14 21:33:47 +
+++ debian/control	2016-02-03 13:44:53 +
@@ -17,7 +17,9 @@
qtdeclarative5-qtquick2-plugin,
qtdeclarative5-private-dev,
qtbase5-private-dev,
-   qtdeclarative5-test-plugin
+   qtdeclarative5-test-plugin,
+   libudev-dev,
+   libevdev-dev,
 Standards-Version: 3.9.6
 Section: misc
 Homepage: https://launchpad.net/ubuntu-docviewer-app

=== modified file 'src/app/qml/common/ContentHubProxy.qml'
--- src/app/qml/common/ContentHubProxy.qml	2015-10-10 12:03:30 +
+++ src/app/qml/common/ContentHubProxy.qml	2016-02-03 13:44:53 +
@@ -53,11 +53,11 @@
 for (var i=0; i<activeTransfer.items.length; i++) {
 var sourcePath = internal.getPathFromUrl(activeTransfer.items[i].url)
 
-if (DocumentViewer.isFileSupported(sourcePath)) {
-var documentsLocation = DocumentViewer.getXdgDocumentsLocation()
+if (FileUtils.isFileSupported(sourcePath)) {
+var documentsLocation = FileUtils.getXdgDocumentsLocation()
 
 // Check if we have already imported the same document in the past.
-var earlierImportedFile = DocumentViewer.checkIfFileAlreadyImported(sourcePath, [documentsLocation])
+var earlierImportedFile = FileUtils.checkIfFileAlreadyImported(sourcePath, [documentsLocation])
 if (earlierImportedFile.length > 0) {
 // Document has been already imported in the past.
 // Append the path of the earlier copy of the
@@ -65,7 +65,7 @@
 importedDocsModel.append({ path: earlierImportedFile })
 } else {
 // No document has been found, so we can safely copy it.
-var destPath = DocumentViewer.buildDestinationPath(documentsLocation, sourcePath);
+var destPath = FileUtils.buildDestinationPath(documentsLocation, sourcePath);
 
 internal.importDocument(sourcePath, destPath)
 }
@@ -120,7 +120,7 @@
 }
 
 function importDocument(sourcePath, destPath) {
-DocumentViewer.copy(sourcePath, destPath)
+FileUtils.copy(sourcePath, destPath)
 importedDocsModel.append({ path: destPath })
 }
 

=== modified file 'src/app/qml/common/DetailsPage.qml'
--- src/app/qml/common/DetailsPage.qml	2015-12-27 12:10:06 +
+++ src/app/qml/common/DetailsPage.qml	2016-02-03 13:44:53 +
@@ -40,12 +40,12 @@
 
 SubtitledListItem {
 text: i18n.tr("File")
-subText: DocumentViewer.getFileNameFromPath(file.path)
+subText: FileUtils.getFileNameFromPath(file.path)
 }
 
 SubtitledListItem {
 text: i18n.tr("Location")
-subText: DocumentViewer.getCanonicalPath(file.path)
+subText: FileUtils.getCanonicalPath(file.path)
 }
 
 SubtitledListItem {

=== modified file 'src/app/qml/common/PickImportedDialog.qml'
--- src/app/qml/common/PickImportedDialog.qml	2015-12-26 18:27:13 +
+++ src/app/qml/common/PickImportedDialog.qml	2016-02-03 13:44:53 +
@@ -40,7 +40,7 @@
 }
 
 Label {
-text: DocumentViewer.getFileBaseNameFromPath(model.path)
+text: FileUtils.getFileBaseNameFromPath(model.path)
 anchors {
 left: parent.left; right: parent.right
 margins: units.gu(2)

=== modified file 'src/app/qml/loView/LOViewDefaultH

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into lp:ubuntu-docviewer-app

Review: Abstain

Moved the MP to a new branch
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2/+merge/284901
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into lp:ubuntu-docviewer-app

Stefano Verzegnassi has proposed merging 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into 
lp:ubuntu-docviewer-app.

Commit message:
Restored "Start presentation" action in the PDF viewer.
After the merging of the branch with the new bottom-edge component, 
PdfViewDefaultHeader.qml document has been removed and the action hasn't been 
added to the header replacement.

Requested reviews:
  Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost/+merge/284903

Restored "Start presentation" action in the PDF viewer.
After the merging of the branch with the new bottom-edge component, 
PdfViewDefaultHeader.qml document has been removed and the action hasn't been 
added to the header replacement.
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into 
lp:ubuntu-docviewer-app.
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot	2016-02-02 23:59:17 +
+++ po/com.ubuntu.docviewer.pot	2016-02-03 13:53:59 +
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2016-02-03 00:58+0100\n"
+"POT-Creation-Date: 2016-02-03 14:48+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <l...@li.org>\n"
@@ -42,7 +42,7 @@
 
 #: ../src/app/qml/common/DetailsPage.qml:26
 #: ../src/app/qml/loView/LOViewDefaultHeader.qml:107
-#: ../src/app/qml/pdfView/PdfView.qml:227
+#: ../src/app/qml/pdfView/PdfView.qml:235
 #: ../src/app/qml/textView/TextViewDefaultHeader.qml:69
 msgid "Details"
 msgstr ""
@@ -216,7 +216,7 @@
 msgstr ""
 
 #: ../src/app/qml/documentPage/DocumentPage.qml:23
-#: /tmp/spreadsheet-part-selector-build/po/com.ubuntu.docviewer.desktop.in.in.h:3
+#: /tmp/ubuntu-docviewer-app-build/po/com.ubuntu.docviewer.desktop.in.in.h:3
 msgid "Documents"
 msgstr ""
 
@@ -343,13 +343,13 @@
 msgstr ""
 
 #: ../src/app/qml/loView/LOViewDefaultHeader.qml:100
-#: ../src/app/qml/pdfView/PdfView.qml:220
+#: ../src/app/qml/pdfView/PdfView.qml:228
 #: ../src/app/qml/textView/TextViewDefaultHeader.qml:63
 msgid "Disable night mode"
 msgstr ""
 
 #: ../src/app/qml/loView/LOViewDefaultHeader.qml:100
-#: ../src/app/qml/pdfView/PdfView.qml:220
+#: ../src/app/qml/pdfView/PdfView.qml:228
 #: ../src/app/qml/textView/TextViewDefaultHeader.qml:63
 msgid "Enable night mode"
 msgstr ""
@@ -433,6 +433,10 @@
 msgid "Go to page..."
 msgstr ""
 
+#: ../src/app/qml/pdfView/PdfView.qml:221
+msgid "Presentation"
+msgstr ""
+
 #: ../src/app/qml/pdfView/PdfViewGotoDialog.qml:26
 msgid "Go to page"
 msgstr ""
@@ -460,10 +464,10 @@
 msgid "copy %1"
 msgstr ""
 
-#: /tmp/spreadsheet-part-selector-build/po/com.ubuntu.docviewer.desktop.in.in.h:1
+#: /tmp/ubuntu-docviewer-app-build/po/com.ubuntu.docviewer.desktop.in.in.h:1
 msgid "Document Viewer"
 msgstr ""
 
-#: /tmp/spreadsheet-part-selector-build/po/com.ubuntu.docviewer.desktop.in.in.h:2
+#: /tmp/ubuntu-docviewer-app-build/po/com.ubuntu.docviewer.desktop.in.in.h:2
 msgid "documents;viewer;pdf;reader;"
 msgstr ""

=== modified file 'src/app/qml/pdfView/PdfView.qml'
--- src/app/qml/pdfView/PdfView.qml	2016-01-29 12:23:24 +
+++ src/app/qml/pdfView/PdfView.qml	2016-02-03 13:53:59 +
@@ -31,7 +31,7 @@
 header: PageHeader {
 flickable: pdfView
 
-trailingActionBar.actions: [ searchText, goToPage, nightModeToggle, fileDetails ]
+trailingActionBar.actions: [ searchText, goToPage, startPresentation, nightModeToggle, fileDetails ]
 
 contents: ListItemLayout {
 anchors.centerIn: parent
@@ -215,6 +215,14 @@
 }
 
 Action {
+id: startPresentation
+objectName:"presentationmode"
+iconName: "slideshow"
+text: i18n.tr("Presentation")
+onTriggered: pageStack.push(Qt.resolvedUrl("./PdfPresentation.qml"), {'poppler': poppler})
+}
+
+Action {
 id: nightModeToggle
 iconName: "night-mode"
 text: mainView.nightModeEnabled ? i18n.tr("Disable night mode") : i18n.tr("Enable night mode")

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Superseded

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support/+merge/282639
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into lp:ubuntu-docviewer-app

Review: Disapprove

I did some mistake when I merged trunk (.po conflicts). I will create a new 
branch for this and propose a new MP.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support/+merge/282639
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2 into lp:ubuntu-docviewer-app

Review: Needs Fixing

Ok, this requires an unconfined AppArmor template.

No urge to add the missing packages to Jenkins, nor to merge this branch. I 
hope the bottom edge will be fixed upstream, because it's not currently usable 
with a mouse (unless we decide to run unconfined)
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support2/+merge/284901
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost/+merge/284903
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost into lp:ubuntu-docviewer-app

Review: Approve

Top-approving. This fix had to be included in the branches we already landed.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-action-lost/+merge/284903
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

Review: Abstain

I've tested it on my BQ and it works fine! Good work!

However, giving a look at the code I saw there may be some complication in 
keeping this change working in future.

Mine just wants to be a suggestion on how to prevent this from happening, but I 
understand there may be some urgency in getting this patch landed and release a 
new version of terminal-app in the store. For that reason I'll abstain from 
doing a review.

Anyway, it's great to see new people joining the Core Apps team, so thank you! 
:)

P.S. I'd wait for Alan, David or Niklas to provide a review before doing any of 
the changes I suggested.

Diff comments:

> 
> === modified file 'src/app/qml/AuthenticationService.qml'
> --- src/app/qml/AuthenticationService.qml 2016-01-09 01:47:56 +
> +++ src/app/qml/AuthenticationService.qml 2016-02-02 21:39:09 +
> @@ -32,6 +32,8 @@
>  Component.onCompleted: {

Try to move the declaration of AuthenticationService at the end of 
'src/app/qml/ubuntu-terminal-app.qml'.
This 'Component.onCompleted' slot will be executed earlier and the focus will 
be stolen by the terminal.

According to the Qt docs[1], "The order of running the onCompleted handlers is 
undefined."

Although that seems to happen systematically, in theory neither the 
'onCompleted' slot in the main QML file is grant to be executed for last.
Even if the patch works great, it'd be better to do this in a different way. A 
small change in one of the other QML documents can potentially break the focus 
behaviour.

A workaround is to add a Timer component with interval=1, in order to delay the 
execution of the code at the next event loop iteration (i.e. after all the 
'onCompleted' slots have been called).

In the AuthenticationDialog, you can set the keyboard focus as follows:

Timer {
interval: 1
running: true
onTriggered: passwordField.forceActiveFocus()
}

If you do that, please add a comment and mark it as "WORKAROUND" for a future 
reference, explaining the reason why it has been done so.

See 
http://bazaar.launchpad.net/~notes-app-dev/reminders-app/trunk/view/head:/src/app/qml/ui/EditNoteView.qml#L195
 as reference.

Otherwise, you can still perform this this at the 'Component.onCompleted' slot 
of the main QML file. In that case you'd need to expose a boolean property so 
that you can detect whether an authentication is required or not.

==

[1] http://doc.qt.io/qt-5/qml-qtqml-component.html#completed-signal

>  if ( systemAuthentication.requireAuthentication() && 
> !noAuthentication) {
>  displayLoginDialog();
> +} else {
> +tabsModel.selectTab(0);
>  }
>  }
>  
> @@ -49,6 +51,7 @@
>  if ( systemAuthentication.validatePasswordToken( password ) ) {
>  granted();
>  PopupUtils.close( authentication_dialog );
> +tabsModel.selectTab(0);

AuthenticationService has a 'onGranted' signal which I guess should be use for 
performing this operation.

QML aims to create a set of reusable components, so in the 'internal' logic 
there should be only the code strictly necessary for the component itself.

See https://www.ics.com/files/qtdocs/qml-extending-types.html

>  }
>  else {
>  var dialog_options = {
> 
> === modified file 'src/app/qml/ubuntu-terminal-app.qml'
> --- src/app/qml/ubuntu-terminal-app.qml   2016-01-29 02:16:38 +
> +++ src/app/qml/ubuntu-terminal-app.qml   2016-02-02 21:39:09 +
> @@ -125,8 +125,4 @@
>  model: 
> ["GreenOnBlack","WhiteOnBlack","BlackOnWhite","BlackOnRandomLight","Linux","cool-retro-term","DarkPastels","BlackOnLightYellow",
>  "Ubuntu"]
>  }
>  }
> -
> -Component.onCompleted: {

If you go for the tips at the first in-line comment, you can restore the code 
you removed here.

> -tabsModel.selectTab(0);
> -}
>  }


-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app

2016-02-02 Thread Stefano Verzegnassi

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/+merge/282845
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into lp:ubuntu-docviewer-app

2016-02-02 Thread Stefano Verzegnassi

Still building the project against OTA-4 (May, 2014)...
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider/+merge/282878
Your team Ubuntu Document Viewer Developers is requested to review the proposed 
merge of 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-async-imageprovider into 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Stefano Verzegnassi

The bug about the bluetooth keyboard should be easily reproducible on desktop 
too: just ensure to make the auth dialog visible and type some text with your 
USB/PS2/... keyboard.

Currently the keyboard focus is owned by the terminal widget, that's the reason 
why it can be typed some command in the console. Once you properly give the 
focus to the dialog, there's no one to move the focus to another component 
(UITK Dialog itself has some internal that prevents this).

If you need some test on a Ubuntu device, feel free to ping me

Keep up the good work! :)
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Stefano Verzegnassi

Hi Evan!
As long as you only need to test the TextField focus, you can force the auth 
dialog to appear on desktop too. In AuthenticationService.qml, line 33, you can 
remove the 'if' condition, so that the dialog will be always shown on any 
platform.

http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot/view/head:/src/app/qml/AuthenticationService.qml#L33

As a side note, the auth dialog does not get the focus because of the multiple 
requests of 'forceActiveFocus()' during initialization, therefore the focus 
stays on the terminal widget. By fixing this, you will probably fix also the 
bug at:
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1488481/comments/3 
-- 
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502
Your team Ubuntu Terminal Developers is requested to review the proposed merge 
of lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into 
lp:ubuntu-terminal-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data/+merge/283958
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into lp:ubuntu-docviewer-app

Anyway, this was the last issue with paiting we found in these 7 months.
As this branch lands, we can say that the first part of the work on LOK plugin 
is completed! \o/
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data/+merge/283958
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

It seems that Jenkins has run a build on revision 239, but it didn't update the 
review. Top-approving...
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app

The proposal to merge 
lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into 
lp:ubuntu-docviewer-app has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/+merge/282845
-- 
Your team Ubuntu Document Viewer Developers is subscribed to branch 
lp:ubuntu-docviewer-app.

-- 
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app