Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi Marcos, У суб, 17. 01 2009. у 16:31 +0100, Marcos пише: 1.- In Firefox more entries has this output: _firefox-ast.po:28: duplicate message definition... _firefox-ast.po:23: ...this is the location of the first definition But... this isn't a error! :O By example: Google is Google. Firefox PO files (as exported by Launchpad) are special PO files only used for building XPI files, and are not usable for any other uses (unfortunately). There is no use in checking them with msgfmt -cv. 2.- In asturian we have 2 plurals, if we have translated only 1 plural, when we download the template from Launchpad, the command say that exist a wrong plural, because Launchpad not include in the downloaded template the msgstr[1] , only include the translated msgstr[0]. I think is a Launchpad Bug :O I am not sure exactly what you are doing, so if you want Launchpad Translations team to investigate, please ask a question on https://answers.launchpad.net/rosetta with all the details (including what particular PO file and what is causing you problems). Cheers, Danilo -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi Milan, У суб, 17. 01 2009. у 14:18 +0100, Milan Bouchet-Valat пише: I'm sorry if this complaint sounds rude, but the tone of your message and your way of presenting things isn't fair either. We're mostly benevolent people here, and we suffer all the time from Launchpad's framwerok problems I've just described. Launchpad problems are only a (very small) part of the picture here, and Translations team is fixing those already. They could happen only in a very awkward set of events described in bug 317578. As others have noted, a lot of these are actually potential upstream problems, and this analysis should help you detect them and fix them. If you do the right thing and fix them both upstream and in Launchpad, every other distribution would benefit as well. Cheers, Danilo -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: Some details of what happened (was: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.)
Il giorno dom, 18/01/2009 alle 07.39 +0200, Adi Roiban ha scritto: Below is the report based on Base pack: 2009-01-06 00:14:56 EET , but I would add a cron job to update such a page once every 2 weeks. http://l10n.ubuntu.tla.ro/rosetta-hardy-build/ It's great, but there are a lot of false positive in there (at least as I see them and for my own language) like: Last-Translator Project-Id-Version Language-Team (There's also an error like 1 translated message.) Those aren't things you can change directly in Launchpad and that upstream teams usually should deal with. We can check with them though, but it's not always that easy, since, if you don't have the Last-Translator or Language-Team field set, you have to go by trial and error. Anyway, that would be a great addition to our resources! -- Milo Casagrande m...@casagrande.name signature.asc Description: Questa è una parte del messaggio firmata digitalmente -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi! I reviewed the Asturian (ast) translation. It isn't a wrong files! :O The asturian files translation are fine! Only the templates po_gnome-system-monitor-ast in Intrepid has errors by next point 1. But I found this bugs with the command msgfmt -c file.po 1.- In Firefox more entries has this output: _firefox-ast.po:28: duplicate message definition... _firefox-ast.po:23: ...this is the location of the first definition But... this isn't a error! :O By example: Google is Google. 2.- In asturian we have 2 plurals, if we have translated only 1 plural, when we download the template from Launchpad, the command say that exist a wrong plural, because Launchpad not include in the downloaded template the msgstr[1] , only include the translated msgstr[0]. I think is a Launchpad Bug :O Can you confirm this, please? Thanks a lot! Cheers! Marcos. -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
GNOME Dia has been updated upstream. -- Og B. Maciel omac...@foresightlinux.org ogmac...@gnome.org ogmac...@ubuntu.com GPG Keys: D5CFC202 http://www.ogmaciel.com (en_US) http://blog.ogmaciel.com (pt_BR) -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
2009/1/17 Milan Bouchet-Valat nalimi...@club.fr: Hi ! Wouldn't you mind giving us more details about the situation you describe and its causes? You're suddenly coming and telling us that everything is going to collapse and that we need to solve this horrible list of bugs ASAP, without even explaining anything about it. Hear hear -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Some details of what happened (was: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.)
Milan Bouchet-Valat wrote: Wouldn't you mind giving us more details about the situation you describe and its causes? You're suddenly coming and telling us that everything is going to collapse and that we need to solve this horrible list of bugs ASAP, without even explaining anything about it. Sorry for that. At the time of sending the initial mail we only knew we have a security problem at hand which involves buggy translations, which contain formatting placeholders where they shouldn't be. Only now I have some information at hand about what happened and will relay it to you. However, I'm just the messenger, so please don't shoot me. ;) From what I've read and seen in the strings list, we're not in such an emergency. Sure, some strings are not correct and can lead to crashes if % jokers are present when they shouldn't. But this seems to have been the case since the release of Hardy and Intrepid, so no need to stress the teams like that. I really can't see your case here: what's new in Hardy and Intrepid that can break anything? Where does those new strings come from, and why can't they be reverted? We had a number of bug reports about applications crashing in certain circumstances in hardy and intrepid. Since these are stable releases, reports about arbitrary crashes get our attention and we try to fix those issues. If the issue is a security thread, it needs immediate attention and a fix ASAP. Only the bug about libxine crashing, pointed us into the right direction that buggy translations might be involved. ( https://bugs.launchpad.net/ubuntu/+source/xine-lib/+bug/290768 ) We noticed, that if a formatting placeholder is present in a translation where it shouldn't be, the application will read arbitrary data from the stack when this message is displayed. Reading arbitrary data from the stack is a security issue, which needs urgent attention. That's why we raised the flag. As a result, we turned on c-format checking in langpack-o-matic when generating language-packs. This will fail the build if such an error is present in the data. That's why all the buggy data needs to be fixed in Launchpad asap, or we won't get new language-packs. What we know is that these buggy translations came from upstream and got approved in Launchpad. In some cases later updates of those packages fixed the broken strings in the translations, however, they show up as 'suggests' in Rosetta and need to be approved manually. This has unfortunately not happened in many cases. Launchpad does check for c-format errors on translations, but: * it seems not to be enough ( https://bugs.launchpad.net/rosetta/+bug/317578 ) * some buggy translations predated the c-format flag and therefor didn't have one when they actually needed one * in some cases upstream did not set the c-format flag correctly To catch all possible erroneous translations we enforced the c-format flag on all messages when doing our analysis. The outcome ( http://people.ubuntu.com/~arne/langpack_errors/ ) has therefor some false positives. [Quote from Danilo to illustrate the problem] Indeed. c-format and no-c-format flags come from packaged templates, so it's up to them to decide on the proper usage (i.e. Launchpad doesn't have enough knowledge to insert them properly). Note that any approach to find every _potential_ problem would give us a lot of false-positives. I.e. Insert % sign is treated as space-padded %s modifier if marked as c-format string, but is definitely not one. To properly decide if any one case is a genuine problem or not, one would have to dive into the code that uses the string itself. [/Quote] Anyway, I think I'd express quite accurately the feeling of many l10n teams members if I say we're somewhat tired of those problems. Rosetta has allowed people to fork upstream translations when we should only have changed Ubuntu-specific strings. This leads to a terrible mess where small teams have to manage a dramatically large textual domain that they can't really master. Upstream translators work far better than we can do on their projects, and avoid the kind of trouble we're now facing: downstream-modified strings that don't get fixed when upstream updates them. We really need a solution here, like locking translations for packages that belong to upstream. Wouldn't have helped in this case. The buggy translations came from upstream. I agree that in some cases some locking would be useful. But on the other hand, if upstream translations have problems, they can be fixed faster for our users by using Launchpad (especially for stable releases, which don't receive upstream updates anymore except for regression and security fixes). I'm sorry if this complaint sounds rude, but the tone of your message and your way of presenting things isn't fair either. We're mostly benevolent people here, and we suffer all the time from Launchpad's framwerok problems I've just described. We're not here only to obey Canonical, and I think
Re: Some details of what happened (was: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.)
În data de Du, 18-01-2009 la 03:12 +0800, Arne Goetje a scris: [snip] Thanks for taking care of the translations, I know you do this voluntarily and in your free time (I also work on several projects in my limited free time) and I appreciate it. Cheers Arne If we could not automatically fix upstream translations do you think a periodic full translations check would help? I was thinking of creating a webpage similar to your reports and maybe add RSS feeds for each language. Below is the report based on Base pack: 2009-01-06 00:14:56 EET , but I would add a cron job to update such a page once every 2 weeks. http://l10n.ubuntu.tla.ro/rosetta-hardy-build/ What do you say? Kind regards, PS: the junky code is here: https://code.edge.launchpad.net/~adiroiban/+junk/rosetta-check -- Adi Roiban -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi, Original Message Subject: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid. From: Arne Goetje a...@canonical.com Date: Fri, January 16, 2009 3:45 am Dear translation team leads, we have a major problem with translations in Hardy and Intrepid which needs your attention NOW! It turns out that several translated msgstrings contain format strings (i.e. %s, %d, etc.) where the msgid doesn't, or the number of format attributes in msgstr and msgid does not match. This causes several applications to crash! We treat this as a severe regression and security issue which needs urgent attention. We have prepared a list of potentially affected files (attached) and need you to check all of those for this type of error and fix them immediately. We cannot build new langpacks with those faulty strings present in the database. Please see the attached list, investigate and fix the faulty strings. When finished, please report back which languages you have fixed. I cannot stress this enough: this is a severe regression in stable releases. Please mobilize all resources to help fixing this problem. I understand and see the urgency in this case, but this is not going to be easy, really. Take for example, in my case, the kdeprint one... there's no package named that way in the kdebase super-package (and probably kde naming is not going to help us...). I supposed the number next to the package name was the faulty string number, probably it is, but not in Launchpad. Just one example: rosetta-hardy/it/LC_MESSAGES/inkscape.po.c-format:385: This is string 385 in Hardy Italian translation of Inkscape: http://tinyurl.com/9rc5g3 Counting at 3465 strings, it's not going to be easy to search for an error which we have no idea of what is since that translation is 99.99% identical to upstream (only 3 strings have changed for convey to GNOME menu naming scheme and are not even c-format). Really, this is not going to be easy if it's proved to be true for all the packages listed. If that number is the string number, and such in my case there's no visible error, I really have no idea of what's going on. Is it possible to have a more detailed explanation of what those numbers mean or anything else that could cast some light on this issue? Thank you. -- Milo Casagrande m...@casagrande.name -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi! Uhm, I think you can run in Terminal: msgfmt -c name_file.po Or open in Poedit and configure for save as .mo, then Poedit warning you the bugs in file. Cheers ;) On Fri, Jan 16, 2009 at 9:18 AM, Milo Casagrande m...@casagrande.name wrote: Hi, Original Message Subject: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid. From: Arne Goetje a...@canonical.com Date: Fri, January 16, 2009 3:45 am Dear translation team leads, we have a major problem with translations in Hardy and Intrepid which needs your attention NOW! It turns out that several translated msgstrings contain format strings (i.e. %s, %d, etc.) where the msgid doesn't, or the number of format attributes in msgstr and msgid does not match. This causes several applications to crash! We treat this as a severe regression and security issue which needs urgent attention. We have prepared a list of potentially affected files (attached) and need you to check all of those for this type of error and fix them immediately. We cannot build new langpacks with those faulty strings present in the database. Please see the attached list, investigate and fix the faulty strings. When finished, please report back which languages you have fixed. I cannot stress this enough: this is a severe regression in stable releases. Please mobilize all resources to help fixing this problem. I understand and see the urgency in this case, but this is not going to be easy, really. Take for example, in my case, the kdeprint one... there's no package named that way in the kdebase super-package (and probably kde naming is not going to help us...). I supposed the number next to the package name was the faulty string number, probably it is, but not in Launchpad. Just one example: rosetta-hardy/it/LC_MESSAGES/inkscape.po.c-format:385: This is string 385 in Hardy Italian translation of Inkscape: http://tinyurl.com/9rc5g3 Counting at 3465 strings, it's not going to be easy to search for an error which we have no idea of what is since that translation is 99.99% identical to upstream (only 3 strings have changed for convey to GNOME menu naming scheme and are not even c-format). Really, this is not going to be easy if it's proved to be true for all the packages listed. If that number is the string number, and such in my case there's no visible error, I really have no idea of what's going on. Is it possible to have a more detailed explanation of what those numbers mean or anything else that could cast some light on this issue? Thank you. -- Milo Casagrande m...@casagrande.name -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Le Friday 16 January 2009 09:18:48 Milo Casagrande, vous avez écrit : Hi, Dear translation team leads, we have a major problem with translations in Hardy and Intrepid which needs your attention NOW! It turns out that several translated msgstrings contain format strings (i.e. %s, %d, etc.) where the msgid doesn't, or the number of format attributes in msgstr and msgid does not match. This causes several applications to crash! We treat this as a severe regression and security issue which needs urgent attention. We have prepared a list of potentially affected files (attached) and need you to check all of those for this type of error and fix them immediately. We cannot build new langpacks with those faulty strings present in the database. Please see the attached list, investigate and fix the faulty strings. When finished, please report back which languages you have fixed. I cannot stress this enough: this is a severe regression in stable releases. Please mobilize all resources to help fixing this problem. I understand and see the urgency in this case, but this is not going to be easy, really. Take for example, in my case, the kdeprint one... there's no package named that way in the kdebase super-package (and probably kde naming is not going to help us...). I supposed the number next to the package name was the faulty string number, probably it is, but not in Launchpad. Just one example: rosetta-hardy/it/LC_MESSAGES/inkscape.po.c-format:385: This is string 385 in Hardy Italian translation of Inkscape: http://tinyurl.com/9rc5g3 Counting at 3465 strings, it's not going to be easy to search for an error which we have no idea of what is since that translation is 99.99% identical to upstream (only 3 strings have changed for convey to GNOME menu naming scheme and are not even c-format). Really, this is not going to be easy if it's proved to be true for all the packages listed. If that number is the string number, and such in my case there's no visible error, I really have no idea of what's going on. Is it possible to have a more detailed explanation of what those numbers mean or anything else that could cast some light on this issue? This is the output of msgfmt -cv foo.po -o foo.mo command. This is not the string number; this the line number in the .po file. I've downloaded 2 files from rosetta (fr) : kcmlayout.po and kcmgreet.po. I didn't find any errors in the first one. There was an error at line 483 although it's 562 in Arne's report It's nearly impossible to fix all this errors from Rosetta (or at least it's a huge work). We need a direct acces to the .po files, download them, fix them and notfy upstream translators about those issues. -- Bruno -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Arne, this can do more slow Launchpad (more downloads/acces). And for the translators: wait the donwloads. Can you create a repository for a direct download of these files, please? This is only an idea :P Cheers. On Fri, Jan 16, 2009 at 9:38 AM, Bruno Patri bruno.pa...@gmail.com wrote: Le Friday 16 January 2009 09:18:48 Milo Casagrande, vous avez écrit : Hi, Dear translation team leads, we have a major problem with translations in Hardy and Intrepid which needs your attention NOW! It turns out that several translated msgstrings contain format strings (i.e. %s, %d, etc.) where the msgid doesn't, or the number of format attributes in msgstr and msgid does not match. This causes several applications to crash! We treat this as a severe regression and security issue which needs urgent attention. We have prepared a list of potentially affected files (attached) and need you to check all of those for this type of error and fix them immediately. We cannot build new langpacks with those faulty strings present in the database. Please see the attached list, investigate and fix the faulty strings. When finished, please report back which languages you have fixed. I cannot stress this enough: this is a severe regression in stable releases. Please mobilize all resources to help fixing this problem. I understand and see the urgency in this case, but this is not going to be easy, really. Take for example, in my case, the kdeprint one... there's no package named that way in the kdebase super-package (and probably kde naming is not going to help us...). I supposed the number next to the package name was the faulty string number, probably it is, but not in Launchpad. Just one example: rosetta-hardy/it/LC_MESSAGES/inkscape.po.c-format:385: This is string 385 in Hardy Italian translation of Inkscape: http://tinyurl.com/9rc5g3 Counting at 3465 strings, it's not going to be easy to search for an error which we have no idea of what is since that translation is 99.99% identical to upstream (only 3 strings have changed for convey to GNOME menu naming scheme and are not even c-format). Really, this is not going to be easy if it's proved to be true for all the packages listed. If that number is the string number, and such in my case there's no visible error, I really have no idea of what's going on. Is it possible to have a more detailed explanation of what those numbers mean or anything else that could cast some light on this issue? This is the output of msgfmt -cv foo.po -o foo.mo command. This is not the string number; this the line number in the .po file. I've downloaded 2 files from rosetta (fr) : kcmlayout.po and kcmgreet.po. I didn't find any errors in the first one. There was an error at line 483 although it's 562 in Arne's report It's nearly impossible to fix all this errors from Rosetta (or at least it's a huge work). We need a direct acces to the .po files, download them, fix them and notfy upstream translators about those issues. -- Bruno -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Original Message Subject: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid. From: Henning Eggers henning.egg...@canonical.com Date: Fri, January 16, 2009 9:21 am No, I'd expect it to be the line number in the po file. I imagined that but that's not going to be easy anyway... Just another example: subversion for my own language. Looks like there's one string broken. Nobody of our team has ever touched that package, the translation has been like that since 2006. Downloaded it, tested it, no errors. -- Milo Casagrande m...@casagrande.name -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Am 16.01.2009 09:38, Bruno Patri schrieb: I've downloaded 2 files from rosetta (fr) : kcmlayout.po and kcmgreet.po. I didn't find any errors in the first one. There was an error at line 483 although it's 562 in Arne's report The problem here is that if the original file was downloaded before this https://bugs.edge.launchpad.net/rosetta/+bug/173530 was fixed, it will now most likely download in a different order, at least as far as obsolete strings are concerned. So the line numbers do not really help, if you download from Launchpad ... :-( So the way would be to use msgfmt -c to find the current position of the errors. Henning -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
У чет, 15. 01 2009. у 22:09 -0500, Og Maciel пише: I have always thought that Rosetta validated the strings before saving them. Is this a regression or was this data brought in via different means (also with no validation)? This can happen if upstream didn't introduce c-format flag right away. Rosetta doesn't recheck all the translations once c-format flag is added, which I filed as https://bugs.launchpad.net/rosetta/+bug/317578 Also, Ubuntu team wants to fix problems that are unknown even to upstreams (i.e. translations using %-formatting where strings are not even marked as c-format). Basically, this means fixing problems for all upstream projects, and my suggestion would be for everybody involved to file specific bugs so this can be fixed upstream as well. Cheers, Danilo -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Hi Milo, У пет, 16. 01 2009. у 01:46 -0700, Milo Casagrande пише: Original Message Subject: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid. From: Henning Eggers henning.egg...@canonical.com Date: Fri, January 16, 2009 9:21 am No, I'd expect it to be the line number in the po file. I imagined that but that's not going to be easy anyway... Just another example: subversion for my own language. Looks like there's one string broken. Nobody of our team has ever touched that package, the translation has been like that since 2006. Downloaded it, tested it, no errors. One should note that Ubuntu team compiled a list which likely includes a lot of false positives. It's impossible to cover all potential problematic cases (i.e. messages which don't have c-format set, but might need to) without getting a bunch of cases which are not really a problem (is % something a sprintf string or not)? I should point out that helping with this analysis will benefit all upstream translations and programs as well, since I expect everybody to submit improvements upstream as well. Cheers, Danilo -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
Original Message Subject: Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid. From: Danilo Šegan dan...@canonical.com Date: Fri, January 16, 2009 11:53 am One should note that Ubuntu team compiled a list which likely includes a lot of false positives. It's impossible to cover all potential problematic cases (i.e. messages which don't have c-format set, but might need to) without getting a bunch of cases which are not really a problem (is % something a sprintf string or not)? Yes yes, I'll see the point, anyway, we need to msgfmt -cv all of them... I should point out that helping with this analysis will benefit all upstream translations and programs as well, since I expect everybody to submit improvements upstream as well. That's for grant, as long as I can find the errors. -- Milo Casagrande m...@casagrande.name -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
Re: HEADS-UP! URGENT! Major problem with translations for Hardy and Intrepid.
I have always thought that Rosetta validated the strings before saving them. Is this a regression or was this data brought in via different means (also with no validation)? -- Og B. Maciel omac...@foresightlinux.org ogmac...@gnome.org ogmac...@ubuntu.com GPG Keys: D5CFC202 http://www.ogmaciel.com (en_US) http://blog.ogmaciel.com (pt_BR) -- ubuntu-translators mailing list ubuntu-translators@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators
