Re: [PATCH] Xtensa strcoll problem with LOCALE support
Chris Zankel wrote: Hi Carmelo, Sorry, I also forgot to add the 'signed-off' line. Looking at the log file, however, it seems that less than 5% of the commits are 'signed-off'. What's the policy? I'm used to sign-off my work being this a common/required policy on kernel side. I think generally in the open source world it should be add. Just a way to take responsibility for change and also recognition for contribution to the community. I wanted just remember this for the next time. uclibc community is not so sever in policy as glibc ;-). Carmelo Thanks, -Chris Carmelo AMOROSO wrote: Bob Wilson wrote: Carmelo AMOROSO wrote: Hi Bob, I don't see any problems in committing this on behalf of you, but proper signed-off-by should be added to these set of patches, as a general rule of thumbs. Possibly Acked-by Xtensa Maintainer (Chris Zankel) It looks like Chris already committed them, but thanks for offering. Yes he did. I've sent this message a lot before, but due to mail server problems, this has been received jjust few minutes ago. :-) I'll be sure to add a signed-off-by line in the future. Thanks, Carmelo ___ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc ___ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc
Re: [PATCH] Xtensa strcoll problem with LOCALE support
Carmelo AMOROSO wrote: Hi Bob, I don't see any problems in committing this on behalf of you, but proper signed-off-by should be added to these set of patches, as a general rule of thumbs. Possibly Acked-by Xtensa Maintainer (Chris Zankel) It looks like Chris already committed them, but thanks for offering. I'll be sure to add a signed-off-by line in the future. ___ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc
Re: [PATCH] Xtensa strcoll problem with LOCALE support
Bob Wilson wrote: Carmelo AMOROSO wrote: Hi Bob, I don't see any problems in committing this on behalf of you, but proper signed-off-by should be added to these set of patches, as a general rule of thumbs. Possibly Acked-by Xtensa Maintainer (Chris Zankel) It looks like Chris already committed them, but thanks for offering. Yes he did. I've sent this message a lot before, but due to mail server problems, this has been received jjust few minutes ago. :-) I'll be sure to add a signed-off-by line in the future. Thanks, Carmelo ___ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc
[PATCH] Xtensa strcoll problem with LOCALE support
The Xtensa-specific strcmp.S file is testing the __UCLIBC_HAS_LOCALE__ macro but it does not include features.h, so that macro is never defined. This causes problems with strcoll when locale support is enabled. Index: libc/string/xtensa/strcmp.S === --- libc/string/xtensa/strcmp.S (revision 23384) +++ libc/string/xtensa/strcmp.S (working copy) @@ -19,6 +19,7 @@ #include ../../sysdeps/linux/xtensa/sysdep.h #include bits/xtensa-config.h +#include features.h #ifdef __XTENSA_EB__ #define MASK0 0xff00 ___ uClibc mailing list uClibc@uclibc.org http://busybox.net/cgi-bin/mailman/listinfo/uclibc
