Re: Cas Editor POM questions

2009-10-23 Thread Marshall Schor


Jörn Kottmann wrote:
>
>> Another question:  I think the dependency
>>
>>
>>   junit
>>   junit
>>   4.5
>>
>>
>> should have test - is this OK if I change this?
>>   
> I cannot recall the exact reason its done like this, I will find out if
> the scope can be changed to test. It has to do with the unit tests,
> they are a bit different.
>
> The Cas Editor has two kind of tests:
> a) Normal unit tests which are executed when its build (like the other
> unit tests in uima)
> b) Unit tests which must be run inside an eclipse instance.
>
> The latter once can right now only be manually started from
> eclipse. I do that once in a while, and it should be done for the
> release on all supported platforms (Linux, OS X, Windows).
OK.  I think it would be good to add a readme file with these details; 
the goal is to insure that other maintainers will continue to do the
right things. 
> To make these tests work the manifest must at least contain
> junit as an optional dependency (but that should be configured
> correctly).
> The execution of these tests is always a bit tricky, maybe I just changed
> the scope to compile and forgot to switch it back to test.
>
> And then there is maven problem, I do not know how
> to configure two different test source folders, maybe you know.
I think that maven doesn't support more than 1 test directory.  If the
goal of having more than one is to enable running a subset of tests,
say, just the "Normal unit tests" in maven, even though there are
"other" tests there for manual eclipse running, then you can use
surefire plugin parameters (e.g., includes and excludes ) to select
tests to run.

-Marshall
> I googled a bit around bit for me it looks like its only possible to have
> one test source folder.
>
> Jörn
>
>
>
>


Re: Cas Editor POM questions

2009-10-23 Thread Jörn Kottmann



Another question:  I think the dependency

   
  junit
  junit
  4.5
   

should have test - is this OK if I change this?
  

I cannot recall the exact reason its done like this, I will find out if
the scope can be changed to test. It has to do with the unit tests,
they are a bit different.

The Cas Editor has two kind of tests:
a) Normal unit tests which are executed when its build (like the other 
unit tests in uima)

b) Unit tests which must be run inside an eclipse instance.

The latter once can right now only be manually started from
eclipse. I do that once in a while, and it should be done for the
release on all supported platforms (Linux, OS X, Windows).
To make these tests work the manifest must at least contain
junit as an optional dependency (but that should be configured correctly).
The execution of these tests is always a bit tricky, maybe I just changed
the scope to compile and forgot to switch it back to test.

And then there is maven problem, I do not know how
to configure two different test source folders, maybe you know.
I googled a bit around bit for me it looks like its only possible to have
one test source folder.

Jörn




Re: Cas Editor POM questions

2009-10-23 Thread Jörn Kottmann

Marshall Schor wrote:

Marshall Schor wrote:
  

While reviewing the Eclipse tooling, I noticed that the POM for the Cas
Editor has a dependency on

org.eclipse.swt
org.eclipse.swt.win32.win32.x86

If this dependency is removed, there are a lot of compile errors.

But because this dependency is on something with "win32" and "x86" in
the name, does it imply that the Cas Editor tool only runs on x86 /
windows platforms?
  


I found some stuff on the internet that uses the maven "profile"
mechanism to switch the jar depending on the platform/os.  I think that
this setup, as it is now, probably "works", without any of that,
though.  If you try and build this on other platforms, it should still
build (because the x86/win/swt jar is only used for proper compiling,
but isn't used in running (the scope is "provided").  And when you run,
the right version of the jar is "provided" by the Eclipse environment
the plugin is installed into, I think (not tested yet).
  

Yes, exactly, it only needs it to compile, the correct version
is then provided by eclipse. I think there is no need that change
it. The Cas Editor should run on every platform for which
an eclipse runtime exists.

I usually test it on Ubuntu, OS X and once in a while on Windows.

Jörn



Re: Cas Editor POM questions

2009-10-23 Thread Marshall Schor


Marshall Schor wrote:
> While reviewing the Eclipse tooling, I noticed that the POM for the Cas
> Editor has a dependency on
>
> org.eclipse.swt
> org.eclipse.swt.win32.win32.x86
>
> If this dependency is removed, there are a lot of compile errors.
>
> But because this dependency is on something with "win32" and "x86" in
> the name, does it imply that the Cas Editor tool only runs on x86 /
> windows platforms?
>   
I found some stuff on the internet that uses the maven "profile"
mechanism to switch the jar depending on the platform/os.  I think that
this setup, as it is now, probably "works", without any of that,
though.  If you try and build this on other platforms, it should still
build (because the x86/win/swt jar is only used for proper compiling,
but isn't used in running (the scope is "provided").  And when you run,
the right version of the jar is "provided" by the Eclipse environment
the plugin is installed into, I think (not tested yet).

-Marshall
> Another question:  I think the dependency
>
>
>   junit
>   junit
>   4.5
>
>
> should have test - is this OK if I change this?
>
> -Marshall
>  
>
>
>   


Cas Editor POM questions

2009-10-22 Thread Marshall Schor
While reviewing the Eclipse tooling, I noticed that the POM for the Cas
Editor has a dependency on

org.eclipse.swt
org.eclipse.swt.win32.win32.x86

If this dependency is removed, there are a lot of compile errors.

But because this dependency is on something with "win32" and "x86" in
the name, does it imply that the Cas Editor tool only runs on x86 /
windows platforms?

Another question:  I think the dependency

   
  junit
  junit
  4.5
   

should have test - is this OK if I change this?

-Marshall