Re: French Canadian Translation missing from guacamole-1.5.x.war
>They are on Github, in the master branch, but they are not in the >1.5.3 (or 1.5.x) source at all. That's peculiar, I double checked yesterday, and they were there. I must have made an oopsie and confused it with the tarball generated after the build. My mistake then. Thanks for your reply and clarifications. CheersAntoine Le mercredi 9 août 2023 à 15:43:56 UTC+2, Nick Couchman a écrit : On Wed, Aug 9, 2023 at 3:48 AM Antoine Besnier wrote: > > Quick follow up, I decided to build from github, and noticed two new > extensions auth-ban and display-statistics. > > They can be found on Github and in the downloadable source for 1.5.3, and > there is no mention of them in the change log for 1.5.3. They are on Github, in the master branch, but they are not in the 1.5.3 (or 1.5.x) source at all. I just downloaded a clean copy of the source from the website: [vnick@vguac Downloads]$ tar tf guacamole-client-1.5.3.tar.gz |grep display-statistics [vnick@vguac Downloads]$ tar tf guacamole-client-1.5.3.tar.gz |grep auth-ban [vnick@vguac Downloads]$ and also switched to the 1.5.3 tag on Github (screenshot attached), and verified that neither extension exists in either of those source locations. > > There are explanations in the relevant PRs (here and here mostly), but not a > lot more, and they are both flagged for 1.6.0. Yes, these two extensions have been added to the git repo, but were not included in any of the 1.5.x releases. They will be included in 1.6.0 when it is released. > > So, my two and a half questions are: > > Are those extensions officially supported, safe and ready to use with 1.5.3 ? > (they do work well for what I quickly tested) No. In general things should be compatible across the 1.x versions, so they may work, but they are not "officially supported" with the 1.5.x releases. > Is there documentation apart from the PR comments? (there is comment in a PR > that documentation will be issued later) > And if not, shouldn't they be removed from the source archive for 1.5.3 and > only be released with 1.6.0? > Documentation will show up when we actually release it (and the documentation gets written). -Nick - To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org For additional commands, e-mail: user-h...@guacamole.apache.org
Re: French Canadian Translation missing from guacamole-1.5.x.war
On Wed, Aug 9, 2023 at 3:48 AM Antoine Besnier wrote: > > Quick follow up, I decided to build from github, and noticed two new > extensions auth-ban and display-statistics. > > They can be found on Github and in the downloadable source for 1.5.3, and > there is no mention of them in the change log for 1.5.3. They are on Github, in the master branch, but they are not in the 1.5.3 (or 1.5.x) source at all. I just downloaded a clean copy of the source from the website: [vnick@vguac Downloads]$ tar tf guacamole-client-1.5.3.tar.gz |grep display-statistics [vnick@vguac Downloads]$ tar tf guacamole-client-1.5.3.tar.gz |grep auth-ban [vnick@vguac Downloads]$ and also switched to the 1.5.3 tag on Github (screenshot attached), and verified that neither extension exists in either of those source locations. > > There are explanations in the relevant PRs (here and here mostly), but not a > lot more, and they are both flagged for 1.6.0. Yes, these two extensions have been added to the git repo, but were not included in any of the 1.5.x releases. They will be included in 1.6.0 when it is released. > > So, my two and a half questions are: > > Are those extensions officially supported, safe and ready to use with 1.5.3 ? > (they do work well for what I quickly tested) No. In general things should be compatible across the 1.x versions, so they may work, but they are not "officially supported" with the 1.5.x releases. > Is there documentation apart from the PR comments? (there is comment in a PR > that documentation will be issued later) > And if not, shouldn't they be removed from the source archive for 1.5.3 and > only be released with 1.6.0? > Documentation will show up when we actually release it (and the documentation gets written). -Nick - To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org For additional commands, e-mail: user-h...@guacamole.apache.org
Re: French Canadian Translation missing from guacamole-1.5.x.war
Quick follow up, I decided to build from github, and noticed two new extensions auth-ban and display-statistics. They can be found on Github and in the downloadable source for 1.5.3, and there is no mention of them in the change log for 1.5.3. There are explanations in the relevant PRs (here and here mostly), but not a lot more, and they are both flagged for 1.6.0. So, my two and a half questions are: - Are those extensions officially supported, safe and ready to use with 1.5.3 ? (they do work well for what I quickly tested) - Is there documentation apart from the PR comments? (there is comment in a PR that documentation will be issued later) - And if not, shouldn't they be removed from the source archive for 1.5.3 and only be released with 1.6.0? CheersAntoine Le lundi 7 août 2023 à 14:08:37 UTC+2, Antoine Besnier a écrit : Hi Nick, Thanks for the quick reply. I did not notice the 1.6.0 mention in the JIRA page, my bad.IIRC, the list of tickets to be included in 1.5.0 was quite short (in quantity, not in amount of work), so I can understand this one went below the radar. Best regardsAntoine Le lundi 7 août 2023 à 14:00:42 UTC+2, Nick Couchman a écrit : On Mon, Aug 7, 2023 at 5:14 AM Antoine Besnier wrote: > > Hello, > > I maintain a small unofficial Guacamole docker image, and one user raised an > issue about missing French Canadian layout in RDP options. > > Indeed, there was an Jira ticket with an approved PR > (https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-1312?filter=allissues > and > https://github.com/apache/guacamole-server/pull/376/commits/9cbd768210a7b2330b16012748d980cb987ea728), > and the layout is found on github for Guacamole server.** > > There also have been updates to translation files to add the fr_ca mapping to > the user interface of Guacamole Client > (https://github.com/apache/guacamole-client/blame/master/guacamole/src/main/frontend/src/translations/en.json#L678) > > The modification to the translation files was added in March 2022, meaning it > could have been implemented since the 1.5.0 release, but none of the official > WAR files (guacamole-1.5.x.war from > https://guacamole.apache.org/releases/1.5.x/) contain this line, making this > option invisible to users. > > In a similar manner, the Czech translations were approved in the master > branch in November 2022, but are also not included in 1.5.x. > > Would it be possible to have the updated translations files included in the > next release of Guacamole, and in the mean time, is my only option to build > the client from github? Hello, Antoine, The Jira issue that you linked, GUACAMOLE-1312, is tagged for the 1.6.0 release. I'm not entirely sure why it didn't make it into 1.5.0, but the releases since 1.5.0 have been bugfix releases where we've not added any features, however minor they may be. I think we may have a 1.5.4 release to fix a minor bug, but I would expect we'll head toward 1.6.0 relatively soon, and it should be included in that. -Nick - To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org For additional commands, e-mail: user-h...@guacamole.apache.org
