Re: Assembly Issue

2018-04-16 Thread Greg Logan 
Hi JB,

Thanks, I'll get that change made.  Any other suggestions?  Any other
debugging steps that would be more likely to trigger this or provide more
information?

G

On Tue, Apr 10, 2018 at 8:35 AM, Jean-Baptiste Onofré 
wrote:

> It's better yes and the "model" is not exactly the same.
>
> Regards
> JB
>
> On 10/04/2018 16:32, Greg Logan wrote:
>
>> Hi JB,
>>
>> Our main pom has the Karaf version at 4.0.10, and the assembly plugin at
>> 3.1.0.  Should they be version locked?
>>
>> G
>>
>> On Mon, Apr 9, 2018 at 9:41 PM, Jean-Baptiste Onofré > > wrote:
>>
>> Hi Greg,
>>
>> you said 4.0.10 for Karaf version (in the Jira). It's also the Karaf
>> maven
>> plugin version right ?
>>
>> Thanks !
>> Regards
>> JB
>>
>> On 04/10/2018 12:34 AM, Greg Logan wrote:
>> > Filed at https://jira.apache.org/jira/browse/KARAF-5693
>> , with attached build
>> > logs and .properties files.
>> >
>> > The assembly doesn't seem to matter, although we definitely notice
>> it more with
>> > allinone since that's the one that gets used for testing mainly!
>> >
>> > G
>> >
>> > On Mon, Apr 9, 2018 at 3:54 PM, Guillaume Nodet > 
>> > >> wrote:
>> >
>> >
>> >
>> > 2018-04-09 23:38 GMT+02:00 Greg Logan > 
>>  > > >>:
>> >
>> > Hi all,
>> >
>> > Building Opencast (https://github.com/opencast/opencast
>> 
>>  > > >), our final step is packaging
>> > into assemblies (assemblies/pom.xml).  Since I haven't seen
>> this
>> > elsewhere it's hard to really give you a small reproducible
>> test case,
>> > but at least it's part of the final steps rather than
>> requiring a full
>> > build.
>> >
>> > Which project should I file the bug against?  Karaf
>> itself?  Or Maven
>> > Assembly Plugin?
>> >
>> >
>> > Karaf please.
>> >
>> > Is there a specific assembly failing ? When you say the
>> config.properties
>> > file is corrupted, what does it look like ?
>> >  >
>> >
>> > Thanks,
>> > G
>> >
>> > On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet <
>> gno...@apache.org 
>> > >>
>> wrote:
>> >
>> > It may be a thread issue while building the assembly.
>> > Please raise a JIRA and attach what you have, a way to
>> reproduce the
>> > issue would be helpful.
>> >
>> > Guillaume
>> >
>> > 2018-04-09 19:15 GMT+02:00 Greg Logan <
>> gregorydlo...@gmail.com 
>>  > >
>> >>:
>>  >
>>  > Hi all,
>>  >
>>  > We're running into an issue where rarely (1/20 or
>> so) of our
>>  > assembly builds end up with a corrupted
>> config.properties file -
>>  > multiple libraries are missing from the file and
>> thus our code
>>  > fails to start because the dependencies are
>> missing.  I took a
>>  > quick look through JIRA and could not find a
>> related issue, but
>>  > I could also be searching for the wrong things...
>>  >
>>  > Is this something that rings a bell with anyone?
>>I have a
>>  > snapshot of both a known good, and known bad
>> build, but
>>  > subsequent builds of the same version of our
>> codebase yield
>>  > working builds.  There don't appear to be any
>> error messages in
>>  > the final assembly packaging logs, so I'm not
>> even really sure
>>  > where to start debugging.
>>  >
>>  > G
>>  >
>>  >
>>  >
>>  >
>>  > --
>>  > 
>>  > Guillaume Nodet
>>  >
>>  >
>>  >
>>  >
>>  >
>>  > --
>>  > 
>>  > Guillaume Nodet
>>  >
>>  >
>>
>> --
>> Jean-Baptiste Onofré
>> jbono...@apache.org 
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>>

Re: Assembly Issue

2018-04-10 Thread Jean-Baptiste Onofré 

It's better yes and the "model" is not exactly the same.

Regards
JB

On 10/04/2018 16:32, Greg Logan wrote:

Hi JB,

Our main pom has the Karaf version at 4.0.10, and the assembly plugin at 
3.1.0.  Should they be version locked?


G

On Mon, Apr 9, 2018 at 9:41 PM, Jean-Baptiste Onofré > wrote:


Hi Greg,

you said 4.0.10 for Karaf version (in the Jira). It's also the Karaf
maven
plugin version right ?

Thanks !
Regards
JB

On 04/10/2018 12:34 AM, Greg Logan wrote:
> Filed at https://jira.apache.org/jira/browse/KARAF-5693
, with attached build
> logs and .properties files.
>
> The assembly doesn't seem to matter, although we definitely notice it 
more with
> allinone since that's the one that gets used for testing mainly!
>
> G
>
> On Mon, Apr 9, 2018 at 3:54 PM, Guillaume Nodet 
> >> wrote:
>
>
>
>     2018-04-09 23:38 GMT+02:00 Greg Logan 
 >     >>:
>
>         Hi all,
>
>         Building Opencast (https://github.com/opencast/opencast

 >         >), our final step is packaging
>         into assemblies (assemblies/pom.xml).  Since I haven't seen this
>         elsewhere it's hard to really give you a small reproducible test 
case,
>         but at least it's part of the final steps rather than requiring a 
full
>         build.
>
>         Which project should I file the bug against?  Karaf itself?  Or 
Maven
>         Assembly Plugin?
>
>
>     Karaf please.
>
>     Is there a specific assembly failing ? When you say the 
config.properties
>     file is corrupted, what does it look like ?
>  
>

>
>         Thanks,
>         G
>
>         On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet 
>         >> wrote:
>
>             It may be a thread issue while building the assembly.
>             Please raise a JIRA and attach what you have, a way to 
reproduce the
>             issue would be helpful.
>
>             Guillaume
>
>             2018-04-09 19:15 GMT+02:00 Greg Logan 
 >             >>:
 >
 >                 Hi all,
 >
 >                 We're running into an issue where rarely (1/20 or
so) of our
 >                 assembly builds end up with a corrupted
config.properties file -
 >                 multiple libraries are missing from the file and
thus our code
 >                 fails to start because the dependencies are
missing.  I took a
 >                 quick look through JIRA and could not find a
related issue, but
 >                 I could also be searching for the wrong things...
 >
 >                 Is this something that rings a bell with anyone? 
I have a

 >                 snapshot of both a known good, and known bad
build, but
 >                 subsequent builds of the same version of our
codebase yield
 >                 working builds.  There don't appear to be any
error messages in
 >                 the final assembly packaging logs, so I'm not
even really sure
 >                 where to start debugging.
 >
 >                 G
 >
 >
 >
 >
 >             --
 >             
 >             Guillaume Nodet
 >
 >
 >
 >
 >
 >     --
 >     
 >     Guillaume Nodet
 >
 >

--
Jean-Baptiste Onofré
jbono...@apache.org 
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Assembly Issue

2018-04-10 Thread Greg Logan 
Hi JB,

Our main pom has the Karaf version at 4.0.10, and the assembly plugin at
3.1.0.  Should they be version locked?

G

On Mon, Apr 9, 2018 at 9:41 PM, Jean-Baptiste Onofré 
wrote:

> Hi Greg,
>
> you said 4.0.10 for Karaf version (in the Jira). It's also the Karaf maven
> plugin version right ?
>
> Thanks !
> Regards
> JB
>
> On 04/10/2018 12:34 AM, Greg Logan wrote:
> > Filed at https://jira.apache.org/jira/browse/KARAF-5693, with attached
> build
> > logs and .properties files.
> >
> > The assembly doesn't seem to matter, although we definitely notice it
> more with
> > allinone since that's the one that gets used for testing mainly!
> >
> > G
> >
> > On Mon, Apr 9, 2018 at 3:54 PM, Guillaume Nodet  > > wrote:
> >
> >
> >
> > 2018-04-09 23:38 GMT+02:00 Greg Logan  > >:
> >
> > Hi all,
> >
> > Building Opencast (https://github.com/opencast/opencast
> > ), our final step is
> packaging
> > into assemblies (assemblies/pom.xml).  Since I haven't seen this
> > elsewhere it's hard to really give you a small reproducible test
> case,
> > but at least it's part of the final steps rather than requiring
> a full
> > build.
> >
> > Which project should I file the bug against?  Karaf itself?  Or
> Maven
> > Assembly Plugin?
> >
> >
> > Karaf please.
> >
> > Is there a specific assembly failing ? When you say the
> config.properties
> > file is corrupted, what does it look like ?
> >
> >
> >
> > Thanks,
> > G
> >
> > On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet <
> gno...@apache.org
> > > wrote:
> >
> > It may be a thread issue while building the assembly.
> > Please raise a JIRA and attach what you have, a way to
> reproduce the
> > issue would be helpful.
> >
> > Guillaume
> >
> > 2018-04-09 19:15 GMT+02:00 Greg Logan <
> gregorydlo...@gmail.com
> > >:
> >
> > Hi all,
> >
> > We're running into an issue where rarely (1/20 or so) of
> our
> > assembly builds end up with a corrupted
> config.properties file -
> > multiple libraries are missing from the file and thus
> our code
> > fails to start because the dependencies are missing.  I
> took a
> > quick look through JIRA and could not find a related
> issue, but
> > I could also be searching for the wrong things...
> >
> > Is this something that rings a bell with anyone?  I have
> a
> > snapshot of both a known good, and known bad build, but
> > subsequent builds of the same version of our codebase
> yield
> > working builds.  There don't appear to be any error
> messages in
> > the final assembly packaging logs, so I'm not even
> really sure
> > where to start debugging.
> >
> > G
> >
> >
> >
> >
> > --
> > 
> > Guillaume Nodet
> >
> >
> >
> >
> >
> > --
> > 
> > Guillaume Nodet
> >
> >
>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: Assembly Issue

2018-04-09 Thread Jean-Baptiste Onofré 
Hi Greg,

you said 4.0.10 for Karaf version (in the Jira). It's also the Karaf maven
plugin version right ?

Thanks !
Regards
JB

On 04/10/2018 12:34 AM, Greg Logan wrote:
> Filed at https://jira.apache.org/jira/browse/KARAF-5693, with attached build
> logs and .properties files.
> 
> The assembly doesn't seem to matter, although we definitely notice it more 
> with
> allinone since that's the one that gets used for testing mainly!
> 
> G
> 
> On Mon, Apr 9, 2018 at 3:54 PM, Guillaume Nodet  > wrote:
> 
> 
> 
> 2018-04-09 23:38 GMT+02:00 Greg Logan  >:
> 
> Hi all,
> 
> Building Opencast (https://github.com/opencast/opencast
> ), our final step is packaging
> into assemblies (assemblies/pom.xml).  Since I haven't seen this
> elsewhere it's hard to really give you a small reproducible test case,
> but at least it's part of the final steps rather than requiring a full
> build.
> 
> Which project should I file the bug against?  Karaf itself?  Or Maven
> Assembly Plugin?
> 
> 
> Karaf please.
> 
> Is there a specific assembly failing ? When you say the config.properties
> file is corrupted, what does it look like ?
>  
> 
> 
> Thanks,
> G
> 
> On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet  > wrote:
> 
> It may be a thread issue while building the assembly.
> Please raise a JIRA and attach what you have, a way to reproduce 
> the
> issue would be helpful.
> 
> Guillaume
> 
> 2018-04-09 19:15 GMT+02:00 Greg Logan  >:
> 
> Hi all,
> 
> We're running into an issue where rarely (1/20 or so) of our
> assembly builds end up with a corrupted config.properties 
> file -
> multiple libraries are missing from the file and thus our code
> fails to start because the dependencies are missing.  I took a
> quick look through JIRA and could not find a related issue, 
> but
> I could also be searching for the wrong things...
> 
> Is this something that rings a bell with anyone?  I have a
> snapshot of both a known good, and known bad build, but
> subsequent builds of the same version of our codebase yield
> working builds.  There don't appear to be any error messages 
> in
> the final assembly packaging logs, so I'm not even really sure
> where to start debugging.
> 
> G
> 
> 
> 
> 
> -- 
> 
> Guillaume Nodet
> 
> 
> 
> 
> 
> -- 
> 
> Guillaume Nodet
> 
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Assembly Issue

2018-04-09 Thread Greg Logan 
Filed at https://jira.apache.org/jira/browse/KARAF-5693, with attached
build logs and .properties files.

The assembly doesn't seem to matter, although we definitely notice it more
with allinone since that's the one that gets used for testing mainly!

G

On Mon, Apr 9, 2018 at 3:54 PM, Guillaume Nodet  wrote:

>
>
> 2018-04-09 23:38 GMT+02:00 Greg Logan :
>
>> Hi all,
>>
>> Building Opencast (https://github.com/opencast/opencast), our final step
>> is packaging into assemblies (assemblies/pom.xml).  Since I haven't seen
>> this elsewhere it's hard to really give you a small reproducible test case,
>> but at least it's part of the final steps rather than requiring a full
>> build.
>>
>> Which project should I file the bug against?  Karaf itself?  Or Maven
>> Assembly Plugin?
>>
>
> Karaf please.
>
> Is there a specific assembly failing ? When you say the config.properties
> file is corrupted, what does it look like ?
>
>
>>
>> Thanks,
>> G
>>
>> On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet 
>> wrote:
>>
>>> It may be a thread issue while building the assembly.
>>> Please raise a JIRA and attach what you have, a way to reproduce the
>>> issue would be helpful.
>>>
>>> Guillaume
>>>
>>> 2018-04-09 19:15 GMT+02:00 Greg Logan :
>>>
 Hi all,

 We're running into an issue where rarely (1/20 or so) of our assembly
 builds end up with a corrupted config.properties file - multiple libraries
 are missing from the file and thus our code fails to start because the
 dependencies are missing.  I took a quick look through JIRA and could not
 find a related issue, but I could also be searching for the wrong things...

 Is this something that rings a bell with anyone?  I have a snapshot of
 both a known good, and known bad build, but subsequent builds of the same
 version of our codebase yield working builds.  There don't appear to be any
 error messages in the final assembly packaging logs, so I'm not even really
 sure where to start debugging.

 G

>>>
>>>
>>>
>>> --
>>> 
>>> Guillaume Nodet
>>>
>>>
>>
>
>
> --
> 
> Guillaume Nodet
>
>

Re: Assembly Issue

2018-04-09 Thread Guillaume Nodet 
Fwiw, one possible suspect is the following code:

https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L1484-L1497
The access to the config properties are not synchronized.

2018-04-09 23:54 GMT+02:00 Guillaume Nodet :

>
>
> 2018-04-09 23:38 GMT+02:00 Greg Logan :
>
>> Hi all,
>>
>> Building Opencast (https://github.com/opencast/opencast), our final step
>> is packaging into assemblies (assemblies/pom.xml).  Since I haven't seen
>> this elsewhere it's hard to really give you a small reproducible test case,
>> but at least it's part of the final steps rather than requiring a full
>> build.
>>
>> Which project should I file the bug against?  Karaf itself?  Or Maven
>> Assembly Plugin?
>>
>
> Karaf please.
>
> Is there a specific assembly failing ? When you say the config.properties
> file is corrupted, what does it look like ?
>
>
>>
>> Thanks,
>> G
>>
>> On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet 
>> wrote:
>>
>>> It may be a thread issue while building the assembly.
>>> Please raise a JIRA and attach what you have, a way to reproduce the
>>> issue would be helpful.
>>>
>>> Guillaume
>>>
>>> 2018-04-09 19:15 GMT+02:00 Greg Logan :
>>>
 Hi all,

 We're running into an issue where rarely (1/20 or so) of our assembly
 builds end up with a corrupted config.properties file - multiple libraries
 are missing from the file and thus our code fails to start because the
 dependencies are missing.  I took a quick look through JIRA and could not
 find a related issue, but I could also be searching for the wrong things...

 Is this something that rings a bell with anyone?  I have a snapshot of
 both a known good, and known bad build, but subsequent builds of the same
 version of our codebase yield working builds.  There don't appear to be any
 error messages in the final assembly packaging logs, so I'm not even really
 sure where to start debugging.

 G

>>>
>>>
>>>
>>> --
>>> 
>>> Guillaume Nodet
>>>
>>>
>>
>
>
> --
> 
> Guillaume Nodet
>
>


-- 

Guillaume Nodet

Re: Assembly Issue

2018-04-09 Thread Guillaume Nodet 
2018-04-09 23:38 GMT+02:00 Greg Logan :

> Hi all,
>
> Building Opencast (https://github.com/opencast/opencast), our final step
> is packaging into assemblies (assemblies/pom.xml).  Since I haven't seen
> this elsewhere it's hard to really give you a small reproducible test case,
> but at least it's part of the final steps rather than requiring a full
> build.
>
> Which project should I file the bug against?  Karaf itself?  Or Maven
> Assembly Plugin?
>

Karaf please.

Is there a specific assembly failing ? When you say the config.properties
file is corrupted, what does it look like ?


>
> Thanks,
> G
>
> On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet  wrote:
>
>> It may be a thread issue while building the assembly.
>> Please raise a JIRA and attach what you have, a way to reproduce the
>> issue would be helpful.
>>
>> Guillaume
>>
>> 2018-04-09 19:15 GMT+02:00 Greg Logan :
>>
>>> Hi all,
>>>
>>> We're running into an issue where rarely (1/20 or so) of our assembly
>>> builds end up with a corrupted config.properties file - multiple libraries
>>> are missing from the file and thus our code fails to start because the
>>> dependencies are missing.  I took a quick look through JIRA and could not
>>> find a related issue, but I could also be searching for the wrong things...
>>>
>>> Is this something that rings a bell with anyone?  I have a snapshot of
>>> both a known good, and known bad build, but subsequent builds of the same
>>> version of our codebase yield working builds.  There don't appear to be any
>>> error messages in the final assembly packaging logs, so I'm not even really
>>> sure where to start debugging.
>>>
>>> G
>>>
>>
>>
>>
>> --
>> 
>> Guillaume Nodet
>>
>>
>


-- 

Guillaume Nodet

Re: Assembly Issue

2018-04-09 Thread Greg Logan 
Hi all,

Building Opencast (https://github.com/opencast/opencast), our final step is
packaging into assemblies (assemblies/pom.xml).  Since I haven't seen this
elsewhere it's hard to really give you a small reproducible test case, but
at least it's part of the final steps rather than requiring a full build.

Which project should I file the bug against?  Karaf itself?  Or Maven
Assembly Plugin?

Thanks,
G

On Mon, Apr 9, 2018 at 1:20 PM, Guillaume Nodet  wrote:

> It may be a thread issue while building the assembly.
> Please raise a JIRA and attach what you have, a way to reproduce the issue
> would be helpful.
>
> Guillaume
>
> 2018-04-09 19:15 GMT+02:00 Greg Logan :
>
>> Hi all,
>>
>> We're running into an issue where rarely (1/20 or so) of our assembly
>> builds end up with a corrupted config.properties file - multiple libraries
>> are missing from the file and thus our code fails to start because the
>> dependencies are missing.  I took a quick look through JIRA and could not
>> find a related issue, but I could also be searching for the wrong things...
>>
>> Is this something that rings a bell with anyone?  I have a snapshot of
>> both a known good, and known bad build, but subsequent builds of the same
>> version of our codebase yield working builds.  There don't appear to be any
>> error messages in the final assembly packaging logs, so I'm not even really
>> sure where to start debugging.
>>
>> G
>>
>
>
>
> --
> 
> Guillaume Nodet
>
>

Re: Assembly Issue

2018-04-09 Thread Guillaume Nodet 
It may be a thread issue while building the assembly.
Please raise a JIRA and attach what you have, a way to reproduce the issue
would be helpful.

Guillaume

2018-04-09 19:15 GMT+02:00 Greg Logan :

> Hi all,
>
> We're running into an issue where rarely (1/20 or so) of our assembly
> builds end up with a corrupted config.properties file - multiple libraries
> are missing from the file and thus our code fails to start because the
> dependencies are missing.  I took a quick look through JIRA and could not
> find a related issue, but I could also be searching for the wrong things...
>
> Is this something that rings a bell with anyone?  I have a snapshot of
> both a known good, and known bad build, but subsequent builds of the same
> version of our codebase yield working builds.  There don't appear to be any
> error messages in the final assembly packaging logs, so I'm not even really
> sure where to start debugging.
>
> G
>



-- 

Guillaume Nodet

Re: Assembly Issue

2018-04-09 Thread Jean-Baptiste Onofré 

Hi Greg,

never had this issue. Can you share a test case to take a look ?

Regards
JB

On 09/04/2018 19:15, Greg Logan wrote:

Hi all,

We're running into an issue where rarely (1/20 or so) of our assembly 
builds end up with a corrupted config.properties file - multiple 
libraries are missing from the file and thus our code fails to start 
because the dependencies are missing.  I took a quick look through JIRA 
and could not find a related issue, but I could also be searching for 
the wrong things...


Is this something that rings a bell with anyone?  I have a snapshot of 
both a known good, and known bad build, but subsequent builds of the 
same version of our codebase yield working builds.  There don't appear 
to be any error messages in the final assembly packaging logs, so I'm 
not even really sure where to start debugging.


G

Assembly Issue

2018-04-09 Thread Greg Logan 
Hi all,

We're running into an issue where rarely (1/20 or so) of our assembly
builds end up with a corrupted config.properties file - multiple libraries
are missing from the file and thus our code fails to start because the
dependencies are missing.  I took a quick look through JIRA and could not
find a related issue, but I could also be searching for the wrong things...

Is this something that rings a bell with anyone?  I have a snapshot of both
a known good, and known bad build, but subsequent builds of the same
version of our codebase yield working builds.  There don't appear to be any
error messages in the final assembly packaging logs, so I'm not even really
sure where to start debugging.

G