Re: is there a better way of creating SQL queries from form objects ?

[Sean Burlington]

Erik Weber wrote:
As far as the implementation goes, there is no reason to be scared of 
switches and loops. (But favor polymorphism/virtual functions over a 
giant loop.) However, you should get rid of all those concat operators 
and use StringBuffer.append instead. The performance will improve 
significantly.

thanks Eric
polymorphism - that was the word I needed :-)
now google can help me ...
--
Sean
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: is there a better way of creating SQL queries from form objects ?

[Sean Burlington]

Rick Reumann wrote:
Look into using iBATIS http://www.ibatis.com. It's easy to use and will 
handle this kind of dynamic SQL very nicel (the PDF instruction manual 
is nice. Look at the SQL Maps documentatoin under Dynamic Mapped 
Statements.)

that's a bigger change in coding than I was thinking of ...
but interesting - what advantages does this have over hibernate ?
--
Sean
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: is there a better way of creating SQL queries from form objec ts ?

[Sean Burlington]

Benedict, Paul C wrote:
Sean,
Have you thought about constructing a DAO/Adapater object that receives your
input, and then does the notorious SQL-string building on the inside? If you
cannot get the elegant solution, you should at least make it appear elegant
by wrapping it inside of the DAO layer.

yes - I've done that bit :-)
I'm a solo in-house programmer and sometimes I worry that I'm doing 
things like this badly.

your comment "notorious SQL-string building" makes me think maybe I'm 
not doing so bad and that this is just a pain

Cheers for the advice
--
Sean

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

is there a better way of creating SQL queries from form objects ?

[Sean Burlington]

Hi all,
	this is such a common problem that I'm sure there must be loads of 
advice on how to deal with it - I just can't find it.

I have a database containing many records
Searches can be performed on several text fields - and refined by 
boolean fields.

The html form thus consist of several text inputs and several checkboxes.
Only one text box should ever be filled in.
I can work out the resultant sql query by using lots of if statements as 
below but it just doesn't seem very elegant ...

I could also break the search down into several forms and so different 
actions - but this seems overly complex.

String query = "select order from po where";
String searchTerm = "";
if (!"".equals(search.getCode())){
query += " code=?";
searchTerm = search.getCode();
} else if (!"".equals(search.getParish())){
query += " parish=?";
searchTerm = search.getParish();
} else if (!"".equals(search.getDetails())){
query += " details=?";
searchTerm = search.getDetails();
}
if (search.isActiveMods()){
query += " and active";
}
if (search.isActiveReclass()){
query += " and reclass";
}
PreparedStatement statement = conn.prepareStatement(query);
statement.setString(1, searchTerm);
--
Sean
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]