Re: FieldChecks change signature and no longer returns value
No, I'm not responsible - all I did was let them know they didn't have the current release of struts on their site. I don't know much about gentoo (first I heard of it was from you!), but its probably best to post a bug here: http://bugs.gentoo.org Niall - Original Message - From: Mick Wever [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, October 14, 2004 4:28 PM Subject: Re: FieldChecks change signature and no longer returns value Gentoo now has the latest version. You're responsible for the ebuild? Thanks! But doesn't build: Source unpacked. Buildfile: build.xml does not exist! Build failed Mick. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: FieldChecks change signature and no longer returns value
Gentoo now has the latest version. You're responsible for the ebuild? Thanks! But doesn't build: Source unpacked. Buildfile: build.xml does not exist! Build failed Mick. -- ---BR/ The reward of patience is patience. St. Augustine BR/ a href=http://www.harryspractice.com.auHarry's Practice/a BR/--- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: FieldChecks change signature and no longer returns value
Version 1.2.2 was downgraded from ga quality because of problems so its not a good idea to use it in general. Current release version is 1.2.4 and this issue was fixed in that version. http://issues.apache.org/bugzilla/show_bug.cgi?id=26413 Niall P.S. I assume you meant FieldsCheck.validateInteger(..) rather than checkInteger() - Original Message - From: Mick Wever [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, October 12, 2004 3:19 PM Subject: FieldChecks change signature and no longer returns value After updating to version 1.2.2 FieldsCheck.checkInteger(..) now returns a boolean indicating success rather the value. This has broken our code and we need the value. Is there a substitute method now? Mick. -- BR/ It is not enough to have a good mind; the main thing is to use it well. Descartes - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: FieldChecks change signature and no longer returns value
After updating to version 1.2.2
FieldsCheck.validateInteger(..) now returns a boolean indicating success
rather the value. This has broken our code and we need the value. Is
there a substitute method now?
I've tracked this down to a patch done under bug#26413.
http://issues.apache.org/bugzilla/show_bug.cgi?id=26413
Changing signatures like this is bad API development.
This change has royally screwed me.
Now I have to copy _ALL_ of the code in FieldChecks.validateInteger(..)
into our application just to get the value again.
IMHO it would have been much much better api development to provide
wrapper methods around the existing validateXXX methods that provided the
fix you wanted.
For example:
public static boolean validatableInteger(Object bean,
ValidatorAction va, Field field,
ActionMessages errors,
HttpServletRequest request) {
return validateInteger(bean,va,field,errors,request) == null
? false : true;
}
This would not break the API, and would solve this issue.
I'm not sure validatable is a word? But you get my drift.
Mick
--
BR/ It is not enough to have a good mind; the main thing is to use it well.
Descartes
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: FieldChecks change signature and no longer returns value
Version 1.2.2 was downgraded from ga quality because of problems so its not a good idea to use it in general. Current release version is 1.2.4 and this issue was fixed in that version. Sorry, failed to look that far ahead :$ Gentoo, unfortunately is still publishing 1.2.2 :( P.S. I assume you meant FieldsCheck.validateInteger(..) rather than checkInteger() Yes, indeed. -- BR/ The ultimate measure of a man is not where he stands in moments of comfort and convenience but where he stands at times of challenge and controversy. Martin Luther King - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: FieldChecks change signature and no longer returns value
Gentoo now has the latest version. Niall - Original Message - From: Mick Wever [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, October 12, 2004 4:01 PM Subject: Re: FieldChecks change signature and no longer returns value Version 1.2.2 was downgraded from ga quality because of problems so its not a good idea to use it in general. Current release version is 1.2.4 and this issue was fixed in that version. Sorry, failed to look that far ahead :$ Gentoo, unfortunately is still publishing 1.2.2 :( P.S. I assume you meant FieldsCheck.validateInteger(..) rather than checkInteger() Yes, indeed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
