Re: S2I and git-lfs

[Philippe Lafoucrière]

On Mon, Jan 16, 2017 at 12:40 PM, Jonathan Yu  wrote:

> What about git-annex? https://apps.fedoraproject.org/packages/git-annex
>

Unfortunately, we don't manage what our clients are using. LFS is now
supported directly in Github, Gitlab, and Bitbucket (and probably others),
which makes the best candidate for this feature.

Thanks,
Philippe
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Clayton Coleman]

We would probably need help getting git-lfs packaged first.  That's really
the biggest blocker to enabling it by default.

On Jan 16, 2017, at 9:40 AM, Philippe Lafoucrière <
philippe.lafoucri...@tech-angels.com> wrote:

@Clayton, does it sound reasonable to you to ask for LFS support in s2i?
If yes, where should this ticket go?
https://github.com/openshift/source-to-image ?

Thanks

​
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Philippe Lafoucrière]

@Clayton, does it sound reasonable to you to ask for LFS support in s2i?
If yes, where should this ticket go?
https://github.com/openshift/source-to-image ?

Thanks

​
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Ben Parees]

On Thu, Jan 12, 2017 at 8:36 PM, Clayton Coleman 
wrote:

> Is git-lfs packaged in epel ben?
>

​does not appear to be, no.  There is a rhel package, but it's not produced
by us:
https://github.com/git-lfs/git-lfs/wiki/Installation#rhelcentos
​



>
> On Jan 12, 2017, at 4:10 PM, Philippe Lafoucrière <
> philippe.lafoucri...@tech-angels.com> wrote:
>
>
> On Thu, Jan 12, 2017 at 3:54 PM, Ben Parees  wrote:
>
>> ​that qualifies as client-side logic (the plugin is executing the logic
>> on the client side, seamlessly or otherwise)
>
>
> Ok, thanks for the explanation.
>
> ___
> users mailing list
> users@lists.openshift.redhat.com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/users
>
>


-- 
Ben Parees | OpenShift
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Clayton Coleman]

Is git-lfs packaged in epel ben?

On Jan 12, 2017, at 4:10 PM, Philippe Lafoucrière <
philippe.lafoucri...@tech-angels.com> wrote:


On Thu, Jan 12, 2017 at 3:54 PM, Ben Parees  wrote:

> ​that qualifies as client-side logic (the plugin is executing the logic on
> the client side, seamlessly or otherwise)


Ok, thanks for the explanation.

___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Ben Parees]

On Thu, Jan 12, 2017 at 3:52 PM, Philippe Lafoucrière <
philippe.lafoucri...@tech-angels.com> wrote:

>
> On Thu, Jan 12, 2017 at 3:50 PM, Ben Parees  wrote:
>
>> ​it's part of the origin/sti-builder infrastructure image.  if git-lfs
>> requires client side logic, it's not going to work with openshift s2i
>> builds i'm afraid.  (at least not w/o some hackery like doing the git clone
>> of the source in your s2i builder's assemble script, instead of letting
>> openshift do it.  then your s2i builder image could have git-lfs installed)
>
>
> There's no "logic" per se. The plugin just needs to be installed, and git
> will clone the repo as usual, with no extra command to run.
>

​that qualifies as client-side logic (the plugin is executing the logic on
the client side, seamlessly or otherwise)
​




-- 
Ben Parees | OpenShift
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Philippe Lafoucrière]

On Thu, Jan 12, 2017 at 3:50 PM, Ben Parees  wrote:

> ​it's part of the origin/sti-builder infrastructure image.  if git-lfs
> requires client side logic, it's not going to work with openshift s2i
> builds i'm afraid.  (at least not w/o some hackery like doing the git clone
> of the source in your s2i builder's assemble script, instead of letting
> openshift do it.  then your s2i builder image could have git-lfs installed)


There's no "logic" per se. The plugin just needs to be installed, and git
will clone the repo as usual, with no extra command to run.
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Ben Parees]

On Thu, Jan 12, 2017 at 3:47 PM, Philippe Lafoucrière <
philippe.lafoucri...@tech-angels.com> wrote:

>
> On Thu, Jan 12, 2017 at 3:43 PM, Ben Parees  wrote:
>
>> ​no known issues but no known uses either.  s2i is basically just git
>> cloning your repo, it sounds like the lfs pointers didn't resolve properly
>> during the clone operation.  I don't know the inner workings of how that is
>> supposed to happen.  If you git clone the repo yourself, does the correct
>> binary content get cloned to your local dir?  Are any additional args
>> required during the clone process to make it work?
>>
>
> If I clone the repo, I have the .war files with their expected content,
> but I have git-lfs installed on my machine (from
> https://git-lfs.github.com/).
> I wonder where the git used by s2i is coming from, I need to read (again)
> the docs.
>

​it's part of the origin/sti-builder infrastructure image.  if git-lfs
requires client side logic, it's not going to work with openshift s2i
builds i'm afraid.  (at least not w/o some hackery like doing the git clone
of the source in your s2i builder's assemble script, instead of letting
openshift do it.  then your s2i builder image could have git-lfs installed)
​



>
> Thanks,
> Philippe
>



-- 
Ben Parees | OpenShift
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Philippe Lafoucrière]

On Thu, Jan 12, 2017 at 3:43 PM, Ben Parees  wrote:

> ​no known issues but no known uses either.  s2i is basically just git
> cloning your repo, it sounds like the lfs pointers didn't resolve properly
> during the clone operation.  I don't know the inner workings of how that is
> supposed to happen.  If you git clone the repo yourself, does the correct
> binary content get cloned to your local dir?  Are any additional args
> required during the clone process to make it work?
>

If I clone the repo, I have the .war files with their expected content, but
I have git-lfs installed on my machine (from https://git-lfs.github.com/).
I wonder where the git used by s2i is coming from, I need to read (again)
the docs.

Thanks,
Philippe
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users

Re: S2I and git-lfs

[Ben Parees]

On Thu, Jan 12, 2017 at 3:05 PM, Philippe Lafoucrière <
philippe.lafoucri...@tech-angels.com> wrote:

> Hi,
>
> I haven't dug yet, but we have enabled git-lfs on a repo, and I noticed
> the build is now failing.
> Actually, the build is passing, but the container fails to start now.
>
> We're building a tomcat container with the war (that's why we have LFS
> enabled) embedded, and it fails with:
>
> SEVERE: Exception fixing docBase for context [/admin]
> java.util.zip.ZipException: error in opening zip file
> at java.util.zip.ZipFile.open(Native Method)
> at java.util.zip.ZipFile.(ZipFile.java:215)
> at java.util.zip.ZipFile.(ZipFile.java:145)
> at java.util.jar.JarFile.(JarFile.java:154)
> at java.util.jar.JarFile.(JarFile.java:91)
> at sun.net.www.protocol.jar.URLJarFile.(URLJarFile.java:93)
> at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:69)
> at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:99)
> at sun.net.www.protocol.jar.JarURLConnection.connect(
> JarURLConnection.java:122)
> at sun.net.www.protocol.jar.JarURLConnection.getJarFile(
> JarURLConnection.java:89)
> at org.apache.catalina.startup.ExpandWar.expand(ExpandWar.java:111)
> at org.apache.catalina.startup.ContextConfig.fixDocBase(
> ContextConfig.java:737)
> at org.apache.catalina.startup.ContextConfig.beforeStart(
> ContextConfig.java:862)
> at org.apache.catalina.startup.ContextConfig.lifecycleEvent(
> ContextConfig.java:390)
> at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(
> LifecycleSupport.java:117)
> at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(
> LifecycleBase.java:90)
> at org.apache.catalina.util.LifecycleBase.setStateInternal(
> LifecycleBase.java:388)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:144)
> at org.apache.catalina.core.ContainerBase.addChildInternal(
> ContainerBase.java:899)
> at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:875)
> at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:652)
> at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1092)
> at org.apache.catalina.startup.HostConfig$DeployWar.run(
> HostConfig.java:1984)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(
> ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(
> ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
>
> root@app-13-yh1w8:/usr/local/tomcat# ls -lh webapps
>
>
> total 12K
>
>
> -rw-rw-r--. 1 root root 670 Jan 12 19:58 README.md
>
>
> -rw-rw-r--. 1 root root 133 Jan 12 19:58 ROOT.war
>
>
> -rw-rw-r--. 1 root root 133 Jan 12 19:58 admin.war
>
> The content of the files (instead of the actual file):
>
> version https://git-lfs.github.com/spec/v1
>   oid sha256:
> 880acdc04e3bc0c9ef2593042360012419d05bb910a9053da1607719cb6b1adc
>   size 10332227
>
> Is there any known issue with S2I and git-lfs? We are using OS origin on
> atomic hosts.
> I can't find anything on that.
>

​no known issues but no known uses either.  s2i is basically just git
cloning your repo, it sounds like the lfs pointers didn't resolve properly
during the clone operation.  I don't know the inner workings of how that is
supposed to happen.  If you git clone the repo yourself, does the correct
binary content get cloned to your local dir?  Are any additional args
required during the clone process to make it work?
​



>
> Thanks,
> Philippe
>
> ___
> users mailing list
> users@lists.openshift.redhat.com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/users
>
>


-- 
Ben Parees | OpenShift
___
users mailing list
users@lists.openshift.redhat.com
http://lists.openshift.redhat.com/openshiftmm/listinfo/users