Re: how do i disable the sunconvention check with checkstyle?
Hi Martin, the suggestion about the pluginmanagement does not work for me. But I managed it to work correctly due to the rest of your suggestions. So many thanks Rolf On 10/11/06, Zeltner Martin [EMAIL PROTECTED] wrote: Hello Rolf You have to place the configuration element directly inside the plugin element. Further pay attention that your plugin element is defined inside build/pluginManagement/plugins, else (if it is defined inside build/plugins) checkstyle will be executed on phase verify (directly before phase install) one more time. Due to issue http://jira.codehaus.org/browse/MNG-1931 config made in pluginManagement will not be directly reused in element reporting. You have to copy your configuration for site generation! At best you use properties (checkstyle.config.location and so only) to config the checkstyle-plugin without adding a configuration section. For an example have a look at http://svn.sourceforge.net/viewvc/el4j/trunk/el4j/pom.xml?view=markup Cheers, Martin -Original Message- From: Rolf Strijdhorst [mailto:[EMAIL PROTECTED] Sent: Dienstag, 10. Oktober 2006 16:21 To: Maven Users List Subject: how do i disable the sunconvention check with checkstyle? Hi I have a custom configuration. But both the sun conventions are checked as well as my own. I don't need the sun conventions btw the build needs to fail on violations so I added the check goal. here is the part of the config: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId executions execution idbasisregistratie styles release 1/id phaseprocess-sources/phase configuration configLocation br_styles_release1.xml /configLocation suppressionsLocation suppressions.xml /suppressionsLocation failOnViolationtrue/failOnViolation /configuration goals goalcheck/goal /goals /execution /plugin thanx Rolf - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: how do i disable the sunconvention check with checkstyle?
Hello Rolf You have to place the configuration element directly inside the plugin element. Further pay attention that your plugin element is defined inside build/pluginManagement/plugins, else (if it is defined inside build/plugins) checkstyle will be executed on phase verify (directly before phase install) one more time. Due to issue http://jira.codehaus.org/browse/MNG-1931 config made in pluginManagement will not be directly reused in element reporting. You have to copy your configuration for site generation! At best you use properties (checkstyle.config.location and so only) to config the checkstyle-plugin without adding a configuration section. For an example have a look at http://svn.sourceforge.net/viewvc/el4j/trunk/el4j/pom.xml?view=markup Cheers, Martin -Original Message- From: Rolf Strijdhorst [mailto:[EMAIL PROTECTED] Sent: Dienstag, 10. Oktober 2006 16:21 To: Maven Users List Subject: how do i disable the sunconvention check with checkstyle? Hi I have a custom configuration. But both the sun conventions are checked as well as my own. I don't need the sun conventions btw the build needs to fail on violations so I added the check goal. here is the part of the config: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId executions execution idbasisregistratie styles release 1/id phaseprocess-sources/phase configuration configLocation br_styles_release1.xml /configLocation suppressionsLocation suppressions.xml /suppressionsLocation failOnViolationtrue/failOnViolation /configuration goals goalcheck/goal /goals /execution /plugin thanx Rolf - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: how do i disable the sunconvention check with checkstyle?
thanx, Monday I will be in the office again and will do it as you mentioned. Rolf On 10/11/06, Zeltner Martin [EMAIL PROTECTED] wrote: Hello Rolf You have to place the configuration element directly inside the plugin element. Further pay attention that your plugin element is defined inside build/pluginManagement/plugins, else (if it is defined inside build/plugins) checkstyle will be executed on phase verify (directly before phase install) one more time. Due to issue http://jira.codehaus.org/browse/MNG-1931 config made in pluginManagement will not be directly reused in element reporting. You have to copy your configuration for site generation! At best you use properties (checkstyle.config.location and so only) to config the checkstyle-plugin without adding a configuration section. For an example have a look at http://svn.sourceforge.net/viewvc/el4j/trunk/el4j/pom.xml?view=markup Cheers, Martin -Original Message- From: Rolf Strijdhorst [mailto:[EMAIL PROTECTED] Sent: Dienstag, 10. Oktober 2006 16:21 To: Maven Users List Subject: how do i disable the sunconvention check with checkstyle? Hi I have a custom configuration. But both the sun conventions are checked as well as my own. I don't need the sun conventions btw the build needs to fail on violations so I added the check goal. here is the part of the config: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId executions execution idbasisregistratie styles release 1/id phaseprocess-sources/phase configuration configLocation br_styles_release1.xml /configLocation suppressionsLocation suppressions.xml /suppressionsLocation failOnViolationtrue/failOnViolation /configuration goals goalcheck/goal /goals /execution /plugin thanx Rolf - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
how do i disable the sunconvention check with checkstyle?
Hi I have a custom configuration. But both the sun conventions are checked as well as my own. I don't need the sun conventions btw the build needs to fail on violations so I added the check goal. here is the part of the config: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId executions execution idbasisregistratie styles release 1/id phaseprocess-sources/phase configuration configLocation br_styles_release1.xml /configLocation suppressionsLocation suppressions.xml /suppressionsLocation failOnViolationtrue/failOnViolation /configuration goals goalcheck/goal /goals /execution /plugin thanx Rolf
Re: how do i disable the sunconvention check with checkstyle?
Rolf Strijdhorst wrote: Hi I have a custom configuration. But both the sun conventions are checked as well as my own. I don't need the sun conventions btw the build needs to fail on violations so I added the check goal. here is the part of the config: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId executions execution idbasisregistratie styles release 1/id phaseprocess-sources/phase configuration configLocation br_styles_release1.xml /configLocation suppressionsLocation suppressions.xml /suppressionsLocation failOnViolationtrue/failOnViolation /configuration goals goalcheck/goal /goals /execution /plugin thanx Rolf Did you try the standard configuration [1] for this first? project ... reporting plugins plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId configuration configLocationbr_styles_release1.xml/configLocation suppressionsLocationsuppressions.xml/suppressionsLocation /configuration /plugin /plugins /reporting ... /project [1]http://maven.apache.org/plugins/maven-checkstyle-plugin/customize.html -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
