Re: Table Captions
On 9/6/06, Mario Ivankovits <[EMAIL PROTECTED]> wrote: Hi Mike! > Dennis stated earlier that this has already been implemented for > MyFaces 1.2. Not sure why the issue wasn't closed. From the bug description: "but it is needed to be supported by myfaces as soon as possible for accessibility reasons" So the main intention from the reporter was to have this in Tomahawks datatable. From the change history I've seen this issue has been moved to JSR-252 later, which IMHO was wrong, I moved the issue now. Mario. I think this was a mistake. The proper thing to do would have been to have duplicated the issue for Tomahawk. It *MUST* be fixed for JSR-252 MyFaces Core. It's optional whether we also support it for Tomahawk dataTable, but these are two separate issues.
Re: Table Captions
Hi Mike! > Dennis stated earlier that this has already been implemented for > MyFaces 1.2. Not sure why the issue wasn't closed. >From the bug description: "but it is needed to be supported by myfaces as soon as possible for accessibility reasons" So the main intention from the reporter was to have this in Tomahawks datatable. >From the change history I've seen this issue has been moved to JSR-252 later, which IMHO was wrong, I moved the issue now. Ciao, Mario
Re: Table Captions
Hey Mario, Dennis stated earlier that this has already been implemented for MyFaces 1.2. Not sure why the issue wasn't closed. What we're talking about here is adding the same behavior to Tomahawk's t:dataTable. On 9/4/06, Mario Ivankovits <[EMAIL PROTECTED]> wrote: hi! > On 9/3/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: >> Backporting may be more than just a quick commit. I seem to remember >> the code for printing the element to be in the shared >> module. This means if you add it to t:dataTable, it ends up in >> h:dataTable also. If h:dataTable is to remain compliant with the JSF >> reference imlementation, something trickier would have to be done. > > Almost all of our t:dataTable code works this way as well. > Typically, configurable support is added to the shared code with the > default behavior being off. Just in case, someone is going to fix this, here is a JIRA for this enhancement: https://issues.apache.org/jira/browse/MYFACES-1352 Ciao, Mario
Re: Table Captions
hi! > On 9/3/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: >> Backporting may be more than just a quick commit. I seem to remember >> the code for printing the element to be in the shared >> module. This means if you add it to t:dataTable, it ends up in >> h:dataTable also. If h:dataTable is to remain compliant with the JSF >> reference imlementation, something trickier would have to be done. > > Almost all of our t:dataTable code works this way as well. > Typically, configurable support is added to the shared code with the > default behavior being off. Just in case, someone is going to fix this, here is a JIRA for this enhancement: https://issues.apache.org/jira/browse/MYFACES-1352 Ciao, Mario
Re: Table Captions
On 9/3/06, Dennis Byrne <[EMAIL PROTECTED]> wrote:
Backporting may be more than just a quick commit. I seem to remember the code for
printing the element to be in the shared module. This means if you add
it to t:dataTable, it ends up in h:dataTable also. If h:dataTable is to remain
compliant with the JSF reference imlementation, something trickier would have to be
done.
Almost all of our t:dataTable code works this way as well.
Typically, configurable support is added to the shared code with the
default behavior being off.
Like
...
doTheTableCaptionThing();
...
protected void doTheTableCaptionThing() {}
as the default value
Or
protected boolean shouldDisplayTableCaption() { return false; }
Then the t:dataTable subclass provides a functional method that turns
on the table caption.
protected boolean shouldDisplayTableCaption() { return true; }
For 1.2, the default behavior woudl also be to return true.
Re: Table Captions
>> You could also backport this feature to the t:dataTable. >> Should be pretty simple if it's already part of the 1.2 branch. >> >> Mike > >Mike, I will look into back porting this feature. > >Brad > Backporting may be more than just a quick commit. I seem to remember the code for printing the element to be in the shared module. This means if you add it to t:dataTable, it ends up in h:dataTable also. If h:dataTable is to remain compliant with the JSF reference imlementation, something trickier would have to be done. Dennis Byrne
Re: Table Captions
On Sat, 2006-09-02 at 21:13 -0400, Mike Kienenberger wrote: > On 9/2/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: > > I just checked the code and it appears to only be in the 1.2 branch. It's > > more work, but you can always override the Renderer in JSF. > > Brad, > > You could also backport this feature to the t:dataTable. > Should be pretty simple if it's already part of the 1.2 branch. Thank you Dennis. Mike, I will look into back porting this feature. Brad signature.asc Description: This is a digitally signed message part
Re: Table Captions
On 9/2/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: I just checked the code and it appears to only be in the 1.2 branch. It's more work, but you can always override the Renderer in JSF. Brad, You could also backport this feature to the t:dataTable. Should be pretty simple if it's already part of the 1.2 branch.
Re: Table Captions
I just checked the code and it appears to only be in the 1.2 branch. It's more work, but you can always override the Renderer in JSF. In your faces-config, javax.faces.Data org.apache.myfaces.Table com.foo.HtmlTableRenderer ... where com.foo.HtmlTableRenderer extends org.apache.myfaces.renderkit.html.ext.HtmlTableRenderer In com.foo.HtmlTableRenderer, override the part that prints and make it print blag . This of course means you may have to do some refactoring when you want to upgrade to a newer version of MyFaces ( where org.apache.myfaces.renderkit.html.ext.HtmlTableRenderer might change ) or move to a different JSF implmentation altogether ( a completely different Renderer to extend). Dennis Byrne >-Original Message- >From: Brad Smith [mailto:[EMAIL PROTECTED] >Sent: Saturday, September 2, 2006 07:19 PM >To: 'MyFaces Discussion' >Subject: Re: Table Captions > >Thanks for the information Dennis. When I use the code Dennis suggested >below, no caption appears. When I use: > >Does this work? > >I get the same result, ie no caption. In both instances, any errors (if >any) are silently disposed of. > >Brad > > >On Sat, 2006-09-02 at 22:23 +, Dennis Byrne wrote: > >> What happens if you do this? >> >> >> >> >> >> This is a requirement for JSF 1.2 . > >
Re: Table Captions
Thanks for the information Dennis. When I use the code Dennis suggested below, no caption appears. When I use: Does this work? I get the same result, ie no caption. In both instances, any errors (if any) are silently disposed of. Brad On Sat, 2006-09-02 at 22:23 +, Dennis Byrne wrote: > What happens if you do this? > > > > > > This is a requirement for JSF 1.2 . signature.asc Description: This is a digitally signed message part
Re: Table Captions
Someone contributed a patch a few months ago. I know I committed it to the 1.2 branch (no release) but I can't remember if it was committed to the 1.1 branch. If it was committed, I also can't tell you if it happened before or after the last release (1.1.3). What happens if you do this? This is a requirement for JSF 1.2 . Dennis Byrne >-Original Message- >From: Brad Smith [mailto:[EMAIL PROTECTED] >Sent: Saturday, September 2, 2006 05:28 PM >To: 'MyFaces Discussion' >Subject: Table Captions > >I have been looking for a way to add captions with the caption element >using either or but do not see this in any >examples or manuals. Am I overlooking the obvious? > >Thanks > >Brad > >
Table Captions
I have been looking for a way to add captions with the caption element using either or but do not see this in any examples or manuals. Am I overlooking the obvious? Thanks Brad signature.asc Description: This is a digitally signed message part
