Re: Unable to quit after cancelling Savables
On Fri, 9 Feb 2018 at 10:07 Marco Rossi wrote: > Dear all, > Emilian has fixed this issue. These involve some changes in the applemenu > module (see https://github.com/apache/incubator-netbeans/pull/411/files). > At this point how could I integrate this fix in my application built on top > of NB 8.2 platform? Is there a way to override that classes with my custom > ones? > Any suggestions? > IIRC (been a while since I did this) you can copy (possibly with changes) and build the module along with your own in your application, and it will override the module in platform because it's seen first. At least, I used to do something similar years ago with JNA to ship a newer version while maintaining dependencies. I also added to the build script to remove the platform module post-build just-in-case. Don't exclude the module in the platform list - that filters out your version too. Interested to try this fix in Praxis LIVE - I have a problem where that quit never works, but have delegating lifecycle managers that always shows a dialog on quit. Best wishes, Neil -- Neil C Smith Artist & Technologist www.neilcsmith.net Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: Unable to quit after cancelling Savables
Dear all, Emilian has fixed this issue. These involve some changes in the applemenu module (see https://github.com/apache/incubator-netbeans/pull/411/files). At this point how could I integrate this fix in my application built on top of NB 8.2 platform? Is there a way to override that classes with my custom ones? Any suggestions? > Il giorno 06 feb 2018, alle ore 23:05, Emilian Bold > ha scritto: > > I does look like a bug in > org.netbeans.modules.applemenu.NbApplicationAdapterJDK8.handleQuitRequestWith(AppEvent.QuitEvent > e, QuitResponse response) > > Seems to me that when the user cancels QuitResponse.cancelQuit should be > called. > > Actually, the Javadoc is quite clear > https://docs.oracle.com/javase/9/docs/api/java/awt/desktop/QuitHandler.html : > >> Implementors must call either QuitResponse.cancelQuit(), >> QuitResponse.performQuit(), or ensure the application terminates. > > Please report the bug for NETBEANS on the Apache Jira: issues.apache.org/jira/ > > Great find! Seems to me the whole exit action design is unable to send an > answer back in case of cancel. > > I also see this has been reported multiple times in the old Bugzilla: > > https://netbeans.org/bugzilla/show_bug.cgi?id=268549 > https://netbeans.org/bugzilla/show_bug.cgi?id=271946 > https://netbeans.org/bugzilla/show_bug.cgi?id=269724 > (probably) https://netbeans.org/bugzilla/show_bug.cgi?id=247690 > > --emi > > Original Message > On 6 February 2018 11:22 PM, Marco Rossi wrote: > >> Hi Emilian, >> I’ve created this small project (attached here as a zip, hope it’s ok) and >> got the same issue. Please note that this seems to be related to OS X only >> (in Windows it works). >> My environment is Netbeans IDE 8.2 on OS X 10.11.6 with Java 1.8. >> >> >> >> >> >>> Il giorno 06 feb 2018, alle ore 19:05, Emilian Bold >>> emilian.b...@protonmail.ch ha scritto: >>> Might be something more subtle, I know I could be able to press Cancel with >>> Salvables. >>> Can you create a simple project that reproduces this problem? >>> --emi >>> >> >> >> >> >> To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org >> For additional commands, e-mail: users-h...@netbeans.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> > > - > To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org > For additional commands, e-mail: users-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Unable to quit after cancelling Savables
I does look like a bug in org.netbeans.modules.applemenu.NbApplicationAdapterJDK8.handleQuitRequestWith(AppEvent.QuitEvent e, QuitResponse response) Seems to me that when the user cancels QuitResponse.cancelQuit should be called. Actually, the Javadoc is quite clear https://docs.oracle.com/javase/9/docs/api/java/awt/desktop/QuitHandler.html : > Implementors must call either QuitResponse.cancelQuit(), > QuitResponse.performQuit(), or ensure the application terminates. Please report the bug for NETBEANS on the Apache Jira: issues.apache.org/jira/ Great find! Seems to me the whole exit action design is unable to send an answer back in case of cancel. I also see this has been reported multiple times in the old Bugzilla: https://netbeans.org/bugzilla/show_bug.cgi?id=268549 https://netbeans.org/bugzilla/show_bug.cgi?id=271946 https://netbeans.org/bugzilla/show_bug.cgi?id=269724 (probably) https://netbeans.org/bugzilla/show_bug.cgi?id=247690 --emi Original Message On 6 February 2018 11:22 PM, Marco Rossi wrote: >Hi Emilian, > I’ve created this small project (attached here as a zip, hope it’s ok) and > got the same issue. Please note that this seems to be related to OS X only > (in Windows it works). > My environment is Netbeans IDE 8.2 on OS X 10.11.6 with Java 1.8. > > > > > >>Il giorno 06 feb 2018, alle ore 19:05, Emilian Bold >>emilian.b...@protonmail.ch ha scritto: >>Might be something more subtle, I know I could be able to press Cancel with >>Salvables. >>Can you create a simple project that reproduces this problem? >>--emi >> > > > > >To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org > For additional commands, e-mail: users-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: >https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > - To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org For additional commands, e-mail: users-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Unable to quit after cancelling Savables
Might be something more subtle, I know I could be able to press Cancel with Salvables. Can you create a simple project that reproduces this problem? --emi Original Message On 5 February 2018 12:57 PM, Marco Rossi wrote: > Hi to all, > I’ve noticed a possible bug: when I quit my custom Netbeans Platform > application (from menu bar > Quit... in OS X environment), if there are some > AbstractSavable instances in the SavableRegistry, it appears the default Save > dialog (see picture) asking user if he would like to save changes before > quit. I click on Cancel and then try to click again in Quit action, nothing > happen and I’m unable to close.
Unable to quit after cancelling Savables
Hi to all, I’ve noticed a possible bug: when I quit my custom Netbeans Platform application (from menu bar > Quit... in OS X environment), if there are some AbstractSavable instances in the SavableRegistry, it appears the default Save dialog (see picture) asking user if he would like to save changes before quit. I click on Cancel and then try to click again in Quit action, nothing happen and I’m unable to close.
