[RESULT][VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0 Inbox x
There were 3 binding +1 votes and no other votes received. The vote has passed. The voting thread can be found here: https://lists.apache.org/thread.html/r2c3c747df4a93da1fec89895528b73028448a347f9430f8650061173%40%3Cusers.qpid.apache.org%3E I will add the release bundles to the dist release repo and promote the maven artefacts from staging repo into maven central. The website will be updated once the artefacts have had time to sync to the mirrors and maven central. Kind Regards, Alex - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
Ok, +1 then. On Fri, 29 May 2020 at 23:53, Oleksandr Rudyy wrote: > > Hi Robbie, > > It is a test issue. I committed a fix for the test in commit > d37a4935de01999bdf96ba2b46b3874b78901fd1 [1]. > > The test failure is caused by "too optimistic" retry value of 1. It seems > it took longer for the virtual host to restart and a single retry attempt > was used before the virtual host transited back into an ACTIVE state > causing the test to fail. > After changing falilove settings to more "realistic", the test is passing > for both 0-10 and 0-9 AMQP protocols. > > Thus, it is not a show stopper. Please, ignore this test failure. > > Kind Regards, > Alex > > > [1] > https://github.com/apache/qpid-jms-amqp-0-x/commit/d37a4935de01999bdf96ba2b46b3874b78901fd1 > > On Fri, 29 May 2020 at 13:17, Robbie Gemmell > wrote: > > > I ran some tests. > > > > The good: > > - Verified the signature and checksum files. > > - Used "mvn apache-rat:check" to check the headers in the source archive. > > - Verified LICENCE and NOTICE present in the archives. > > - Ran the Broker-J master build + mms.0-10 systests using staged > > client on JDK8 and JDK11, all fine. > > > > The bad: > > - Ran the build and 0-10 systests on JDK8 and JDK11. Saw a test > > failure in both cases: > > [ERROR] > > testAccountRotationViaConnectAttemptListenerOnFailover(org.apache.qpid.systest.connection.ConnectionFactoryTest) > > Time elapsed: 10.238 s <<< FAILURE! > > > > > > ConnectionFactoryTest.testAccountRotationViaConnectAttemptListenerOnFailover:294->restartBrokerAndWaitForFailover:357 > > > > The same test is failing in CI on 0-10 and 0-9-1 profiles: > > > > https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-JMS-AMQP-0-x-Broker-J-TestMatrix/45/#showFailuresLink > > > > I havent looked into it, but I think it would be good to ascertain the > > cause of the failures before deciding whether its a blocking issue or > > not. I believe its a new test so it is a regression of sorts. > > > > Robbie > > > > On Thu, 28 May 2020 at 21:30, Oleksandr Rudyy wrote: > > > > > > Hi, > > > I created a release candidate build for new minor version 6.4.0 of Qpid > > JMS > > > for AMQP 0-x. > > > The release introduces a number of improvements including an improvement > > > allowing to rotate credentials using extension mechanism similar to the > > one > > > available in JMS Client for AMQP 1.0. > > > > > > Please give it a test out and vote accordingly. > > > > > > The source and binary bundles can be taken from: > > > https://dist.apache.org/repos/dist/dev/qpid/jms-amqp-0-x/6.4.0-RC1 > > > > > > The maven artifacts are also staged at: > > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > > > The JIRAs currently assigned are: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12345500 > > > > > > Regards, > > > Alex > > > > > > P.S. If you want to test it out using maven, you can temporarily add this > > > to your project pom to access the staging repo: > > > > > > > > > > > > staging > > > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > > > > > > > > > > > The dependency for the client itself would then be: > > > > > > > > > org.apache.qpid > > > qpid-client > > > 6.4.0 > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
Thanks Alex! On that basis I am happy to vote +1 for the release. On 30/05/2020 12:27 am, Oleksandr Rudyy wrote: Hi Gordon, Thanks for reporting the issues with tests from test suite FailoverMethodTest. The tests are supposed to test singleserver and roundrobin failover methods. The way they test it is a bit weird. The connection URL contains 2 broker entries but only one broker is running. The second broker is not running and random free port is used as a second broker entry. When the first broker is stopped the failover functionality is supposed to try use 3 attempts to try establishing connectivity with a second broker with a delay of 2 seconds between each retry. The test tries to verify that it takes expected time for the failover before it gives up and throw an exception. It looks like that in you environment opening a socket to a second failover port (with no broker listening) might took longer than expected and tests took more than 60 seconds to run instead of expected time of 6 - 11 seconds. I am not sure what is causing the issue. Though, it looks to me that it is a test issue. Possibly, running a broker on a second port might help to fix the problem. I will try to look into it tomorrow. Kind Regards, Alex On Fri, 29 May 2020 at 22:43, Gordon Sim wrote: On 29/05/2020 9:14 pm, Robbie Gemmell wrote: You need to set a profile to enable them, e.g -Pbroker-j Thanks Robbie! Running the cpp profile, I see errors in failover tests and then the tests seem to just hang after that (nothing obvious to me from either jstack or pstack on the broker which appears idle). [INFO] Running org.apache.qpid.systest.connection.FailoverMethodTest [ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 134.204 s <<< FAILURE! - in org.apache.qpid.systest.connection.FailoverMethodTest [ERROR] testFailoverSingleDelay(org.apache.qpid.systest.connection.FailoverMethodTest) Time elapsed: 66.088 s <<< FAILURE! java.lang.AssertionError: Failover took more than 9 seconds:(66056) at org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverSingleDelay(FailoverMethodTest.java:165) [ERROR] testFailoverRoundRobinDelay(org.apache.qpid.systest.connection.FailoverMethodTest) Time elapsed: 68.083 s <<< FAILURE! java.lang.AssertionError: Failover took more than 11 seconds:(68082) at org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverRoundRobinDelay(FailoverMethodTest.java:115) [INFO] Running org.apache.qpid.systest.connection.FailoverBehaviourTest with the broker-j profile I don't see any failures but I do see 23 skipped tests (out of 163) - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
Hi Gordon, Thanks for reporting the issues with tests from test suite FailoverMethodTest. The tests are supposed to test singleserver and roundrobin failover methods. The way they test it is a bit weird. The connection URL contains 2 broker entries but only one broker is running. The second broker is not running and random free port is used as a second broker entry. When the first broker is stopped the failover functionality is supposed to try use 3 attempts to try establishing connectivity with a second broker with a delay of 2 seconds between each retry. The test tries to verify that it takes expected time for the failover before it gives up and throw an exception. It looks like that in you environment opening a socket to a second failover port (with no broker listening) might took longer than expected and tests took more than 60 seconds to run instead of expected time of 6 - 11 seconds. I am not sure what is causing the issue. Though, it looks to me that it is a test issue. Possibly, running a broker on a second port might help to fix the problem. I will try to look into it tomorrow. Kind Regards, Alex On Fri, 29 May 2020 at 22:43, Gordon Sim wrote: > On 29/05/2020 9:14 pm, Robbie Gemmell wrote: > > You need to set a profile to enable them, e.g -Pbroker-j > > Thanks Robbie! > > Running the cpp profile, I see errors in failover tests and then the > tests seem to just hang after that (nothing obvious to me from either > jstack or pstack on the broker which appears idle). > > > [INFO] Running org.apache.qpid.systest.connection.FailoverMethodTest > > [ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: > 134.204 s <<< FAILURE! - in > org.apache.qpid.systest.connection.FailoverMethodTest > > [ERROR] > testFailoverSingleDelay(org.apache.qpid.systest.connection.FailoverMethodTest) > Time elapsed: 66.088 s <<< FAILURE! > > java.lang.AssertionError: Failover took more than 9 seconds:(66056) > > at > org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverSingleDelay(FailoverMethodTest.java:165) > > > > [ERROR] > testFailoverRoundRobinDelay(org.apache.qpid.systest.connection.FailoverMethodTest) > Time elapsed: 68.083 s <<< FAILURE! > > java.lang.AssertionError: Failover took more than 11 seconds:(68082) > > at > org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverRoundRobinDelay(FailoverMethodTest.java:115) > > > > [INFO] Running org.apache.qpid.systest.connection.FailoverBehaviourTest > > with the broker-j profile I don't see any failures but I do see 23 > skipped tests (out of 163) > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > >
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
Hi Robbie, It is a test issue. I committed a fix for the test in commit d37a4935de01999bdf96ba2b46b3874b78901fd1 [1]. The test failure is caused by "too optimistic" retry value of 1. It seems it took longer for the virtual host to restart and a single retry attempt was used before the virtual host transited back into an ACTIVE state causing the test to fail. After changing falilove settings to more "realistic", the test is passing for both 0-10 and 0-9 AMQP protocols. Thus, it is not a show stopper. Please, ignore this test failure. Kind Regards, Alex [1] https://github.com/apache/qpid-jms-amqp-0-x/commit/d37a4935de01999bdf96ba2b46b3874b78901fd1 On Fri, 29 May 2020 at 13:17, Robbie Gemmell wrote: > I ran some tests. > > The good: > - Verified the signature and checksum files. > - Used "mvn apache-rat:check" to check the headers in the source archive. > - Verified LICENCE and NOTICE present in the archives. > - Ran the Broker-J master build + mms.0-10 systests using staged > client on JDK8 and JDK11, all fine. > > The bad: > - Ran the build and 0-10 systests on JDK8 and JDK11. Saw a test > failure in both cases: > [ERROR] > testAccountRotationViaConnectAttemptListenerOnFailover(org.apache.qpid.systest.connection.ConnectionFactoryTest) > Time elapsed: 10.238 s <<< FAILURE! > > > ConnectionFactoryTest.testAccountRotationViaConnectAttemptListenerOnFailover:294->restartBrokerAndWaitForFailover:357 > > The same test is failing in CI on 0-10 and 0-9-1 profiles: > > https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-JMS-AMQP-0-x-Broker-J-TestMatrix/45/#showFailuresLink > > I havent looked into it, but I think it would be good to ascertain the > cause of the failures before deciding whether its a blocking issue or > not. I believe its a new test so it is a regression of sorts. > > Robbie > > On Thu, 28 May 2020 at 21:30, Oleksandr Rudyy wrote: > > > > Hi, > > I created a release candidate build for new minor version 6.4.0 of Qpid > JMS > > for AMQP 0-x. > > The release introduces a number of improvements including an improvement > > allowing to rotate credentials using extension mechanism similar to the > one > > available in JMS Client for AMQP 1.0. > > > > Please give it a test out and vote accordingly. > > > > The source and binary bundles can be taken from: > > https://dist.apache.org/repos/dist/dev/qpid/jms-amqp-0-x/6.4.0-RC1 > > > > The maven artifacts are also staged at: > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > The JIRAs currently assigned are: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12345500 > > > > Regards, > > Alex > > > > P.S. If you want to test it out using maven, you can temporarily add this > > to your project pom to access the staging repo: > > > > > > > > staging > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > > > > > > The dependency for the client itself would then be: > > > > > > org.apache.qpid > > qpid-client > > 6.4.0 > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > >
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
On 29/05/2020 9:14 pm, Robbie Gemmell wrote: You need to set a profile to enable them, e.g -Pbroker-j Thanks Robbie! Running the cpp profile, I see errors in failover tests and then the tests seem to just hang after that (nothing obvious to me from either jstack or pstack on the broker which appears idle). [INFO] Running org.apache.qpid.systest.connection.FailoverMethodTest [ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 134.204 s <<< FAILURE! - in org.apache.qpid.systest.connection.FailoverMethodTest [ERROR] testFailoverSingleDelay(org.apache.qpid.systest.connection.FailoverMethodTest) Time elapsed: 66.088 s <<< FAILURE! java.lang.AssertionError: Failover took more than 9 seconds:(66056) at org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverSingleDelay(FailoverMethodTest.java:165) [ERROR] testFailoverRoundRobinDelay(org.apache.qpid.systest.connection.FailoverMethodTest) Time elapsed: 68.083 s <<< FAILURE! java.lang.AssertionError: Failover took more than 11 seconds:(68082) at org.apache.qpid.systest.connection.FailoverMethodTest.testFailoverRoundRobinDelay(FailoverMethodTest.java:115) [INFO] Running org.apache.qpid.systest.connection.FailoverBehaviourTest with the broker-j profile I don't see any failures but I do see 23 skipped tests (out of 163) - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
On Fri, 29 May 2020 at 20:50, Gordon Sim wrote: > > On 29/05/2020 1:17 pm, Robbie Gemmell wrote: > > I ran some tests. > > > > The good: > > - Verified the signature and checksum files. > > - Used "mvn apache-rat:check" to check the headers in the source archive. > > - Verified LICENCE and NOTICE present in the archives. > > - Ran the Broker-J master build + mms.0-10 systests using staged > > client on JDK8 and JDK11, all fine. > > > > The bad: > > - Ran the build and 0-10 systests on JDK8 and JDK11. Saw a test > > failure in both cases: > > [ERROR] > > testAccountRotationViaConnectAttemptListenerOnFailover(org.apache.qpid.systest.connection.ConnectionFactoryTest) > > Time elapsed: 10.238 s <<< FAILURE! > > > > ConnectionFactoryTest.testAccountRotationViaConnectAttemptListenerOnFailover:294->restartBrokerAndWaitForFailover:357 > > > > The same test is failing in CI on 0-10 and 0-9-1 profiles: > > https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-JMS-AMQP-0-x-Broker-J-TestMatrix/45/#showFailuresLink > > > > I havent looked into it, but I think it would be good to ascertain the > > cause of the failures before deciding whether its a blocking issue or > > not. I believe its a new test so it is a regression of sorts. > > > > I verified signatures, built and ran the example against the c++ broker > which worked fine. > > All the tests were skipped for me, so presumably I need to do something > to enable the environment it is expecting? > You need to set a profile to enable them, e.g -Pbroker-j You can see example commands in the systests pom.xml file: https://github.com/apache/qpid-jms-amqp-0-x/blob/6.4.0/systests/pom.xml#L151 - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
On 29/05/2020 1:17 pm, Robbie Gemmell wrote: I ran some tests. The good: - Verified the signature and checksum files. - Used "mvn apache-rat:check" to check the headers in the source archive. - Verified LICENCE and NOTICE present in the archives. - Ran the Broker-J master build + mms.0-10 systests using staged client on JDK8 and JDK11, all fine. The bad: - Ran the build and 0-10 systests on JDK8 and JDK11. Saw a test failure in both cases: [ERROR] testAccountRotationViaConnectAttemptListenerOnFailover(org.apache.qpid.systest.connection.ConnectionFactoryTest) Time elapsed: 10.238 s <<< FAILURE! ConnectionFactoryTest.testAccountRotationViaConnectAttemptListenerOnFailover:294->restartBrokerAndWaitForFailover:357 The same test is failing in CI on 0-10 and 0-9-1 profiles: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-JMS-AMQP-0-x-Broker-J-TestMatrix/45/#showFailuresLink I havent looked into it, but I think it would be good to ascertain the cause of the failures before deciding whether its a blocking issue or not. I believe its a new test so it is a regression of sorts. I verified signatures, built and ran the example against the c++ broker which worked fine. All the tests were skipped for me, so presumably I need to do something to enable the environment it is expecting? - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
I ran some tests. The good: - Verified the signature and checksum files. - Used "mvn apache-rat:check" to check the headers in the source archive. - Verified LICENCE and NOTICE present in the archives. - Ran the Broker-J master build + mms.0-10 systests using staged client on JDK8 and JDK11, all fine. The bad: - Ran the build and 0-10 systests on JDK8 and JDK11. Saw a test failure in both cases: [ERROR] testAccountRotationViaConnectAttemptListenerOnFailover(org.apache.qpid.systest.connection.ConnectionFactoryTest) Time elapsed: 10.238 s <<< FAILURE! ConnectionFactoryTest.testAccountRotationViaConnectAttemptListenerOnFailover:294->restartBrokerAndWaitForFailover:357 The same test is failing in CI on 0-10 and 0-9-1 profiles: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-JMS-AMQP-0-x-Broker-J-TestMatrix/45/#showFailuresLink I havent looked into it, but I think it would be good to ascertain the cause of the failures before deciding whether its a blocking issue or not. I believe its a new test so it is a regression of sorts. Robbie On Thu, 28 May 2020 at 21:30, Oleksandr Rudyy wrote: > > Hi, > I created a release candidate build for new minor version 6.4.0 of Qpid JMS > for AMQP 0-x. > The release introduces a number of improvements including an improvement > allowing to rotate credentials using extension mechanism similar to the one > available in JMS Client for AMQP 1.0. > > Please give it a test out and vote accordingly. > > The source and binary bundles can be taken from: > https://dist.apache.org/repos/dist/dev/qpid/jms-amqp-0-x/6.4.0-RC1 > > The maven artifacts are also staged at: > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > The JIRAs currently assigned are: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12345500 > > Regards, > Alex > > P.S. If you want to test it out using maven, you can temporarily add this > to your project pom to access the staging repo: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > The dependency for the client itself would then be: > > > org.apache.qpid > qpid-client > 6.4.0 > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
+1 * built and ran tests successfully from source bundle * verified signatures and checksums * ran rat check successfully * ran successfully Qpid Broker integration tests on master branch using staged client artefacts and maven profiles java-bdb.0-10 and java-bdb.0-9 On Thu, 28 May 2020 at 21:29, Oleksandr Rudyy wrote: > Hi, > I created a release candidate build for new minor version 6.4.0 of Qpid > JMS for AMQP 0-x. > The release introduces a number of improvements including an improvement > allowing to rotate credentials using extension mechanism similar to the one > available in JMS Client for AMQP 1.0. > > Please give it a test out and vote accordingly. > > The source and binary bundles can be taken from: > https://dist.apache.org/repos/dist/dev/qpid/jms-amqp-0-x/6.4.0-RC1 > > The maven artifacts are also staged at: > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > The JIRAs currently assigned are: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12345500 > > Regards, > Alex > > P.S. If you want to test it out using maven, you can temporarily add this > to your project pom to access the staging repo: > > > > staging > > https://repository.apache.org/content/repositories/orgapacheqpid-1197 > > > > > The dependency for the client itself would then be: > > > org.apache.qpid > qpid-client > 6.4.0 > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org >
[VOTE] Release Apache Qpid JMS AMQP 0-x 6.4.0
Hi, I created a release candidate build for new minor version 6.4.0 of Qpid JMS for AMQP 0-x. The release introduces a number of improvements including an improvement allowing to rotate credentials using extension mechanism similar to the one available in JMS Client for AMQP 1.0. Please give it a test out and vote accordingly. The source and binary bundles can be taken from: https://dist.apache.org/repos/dist/dev/qpid/jms-amqp-0-x/6.4.0-RC1 The maven artifacts are also staged at: https://repository.apache.org/content/repositories/orgapacheqpid-1197 The JIRAs currently assigned are: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520=12345500 Regards, Alex P.S. If you want to test it out using maven, you can temporarily add this to your project pom to access the staging repo: staging https://repository.apache.org/content/repositories/orgapacheqpid-1197 The dependency for the client itself would then be: org.apache.qpid qpid-client 6.4.0 - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org