Re: [dispatch-router] 1.16.1 release?
On Mon, Jun 21, 2021 at 9:53 AM Ken Giusti wrote: > Folks, > If there are no objections I'd like to spin up an RC1 for the 1.16.1 patch > release today. > +1, Sounds good. Thanks. > thank, > -K > > > On Thu, Jun 17, 2021 at 9:48 AM Ken Giusti wrote: > > > > > > > On Thu, Jun 17, 2021 at 4:33 AM Robbie Gemmell > > > wrote: > > > >> I'm glad to see a followup release being done, but I find it > >> surprising that more of the resolved 'bug' JIRA fixes aren't being > >> included: > >> > >> > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20DISPATCH%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%201.17.0 > >> > >> Particularly the ones that are marked as blockers, but I'd wonder > >> about various others too, especially given one of the few JIRAs being > >> included isnt a bug fix. > >> > > > > That's understandable, but we have to consider minimizing risk to the > > stability of the 1.16.x branch as well. > > > > While we do have a number of blockers fixed, we're also seeing a number > of > > CI failures on main. We're moving towards fixing these, but without > > knowing the root causes for these failures I'm a bit reluctant to > introduce > > more stuff onto the stable branch than absolutely necessary. > > > > The fixes that have been proposed address issues found by users of the > TCP > > functionality introduced in 1.16.0 that basically make that functionality > > unusable for their purposes. From that perspective it can be argued that > > DISPATCH-2142 is more bugfix than improvement. > > > > > > > > > >> > >> On Wed, 16 Jun 2021 at 20:18, Ganesh Murthy wrote: > >> > > >> > On Wed, Jun 16, 2021 at 1:08 PM Ken Giusti > wrote: > >> > > >> > > Ok, I'll pull in DISPATCH-2170 to the PR as well. > >> > > > >> > Thank you. I checked the PR you created - > >> > https://github.com/apache/qpid-dispatch/pull/1262 - and it looks > good. > >> > Any thoughts on when you might start the vote ? > >> > Thanks. > >> > > >> > > > >> > > On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy > >> wrote: > >> > > > >> > > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim > wrote: > >> > > > > >> > > > > There have been a couple of fixes since the 1.16.0 release that > >> are > >> > > > > useful for users of the tcp support. Making those available as a > >> > > > > 1.16.1 seems like a good idea to me. The fixes I would suggest > >> are: > >> > > > > > >> > > > > DISPATCH-2142 > >> > > > > DISPATCH-2097 > >> > > > > DISPATCH-1878 (last commit) > >> > > > > > >> > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > >> > > > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 > >> > > (DISPATCH-2170), > >> > > > so please include cc3a53d2 as well. > >> > > > > >> > > > Thanks. > >> > > > > >> > > > > > >> > > > > > >> > > > > > >> - > >> > > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > >> > > > > For additional commands, e-mail: users-h...@qpid.apache.org > >> > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > -- > >> > > -K > >> > > > >> > >> - > >> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > >> For additional commands, e-mail: users-h...@qpid.apache.org > >> > >> > > > > -- > > -K > > > > > -- > -K >
Re: [dispatch-router] 1.16.1 release?
Folks, If there are no objections I'd like to spin up an RC1 for the 1.16.1 patch release today. thank, -K On Thu, Jun 17, 2021 at 9:48 AM Ken Giusti wrote: > > > On Thu, Jun 17, 2021 at 4:33 AM Robbie Gemmell > wrote: > >> I'm glad to see a followup release being done, but I find it >> surprising that more of the resolved 'bug' JIRA fixes aren't being >> included: >> >> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DISPATCH%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%201.17.0 >> >> Particularly the ones that are marked as blockers, but I'd wonder >> about various others too, especially given one of the few JIRAs being >> included isnt a bug fix. >> > > That's understandable, but we have to consider minimizing risk to the > stability of the 1.16.x branch as well. > > While we do have a number of blockers fixed, we're also seeing a number of > CI failures on main. We're moving towards fixing these, but without > knowing the root causes for these failures I'm a bit reluctant to introduce > more stuff onto the stable branch than absolutely necessary. > > The fixes that have been proposed address issues found by users of the TCP > functionality introduced in 1.16.0 that basically make that functionality > unusable for their purposes. From that perspective it can be argued that > DISPATCH-2142 is more bugfix than improvement. > > > > >> >> On Wed, 16 Jun 2021 at 20:18, Ganesh Murthy wrote: >> > >> > On Wed, Jun 16, 2021 at 1:08 PM Ken Giusti wrote: >> > >> > > Ok, I'll pull in DISPATCH-2170 to the PR as well. >> > > >> > Thank you. I checked the PR you created - >> > https://github.com/apache/qpid-dispatch/pull/1262 - and it looks good. >> > Any thoughts on when you might start the vote ? >> > Thanks. >> > >> > > >> > > On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy >> wrote: >> > > >> > > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: >> > > > >> > > > > There have been a couple of fixes since the 1.16.0 release that >> are >> > > > > useful for users of the tcp support. Making those available as a >> > > > > 1.16.1 seems like a good idea to me. The fixes I would suggest >> are: >> > > > > >> > > > > DISPATCH-2142 >> > > > > DISPATCH-2097 >> > > > > DISPATCH-1878 (last commit) >> > > > > >> > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b >> > > > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 >> > > (DISPATCH-2170), >> > > > so please include cc3a53d2 as well. >> > > > >> > > > Thanks. >> > > > >> > > > > >> > > > > >> > > > > >> - >> > > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org >> > > > > For additional commands, e-mail: users-h...@qpid.apache.org >> > > > > >> > > > > >> > > > >> > > >> > > >> > > -- >> > > -K >> > > >> >> - >> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org >> For additional commands, e-mail: users-h...@qpid.apache.org >> >> > > -- > -K > -- -K
Re: [dispatch-router] 1.16.1 release?
On Thu, Jun 17, 2021 at 4:33 AM Robbie Gemmell wrote: > I'm glad to see a followup release being done, but I find it > surprising that more of the resolved 'bug' JIRA fixes aren't being > included: > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20DISPATCH%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%201.17.0 > > Particularly the ones that are marked as blockers, but I'd wonder > about various others too, especially given one of the few JIRAs being > included isnt a bug fix. > That's understandable, but we have to consider minimizing risk to the stability of the 1.16.x branch as well. While we do have a number of blockers fixed, we're also seeing a number of CI failures on main. We're moving towards fixing these, but without knowing the root causes for these failures I'm a bit reluctant to introduce more stuff onto the stable branch than absolutely necessary. The fixes that have been proposed address issues found by users of the TCP functionality introduced in 1.16.0 that basically make that functionality unusable for their purposes. From that perspective it can be argued that DISPATCH-2142 is more bugfix than improvement. > > On Wed, 16 Jun 2021 at 20:18, Ganesh Murthy wrote: > > > > On Wed, Jun 16, 2021 at 1:08 PM Ken Giusti wrote: > > > > > Ok, I'll pull in DISPATCH-2170 to the PR as well. > > > > > Thank you. I checked the PR you created - > > https://github.com/apache/qpid-dispatch/pull/1262 - and it looks good. > > Any thoughts on when you might start the vote ? > > Thanks. > > > > > > > > On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy > wrote: > > > > > > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > > > > > > > > > There have been a couple of fixes since the 1.16.0 release that are > > > > > useful for users of the tcp support. Making those available as a > > > > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > > > > > > > DISPATCH-2142 > > > > > DISPATCH-2097 > > > > > DISPATCH-1878 (last commit) > > > > > > > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > > > > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 > > > (DISPATCH-2170), > > > > so please include cc3a53d2 as well. > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > > > > > > > > > > > > > > > > > -- > > > -K > > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > > -- -K
Re: [dispatch-router] 1.16.1 release?
I'm glad to see a followup release being done, but I find it surprising that more of the resolved 'bug' JIRA fixes aren't being included: https://issues.apache.org/jira/issues/?jql=project%20%3D%20DISPATCH%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%201.17.0 Particularly the ones that are marked as blockers, but I'd wonder about various others too, especially given one of the few JIRAs being included isnt a bug fix. On Wed, 16 Jun 2021 at 20:18, Ganesh Murthy wrote: > > On Wed, Jun 16, 2021 at 1:08 PM Ken Giusti wrote: > > > Ok, I'll pull in DISPATCH-2170 to the PR as well. > > > Thank you. I checked the PR you created - > https://github.com/apache/qpid-dispatch/pull/1262 - and it looks good. > Any thoughts on when you might start the vote ? > Thanks. > > > > > On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy wrote: > > > > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > > > > > > > There have been a couple of fixes since the 1.16.0 release that are > > > > useful for users of the tcp support. Making those available as a > > > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > > > > > DISPATCH-2142 > > > > DISPATCH-2097 > > > > DISPATCH-1878 (last commit) > > > > > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > > > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 > > (DISPATCH-2170), > > > so please include cc3a53d2 as well. > > > > > > Thanks. > > > > > > > > > > > > > > > - > > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > > > > > > > > > > > -- > > -K > > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [dispatch-router] 1.16.1 release?
On Wed, 16 Jun 2021 at 17:09, Ganesh Murthy wrote: > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > > > There have been a couple of fixes since the 1.16.0 release that are > > useful for users of the tcp support. Making those available as a > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > DISPATCH-2142 > > DISPATCH-2097 > > DISPATCH-1878 (last commit) > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 (DISPATCH-2170), > so please include cc3a53d2 as well. > > Thanks. > If information like this is known its good to reflect it on the JIRAs (I have just linked them and commented to this effect). It can be good to know later and would for example help someone (e.g Ken) decide to backport that important bug fix too without it needing to be pointed out like this. Since the original change was just made and hasnt been released, the fix commit should really have been made against DISPATCH-2097 as well/instead if known at the time given it is effectively part of that issue. > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
Re: [dispatch-router] 1.16.1 release?
On Wed, Jun 16, 2021 at 1:08 PM Ken Giusti wrote: > Ok, I'll pull in DISPATCH-2170 to the PR as well. > Thank you. I checked the PR you created - https://github.com/apache/qpid-dispatch/pull/1262 - and it looks good. Any thoughts on when you might start the vote ? Thanks. > > On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy wrote: > > > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > > > > > There have been a couple of fixes since the 1.16.0 release that are > > > useful for users of the tcp support. Making those available as a > > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > > > DISPATCH-2142 > > > DISPATCH-2097 > > > DISPATCH-1878 (last commit) > > > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 > (DISPATCH-2170), > > so please include cc3a53d2 as well. > > > > Thanks. > > > > > > > > > > > - > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > > > > > -- > -K >
Re: [dispatch-router] 1.16.1 release?
Ok, I'll pull in DISPATCH-2170 to the PR as well. On Wed, Jun 16, 2021 at 12:19 PM Ganesh Murthy wrote: > On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > > > There have been a couple of fixes since the 1.16.0 release that are > > useful for users of the tcp support. Making those available as a > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > DISPATCH-2142 > > DISPATCH-2097 > > DISPATCH-1878 (last commit) > > > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b > 00a2b3 introduced a memory leak that was fixed in cc3a53d2 (DISPATCH-2170), > so please include cc3a53d2 as well. > > Thanks. > > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > -- -K
Re: [dispatch-router] 1.16.1 release?
On Tue, Jun 15, 2021 at 2:39 PM Gordon Sim wrote: > There have been a couple of fixes since the 1.16.0 release that are > useful for users of the tcp support. Making those available as a > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > DISPATCH-2142 > DISPATCH-2097 > DISPATCH-1878 (last commit) > The fix to DISPATCH-2097 consists of 2 commits - 00a2b3 and d5889b 00a2b3 introduced a memory leak that was fixed in cc3a53d2 (DISPATCH-2170), so please include cc3a53d2 as well. Thanks. > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > >
Re: [dispatch-router] 1.16.1 release?
Gordon, Chuck and Ernie: I've created a github PR that merges the requested fixes onto the 1.16.x branch. https://github.com/apache/qpid-dispatch/pull/1262 Please review and test, thanks. On Wed, Jun 16, 2021 at 9:16 AM Ken Giusti wrote: > +1 to a 1.16.1 release for these fixes. > > I'll take a spin through the list of resolved bug JIRAs to see if anything > else pops out. Feel free to do the same. > > I'd like to start by cherry-picking those fixes suggested by Gordon down > to the 1.16.x branch later today unless anyone has a strong objection to > that. > > -K > > > On Wed, Jun 16, 2021 at 4:08 AM Robbie Gemmell > wrote: > >> Doing a 1.16.1 release sounds like a good idea to me. I'd wonder if >> there are possibly some other fixes appropriate to include too given >> the volume of bug JIRAs resolved since 1.16.0. >> >> On Tue, 15 Jun 2021 at 19:31, Gordon Sim wrote: >> > >> > There have been a couple of fixes since the 1.16.0 release that are >> > useful for users of the tcp support. Making those available as a >> > 1.16.1 seems like a good idea to me. The fixes I would suggest are: >> > >> > DISPATCH-2142 >> > DISPATCH-2097 >> > DISPATCH-1878 (last commit) >> > >> > >> > - >> > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org >> > For additional commands, e-mail: users-h...@qpid.apache.org >> > >> >> - >> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org >> For additional commands, e-mail: users-h...@qpid.apache.org >> >> > > -- > -K > -- -K
Re: [dispatch-router] 1.16.1 release?
+1 to a 1.16.1 release for these fixes. I'll take a spin through the list of resolved bug JIRAs to see if anything else pops out. Feel free to do the same. I'd like to start by cherry-picking those fixes suggested by Gordon down to the 1.16.x branch later today unless anyone has a strong objection to that. -K On Wed, Jun 16, 2021 at 4:08 AM Robbie Gemmell wrote: > Doing a 1.16.1 release sounds like a good idea to me. I'd wonder if > there are possibly some other fixes appropriate to include too given > the volume of bug JIRAs resolved since 1.16.0. > > On Tue, 15 Jun 2021 at 19:31, Gordon Sim wrote: > > > > There have been a couple of fixes since the 1.16.0 release that are > > useful for users of the tcp support. Making those available as a > > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > > > DISPATCH-2142 > > DISPATCH-2097 > > DISPATCH-1878 (last commit) > > > > > > - > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > > -- -K
Re: [dispatch-router] 1.16.1 release?
Doing a 1.16.1 release sounds like a good idea to me. I'd wonder if there are possibly some other fixes appropriate to include too given the volume of bug JIRAs resolved since 1.16.0. On Tue, 15 Jun 2021 at 19:31, Gordon Sim wrote: > > There have been a couple of fixes since the 1.16.0 release that are > useful for users of the tcp support. Making those available as a > 1.16.1 seems like a good idea to me. The fixes I would suggest are: > > DISPATCH-2142 > DISPATCH-2097 > DISPATCH-1878 (last commit) > > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
[dispatch-router] 1.16.1 release?
There have been a couple of fixes since the 1.16.0 release that are useful for users of the tcp support. Making those available as a 1.16.1 seems like a good idea to me. The fixes I would suggest are: DISPATCH-2142 DISPATCH-2097 DISPATCH-1878 (last commit) - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
