Re: Fwd: Note to SA authors and Mail::SpamAssassin::Message

2005-04-17 Thread Theo Van Dinter
On Sat, Apr 16, 2005 at 05:07:43PM -0500, Robert Nicholson wrote:
 Only a minor annoyance there being an inconsistency with the way the 
 extra new line is present from
 get_pristine_header.

There is no designed Mail::Audit compatibility in M::SA::Message.
I'd be surprised if this is the only difference there is between the two.

-- 
Randomly Generated Tagline:
Like any French restaurant in America, it was overpriced, noisy, moody,
 and would put you in mortal danger if you had an accident with anything
 larger than a croissant. - Unknown about the Renault LeCar


pgpMRTdkOTIRX.pgp
Description: PGP signature


Re: Note to SA authors and Mail::SpamAssassin::Message

2005-04-17 Thread Robert Nicholson
My point would be that
What will Mail::Internet get_header return? Will it have the new line 
or not?

I guess it says pristine which means what?
If it said get_header then I'd take issue because it also includes the 
separate b/w header and body.

Clearly in SA there are very few occurrences where you actually need 
the header _without_ the separator

On Apr 17, 2005, at 8:33 AM, Theo Van Dinter wrote:
On Sat, Apr 16, 2005 at 05:07:43PM -0500, Robert Nicholson wrote:
Only a minor annoyance there being an inconsistency with the way the
extra new line is present from
get_pristine_header.
There is no designed Mail::Audit compatibility in M::SA::Message.
I'd be surprised if this is the only difference there is between the 
two.

--
Randomly Generated Tagline:
Like any French restaurant in America, it was overpriced, noisy, 
moody,
 and would put you in mortal danger if you had an accident with 
anything
 larger than a croissant. - Unknown about the Renault LeCar


Re: Note to SA authors and Mail::SpamAssassin::Message

2005-04-17 Thread Theo Van Dinter
On Sun, Apr 17, 2005 at 10:20:41AM -0500, Robert Nicholson wrote:
 What will Mail::Internet get_header return? Will it have the new line 
 or not?

Don't know.  Why does this matter wrt SA?  We don't use Mail::Internet.

 I guess it says pristine which means what?

The pristine functions return the data as passed in originally to
M::SA::Message.  No whitespace folding is dealt with, no decoding, etc.

 If it said get_header then I'd take issue because it also includes the 
 separate b/w header and body.

b/w ?

-- 
Randomly Generated Tagline:
I won't use Windows, I won't use Windows ...


pgpbai7fVtXhk.pgp
Description: PGP signature


Fwd: Note to SA authors and Mail::SpamAssassin::Message

2005-04-16 Thread Robert Nicholson

Begin forwarded message:
From: Robert Nicholson [EMAIL PROTECTED]
Date: April 16, 2005 12:24:22 PM CDT
To: Sa-Talk (E-mail) spamassassin-talk@lists.sourceforge.net
Subject: Note to SA authors and Mail::SpamAssassin::Message
Only a minor annoyance there being an inconsistency with the way the 
extra new line is present from
get_pristine_header.

my $header = undef;
  if ($mail-isa('Mail::Audit')) {
 $header = $mail-header;
  } elsif ($mail-isa('Mail::SpamAssassin::Message')) {
 $header = $mail-get_pristine_header;
 # remove the last new line
 $header =~ s/\s$//g;