Re: Tapestry 5.3 and progressive display
Ok; I just created an alpha-10 to address some of the other issues Andy has hit. On Mon, Aug 8, 2011 at 10:53 AM, pedro wrote: > I'll take a look at it, maybe we are not using the latest alpha release (I > think we are in alpha 9). We haven't patched that code, and there is no > check in the zone variable, so I'll look for the latest code and let you > know. > > -- > View this message in context: > http://tapestry-users.832.n2.nabble.com/Tapestry-5-3-and-progressive-display-js-issue-tp6664856p6665232.html > Sent from the Tapestry Users mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3 and progressive display
I'll take a look at it, maybe we are not using the latest alpha release (I think we are in alpha 9). We haven't patched that code, and there is no check in the zone variable, so I'll look for the latest code and let you know. -- View this message in context: http://tapestry-users.832.n2.nabble.com/Tapestry-5-3-and-progressive-display-js-issue-tp6664856p6665232.html Sent from the Tapestry Users mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3 and progressive display
Are you possibly monkey-patching the code? Here's the current version of that:
processReply : function(reply) {
Tapestry.loadScriptsInReply(reply, function() {
/*
* In a multi-zone update, the reply.content may be missing, in
* which case, leave the curent content in place. TAP5-1177
*/
reply.content != undefined && this.show(reply.content);
/*
* zones is an object of zone ids and zone content that will be
* present in a multi-zone update response.
*/
reply.zones && Object.keys(reply.zones).each(function(zoneId) {
var manager = Tapestry.findZoneManagerForZone(zoneId);
if (manager) {
var zoneContent = reply.zones[zoneId];
manager.show(zoneContent);
}
});
}.bind(this));
},
Unless I'm missing something, that should handle the case for
reply.zones being null/undefined correctly. Certainly, Tapestry's
test suite includes the case for ProgressiveDisplay without additional
zones being updated.
In addition, Tapestry is transitioning towards a more "fail early"
approach on the client side, since the mechanisms in place to allow
initialization to continue after a JavaScript error make it very hard
to actually identify and fix the cause of the JavaScript error.
On Mon, Aug 8, 2011 at 9:58 AM, Howard Lewis Ship wrote:
> Thanks, I'll take a peek at this. I think it must be some unintended
> consequences of other changes.
>
> On Mon, Aug 8, 2011 at 9:13 AM, pedro wrote:
>> Hi,
>>
>> We are currently going through the update to Tapestry 5.3 and we have found
>> an issue while using the progressive display component.
>>
>> There is an exception in the tapestry javascript while loading the
>> progressive display in the processReply function. The problem is in the loop
>> through the zones of the reply (
>> /Object.keys(reply.zones).each(function(zoneId) / ) as they are not defined
>> in the case of this component.
>>
>> After the exception no other javascript is processed.
>>
>> Regars,
>> Pedro Ayala
>> Software Developer
>> ProQuest
>>
>>
>> --
>> View this message in context:
>> http://tapestry-users.832.n2.nabble.com/Tapestry-5-3-and-progressive-display-tp6664856p6664856.html
>> Sent from the Tapestry Users mailing list archive at Nabble.com.
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
>> For additional commands, e-mail: users-h...@tapestry.apache.org
>>
>>
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
-
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3 and progressive display
Thanks, I'll take a peek at this. I think it must be some unintended consequences of other changes. On Mon, Aug 8, 2011 at 9:13 AM, pedro wrote: > Hi, > > We are currently going through the update to Tapestry 5.3 and we have found > an issue while using the progressive display component. > > There is an exception in the tapestry javascript while loading the > progressive display in the processReply function. The problem is in the loop > through the zones of the reply ( > /Object.keys(reply.zones).each(function(zoneId) / ) as they are not defined > in the case of this component. > > After the exception no other javascript is processed. > > Regars, > Pedro Ayala > Software Developer > ProQuest > > > -- > View this message in context: > http://tapestry-users.832.n2.nabble.com/Tapestry-5-3-and-progressive-display-tp6664856p6664856.html > Sent from the Tapestry Users mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Tapestry 5.3 and progressive display
Hi, We are currently going through the update to Tapestry 5.3 and we have found an issue while using the progressive display component. There is an exception in the tapestry javascript while loading the progressive display in the processReply function. The problem is in the loop through the zones of the reply ( /Object.keys(reply.zones).each(function(zoneId) / ) as they are not defined in the case of this component. After the exception no other javascript is processed. Regars, Pedro Ayala Software Developer ProQuest -- View this message in context: http://tapestry-users.832.n2.nabble.com/Tapestry-5-3-and-progressive-display-tp6664856p6664856.html Sent from the Tapestry Users mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
