Re: Tapestry 5.3.4-rc-9
At this point, I'm thinking 5.3.5 will fix yuicompressor. I just want to get 5.3.4 out the door On Wed, Jul 4, 2012 at 6:51 AM, Jochen Berger wrote: > Am 04.07.2012 10:55, schrieb Lenny Primak: > >> I don't think there is a 'clean' solution. > > > Hopefully, requirejs/uglifyjs will be able to make all this obsolete by the > end of this year. :-) > > > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
Hi, Am 05.07.2012 02:39, schrieb Bob Harner: I'm trying to follow what was done with YUICompressor in Tapestry 5.3.4-rc-9, somebody tell me if I have it right: To get YUICompressor to work more reliably, Tapestry 5.3.4-rc-9 includes a version of the YUICompressor that the maven-play-plugin project built (at http://maven-play-plugin.googlecode.com/svn/mavenrepo/releases/), which includes versions of Rhino classes correct up to here AFAICT that have had their package names changed to avoid conflicts with other implementations of Rhino that may be on the classpath. Right? No, unfortunately not. That is what would have solved the problems. 5.3.3 included rhino and yuicompressor 2.4.6. The latter contained modified versions of some of the classes contained in rhino, so the classes ended up on the classpath twice. once from rhino (unmodified) and once from yuicompressor (modified). This caused serious issues so for 5.3.4, yuicompressor was upgraded. In 5.3.4, t-yuicompressor has a dependency on the aforementioned yuicompressor 2.4.7 from the maven-play repo. The only difference apart from the version is that that jar is a merged package of rhino, jargs and yuicompressor itself. No chances in package names or whatsoever, just all three jars merged together in one with the modified rhino classes from yuicompressor simply overwriting the original ones. While this eliminates the duplication in classes between rhino and yui, conflicts with other libraries that depend on rhino themselves (like t5conduit) remain the same. Sooner or later we might even have a conflicting rhino in tapestry-core if Howard decides to pull it in via wro4j as a compile dependency for Tapestry 5.4. Jochen - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
Sounds reasonable. I don't know what play project did though. On Jul 4, 2012, at 8:39 PM, Bob Harner wrote: > I'm trying to follow what was done with YUICompressor in Tapestry > 5.3.4-rc-9, somebody tell me if I have it right: To get YUICompressor > to work more reliably, Tapestry 5.3.4-rc-9 includes a version of the > YUICompressor that the maven-play-plugin project built (at > http://maven-play-plugin.googlecode.com/svn/mavenrepo/releases/), > which includes versions of Rhino classes that have had their package > names changed to avoid conflicts with other implementations of Rhino > that may be on the classpath. Right? > > On Wed, Jul 4, 2012 at 9:51 AM, Jochen Berger > wrote: >> Am 04.07.2012 10:55, schrieb Lenny Primak: >> >>> I don't think there is a 'clean' solution. >> >> >> Hopefully, requirejs/uglifyjs will be able to make all this obsolete by the >> end of this year. :-) >> >> >> >> - >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: users-h...@tapestry.apache.org >> > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
I'm trying to follow what was done with YUICompressor in Tapestry 5.3.4-rc-9, somebody tell me if I have it right: To get YUICompressor to work more reliably, Tapestry 5.3.4-rc-9 includes a version of the YUICompressor that the maven-play-plugin project built (at http://maven-play-plugin.googlecode.com/svn/mavenrepo/releases/), which includes versions of Rhino classes that have had their package names changed to avoid conflicts with other implementations of Rhino that may be on the classpath. Right? On Wed, Jul 4, 2012 at 9:51 AM, Jochen Berger wrote: > Am 04.07.2012 10:55, schrieb Lenny Primak: > >> I don't think there is a 'clean' solution. > > > Hopefully, requirejs/uglifyjs will be able to make all this obsolete by the > end of this year. :-) > > > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
Am 04.07.2012 10:55, schrieb Lenny Primak: I don't think there is a 'clean' solution. Hopefully, requirejs/uglifyjs will be able to make all this obsolete by the end of this year. :-) - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
I have solved this problem by repackaging yuicompressor, rhino and tap-yuicompressor into a single .jar file using jarjar, which solves all problems. I don't think there is a 'clean' solution. --- Combine yucompressor-2.4.6 and rhino-1.6R7 into src file (via jar) $ mkdir work; cd work $ jar xf ~/.m2/repository/rhino/js/1.6R7/js-1.6R7.jar $ jar xf ~/.m2/repository/com/yahoo/platform/yui/yuicompressor/2.4.6/yuicompressor-2.4.6.jar $ jar xf ~/.m2/repository/org/apache/tapestry/tapestry-yuicompressor/5.3.2/tapestry-yuicompressor-5.3.2.jar $ jar cfm ../yuic.jar META-INF/MANIFEST.MF . Using instructions in http://yuilibrary.com/projects/yuicompressor/ticket/2527981 to generate yuicompressor and upload it to the BAW repo $ java -jar jarjar-1.2.jar process yui-rules.txt yuic.jar yuicompressor-2.4.6-cust-tap-5.3.2.jar $ mvn deploy:deploy-file -DgroupId=com.yahoo.platform.yui -DartifactId=yuicompressor -Dversion=2.4.6-cust-tap-5.3.2 -DgeneratePom=true -Dpackaging=jar -Dfile=yuicompressor-2.4.6-cust-tap-5.3.2.jar -DrepositoryId=repo -Durl=file://flowlogix-m2 - - yui-rules.txt -- rule jargs.gnu.** com.yahoo.platform.yui.@0 rule org.mozilla.** com.yahoo.platform.yui.@0 keep com.yahoo.** keep org.apache.** --- On Jul 4, 2012, at 4:48 AM, Felix Gonschorek wrote: > howard, > > i encountered problems with yuicompressor too (in the rc5 release i > think). i deactivated the yuicompressor tap5 module to fix it. the > problem for me was this: > > http://yuilibrary.com/projects/yuicompressor/ticket/2528056 > > the yuicompressor has its own version of the rhino classes, but in the > same package hierachy. i have my own (newer) rhino dependency in the > classpath. when the yuicompressor rhino classes gets loaded first, my > application starts to massively throw exceptions. > > maybe this helps narrowing down things. > > felix > > > Am 03.07.2012 18:16, schrieb Howard Lewis Ship: >> I've just released Tapestry 5.3.4-rc-9. >> >> The only difference from rc-8 is that the POM for >> tapestry-yuicompressor correctly identifies the repository one of its >> dependencies comes from (that is not in the Maven central repository). >> >> However, may people (including myself) are having issues with >> yuicompressor in running applications; I'm still trying to get to the >> core of it, my working theory is some conflict between the patched >> version of Rhino (the JavaScript engine) inside the yuicompressor >> library, and the version of Rhino that is packaged with JDK 1.6 and >> up. >> > > > - > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Re: Tapestry 5.3.4-rc-9
howard, i encountered problems with yuicompressor too (in the rc5 release i think). i deactivated the yuicompressor tap5 module to fix it. the problem for me was this: http://yuilibrary.com/projects/yuicompressor/ticket/2528056 the yuicompressor has its own version of the rhino classes, but in the same package hierachy. i have my own (newer) rhino dependency in the classpath. when the yuicompressor rhino classes gets loaded first, my application starts to massively throw exceptions. maybe this helps narrowing down things. felix Am 03.07.2012 18:16, schrieb Howard Lewis Ship: > I've just released Tapestry 5.3.4-rc-9. > > The only difference from rc-8 is that the POM for > tapestry-yuicompressor correctly identifies the repository one of its > dependencies comes from (that is not in the Maven central repository). > > However, may people (including myself) are having issues with > yuicompressor in running applications; I'm still trying to get to the > core of it, my working theory is some conflict between the patched > version of Rhino (the JavaScript engine) inside the yuicompressor > library, and the version of Rhino that is packaged with JDK 1.6 and > up. > - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
Tapestry 5.3.4-rc-9
I've just released Tapestry 5.3.4-rc-9. The only difference from rc-8 is that the POM for tapestry-yuicompressor correctly identifies the repository one of its dependencies comes from (that is not in the Maven central repository). However, may people (including myself) are having issues with yuicompressor in running applications; I'm still trying to get to the core of it, my working theory is some conflict between the patched version of Rhino (the JavaScript engine) inside the yuicompressor library, and the version of Rhino that is packaged with JDK 1.6 and up. -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com - To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
