Re: tc-embed-9.0.38 : module does not declare uses
On 10/9/20 11:49 AM, Mark Thomas wrote: On 09/10/2020 16:38, marc.davenp...@oracle.com wrote: Hello all, I'm trying to upgrade from 9.0.35 to 9.0.38. I know that explicit module definitions were added between .37 & .38. I'm just trying to shake out the changes needed on our end to use it. It's my tentative grasp on proper use of modules, but I could use some help. Now when we are starting our embedded tomcat, I am getting an error as we instantiate and configure the AccessLogValve. Exception in thread "main" java.util.ServiceConfigurationError: org.apache.juli.logging.Log: module org.apache.tomcat.embed.core does not declare `uses` https://urldefense.com/v3/__https://bz.apache.org/bugzilla/show_bug.cgi?id=64751__;!!GqivPVa7Brio!LobtElrQgI0ja3WtqMuX9RiJwqU3mbRK3cjL70UP3z5ZNsIfXECcvNMvkLriRL5oYwg$ Fixed in 9.0.39 which looks as if it will be released very (hours) shortly. Mark Ah, that explains it. Thanks for the reply. I'm going to switch to 9.0.37 and then deal with the JPMS changes in the next quarter. Regards, Marc at java.base/java.util.ServiceLoader.fail(Unknown Source) at java.base/java.util.ServiceLoader.checkCaller(Unknown Source) at java.base/java.util.ServiceLoader.(Unknown Source) at java.base/java.util.ServiceLoader.load(Unknown Source) at org.apache.tomcat.embed.core@9.0.38/org.apache.juli.logging.LogFactory.(LogFactory.java:89) at org.apache.tomcat.embed.core@9.0.38/org.apache.juli.logging.LogFactory.(LogFactory.java:66) at org.apache.tomcat.embed.core@9.0.38/org.apache.catalina.util.LifecycleBase.(LifecycleBase.java:39) at our/Server.start(OurServer.java:104) -> new AccessLogValve(). We are running against a custom jre made by jlink which includes the following mods which might be pertinent. /mods/commons-logging-1.2.jar ... /mods/slf4j-api-1.8.0-beta4.jar /mods/slf4j-log4j-100.0.0.0.0-SNAPSHOT.jar (shaded jar) ... /mods/tomcat-annotations-api-9.0.38.jar /mods/tomcat-embed-core-9.0.38.jar /mods/tomcat-embed-el-9.0.38.jar /mods/tomcat-embed-jasper-9.0.38.jar I'm not sure what the implication of this error message is and any help would be appreciated. Thank you, Marc - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
tc-embed-9.0.38 : module does not declare uses
Hello all, I'm trying to upgrade from 9.0.35 to 9.0.38. I know that explicit module definitions were added between .37 & .38. I'm just trying to shake out the changes needed on our end to use it. It's my tentative grasp on proper use of modules, but I could use some help. Now when we are starting our embedded tomcat, I am getting an error as we instantiate and configure the AccessLogValve. Exception in thread "main" java.util.ServiceConfigurationError: org.apache.juli.logging.Log: module org.apache.tomcat.embed.core does not declare `uses` at java.base/java.util.ServiceLoader.fail(Unknown Source) at java.base/java.util.ServiceLoader.checkCaller(Unknown Source) at java.base/java.util.ServiceLoader.(Unknown Source) at java.base/java.util.ServiceLoader.load(Unknown Source) at org.apache.tomcat.embed.core@9.0.38/org.apache.juli.logging.LogFactory.(LogFactory.java:89) at org.apache.tomcat.embed.core@9.0.38/org.apache.juli.logging.LogFactory.(LogFactory.java:66) at org.apache.tomcat.embed.core@9.0.38/org.apache.catalina.util.LifecycleBase.(LifecycleBase.java:39) at our/Server.start(OurServer.java:104) -> new AccessLogValve(). We are running against a custom jre made by jlink which includes the following mods which might be pertinent. /mods/commons-logging-1.2.jar ... /mods/slf4j-api-1.8.0-beta4.jar /mods/slf4j-log4j-100.0.0.0.0-SNAPSHOT.jar (shaded jar) ... /mods/tomcat-annotations-api-9.0.38.jar /mods/tomcat-embed-core-9.0.38.jar /mods/tomcat-embed-el-9.0.38.jar /mods/tomcat-embed-jasper-9.0.38.jar I'm not sure what the implication of this error message is and any help would be appreciated. Thank you, Marc - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
Re: new module-info.class & tomcat-embed-programmatic.jar in 9.0.38 embed distribution.
On 10/7/20 2:50 PM, Mark Thomas wrote:
On 07/10/2020 19:47, marc.davenp...@oracle.com wrote:
On 10/7/20 1:51 PM, Mark Thomas wrote:
On 07/10/2020 18:29, marc.davenp...@oracle.com wrote:
I'm doing a simple upgrade from 9.0.35 to 9.0.38 embed. I notice some
significant changes that I don't see listed in the changelog.
There are covered by the entry for bug 64540.
Ah, thank you for the clarification. I didn't understand the
implications of that note.
The annotations-api.jar module-info is using the java namespace?
open module java.annotation {
requires java.base;
exports javax.annotation;
exports javax.annotation.security;
exports javax.annotation.sql;
}
Until 9.0.37 tomcat-embed-core.jar did not have a module-info. Now in
9.0.38 it does. This changes the modules I need to require when using
it. This may be the right way to be doing thing all along, but it does
feel like a significant change and not a simple upgrade with a version
bump.
There is also a new tomcat-embed-programmatic.jar in the
apache-tomcat-9.0.38-embed.zip distribution but it does not seem to be
available alone in maven central:
https://urldefense.com/v3/__https://mvnrepository.com/artifact/org.apache.tomcat.embed__;!!GqivPVa7Brio!Mrj4iTWd6AiGf5VPU0EyhkGtFSZfsmaM_UC7lBc_eDHuZc2GpP9iUTE2VAucYNb_A5U$
I suspect the new JAR was added to the main build script but not the
script that does the Maven upload.
That should be something we can fix for the November release round.
What is the intention for this new jar?
I believe it is intended for use in environments (Graal) where you don't
want to use reflection (i.e. standard XML configuration files) to
configure Tomcat.
Mark
-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
Re: new module-info.class & tomcat-embed-programmatic.jar in 9.0.38 embed distribution.
On 10/7/20 1:51 PM, Mark Thomas wrote: On 07/10/2020 18:29, marc.davenp...@oracle.com wrote: I'm doing a simple upgrade from 9.0.35 to 9.0.38 embed. I notice some significant changes that I don't see listed in the changelog. There are covered by the entry for bug 64540. Ah, thank you for the clarification. I didn't understand the implications of that note. Until 9.0.37 tomcat-embed-core.jar did not have a module-info. Now in 9.0.38 it does. This changes the modules I need to require when using it. This may be the right way to be doing thing all along, but it does feel like a significant change and not a simple upgrade with a version bump. There is also a new tomcat-embed-programmatic.jar in the apache-tomcat-9.0.38-embed.zip distribution but it does not seem to be available alone in maven central: https://urldefense.com/v3/__https://mvnrepository.com/artifact/org.apache.tomcat.embed__;!!GqivPVa7Brio!Mrj4iTWd6AiGf5VPU0EyhkGtFSZfsmaM_UC7lBc_eDHuZc2GpP9iUTE2VAucYNb_A5U$ I suspect the new JAR was added to the main build script but not the script that does the Maven upload. That should be something we can fix for the November release round. What is the intention for this new jar? Mark - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
new module-info.class & tomcat-embed-programmatic.jar in 9.0.38 embed distribution.
I'm doing a simple upgrade from 9.0.35 to 9.0.38 embed. I notice some significant changes that I don't see listed in the changelog. Until 9.0.37 tomcat-embed-core.jar did not have a module-info. Now in 9.0.38 it does. This changes the modules I need to require when using it. This may be the right way to be doing thing all along, but it does feel like a significant change and not a simple upgrade with a version bump. There is also a new tomcat-embed-programmatic.jar in the apache-tomcat-9.0.38-embed.zip distribution but it does not seem to be available alone in maven central: https://mvnrepository.com/artifact/org.apache.tomcat.embed - To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
