Re: Version migration problems

2020-06-19 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Niranjan,

On 6/19/20 13:17, Niranjan Rao wrote:
> Hi Mark/Chris,
>
> Thank you for the reply.
>
> It's a spring application, related controllers/methods basically
> return page name as return "pages/Login".
>
> The view resolver maps it WEB-INF/jsp/pages/Login.jsp.
>
> Login.jsp has entry that says
>
> 
>
> This entry gets resolved correctly in V7, but V9 I get error can
> not find pages/jsp/fragments/commonData.jsp.
>
> After playing with it couple of hours, I figured out full path
> works. So issue seems to be root context/directory of jsp engine
> that was WEB-INF seems to have changed to current directory where
> page is getting loaded. JSP generation still generates same line
> for both of them like following.
>
> org.apache.jasper.runtime.JspRuntimeLibrary.include(request,
> response, "jsp/fragments/commonData.jsp", out, false);
>
> But v9 interprets it relative to directory of current jsp that is
> in my case WEB-INF/jsp/pages and older engine interprets it
> relative to WEB-INF directory.
>
> JDK version 1.8.0_111, Operating system is 16.04.6. It's same WAR
> file getting deployed in both tomcat versions. Only difference is
> server.xml has different ports.

I've never done this kind of thing (I tend not to use very many JSPs),
but I think you probably want all your file paths to start with "/".
So that should be:



or maybe:



... unless the path is supposed to be relative to "Login.jsp".

Do you have these two files?

WEB-INF/pages/Login.jsp
WEB-INF/pages/jsp/fragments/commonData.jsp

?

If not, then your application isn't built properly. These rules have
always been the case, though, so I'm not sure why it would have worked
on Tomcat 7 but no longer works on Tomcat 9.

- -chris

> On 6/19/20 6:13 AM, Mark Thomas wrote:
>> On 19/06/2020 13:19, Christopher Schultz wrote:
>>> Niranjan,
>>>
>>> On 6/18/20 13:47, Niranjan Rao wrote:
 I am trying to migrate from 7.0.73 to 9.0.36 and facing
 challenges. Java version and operating system version remains
 same in both cases.
>>> ... and what are those versions?
>>>
 I have carefully reviewed the configurations and everything
 looks ok. Version 9 does not report any problems when
 starting the application either in catalina.out file or in
 the application log file.
>>> Good.
>>>
 Applications has bunch of JSP pages which sit under
 WEB-INF/jsp/pages directory and some of these pages include
 fragments from WEB-INF/jsp/fragments directory. In the older
 version V7 this works correctly, but in V9 I get error about
 include not not found. Page do get resolved correctly, but
 includes do not.
>>> Can you give some examples?
>> +1. The simplest test case that demonstrates the issue would be
>> good. That should be a JSP, a JSP fragment and the appropriate
>> directory structure.
>>
>> Mark
>>
 Given only change is tomcat version as it's same WAR file
 deployed on same operating system and same java version, I am
 thinking I am missing some basic change in tomcat JSP lookup
 for version 9.
>>>
 Can anyone please point me what I can be doing wrong or what
 I need to do so that same WAR file works in both versions
>>> -chris
>>>
>>>
>>> 
- -
>>>
>>>
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>>
>>
>> -
>>
>>
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: users-h...@tomcat.apache.org
>>
>
>
> -
>
>
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl7tHcAACgkQHPApP6U8
pFjqnQ/+LOlgMJirTrnwX/2Bsev2Pxfr80JXx7g9JjAxGTT+ncmYDPnV/xPfNS1m
OuZtveZorks4Hvmb62qhSaQWv3GlRwUGn4gYuvSb/EIUX7HWaKJ+f4Zwqjzx0LG/
YAWyK0WeFB4tm9NGjneHGJ5GzfV96WETGNKou38THVAf2nIFBh29kaC9dAd/Pwac
zx5Pp2EUGUxwfBR1J3MFoi9XAZnCorpPCKilvtKjn3VMuCvvgQc2CPqarF3NI/S3
EXPRSj5fvQKoAaazEn1IbGbXw1YxkcR9NnV5HUb/+5yYLIbxkpGXcQagt+cbmkJb
SBEBsU4q8d7p/ZQYMt7M55P4+kcwpHtPTZwUiKl0u+dI6aw+F/DJONk4adzvvTHu
TkAj3DbEuRCegnbGZ8kcYwXRqP5d/CzJh/DCp34neMlGx6fDajuTkY2KfVwcFiZL
6kjPVmym1Gg2csUXjhu0z8T2AbeSFCwm3Fz/Utiqy5OLmhf8Q/mhYiDKdPoT+f9K
+9pbidEM0lCLshc0aDR3QOXRLn/jVf3IGc4OrhMniuVYT+kmNRCwtVBCWgc82Xar
X+4AwtyGTEgn22gJJ/t0wt+ke0YPrXYvsfR3pk+1XlUZxmRwue/kfduboNsz4FO3
LggXLocMDNPt0FYgUd8pcN4C1n/YxoUgUSxR//I384CdytmfZtU=
=OKkM
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Version migration problems

2020-06-19 Thread Niranjan Rao

Hi Mark/Chris,

Thank you for the reply.

It's a spring application, related controllers/methods basically return 
page name as return "pages/Login".


The view resolver maps it WEB-INF/jsp/pages/Login.jsp.

Login.jsp has entry that says



This entry gets resolved correctly in V7, but V9 I get error can not 
find pages/jsp/fragments/commonData.jsp.


After playing with it couple of hours, I figured out full path works. So 
issue seems to be root context/directory of jsp engine that was WEB-INF 
seems to have changed to current directory where page is getting loaded.

JSP generation still generates same line for both of them like following.

org.apache.jasper.runtime.JspRuntimeLibrary.include(request, response, 
"jsp/fragments/commonData.jsp", out, false);


But v9 interprets it relative to directory of current jsp that is in my 
case WEB-INF/jsp/pages and older engine interprets it relative to 
WEB-INF directory.


JDK version 1.8.0_111, Operating system is 16.04.6. It's same WAR file 
getting deployed in both tomcat versions. Only difference is server.xml 
has different ports.


Regards,

Niranjan
On 6/19/20 6:13 AM, Mark Thomas wrote:

On 19/06/2020 13:19, Christopher Schultz wrote:

Niranjan,

On 6/18/20 13:47, Niranjan Rao wrote:

I am trying to migrate from 7.0.73 to 9.0.36 and facing
challenges.
Java version and operating system version remains same in both
cases.

... and what are those versions?


I have carefully reviewed the configurations and everything looks
ok. Version 9 does not report any problems when starting the
application either in catalina.out file or in the application log
file.

Good.


Applications has bunch of JSP pages which sit under
WEB-INF/jsp/pages directory and some of these pages include
fragments from WEB-INF/jsp/fragments directory. In the older
version V7 this works correctly, but in V9 I get error about
include not not found. Page do get resolved correctly, but includes
do not.

Can you give some examples?

+1. The simplest test case that demonstrates the issue would be good.
That should be a JSP, a JSP fragment and the appropriate directory
structure.

Mark


Given only change is tomcat version as it's same WAR file deployed
on same operating system and same java version, I am thinking I am
missing some basic change in tomcat JSP lookup for version 9.



Can anyone please point me what I can be doing wrong or what I need
to do so that same WAR file works in both versions

-chris


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org




-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Version migration problems

2020-06-19 Thread Mark Thomas
On 19/06/2020 13:19, Christopher Schultz wrote:
> Niranjan,
> 
> On 6/18/20 13:47, Niranjan Rao wrote:
>> I am trying to migrate from 7.0.73 to 9.0.36 and facing
>> challenges.
> 
>> Java version and operating system version remains same in both
>> cases.
> 
> ... and what are those versions?
> 
>> I have carefully reviewed the configurations and everything looks
>> ok. Version 9 does not report any problems when starting the
>> application either in catalina.out file or in the application log
>> file.
> 
> Good.
> 
>> Applications has bunch of JSP pages which sit under
>> WEB-INF/jsp/pages directory and some of these pages include
>> fragments from WEB-INF/jsp/fragments directory. In the older
>> version V7 this works correctly, but in V9 I get error about
>> include not not found. Page do get resolved correctly, but includes
>> do not.
> 
> Can you give some examples?

+1. The simplest test case that demonstrates the issue would be good.
That should be a JSP, a JSP fragment and the appropriate directory
structure.

Mark

> 
>> Given only change is tomcat version as it's same WAR file deployed
>> on same operating system and same java version, I am thinking I am
>> missing some basic change in tomcat JSP lookup for version 9.
> 
> 
>> Can anyone please point me what I can be doing wrong or what I need
>> to do so that same WAR file works in both versions
> 
> -chris
> 
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Re: Version migration problems

2020-06-19 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Niranjan,

On 6/18/20 13:47, Niranjan Rao wrote:
> I am trying to migrate from 7.0.73 to 9.0.36 and facing
> challenges.
>
> Java version and operating system version remains same in both
> cases.

... and what are those versions?

> I have carefully reviewed the configurations and everything looks
> ok. Version 9 does not report any problems when starting the
> application either in catalina.out file or in the application log
> file.

Good.

> Applications has bunch of JSP pages which sit under
> WEB-INF/jsp/pages directory and some of these pages include
> fragments from WEB-INF/jsp/fragments directory. In the older
> version V7 this works correctly, but in V9 I get error about
> include not not found. Page do get resolved correctly, but includes
> do not.

Can you give some examples?

> Given only change is tomcat version as it's same WAR file deployed
> on same operating system and same java version, I am thinking I am
> missing some basic change in tomcat JSP lookup for version 9.
>
>
> Can anyone please point me what I can be doing wrong or what I need
> to do so that same WAR file works in both versions

- -chris

-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl7srVoACgkQHPApP6U8
pFgboBAAsPPfvI5s5NXt7ldN+tub4IBdjYnAqTDtd2Y7Rh2bCZLSjhet6wXIRZcL
acRC4o+OE+1Y9RhgTTDKYos9IEIr35WlFLLIRQMhFUjdSBQPbFjlKVIK6YMXJTCp
Sbh1IHV/mI+GqsswNaKVDy4l3CueSaUJDB7sw+y/5dbGqWmny+FP4QiR+l8uFofB
Yvyu/CilM0SxWpTYUc4Wm6QxXtWbztucSdRRKwKJC6JNnfGhBgZo1q63hjg+NbjZ
S6zhz6jc4CSzainEZqiOpJmxryqxUL4LvDfAcST6dmnCxn6Y7LAQd2M78e2reNsX
hnR+uNaPr4gPSHibsX6T+oVaXRQdxd05Ws+Fdyu1USIH1K8+cTl7TgEo4Zu92uwx
Z2P0OGLq8iWCosvKIQzk2YRq3+Y22UNO8MNMdrl/0NTomDCybNAL/i1PEwH5vCii
ylqCMVfk+jzbf91PZWue2ONx10x90NQ70C/I2k5KqkNd2XfnBcNM/BNsFX7SIXpG
fkZQHY72YQXC+hkVg4yoyNW9dVOiEQRhH6RTV3Jkjzjmc5NME9dpFn4aYKVG8Zay
qAuzz55bVSXcUVVRTUTSefaAsZB7MeUykIe7rSF4Y6wbdidUkbZEVzXHlf8SYXdO
EdRjzIddlZJYolbOBGY3uVWOEk4F1ts7EMmUBHsuhekl3wI3Zcc=
=BwV+
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org



Version migration problems

2020-06-18 Thread Niranjan Rao

Greetings,


I am trying to migrate from 7.0.73 to 9.0.36 and facing challenges.


Java version and operating system version remains same in both cases.


I have carefully reviewed the configurations and everything looks ok. 
Version 9 does not report any problems when starting the application 
either in catalina.out file or in the application log file.



Applications has bunch of JSP pages which sit under WEB-INF/jsp/pages 
directory and some of these pages include fragments from 
WEB-INF/jsp/fragments directory. In the older version V7 this works 
correctly, but in V9 I get error about include not not found. Page do 
get resolved correctly, but includes do not.



Given only change is tomcat version as it's same WAR file deployed on 
same operating system and same java version, I am thinking I am missing 
some basic change in tomcat JSP lookup for version 9.



Can anyone please point me what I can be doing wrong or what I need to 
do so that same WAR file works in both versions



Regards,

Niranjan


-
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org