Re: AjaxButton documentation error?
It will lie no more. I just fixed it in 1.4.x and trunk. Thanks Chris and Craig! On Mon, Jul 12, 2010 at 7:03 AM, Craig McIlwee craig.mcil...@openroadsconsulting.com wrote: Yeah, that's been wrong for a really long time, maybe always. Whenever I point coworkers to that class I tell them to ignore that comment. Just checked the code for AjaxButton, and there is no form.add(this) call anywhere. Craig - Original Message - From: Chris Colman [mailto:chr...@stepaheadsoftware.com] To: users@wicket.apache.org Sent: Thu, 08 Jul 2010 21:48:20 -0400 Subject: AjaxButton documentation error? The JavaDoc for AjaxButton (and AjaxSubmitButton) says: A button that submits the form via ajax. Since this button takes the form as a constructor argument it does not need to be added to it unlike the Button component. Well I've just spent a good amount of time putting that theory to the test. I use the constructor that takes the form as its second parameter. Basically the form fails with an error saying wicket can't find the button component unless I explicitly add the AjaxButton object to the form object, seemingly contradicting the above doco quote. The Wicket example explicitly adds the button to the form too - which also seems to go against the above doco declaration. Maybe it's a rare case where reading the documentation is not a good idea =} - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: AjaxButton documentation error?
Yeah, that's been wrong for a really long time, maybe always. Whenever I point coworkers to that class I tell them to ignore that comment. Just checked the code for AjaxButton, and there is no form.add(this) call anywhere. Craig - Original Message - From: Chris Colman [mailto:chr...@stepaheadsoftware.com] To: users@wicket.apache.org Sent: Thu, 08 Jul 2010 21:48:20 -0400 Subject: AjaxButton documentation error? The JavaDoc for AjaxButton (and AjaxSubmitButton) says: A button that submits the form via ajax. Since this button takes the form as a constructor argument it does not need to be added to it unlike the Button component. Well I've just spent a good amount of time putting that theory to the test. I use the constructor that takes the form as its second parameter. Basically the form fails with an error saying wicket can't find the button component unless I explicitly add the AjaxButton object to the form object, seemingly contradicting the above doco quote. The Wicket example explicitly adds the button to the form too - which also seems to go against the above doco declaration. Maybe it's a rare case where reading the documentation is not a good idea =} - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: AjaxButton documentation error?
sounds like a bug, file a jira. -igor On Thu, Jul 8, 2010 at 6:48 PM, Chris Colman chr...@stepaheadsoftware.com wrote: The JavaDoc for AjaxButton (and AjaxSubmitButton) says: A button that submits the form via ajax. Since this button takes the form as a constructor argument it does not need to be added to it unlike the Button component. Well I've just spent a good amount of time putting that theory to the test. I use the constructor that takes the form as its second parameter. Basically the form fails with an error saying wicket can't find the button component unless I explicitly add the AjaxButton object to the form object, seemingly contradicting the above doco quote. The Wicket example explicitly adds the button to the form too - which also seems to go against the above doco declaration. Maybe it's a rare case where reading the documentation is not a good idea =} - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
AjaxButton documentation error?
The JavaDoc for AjaxButton (and AjaxSubmitButton) says: A button that submits the form via ajax. Since this button takes the form as a constructor argument it does not need to be added to it unlike the Button component. Well I've just spent a good amount of time putting that theory to the test. I use the constructor that takes the form as its second parameter. Basically the form fails with an error saying wicket can't find the button component unless I explicitly add the AjaxButton object to the form object, seemingly contradicting the above doco quote. The Wicket example explicitly adds the button to the form too - which also seems to go against the above doco declaration. Maybe it's a rare case where reading the documentation is not a good idea =} - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
