Re: NPE in constructor of AbstractWebSocketProcessor
Forgot versions: Tomcat 8.5.9 Wicket 7.6.0 Chrome latest Ubuntu 16.10 latest On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik wrote: > Hello All, > > I'm observing weird behavior: > I'm displaying wicket page in iframe > For some unknown reason I'm getting NPE in [1] if page is being > reloaded both F5 and Shift+F5 > Every second time I got NPE > > The method is being called from [2], every second time > (HttpSession) userProperties.get("session") == NULL > > maybe you know what can be done here? > > [1] > https://github.com/apache/wicket/blob/wicket-7.x/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java#L104 > [2] > https://github.com/apache/wicket/blob/wicket-7.x/wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/JavaxUpgradeHttpRequest.java#L74 > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: NPE in constructor of AbstractWebSocketProcessor
Hi Maxim, I'll try to reproduce it. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik wrote: > Forgot versions: > > Tomcat 8.5.9 > Wicket 7.6.0 > Chrome latest > Ubuntu 16.10 latest > > > On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik > wrote: > > Hello All, > > > > I'm observing weird behavior: > > I'm displaying wicket page in iframe > > For some unknown reason I'm getting NPE in [1] if page is being > > reloaded both F5 and Shift+F5 > > Every second time I got NPE > > > > The method is being called from [2], every second time > > (HttpSession) userProperties.get("session") == NULL > > > > maybe you know what can be done here? > > > > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > native-websocket/wicket-native-websocket-core/src/ > main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor. > java#L104 > > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > native-websocket/wicket-native-websocket-javax/src/ > main/java/org/apache/wicket/protocol/ws/javax/ > JavaxUpgradeHttpRequest.java#L74 > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: NPE in constructor of AbstractWebSocketProcessor
Thanks a lot Martin, I can send the stacktrace if it will help ... Will try to find reproducible easy steps ... On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov wrote: > Hi Maxim, > > I'll try to reproduce it. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik > wrote: > >> Forgot versions: >> >> Tomcat 8.5.9 >> Wicket 7.6.0 >> Chrome latest >> Ubuntu 16.10 latest >> >> >> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik >> wrote: >> > Hello All, >> > >> > I'm observing weird behavior: >> > I'm displaying wicket page in iframe >> > For some unknown reason I'm getting NPE in [1] if page is being >> > reloaded both F5 and Shift+F5 >> > Every second time I got NPE >> > >> > The method is being called from [2], every second time >> > (HttpSession) userProperties.get("session") == NULL >> > >> > maybe you know what can be done here? >> > >> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >> native-websocket/wicket-native-websocket-core/src/ >> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor. >> java#L104 >> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >> native-websocket/wicket-native-websocket-javax/src/ >> main/java/org/apache/wicket/protocol/ws/javax/ >> JavaxUpgradeHttpRequest.java#L74 >> > >> > -- >> > WBR >> > Maxim aka solomax >> >> >> >> -- >> WBR >> Maxim aka solomax >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> -- WBR Maxim aka solomax - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: NPE in constructor of AbstractWebSocketProcessor
Also reproducible using FF on Ubuntu 16.10 ... Unfortunately it is not reproducible using simpler config :( I would appreciate any workaround due to issue is critical for our project On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik wrote: > Thanks a lot Martin, > > I can send the stacktrace if it will help ... > Will try to find reproducible easy steps ... > > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov wrote: >> Hi Maxim, >> >> I'll try to reproduce it. >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik >> wrote: >> >>> Forgot versions: >>> >>> Tomcat 8.5.9 >>> Wicket 7.6.0 >>> Chrome latest >>> Ubuntu 16.10 latest >>> >>> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik >>> wrote: >>> > Hello All, >>> > >>> > I'm observing weird behavior: >>> > I'm displaying wicket page in iframe >>> > For some unknown reason I'm getting NPE in [1] if page is being >>> > reloaded both F5 and Shift+F5 >>> > Every second time I got NPE >>> > >>> > The method is being called from [2], every second time >>> > (HttpSession) userProperties.get("session") == NULL >>> > >>> > maybe you know what can be done here? >>> > >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >>> native-websocket/wicket-native-websocket-core/src/ >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor. >>> java#L104 >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >>> native-websocket/wicket-native-websocket-javax/src/ >>> main/java/org/apache/wicket/protocol/ws/javax/ >>> JavaxUpgradeHttpRequest.java#L74 >>> > >>> > -- >>> > WBR >>> > Maxim aka solomax >>> >>> >>> >>> -- >>> WBR >>> Maxim aka solomax >>> >>> - >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >>> > > > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: NPE in constructor of AbstractWebSocketProcessor
On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik wrote: > Also reproducible using FF on Ubuntu 16.10 ... > Unfortunately it is not reproducible using simpler config :( > I would appreciate any workaround due to issue is critical for our project > When the user reloads the page the old WebSocket connection is closed and a new one is created. request.getSession(true) should never return null, because even if there is no HttpSession the parameter says that a new one should be created. Try with Tomcat 8.5.11. I'll try to reproduce it later today. > > On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik > wrote: > > Thanks a lot Martin, > > > > I can send the stacktrace if it will help ... > > Will try to find reproducible easy steps ... > > > > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov > wrote: > >> Hi Maxim, > >> > >> I'll try to reproduce it. > >> > >> Martin Grigorov > >> Wicket Training and Consulting > >> https://twitter.com/mtgrigorov > >> > >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik > > >> wrote: > >> > >>> Forgot versions: > >>> > >>> Tomcat 8.5.9 > >>> Wicket 7.6.0 > >>> Chrome latest > >>> Ubuntu 16.10 latest > >>> > >>> > >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > solomax...@gmail.com> > >>> wrote: > >>> > Hello All, > >>> > > >>> > I'm observing weird behavior: > >>> > I'm displaying wicket page in iframe > >>> > For some unknown reason I'm getting NPE in [1] if page is being > >>> > reloaded both F5 and Shift+F5 > >>> > Every second time I got NPE > >>> > > >>> > The method is being called from [2], every second time > >>> > (HttpSession) userProperties.get("session") == NULL > >>> > > >>> > maybe you know what can be done here? > >>> > > >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > >>> native-websocket/wicket-native-websocket-core/src/ > >>> main/java/org/apache/wicket/protocol/ws/api/ > AbstractWebSocketProcessor. > >>> java#L104 > >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > >>> native-websocket/wicket-native-websocket-javax/src/ > >>> main/java/org/apache/wicket/protocol/ws/javax/ > >>> JavaxUpgradeHttpRequest.java#L74 > >>> > > >>> > -- > >>> > WBR > >>> > Maxim aka solomax > >>> > >>> > >>> > >>> -- > >>> WBR > >>> Maxim aka solomax > >>> > >>> - > >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >>> For additional commands, e-mail: users-h...@wicket.apache.org > >>> > >>> > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
Re: NPE in constructor of AbstractWebSocketProcessor
Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty 9.4.0 and - works as expected. Please let me know if you find a way to reproduce it with the examples or a quickstart! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov wrote: > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik > wrote: > >> Also reproducible using FF on Ubuntu 16.10 ... >> Unfortunately it is not reproducible using simpler config :( >> I would appreciate any workaround due to issue is critical for our project >> > > When the user reloads the page the old WebSocket connection is closed and > a new one is created. > request.getSession(true) should never return null, because even if there > is no HttpSession the parameter says that a new one should be created. > Try with Tomcat 8.5.11. > I'll try to reproduce it later today. > > >> >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik >> wrote: >> > Thanks a lot Martin, >> > >> > I can send the stacktrace if it will help ... >> > Will try to find reproducible easy steps ... >> > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov >> wrote: >> >> Hi Maxim, >> >> >> >> I'll try to reproduce it. >> >> >> >> Martin Grigorov >> >> Wicket Training and Consulting >> >> https://twitter.com/mtgrigorov >> >> >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < >> solomax...@gmail.com> >> >> wrote: >> >> >> >>> Forgot versions: >> >>> >> >>> Tomcat 8.5.9 >> >>> Wicket 7.6.0 >> >>> Chrome latest >> >>> Ubuntu 16.10 latest >> >>> >> >>> >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < >> solomax...@gmail.com> >> >>> wrote: >> >>> > Hello All, >> >>> > >> >>> > I'm observing weird behavior: >> >>> > I'm displaying wicket page in iframe >> >>> > For some unknown reason I'm getting NPE in [1] if page is being >> >>> > reloaded both F5 and Shift+F5 >> >>> > Every second time I got NPE >> >>> > >> >>> > The method is being called from [2], every second time >> >>> > (HttpSession) userProperties.get("session") == NULL >> >>> > >> >>> > maybe you know what can be done here? >> >>> > >> >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >> >>> native-websocket/wicket-native-websocket-core/src/ >> >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocke >> tProcessor. >> >>> java#L104 >> >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- >> >>> native-websocket/wicket-native-websocket-javax/src/ >> >>> main/java/org/apache/wicket/protocol/ws/javax/ >> >>> JavaxUpgradeHttpRequest.java#L74 >> >>> > >> >>> > -- >> >>> > WBR >> >>> > Maxim aka solomax >> >>> >> >>> >> >>> >> >>> -- >> >>> WBR >> >>> Maxim aka solomax >> >>> >> >>> - >> >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> >>> For additional commands, e-mail: users-h...@wicket.apache.org >> >>> >> >>> >> > >> > >> > >> > -- >> > WBR >> > Maxim aka solomax >> >> >> >> -- >> WBR >> Maxim aka solomax >> >> - >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> >
Re: NPE in constructor of AbstractWebSocketProcessor
Hello Martin, I have updated our application to wicket-8 and NPE is not reproducible anymore Now I have even more weird situation: on every second page reload I'm not getting WebSocketBehavior::onConnect messages (Chrome error console empty) I suspect this might be caused by my code :( The logic I need to implement is: In case particular page is loaded, and special one-time hash is passed as page parameter, I need to drop existing session And set session Auth data using hash received. So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == true I call invalidateNow() and replaceSession() Maybe this need to be implemented somehow differently? Maybe I can put breakpoint somewhere to be able to debug this? On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov wrote: > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty 9.4.0 and > - works as expected. > Please let me know if you find a way to reproduce it with the examples or a > quickstart! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov > wrote: > > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik > > wrote: > > > >> Also reproducible using FF on Ubuntu 16.10 ... > >> Unfortunately it is not reproducible using simpler config :( > >> I would appreciate any workaround due to issue is critical for our > project > >> > > > > When the user reloads the page the old WebSocket connection is closed and > > a new one is created. > > request.getSession(true) should never return null, because even if there > > is no HttpSession the parameter says that a new one should be created. > > Try with Tomcat 8.5.11. > > I'll try to reproduce it later today. > > > > > >> > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik > > >> wrote: > >> > Thanks a lot Martin, > >> > > >> > I can send the stacktrace if it will help ... > >> > Will try to find reproducible easy steps ... > >> > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < > mgrigo...@apache.org> > >> wrote: > >> >> Hi Maxim, > >> >> > >> >> I'll try to reproduce it. > >> >> > >> >> Martin Grigorov > >> >> Wicket Training and Consulting > >> >> https://twitter.com/mtgrigorov > >> >> > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < > >> solomax...@gmail.com> > >> >> wrote: > >> >> > >> >>> Forgot versions: > >> >>> > >> >>> Tomcat 8.5.9 > >> >>> Wicket 7.6.0 > >> >>> Chrome latest > >> >>> Ubuntu 16.10 latest > >> >>> > >> >>> > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > >> solomax...@gmail.com> > >> >>> wrote: > >> >>> > Hello All, > >> >>> > > >> >>> > I'm observing weird behavior: > >> >>> > I'm displaying wicket page in iframe > >> >>> > For some unknown reason I'm getting NPE in [1] if page is being > >> >>> > reloaded both F5 and Shift+F5 > >> >>> > Every second time I got NPE > >> >>> > > >> >>> > The method is being called from [2], every second time > >> >>> > (HttpSession) userProperties.get("session") == NULL > >> >>> > > >> >>> > maybe you know what can be done here? > >> >>> > > >> >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > >> >>> native-websocket/wicket-native-websocket-core/src/ > >> >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocke > >> tProcessor. > >> >>> java#L104 > >> >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > >> >>> native-websocket/wicket-native-websocket-javax/src/ > >> >>> main/java/org/apache/wicket/protocol/ws/javax/ > >> >>> JavaxUpgradeHttpRequest.java#L74 > >> >>> > > >> >>> > -- > >> >>> > WBR > >> >>> > Maxim aka solomax > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> WBR > >> >>> Maxim aka solomax > >> >>> > >> >>> > - > >> >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >> >>> For additional commands, e-mail: users-h...@wicket.apache.org > >> >>> > >> >>> > >> > > >> > > >> > > >> > -- > >> > WBR > >> > Maxim aka solomax > >> > >> > >> > >> -- > >> WBR > >> Maxim aka solomax > >> > >> - > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >> For additional commands, e-mail: users-h...@wicket.apache.org > >> > >> > > > -- WBR Maxim aka solomax
Re: NPE in constructor of AbstractWebSocketProcessor
Hi Maxim, I've fixed a nasty bug related to session management few days ago. In case you use 8.0.0-M3 I'd suggest to try with 8.0.0-SNAPSHOT! On Feb 2, 2017 6:32 AM, "Maxim Solodovnik" wrote: > Hello Martin, > > I have updated our application to wicket-8 and NPE is not reproducible > anymore > Now I have even more weird situation: on every second page reload I'm not > getting WebSocketBehavior::onConnect messages (Chrome error console empty) > I suspect this might be caused by my code :( > > The logic I need to implement is: > In case particular page is loaded, and special one-time hash is passed as > page parameter, I need to drop existing session > And set session Auth data using hash received. > > So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == true > I call invalidateNow() and replaceSession() > > Maybe this need to be implemented somehow differently? > Maybe I can put breakpoint somewhere to be able to debug this? > > > On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov > wrote: > > > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty 9.4.0 > and > > - works as expected. > > Please let me know if you find a way to reproduce it with the examples > or a > > quickstart! > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov > > wrote: > > > > > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik < > solomax...@gmail.com> > > > wrote: > > > > > >> Also reproducible using FF on Ubuntu 16.10 ... > > >> Unfortunately it is not reproducible using simpler config :( > > >> I would appreciate any workaround due to issue is critical for our > > project > > >> > > > > > > When the user reloads the page the old WebSocket connection is closed > and > > > a new one is created. > > > request.getSession(true) should never return null, because even if > there > > > is no HttpSession the parameter says that a new one should be created. > > > Try with Tomcat 8.5.11. > > > I'll try to reproduce it later today. > > > > > > > > >> > > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik < > solomax...@gmail.com > > > > > >> wrote: > > >> > Thanks a lot Martin, > > >> > > > >> > I can send the stacktrace if it will help ... > > >> > Will try to find reproducible easy steps ... > > >> > > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < > > mgrigo...@apache.org> > > >> wrote: > > >> >> Hi Maxim, > > >> >> > > >> >> I'll try to reproduce it. > > >> >> > > >> >> Martin Grigorov > > >> >> Wicket Training and Consulting > > >> >> https://twitter.com/mtgrigorov > > >> >> > > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < > > >> solomax...@gmail.com> > > >> >> wrote: > > >> >> > > >> >>> Forgot versions: > > >> >>> > > >> >>> Tomcat 8.5.9 > > >> >>> Wicket 7.6.0 > > >> >>> Chrome latest > > >> >>> Ubuntu 16.10 latest > > >> >>> > > >> >>> > > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > > >> solomax...@gmail.com> > > >> >>> wrote: > > >> >>> > Hello All, > > >> >>> > > > >> >>> > I'm observing weird behavior: > > >> >>> > I'm displaying wicket page in iframe > > >> >>> > For some unknown reason I'm getting NPE in [1] if page is being > > >> >>> > reloaded both F5 and Shift+F5 > > >> >>> > Every second time I got NPE > > >> >>> > > > >> >>> > The method is being called from [2], every second time > > >> >>> > (HttpSession) userProperties.get("session") == NULL > > >> >>> > > > >> >>> > maybe you know what can be done here? > > >> >>> > > > >> >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > > >> >>> native-websocket/wicket-native-websocket-core/src/ > > >> >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocke > > >> tProcessor. > > >> >>> java#L104 > > >> >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > > >> >>> native-websocket/wicket-native-websocket-javax/src/ > > >> >>> main/java/org/apache/wicket/protocol/ws/javax/ > > >> >>> JavaxUpgradeHttpRequest.java#L74 > > >> >>> > > > >> >>> > -- > > >> >>> > WBR > > >> >>> > Maxim aka solomax > > >> >>> > > >> >>> > > >> >>> > > >> >>> -- > > >> >>> WBR > > >> >>> Maxim aka solomax > > >> >>> > > >> >>> > > - > > >> >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > >> >>> For additional commands, e-mail: users-h...@wicket.apache.org > > >> >>> > > >> >>> > > >> > > > >> > > > >> > > > >> > -- > > >> > WBR > > >> > Maxim aka solomax > > >> > > >> > > >> > > >> -- > > >> WBR > > >> Maxim aka solomax > > >> > > >> - > > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > >> For additional commands, e-mail: users-h...@wicket.apache.org > > >> > > >> > > > > > > > > > -- > WBR > Maxim aka solomax >
Re: NPE in constructor of AbstractWebSocketProcessor
Hello Martin, This version seems to work as expected :))) Now the question is: How can I get M4 (or M3.1) : On Thu, Feb 2, 2017 at 11:41 AM, Martin Grigorov wrote: > Hi Maxim, > > I've fixed a nasty bug related to session management few days ago. > In case you use 8.0.0-M3 I'd suggest to try with 8.0.0-SNAPSHOT! > > On Feb 2, 2017 6:32 AM, "Maxim Solodovnik" wrote: > > > Hello Martin, > > > > I have updated our application to wicket-8 and NPE is not reproducible > > anymore > > Now I have even more weird situation: on every second page reload I'm not > > getting WebSocketBehavior::onConnect messages (Chrome error console > empty) > > I suspect this might be caused by my code :( > > > > The logic I need to implement is: > > In case particular page is loaded, and special one-time hash is passed as > > page parameter, I need to drop existing session > > And set session Auth data using hash received. > > > > So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == true > > I call invalidateNow() and replaceSession() > > > > Maybe this need to be implemented somehow differently? > > Maybe I can put breakpoint somewhere to be able to debug this? > > > > > > On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov > > wrote: > > > > > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty 9.4.0 > > and > > > - works as expected. > > > Please let me know if you find a way to reproduce it with the examples > > or a > > > quickstart! > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov > > > > wrote: > > > > > > > > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik < > > solomax...@gmail.com> > > > > wrote: > > > > > > > >> Also reproducible using FF on Ubuntu 16.10 ... > > > >> Unfortunately it is not reproducible using simpler config :( > > > >> I would appreciate any workaround due to issue is critical for our > > > project > > > >> > > > > > > > > When the user reloads the page the old WebSocket connection is closed > > and > > > > a new one is created. > > > > request.getSession(true) should never return null, because even if > > there > > > > is no HttpSession the parameter says that a new one should be > created. > > > > Try with Tomcat 8.5.11. > > > > I'll try to reproduce it later today. > > > > > > > > > > > >> > > > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik < > > solomax...@gmail.com > > > > > > > >> wrote: > > > >> > Thanks a lot Martin, > > > >> > > > > >> > I can send the stacktrace if it will help ... > > > >> > Will try to find reproducible easy steps ... > > > >> > > > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < > > > mgrigo...@apache.org> > > > >> wrote: > > > >> >> Hi Maxim, > > > >> >> > > > >> >> I'll try to reproduce it. > > > >> >> > > > >> >> Martin Grigorov > > > >> >> Wicket Training and Consulting > > > >> >> https://twitter.com/mtgrigorov > > > >> >> > > > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < > > > >> solomax...@gmail.com> > > > >> >> wrote: > > > >> >> > > > >> >>> Forgot versions: > > > >> >>> > > > >> >>> Tomcat 8.5.9 > > > >> >>> Wicket 7.6.0 > > > >> >>> Chrome latest > > > >> >>> Ubuntu 16.10 latest > > > >> >>> > > > >> >>> > > > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > > > >> solomax...@gmail.com> > > > >> >>> wrote: > > > >> >>> > Hello All, > > > >> >>> > > > > >> >>> > I'm observing weird behavior: > > > >> >>> > I'm displaying wicket page in iframe > > > >> >>> > For some unknown reason I'm getting NPE in [1] if page is > being > > > >> >>> > reloaded both F5 and Shift+F5 > > > >> >>> > Every second time I got NPE > > > >> >>> > > > > >> >>> > The method is being called from [2], every second time > > > >> >>> > (HttpSession) userProperties.get("session") == NULL > > > >> >>> > > > > >> >>> > maybe you know what can be done here? > > > >> >>> > > > > >> >>> > [1] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > > > >> >>> native-websocket/wicket-native-websocket-core/src/ > > > >> >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocke > > > >> tProcessor. > > > >> >>> java#L104 > > > >> >>> > [2] https://github.com/apache/wicket/blob/wicket-7.x/wicket- > > > >> >>> native-websocket/wicket-native-websocket-javax/src/ > > > >> >>> main/java/org/apache/wicket/protocol/ws/javax/ > > > >> >>> JavaxUpgradeHttpRequest.java#L74 > > > >> >>> > > > > >> >>> > -- > > > >> >>> > WBR > > > >> >>> > Maxim aka solomax > > > >> >>> > > > >> >>> > > > >> >>> > > > >> >>> -- > > > >> >>> WBR > > > >> >>> Maxim aka solomax > > > >> >>> > > > >> >>> > > > - > > > >> >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > >> >>> For additional commands, e-mail: users-h...@wicket.apache.org > > > >> >>> > > > >> >>> > > > >> > > > > >> > > > > >> > > > > >> > -- > > > >> > WBR > > > >> > Maxi
Re: NPE in constructor of AbstractWebSocketProcessor
On Thu, Feb 2, 2017 at 7:21 AM, Maxim Solodovnik wrote: > Hello Martin, > > This version seems to work as expected :))) > Now the question is: How can I get M4 (or M3.1) : > +1 for a new release from me! > > > On Thu, Feb 2, 2017 at 11:41 AM, Martin Grigorov > wrote: > > > Hi Maxim, > > > > I've fixed a nasty bug related to session management few days ago. > > In case you use 8.0.0-M3 I'd suggest to try with 8.0.0-SNAPSHOT! > > > > On Feb 2, 2017 6:32 AM, "Maxim Solodovnik" wrote: > > > > > Hello Martin, > > > > > > I have updated our application to wicket-8 and NPE is not reproducible > > > anymore > > > Now I have even more weird situation: on every second page reload I'm > not > > > getting WebSocketBehavior::onConnect messages (Chrome error console > > empty) > > > I suspect this might be caused by my code :( > > > > > > The logic I need to implement is: > > > In case particular page is loaded, and special one-time hash is passed > as > > > page parameter, I need to drop existing session > > > And set session Auth data using hash received. > > > > > > So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == > true > > > I call invalidateNow() and replaceSession() > > > > > > Maybe this need to be implemented somehow differently? > > > Maybe I can put breakpoint somewhere to be able to debug this? > > > > > > > > > On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov > > > wrote: > > > > > > > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty > 9.4.0 > > > and > > > > - works as expected. > > > > Please let me know if you find a way to reproduce it with the > examples > > > or a > > > > quickstart! > > > > > > > > Martin Grigorov > > > > Wicket Training and Consulting > > > > https://twitter.com/mtgrigorov > > > > > > > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov < > mgrigo...@apache.org > > > > > > > wrote: > > > > > > > > > > > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik < > > > solomax...@gmail.com> > > > > > wrote: > > > > > > > > > >> Also reproducible using FF on Ubuntu 16.10 ... > > > > >> Unfortunately it is not reproducible using simpler config :( > > > > >> I would appreciate any workaround due to issue is critical for our > > > > project > > > > >> > > > > > > > > > > When the user reloads the page the old WebSocket connection is > closed > > > and > > > > > a new one is created. > > > > > request.getSession(true) should never return null, because even if > > > there > > > > > is no HttpSession the parameter says that a new one should be > > created. > > > > > Try with Tomcat 8.5.11. > > > > > I'll try to reproduce it later today. > > > > > > > > > > > > > > >> > > > > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik < > > > solomax...@gmail.com > > > > > > > > > >> wrote: > > > > >> > Thanks a lot Martin, > > > > >> > > > > > >> > I can send the stacktrace if it will help ... > > > > >> > Will try to find reproducible easy steps ... > > > > >> > > > > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < > > > > mgrigo...@apache.org> > > > > >> wrote: > > > > >> >> Hi Maxim, > > > > >> >> > > > > >> >> I'll try to reproduce it. > > > > >> >> > > > > >> >> Martin Grigorov > > > > >> >> Wicket Training and Consulting > > > > >> >> https://twitter.com/mtgrigorov > > > > >> >> > > > > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < > > > > >> solomax...@gmail.com> > > > > >> >> wrote: > > > > >> >> > > > > >> >>> Forgot versions: > > > > >> >>> > > > > >> >>> Tomcat 8.5.9 > > > > >> >>> Wicket 7.6.0 > > > > >> >>> Chrome latest > > > > >> >>> Ubuntu 16.10 latest > > > > >> >>> > > > > >> >>> > > > > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > > > > >> solomax...@gmail.com> > > > > >> >>> wrote: > > > > >> >>> > Hello All, > > > > >> >>> > > > > > >> >>> > I'm observing weird behavior: > > > > >> >>> > I'm displaying wicket page in iframe > > > > >> >>> > For some unknown reason I'm getting NPE in [1] if page is > > being > > > > >> >>> > reloaded both F5 and Shift+F5 > > > > >> >>> > Every second time I got NPE > > > > >> >>> > > > > > >> >>> > The method is being called from [2], every second time > > > > >> >>> > (HttpSession) userProperties.get("session") == NULL > > > > >> >>> > > > > > >> >>> > maybe you know what can be done here? > > > > >> >>> > > > > > >> >>> > [1] https://github.com/apache/ > wicket/blob/wicket-7.x/wicket- > > > > >> >>> native-websocket/wicket-native-websocket-core/src/ > > > > >> >>> main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocke > > > > >> tProcessor. > > > > >> >>> java#L104 > > > > >> >>> > [2] https://github.com/apache/ > wicket/blob/wicket-7.x/wicket- > > > > >> >>> native-websocket/wicket-native-websocket-javax/src/ > > > > >> >>> main/java/org/apache/wicket/protocol/ws/javax/ > > > > >> >>> JavaxUpgradeHttpRequest.java#L74 > > > > >> >>> > > > > > >> >>> > -- > > > > >> >>> > WBR > > > > >> >>> > Maxim aka solomax > > > > >> >>> > > > > >> >>> > > > > >> >>>
Re: NPE in constructor of AbstractWebSocketProcessor
The only workaround I see is to reset org.apache.wicket.Session#sessionInvalidated to false in overridden #invalidateNow() via reflection :-/ The related issue is WICKET-6310. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Feb 2, 2017 at 7:58 AM, Martin Grigorov wrote: > > On Thu, Feb 2, 2017 at 7:21 AM, Maxim Solodovnik > wrote: > >> Hello Martin, >> >> This version seems to work as expected :))) >> Now the question is: How can I get M4 (or M3.1) : >> > > +1 for a new release from me! > > >> >> >> On Thu, Feb 2, 2017 at 11:41 AM, Martin Grigorov >> wrote: >> >> > Hi Maxim, >> > >> > I've fixed a nasty bug related to session management few days ago. >> > In case you use 8.0.0-M3 I'd suggest to try with 8.0.0-SNAPSHOT! >> > >> > On Feb 2, 2017 6:32 AM, "Maxim Solodovnik" >> wrote: >> > >> > > Hello Martin, >> > > >> > > I have updated our application to wicket-8 and NPE is not reproducible >> > > anymore >> > > Now I have even more weird situation: on every second page reload I'm >> not >> > > getting WebSocketBehavior::onConnect messages (Chrome error console >> > empty) >> > > I suspect this might be caused by my code :( >> > > >> > > The logic I need to implement is: >> > > In case particular page is loaded, and special one-time hash is >> passed as >> > > page parameter, I need to drop existing session >> > > And set session Auth data using hash received. >> > > >> > > So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == >> true >> > > I call invalidateNow() and replaceSession() >> > > >> > > Maybe this need to be implemented somehow differently? >> > > Maybe I can put breakpoint somewhere to be able to debug this? >> > > >> > > >> > > On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov > > >> > > wrote: >> > > >> > > > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty >> 9.4.0 >> > > and >> > > > - works as expected. >> > > > Please let me know if you find a way to reproduce it with the >> examples >> > > or a >> > > > quickstart! >> > > > >> > > > Martin Grigorov >> > > > Wicket Training and Consulting >> > > > https://twitter.com/mtgrigorov >> > > > >> > > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov < >> mgrigo...@apache.org >> > > >> > > > wrote: >> > > > >> > > > > >> > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik < >> > > solomax...@gmail.com> >> > > > > wrote: >> > > > > >> > > > >> Also reproducible using FF on Ubuntu 16.10 ... >> > > > >> Unfortunately it is not reproducible using simpler config :( >> > > > >> I would appreciate any workaround due to issue is critical for >> our >> > > > project >> > > > >> >> > > > > >> > > > > When the user reloads the page the old WebSocket connection is >> closed >> > > and >> > > > > a new one is created. >> > > > > request.getSession(true) should never return null, because even if >> > > there >> > > > > is no HttpSession the parameter says that a new one should be >> > created. >> > > > > Try with Tomcat 8.5.11. >> > > > > I'll try to reproduce it later today. >> > > > > >> > > > > >> > > > >> >> > > > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik < >> > > solomax...@gmail.com >> > > > > >> > > > >> wrote: >> > > > >> > Thanks a lot Martin, >> > > > >> > >> > > > >> > I can send the stacktrace if it will help ... >> > > > >> > Will try to find reproducible easy steps ... >> > > > >> > >> > > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < >> > > > mgrigo...@apache.org> >> > > > >> wrote: >> > > > >> >> Hi Maxim, >> > > > >> >> >> > > > >> >> I'll try to reproduce it. >> > > > >> >> >> > > > >> >> Martin Grigorov >> > > > >> >> Wicket Training and Consulting >> > > > >> >> https://twitter.com/mtgrigorov >> > > > >> >> >> > > > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < >> > > > >> solomax...@gmail.com> >> > > > >> >> wrote: >> > > > >> >> >> > > > >> >>> Forgot versions: >> > > > >> >>> >> > > > >> >>> Tomcat 8.5.9 >> > > > >> >>> Wicket 7.6.0 >> > > > >> >>> Chrome latest >> > > > >> >>> Ubuntu 16.10 latest >> > > > >> >>> >> > > > >> >>> >> > > > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < >> > > > >> solomax...@gmail.com> >> > > > >> >>> wrote: >> > > > >> >>> > Hello All, >> > > > >> >>> > >> > > > >> >>> > I'm observing weird behavior: >> > > > >> >>> > I'm displaying wicket page in iframe >> > > > >> >>> > For some unknown reason I'm getting NPE in [1] if page is >> > being >> > > > >> >>> > reloaded both F5 and Shift+F5 >> > > > >> >>> > Every second time I got NPE >> > > > >> >>> > >> > > > >> >>> > The method is being called from [2], every second time >> > > > >> >>> > (HttpSession) userProperties.get("session") == NULL >> > > > >> >>> > >> > > > >> >>> > maybe you know what can be done here? >> > > > >> >>> > >> > > > >> >>> > [1] https://github.com/apache/wick >> et/blob/wicket-7.x/wicket- >> > > > >> >>> native-websocket/wicket-native-websocket-core/src/ >> > > > >> >>> main/java/org/apache/wicket/pro
Re: NPE in constructor of AbstractWebSocketProcessor
If M4 can be scheduled in reasonable time-frame I would wait ... In case you can start the VOTE this week for ex. :)) You already have +1 from me :) I have tested potentual M4 using aour main application :) On Thu, Feb 2, 2017 at 2:19 PM, Martin Grigorov wrote: > The only workaround I see is to > reset org.apache.wicket.Session#sessionInvalidated to false in overridden > #invalidateNow() via reflection :-/ > The related issue is WICKET-6310. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Thu, Feb 2, 2017 at 7:58 AM, Martin Grigorov > wrote: > > > > > On Thu, Feb 2, 2017 at 7:21 AM, Maxim Solodovnik > > wrote: > > > >> Hello Martin, > >> > >> This version seems to work as expected :))) > >> Now the question is: How can I get M4 (or M3.1) : > >> > > > > +1 for a new release from me! > > > > > >> > >> > >> On Thu, Feb 2, 2017 at 11:41 AM, Martin Grigorov > >> wrote: > >> > >> > Hi Maxim, > >> > > >> > I've fixed a nasty bug related to session management few days ago. > >> > In case you use 8.0.0-M3 I'd suggest to try with 8.0.0-SNAPSHOT! > >> > > >> > On Feb 2, 2017 6:32 AM, "Maxim Solodovnik" > >> wrote: > >> > > >> > > Hello Martin, > >> > > > >> > > I have updated our application to wicket-8 and NPE is not > reproducible > >> > > anymore > >> > > Now I have even more weird situation: on every second page reload > I'm > >> not > >> > > getting WebSocketBehavior::onConnect messages (Chrome error console > >> > empty) > >> > > I suspect this might be caused by my code :( > >> > > > >> > > The logic I need to implement is: > >> > > In case particular page is loaded, and special one-time hash is > >> passed as > >> > > page parameter, I need to drop existing session > >> > > And set session Auth data using hash received. > >> > > > >> > > So I'm checking if AbstractAuthenticatedWebSession::isSignedIn() == > >> true > >> > > I call invalidateNow() and replaceSession() > >> > > > >> > > Maybe this need to be implemented somehow differently? > >> > > Maybe I can put breakpoint somewhere to be able to debug this? > >> > > > >> > > > >> > > On Wed, Feb 1, 2017 at 2:56 AM, Martin Grigorov < > mgrigo...@apache.org > >> > > >> > > wrote: > >> > > > >> > > > Just tried it with Wicket 8.x Examples on Tomcat 8.5.11 and Jetty > >> 9.4.0 > >> > > and > >> > > > - works as expected. > >> > > > Please let me know if you find a way to reproduce it with the > >> examples > >> > > or a > >> > > > quickstart! > >> > > > > >> > > > Martin Grigorov > >> > > > Wicket Training and Consulting > >> > > > https://twitter.com/mtgrigorov > >> > > > > >> > > > On Tue, Jan 31, 2017 at 4:14 PM, Martin Grigorov < > >> mgrigo...@apache.org > >> > > > >> > > > wrote: > >> > > > > >> > > > > > >> > > > > On Tue, Jan 31, 2017 at 4:10 PM, Maxim Solodovnik < > >> > > solomax...@gmail.com> > >> > > > > wrote: > >> > > > > > >> > > > >> Also reproducible using FF on Ubuntu 16.10 ... > >> > > > >> Unfortunately it is not reproducible using simpler config :( > >> > > > >> I would appreciate any workaround due to issue is critical for > >> our > >> > > > project > >> > > > >> > >> > > > > > >> > > > > When the user reloads the page the old WebSocket connection is > >> closed > >> > > and > >> > > > > a new one is created. > >> > > > > request.getSession(true) should never return null, because even > if > >> > > there > >> > > > > is no HttpSession the parameter says that a new one should be > >> > created. > >> > > > > Try with Tomcat 8.5.11. > >> > > > > I'll try to reproduce it later today. > >> > > > > > >> > > > > > >> > > > >> > >> > > > >> On Tue, Jan 31, 2017 at 3:09 PM, Maxim Solodovnik < > >> > > solomax...@gmail.com > >> > > > > > >> > > > >> wrote: > >> > > > >> > Thanks a lot Martin, > >> > > > >> > > >> > > > >> > I can send the stacktrace if it will help ... > >> > > > >> > Will try to find reproducible easy steps ... > >> > > > >> > > >> > > > >> > On Tue, Jan 31, 2017 at 2:52 PM, Martin Grigorov < > >> > > > mgrigo...@apache.org> > >> > > > >> wrote: > >> > > > >> >> Hi Maxim, > >> > > > >> >> > >> > > > >> >> I'll try to reproduce it. > >> > > > >> >> > >> > > > >> >> Martin Grigorov > >> > > > >> >> Wicket Training and Consulting > >> > > > >> >> https://twitter.com/mtgrigorov > >> > > > >> >> > >> > > > >> >> On Mon, Jan 30, 2017 at 6:16 PM, Maxim Solodovnik < > >> > > > >> solomax...@gmail.com> > >> > > > >> >> wrote: > >> > > > >> >> > >> > > > >> >>> Forgot versions: > >> > > > >> >>> > >> > > > >> >>> Tomcat 8.5.9 > >> > > > >> >>> Wicket 7.6.0 > >> > > > >> >>> Chrome latest > >> > > > >> >>> Ubuntu 16.10 latest > >> > > > >> >>> > >> > > > >> >>> > >> > > > >> >>> On Tue, Jan 31, 2017 at 12:06 AM, Maxim Solodovnik < > >> > > > >> solomax...@gmail.com> > >> > > > >> >>> wrote: > >> > > > >> >>> > Hello All, > >> > > > >> >>> > > >> > > > >> >>> > I'm observing weird behavior: > >> > > > >> >>> > I'm displaying wicket page in iframe > >> > > > >> >>> > For some unknown reas