Re: Wicket 7 for production use?

2015-02-01 Thread Martin Grigorov
Right.
Keeping the method in 7.x doesn't help because it won't help. The developer
would be confused that the method is still used.

Deprecating in 6.x is not an option because #isEnabledInHierarchy() is
still final there and there is no substitution.

The migration guide properly says what is the replacement.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 1, 2015 at 7:48 PM, Sven Meier  wrote:

> Hi,
>
> I don't have any objections, but I don't see much sense in restoring the
> broken 6.x behavior.
>
> Yes, keeping a deprecated method is nice - it's not necessary for a major
> release though.
> We could deprecate #isLinkEnabled() in the next 6.x version (given it is
> released before 7.0).
>
> My 2 cents
> Sven
>
>
>
>
> On 01.02.2015 13:05, Martin Grigorov wrote:
>
>> I agree that AbstractLink#isLinkEnabled() should be marked as deprecated
>> in
>> 7.x.
>> Its substitution is #isEnabledInHierarchy(), not #isEnabled().
>> Having this described in the javadoc will help users to use the correct
>> replacement. And the migration will be even smoother!
>>
>> @Sven: any objections ?
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Sun, Feb 1, 2015 at 2:02 PM, Martin Grigorov 
>> wrote:
>>
>>  Hi Don,
>>>
>>> Are you sure that you upgraded to 7.0.0-M4 ?
>>> The change in Image#setImageResponseReference() is not even in the voted
>>> M5. It has been applied to master branch few days ago, after M5 has been
>>> cut for voting.
>>> I didn't notice that the old signature of the method disappeared. I'll
>>> revert it back.
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>>
>>> On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson 
>>> wrote:
>>>
>>>  Here is what I encountered migrating a moderately large wicket/bootstrap
 app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
 tweaks, and of those, 5 were already covered in the migration guide.
 Overall, it was pretty smooth process.


 https://docs.google.com/document/d/1GI8vU_wHLxQ-
 ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
 <
 https://docs.google.com/document/d/1GI8vU_wHLxQ-
 ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
 -Don

  On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
>
 wrote:

> Hi,
>
> There are rumors that 7.0.0 will be released this month.
>
> I'd recommend to migrate the app as soon as possible and report any
> problems you hit.
> If there is a need of an API change then we will need to release one
>
 more

> milestone. Otherwise the next release will be 7.0.0 and any API changes
> will have to wait for 8.0.0.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
>
>  Hi all,
>>
>> Is there any estimate when wicket 7 will be ready for production use?
>>
>> We would really like to migrate our applications to it, and help with
>> testing, but we are worried that we may encounter bugs in things that
>>
> work

> in wicket 6 (such as wicket-5800 that I recently reported). Since
>>
> there is

> no indication on the wicket site about when version 7 will be released
>>
> we

> are worried that our project will be delayed waiting for wicket
>> bug-fixes/releases.
>>
>> Marios
>>
>>

>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>


Re: Wicket 7 for production use?

2015-02-01 Thread Sven Meier

Hi,

I don't have any objections, but I don't see much sense in restoring the 
broken 6.x behavior.


Yes, keeping a deprecated method is nice - it's not necessary for a 
major release though.
We could deprecate #isLinkEnabled() in the next 6.x version (given it is 
released before 7.0).


My 2 cents
Sven



On 01.02.2015 13:05, Martin Grigorov wrote:

I agree that AbstractLink#isLinkEnabled() should be marked as deprecated in
7.x.
Its substitution is #isEnabledInHierarchy(), not #isEnabled().
Having this described in the javadoc will help users to use the correct
replacement. And the migration will be even smoother!

@Sven: any objections ?

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 1, 2015 at 2:02 PM, Martin Grigorov 
wrote:


Hi Don,

Are you sure that you upgraded to 7.0.0-M4 ?
The change in Image#setImageResponseReference() is not even in the voted
M5. It has been applied to master branch few days ago, after M5 has been
cut for voting.
I didn't notice that the old signature of the method disappeared. I'll
revert it back.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson 
wrote:


Here is what I encountered migrating a moderately large wicket/bootstrap
app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
tweaks, and of those, 5 were already covered in the migration guide.
Overall, it was pretty smooth process.


https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
<
https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
-Don


On Jan 9, 2015, at 4:41 AM, Martin Grigorov 

wrote:

Hi,

There are rumors that 7.0.0 will be released this month.

I'd recommend to migrate the app as soon as possible and report any
problems you hit.
If there is a need of an API change then we will need to release one

more

milestone. Otherwise the next release will be 7.0.0 and any API changes
will have to wait for 8.0.0.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:


Hi all,

Is there any estimate when wicket 7 will be ready for production use?

We would really like to migrate our applications to it, and help with
testing, but we are worried that we may encounter bugs in things that

work

in wicket 6 (such as wicket-5800 that I recently reported). Since

there is

no indication on the wicket site about when version 7 will be released

we

are worried that our project will be delayed waiting for wicket
bug-fixes/releases.

Marios






-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Wicket 7 for production use?

2015-02-01 Thread Tobias Soloschenko
Ok the commit shows what you are talking about. Thanks for fixing the 
signature! 

kind regards

Tobias

> Am 01.02.2015 um 13:02 schrieb Martin Grigorov :
> 
> Hi Don,
> 
> Are you sure that you upgraded to 7.0.0-M4 ?
> The change in Image#setImageResponseReference() is not even in the voted
> M5. It has been applied to master branch few days ago, after M5 has been
> cut for voting.
> I didn't notice that the old signature of the method disappeared. I'll
> revert it back.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
>> On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson  wrote:
>> 
>> Here is what I encountered migrating a moderately large wicket/bootstrap
>> app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
>> tweaks, and of those, 5 were already covered in the migration guide.
>> Overall, it was pretty smooth process.
>> 
>> 
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> <
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> 
>> -Don
>> 
 On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> There are rumors that 7.0.0 will be released this month.
>>> 
>>> I'd recommend to migrate the app as soon as possible and report any
>>> problems you hit.
>>> If there is a need of an API change then we will need to release one more
>>> milestone. Otherwise the next release will be 7.0.0 and any API changes
>>> will have to wait for 8.0.0.
>>> 
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>> 
 On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
 
 Hi all,
 
 Is there any estimate when wicket 7 will be ready for production use?
 
 We would really like to migrate our applications to it, and help with
 testing, but we are worried that we may encounter bugs in things that
>> work
 in wicket 6 (such as wicket-5800 that I recently reported). Since there
>> is
 no indication on the wicket site about when version 7 will be released
>> we
 are worried that our project will be delayed waiting for wicket
 bug-fixes/releases.
 
 Marios
>> 
>> 

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Wicket 7 for production use?

2015-02-01 Thread Tobias Soloschenko
Hi Martin,

what do you mean by disappeard there are two signatures in Image

Image#setImageResourceReference() which is the old signature and
Image#setResourceReferences() which os used for srcset - the diff view is 
confusing - take a look at the RAW version.

kind regards

Tobias

> Am 01.02.2015 um 13:02 schrieb Martin Grigorov :
> 
> Hi Don,
> 
> Are you sure that you upgraded to 7.0.0-M4 ?
> The change in Image#setImageResponseReference() is not even in the voted
> M5. It has been applied to master branch few days ago, after M5 has been
> cut for voting.
> I didn't notice that the old signature of the method disappeared. I'll
> revert it back.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
>> On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson  wrote:
>> 
>> Here is what I encountered migrating a moderately large wicket/bootstrap
>> app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
>> tweaks, and of those, 5 were already covered in the migration guide.
>> Overall, it was pretty smooth process.
>> 
>> 
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> <
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> 
>> -Don
>> 
 On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> There are rumors that 7.0.0 will be released this month.
>>> 
>>> I'd recommend to migrate the app as soon as possible and report any
>>> problems you hit.
>>> If there is a need of an API change then we will need to release one more
>>> milestone. Otherwise the next release will be 7.0.0 and any API changes
>>> will have to wait for 8.0.0.
>>> 
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>> 
 On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
 
 Hi all,
 
 Is there any estimate when wicket 7 will be ready for production use?
 
 We would really like to migrate our applications to it, and help with
 testing, but we are worried that we may encounter bugs in things that
>> work
 in wicket 6 (such as wicket-5800 that I recently reported). Since there
>> is
 no indication on the wicket site about when version 7 will be released
>> we
 are worried that our project will be delayed waiting for wicket
 bug-fixes/releases.
 
 Marios
>> 
>> 

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Wicket 7 for production use?

2015-02-01 Thread Martin Grigorov
I agree that AbstractLink#isLinkEnabled() should be marked as deprecated in
7.x.
Its substitution is #isEnabledInHierarchy(), not #isEnabled().
Having this described in the javadoc will help users to use the correct
replacement. And the migration will be even smoother!

@Sven: any objections ?

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 1, 2015 at 2:02 PM, Martin Grigorov 
wrote:

> Hi Don,
>
> Are you sure that you upgraded to 7.0.0-M4 ?
> The change in Image#setImageResponseReference() is not even in the voted
> M5. It has been applied to master branch few days ago, after M5 has been
> cut for voting.
> I didn't notice that the old signature of the method disappeared. I'll
> revert it back.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson 
> wrote:
>
>> Here is what I encountered migrating a moderately large wicket/bootstrap
>> app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
>> tweaks, and of those, 5 were already covered in the migration guide.
>> Overall, it was pretty smooth process.
>>
>>
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> <
>> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
>> >
>>
>> -Don
>>
>> > On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
>> wrote:
>> >
>> > Hi,
>> >
>> > There are rumors that 7.0.0 will be released this month.
>> >
>> > I'd recommend to migrate the app as soon as possible and report any
>> > problems you hit.
>> > If there is a need of an API change then we will need to release one
>> more
>> > milestone. Otherwise the next release will be 7.0.0 and any API changes
>> > will have to wait for 8.0.0.
>> >
>> > Martin Grigorov
>> > Wicket Training and Consulting
>> > https://twitter.com/mtgrigorov
>> >
>> > On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
>> >
>> >> Hi all,
>> >>
>> >> Is there any estimate when wicket 7 will be ready for production use?
>> >>
>> >> We would really like to migrate our applications to it, and help with
>> >> testing, but we are worried that we may encounter bugs in things that
>> work
>> >> in wicket 6 (such as wicket-5800 that I recently reported). Since
>> there is
>> >> no indication on the wicket site about when version 7 will be released
>> we
>> >> are worried that our project will be delayed waiting for wicket
>> >> bug-fixes/releases.
>> >>
>> >> Marios
>> >>
>>
>>
>


Re: Wicket 7 for production use?

2015-02-01 Thread Martin Grigorov
Hi Don,

Are you sure that you upgraded to 7.0.0-M4 ?
The change in Image#setImageResponseReference() is not even in the voted
M5. It has been applied to master branch few days ago, after M5 has been
cut for voting.
I didn't notice that the old signature of the method disappeared. I'll
revert it back.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Feb 1, 2015 at 1:44 AM, Don Ferguson  wrote:

> Here is what I encountered migrating a moderately large wicket/bootstrap
> app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
> tweaks, and of those, 5 were already covered in the migration guide.
> Overall, it was pretty smooth process.
>
>
> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
> <
> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
> >
>
> -Don
>
> > On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
> wrote:
> >
> > Hi,
> >
> > There are rumors that 7.0.0 will be released this month.
> >
> > I'd recommend to migrate the app as soon as possible and report any
> > problems you hit.
> > If there is a need of an API change then we will need to release one more
> > milestone. Otherwise the next release will be 7.0.0 and any API changes
> > will have to wait for 8.0.0.
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
> >
> >> Hi all,
> >>
> >> Is there any estimate when wicket 7 will be ready for production use?
> >>
> >> We would really like to migrate our applications to it, and help with
> >> testing, but we are worried that we may encounter bugs in things that
> work
> >> in wicket 6 (such as wicket-5800 that I recently reported). Since there
> is
> >> no indication on the wicket site about when version 7 will be released
> we
> >> are worried that our project will be delayed waiting for wicket
> >> bug-fixes/releases.
> >>
> >> Marios
> >>
>
>


Re: Wicket 7 for production use?

2015-02-01 Thread Sven Meier

Hi Don,

I've added a line to the migration docs related to the generics changes, 
i.e. WICKET-5350.


Many thanks
Sven


On 01.02.2015 00:44, Don Ferguson wrote:

Here is what I encountered migrating a moderately large wicket/bootstrap app 
from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor tweaks, and 
of those, 5 were already covered in the migration guide.  Overall, it was 
pretty smooth process.

https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY 


-Don


On Jan 9, 2015, at 4:41 AM, Martin Grigorov  wrote:

Hi,

There are rumors that 7.0.0 will be released this month.

I'd recommend to migrate the app as soon as possible and report any
problems you hit.
If there is a need of an API change then we will need to release one more
milestone. Otherwise the next release will be 7.0.0 and any API changes
will have to wait for 8.0.0.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:


Hi all,

Is there any estimate when wicket 7 will be ready for production use?

We would really like to migrate our applications to it, and help with
testing, but we are worried that we may encounter bugs in things that work
in wicket 6 (such as wicket-5800 that I recently reported). Since there is
no indication on the wicket site about when version 7 will be released we
are worried that our project will be delayed waiting for wicket
bug-fixes/releases.

Marios







Re: Wicket 7 for production use?

2015-01-31 Thread Ernesto Reinaldo Barreiro
Thanks for sharing!

On Sun, Feb 1, 2015 at 12:44 AM, Don Ferguson 
wrote:

> Here is what I encountered migrating a moderately large wicket/bootstrap
> app from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor
> tweaks, and of those, 5 were already covered in the migration guide.
> Overall, it was pretty smooth process.
>
>
> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
> <
> https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY
> >
>
> -Don
>
> > On Jan 9, 2015, at 4:41 AM, Martin Grigorov 
> wrote:
> >
> > Hi,
> >
> > There are rumors that 7.0.0 will be released this month.
> >
> > I'd recommend to migrate the app as soon as possible and report any
> > problems you hit.
> > If there is a need of an API change then we will need to release one more
> > milestone. Otherwise the next release will be 7.0.0 and any API changes
> > will have to wait for 8.0.0.
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
> >
> >> Hi all,
> >>
> >> Is there any estimate when wicket 7 will be ready for production use?
> >>
> >> We would really like to migrate our applications to it, and help with
> >> testing, but we are worried that we may encounter bugs in things that
> work
> >> in wicket 6 (such as wicket-5800 that I recently reported). Since there
> is
> >> no indication on the wicket site about when version 7 will be released
> we
> >> are worried that our project will be delayed waiting for wicket
> >> bug-fixes/releases.
> >>
> >> Marios
> >>
>
>


-- 
Regards - Ernesto Reinaldo Barreiro


Re: Wicket 7 for production use?

2015-01-31 Thread Don Ferguson
Here is what I encountered migrating a moderately large wicket/bootstrap app 
from 6.1.18 to 7.0.0-M4.  There were 8 changes that required minor tweaks, and 
of those, 5 were already covered in the migration guide.  Overall, it was 
pretty smooth process.

https://docs.google.com/document/d/1GI8vU_wHLxQ-ntXxLMHCaRcekfwEe7jIbIrri1LzYSY 


-Don

> On Jan 9, 2015, at 4:41 AM, Martin Grigorov  wrote:
> 
> Hi,
> 
> There are rumors that 7.0.0 will be released this month.
> 
> I'd recommend to migrate the app as soon as possible and report any
> problems you hit.
> If there is a need of an API change then we will need to release one more
> milestone. Otherwise the next release will be 7.0.0 and any API changes
> will have to wait for 8.0.0.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:
> 
>> Hi all,
>> 
>> Is there any estimate when wicket 7 will be ready for production use?
>> 
>> We would really like to migrate our applications to it, and help with
>> testing, but we are worried that we may encounter bugs in things that work
>> in wicket 6 (such as wicket-5800 that I recently reported). Since there is
>> no indication on the wicket site about when version 7 will be released we
>> are worried that our project will be delayed waiting for wicket
>> bug-fixes/releases.
>> 
>> Marios
>> 



Re: Wicket 7 for production use?

2015-01-09 Thread Martin Grigorov
Hi,

There are rumors that 7.0.0 will be released this month.

I'd recommend to migrate the app as soon as possible and report any
problems you hit.
If there is a need of an API change then we will need to release one more
milestone. Otherwise the next release will be 7.0.0 and any API changes
will have to wait for 8.0.0.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Jan 9, 2015 at 12:28 PM, mscoon  wrote:

> Hi all,
>
> Is there any estimate when wicket 7 will be ready for production use?
>
> We would really like to migrate our applications to it, and help with
> testing, but we are worried that we may encounter bugs in things that work
> in wicket 6 (such as wicket-5800 that I recently reported). Since there is
> no indication on the wicket site about when version 7 will be released we
> are worried that our project will be delayed waiting for wicket
> bug-fixes/releases.
>
> Marios
>


Wicket 7 for production use?

2015-01-09 Thread mscoon
Hi all,

Is there any estimate when wicket 7 will be ready for production use?

We would really like to migrate our applications to it, and help with
testing, but we are worried that we may encounter bugs in things that work
in wicket 6 (such as wicket-5800 that I recently reported). Since there is
no indication on the wicket site about when version 7 will be released we
are worried that our project will be delayed waiting for wicket
bug-fixes/releases.

Marios