Re: r4480 - trunk/varnish-cache/bin/varnishncsa

[Anders Nordby]

Hi,

I must object to this change, as I use varnishncsa -b extensively to
pull out reports on missed objects being fetch from the backends too
often. Please revert this change, as varnishncsa -b has its use.

Anders.

On Mon, Jan 25, 2010 at 01:19:22PM +0100, krist...@projects.linpro.no wrote:
 Author: kristian
 Date: 2010-01-25 13:19:22 +0100 (Mon, 25 Jan 2010)
 New Revision: 4480
 
 Modified:
trunk/varnish-cache/bin/varnishncsa/varnishncsa.c
 Log:
 Only handle client requests (-c) for varnishncsa
 
 Fixes #617
 
 
 Modified: trunk/varnish-cache/bin/varnishncsa/varnishncsa.c
 ===
 --- trunk/varnish-cache/bin/varnishncsa/varnishncsa.c 2010-01-25 11:36:43 UTC 
 (rev 4479)
 +++ trunk/varnish-cache/bin/varnishncsa/varnishncsa.c 2010-01-25 12:19:22 UTC 
 (rev 4480)
 @@ -553,6 +553,13 @@
   case 'w':
   w_arg = optarg;
   break;
 + case 'b':
 + fprintf(stderr, -b is not valid for varnishncsa\n);
 + exit(1);
 + break;
 + case 'c':
 + /* XXX: Silently ignored: it's required anyway */
 + break;
   default:
   if (VSL_Arg(vd, c, optarg)  0)
   break;
 @@ -560,6 +567,8 @@
   }
   }
  
 + VSL_Arg(vd, 'c', optarg);
 +
   if (VSL_OpenLog(vd, n_arg))
   exit(1);
  
 
 ___
 varnish-commit mailing list
 varnish-com...@projects.linpro.no
 http://projects.linpro.no/mailman/listinfo/varnish-commit


-- 
Anders.
___
varnish-dev mailing list
varnish-dev@projects.linpro.no
http://projects.linpro.no/mailman/listinfo/varnish-dev

Re: r4480 - trunk/varnish-cache/bin/varnishncsa

[Poul-Henning Kamp]

In message d38199ba-78a0-4c7a-a26a-a24d070b6...@develooper.com, =?iso-8859-1?
Q?Ask_Bj=F8rn_Hansen?= writes:

On Feb 1, 2010, at 1:35, Anders Nordby wrote:

 I must object to this change, as I use varnishncsa -b extensively to
 pull out reports on missed objects being fetch from the backends too
 often. Please revert this change, as varnishncsa -b has its use.

I don't know why it was removed or if there's a good alternative,
but I've found the -b option very useful, too.

Well, the code to implement it full was never there, and people were
reporting core dumps because of it, so we figured we would make the
non-support for -b explicit, until the code could be written.

There are no objections to supporting it, it's just code to be
written by somebody... (nudge, nudge, wink, wink...)

Poul-Henning


-- 
Poul-Henning Kamp   | UNIX since Zilog Zeus 3.20
p...@freebsd.org | TCP/IP since RFC 956
FreeBSD committer   | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
___
varnish-dev mailing list
varnish-dev@projects.linpro.no
http://projects.linpro.no/mailman/listinfo/varnish-dev