[vchkpw] Incredibly destructive chmod's in vpopmail's Makefile.am
Here's a snippet of vpopmail's Makefile.am (from line 106 in 5.3.23) chmod 755 $(DESTDIR)@vpopmaildir@ chmod 755 $(DESTDIR)@vpopmaildir@/include chmod 755 $(DESTDIR)@vpopmaildir@/etc chmod 755 $(DESTDIR)@vpopmaildir@/doc chmod 755 $(DESTDIR)@vpopmaildir@/doc/man_html chmod 755 $(DESTDIR)@vpopmaildir@/doc/doc_html chmod 755 $(DESTDIR)@vpopmaildir@/bin chmod 700 $(DESTDIR)@vpopmaildir@/@domains_dir@ chmod 711 $(DESTDIR)@vpopmaildir@/bin/* chmod 444 $(DESTDIR)@vpopmaildir@/include/* chmod 444 $(DESTDIR)@vpopmaildir@/doc/doc_html/* Can anyone besides me see the problem? To make vpopmail distribution-friendly, I symlinked /home/vpopmail/bin to /usr/sbin (where I feel the files belong in the first place). So everything in /usr/sbin is set to rwx--x--x. Because I installed qmail via my distribution's installation tool, its binaries are located in /usr/sbin. Needless to say, the mail server was broken. There is no good reason to change permissions on all these files anyway; just install them properly in the first place and there's no reason they would get changed (unless the sysadmin wanted them changed, for whatever reason). The Makefile.am would be a lot simpler and less system-intrusive if it used the 'install' command instead of mkinstalldirs/cp/chown/chmod. Would it be more helpful if I wrote up a patch for this? I have hardly any time for the next 3 weeks, but figured this issue ought to be brought to people's attention as soon as possible. Adam Hooper [EMAIL PROTECTED]
Re: [vchkpw] Incredibly destructive chmod's in vpopmail's Makefile.am
måndagen den 11 augusti 2003 21.20 skrev Tom Collins: On Monday, August 11, 2003, at 10:36 AM, Adam Hooper wrote: The Makefile.am would be a lot simpler and less system-intrusive if it used the 'install' command instead of mkinstalldirs/cp/chown/chmod. Would it be more helpful if I wrote up a patch for this? I have hardly any time for the next 3 weeks, but figured this issue ought to be brought to people's attention as soon as possible. I would gladly accept such a patch. This is on the todo list for vpopmail, and I'd love to cross it out. Being able to install vpopmail to /usr/local would be a great improvement. Having it make so many changes to directory ownership and permissions is a bad thing. If you do not have the time, then I'll try to take a look at the install command and change Makefile.am to use it instead of the current mess of code. That shouldn't be so hard, just a matter of making it honor the passed bindir, sbindir, sysconfdir, etc. from the configure invocation(?). --prefix=/home/vpopmail would be the legacy and default option in this case. -- Regards // Oden Eriksson, Deserve-IT.com
Re: [vchkpw] Incredibly destructive chmod's in vpopmail's Makefile.am
On Monday, August 11, 2003, at 10:36 AM, Adam Hooper wrote: The Makefile.am would be a lot simpler and less system-intrusive if it used the 'install' command instead of mkinstalldirs/cp/chown/chmod. Would it be more helpful if I wrote up a patch for this? I have hardly any time for the next 3 weeks, but figured this issue ought to be brought to people's attention as soon as possible. I would gladly accept such a patch. This is on the todo list for vpopmail, and I'd love to cross it out. Being able to install vpopmail to /usr/local would be a great improvement. Having it make so many changes to directory ownership and permissions is a bad thing. If you do not have the time, then I'll try to take a look at the install command and change Makefile.am to use it instead of the current mess of code. -- Tom Collins [EMAIL PROTECTED] http://sniffter.com/ - info on the Sniffter hand-held Network Tester
