Re: [vdr] vdr xine-lib eac3
Zaverel and Jose Alberto, Thanks a lot for your explanations; I am going to try the "recode ac3 solution" with alsa. Cheers. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de zaverel Envoyé : jeudi 12 juillet 2012 13:12 À : VDR Mailing List Objet : [vdr] vdr xine-lib eac3 @Zaverel, What do you mean by "It's not perfect but that work" ? it's cpu extensive because all audio is recoded in ac3. You can try with this in /etc/asound.conf (for global user ) or ~/.asoundrc (only user) pcm.!default { type plug slave.pcm surroundaudio } ctl.!default { type plug slave.pcm surroundaudio } pcm.a52encode { type a52 format S16_LE channels 6 rate 48000 bitrate 448 } pcm.surroundaudio { type upmix slave.pcm a52encode channels 6 } and start xine with --audio=alsa:surroundaudio ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
On Miércoles, 11 de julio de 2012 22:43:04 Karim Afifi escribió: > @Zaverel, > What do you mean by "It's not perfect but that work" ? > > @Jose Alberto, > What's the problem with the channel "TVE-HD Pruebas". > Could you please tell us about your hardware ? Are you using spdif output ? > > Thanks for your support which help us to understand the subject. > Karim > The patch is because ffmpeg eac3 takes whole eac3 frames, and the remaining part of the frames are lost without the patch. It is noticed by bad audio and lost audio parts. I have only one channel with eac3, and it only has two channels. I connect the computer with a hdmi cable to a tv. I am not using spdif. Jose Alberto > -Message d'origine- > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de > Jose Alberto Reguero > Envoyé : mercredi 11 juillet 2012 18:52 > À : vdr@linuxtv.org > Cc : zaverel > Objet : Re: [vdr] vdr xine-lib eac3 > > On Miércoles, 11 de julio de 2012 14:00:47 zaverel escribió: > > >/ Is it the normal behaviour, or did I miss something ? > > > > />/ Is there a way to convert eac3 => ac3 for delivering 5.1 stream > > through the />/ spdif output ? > > />/ > > />/ Regards. > > />/ Karim > > />/ > > > > hello, > > > > with alsa-plugins and a52 you can have more than 2 channels on spdif > > > > sound is encoded in dolby on-the-fly and send to the spdif. > > > > configuration is in ~/.asoundrc > > > > There is many exemples on the net > > > > It's not perfect but that work./ > > > > > > > > Jose Alberto , what is the purpose to your patch ? > > The patch is for eac3 sound problems with the channel "TVE-HD Pruebas". > > Jose Alberto > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
@Zaverel, What do you mean by "It's not perfect but that work" ? @Jose Alberto, What's the problem with the channel "TVE-HD Pruebas". Could you please tell us about your hardware ? Are you using spdif output ? Thanks for your support which help us to understand the subject. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de Jose Alberto Reguero Envoyé : mercredi 11 juillet 2012 18:52 À : vdr@linuxtv.org Cc : zaverel Objet : Re: [vdr] vdr xine-lib eac3 On Miércoles, 11 de julio de 2012 14:00:47 zaverel escribió: > >/ Is it the normal behaviour, or did I miss something ? > > />/ Is there a way to convert eac3 => ac3 for delivering 5.1 stream > through the />/ spdif output ? > />/ > />/ Regards. > />/ Karim > />/ > > hello, > > with alsa-plugins and a52 you can have more than 2 channels on spdif > > sound is encoded in dolby on-the-fly and send to the spdif. > > configuration is in ~/.asoundrc > > There is many exemples on the net > > It's not perfect but that work./ > > > > Jose Alberto , what is the purpose to your patch ? The patch is for eac3 sound problems with the channel "TVE-HD Pruebas". Jose Alberto ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
On Miércoles, 11 de julio de 2012 14:00:47 zaverel escribió: > >/ Is it the normal behaviour, or did I miss something ? > > />/ Is there a way to convert eac3 => ac3 for delivering 5.1 stream through > the />/ spdif output ? > />/ > />/ Regards. > />/ Karim > />/ > > hello, > > with alsa-plugins and a52 you can have more than 2 channels on spdif > > sound is encoded in dolby on-the-fly and send to the spdif. > > configuration is in ~/.asoundrc > > There is many exemples on the net > > It's not perfect but that work./ > > > > Jose Alberto , what is the purpose to your patch ? The patch is for eac3 sound problems with the channel "TVE-HD Pruebas". Jose Alberto ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
On Martes, 10 de julio de 2012 22:53:44 Karim Afifi escribió: > Up please :-) > > Karim > > -Message d'origine- > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de > Karim Afifi > Envoyé : vendredi 18 mai 2012 21:32 > À : 'VDR Mailing List' > Objet : Re: [vdr] vdr xine-lib eac3 > > Hello, > > I am using vdr-1.7.27 and xineliboutput (with xine-lib from january 2012 and > José Alberto's patch). All HD dvb-t french channels are deliver "eac3", but > vdr delivers only stereo pcm on the spdif output (instead of 5.1). > > Is it the normal behaviour, or did I miss something ? > Is there a way to convert eac3 => ac3 for delivering 5.1 stream through the > spdif output ? > > Regards. > Karim > You can try latest vdr and latest xine-lib-1.2 without patches. I use also a patch(attached) for xine-lib-1.2 but perhaps you don't need it. But I don't know if spdif works because decoding eac3 is done via ffmpeg. Jose Alberto > > -Message d'origine- > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de > Jose Alberto Reguero Envoyé : dimanche 3 octobre 2010 23:56 À : VDR Mailing > List Objet : Re: [vdr] vdr xine-lib eac3 > > Attached is a patch to fix xine-lib ts work with eac3. With this patch you > can use xine-ui to play the records. > > Jose Alberto > > El Domingo 03 Octubre 2010, Jose Alberto Reguero escribió: > > Playing with xine-ui and demux ts don't work well. You must play it > > with > > vdr- xine. > > > > Jose Alberto > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdrdiff -r 748c5603d2df src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Wed Feb 29 08:35:12 2012 +0200 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Mon Jun 18 17:17:58 2012 +0200 @@ -448,7 +448,8 @@ /* pad input data */ memset(&this->buf[this->size], 0, FF_INPUT_BUFFER_PADDING_SIZE); - while (this->size>0) { + bytes_consumed = 0; + while (this->size>bytes_consumed) { decode_buffer_size = AVCODEC_MAX_AUDIO_FRAME_SIZE; bytes_consumed = @@ -555,8 +556,8 @@ offset += bytes_consumed; } - /* reset internal accumulation buffer */ - this->size = 0; + if (offset) +memmove(this->buf, &this->buf[offset], this->size); } } } ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Up please :-) Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de Karim Afifi Envoyé : vendredi 18 mai 2012 21:32 À : 'VDR Mailing List' Objet : Re: [vdr] vdr xine-lib eac3 Hello, I am using vdr-1.7.27 and xineliboutput (with xine-lib from january 2012 and José Alberto's patch). All HD dvb-t french channels are deliver "eac3", but vdr delivers only stereo pcm on the spdif output (instead of 5.1). Is it the normal behaviour, or did I miss something ? Is there a way to convert eac3 => ac3 for delivering 5.1 stream through the spdif output ? Regards. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de Jose Alberto Reguero Envoyé : dimanche 3 octobre 2010 23:56 À : VDR Mailing List Objet : Re: [vdr] vdr xine-lib eac3 Attached is a patch to fix xine-lib ts work with eac3. With this patch you can use xine-ui to play the records. Jose Alberto El Domingo 03 Octubre 2010, Jose Alberto Reguero escribió: > Playing with xine-ui and demux ts don't work well. You must play it > with > vdr- xine. > > Jose Alberto > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hello, I am using vdr-1.7.27 and xineliboutput (with xine-lib from january 2012 and José Alberto's patch). All HD dvb-t french channels are deliver "eac3", but vdr delivers only stereo pcm on the spdif output (instead of 5.1). Is it the normal behaviour, or did I miss something ? Is there a way to convert eac3 => ac3 for delivering 5.1 stream through the spdif output ? Regards. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de Jose Alberto Reguero Envoyé : dimanche 3 octobre 2010 23:56 À : VDR Mailing List Objet : Re: [vdr] vdr xine-lib eac3 Attached is a patch to fix xine-lib ts work with eac3. With this patch you can use xine-ui to play the records. Jose Alberto El Domingo 03 Octubre 2010, Jose Alberto Reguero escribió: > Playing with xine-ui and demux ts don't work well. You must play it > with > vdr- xine. > > Jose Alberto > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
thanks for your help and have a nice week end > > > > > > > > Best regards > > > > > > > > Le Thursday 30 September 2010 22:51:34 dplu, vous avez écrit : > > > > > Here is the result of my colleague using vdr-sxfe verbose and > > > > > changing the audio track > > > > > > > > > > [9665] [demux_vdr] audio stream changed: 0341 -> 03410001 > > > > > Erreur de segmentation (=segfault error) > > > > > > > > > > As you can see this is the same error , he use this patch > > > > > > > > > > diff -r cb99a1abe986 src/combined/ffmpeg/ff_audio_decoder.c > > > > > --- a/src/combined/ffmpeg/ff_audio_decoder.c Fri Apr 09 18:55:47 > > > > > 2010 +0200 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Sat Apr 10 > > > > > 16:23:14 2010 +0200 @@ -219,6 +219,12 @@ > > > > > this->context->extradata_size); > > > > > break; > > > > > } > > > > > + case BUF_AUDIO_EAC3: > > > > > + case BUF_AUDIO_A52: > > > > > + { > > > > > + this->context->request_channels = 2; > > > > > + break; > > > > > + } > > > > > default: > > > > > xprintf(this->stream->xine, XINE_VERBOSITY_LOG, > > > > > "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", > > > > > codec_type); > > > > > > > > > > We continue to investigate > > > > > > > > > > thanks for your help > > > > > > > > > > Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > > > > > > I will add this patch to my xine-lib and rebuild all > > > > > > > > > > > > Here are two more samples to test given by colleague, I will also > > > > > > wait the answer from Karim Afifi to have comparative tests > > > > > > > > > > > > http://dl.free.fr/mE6yTLPnx > > > > > > http://dl.free.fr/u2dWSU5R8 > > > > > > > > > > > > Other idea : may it comes from my xine-ui version ? did you use a > > > > > > fresh one from http://hg.debian.org/hg/xine-lib/xine-ui/ > > > > > > > > > > > > Many thanks for your help and have a nice evening > > > > > > > > > > > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous > > > > > > avez > > > > > > > > > > écrit : > > > > > > > The error you report doesn't matter. It is because there is no > > > > > > > case for EAC3. I have an additional patch to use only two > > > > > > > channels, and I don't have this error. You can use the patch > > > > > > > and comment the line: this->context->request_channels = 2; and > > > > > > > then you don't have the error. > > > > > > > I try with the sample you give to me. If you want you can give > > > > > > > me another sample. > > > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > > > > > > Hi > > > > > > > > > > > > > > > > In fact, I use a very recent ffmpeg (less than one month) and > > > > > > > > the very latest xine-lib 1.2 with no patch except yours > > > > > > > > > > > > > > > > I found my error message in > > > > > > > > combined/ffmpeg/ff_audio_decoder.c > > > > > > > > > > > > > > > > This is strange that you cannot reproduce as long we (my > > > > > > > > colleague + me) are able to have it every time and other user > > > > > > > > report this problem using xlo plugin + sxfe (on French DVB > > > > > > > > forum) > > > > > > > > > > > > > > > > I can update my ffmpeg to the very latest release but not > > > > > > > > sure it will change something (ffplay or mplayer works fine) > > > > > > > > > > > > > > > > Nobody else can test our sample please ? > > > > > > > > > > > > > > >
Re: [vdr] vdr xine-lib eac3
o_decoder.c Fri Apr 09 18:55:47 2010 > > > > +0200 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Sat Apr 10 > > > > 16:23:14 2010 +0200 @@ -219,6 +219,12 @@ > > > > this->context->extradata_size); > > > > break; > > > > } > > > > + case BUF_AUDIO_EAC3: > > > > + case BUF_AUDIO_A52: > > > > + { > > > > + this->context->request_channels = 2; > > > > + break; > > > > + } > > > > default: > > > > xprintf(this->stream->xine, XINE_VERBOSITY_LOG, > > > > "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", codec_type); > > > > > > > > We continue to investigate > > > > > > > > thanks for your help > > > > > > > > Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > > > > > I will add this patch to my xine-lib and rebuild all > > > > > > > > > > Here are two more samples to test given by colleague, I will also > > > > > wait the answer from Karim Afifi to have comparative tests > > > > > > > > > > http://dl.free.fr/mE6yTLPnx > > > > > http://dl.free.fr/u2dWSU5R8 > > > > > > > > > > Other idea : may it comes from my xine-ui version ? did you use a > > > > > fresh one from http://hg.debian.org/hg/xine-lib/xine-ui/ > > > > > > > > > > Many thanks for your help and have a nice evening > > > > > > > > > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous > > > > > avez > > > > > > > > écrit : > > > > > > The error you report doesn't matter. It is because there is no > > > > > > case for EAC3. I have an additional patch to use only two > > > > > > channels, and I don't have this error. You can use the patch and > > > > > > comment the line: this->context->request_channels = 2; > > > > > > and then you don't have the error. > > > > > > I try with the sample you give to me. If you want you can give me > > > > > > another sample. > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > > > > > Hi > > > > > > > > > > > > > > In fact, I use a very recent ffmpeg (less than one month) and > > > > > > > the very latest xine-lib 1.2 with no patch except yours > > > > > > > > > > > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > > > > > > > > > > > This is strange that you cannot reproduce as long we (my > > > > > > > colleague + me) are able to have it every time and other user > > > > > > > report this problem using xlo plugin + sxfe (on French DVB > > > > > > > forum) > > > > > > > > > > > > > > I can update my ffmpeg to the very latest release but not sure > > > > > > > it will change something (ffplay or mplayer works fine) > > > > > > > > > > > > > > Nobody else can test our sample please ? > > > > > > > > > > > > > > Have a nive evening > > > > > > > > > > > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, > > > > > > > vous avez > > > > > > > > > > > > écrit : > > > > > > > > I can change eac3 audio channel without problem. Perhaps you > > > > > > > > have additional patches that cause that. > > > > > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > Just to confirm that I've the same crash that dplu is > > > > > > > > > talking about, with xineliboutput here. It occurs : > > > > > > > > > - **Every time** I try to change audio track on "HD e-ac3" > > > > > > > > > channel. - Many time when I zap from "SD" to on "H
Re: [vdr] vdr xine-lib eac3
thanks for your help > > > > > > Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > > > > I will add this patch to my xine-lib and rebuild all > > > > > > > > Here are two more samples to test given by colleague, I will also > > > > wait the answer from Karim Afifi to have comparative tests > > > > > > > > http://dl.free.fr/mE6yTLPnx > > > > http://dl.free.fr/u2dWSU5R8 > > > > > > > > Other idea : may it comes from my xine-ui version ? did you use a > > > > fresh one from http://hg.debian.org/hg/xine-lib/xine-ui/ > > > > > > > > Many thanks for your help and have a nice evening > > > > > > > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous > > > > avez > > > > > > écrit : > > > > > The error you report doesn't matter. It is because there is no case > > > > > for EAC3. I have an additional patch to use only two channels, and > > > > > I don't have this error. You can use the patch and comment the > > > > > line: this->context->request_channels = 2; > > > > > and then you don't have the error. > > > > > I try with the sample you give to me. If you want you can give me > > > > > another sample. > > > > > > > > > > Jose Alberto > > > > > > > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > > > > Hi > > > > > > > > > > > > In fact, I use a very recent ffmpeg (less than one month) and the > > > > > > very latest xine-lib 1.2 with no patch except yours > > > > > > > > > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > > > > > > > > > This is strange that you cannot reproduce as long we (my > > > > > > colleague + me) are able to have it every time and other user > > > > > > report this problem using xlo plugin + sxfe (on French DVB forum) > > > > > > > > > > > > I can update my ffmpeg to the very latest release but not sure it > > > > > > will change something (ffplay or mplayer works fine) > > > > > > > > > > > > Nobody else can test our sample please ? > > > > > > > > > > > > Have a nive evening > > > > > > > > > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous > > > > > > avez > > > > > > > > > > écrit : > > > > > > > I can change eac3 audio channel without problem. Perhaps you > > > > > > > have additional patches that cause that. > > > > > > > > > > > > > > Jose Alberto > > > > > > > > > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > > > > > Hello, > > > > > > > > > > > > > > > > Just to confirm that I've the same crash that dplu is talking > > > > > > > > about, with xineliboutput here. It occurs : > > > > > > > > - **Every time** I try to change audio track on "HD e-ac3" > > > > > > > > channel. - Many time when I zap from "SD" to on "HD e-ac3" > > > > > > > > channel. - Many time when I zap from HD "e-ac3" to on HD > > > > > > > > "e-ac3" channel. - No problem when using "SD" and "HD no > > > > > > > > e-ac3" channels. > > > > > > > > > > > > > > > > Guys, many thanks for your job, I hope vdr will soon remain > > > > > > > > as stable on "HD e-ac3" that with "SD" and "HD non e-ac3" > > > > > > > > channels. > > > > > > > > > > > > > > > > > > > > > > > > Karim > > > > > > > > > > > > > > > > -Message d'origine- > > > > > > > > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] > > > > > > > > De la part de dplu > > > > > > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > > > > > > À : VDR Mailing List > >
Re: [vdr] vdr xine-lib eac3
Hi I continue to search why it fail ... with no luck, hope other people will have time to make test basis test setup : vdr 1.7.15 extention patch + patch e-ac3 for vdr-xine xine-ui 0.99.6 latest git ffmpeg latest xine 1.2 with basic e-ac3 patch for only >From vdr : crash every time I change audio track as described previously Second test Try opening the TS file from xine-ui directly, same behaviour op mode : At startup sound track is "0" (should be "fra"), play nice track -- display track "off" , no crash track ++ display "0" instead of "fra" , no crash track ++ display "qaa" , it's real name .. crash in couple of seconds Here is the log with high verbosity http://pastebin.com/BvGKDk0v Hope this help you, I underline in yellow some strange thing By the way, if you have time, can you post a sample of recording made at home so we can also test your sample with our configuration Many thanks for your help and have a nice week end Best regards Le Thursday 30 September 2010 22:51:34 dplu, vous avez écrit : > Here is the result of my colleague using vdr-sxfe verbose and changing the > audio track > > [9665] [demux_vdr] audio stream changed: 0341 -> 03410001 > Erreur de segmentation (=segfault error) > > As you can see this is the same error , he use this patch > > diff -r cb99a1abe986 src/combined/ffmpeg/ff_audio_decoder.c > --- a/src/combined/ffmpeg/ff_audio_decoder.c Fri Apr 09 18:55:47 2010 +0200 > +++ b/src/combined/ffmpeg/ff_audio_decoder.c Sat Apr 10 16:23:14 2010 +0200 > @@ -219,6 +219,12 @@ > this->context->extradata_size); > break; > } > + case BUF_AUDIO_EAC3: > + case BUF_AUDIO_A52: > + { > + this->context->request_channels = 2; > + break; > + } > default: > xprintf(this->stream->xine, XINE_VERBOSITY_LOG, > "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", codec_type); > > We continue to investigate > > thanks for your help > > Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > > I will add this patch to my xine-lib and rebuild all > > > > Here are two more samples to test given by colleague, I will also wait > > the answer from Karim Afifi to have comparative tests > > > > http://dl.free.fr/mE6yTLPnx > > http://dl.free.fr/u2dWSU5R8 > > > > Other idea : may it comes from my xine-ui version ? did you use a fresh > > one from http://hg.debian.org/hg/xine-lib/xine-ui/ > > > > Many thanks for your help and have a nice evening > > > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous avez > > écrit : > > > The error you report doesn't matter. It is because there is no case for > > > EAC3. I have an additional patch to use only two channels, and I don't > > > have this error. You can use the patch and comment the line: > > > this->context->request_channels = 2; > > > and then you don't have the error. > > > I try with the sample you give to me. If you want you can give me > > > another sample. > > > > > > Jose Alberto > > > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > > Hi > > > > > > > > In fact, I use a very recent ffmpeg (less than one month) and the > > > > very latest xine-lib 1.2 with no patch except yours > > > > > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > > > > > This is strange that you cannot reproduce as long we (my colleague + > > > > me) are able to have it every time and other user report this problem > > > > using xlo plugin + sxfe (on French DVB forum) > > > > > > > > I can update my ffmpeg to the very latest release but not sure it > > > > will change something (ffplay or mplayer works fine) > > > > > > > > Nobody else can test our sample please ? > > > > > > > > Have a nive evening > > > > > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous > > > > avez > > > > > > écrit : > > > > > I can change eac3 audio channel without problem. Perhaps you have > > > > > additional patches that cause that. > > > > > > > > > > Jose Alberto > > > > > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > > > Hello, > > > > > > > > > > > > Just to confirm that I've the same crash that dplu is talking > > > > > > about, with xi
Re: [vdr] vdr xine-lib eac3
Here is the result of my colleague using vdr-sxfe verbose and changing the audio track [9665] [demux_vdr] audio stream changed: 0341 -> 03410001 Erreur de segmentation (=segfault error) As you can see this is the same error , he use this patch diff -r cb99a1abe986 src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Fri Apr 09 18:55:47 2010 +0200 +++ b/src/combined/ffmpeg/ff_audio_decoder.c Sat Apr 10 16:23:14 2010 +0200 @@ -219,6 +219,12 @@ this->context->extradata_size); break; } + case BUF_AUDIO_EAC3: + case BUF_AUDIO_A52: + { + this->context->request_channels = 2; + break; + } default: xprintf(this->stream->xine, XINE_VERBOSITY_LOG, "ffmpeg_audio_dec: unknown header with buf type 0x%X\n", codec_type); We continue to investigate thanks for your help Le Thursday 30 September 2010 22:40:34 dplu, vous avez écrit : > I will add this patch to my xine-lib and rebuild all > > Here are two more samples to test given by colleague, I will also wait the > answer from Karim Afifi to have comparative tests > > http://dl.free.fr/mE6yTLPnx > http://dl.free.fr/u2dWSU5R8 > > Other idea : may it comes from my xine-ui version ? did you use a fresh one > from http://hg.debian.org/hg/xine-lib/xine-ui/ > > Many thanks for your help and have a nice evening > > Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous avez écrit : > > The error you report doesn't matter. It is because there is no case for > > EAC3. I have an additional patch to use only two channels, and I don't > > have this error. You can use the patch and comment the line: > > this->context->request_channels = 2; > > and then you don't have the error. > > I try with the sample you give to me. If you want you can give me another > > sample. > > > > Jose Alberto > > > > El Jueves 30 Septiembre 2010, dplu escribió: > > > Hi > > > > > > In fact, I use a very recent ffmpeg (less than one month) and the very > > > latest xine-lib 1.2 with no patch except yours > > > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > > > This is strange that you cannot reproduce as long we (my colleague + > > > me) are able to have it every time and other user report this problem > > > using xlo plugin + sxfe (on French DVB forum) > > > > > > I can update my ffmpeg to the very latest release but not sure it will > > > change something (ffplay or mplayer works fine) > > > > > > Nobody else can test our sample please ? > > > > > > Have a nive evening > > > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez > > > > écrit : > > > > I can change eac3 audio channel without problem. Perhaps you have > > > > additional patches that cause that. > > > > > > > > Jose Alberto > > > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > > Hello, > > > > > > > > > > Just to confirm that I've the same crash that dplu is talking > > > > > about, with xineliboutput here. It occurs : > > > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as > > > > > stable on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > > > > > > > Karim > > > > > > > > > > -Message d'origine- > > > > > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la > > > > > part de dplu > > > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > > > À : VDR Mailing List > > > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > > > > > > > Hi > > > > > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > > > channel ? I > > > > > have a strange error reported also by french colleague : > > > > > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour évi
Re: [vdr] vdr xine-lib eac3
I will add this patch to my xine-lib and rebuild all Here are two more samples to test given by colleague, I will also wait the answer from Karim Afifi to have comparative tests http://dl.free.fr/mE6yTLPnx http://dl.free.fr/u2dWSU5R8 Other idea : may it comes from my xine-ui version ? did you use a fresh one from http://hg.debian.org/hg/xine-lib/xine-ui/ Many thanks for your help and have a nice evening Le Thursday 30 September 2010 22:27:52 Jose Alberto Reguero, vous avez écrit : > The error you report doesn't matter. It is because there is no case for > EAC3. I have an additional patch to use only two channels, and I don't have > this error. You can use the patch and comment the line: > this->context->request_channels = 2; > and then you don't have the error. > I try with the sample you give to me. If you want you can give me another > sample. > > Jose Alberto > > El Jueves 30 Septiembre 2010, dplu escribió: > > Hi > > > > In fact, I use a very recent ffmpeg (less than one month) and the very > > latest xine-lib 1.2 with no patch except yours > > > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > > > This is strange that you cannot reproduce as long we (my colleague + me) > > are able to have it every time and other user report this problem using > > xlo plugin + sxfe (on French DVB forum) > > > > I can update my ffmpeg to the very latest release but not sure it will > > change something (ffplay or mplayer works fine) > > > > Nobody else can test our sample please ? > > > > Have a nive evening > > > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez > > écrit : > > > I can change eac3 audio channel without problem. Perhaps you have > > > additional patches that cause that. > > > > > > Jose Alberto > > > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > > Hello, > > > > > > > > Just to confirm that I've the same crash that dplu is talking about, > > > > with xineliboutput here. It occurs : > > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as stable > > > > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > > > > Karim > > > > > > > > -Message d'origine- > > > > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la > > > > part de dplu > > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > > À : VDR Mailing List > > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > > > > Hi > > > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > > channel ? I > > > > have a strange error reported also by french colleague : > > > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > > > saturation. (translation) => Increasing buffer size to 98304 to > > > > prevent overflow ffmpeg_audio_dec: unknown header with buf type > > > > 0x341 > > > > > > > > and xine-ui crash ... error in xiTK > > > > > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > > > switching > > > > from ac3 live channels (like Einfestival HD or ITV HD) to records > > > > having e-ac3 tracks. It is Ok when coming from a mpeg audio channel > > > > (SD broadcast) > > > > > > > > I don't know if it is a xine problem sending bad information to > > > > ffmpeg or a bug in ffmpeg ... changing audio track (with # key) do > > > > not crash mplayer when > > > > playing the TS file > > > > > > > > By the way, many thanks for your work ;o)) > > > > > > > > Best regards > > > > > > > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous > > > > avez > > > > > > > > écrit : > > > > > Here is a new version of the p
Re: [vdr] vdr xine-lib eac3
The error you report doesn't matter. It is because there is no case for EAC3. I have an additional patch to use only two channels, and I don't have this error. You can use the patch and comment the line: this->context->request_channels = 2; and then you don't have the error. I try with the sample you give to me. If you want you can give me another sample. Jose Alberto El Jueves 30 Septiembre 2010, dplu escribió: > Hi > > In fact, I use a very recent ffmpeg (less than one month) and the very > latest xine-lib 1.2 with no patch except yours > > I found my error message in combined/ffmpeg/ff_audio_decoder.c > > This is strange that you cannot reproduce as long we (my colleague + me) > are able to have it every time and other user report this problem using > xlo plugin + sxfe (on French DVB forum) > > I can update my ffmpeg to the very latest release but not sure it will > change something (ffplay or mplayer works fine) > > Nobody else can test our sample please ? > > Have a nive evening > > Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez écrit : > > I can change eac3 audio channel without problem. Perhaps you have > > additional patches that cause that. > > > > Jose Alberto > > > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > > Hello, > > > > > > Just to confirm that I've the same crash that dplu is talking about, > > > with xineliboutput here. It occurs : > > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > > > Guys, many thanks for your job, I hope vdr will soon remain as stable > > > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > > > > Karim > > > > > > -Message d'origine- > > > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la > > > part de dplu > > > Envoyé : mercredi 29 septembre 2010 15:05 > > > À : VDR Mailing List > > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > > > > Hi > > > > > > Thanks for the patch, works nice now. Did you try to change audio > > > channel ? I > > > have a strange error reported also by french colleague : > > > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > > saturation. (translation) => Increasing buffer size to 98304 to prevent > > > overflow ffmpeg_audio_dec: unknown header with buf type 0x341 > > > > > > and xine-ui crash ... error in xiTK > > > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > > switching > > > from ac3 live channels (like Einfestival HD or ITV HD) to records > > > having e-ac3 tracks. It is Ok when coming from a mpeg audio channel > > > (SD broadcast) > > > > > > I don't know if it is a xine problem sending bad information to ffmpeg > > > or a bug in ffmpeg ... changing audio track (with # key) do not crash > > > mplayer when > > > playing the TS file > > > > > > By the way, many thanks for your work ;o)) > > > > > > Best regards > > > > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez > > > > > > écrit : > > > > Here is a new version of the patch. Now it works with the sample. > > > > There > > > > > > was > > > > > > > a bug in the last patch. > > > > > > > > Jose Alberto > > > > > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > > > Thanks for the test, In fact I am not in covered area so I work > > > > > with sample given by a colleague who live in good area on our > > > > > forum > > > > > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > > > > > Maybe is there "something" in TS who is different from your > > > > > country. It should be also interesting to have report from Italian &
Re: [vdr] vdr xine-lib eac3
Jose, Sorry, I was related the issue *before* your last patches. I will test them this week-end. Regards. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de Jose Alberto Reguero Envoyé : jeudi 30 septembre 2010 20:11 À : VDR Mailing List Objet : Re: [vdr] vdr xine-lib eac3 I can change eac3 audio channel without problem. Perhaps you have additional patches that cause that. Jose Alberto El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > Hello, > > Just to confirm that I've the same crash that dplu is talking about, > with xineliboutput here. It occurs : > - **Every time** I try to change audio track on "HD e-ac3" channel. > - Many time when I zap from "SD" to on "HD e-ac3" channel. > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > - No problem when using "SD" and "HD no e-ac3" channels. > > Guys, many thanks for your job, I hope vdr will soon remain as stable > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > Karim > > -Message d'origine- > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de > dplu > Envoyé : mercredi 29 septembre 2010 15:05 > À : VDR Mailing List > Objet : Re: [vdr] vdr xine-lib eac3 > > > Hi > > Thanks for the patch, works nice now. Did you try to change audio channel ? > I > have a strange error reported also by french colleague : > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa saturation. > (translation) => Increasing buffer size to 98304 to prevent overflow > ffmpeg_audio_dec: unknown header with buf type 0x341 > > and xine-ui crash ... error in xiTK > > It happen when switching from fra to qaa (both e-ac3) and also when > switching > from ac3 live channels (like Einfestival HD or ITV HD) to records having > e-ac3 tracks. It is Ok when coming from a mpeg audio channel (SD broadcast) > > I don't know if it is a xine problem sending bad information to ffmpeg or a > bug in ffmpeg ... changing audio track (with # key) do not crash mplayer > when > playing the TS file > > By the way, many thanks for your work ;o)) > > Best regards > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez > > écrit : > > Here is a new version of the patch. Now it works with the sample. There > > was > > > a bug in the last patch. > > > > Jose Alberto > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > Thanks for the test, In fact I am not in covered area so I work with > > > sample given by a colleague who live in good area on our forum > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > Maybe is there "something" in TS who is different from your country. It > > > should be also interesting to have report from Italian users who > > > experiment this audio encoding (not all are xbmc user I hope) > > > > > > Have a nice evening > > > > > > Best regards > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez > > écrit : > > > > I try the sample and don't work. I look into it. But you must try > > > > live tv or samples made with the patches, to see if it work. I try > > > > here > > with > > > > > a channel whith eac3 with spectral extention and it work well. > > > > > > > > Jose Alberto > > > > > > ___ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > __ Information provenant d'ESET Smart Security, version de la base > des signatures de virus 5488 (20100929) __ > > Le message a été vérifié par ESET Smart Security. > > http://www.eset.com > > > > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr __ Information provenant d'ESET Smart Security, version de la base des signatures de virus 5493 (20100930) __ Le message a été vérifié par ESET Smart Security. http://www.eset.com ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi In fact, I use a very recent ffmpeg (less than one month) and the very latest xine-lib 1.2 with no patch except yours I found my error message in combined/ffmpeg/ff_audio_decoder.c This is strange that you cannot reproduce as long we (my colleague + me) are able to have it every time and other user report this problem using xlo plugin + sxfe (on French DVB forum) I can update my ffmpeg to the very latest release but not sure it will change something (ffplay or mplayer works fine) Nobody else can test our sample please ? Have a nive evening Le Thursday 30 September 2010 20:10:54 Jose Alberto Reguero, vous avez écrit : > I can change eac3 audio channel without problem. Perhaps you have > additional patches that cause that. > > Jose Alberto > > El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > > Hello, > > > > Just to confirm that I've the same crash that dplu is talking about, > > with xineliboutput here. It occurs : > > - **Every time** I try to change audio track on "HD e-ac3" channel. > > - Many time when I zap from "SD" to on "HD e-ac3" channel. > > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > > - No problem when using "SD" and "HD no e-ac3" channels. > > > > Guys, many thanks for your job, I hope vdr will soon remain as stable > > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > > > > Karim > > > > -----Message d'origine- > > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part > > de dplu > > Envoyé : mercredi 29 septembre 2010 15:05 > > À : VDR Mailing List > > Objet : Re: [vdr] vdr xine-lib eac3 > > > > > > Hi > > > > Thanks for the patch, works nice now. Did you try to change audio channel > > ? I > > have a strange error reported also by french colleague : > > > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa > > saturation. (translation) => Increasing buffer size to 98304 to prevent > > overflow ffmpeg_audio_dec: unknown header with buf type 0x341 > > > > and xine-ui crash ... error in xiTK > > > > It happen when switching from fra to qaa (both e-ac3) and also when > > switching > > from ac3 live channels (like Einfestival HD or ITV HD) to records having > > e-ac3 tracks. It is Ok when coming from a mpeg audio channel (SD > > broadcast) > > > > I don't know if it is a xine problem sending bad information to ffmpeg or > > a bug in ffmpeg ... changing audio track (with # key) do not crash > > mplayer when > > playing the TS file > > > > By the way, many thanks for your work ;o)) > > > > Best regards > > > > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez > > > > écrit : > > > Here is a new version of the patch. Now it works with the sample. There > > > > was > > > > > a bug in the last patch. > > > > > > Jose Alberto > > > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > > Thanks for the test, In fact I am not in covered area so I work with > > > > sample given by a colleague who live in good area on our forum > > > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > > > Maybe is there "something" in TS who is different from your country. > > > > It should be also interesting to have report from Italian users who > > > > experiment this audio encoding (not all are xbmc user I hope) > > > > > > > > Have a nice evening > > > > > > > > Best regards > > > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez > > > > écrit : > > > > > I try the sample and don't work. I look into it. But you must try > > > > > live tv or samples made with the patches, to see if it work. I try > > > > > here > > > > with > > > > > > > a channel whith eac3 with spectral extention and it work well. > > > > > > > > > > Jose Alberto > > > > > > > > ___ > > > > vdr mailing list > > > > vdr@linuxtv.org > > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > __ Information provenant d'ESET Smart Security, version de la > > base des signatures de virus 5488 (20100929) __ > > > > Le message a été vérifié par ESET Smart Security. > > > > http://www.eset.com > > > > > > > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
I can change eac3 audio channel without problem. Perhaps you have additional patches that cause that. Jose Alberto El Miércoles 29 Septiembre 2010, Karim Afifi escribió: > Hello, > > Just to confirm that I've the same crash that dplu is talking about, > with xineliboutput here. It occurs : > - **Every time** I try to change audio track on "HD e-ac3" channel. > - Many time when I zap from "SD" to on "HD e-ac3" channel. > - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. > - No problem when using "SD" and "HD no e-ac3" channels. > > Guys, many thanks for your job, I hope vdr will soon remain as stable > on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. > > > Karim > > -Message d'origine- > De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de > dplu > Envoyé : mercredi 29 septembre 2010 15:05 > À : VDR Mailing List > Objet : Re: [vdr] vdr xine-lib eac3 > > > Hi > > Thanks for the patch, works nice now. Did you try to change audio channel ? > I > have a strange error reported also by french colleague : > > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa saturation. > (translation) => Increasing buffer size to 98304 to prevent overflow > ffmpeg_audio_dec: unknown header with buf type 0x341 > > and xine-ui crash ... error in xiTK > > It happen when switching from fra to qaa (both e-ac3) and also when > switching > from ac3 live channels (like Einfestival HD or ITV HD) to records having > e-ac3 tracks. It is Ok when coming from a mpeg audio channel (SD broadcast) > > I don't know if it is a xine problem sending bad information to ffmpeg or a > bug in ffmpeg ... changing audio track (with # key) do not crash mplayer > when > playing the TS file > > By the way, many thanks for your work ;o)) > > Best regards > > > Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez > > écrit : > > Here is a new version of the patch. Now it works with the sample. There > > was > > > a bug in the last patch. > > > > Jose Alberto > > > > El Lunes 27 Septiembre 2010, dplu escribió: > > > Thanks for the test, In fact I am not in covered area so I work with > > > sample given by a colleague who live in good area on our forum > > > > > > The sample is very fresh and works perfectly with xineliboutput + > > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch > > > ff_audio_decoder to downmix 5.1 to 2.0 > > > > > > Maybe is there "something" in TS who is different from your country. It > > > should be also interesting to have report from Italian users who > > > experiment this audio encoding (not all are xbmc user I hope) > > > > > > Have a nice evening > > > > > > Best regards > > > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez > > écrit : > > > > I try the sample and don't work. I look into it. But you must try > > > > live tv or samples made with the patches, to see if it work. I try > > > > here > > with > > > > > a channel whith eac3 with spectral extention and it work well. > > > > > > > > Jose Alberto > > > > > > ___ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > __ Information provenant d'ESET Smart Security, version de la base > des signatures de virus 5488 (20100929) __ > > Le message a été vérifié par ESET Smart Security. > > http://www.eset.com > > > > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hello, Just to confirm that I've the same crash that dplu is talking about, with xineliboutput here. It occurs : - **Every time** I try to change audio track on "HD e-ac3" channel. - Many time when I zap from "SD" to on "HD e-ac3" channel. - Many time when I zap from HD "e-ac3" to on HD "e-ac3" channel. - No problem when using "SD" and "HD no e-ac3" channels. Guys, many thanks for your job, I hope vdr will soon remain as stable on "HD e-ac3" that with "SD" and "HD non e-ac3" channels. Karim -Message d'origine- De : vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org] De la part de dplu Envoyé : mercredi 29 septembre 2010 15:05 À : VDR Mailing List Objet : Re: [vdr] vdr xine-lib eac3 Hi Thanks for the patch, works nice now. Did you try to change audio channel ? I have a strange error reported also by french colleague : ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa saturation. (translation) => Increasing buffer size to 98304 to prevent overflow ffmpeg_audio_dec: unknown header with buf type 0x341 and xine-ui crash ... error in xiTK It happen when switching from fra to qaa (both e-ac3) and also when switching from ac3 live channels (like Einfestival HD or ITV HD) to records having e-ac3 tracks. It is Ok when coming from a mpeg audio channel (SD broadcast) I don't know if it is a xine problem sending bad information to ffmpeg or a bug in ffmpeg ... changing audio track (with # key) do not crash mplayer when playing the TS file By the way, many thanks for your work ;o)) Best regards Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez écrit : > Here is a new version of the patch. Now it works with the sample. There was > a bug in the last patch. > > Jose Alberto > > El Lunes 27 Septiembre 2010, dplu escribió: > > Thanks for the test, In fact I am not in covered area so I work with > > sample given by a colleague who live in good area on our forum > > > > The sample is very fresh and works perfectly with xineliboutput + > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch ff_audio_decoder > > to downmix 5.1 to 2.0 > > > > Maybe is there "something" in TS who is different from your country. It > > should be also interesting to have report from Italian users who > > experiment this audio encoding (not all are xbmc user I hope) > > > > Have a nice evening > > > > Best regards > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez écrit : > > > I try the sample and don't work. I look into it. But you must try live > > > tv or samples made with the patches, to see if it work. I try here with > > > a channel whith eac3 with spectral extention and it work well. > > > > > > Jose Alberto > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr __ Information provenant d'ESET Smart Security, version de la base des signatures de virus 5488 (20100929) __ Le message a été vérifié par ESET Smart Security. http://www.eset.com ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi Thanks for the patch, works nice now. Did you try to change audio channel ? I have a strange error reported also by french colleague : ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa saturation. (translation) => Increasing buffer size to 98304 to prevent overflow ffmpeg_audio_dec: unknown header with buf type 0x341 and xine-ui crash ... error in xiTK It happen when switching from fra to qaa (both e-ac3) and also when switching from ac3 live channels (like Einfestival HD or ITV HD) to records having e-ac3 tracks. It is Ok when coming from a mpeg audio channel (SD broadcast) I don't know if it is a xine problem sending bad information to ffmpeg or a bug in ffmpeg ... changing audio track (with # key) do not crash mplayer when playing the TS file By the way, many thanks for your work ;o)) Best regards Le Wednesday 29 September 2010 02:07:11 Jose Alberto Reguero, vous avez écrit : > Here is a new version of the patch. Now it works with the sample. There was > a bug in the last patch. > > Jose Alberto > > El Lunes 27 Septiembre 2010, dplu escribió: > > Thanks for the test, In fact I am not in covered area so I work with > > sample given by a colleague who live in good area on our forum > > > > The sample is very fresh and works perfectly with xineliboutput + > > vdr-sxfe with patch xineliboutputeac3_4.diff plus patch ff_audio_decoder > > to downmix 5.1 to 2.0 > > > > Maybe is there "something" in TS who is different from your country. It > > should be also interesting to have report from Italian users who > > experiment this audio encoding (not all are xbmc user I hope) > > > > Have a nice evening > > > > Best regards > > > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez écrit : > > > I try the sample and don't work. I look into it. But you must try live > > > tv or samples made with the patches, to see if it work. I try here with > > > a channel whith eac3 with spectral extention and it work well. > > > > > > Jose Alberto > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Here is a new version of the patch. Now it works with the sample. There was a bug in the last patch. Jose Alberto El Lunes 27 Septiembre 2010, dplu escribió: > Thanks for the test, In fact I am not in covered area so I work with sample > given by a colleague who live in good area on our forum > > The sample is very fresh and works perfectly with xineliboutput + vdr-sxfe > with patch xineliboutputeac3_4.diff plus patch ff_audio_decoder to downmix > 5.1 to 2.0 > > Maybe is there "something" in TS who is different from your country. It > should be also interesting to have report from Italian users who > experiment this audio encoding (not all are xbmc user I hope) > > Have a nice evening > > Best regards > > Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez écrit : > > I try the sample and don't work. I look into it. But you must try live tv > > or samples made with the patches, to see if it work. I try here with a > > channel whith eac3 with spectral extention and it work well. > > > > Jose Alberto > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr diff -ur xine-0.9.3/vdr172remux.c xine-0.9.3.new/vdr172remux.c --- xine-0.9.3/vdr172remux.c 2009-04-12 13:52:32.0 +0200 +++ xine-0.9.3.new/vdr172remux.c 2010-09-29 01:58:34.79803 +0200 @@ -1703,8 +1703,20 @@ const uchar *Payload = Data + PesPayloadOffset; const int PayloadCount = Count - PesPayloadOffset; + bool ac3; + int framesize; + unsigned short size; - if (Data[3] == 0xBD && PayloadCount >= 9 && ((Payload[0] & 0xF0) == 0x80) && Payload[4] == 0x0B && Payload[5] == 0x77 && frameSizes[Payload[8]] > 0) { + if (PayloadCount < 10) + return -1; + ac3 = ((Payload[9] >> 3) & 0x1f) <= 10; + if ( ac3) + framesize = frameSizes[Payload[8]]; + else { + size = Payload[7] + Payload[6] * 256; + framesize = ((size & 0x07FF) + 1) << 1; + } + if (Data[3] == 0xBD && ((Payload[0] & 0xF0) == 0x80) && Payload[4] == 0x0B && Payload[5] == 0x77 && framesize > 0) { if (TrackIndex) *TrackIndex = Payload[0] - 0x80; @@ -1860,6 +1872,7 @@ int done = 6 + 3 + Data[8]; int todo = Count - done; const uchar *data = Data + done; + unsigned short size; // look for 0x0B 0x77 while (todo > 0) { @@ -1906,7 +1919,12 @@ state++; continue; case get_length: - ac3todo = 2 * frameSizes[*data]; + if (((*(data + 1) >> 3) & 0x1f) <= 10) + ac3todo = 2 * frameSizes[*data]; + else { + size = chk2 + chk1 * 256; + ac3todo = ((size & 0x07FF) + 1) << 1; + } // frameSizeCode was invalid => restart searching if (ac3todo <= 0) { // reset PES header instead of using a wrong one @@ -1971,6 +1989,10 @@ int cDolbyRepacker::BreakAt(const uchar *Data, int Count) { + bool ac3; + int framesize; + unsigned short size; + if (initiallySyncing) return -1; // fill the packet buffer completely until we have synced once // enough data for test? @@ -1984,12 +2006,20 @@ if (ac3todo > 0) return headerLen + ac3todo; // enough data for test? - if (Count < headerLen + 5) + if (Count < headerLen + 6) return -1; const uchar *data = Data + headerLen; // break after ac3 frame? - if (data[0] == 0x0B && data[1] == 0x77 && frameSizes[data[4]] > 0) - return headerLen + 2 * frameSizes[data[4]]; + ac3 = ((data[5] >> 3) & 0x1f) <= 10; + if ( ac3) + framesize = 2 * frameSizes[data[4]]; + else { + size = data[3] + data[2] * 256; + framesize = ((size & 0x07FF) + 1) << 1; + } + if (data[0] == 0x0B && data[1] == 0x77 && framesize > 0) + return headerLen + framesize; + return -1; } ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Thanks for the test, In fact I am not in covered area so I work with sample given by a colleague who live in good area on our forum The sample is very fresh and works perfectly with xineliboutput + vdr-sxfe with patch xineliboutputeac3_4.diff plus patch ff_audio_decoder to downmix 5.1 to 2.0 Maybe is there "something" in TS who is different from your country. It should be also interesting to have report from Italian users who experiment this audio encoding (not all are xbmc user I hope) Have a nice evening Best regards Le Monday 27 September 2010 22:42:06 Jose Alberto Reguero, vous avez écrit : > I try the sample and don't work. I look into it. But you must try live tv > or samples made with the patches, to see if it work. I try here with a > channel whith eac3 with spectral extention and it work well. > > Jose Alberto ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
El Lunes 27 Septiembre 2010, dplu escribió: > Hi > > @Darren Salt > Oupss you're right, I had another old patch for e-ac3 support auto applied > I clean all now > > @Jose Alberto > By the way, we are two person having made same test : not working with this > sample of french DVB-T HD , here is detail given by ffplay > > sample : http://dl.free.fr/cMNuFuG8X > > Stream #0.0[0xdc]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR 16:9], > 50 fps, 50 tbr, 90k tbn, 50 tbc > Stream #0.1[0xe7](qaa): Audio: eac3, 48000 Hz, 5.1, s16, 256 kb/s > Stream #0.2[0xe6](fra): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s > Stream #0.3[0xf0](fra): Subtitle: dvbsub > > Can you please test this small file (48 Mo) and tell us if OK or not, this > should be a good direction to go. I will rebuild a full new dev env on my > machine > > Many thanks for your help > > Best regards > I try the sample and don't work. I look into it. But you must try live tv or samples made with the patches, to see if it work. I try here with a channel whith eac3 with spectral extention and it work well. Jose Alberto > Le Sunday 26 September 2010 20:56:32 Darren Salt, vous avez écrit : > > I demand that dplu may or may not have written... > > > > [snip] > > > > > http://hg.debian.org/hg/xine-lib/xine-lib-1.2/ > > > is not allways well synchronized, for example the patch for demux_ts on > > > 1.1.18 changeset a1ba73e0b475 (april 9) is not on 1.2 > > > > It is... > > > > [snip] > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi @Darren Salt Oupss you're right, I had another old patch for e-ac3 support auto applied I clean all now @Jose Alberto By the way, we are two person having made same test : not working with this sample of french DVB-T HD , here is detail given by ffplay sample : http://dl.free.fr/cMNuFuG8X Stream #0.0[0xdc]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc Stream #0.1[0xe7](qaa): Audio: eac3, 48000 Hz, 5.1, s16, 256 kb/s Stream #0.2[0xe6](fra): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s Stream #0.3[0xf0](fra): Subtitle: dvbsub Can you please test this small file (48 Mo) and tell us if OK or not, this should be a good direction to go. I will rebuild a full new dev env on my machine Many thanks for your help Best regards Le Sunday 26 September 2010 20:56:32 Darren Salt, vous avez écrit : > I demand that dplu may or may not have written... > > [snip] > > > http://hg.debian.org/hg/xine-lib/xine-lib-1.2/ > > is not allways well synchronized, for example the patch for demux_ts on > > 1.1.18 changeset a1ba73e0b475 (april 9) is not on 1.2 > > It is... > > [snip] ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
I demand that dplu may or may not have written... [snip] > http://hg.debian.org/hg/xine-lib/xine-lib-1.2/ > is not allways well synchronized, for example the patch for demux_ts on > 1.1.18 changeset a1ba73e0b475 (april 9) is not on 1.2 It is... [snip] -- | Darren Salt| linux at youmustbejoking | nr. Ashington, | Toon | using Debian GNU/Linux | or ds,demon,co,uk| Northumberland | back! | + Output *more* particulate pollutants. BUFFER AGAINST GLOBAL WARMING. I am not young enough to know everything. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
El Domingo 26 Septiembre 2010, dplu escribió: > Hi > > I Just test your patch, thanks for it, it applied well but seems not > working, no e-ac3 sound on sample e-ac3 record for French DVB-T but AC3 > sound is still OK > > Which xine-lib 1.2 did you use ? this one : > http://hg.debian.org/hg/xine-lib/xine-lib-1.2/ > is not allways well synchronized, for example the patch for demux_ts on > 1.1.18 changeset a1ba73e0b475 (april 9) is not on 1.2 > > I will check another time to see if I made no error on patching > > Regards > You need a recent ffmpeg. I use latest hg xine-lib-1.2, and latest ffmpeg svn. Jose Alberto. > Le Tuesday 21 September 2010 00:57:39 Jose Alberto Reguero, vous avez écrit : > > El Domingo, 13 de Junio de 2010, Luca Olivetti escribió: > > > Al 25/03/10 16:08, En/na Jose Alberto Reguero ha escrit: > > > > Patch for xine-lib that don't need to patch remux.c to work. > > > > > > Today I applied this patch (strange it isn't in xine-lib-1.2 yet) but > > > there's still no sound on tvehd (vdr 1.7.15, vdr-xine and playing the > > > ts directly through xine). > > > Do I need some special options to configure xine-lib for this patch to > > > take effect? > > > > > > Bye > > > > With this two patches vdr-xine work with eac3. I can't test if it still > > work with normal ac3. One patch is for the plugin, and the other is for > > xine-lib 1.2. > > > > Jose Alberto > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi I Just test your patch, thanks for it, it applied well but seems not working, no e-ac3 sound on sample e-ac3 record for French DVB-T but AC3 sound is still OK Which xine-lib 1.2 did you use ? this one : http://hg.debian.org/hg/xine-lib/xine-lib-1.2/ is not allways well synchronized, for example the patch for demux_ts on 1.1.18 changeset a1ba73e0b475 (april 9) is not on 1.2 I will check another time to see if I made no error on patching Regards Le Tuesday 21 September 2010 00:57:39 Jose Alberto Reguero, vous avez écrit : > El Domingo, 13 de Junio de 2010, Luca Olivetti escribió: > > Al 25/03/10 16:08, En/na Jose Alberto Reguero ha escrit: > > > Patch for xine-lib that don't need to patch remux.c to work. > > > > Today I applied this patch (strange it isn't in xine-lib-1.2 yet) but > > there's still no sound on tvehd (vdr 1.7.15, vdr-xine and playing the ts > > directly through xine). > > Do I need some special options to configure xine-lib for this patch to > > take effect? > > > > Bye > > With this two patches vdr-xine work with eac3. I can't test if it still > work with normal ac3. One patch is for the plugin, and the other is for > xine-lib 1.2. > > Jose Alberto ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
El Domingo, 13 de Junio de 2010, Luca Olivetti escribió: > Al 25/03/10 16:08, En/na Jose Alberto Reguero ha escrit: > > Patch for xine-lib that don't need to patch remux.c to work. > > Today I applied this patch (strange it isn't in xine-lib-1.2 yet) but > there's still no sound on tvehd (vdr 1.7.15, vdr-xine and playing the ts > directly through xine). > Do I need some special options to configure xine-lib for this patch to > take effect? > > Bye With this two patches vdr-xine work with eac3. I can't test if it still work with normal ac3. One patch is for the plugin, and the other is for xine-lib 1.2. Jose Alberto diff -ur xine-0.9.3/vdr172remux.c xine-0.9.3.new/vdr172remux.c --- xine-0.9.3/vdr172remux.c 2009-04-12 13:52:32.0 +0200 +++ xine-0.9.3.new/vdr172remux.c 2010-09-20 23:49:10.19914 +0200 @@ -1703,8 +1703,17 @@ const uchar *Payload = Data + PesPayloadOffset; const int PayloadCount = Count - PesPayloadOffset; + bool ac3; + int framesize; - if (Data[3] == 0xBD && PayloadCount >= 9 && ((Payload[0] & 0xF0) == 0x80) && Payload[4] == 0x0B && Payload[5] == 0x77 && frameSizes[Payload[8]] > 0) { + if (PayloadCount < 10) + return -1; + ac3 = ((Payload[9] >> 3) & 0x1f) <= 10; + if ( ac3) + framesize = frameSizes[Payload[8]]; + else + framesize = (Payload[7] + 1) << 1; + if (Data[3] == 0xBD && ((Payload[0] & 0xF0) == 0x80) && Payload[4] == 0x0B && Payload[5] == 0x77 && framesize > 0) { if (TrackIndex) *TrackIndex = Payload[0] - 0x80; @@ -1906,7 +1915,10 @@ state++; continue; case get_length: - ac3todo = 2 * frameSizes[*data]; + if (((*(data + 1) >> 3) & 0x1f) <= 10) + ac3todo = 2 * frameSizes[*data]; + else + ac3todo = (*(data - 1) + 1) << 1; // frameSizeCode was invalid => restart searching if (ac3todo <= 0) { // reset PES header instead of using a wrong one @@ -1971,6 +1983,9 @@ int cDolbyRepacker::BreakAt(const uchar *Data, int Count) { + bool ac3; + int framesize; + if (initiallySyncing) return -1; // fill the packet buffer completely until we have synced once // enough data for test? @@ -1984,12 +1999,18 @@ if (ac3todo > 0) return headerLen + ac3todo; // enough data for test? - if (Count < headerLen + 5) + if (Count < headerLen + 6) return -1; const uchar *data = Data + headerLen; // break after ac3 frame? - if (data[0] == 0x0B && data[1] == 0x77 && frameSizes[data[4]] > 0) - return headerLen + 2 * frameSizes[data[4]]; + ac3 = ((data[5] >> 3) & 0x1f) <= 10; + if ( ac3) + framesize = 2 * frameSizes[data[4]]; + else + framesize = (data[3] + 1) << 1; + if (data[0] == 0x0B && data[1] == 0x77 && framesize > 0) + return headerLen + framesize; + return -1; } diff -r 9679028a161b src/demuxers/demux_mpeg_pes.c --- a/src/demuxers/demux_mpeg_pes.c Wed Jul 21 15:52:00 2010 + +++ b/src/demuxers/demux_mpeg_pes.c Tue Sep 21 00:54:22 2010 +0200 @@ -103,6 +103,7 @@ uint8_t preview_data[ MAX_PREVIEW_SIZE ]; off_t preview_size, preview_done; + uint8_t preview_eac3; } demux_mpeg_pes_t ; typedef struct { @@ -931,10 +932,21 @@ buf->content = p+4; buf->size = this->packet_len-4; - if (track & 0x8) { -buf->type = BUF_AUDIO_DTS + (track & 0x07); /* DVDs only have 8 tracks */ + if (((p[9] >> 3) & 0x1f) <= 10) { +if (track & 0x8) { + buf->type = BUF_AUDIO_DTS + (track & 0x07); /* DVDs only have 8 tracks */ +} else { + buf->type = BUF_AUDIO_A52 + track; +} } else { -buf->type = BUF_AUDIO_A52 + track; +buf->type = BUF_AUDIO_EAC3; +if (this->preview_eac3 < 2) + this->preview_eac3++; +if (this->preview_eac3 == 1) + buf->decoder_flags = BUF_FLAG_HEADER | BUF_FLAG_FRAME_END; +else { + buf->decoder_flags |= BUF_FLAG_FRAME_END; +} } buf->pts = this->pts; if( !this->preview_mode ) @@ -1548,6 +1560,7 @@ */ this->last_cell_time = 0; this->send_newpts = 1; + this->preview_eac3 = 0; if( !playing ) { this->buf_flag_seek = 0; ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
El Domingo, 13 de Junio de 2010, Luca Olivetti escribió: > Al 25/03/10 16:08, En/na Jose Alberto Reguero ha escrit: > > Patch for xine-lib that don't need to patch remux.c to work. > > Today I applied this patch (strange it isn't in xine-lib-1.2 yet) but > there's still no sound on tvehd (vdr 1.7.15, vdr-xine and playing the ts > directly through xine). > Do I need some special options to configure xine-lib for this patch to > take effect? > > Bye I use the latest xine-lib hg without patches and xineliboutput with the attached patch. Live TV are ok, but the recordings have drop outs. vdr-xine don't work with eac3. Jose Alberto Index: xine/ts2es.c === RCS file: /cvsroot/xineliboutput/vdr-xineliboutput/xine/ts2es.c,v retrieving revision 1.12 diff -r1.12 ts2es.c 33a34 > intnumpreview; 165,169c166,181 < < this->buf->decoder_flags |= BUF_FLAG_FRAME_END; < < result = this->buf; < this->buf = NULL; --- > if (!this->video) { > if (this->numpreview<5) > this->numpreview++; > if (this->numpreview == 1) > this->buf->decoder_flags = BUF_FLAG_HEADER | BUF_FLAG_FRAME_END; > else if (this->numpreview < 5) > this->buf->decoder_flags = BUF_FLAG_PREVIEW; > else > this->buf->decoder_flags |= BUF_FLAG_FRAME_END; > result = this->buf; > this->buf = NULL; > } else { > this->buf->decoder_flags |= BUF_FLAG_FRAME_END; > result = this->buf; > this->buf = NULL; > } 177d188 < 313a325,326 > data->numpreview=0; > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Al 25/03/10 16:08, En/na Jose Alberto Reguero ha escrit: Patch for xine-lib that don't need to patch remux.c to work. Today I applied this patch (strange it isn't in xine-lib-1.2 yet) but there's still no sound on tvehd (vdr 1.7.15, vdr-xine and playing the ts directly through xine). Do I need some special options to configure xine-lib for this patch to take effect? Bye -- Luca ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
hello, i do that but no change. I try another thing: i convert the sample ts of vdr recording to mkv and rebuild xine-lib without your patch to test and it's the same: stereo is good but 5.0 is bad. I think xine-lib eac3 only support stereo at this time. see you. Selon Jose Alberto Reguero : > Yes, the file is ff_audio_decoder.c > You must put the line > this->context->request_channels = 2; > after > this->context->codec_tag = _x_stream_info_get(this->stream, > XINE_STREAM_INFO_AUDIO_FOURCC); > > Jose Alberto > > El Sábado, 27 de Marzo de 2010, zaverel escribió: > > Is ff_audio_decoder.c to patch ? > > I try but that change nothing. > > > > Le 26/03/2010 13:12, Jose Alberto Reguero a écrit : > > > You can add the line: > > > > > > this->context->request_channels = 2; > > > > > > in line 247 and 295. > > > > > > Then you have stereo sound. > > > > > > Joae Alberto > > > > > > El Viernes, 26 de Marzo de 2010, zaverel escribió: > > >> After some test there are some issue: > > >> ramdom crash at start up or without sound. > > >> But the real probleme i think is with 5.0 sound. > > >> > > >> In the sample the 2.0 audio out is good > > >> but the 5.0 has low volume and metallic sound > > >> > > >> just try xine > > >> fra piste 5.0 > > >> ffmpeg_audio_dec: unknown header with buf type 0x300 > > >> > > >> qaa 2.0 > > >> is good > > >> > > >> ffmpeg -i 1.ts > > >> ... > > >> > > >> Input #0, mpegts, from '1.ts': > > >> Duration: 00:02:10.51, start: 10461.634989, bitrate: 6905 kb/s > > >> Program 132 > > >> > > >> Stream #0.0[0x78]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR > > >> > > >> 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc > > >> > > >> Stream #0.1[0x82](fra): Audio: eac3, 48000 Hz, 5.0, s16, 256 kb/s > > >> Stream #0.2[0x83](qaa): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s > > >> Stream #0.3[0x8c](fra): Subtitle: dvbsub > > >> Stream #0.4[0x8d](fra): Subtitle: dvbsub > > >> > > >> Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : > > >>> Patch for xine-lib that don't need to patch remux.c to work. > > >>> > > >>> Jose Alberto > > >>> > > >>> El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > > Patch against latest xine-lib-1.2. New patch for xineliboutput. Now > > must work if you patch remux.c. > > You must have the latest xine-lib and xineliboutput. Yesterday both > > have changes about eac3. > > > > Jose Alberto > > > > El Jueves, 25 de Marzo de 2010, zaverel escribió: > > > The typo was on remux.c => lost : and ; > > > > > > Anyway xine-lib has been updated and your patch don't apply. > > > > > > Update is for eac3 with mkv > > > > > > i don't test it yet > > > > > > > > > > > > corrected remux.c > > > > > > line 533 > > > case SI::AC3DescriptorTag: > > > +case SI::EnhancedAC3DescriptorTag: > > > > > > > > > and in line 191: > > > > > > -Target[i++] = SI::AC3DescriptorTag; > > > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > > > Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > > >> I attached a second version of the first patch. > > >> I make the same changes that in the second patch, but maintaining > > >> the logic of the first patch. Also I commented the line: > > >> +//this->context->request_channels = 2; > > >> because your example has 5 channels. If you have trouble with that > > >> you can comment the line again. > > >> Which typo error has the second patch? > > >> > > >> Jose Alberto > > >> > > >> El Miércoles, 24 de Marzo de 2010, zaverel escribió: > > >>> i 've patched pat.c and now remux.c > > >>> and with use xine-lib-1.2 with your second patch (who has typo > > >>> error) and that doesn't work. > > >>> > > >>> corrected remux.c > > >>> > > >>> line 533 > > >>> case SI::AC3DescriptorTag: > > >>> +case SI::EnhancedAC3DescriptorTag: > > >>> > > >>> > > >>> and in line 191: > > >>> > > >>> -Target[i++] = SI::AC3DescriptorTag; > > >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; > > >>> > > >>> > > >>> > > >>> with your previously patch and just pat.c patched with > > >>> line 402 > > >>> > > >>> case SI::AC3DescriptorTag: > > >>> +case SI:EnhancedAC3DescriptorTag: > > >>> > > >>> that worked but not stable. > > >>> > > >>> Is your sample eac3 has |"Spectral extension" ? > > >>> because in france dvb-t with eac3 has it > > >>> and need a ffmpeg patched for that. > > >>> And i test with that sound. > > >>> > > >>> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > > It works here with a old sample of tdt with eac3. Have you patch > > also remux.c? You need to change in line 533: > > > > case SI::AC3DescriptorTag: > > +case SI:EnhancedAC3DescriptorTag: > > >
Re: [vdr] vdr xine-lib eac3
Yes, the file is ff_audio_decoder.c You must put the line this->context->request_channels = 2; after this->context->codec_tag = _x_stream_info_get(this->stream, XINE_STREAM_INFO_AUDIO_FOURCC); Jose Alberto El Sábado, 27 de Marzo de 2010, zaverel escribió: > Is ff_audio_decoder.c to patch ? > I try but that change nothing. > > Le 26/03/2010 13:12, Jose Alberto Reguero a écrit : > > You can add the line: > > > > this->context->request_channels = 2; > > > > in line 247 and 295. > > > > Then you have stereo sound. > > > > Joae Alberto > > > > El Viernes, 26 de Marzo de 2010, zaverel escribió: > >> After some test there are some issue: > >> ramdom crash at start up or without sound. > >> But the real probleme i think is with 5.0 sound. > >> > >> In the sample the 2.0 audio out is good > >> but the 5.0 has low volume and metallic sound > >> > >> just try xine > >> fra piste 5.0 > >> ffmpeg_audio_dec: unknown header with buf type 0x300 > >> > >> qaa 2.0 > >> is good > >> > >> ffmpeg -i 1.ts > >> ... > >> > >> Input #0, mpegts, from '1.ts': > >> Duration: 00:02:10.51, start: 10461.634989, bitrate: 6905 kb/s > >> Program 132 > >> > >> Stream #0.0[0x78]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR > >> > >> 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc > >> > >> Stream #0.1[0x82](fra): Audio: eac3, 48000 Hz, 5.0, s16, 256 kb/s > >> Stream #0.2[0x83](qaa): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s > >> Stream #0.3[0x8c](fra): Subtitle: dvbsub > >> Stream #0.4[0x8d](fra): Subtitle: dvbsub > >> > >> Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : > >>> Patch for xine-lib that don't need to patch remux.c to work. > >>> > >>> Jose Alberto > >>> > >>> El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > Patch against latest xine-lib-1.2. New patch for xineliboutput. Now > must work if you patch remux.c. > You must have the latest xine-lib and xineliboutput. Yesterday both > have changes about eac3. > > Jose Alberto > > El Jueves, 25 de Marzo de 2010, zaverel escribió: > > The typo was on remux.c => lost : and ; > > > > Anyway xine-lib has been updated and your patch don't apply. > > > > Update is for eac3 with mkv > > > > i don't test it yet > > > > > > > > corrected remux.c > > > > line 533 > > case SI::AC3DescriptorTag: > > +case SI::EnhancedAC3DescriptorTag: > > > > > > and in line 191: > > > > -Target[i++] = SI::AC3DescriptorTag; > > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > >> I attached a second version of the first patch. > >> I make the same changes that in the second patch, but maintaining > >> the logic of the first patch. Also I commented the line: > >> +//this->context->request_channels = 2; > >> because your example has 5 channels. If you have trouble with that > >> you can comment the line again. > >> Which typo error has the second patch? > >> > >> Jose Alberto > >> > >> El Miércoles, 24 de Marzo de 2010, zaverel escribió: > >>> i 've patched pat.c and now remux.c > >>> and with use xine-lib-1.2 with your second patch (who has typo > >>> error) and that doesn't work. > >>> > >>> corrected remux.c > >>> > >>> line 533 > >>> case SI::AC3DescriptorTag: > >>> +case SI::EnhancedAC3DescriptorTag: > >>> > >>> > >>> and in line 191: > >>> > >>> -Target[i++] = SI::AC3DescriptorTag; > >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; > >>> > >>> > >>> > >>> with your previously patch and just pat.c patched with > >>> line 402 > >>> > >>> case SI::AC3DescriptorTag: > >>> +case SI:EnhancedAC3DescriptorTag: > >>> > >>> that worked but not stable. > >>> > >>> Is your sample eac3 has |"Spectral extension" ? > >>> because in france dvb-t with eac3 has it > >>> and need a ffmpeg patched for that. > >>> And i test with that sound. > >>> > >>> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > It works here with a old sample of tdt with eac3. Have you patch > also remux.c? You need to change in line 533: > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag > > Jose Alberto > > El Miércoles, 24 de Marzo de 2010, dplu escribió: > > Hi > > > > I have made previous test with the version release by Petri > > Hintukainen > > > > And I notice this part is not working like it should > > > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||
Re: [vdr] vdr xine-lib eac3
Is ff_audio_decoder.c to patch ? I try but that change nothing. Le 26/03/2010 13:12, Jose Alberto Reguero a écrit : > You can add the line: > > this->context->request_channels = 2; > > in line 247 and 295. > > Then you have stereo sound. > > Joae Alberto > > El Viernes, 26 de Marzo de 2010, zaverel escribió: > >> After some test there are some issue: >> ramdom crash at start up or without sound. >> But the real probleme i think is with 5.0 sound. >> >> In the sample the 2.0 audio out is good >> but the 5.0 has low volume and metallic sound >> >> just try xine >> fra piste 5.0 >> ffmpeg_audio_dec: unknown header with buf type 0x300 >> >> qaa 2.0 >> is good >> >> ffmpeg -i 1.ts >> ... >> Input #0, mpegts, from '1.ts': >> Duration: 00:02:10.51, start: 10461.634989, bitrate: 6905 kb/s >> Program 132 >> Stream #0.0[0x78]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR >> 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc >> Stream #0.1[0x82](fra): Audio: eac3, 48000 Hz, 5.0, s16, 256 kb/s >> Stream #0.2[0x83](qaa): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s >> Stream #0.3[0x8c](fra): Subtitle: dvbsub >> Stream #0.4[0x8d](fra): Subtitle: dvbsub >> >> Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : >> >>> Patch for xine-lib that don't need to patch remux.c to work. >>> >>> Jose Alberto >>> >>> El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: >>> Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must work if you patch remux.c. You must have the latest xine-lib and xineliboutput. Yesterday both have changes about eac3. Jose Alberto El Jueves, 25 de Marzo de 2010, zaverel escribió: > The typo was on remux.c => lost : and ; > > Anyway xine-lib has been updated and your patch don't apply. > > Update is for eac3 with mkv > > i don't test it yet > > > > corrected remux.c > > line 533 > case SI::AC3DescriptorTag: > +case SI::EnhancedAC3DescriptorTag: > > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > >> I attached a second version of the first patch. >> I make the same changes that in the second patch, but maintaining the >> logic of the first patch. Also I commented the line: >> +//this->context->request_channels = 2; >> because your example has 5 channels. If you have trouble with that you >> can comment the line again. >> Which typo error has the second patch? >> >> Jose Alberto >> >> El Miércoles, 24 de Marzo de 2010, zaverel escribió: >> >>> i 've patched pat.c and now remux.c >>> and with use xine-lib-1.2 with your second patch (who has typo error) >>> and that doesn't work. >>> >>> corrected remux.c >>> >>> line 533 >>> case SI::AC3DescriptorTag: >>> +case SI::EnhancedAC3DescriptorTag: >>> >>> >>> and in line 191: >>> >>> -Target[i++] = SI::AC3DescriptorTag; >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; >>> >>> >>> >>> with your previously patch and just pat.c patched with >>> line 402 >>> >>> case SI::AC3DescriptorTag: >>> +case SI:EnhancedAC3DescriptorTag: >>> >>> that worked but not stable. >>> >>> Is your sample eac3 has |"Spectral extension" ? >>> because in france dvb-t with eac3 has it >>> and need a ffmpeg patched for that. >>> And i test with that sound. >>> >>> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : >>> It works here with a old sample of tdt with eac3. Have you patch also remux.c? You need to change in line 533: case SI::AC3DescriptorTag: +case SI:EnhancedAC3DescriptorTag: and in line 191: -Target[i++] = SI::AC3DescriptorTag; +Target[i++] = SI::EnhancedAC3DescriptorTag Jose Alberto El Miércoles, 24 de Marzo de 2010, dplu escribió: > Hi > > I have made previous test with the version release by Petri > Hintukainen > > And I notice this part is not working like it should > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw > */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > + m->content = p; > + m->size = packet_len; > + m->type |= BUF_AUDIO_EAC3; > + return 1; > + > +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 > - raw */ > > unfortunaletly, in AC3 or E-AC3 , the descriptor tag is > STREAM_AUDIO_AC3, so the program never run the first if (installed > a
Re: [vdr] vdr xine-lib eac3
You can add the line: this->context->request_channels = 2; in line 247 and 295. Then you have stereo sound. Joae Alberto El Viernes, 26 de Marzo de 2010, zaverel escribió: > After some test there are some issue: > ramdom crash at start up or without sound. > But the real probleme i think is with 5.0 sound. > > In the sample the 2.0 audio out is good > but the 5.0 has low volume and metallic sound > > just try xine > fra piste 5.0 > ffmpeg_audio_dec: unknown header with buf type 0x300 > > qaa 2.0 > is good > > ffmpeg -i 1.ts > ... > Input #0, mpegts, from '1.ts': > Duration: 00:02:10.51, start: 10461.634989, bitrate: 6905 kb/s > Program 132 > Stream #0.0[0x78]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR > 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc > Stream #0.1[0x82](fra): Audio: eac3, 48000 Hz, 5.0, s16, 256 kb/s > Stream #0.2[0x83](qaa): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s > Stream #0.3[0x8c](fra): Subtitle: dvbsub > Stream #0.4[0x8d](fra): Subtitle: dvbsub > > Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : > > Patch for xine-lib that don't need to patch remux.c to work. > > > > Jose Alberto > > > > El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > >> Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must > >> work if you patch remux.c. > >> You must have the latest xine-lib and xineliboutput. Yesterday both have > >> changes about eac3. > >> > >> Jose Alberto > >> > >> El Jueves, 25 de Marzo de 2010, zaverel escribió: > >>> The typo was on remux.c => lost : and ; > >>> > >>> Anyway xine-lib has been updated and your patch don't apply. > >>> > >>> Update is for eac3 with mkv > >>> > >>> i don't test it yet > >>> > >>> > >>> > >>> corrected remux.c > >>> > >>> line 533 > >>> case SI::AC3DescriptorTag: > >>> +case SI::EnhancedAC3DescriptorTag: > >>> > >>> > >>> and in line 191: > >>> > >>> -Target[i++] = SI::AC3DescriptorTag; > >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; > >>> > >>> Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > I attached a second version of the first patch. > I make the same changes that in the second patch, but maintaining the > logic of the first patch. Also I commented the line: > +//this->context->request_channels = 2; > because your example has 5 channels. If you have trouble with that you > can comment the line again. > Which typo error has the second patch? > > Jose Alberto > > El Miércoles, 24 de Marzo de 2010, zaverel escribió: > > i 've patched pat.c and now remux.c > > and with use xine-lib-1.2 with your second patch (who has typo error) > > and that doesn't work. > > > > corrected remux.c > > > > line 533 > > case SI::AC3DescriptorTag: > > +case SI::EnhancedAC3DescriptorTag: > > > > > > and in line 191: > > > > -Target[i++] = SI::AC3DescriptorTag; > > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > > > > > with your previously patch and just pat.c patched with > > line 402 > > > > case SI::AC3DescriptorTag: > > +case SI:EnhancedAC3DescriptorTag: > > > > that worked but not stable. > > > > Is your sample eac3 has |"Spectral extension" ? > > because in france dvb-t with eac3 has it > > and need a ffmpeg patched for that. > > And i test with that sound. > > > > Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > >> It works here with a old sample of tdt with eac3. Have you patch > >> also remux.c? You need to change in line 533: > >> > >> case SI::AC3DescriptorTag: > >> +case SI:EnhancedAC3DescriptorTag: > >> > >> and in line 191: > >> > >> -Target[i++] = SI::AC3DescriptorTag; > >> +Target[i++] = SI::EnhancedAC3DescriptorTag > >> > >> Jose Alberto > >> > >> El Miércoles, 24 de Marzo de 2010, dplu escribió: > >>> Hi > >>> > >>> I have made previous test with the version release by Petri > >>> Hintukainen > >>> > >>> And I notice this part is not working like it should > >>> > >>> -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw > >>> */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > >>> + m->content = p; > >>> + m->size = packet_len; > >>> + m->type |= BUF_AUDIO_EAC3; > >>> + return 1; > >>> + > >>> +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 > >>> - raw */ > >>> > >>> unfortunaletly, in AC3 or E-AC3 , the descriptor tag is > >>> STREAM_AUDIO_AC3, so the program never run the first if (installed > >>> a debug printf here) > >>> > >>> It seems that your first approach (at least what I understood) by > >>> forcing the decoding of all AC-3 stream by ffmepg instead of > >>> internal lib was nice but generate violent segfault on li
Re: [vdr] vdr xine-lib eac3
After some test there are some issue: ramdom crash at start up or without sound. But the real probleme i think is with 5.0 sound. In the sample the 2.0 audio out is good but the 5.0 has low volume and metallic sound just try xine fra piste 5.0 ffmpeg_audio_dec: unknown header with buf type 0x300 qaa 2.0 is good ffmpeg -i 1.ts ... Input #0, mpegts, from '1.ts': Duration: 00:02:10.51, start: 10461.634989, bitrate: 6905 kb/s Program 132 Stream #0.0[0x78]: Video: h264, yuv420p, 1440x1080 [PAR 4:3 DAR 16:9], 50 fps, 50 tbr, 90k tbn, 50 tbc Stream #0.1[0x82](fra): Audio: eac3, 48000 Hz, 5.0, s16, 256 kb/s Stream #0.2[0x83](qaa): Audio: eac3, 48000 Hz, stereo, s16, 128 kb/s Stream #0.3[0x8c](fra): Subtitle: dvbsub Stream #0.4[0x8d](fra): Subtitle: dvbsub Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : > Patch for xine-lib that don't need to patch remux.c to work. > > Jose Alberto > > El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > >> Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must >> work if you patch remux.c. >> You must have the latest xine-lib and xineliboutput. Yesterday both have >> changes about eac3. >> >> Jose Alberto >> >> El Jueves, 25 de Marzo de 2010, zaverel escribió: >> >>> The typo was on remux.c => lost : and ; >>> >>> Anyway xine-lib has been updated and your patch don't apply. >>> >>> Update is for eac3 with mkv >>> >>> i don't test it yet >>> >>> >>> >>> corrected remux.c >>> >>> line 533 >>> case SI::AC3DescriptorTag: >>> +case SI::EnhancedAC3DescriptorTag: >>> >>> >>> and in line 191: >>> >>> -Target[i++] = SI::AC3DescriptorTag; >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; >>> >>> Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : >>> I attached a second version of the first patch. I make the same changes that in the second patch, but maintaining the logic of the first patch. Also I commented the line: +//this->context->request_channels = 2; because your example has 5 channels. If you have trouble with that you can comment the line again. Which typo error has the second patch? Jose Alberto El Miércoles, 24 de Marzo de 2010, zaverel escribió: > i 've patched pat.c and now remux.c > and with use xine-lib-1.2 with your second patch (who has typo error) > and that doesn't work. > > corrected remux.c > > line 533 > case SI::AC3DescriptorTag: > +case SI::EnhancedAC3DescriptorTag: > > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > with your previously patch and just pat.c patched with > line 402 > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > that worked but not stable. > > Is your sample eac3 has |"Spectral extension" ? > because in france dvb-t with eac3 has it > and need a ffmpeg patched for that. > And i test with that sound. > > Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > >> It works here with a old sample of tdt with eac3. Have you patch also >> remux.c? You need to change in line 533: >> >> case SI::AC3DescriptorTag: >> +case SI:EnhancedAC3DescriptorTag: >> >> and in line 191: >> >> -Target[i++] = SI::AC3DescriptorTag; >> +Target[i++] = SI::EnhancedAC3DescriptorTag >> >> Jose Alberto >> >> El Miércoles, 24 de Marzo de 2010, dplu escribió: >> >>> Hi >>> >>> I have made previous test with the version release by Petri >>> Hintukainen >>> >>> And I notice this part is not working like it should >>> >>> -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw >>> */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { >>> + m->content = p; >>> + m->size = packet_len; >>> + m->type |= BUF_AUDIO_EAC3; >>> + return 1; >>> + >>> +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 >>> - raw */ >>> >>> unfortunaletly, in AC3 or E-AC3 , the descriptor tag is >>> STREAM_AUDIO_AC3, so the program never run the first if (installed a >>> debug printf here) >>> >>> It seems that your first approach (at least what I understood) by >>> forcing the decoding of all AC-3 stream by ffmepg instead of >>> internal lib was nice but generate violent segfault on libavcodec >>> >>> Hope this help you >>> >>> Best regards >>> >>> PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg >>> or xine-lib) >>> >>> Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : >>> hello your second patch doesn't work : no sound on eac3 channel if you want there is a sample
Re: [vdr] vdr xine-lib eac3
Yes ! that work just with your last patch xine-eac3_5.diff and without had to patch xineliboutput. i do my last test with vdr-1.7.14 and patch pat.c line 402 case SI::AC3DescriptorTag: +case SI:EnhancedAC3DescriptorTag: just don't forget to activate "dolby digital" in vdr settings Thank you for your work. now remains to see if it's stable Le 25/03/2010 16:08, Jose Alberto Reguero a écrit : > Patch for xine-lib that don't need to patch remux.c to work. > > Jose Alberto > > El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > >> Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must >> work if you patch remux.c. >> You must have the latest xine-lib and xineliboutput. Yesterday both have >> changes about eac3. >> >> Jose Alberto >> >> El Jueves, 25 de Marzo de 2010, zaverel escribió: >> >>> The typo was on remux.c => lost : and ; >>> >>> Anyway xine-lib has been updated and your patch don't apply. >>> >>> Update is for eac3 with mkv >>> >>> i don't test it yet >>> >>> >>> >>> corrected remux.c >>> >>> line 533 >>> case SI::AC3DescriptorTag: >>> +case SI::EnhancedAC3DescriptorTag: >>> >>> >>> and in line 191: >>> >>> -Target[i++] = SI::AC3DescriptorTag; >>> +Target[i++] = SI::EnhancedAC3DescriptorTag; >>> >>> Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : >>> I attached a second version of the first patch. I make the same changes that in the second patch, but maintaining the logic of the first patch. Also I commented the line: +//this->context->request_channels = 2; because your example has 5 channels. If you have trouble with that you can comment the line again. Which typo error has the second patch? Jose Alberto El Miércoles, 24 de Marzo de 2010, zaverel escribió: > i 've patched pat.c and now remux.c > and with use xine-lib-1.2 with your second patch (who has typo error) > and that doesn't work. > > corrected remux.c > > line 533 > case SI::AC3DescriptorTag: > +case SI::EnhancedAC3DescriptorTag: > > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > with your previously patch and just pat.c patched with > line 402 > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > that worked but not stable. > > Is your sample eac3 has |"Spectral extension" ? > because in france dvb-t with eac3 has it > and need a ffmpeg patched for that. > And i test with that sound. > > Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > >> It works here with a old sample of tdt with eac3. Have you patch also >> remux.c? You need to change in line 533: >> >> case SI::AC3DescriptorTag: >> +case SI:EnhancedAC3DescriptorTag: >> >> and in line 191: >> >> -Target[i++] = SI::AC3DescriptorTag; >> +Target[i++] = SI::EnhancedAC3DescriptorTag >> >> Jose Alberto >> >> El Miércoles, 24 de Marzo de 2010, dplu escribió: >> >>> Hi >>> >>> I have made previous test with the version release by Petri >>> Hintukainen >>> >>> And I notice this part is not working like it should >>> >>> -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw >>> */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { >>> + m->content = p; >>> + m->size = packet_len; >>> + m->type |= BUF_AUDIO_EAC3; >>> + return 1; >>> + >>> +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 >>> - raw */ >>> >>> unfortunaletly, in AC3 or E-AC3 , the descriptor tag is >>> STREAM_AUDIO_AC3, so the program never run the first if (installed a >>> debug printf here) >>> >>> It seems that your first approach (at least what I understood) by >>> forcing the decoding of all AC-3 stream by ffmepg instead of >>> internal lib was nice but generate violent segfault on libavcodec >>> >>> Hope this help you >>> >>> Best regards >>> >>> PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg >>> or xine-lib) >>> >>> Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : >>> hello your second patch doesn't work : no sound on eac3 channel if you want there is a sample of vdr hd-eac3 recording here: http://dl.free.fr/ew4rJddM8 103mo else , i don't know what mailing-list is the more indicate for debuging the vdr or xine-dev mailing-list ? ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Patch for xine-lib that don't need to patch remux.c to work. Jose Alberto El Jueves, 25 de Marzo de 2010, Jose Alberto Reguero escribió: > Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must > work if you patch remux.c. > You must have the latest xine-lib and xineliboutput. Yesterday both have > changes about eac3. > > Jose Alberto > > El Jueves, 25 de Marzo de 2010, zaverel escribió: > > The typo was on remux.c => lost : and ; > > > > Anyway xine-lib has been updated and your patch don't apply. > > > > Update is for eac3 with mkv > > > > i don't test it yet > > > > > > > > corrected remux.c > > > > line 533 > > case SI::AC3DescriptorTag: > > +case SI::EnhancedAC3DescriptorTag: > > > > > > and in line 191: > > > > -Target[i++] = SI::AC3DescriptorTag; > > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > > > I attached a second version of the first patch. > > > I make the same changes that in the second patch, but maintaining the > > > logic of the first patch. Also I commented the line: > > > +//this->context->request_channels = 2; > > > because your example has 5 channels. If you have trouble with that you > > > can comment the line again. > > > Which typo error has the second patch? > > > > > > Jose Alberto > > > > > > El Miércoles, 24 de Marzo de 2010, zaverel escribió: > > >> i 've patched pat.c and now remux.c > > >> and with use xine-lib-1.2 with your second patch (who has typo error) > > >> and that doesn't work. > > >> > > >> corrected remux.c > > >> > > >> line 533 > > >> case SI::AC3DescriptorTag: > > >> +case SI::EnhancedAC3DescriptorTag: > > >> > > >> > > >> and in line 191: > > >> > > >> -Target[i++] = SI::AC3DescriptorTag; > > >> +Target[i++] = SI::EnhancedAC3DescriptorTag; > > >> > > >> > > >> > > >> with your previously patch and just pat.c patched with > > >> line 402 > > >> > > >> case SI::AC3DescriptorTag: > > >> +case SI:EnhancedAC3DescriptorTag: > > >> > > >> that worked but not stable. > > >> > > >> Is your sample eac3 has |"Spectral extension" ? > > >> because in france dvb-t with eac3 has it > > >> and need a ffmpeg patched for that. > > >> And i test with that sound. > > >> > > >> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > > >>> It works here with a old sample of tdt with eac3. Have you patch also > > >>> remux.c? You need to change in line 533: > > >>> > > >>> case SI::AC3DescriptorTag: > > >>> +case SI:EnhancedAC3DescriptorTag: > > >>> > > >>> and in line 191: > > >>> > > >>> -Target[i++] = SI::AC3DescriptorTag; > > >>> +Target[i++] = SI::EnhancedAC3DescriptorTag > > >>> > > >>> Jose Alberto > > >>> > > >>> El Miércoles, 24 de Marzo de 2010, dplu escribió: > > Hi > > > > I have made previous test with the version release by Petri > > Hintukainen > > > > And I notice this part is not working like it should > > > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw > > */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > > + m->content = p; > > + m->size = packet_len; > > + m->type |= BUF_AUDIO_EAC3; > > + return 1; > > + > > +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 > > - raw */ > > > > unfortunaletly, in AC3 or E-AC3 , the descriptor tag is > > STREAM_AUDIO_AC3, so the program never run the first if (installed a > > debug printf here) > > > > It seems that your first approach (at least what I understood) by > > forcing the decoding of all AC-3 stream by ffmepg instead of > > internal lib was nice but generate violent segfault on libavcodec > > > > Hope this help you > > > > Best regards > > > > PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg > > or xine-lib) > > > > Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > > > hello > > > > > > your second patch doesn't work : no sound on eac3 channel > > > > > > if you want there is a sample of vdr hd-eac3 recording here: > > > > > > http://dl.free.fr/ew4rJddM8 > > > > > > 103mo > > > > > > else , i don't know what mailing-list is the more indicate for > > > debuging > > > > > > the vdr or xine-dev mailing-list ? > > > > > > ___ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > >>> > > >>> ___ > > >>> vdr mailing list > > >>> vdr@linuxtv.org > > >>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > > > _
Re: [vdr] vdr xine-lib eac3
Patch against latest xine-lib-1.2. New patch for xineliboutput. Now must work if you patch remux.c. You must have the latest xine-lib and xineliboutput. Yesterday both have changes about eac3. Jose Alberto El Jueves, 25 de Marzo de 2010, zaverel escribió: > The typo was on remux.c => lost : and ; > > Anyway xine-lib has been updated and your patch don't apply. > > Update is for eac3 with mkv > > i don't test it yet > > > > corrected remux.c > > line 533 > case SI::AC3DescriptorTag: > +case SI::EnhancedAC3DescriptorTag: > > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > > I attached a second version of the first patch. > > I make the same changes that in the second patch, but maintaining the > > logic of the first patch. Also I commented the line: > > +//this->context->request_channels = 2; > > because your example has 5 channels. If you have trouble with that you > > can comment the line again. > > Which typo error has the second patch? > > > > Jose Alberto > > > > El Miércoles, 24 de Marzo de 2010, zaverel escribió: > >> i 've patched pat.c and now remux.c > >> and with use xine-lib-1.2 with your second patch (who has typo error) > >> and that doesn't work. > >> > >> corrected remux.c > >> > >> line 533 > >> case SI::AC3DescriptorTag: > >> +case SI::EnhancedAC3DescriptorTag: > >> > >> > >> and in line 191: > >> > >> -Target[i++] = SI::AC3DescriptorTag; > >> +Target[i++] = SI::EnhancedAC3DescriptorTag; > >> > >> > >> > >> with your previously patch and just pat.c patched with > >> line 402 > >> > >> case SI::AC3DescriptorTag: > >> +case SI:EnhancedAC3DescriptorTag: > >> > >> that worked but not stable. > >> > >> Is your sample eac3 has |"Spectral extension" ? > >> because in france dvb-t with eac3 has it > >> and need a ffmpeg patched for that. > >> And i test with that sound. > >> > >> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > >>> It works here with a old sample of tdt with eac3. Have you patch also > >>> remux.c? You need to change in line 533: > >>> > >>> case SI::AC3DescriptorTag: > >>> +case SI:EnhancedAC3DescriptorTag: > >>> > >>> and in line 191: > >>> > >>> -Target[i++] = SI::AC3DescriptorTag; > >>> +Target[i++] = SI::EnhancedAC3DescriptorTag > >>> > >>> Jose Alberto > >>> > >>> El Miércoles, 24 de Marzo de 2010, dplu escribió: > Hi > > I have made previous test with the version release by Petri > Hintukainen > > And I notice this part is not working like it should > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ > +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > + m->content = p; > + m->size = packet_len; > + m->type |= BUF_AUDIO_EAC3; > + return 1; > + > +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - > raw */ > > unfortunaletly, in AC3 or E-AC3 , the descriptor tag is > STREAM_AUDIO_AC3, so the program never run the first if (installed a > debug printf here) > > It seems that your first approach (at least what I understood) by > forcing the decoding of all AC-3 stream by ffmepg instead of internal > lib was nice but generate violent segfault on libavcodec > > Hope this help you > > Best regards > > PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg > or xine-lib) > > Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > > hello > > > > your second patch doesn't work : no sound on eac3 channel > > > > if you want there is a sample of vdr hd-eac3 recording here: > > > > http://dl.free.fr/ew4rJddM8 > > > > 103mo > > > > else , i don't know what mailing-list is the more indicate for > > debuging > > > > the vdr or xine-dev mailing-list ? > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > >>> > >>> ___ > >>> vdr mailing list > >>> vdr@linuxtv.org > >>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr Index: xine/ts2es.c === RCS file: /cvsroot/xineliboutput/vdr-xineliboutput/xine/ts2es.c,v retrieving revision 1.10 diff -r1.10 ts2es.c 78a79,84 > if (this->stream_type == STREAM_AUDIO_EAC3) { > this->xine_buf_type |= BUF_AUDIO_EAC3; >
Re: [vdr] vdr xine-lib eac3
The typo was on remux.c => lost : and ; Anyway xine-lib has been updated and your patch don't apply. Update is for eac3 with mkv i don't test it yet corrected remux.c line 533 case SI::AC3DescriptorTag: +case SI::EnhancedAC3DescriptorTag: and in line 191: -Target[i++] = SI::AC3DescriptorTag; +Target[i++] = SI::EnhancedAC3DescriptorTag; Le 24/03/2010 22:58, Jose Alberto Reguero a écrit : > I attached a second version of the first patch. > I make the same changes that in the second patch, but maintaining the logic > of > the first patch. Also I commented the line: > +//this->context->request_channels = 2; > because your example has 5 channels. If you have trouble with that you can > comment the line again. > Which typo error has the second patch? > > Jose Alberto > > El Miércoles, 24 de Marzo de 2010, zaverel escribió: > >> i 've patched pat.c and now remux.c >> and with use xine-lib-1.2 with your second patch (who has typo error) >> and that doesn't work. >> >> corrected remux.c >> >> line 533 >> case SI::AC3DescriptorTag: >> +case SI::EnhancedAC3DescriptorTag: >> >> >> and in line 191: >> >> -Target[i++] = SI::AC3DescriptorTag; >> +Target[i++] = SI::EnhancedAC3DescriptorTag; >> >> >> >> with your previously patch and just pat.c patched with >> line 402 >> >> case SI::AC3DescriptorTag: >> +case SI:EnhancedAC3DescriptorTag: >> >> that worked but not stable. >> >> Is your sample eac3 has |"Spectral extension" ? >> because in france dvb-t with eac3 has it >> and need a ffmpeg patched for that. >> And i test with that sound. >> >> Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : >> >>> It works here with a old sample of tdt with eac3. Have you patch also >>> remux.c? You need to change in line 533: >>> >>> case SI::AC3DescriptorTag: >>> +case SI:EnhancedAC3DescriptorTag: >>> >>> and in line 191: >>> >>> -Target[i++] = SI::AC3DescriptorTag; >>> +Target[i++] = SI::EnhancedAC3DescriptorTag >>> >>> Jose Alberto >>> >>> El Miércoles, 24 de Marzo de 2010, dplu escribió: >>> Hi I have made previous test with the version release by Petri Hintukainen And I notice this part is not working like it should -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { + m->content = p; + m->size = packet_len; + m->type |= BUF_AUDIO_EAC3; + return 1; + +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ unfortunaletly, in AC3 or E-AC3 , the descriptor tag is STREAM_AUDIO_AC3, so the program never run the first if (installed a debug printf here) It seems that your first approach (at least what I understood) by forcing the decoding of all AC-3 stream by ffmepg instead of internal lib was nice but generate violent segfault on libavcodec Hope this help you Best regards PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or xine-lib) Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > hello > > your second patch doesn't work : no sound on eac3 channel > > if you want there is a sample of vdr hd-eac3 recording here: > > http://dl.free.fr/ew4rJddM8 > > 103mo > > else , i don't know what mailing-list is the more indicate for debuging > > the vdr or xine-dev mailing-list ? > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >>> ___ >>> vdr mailing list >>> vdr@linuxtv.org >>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >>> > > > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
I attached a second version of the first patch. I make the same changes that in the second patch, but maintaining the logic of the first patch. Also I commented the line: +//this->context->request_channels = 2; because your example has 5 channels. If you have trouble with that you can comment the line again. Which typo error has the second patch? Jose Alberto El Miércoles, 24 de Marzo de 2010, zaverel escribió: > i 've patched pat.c and now remux.c > and with use xine-lib-1.2 with your second patch (who has typo error) > and that doesn't work. > > corrected remux.c > > line 533 > case SI::AC3DescriptorTag: > +case SI::EnhancedAC3DescriptorTag: > > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag; > > > > with your previously patch and just pat.c patched with > line 402 > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > that worked but not stable. > > Is your sample eac3 has |"Spectral extension" ? > because in france dvb-t with eac3 has it > and need a ffmpeg patched for that. > And i test with that sound. > > Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > > It works here with a old sample of tdt with eac3. Have you patch also > > remux.c? You need to change in line 533: > > > > case SI::AC3DescriptorTag: > > +case SI:EnhancedAC3DescriptorTag: > > > > and in line 191: > > > > -Target[i++] = SI::AC3DescriptorTag; > > +Target[i++] = SI::EnhancedAC3DescriptorTag > > > > Jose Alberto > > > > El Miércoles, 24 de Marzo de 2010, dplu escribió: > >> Hi > >> > >> I have made previous test with the version release by Petri Hintukainen > >> > >> And I notice this part is not working like it should > >> > >> -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ > >> +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > >> + m->content = p; > >> + m->size = packet_len; > >> + m->type |= BUF_AUDIO_EAC3; > >> + return 1; > >> + > >> +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - > >> raw */ > >> > >> unfortunaletly, in AC3 or E-AC3 , the descriptor tag is > >> STREAM_AUDIO_AC3, so the program never run the first if (installed a > >> debug printf here) > >> > >> It seems that your first approach (at least what I understood) by > >> forcing the decoding of all AC-3 stream by ffmepg instead of internal > >> lib was nice but generate violent segfault on libavcodec > >> > >> Hope this help you > >> > >> Best regards > >> > >> PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or > >> xine-lib) > >> > >> Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > >>> hello > >>> > >>> your second patch doesn't work : no sound on eac3 channel > >>> > >>> if you want there is a sample of vdr hd-eac3 recording here: > >>> > >>> http://dl.free.fr/ew4rJddM8 > >>> > >>> 103mo > >>> > >>> else , i don't know what mailing-list is the more indicate for debuging > >>> > >>> the vdr or xine-dev mailing-list ? > >>> > >>> ___ > >>> vdr mailing list > >>> vdr@linuxtv.org > >>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > >> > >> ___ > >> vdr mailing list > >> vdr@linuxtv.org > >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr diff -r a6a25ea3e2c8 src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Sun Mar 14 15:12:25 2010 + +++ b/src/combined/ffmpeg/ff_audio_decoder.c Wed Mar 24 22:44:29 2010 +0100 @@ -257,10 +257,44 @@ if( !this->decoder_ok ) { if ( ! this->context || ! this->codec ) { -xprintf (this->stream->xine, XINE_VERBOSITY_LOG, - _("ffmpeg_audio_dec: trying to open null codec\n")); - _x_stream_info_set(this->stream, XINE_STREAM_INFO_AUDIO_HANDLED, 0); - return; + if ( (buf->type & 0x) == BUF_AUDIO_A52 ) { + pthread_mutex_lock (&ffmpeg_lock); +this->codec = avcodec_find_decoder(CODEC_ID_AC3); + pthread_mutex_unlock (&ffmpeg_lock); +_x_meta_info_set(this->stream, XINE_META_INFO_AUDIOCODEC, + "AC3 coque (ffmpeg)"); + +if (!this->codec) { + xprintf (this->stream->xine, XINE_VERBOSITY_LOG, + _("ffmpeg_audio_dec: couldn't find ffmpeg decoder for buf type 0x%X\n"), + buf->type); + _x_stream_info_set(this->stream, XINE_STREAM_INFO_AUDIO_HANDLED, 0); + return; +} + +this->context = avcodec_alloc_context(); + +this->audio_bits = 16; +// this->audio_sample_rate = 48000; +// this->audio_channels = 6; +//this->context->request_channels = 2; + +this->context->bits_per_sample = this->audio_bits; +this->context->sample_rate = this->audio_sample_rate;
Re: [vdr] vdr xine-lib eac3
i 've patched pat.c and now remux.c and with use xine-lib-1.2 with your second patch (who has typo error) and that doesn't work. corrected remux.c line 533 case SI::AC3DescriptorTag: +case SI::EnhancedAC3DescriptorTag: and in line 191: -Target[i++] = SI::AC3DescriptorTag; +Target[i++] = SI::EnhancedAC3DescriptorTag; with your previously patch and just pat.c patched with line 402 case SI::AC3DescriptorTag: +case SI:EnhancedAC3DescriptorTag: that worked but not stable. Is your sample eac3 has |"Spectral extension" ? because in france dvb-t with eac3 has it and need a ffmpeg patched for that. And i test with that sound. | Le 24/03/2010 19:41, Jose Alberto Reguero a écrit : > It works here with a old sample of tdt with eac3. Have you patch also remux.c? > You need to change in line 533: > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag > > Jose Alberto > > El Miércoles, 24 de Marzo de 2010, dplu escribió: > >> Hi >> >> I have made previous test with the version release by Petri Hintukainen >> >> And I notice this part is not working like it should >> >> -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ >> +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { >> + m->content = p; >> + m->size = packet_len; >> + m->type |= BUF_AUDIO_EAC3; >> + return 1; >> + >> +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw >> */ >> >> unfortunaletly, in AC3 or E-AC3 , the descriptor tag is STREAM_AUDIO_AC3, >> so the program never run the first if (installed a debug printf here) >> >> It seems that your first approach (at least what I understood) by forcing >> the decoding of all AC-3 stream by ffmepg instead of internal lib was nice >> but generate violent segfault on libavcodec >> >> Hope this help you >> >> Best regards >> >> PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or >> xine-lib) >> >> Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : >> >>> hello >>> >>> your second patch doesn't work : no sound on eac3 channel >>> >>> if you want there is a sample of vdr hd-eac3 recording here: >>> >>> http://dl.free.fr/ew4rJddM8 >>> >>> 103mo >>> >>> else , i don't know what mailing-list is the more indicate for debuging >>> >>> the vdr or xine-dev mailing-list ? >>> >>> ___ >>> vdr mailing list >>> vdr@linuxtv.org >>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >>> >> ___ >> vdr mailing list >> vdr@linuxtv.org >> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr >> > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi Ok I do not have this line, I better understand now, the type ID in file was not correct so system don't know how to route it ... int cPatPmtGenerator::MakeAC3Descriptor(uchar *Target) { int i = 0; Target[i++] = SI::AC3DescriptorTag; Target[i++] = 0x01; // length Target[i++] = 0x00; IncEsInfoLength(i); return i; } Of course, the question is now : what about real and normal ac3 stream like in German SD/HD channels ? (Sat1 /prosieben) are they "transtyped" to e-ac3 also ? I am not able to recompile now, but will try this week end or one of my colleague will try earlier if available Thanks for your help Best regards Le Wednesday 24 March 2010 19:41:43 Jose Alberto Reguero, vous avez écrit : > It works here with a old sample of tdt with eac3. Have you patch also > remux.c? You need to change in line 533: > > case SI::AC3DescriptorTag: > +case SI:EnhancedAC3DescriptorTag: > > and in line 191: > > -Target[i++] = SI::AC3DescriptorTag; > +Target[i++] = SI::EnhancedAC3DescriptorTag > > Jose Alberto > > El Miércoles, 24 de Marzo de 2010, dplu escribió: > > Hi > > > > I have made previous test with the version release by Petri Hintukainen > > > > And I notice this part is not working like it should > > > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ > > +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > > + m->content = p; > > + m->size = packet_len; > > + m->type |= BUF_AUDIO_EAC3; > > + return 1; > > + > > +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw > > */ > > > > unfortunaletly, in AC3 or E-AC3 , the descriptor tag is STREAM_AUDIO_AC3, > > so the program never run the first if (installed a debug printf here) > > > > It seems that your first approach (at least what I understood) by forcing > > the decoding of all AC-3 stream by ffmepg instead of internal lib was > > nice but generate violent segfault on libavcodec > > > > Hope this help you > > > > Best regards > > > > PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or > > xine-lib) > > > > Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > > > hello > > > > > > your second patch doesn't work : no sound on eac3 channel > > > > > > if you want there is a sample of vdr hd-eac3 recording here: > > > > > > http://dl.free.fr/ew4rJddM8 > > > > > > 103mo > > > > > > else , i don't know what mailing-list is the more indicate for debuging > > > > > > the vdr or xine-dev mailing-list ? > > > > > > ___ > > > vdr mailing list > > > vdr@linuxtv.org > > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
It works here with a old sample of tdt with eac3. Have you patch also remux.c? You need to change in line 533: case SI::AC3DescriptorTag: +case SI:EnhancedAC3DescriptorTag: and in line 191: -Target[i++] = SI::AC3DescriptorTag; +Target[i++] = SI::EnhancedAC3DescriptorTag Jose Alberto El Miércoles, 24 de Marzo de 2010, dplu escribió: > Hi > > I have made previous test with the version release by Petri Hintukainen > > And I notice this part is not working like it should > > -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ > +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { > + m->content = p; > + m->size = packet_len; > + m->type |= BUF_AUDIO_EAC3; > + return 1; > + > +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw > */ > > unfortunaletly, in AC3 or E-AC3 , the descriptor tag is STREAM_AUDIO_AC3, > so the program never run the first if (installed a debug printf here) > > It seems that your first approach (at least what I understood) by forcing > the decoding of all AC-3 stream by ffmepg instead of internal lib was nice > but generate violent segfault on libavcodec > > Hope this help you > > Best regards > > PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or > xine-lib) > > Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > > hello > > > > your second patch doesn't work : no sound on eac3 channel > > > > if you want there is a sample of vdr hd-eac3 recording here: > > > > http://dl.free.fr/ew4rJddM8 > > > > 103mo > > > > else , i don't know what mailing-list is the more indicate for debuging > > > > the vdr or xine-dev mailing-list ? > > > > ___ > > vdr mailing list > > vdr@linuxtv.org > > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
Hi I have made previous test with the version release by Petri Hintukainen And I notice this part is not working like it should -if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ +if(m->descriptor_tag == HDMV_AUDIO_84_EAC3) { + m->content = p; + m->size = packet_len; + m->type |= BUF_AUDIO_EAC3; + return 1; + +} else if((m->descriptor_tag == STREAM_AUDIO_AC3) ||/* ac3 - raw */ unfortunaletly, in AC3 or E-AC3 , the descriptor tag is STREAM_AUDIO_AC3, so the program never run the first if (installed a debug printf here) It seems that your first approach (at least what I understood) by forcing the decoding of all AC-3 stream by ffmepg instead of internal lib was nice but generate violent segfault on libavcodec Hope this help you Best regards PS : Sorry to pollute the vdr mailing list (not subscribed to ffmpeg or xine-lib) Le Wednesday 24 March 2010 18:41:14 zaverel, vous avez écrit : > hello > > your second patch doesn't work : no sound on eac3 channel > > if you want there is a sample of vdr hd-eac3 recording here: > > http://dl.free.fr/ew4rJddM8 > 103mo > > else , i don't know what mailing-list is the more indicate for debuging > > the vdr or xine-dev mailing-list ? > > ___ > vdr mailing list > vdr@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr xine-lib eac3
El Miércoles, 24 de Marzo de 2010, zaverel escribió: > hello > > i try the patch from Jose Alberto to use ffmpeg eac3 with xine > http://www.linuxtv.org/pipermail/vdr/2010-March/022687.html > > The good things is that eac3 sound is now decoded with xine-lib > > But it's not stable at all when zapping frhom HD to HD channel or SD > channel > > vdr-sxfe doesn't work anymore with --video=xv on HD channels but only > with --video=vdpau > > vdr-sxfe --tcp --video=xv --verbose > > > [29976] [input_vdr] fifo_buffer_new... > [29976] [input_vdr] fifo_buffer_new done. > [29977] [demux_vdr] PMT changed > [29977] [demux_vdr] audio stream changed: -> 0300 > ffmpeg_audio_dec: increasing buffer to 98304 to avoid overflow. > Erreur de segmentation > > and dmesg said > > vdr-sxfe[29973] general protection ip:b06757c5 sp:b442a020 error:0 in > libavcodec.so.52.60.0[b01d7000+6e3000] > > with xine-ui it's almost the same > > xine "xvdr+tcp://miniq#nocache" --verbose --video=xv > > > > [1723] [input_vdr] wait_stream_sync: discard_index 5465954112 != curpos > 5471218488 ! (diff -5264376) > prebuffer=14400 pts > prebuffer=2000 pts > prebuffer=14400 pts > prebuffer=14400 pts > [1723] [demux_vdr] PMT changed > ffmpeg_audio_dec: augmentation du buffer à 98304 pour éviter sa saturation. > Last message repeated 3 times > [h264 @ 0x8fb2640]non-existing SPS 0 referenced in buffering period > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]non-existing PPS 0 referenced > [h264 @ 0x8fb2640]decode_slice_header error > [h264 @ 0x8fb2640]no frame! > xiTK received SIGSEGV signal, RIP. > Abandon > > but dmesg said nothing. > > > I do my test with vdr-1.7.12 , ffmpeg , xine-lib-1.2 , all patched for > eac3 and xineliboutput. > All are latest cvs > > > So what can i do ? > > thanks. > > I make some changes based on the patches posted by Petri Hintukainen yesterday in the xine-devel mailing list. Attached is a new version of the patch. I can not probe it now with tdt eac3 channel. You can try it. Jose Alberto diff -r a6a25ea3e2c8 include/xine/buffer.h --- a/include/xine/buffer.h Sun Mar 14 15:12:25 2010 + +++ b/include/xine/buffer.h Wed Mar 24 17:24:12 2010 +0100 @@ -266,6 +266,7 @@ #define BUF_AUDIO_MP3ADU 0x033E #define BUF_AUDIO_AMR_NB 0x033F #define BUF_AUDIO_AMR_WB 0x0340 +#define BUF_AUDIO_EAC3 0x0341 /*...@}*/ /** diff -r a6a25ea3e2c8 src/combined/ffmpeg/ff_audio_decoder.c --- a/src/combined/ffmpeg/ff_audio_decoder.c Sun Mar 14 15:12:25 2010 + +++ b/src/combined/ffmpeg/ff_audio_decoder.c Wed Mar 24 17:24:12 2010 +0100 @@ -257,10 +257,44 @@ if( !this->decoder_ok ) { if ( ! this->context || ! this->codec ) { -xprintf (this->stream->xine, XINE_VERBOSITY_LOG, - _("ffmpeg_audio_dec: trying to open null codec\n")); - _x_stream_info_set(this->stream, XINE_STREAM_INFO_AUDIO_HANDLED, 0); - return; + if ( (buf->type & 0x) == BUF_AUDIO_EAC3 ) { + pthread_mutex_lock (&ffmpeg_lock); +this->codec = avcodec_find_decoder(CODEC_ID_EAC3); + pthread_mutex_unlock (&ffmpeg_lock); +_x_meta_info_set(this->stream, XINE_META_INFO_AUDIOCODEC, + "AC3 coque (ffmpeg)"); + +if (!this->codec) { + xprintf (this->stream->xine, XINE_VERBOSITY_LOG, + _("ffmpeg_audio_dec: couldn't find ffmpeg decoder for buf type 0x%X\n"), + buf->type); + _x_stream_info_set(this->stream, XINE_STREAM_INFO_AUDIO_HANDLED, 0); + return; +} + +this->context = avcodec_alloc_context(); + +this->audio_bits = 16; +// this->audio_sample_rate = 48000; +// this->audio_channels = 6; +this->context->request_channels = 2; + +this->context->bits_per_sample = this->audio_bits; +this->context->sample_rate = this->audio_sample_rate; +this->context->channels= this->audio_channels; +this->context->codec_id= this->codec->id; +this->context->codec_type = this->codec->type; +this->context->codec_tag = _x_stream_info_get(this->stream, XINE_STREAM_INFO_AUDIO_FOURCC); + +this->size = 0; + +this->decode_buffer = calloc(1, AVCODEC_MAX_AUDIO_FRAME_SIZE); + } else { + xprintf (this->stream->xine, XINE_VERBOSITY_LOG, + _("ffmpeg_audio_dec: trying to open null codec\n")); + _x_stream_info_set(this->stream, XINE_STREAM_INFO_AUDIO_HANDLED, 0); + return; + } } pthread_mutex_lock (&ffmpeg_lock); @@ -284,11 +318,14 @@ if (!thi