Change in vdsm[master]: vdsm.spec: Adding with_systemd macro
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Adding with_systemd macro .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1301/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/412/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: create /etc/modules-load.d/vdsm.conf .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1265/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/411/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm: create /etc/modules-load.d/vdsm.conf .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/11718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Adding with_systemd macro
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: Adding with_systemd macro .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/12086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: create /etc/modules-load.d/vdsm.conf .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1300/ (3/3) -- To view, visit http://gerrit.ovirt.org/11718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Adding with_systemd macro
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Adding with_systemd macro .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1266/ (3/3) -- To view, visit http://gerrit.ovirt.org/12086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: create /etc/modules-load.d/vdsm.conf .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/411/ (2/3) -- To view, visit http://gerrit.ovirt.org/11718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: create /etc/modules-load.d/vdsm.conf .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1265/ (1/3) -- To view, visit http://gerrit.ovirt.org/11718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Adding with_systemd macro
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Adding with_systemd macro .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1301/ (2/3) -- To view, visit http://gerrit.ovirt.org/12086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Adding with_systemd macro
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Adding with_systemd macro .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/412/ (1/3) -- To view, visit http://gerrit.ovirt.org/12086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
Lee Yarwood has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
Adam Litke has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
Adam Litke has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
Adam Litke has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1298/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/409/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1299/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/410/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
Adam Litke has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
Adam Litke has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
Adam Litke has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
Adam Litke has posted comments on this change.
Change subject: gluster: add task support
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Some TODO items regarding the schema.
File vdsm_api/glusterapi-schema.json
Line 37: # Start rebalance of given volume.
Line 38: #
Line 39: # @volumeName: Gluster volume name
Line 40: #
Line 41: ##
Try running this file through process-schema.py in vdsm_api. That will show
you the places where this schema file is not quite compatible with the expected
format. For example, you have no 'Since' tags. Also, you are missing the
return information for some of these commands.
Line 42: {'command': {'class': 'GlusterVolume', 'name': 'rebalanceStart'},
Line 43: 'data': {'volumeName': 'str'}}
Line 44:
Line 45: ##
--
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shireesh Anjal
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1297/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/408/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/410/ (3/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1296/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/407/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/409/ (3/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/406/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1259/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/405/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/408/ (3/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1298/ (2/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1299/ (2/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1297/ (2/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1264/ (1/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1296/ (2/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1262/ (1/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1263/ (1/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/405/ (3/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1261/ (3/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/407/ (1/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1295/ (2/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1260/ (3/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1294/ (1/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1259/ (2/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/406/ (1/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1293/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/404/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1292/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/403/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1291/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/402/ : FAILURE -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1290/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/401/ : FAILURE -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/404/ (3/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1289/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/400/ : FAILURE -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/403/ (3/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/402/ (3/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1253/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1288/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/399/ : FAILURE -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1293/ (2/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1291/ (2/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1292/ (2/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1258/ (1/3) -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1257/ (1/3) -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1256/ (1/3) -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1255/ (3/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1254/ (3/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1288/ (3/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1290/ (1/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/401/ (2/3) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1253/ (2/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1289/ (2/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/399/ (1/3) -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
Adam Litke has uploaded a new change for review.
Change subject: api: Convert process_schema.py to use vdsmapi.get_api()
..
api: Convert process_schema.py to use vdsmapi.get_api()
Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747
Signed-off-by: Adam Litke
---
M vdsm_api/process-schema.py
1 file changed, 36 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/12109/1
diff --git a/vdsm_api/process-schema.py b/vdsm_api/process-schema.py
index e8de198..c4bda0d 100755
--- a/vdsm_api/process-schema.py
+++ b/vdsm_api/process-schema.py
@@ -35,7 +35,7 @@
typeKinds = ('class', 'type', 'enum', 'map', 'union', 'alias')
-def read_symbol_comment(f, symbols):
+def read_symbol_comment(f, api):
"""
In the VDSM API schema, each entity is preceeded by a comment that provides
additional human-readable information about the entity. The format of this
@@ -61,24 +61,21 @@
##
"""
-def find_symbol(symbols, name):
+def find_symbol(api, name):
"""
Find a symbol by name in the vdsmapi parsed symbol list.
"""
-for s in symbols:
-if '.' in name:
-cls, member = name.split('.')
-if member == 'init' and s.get('init') == cls:
-return s
-if 'command' not in s:
-continue
-if s['command']['class'] == cls and \
-s['command']['name'] == member:
-return s
-else:
-for k in typeKinds:
-if s.get(k) == name:
-return s
+if '.' in name:
+# This is a command
+ns, method = name.split('.')
+try:
+return api['commands'][ns][method]
+except KeyError:
+pass
+else:
+for sType in ('types', 'enums', 'aliases', 'maps'):
+if name in api[sType]:
+return api[sType][name]
raise ValueError("symbol: %s not found" % name)
# Parse one complete comment block. Blocks begin and end with '^##'.
@@ -96,8 +93,12 @@
m = re.search('^\@(.*):$', line)
name = m.group(1)
+# We skip namespace definitions since there is nothing to document
+if name in api['commands']:
+return
+
# Find the already processed symbol information
-symbol = find_symbol(symbols, name)
+symbol = find_symbol(api, name)
symbol.update({'name': name, 'info_data': {}, 'info_return': '',
'xxx': []})
@@ -157,7 +158,7 @@
return symbol
-def read_schema_doc(f, symbols):
+def read_schema_doc(f, api):
"""
Read all of the documentation information from the schema and attach it to
the relavent symbol definitions we have already parsed.
@@ -165,9 +166,9 @@
while True:
line = f.readline()
if not line:
-return symbols
+return api
if line.strip() == '##':
-read_symbol_comment(f, symbols)
+read_symbol_comment(f, api)
continue
@@ -287,7 +288,7 @@
f.write('\n')
-def create_doc(symbols, filename):
+def create_doc(api, filename):
f = open(filename, 'w')
header = """
@@ -317,17 +318,16 @@
"""
f.write(header)
-# Sort commands by their expanded names
-cmdKey = lambda k: k.get('command', {}).get('class', '') + '.' + \
-k.get('command', {}).get('name', '')
-commands = [s for s in sorted(symbols, key=cmdKey)
-if 'command' in s]
-# Types come after commands but they are not sorted
-types = [s for s in symbols if 'command' not in s]
-for s in commands:
-write_symbol(f, s)
-for s in types:
-write_symbol(f, s)
+# First, write out commands in sorted order
+for ns in sorted(api['commands'].iterkeys()):
+for cmd in sorted(api['commands'][ns].iterkeys()):
+write_symbol(f, api['commands'][ns][cmd])
+
+# Write out the data types
+for sType in ('aliases', 'types', 'maps', 'enums'):
+for name in sorted(api[sType].iterkeys()):
+write_symbol(f, api[sType][name])
+
f.write(footer)
@@ -358,15 +358,13 @@
schema = sys.argv[1]
output = sys.argv[2]
-symbols = None
-# First read in the progmatic schema definition
-with open(schema) as f:
-symbols = vdsmapi.parse_schema(f)
-verify_symbols(symbols)
+api = vdsmapi.get_api(schema)
+#verify_symbols(symbols)
# Now merge in the information from the comments
with open(schema) as f:
-symbols = read_schema_doc(f, symbols)
+symbols = read_schema_doc(f, api)
+
create_doc(symbols, output)
--
To view, visit http://gerrit.ovirt.org/12109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newc
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: Move DynamicBridge to vdsmapi schema processing .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/400/ (1/3) -- To view, visit http://gerrit.ovirt.org/12107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
Adam Litke has uploaded a new change for review.
Change subject: api: Move DynamicBridge to vdsmapi schema processing
..
api: Move DynamicBridge to vdsmapi schema processing
Signed-off-by: Adam Litke
Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71
---
M tests/apiTests.py
M vdsm/clientIF.py
M vdsm_api/Bridge.py
M vdsm_api/jsonrpc/__init__.py
4 files changed, 29 insertions(+), 59 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/12107/1
diff --git a/tests/apiTests.py b/tests/apiTests.py
index 7ad8a1f..5275391 100644
--- a/tests/apiTests.py
+++ b/tests/apiTests.py
@@ -27,7 +27,6 @@
from contextlib import closing
from testrunner import VdsmTestCase as TestCaseBase
-from vdsm import constants
import BindingJsonRpc
import jsonrpc
import apiData
@@ -110,21 +109,6 @@
sys.modules['API'] = _newAPI
-def findSchema():
-"""
-Find the API schema file whether we are running tests from the source dir
-or from the tests install location
-"""
-scriptdir = os.path.dirname(__file__)
-localpath = os.path.join(scriptdir, '../vdsm_api/vdsmapi-schema.json')
-installedpath = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json')
-for f in localpath, installedpath:
-if os.access(f, os.R_OK):
-return f
-raise Exception("Unable to find schema in %s or %s",
-localpath, installedpath)
-
-
def setUpModule():
"""
Set up the environment for all tests:
@@ -140,12 +124,11 @@
handler.setLevel(logging.INFO)
log.addHandler(handler)
-schema = findSchema()
createFakeAPI()
# Bridge imports the API module so we must set up the fake API first
import Bridge
-bridge = Bridge.DynamicBridge(schema)
+bridge = Bridge.DynamicBridge()
# Support parallel testing. Try hard to find an open port to use
port = getFreePort()
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 841e962..ef9a19b 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -153,11 +153,10 @@
def _loadBindingJsonRpc(self):
from BindingJsonRpc import BindingJsonRpc
from Bridge import DynamicBridge
-schema = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json')
ip = self._getServerIP(config.get('addresses', 'management_ip'))
port = config.getint('addresses', 'json_port')
conf = [('tcp', {"ip": ip, "port": port})]
-self.bindings['json'] = BindingJsonRpc(DynamicBridge(schema), conf)
+self.bindings['json'] = BindingJsonRpc(DynamicBridge(), conf)
def _prepareBindings(self):
self.bindings = {}
diff --git a/vdsm_api/Bridge.py b/vdsm_api/Bridge.py
index 8fade0f..cc3f227 100644
--- a/vdsm_api/Bridge.py
+++ b/vdsm_api/Bridge.py
@@ -29,8 +29,8 @@
class DynamicBridge(object):
-def __init__(self, schema):
-self._parseSchema(schema)
+def __init__(self):
+self.api = vdsmapi.get_api()
def dispatch(self, name, argobj):
methodName = name.replace('.', '_')
@@ -60,30 +60,13 @@
except KeyError:
raise VdsmError(5, "Response is missing '%s' member" % member)
-def _parseSchema(self, schema):
-self.commands = {}
-self.classes = {}
-self.types = {}
-with open(schema) as f:
-symbols = vdsmapi.parse_schema(f)
-for s in symbols:
-if 'command' in s:
-key = "%s_%s" % (s['command']['class'],
- s['command']['name'])
-self.commands[key] = s
-elif 'class' in s:
-cls = s['class']
-self.classes[cls] = s
-elif 'type' in s:
-t = s['type']
-self.types[t] = s
-
def __getattr__(self, attr):
-if attr in self.commands:
+try:
className, methodName = attr.split('_')
-return partial(self._dynamicMethod, className, methodName)
-else:
+self.api['commands'][className][methodName]
+except (KeyError, ValueError):
raise AttributeError("Attribute not found '%s'" % attr)
+return partial(self._dynamicMethod, className, methodName)
def _convertClassName(self, name):
"""
@@ -97,7 +80,7 @@
except KeyError:
return name
-def _getMethodArgs(self, className, cmd, argObj):
+def _getMethodArgs(self, className, methodName, argObj):
"""
An internal API call currently looks like:
@@ -109,10 +92,11 @@
them from here. For any given method, the method_args are obtained by
chopping off the ctor_args from the beginning of argObj.
"""
-className = self._convertClassName(className)
# Get the full argument list
-allArgs = self.commands[cmd].get('data', {}).keys()
+sym = s
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
Adam Litke has uploaded a new change for review.
Change subject: api: Convert schemaTests to use vdsmapi.get_api
..
api: Convert schemaTests to use vdsmapi.get_api
Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4
Signed-off-by: Adam Litke
---
M tests/schemaTests.py
1 file changed, 1 insertion(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/12108/1
diff --git a/tests/schemaTests.py b/tests/schemaTests.py
index 9bf4b5b..ae82b9f 100644
--- a/tests/schemaTests.py
+++ b/tests/schemaTests.py
@@ -18,30 +18,9 @@
#
from testrunner import VdsmTestCase as TestCaseBase
-import os.path
import vdsmapi
-from vdsm import constants
-
-
-def findSchema():
-"""
-Find the API schema file whether we are running tests from the source dir
-or from the tests install location
-"""
-scriptdir = os.path.dirname(__file__)
-localpath = os.path.join(scriptdir, '../vdsm_api/vdsmapi-schema.json')
-installedpath = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json')
-for f in localpath, installedpath:
-if os.access(f, os.R_OK):
-return f
-raise Exception("Unable to find schema in %s or %s" % (localpath,
- installedpath))
class SchemaTest(TestCaseBase):
-def setUp(self):
-self.schema = findSchema()
-
def testSchemaParse(self):
-with open(self.schema) as f:
-vdsmapi.parse_schema(f)
+self.assertTrue(isinstance(vdsmapi.get_api(), dict))
--
To view, visit http://gerrit.ovirt.org/12108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
Adam Litke has uploaded a new change for review.
Change subject: api: Organize schema symbols by type
..
api: Organize schema symbols by type
Currently the vdsmapi module returns the parsed schema as a large list of
symbols. Consumers of this list have all resorted to reorganizing the symbols
by type (commands, types, enums, maps, etc). Rather than forcing each user to
rewrite this code, just do it correctly at the source. This reduces code
duplication and makes at easier to add new symbol types (such as events and
errors).
Signed-off-by: Adam Litke
Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690
---
M vdsm_api/vdsmapi.py
1 file changed, 122 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/12106/1
diff --git a/vdsm_api/vdsmapi.py b/vdsm_api/vdsmapi.py
index 889da71..f154e99 100644
--- a/vdsm_api/vdsmapi.py
+++ b/vdsm_api/vdsmapi.py
@@ -24,6 +24,9 @@
# Refer to the README and COPYING files for full details of the license
#
+import os
+from vdsm import constants
+
try:
from collections import OrderedDict
OrderedDict # make pyflakes happy
@@ -107,3 +110,122 @@
exprs.append(expr_eval)
return exprs
+
+
+def find_schema():
+"""
+Find the API schema file whether we are running from within the source dir
+or from an installed location
+"""
+localpath = os.path.dirname(__file__)
+installedpath = constants.P_VDSM
+for directory in localpath, installedpath:
+path = os.path.join(directory, 'vdsmapi-schema.json')
+if os.access(path, os.R_OK):
+return path
+raise Exception("Unable to find API schema file in %s or %s",
+localpath, installedpath)
+
+
+_api_info = None
+
+
+def _load_api_info(schema):
+"""
+Organize API information from the schema file into a useful structure:
+
+types: A dictionary of type symbols indexed by type name
+{
+ 'type':
+ 'data':
+ 'union':
+}
+
+enums: A dictionary of enum symbols indexed by enum name
+{
+ 'enum': ,
+ 'data':
+}
+
+aliases: A dictionary of alias symbols indexed by alias name
+{
+ 'alias':
+ 'data':
+}
+
+maps: A dictionary of mapping types indexed by name
+{
+ 'map':
+ 'key':
+ 'value':
+}
+
+commands: A dictionary of command namespaces indexed by namespace name that
+contains dictionaries of command symbols indexed by command name
+{
+ 'command'
+ {
+ 'class':
+ 'name':
+ }
+ 'data':
+ 'returns':
+}
+
+unions: A dictionary that describes valid casts between related types.
+Each key is a source type that is castable and the value is a list of types
+to which the source type may be cast.
+"""
+global _api_info
+
+info_key = schema
+if schema is None:
+schema = find_schema()
+with open(schema) as f:
+symbols = parse_schema(f)
+
+info = {'types': {}, 'enums': {}, 'aliases': {}, 'maps': {},
+'commands': {}, 'unions': {}}
+
+for s in symbols:
+if 'alias' in s:
+info['aliases'][s['alias']] = s
+elif 'type' in s:
+info['types'][s['type']] = s
+elif 'enum' in s:
+info['enums'][s['enum']] = s
+elif 'map' in s:
+info['maps'][s['map']] = s
+elif 'command' in s:
+ns = s['command']['class']
+cmd = s['command']['name']
+if ns not in info['commands']:
+info['commands'][ns] = {cmd: s}
+else:
+info['commands'][ns][cmd] = s
+
+# Determine the valid casts
+def add_relation(mapping, typeA, typeB):
+if typeA in mapping:
+mapping[typeA].append(typeB)
+else:
+mapping[typeA] = [typeB, ]
+
+for t in info['types'].values():
+if 'union' not in t:
+continue
+for u in t['union']:
+add_relation(info['unions'], u, t['type'])
+add_relation(info['unions'], t['type'], u)
+
+_api_info = {info_key: info}
+
+
+def get_api(schema=None):
+"""
+Get organized information about the vdsm API. If schema is specified,
+read from a specific file. Otherwise try to find the schema automatically.
+"""
+if _api_info is None or schema not in _api_info:
+_load_api_info(schema)
+return _api_info[schema]
--
To view, visit http://gerrit.ovirt.org/12106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blocksd: skip broken images in getAllVolumes
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: FYI: This may be a candidate for fixing https://bugzilla.redhat.com/show_bug.cgi?id=910013 -- To view, visit http://gerrit.ovirt.org/11859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bbf7eecdb11873dd5fe9bef2afaa680aecbc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1252/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/398/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
Federico Simoncelli has uploaded a new change for review.
Change subject: image: do not delete the template on deleteImage
..
image: do not delete the template on deleteImage
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910013
Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51
Signed-off-by: Federico Simoncelli
---
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sd.py
3 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/12105/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index ed6e262..793582b 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1430,7 +1430,7 @@
vars.task.getExclusiveLock(STORAGE, imgUUID)
vars.task.getSharedLock(STORAGE, sdUUID)
allVols = dom.getAllVolumes()
-volsByImg = sd.getVolsOfImage(allVols, imgUUID)
+volsByImg = sd.getVolsOfImage(allVols, imgUUID, withTemplate=False)
if not volsByImg:
self.log.error("Empty or not found image %s in SD %s. %s",
imgUUID, sdUUID, allVols)
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 92021ff..9bb5da4 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -76,7 +76,7 @@
Replaces Image.delete() in Image.[copy(), move(),multimove()].
"""
allVols = dom.getAllVolumes()
-imgVols = sd.getVolsOfImage(allVols, imgUUID)
+imgVols = sd.getVolsOfImage(allVols, imgUUID, withTemplate=False)
if not imgVols:
log.warning("No volumes found for image %s. %s", imgUUID, allVols)
return
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index 9ce836b..17626e3 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -145,7 +145,7 @@
mountBasePath = os.path.join(storage_repository, DOMAIN_MNT_POINT)
-def getVolsOfImage(allVols, imgUUID):
+def getVolsOfImage(allVols, imgUUID, withTemplate=True):
""" Filter allVols dict for volumes related to imgUUID.
Returns {volName: (([templateImge], imgUUID, [otherImg]), volPar)
@@ -155,7 +155,8 @@
"""
return dict((volName, vol) for volName, vol in allVols.iteritems()
-if imgUUID in vol.imgs)
+if (vol.imgs[0] == imgUUID or
+(withTemplate and imgUUID in vol.imgs)))
def supportsUnicode(version):
--
To view, visit http://gerrit.ovirt.org/12105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1287/ (1/3) -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1252/ (3/3) -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/398/ (2/3) -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: doc: Solved sphinx-build import errors.
oVirt Jenkins CI Server has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/397/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: doc: Solved sphinx-build import errors.
oVirt Jenkins CI Server has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1251/ (2/3) -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: doc: Solved sphinx-build import errors.
oVirt Jenkins CI Server has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/397/ (3/3) -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: doc: Solved sphinx-build import errors.
oVirt Jenkins CI Server has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1286/ (1/3) -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add a json rpc funtional test which sets up a VM
Adam Litke has posted comments on this change.
Change subject: add a json rpc funtional test which sets up a VM
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
File tests/functional/jsonrpcTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
You wrote this file, right? The copyright should be to you and IBM and in 2013
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 109: kernelArgsDistro['rhel'] = kernelArgsDistro['fedora']
Line 110: if distro.lower() not in kernelArgsDistro:
Line 111: raise SkipTest("Don't know how to perform direct kernel
boot for "
Line 112:"%s" % distro)
Line 113:
Can you also to an access test for the kernel and initrd? I've found that
tests like this fail because with selinux and svirt enabled, the qemu process
cannot access the kernel and initrd.
Line 114: template = {'vmId': '-abcd---',
Line 115: 'vmName': 'vdsmKernelBootVM',
Line 116: 'display': 'vnc',
Line 117: 'kvmEnable': 'true',
--
To view, visit http://gerrit.ovirt.org/11386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I734614fdc9515e2883004aceafb36291ee44e59a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: ShaoHe Feng
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix Exception message error in apiTests module
Adam Litke has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51b141047dc0490e50a050fd667f63d30f121f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook_faqemu: using libvirt instead of hacking it
Peter V. Saveliev has posted comments on this change. Change subject: hook_faqemu: using libvirt instead of hacking it .. Patch Set 1: in addition to F17/F18, also successfully tested on RHEL6.3 1. HW with kvm loaded (/dev/kvm presents) 2. HW with kvm unloaded (w/o /dev/kvm) 3. virtual node w/o kvm support at all -- To view, visit http://gerrit.ovirt.org/12084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85f0208bf55f26c5bd146e3a81f28fdc56b8c5ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel P. Berrange Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
