Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2268/ (1/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1430/ (2/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2269/ (3/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2269/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1430/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2333/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1431/ (2/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2270/ (1/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2334/ (3/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2270/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2334/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Add blkIoTune support at vm creation
..
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
File vdsm/libvirtvm.py
Line 1178: not
utils.getUserPermissions(constants.QEMU_PROCESS_USER,
Line 1179: self.path)['write']):
Line 1180: diskelem.appendChildWithArgs('readonly')
Line 1181:
Line 1182: if hasattr(self, 'blkIoTune'):
Now the code is more robust, but I would move all the validation logic to an
external function and leave here only the XMLElement creation logic. Having a
few more tests for the validation logic would be good as well.
Line 1183: validParamNames = ('total_bytes_sec', 'read_bytes_sec',
Line 1184:'write_bytes_sec', 'total_iops_sec',
Line 1185:'write_iops_sec', 'read_iops_sec')
Line 1186: for key, value in self.blkIoTune.iteritems():
Line 1179: self.path)['write']):
Line 1180: diskelem.appendChildWithArgs('readonly')
Line 1181:
Line 1182: if hasattr(self, 'blkIoTune'):
Line 1183: validParamNames = ('total_bytes_sec', 'read_bytes_sec',
These are disk device tune params, I would use the same name or something
closer to it, used in the json schema.
Line 1184:'write_bytes_sec', 'total_iops_sec',
Line 1185:'write_iops_sec', 'read_iops_sec')
Line 1186: for key, value in self.blkIoTune.iteritems():
Line 1187: try:
Line 1198: except ValueError:
Line 1199: raise Exception('an integer is required for
blkIoTune'
Line 1200: ' parameter %s' % key)
Line 1201:
Line 1202: categories = (bytes, iops)
I would extract a function checkCategories
Line 1203: for i, category in enumerate(categories):
Line 1204: if self.blkIoTune.get('total_' + category + '_sec',
0) and \
Line 1205: self.blkIoTune.get('read_' + category +
'_sec', 0) or \
Line 1206: self.blkIoTune.get('total_' + category +
'_sec', 0) \
--
To view, visit http://gerrit.ovirt.org/14636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: (1 inline comment) File vdsm/storage/glusterVolume.py Line 26: svdsmProxy = svdsm.getProxy() Line 27: try: Line 28: volInfo = svdsmProxy.glusterVolumeInfo(volname, volfileServer) Line 29: volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]] Line 30: except: Done Line 31: # In case of issues with finding transport type, default to tcp Line 32: self.log.warning(Unable to find transport type for GlusterFS Line 33: volume %s. GlusterFS server = %s, Line 34: (volname, volfileServer), exc_info=True) -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2271/ (1/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2335/ (2/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1432/ (3/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Will squash this with 14666 per fsimonce's suggestion hence abandoning this change -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has abandoned this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Abandoned squash with 14666 -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add tuneBlockDevIo interface
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add tuneBlockDevIo interface .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1433/ (1/3) -- To view, visit http://gerrit.ovirt.org/14394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb33510a081d221af0f69d4dd2d55adf0b79efd2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add tuneBlockDevIo interface
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add tuneBlockDevIo interface .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1433/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2336/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb33510a081d221af0f69d4dd2d55adf0b79efd2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 5: I would prefer that you didn't submit this (2 inline comments) Sorry Vinzenz for not noticing these two issues on the former round. File vdsm/libvirtvm.py Line 36: import hooks Line 37: import caps Line 38: from vdsm import netinfo Line 39: import supervdsm Line 40: import os Not: import from stdlib first. Line 41: Line 42: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm' Line 43: # This device name is used as default both in the qemu-guest-agent Line 44: # service/daemon and in libvirtd (to be used with the quiesce flag). Line 1390: socketPath = self._makeChannelPath(name) Line 1391: if path != socketPath: Line 1392: os.symlink(path, socketPath) Line 1393: Line 1394: except IndexError: Could you make this big try-block smaller? Around the relevant index lookup only? Line 1395: pass Line 1396: Line 1397: def _domDependentInit(self): Line 1398: if self.destroyed: -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Dan Kenigsberg has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Dan Kenigsberg has submitted this change and it was merged. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. storage: Fix the case when VDSM host is not a gluster peer Currently when using glusterSD, VDSM has the need to know the transport type of gluster volume for which it uses gluster cli which assumes that VDSM host is part of gluster cluster (peer). This may not be true always and imposes a constraint that VDSM host must be a gluster peer. This patch fixes the above by doing 2 things... Adds support for --remote-host gluster cli option to volumeInfo API. This helps retrieve gluster volume info from a host that is not a gluster peer (Eg. VDSM host) Adds support to use the ability of gluster cli (--remote-host) to retrieve the gluster volume info even when VDSM host is not a gluster peer. Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Signed-off-by: Deepak C Shetty deepa...@linux.vnet.ibm.com --- M vdsm/gluster/cli.py M vdsm/storage/glusterVolume.py 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Deepak C Shetty: Verified -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2273/ (2/3) -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2337/ (3/3) -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1434/ (1/3) -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1434/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2337/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1435/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2338/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2274/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
Giuseppe Vallarelli has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 15: (3 inline comments) File lib/vdsm/utils.py Line 492: Line 493: Executes an external command, optionally via sudo with stop abilities. Line 494: Line 495: proc = execCmd(command, sudo=False, cwd=cwd, data=data, sync=False, Line 496:nice=nice, ioclass=ioclass) Done Line 497: if recoveryCallback: Line 498: recoveryCallback(proc) Line 499: Line 500: if not proc.wait(cond=stop): File vdsm/storage/Makefile.am Line 66:threadPool.py \ Line 67:volume.py Line 68: Line 69: check-local: Line 70:PYTHONPATH=$(top_srcdir)/lib:PYTHONPATH PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(srcdir)/storage_exception.py Done File vdsm/storage/misc.py Line 222 Line 223 Line 224 Line 225 Line 226 Done -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2338/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2339/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2275/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1436/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1436/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2339/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2340/ (1/3) -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2276/ (3/3) -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1437/ (2/3) -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1437/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
Giuseppe Vallarelli has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 15: (1 inline comment) File vdsm/storage/misc.py Line 222 Line 223 Line 224 Line 225 Line 226 Since you already did something similar I'll be consistent with your approach, but it's something that I do not like much, my opinion is that makes code not explicit and so harder to understand. -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
Giuseppe Vallarelli has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: Verified -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2341/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2277/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1438/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: make iscsid a systemd dependency
Dan Kenigsberg has posted comments on this change. Change subject: service: make iscsid a systemd dependency .. Patch Set 1: Looks good to me, approved better later than never. -- To view, visit http://gerrit.ovirt.org/14630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b3d9c38e971f6d749ac40765610dbb9915ba1a6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1438/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing mocking of _start function and add extraCmd variabl...
Dan Kenigsberg has posted comments on this change. Change subject: Removing mocking of _start function and add extraCmd variable to proxy .. Patch Set 3: Looks good to me, approved Oh right. Sudo squashes env changes. Thanks. -- To view, visit http://gerrit.ovirt.org/14585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I790fb1366bcfd369bd6be1618c284f2a945c19ca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing mocking of _start function and add extraCmd variabl...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing mocking of _start function and add extraCmd variable to proxy .. Removing mocking of _start function and add extraCmd variable to proxy Instead of adding monkeyPatch only for adding PYTHONPATH before running the command, setting self.extraCmd will append extra field to the execution. Change-Id: I790fb1366bcfd369bd6be1618c284f2a945c19ca Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- M tests/superVdsmTests.py M vdsm/supervdsm.py 2 files changed, 5 insertions(+), 23 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I790fb1366bcfd369bd6be1618c284f2a945c19ca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments) File vdsm/alignmentScan.py Line 64: virt-alignment-scan: %d % rc) Line 65: outList = [] Line 66: for line in out: Line 67: outList.append(ScanOutput(*line.split(None, 3))) Line 68: return outList I really like the existing api of this module. Why do you keep changing it? A boolean scanResult is soon nice, please keep it. File vdsm/clientIF.py Line 363: volPath = self.prepareVolumePath(drive) Line 364: try: Line 365: out = alignmentScan.scanImage(volPath) Line 366: except alignmentScan.VirtAlignError as e: Line 367: self.log.warning(Error in virt-alignment-scan: %s, e) Why are you swallowing the error here? Line 368: else: Line 369: for line in xrange(len(out)): Line 370: aligning[out[line].partitionName] = ( Line 371: out[line].alignmentScanResult == ok) -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2278/ (1/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1439/ (2/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2342/ (3/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Giuseppe Vallarelli has uploaded a new change for review. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. refactoring: getMaxMtu updated implementation using max builtin. Improvement to getMaxMtu implementation which now is more succint by using max builtin function. Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Signed-off-by: Giuseppe Vallarelli gvall...@redhat.com --- M vdsm/netconf/ifcfg.py 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/14743/1 diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py index 58dc501..efa83e0 100644 --- a/vdsm/netconf/ifcfg.py +++ b/vdsm/netconf/ifcfg.py @@ -695,12 +695,8 @@ getMaxMtu return the highest value in a connection tree, it check if a vlan, bond that have a higher mtu value -for nic in nics: -mtuval = int(netinfo.getMtu(nic)) -if mtuval mtu: -mtu = mtuval -return mtu +return max(mtu, *[int(netinfo.getMtu(nic)) for nic in nics]) def setNewMtu(self, network, bridged, _netinfo=None): -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1439/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2342/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
Mark Wu has posted comments on this change.
Change subject: vdsm: Add blkIoTune support at vm creation
..
Patch Set 5: I would prefer that you didn't submit this
(5 inline comments)
File vdsm/libvirtvm.py
Line 1178: not
utils.getUserPermissions(constants.QEMU_PROCESS_USER,
Line 1179: self.path)['write']):
Line 1180: diskelem.appendChildWithArgs('readonly')
Line 1181:
Line 1182: if hasattr(self, 'blkIoTune'):
+1
Line 1183: validParamNames = ('total_bytes_sec', 'read_bytes_sec',
Line 1184:'write_bytes_sec', 'total_iops_sec',
Line 1185:'write_iops_sec', 'read_iops_sec')
Line 1186: for key, value in self.blkIoTune.iteritems():
Line 1189: self.blkIoTune[key] = int(value)
Line 1190: if self.blkIoTune[key] = 0:
Line 1191: continue
Line 1192: else:
Line 1193: raise Exception('parameter %s value
should be'
you could use ValueError instead of the generic exception
Line 1194: ' equal or greater than
zero'
Line 1195: % key)
Line 1196: else:
Line 1197: raise Exception('parameter %s name is
invalid' % key)
Line 1194: ' equal or greater than
zero'
Line 1195: % key)
Line 1196: else:
Line 1197: raise Exception('parameter %s name is
invalid' % key)
Line 1198: except ValueError:
except ValueError as e:
e.message = an integer is required for blkIoTune parameter %s' % key
raise
Line 1199: raise Exception('an integer is required for
blkIoTune'
Line 1200: ' parameter %s' % key)
Line 1201:
Line 1202: categories = (bytes, iops)
Line 1199: raise Exception('an integer is required for
blkIoTune'
Line 1200: ' parameter %s' % key)
Line 1201:
Line 1202: categories = (bytes, iops)
Line 1203: for i, category in enumerate(categories):
why do you use enumerate? It looks you don't need the index.
Line 1204: if self.blkIoTune.get('total_' + category + '_sec',
0) and \
Line 1205: self.blkIoTune.get('read_' + category +
'_sec', 0) or \
Line 1206: self.blkIoTune.get('total_' + category +
'_sec', 0) \
Line 1207: and self.blkIoTune.get('write_' + category +
Line 1204: if self.blkIoTune.get('total_' + category + '_sec',
0) and \
Line 1205: self.blkIoTune.get('read_' + category +
'_sec', 0) or \
Line 1206: self.blkIoTune.get('total_' + category +
'_sec', 0) \
Line 1207: and self.blkIoTune.get('write_' + category +
Line 1208:'_sec', 0):
you could change to 'self.blkIoTune.get('total_' + category + '_sec', 0) and
(self.blkIoTune.get('read_' + category + '_sec', 0) or
self.blkIoTune.get('write_' + category + '_sec', 0))
Line 1209: raise Exception('A non-zero total value and
non-zero'
Line 1210: ' read/write value for %s_sec
can not be'
Line 1211: ' set at the same time' %
category)
Line 1212:
--
To view, visit http://gerrit.ovirt.org/14636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2279/ (2/3) -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2343/ (3/3) -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1440/ (1/3) -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
Peter V. Saveliev has uploaded a new change for review.
Change subject: vdsm: fix RTC offset
..
vdsm: fix RTC offset
Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event
with RTC offset from the qemu start -rtc value in seconds. The received offset
should not replace the previous value, but should be added to it. Since the
time update event is relative to the qemu start time, we should store the
initial value and use it for the calculation.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956741
Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Signed-off-by: Peter V. Saveliev p...@redhat.com
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/14750/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 2b76662..bbc833a 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -351,6 +351,7 @@
self.id = self.conf['vmId']
self._volPrepareLock = threading.Lock()
self._initTimePauseCode = None
+self._initTimeRTC = None
self.guestAgent = None
self._guestEvent = 'Powering up'
self._guestEventTime = 0
@@ -852,7 +853,9 @@
def _rtcUpdate(self, timeOffset):
self.log.debug('new rtc offset %s', timeOffset)
with self._confLock:
-self.conf['timeOffset'] = timeOffset
+if self._initTimeRTC is None:
+self._initTimeRTC = long(self.conf['timeOffset'])
+self.conf['timeOffset'] = self._initTimeRTC + long(timeOffset)
def extendDriveVolume(self, vmDrive):
if not vmDrive.blockDev:
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev p...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
Peter V. Saveliev has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix RTC offset
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2279/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1440/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2343/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Martin Sivák has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) This looks good, except for one style comment. File vdsm/netconf/ifcfg.py Line 695: getMaxMtu return the highest value in a connection tree, Line 696: it check if a vlan, bond that have a higher mtu value Line 697: Line 698: Line 699: return max(mtu, *[int(netinfo.getMtu(nic)) for nic in nics]) Can you please split this into two lines? Save the list of mtus and then call max() on it. Although this is correct, it is not easy to read. Line 700: Line 701: def setNewMtu(self, network, bridged, _netinfo=None): Line 702: Line 703: Set new MTU value to network and its interfaces -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2344/ (2/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1441/ (1/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2280/ (3/3) -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 1: (1 inline comment) File vdsm/netconf/ifcfg.py Line 695: getMaxMtu return the highest value in a connection tree, Line 696: it check if a vlan, bond that have a higher mtu value Line 697: Line 698: Line 699: return max(mtu, *[int(netinfo.getMtu(nic)) for nic in nics]) Done Line 700: Line 701: def setNewMtu(self, network, bridged, _netinfo=None): Line 702: Line 703: Set new MTU value to network and its interfaces -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1441/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2344/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Antoni Segura Puimedon has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Looks good to me, but someone else must approve I'll leave the docstring fixing as a thing for the future. -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Dan Kenigsberg has submitted this change and it was merged. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. refactoring: getMaxMtu updated implementation using max builtin. Improvement to getMaxMtu implementation which now is more succint by using max builtin function. Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Signed-off-by: Giuseppe Vallarelli gvall...@redhat.com --- M vdsm/netconf/ifcfg.py 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Giuseppe Vallarelli: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: getMaxMtu updated implementation using max buil...
Dan Kenigsberg has posted comments on this change. Change subject: refactoring: getMaxMtu updated implementation using max builtin. .. Patch Set 2: Looks good to me, approved heh, I'm not crazy for the interim variable either. No biggy. -- To view, visit http://gerrit.ovirt.org/14743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e3beef38675b2f74f2945247b8af1de3eeebc90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change.
Change subject: Test: regression test to catch cross imports.
..
Patch Set 23: I would prefer that you didn't submit this
(1 inline comment)
Only a minor comment.
File tests/crossImportsTests.py.in
Line 31: for sub_dir in sub_dirs]
Line 32: new_path = [path for path in sys.path
Line 33: if os.path.abspath(path)
Line 34: not in exclude_dirs]
Line 35: return new_path
I'd rather have it without the extra variable.
return [path for path in sys.path
if os.path.abspath(path) not in exclude_dirs]
If that is not possible... How about just having the not in line 33 considering
it fits there perfectly?
Line 36:
Line 37:
Line 38: def get_mods(path):
Line 39: return [(file.strip('.py')).strip('.pyc') for file in
--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2281/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2345/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1442/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Test: regression test to catch cross imports.
..
Patch Set 23: (1 inline comment)
File tests/crossImportsTests.py.in
Line 31: for sub_dir in sub_dirs]
Line 32: new_path = [path for path in sys.path
Line 33: if os.path.abspath(path)
Line 34: not in exclude_dirs]
Line 35: return new_path
Done
Line 36:
Line 37:
Line 38: def get_mods(path):
Line 39: return [(file.strip('.py')).strip('.pyc') for file in
--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2345/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Looks good to me, but someone else must approve Let's make sure that it works when running the tests on the source dir and also when having them installed from vdsm-tests -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Use UUID as unique identifier for socket names
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding cpopen as external python package to vdsm
Dan Kenigsberg has posted comments on this change. Change subject: Adding cpopen as external python package to vdsm .. Patch Set 14: Fails; No score I cannot install vdsm-tests since it requires $ rpm -qpR vdsm-tests-4.10.3-0.398.git3b737d4.noarch.rpm |grep vdsm vdsm = 1.2.1-1 -- To view, visit http://gerrit.ovirt.org/13685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor and product id .. Patch Set 5: Looks good to me, but someone else must approve Thanks a lot David for the patch to add support for multiple devices. The current hook suffers from concurrency issues when two VM use the hook since the ownership log is not locked and it is global per all the usb devices controlled by the hook. It should be improved in a later patch following the approach that the sr-iov hook has to handle multiple devices. For the moment, I feel that we can probably take this in as a step towards a better hostusb hook. -- To view, visit http://gerrit.ovirt.org/14237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor and product id .. Patch Set 5: One thing I would want to submit also for consideration for a further patch, now that this patch will pass through all the devices with the same vendor and product id to a host is: Do we want to potentially redefine the custom property so the hook can be called with optional info specifying only a subset (by bus and dev addr)? -- To view, visit http://gerrit.ovirt.org/14237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
Eduardo has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 6: (1 inline comment) File vdsm/alignmentScan.py Line 64: virt-alignment-scan: %d % rc) Line 65: outList = [] Line 66: for line in out: Line 67: outList.append(ScanOutput(*line.split(None, 3))) Line 68: return outList One list is worth a thousand booleans. i think this way is better, you can do if scanResult() and imagine that the empty list is False. -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: No score if running the tests on vdsm-tests (cut) you mean cd-ing in /usr/share/vdsm/tests and from there running the tests. Then it's not going to work due to the relative path '../lib/vdsm' . -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: but I'm always open listening for some hints :-) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Fails In that case :( -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: I would prefer that you didn't submit this (1 inline comment) File tests/crossImportsTests.py.in Line 43: Line 44: @MonkeyPatch(sys, 'path', path_without_vdsm_ext_mod()) Line 45: def test_fail_when_importing_ext_mod(self): Line 46: paths = ['@VDSMDIR@', '../lib/vdsm'] Line 47: for path in paths: Could you not add here a check to see if the path exists and only do the imports in that case? -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring storage.misc: moving watchCmd and its deps to vd...
Zhou Zheng Sheng has posted comments on this change. Change subject: Refactoring storage.misc: moving watchCmd and its deps to vdsm.utils. .. Patch Set 16: I would prefer that you didn't submit this (2 inline comments) Some modules still refer to the old place of ActionStopped and stripNewLines, I mark them in the comments. I'm sorry for not verifying them in previous review. As we move the related things from misc to utils, we find some problems such as the logger's name and the exceptions. I can accept the solution for logging now, we can improve it in future patches. As regard to exception classes, the GeneralException and ActionStopped are moved to utils as well, but these two are storage specific exceptions, you can see there are fields like code and message in them like other storage exceptions. Having these two exceptions in utils maybe a bad idea because it mixes storage specific concepts in utils even though the utils code does not depend on storage code. I think a better way is that define an exception named Stopped in utils and let utils.watchCmd throw it, then define another watchCmd in misc to invoke utils.watchCmd, except the Stopped, change it to storage_exception.ActionStopped and re-raise it. The above are just my thoughts, I -1 for not updating all the reference to the moved classes. File vdsm/storage/misc.py Line 72 Line 73 Line 74 Line 75 Line 76 The vdsm/storage/fileSD.py still refer to misc.stripNewLines not vdsm.utils.stripNewLines . File vdsm/storage/storage_exception.py Line 1017 Line 1018 Line 1019 Line 1020 Line 1021 Modules still have references to storage_exception.ActionStopped are as follow vdsm/storage/fileVolume.py vdsm/storage/blockVolume.py vdsm/storage/image.py vdsm/storage/blockSD.py I think you can either change those files to use vdsm.utils.ActionStopped, or from vdsm.utils import ActionStopped in storage_exception.py . -- To view, visit http://gerrit.ovirt.org/14408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45eaf487b0260863af09087e5114fb836276a750 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1443/ (3/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2282/ (2/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2346/ (1/3) -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add blkIoTune support at vm creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Add blkIoTune support at vm creation .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1443/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2346/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4034648620ed9212c06c12607bb889d97cca9d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2347/ (2/3) -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2283/ (1/3) -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1445/ (1/3) -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2348/ (2/3) -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Adding monitorDomains.
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Adding monitorDomains. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2349/ (1/3) -- To view, visit http://gerrit.ovirt.org/14674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f148764ac030730c93bfd9c8da25a7ea434dc33 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2284/ (3/3) -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Adding monitorDomains.
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Adding monitorDomains. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1446/ (2/3) -- To view, visit http://gerrit.ovirt.org/14674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f148764ac030730c93bfd9c8da25a7ea434dc33 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
