Change in vdsm[master]: vdsmd.init: Add init adapter
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (19 inline comments)
File vdsm/init/daemonAdapter
Line 1: #!/usr/bin/python
I'm OK with the hybrid solution, because I like working step by step. For now,
the initialization tasks are in shell scripts, so it's good to have run_task.sh
in shell as well. For daemon adapter, I think Python is better and cleaner.
Python code is the most obvious method to implement daemon adapter at the time
I was writhing the patch (specifically on argument parsing). Having shell tasks
are because of some historic reason, and in future we can improve the tasks by
re-writing them in Python. However, I'm fine to use shell for daemon adapter as
well.
Line 2: # Copyright 2013 IBM, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 34: parser.add_argument('-u', '--user', dest='user', default=None,
Line 35: metavar='user_name', help='Run as user_name')
Line 36: parser.add_argument('-n', '--renice', dest='renice', default=False,
Line 37: action='store_true',
Line 38: help='Ajust nice according to configuration
file')
Yes, but the nice value may be set outside daemon adapter by the init system,
so I think it's OK to make this optional.
Line 39: parser.add_argument('-r', '--respawn-pid-file',
dest='respawnPidFile',
Line 40: default=None, metavar='respawn_pid_file_path',
Line 41: help='Run with respawn watchdog protection and
'
Line 42: 'specify the respawn pid file path')
Line 38: help='Ajust nice according to configuration
file')
Line 39: parser.add_argument('-r', '--respawn-pid-file',
dest='respawnPidFile',
Line 40: default=None, metavar='respawn_pid_file_path',
Line 41: help='Run with respawn watchdog protection and
'
Line 42: 'specify the respawn pid file path')
Yes. In first case, the vdsm is started directly by systemd or upstart, so the
pid file is useless, but if I write daemon adapter in shell, it forks the vdsm
process, then systemd would need the pid file as a hint to manage vdsm process.
There is a pidfile field available in system service spec file to handle this
case.
I think though the pid file sometimes is useless, it does not harm to have them.
Line 43: args = parser.parse_args(sys.argv[1:])
Line 44: return args
Line 45:
Line 46: if __name__ == '__main__':
Line 51: os.nice(config.getint('vars', 'vdsm_nice'))
Line 52: except OSError as e:
Line 53: sys.stderr.write(daemon adapter: failed to renice, %s %
e)
Line 54:
Line 55: if args.user is not None:
Yes. Downstream init systems knows how to change identity. I keep this in
daemon adapter for some reason. The nice level can be configured in vdsm.conf,
so I can not write a fixed value in vdsmd systemd service file or vdsmd upstart
job, daemon adapter has to read the nice level from vdsm.conf then renice
itself, and the renice needs root privilege, so daemon adapter later has to
drop the privilege and change the identity itself.
Line 56: userPw = pwd.getpwnam(args.user)
Line 57: os.environ.update({
Line 58: 'LOGNAME': userPw.pw_name,
Line 59: 'USER': userPw.pw_name,
Line 53: sys.stderr.write(daemon adapter: failed to renice, %s %
e)
Line 54:
Line 55: if args.user is not None:
Line 56: userPw = pwd.getpwnam(args.user)
Line 57: os.environ.update({
Yes.
Line 58: 'LOGNAME': userPw.pw_name,
Line 59: 'USER': userPw.pw_name,
Line 60: 'LNAME': userPw.pw_name,
Line 61: 'USERNAME': userPw.pw_name})
Line 64:
Line 65: cmd = []
Line 66: if args.respawnPidFile:
Line 67: cmd += [os.path.join(P_VDSM, 'respawn'), '--minlifetime', '10',
Line 68: '--daemon', '--masterpid', args.respawnPidFile]
The downstream init systems already daemonize the process that this daemon
adapter runs, we do not need to daemonize ourself again. So the --daemon here
does not means we daemonize the vdsm, it's just an option for respawn to
redirect std out and err to /dev/null when it runs vdsm. The name is not good
though.
Line 69:
Line 70: cmd.append(os.path.join(P_VDSM, 'vdsm'))
Line 71:
Line 72: env = os.environ
Line 82: os.open(/dev/null, os.O_RDONLY)
Line 83: os.close(1)
Line 84: os.open(/dev/null, os.O_WRONLY)
Line 85: os.close(2)
Line 86: os.open(/dev/null, os.O_WRONLY)
Yes, totally agree. However I get a lot of vdsm debug
Change in vdsm[master]: vdsmd.init: Add init adapter
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd.init: Add init adapter .. Patch Set 1: (1 inline comment) File vdsm/init/daemonAdapter Line 1: #!/usr/bin/python Do we have a plan to implement all the things in Python? It we do, I think daemon adapter is a good start... ;-) Line 2: # Copyright 2013 IBM, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by -- To view, visit http://gerrit.ovirt.org/15578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1956/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2842/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad oma...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1957/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2843/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad oma...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/15445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad oma...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the live diskSizeExtend method
Sergey Gotliv has posted comments on this change. Change subject: vm: add the live diskSizeExtend method .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f0e71d53382a49eb3b43cdf0bc0472f71abdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mom: add mom balloon functional tests for running vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1958/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2844/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/13156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I922568233dc769d83e2fdffe1c24439d13d03d7e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmd.init: Add init adapter
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (6 inline comments)
Thanks!!!
Few more questions... sorry for me bothering you.
File vdsm/init/daemonAdapter
Line 38: help='Ajust nice according to configuration
file')
Line 39: parser.add_argument('-r', '--respawn-pid-file',
dest='respawnPidFile',
Line 40: default=None, metavar='respawn_pid_file_path',
Line 41: help='Run with respawn watchdog protection and
'
Line 42: 'specify the respawn pid file path')
I write daemon adapter in shell, it forks the vdsm process
I do not understand... we use the spawn with for sysvinit and this always
forks, all the other cases has no fork, right?
It does not harm to have but it should be taken care of explicitly like
preparing empty file at init script, chown to the daemon user to allow the
daemon to write into the file.
It is complex and needed only for the spawn at sysvinit, which is actually the
pid we are looking for.
Maybe I miss something...
Line 43: args = parser.parse_args(sys.argv[1:])
Line 44: return args
Line 45:
Line 46: if __name__ == '__main__':
Line 51: os.nice(config.getint('vars', 'vdsm_nice'))
Line 52: except OSError as e:
Line 53: sys.stderr.write(daemon adapter: failed to renice, %s %
e)
Line 54:
Line 55: if args.user is not None:
Can't we move this configuration? Dan?
If not, can't we set -20 level at init script and then reset here to lower
value? as far as I know this should work without root.
If not, I would have preferred to do this via svdsm after startup... but ignore
that one.
Line 56: userPw = pwd.getpwnam(args.user)
Line 57: os.environ.update({
Line 58: 'LOGNAME': userPw.pw_name,
Line 59: 'USER': userPw.pw_name,
Line 64:
Line 65: cmd = []
Line 66: if args.respawnPidFile:
Line 67: cmd += [os.path.join(P_VDSM, 'respawn'), '--minlifetime', '10',
Line 68: '--daemon', '--masterpid', args.respawnPidFile]
as far as I understand sysv is the only that uses respawn, and in this case we
must have respawn to fork, this is what --daemon does.
what I suggest that you add this option to daemonize the respawn or not to the
cmdline of the script so we have control over it, and it will be clear that the
sysv init script expect the script to daemonize, as it currently does
implicitly based on the existence of pid parameter.
Line 69:
Line 70: cmd.append(os.path.join(P_VDSM, 'vdsm'))
Line 71:
Line 72: env = os.environ
Line 82: os.open(/dev/null, os.O_RDONLY)
Line 83: os.close(1)
Line 84: os.open(/dev/null, os.O_WRONLY)
Line 85: os.close(2)
Line 86: os.open(/dev/null, os.O_WRONLY)
And you can call --console-redirect=/dev/null for now, until the other issue is
resolved.
Thanks!
Line 87:
Line 84: os.open(/dev/null, os.O_WRONLY)
Line 85: os.close(2)
Line 86: os.open(/dev/null, os.O_WRONLY)
Line 87:
Line 88: os.execve(cmd[0], cmd, env)
Apart of my reply above to try to set nice=-20 at init then reset it here...
The core parameters of a service are expected to be at standard location...
/etc/sysconfig/service at rpm based.
The problem with systemd is that it is quite primitive (in contrast of what
people may think), it has the nature of environment, but these are not support
this generically... the truly expect people to copy the unit to /etc and modify
it. But this is how systemd is working...
I have another stupid idea... we can use the ExecStartPost to execute renice of
the process provided we have pid... just an idea...
File vdsm/vdsmd.service.in
Line 6:
Line 7: [Service]
Line 8: Type=simple
Line 9: EnvironmentFile=-/etc/sysconfig/vdsm
Line 10: ExecStartPre=@VDSMDIR@/init/run_task.sh pre-start run_init_hooks
gencerts libvirt_reconfigure syslog_available nwfilter dummybr
load_needed_modules tune_system mkdirs test_space test_lo test_conflicting_conf
So the other way around... make systemd and upstart 'pure', and include these
ones in the sysv... :)
Line 11: ExecStart=@PYTHON@ @VDSMDIR@/init/daemonAdapter -u vdsm -n
Line 12: ExecStopPost=@VDSMDIR@/init/run_task.sh post-stop run_final_hooks
Line 13: KillMode=process
Line 14: Restart=always
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv
Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...
Zhou Zheng Sheng has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 10: I would prefer that you didn't submit this
(6 inline comments)
Some minor problems, very close to +1 ;-)
File lib/vdsm/tool/libvirt_configure.py
Line 44:
Line 45: return 0
Line 46:
Line 47:
Line 48: def parseParams(args):
It seems what parseParams does is to verify/check/validate parameters, not
parsing them, so a better name would be checkParams.
Line 49: if len(args) == 0:
Line 50: usageMsg = \
Line 51:
Line 52: Using default conf files:
File lib/vdsm/tool/libvirt_configure.sh.in
Line 243: set_if_default $qlconf auto_disk_leases 0
Line 244: set_if_default $qlconf require_lease_for_disks 0
Line 245:
Line 246: # Configuring auto dump path
Line 247: set_if_default $qconf auto_dump_path \$QEMU_DUMP_PATH\
QEMU_DUMP_PATH is not defined..
Line 248:
Line 249: # Write to all conf files the *end* message of vdsm changes
Line 250: for arg in ${lconf} ${qconf} ${ldconf} ${qlconf}
Line 251: do
Line 304: ;;
Line 305: test_conflict_configurations)
Line 306: echo Checking conflicts ...
Line 307: if [ $# = '2' ]; then
Line 308: test_conflicting_conf $2 $3
If $# equals to '2', then what's the value of $3 here? Maybe the $# should
equal to 3 to enter this block.
Line 309: else
Line 310: test_conflicting_conf $LCONF $QCONF
Line 311: fi
Line 312: RETVAL=$?
File lib/vdsm/tool/Makefile.am
Line 34:__init__.py \
Line 35:dummybr.py \
Line 36:nwfilter.py \
Line 37:libvirt_configure.py \
Line 38:libvirt_configure.sh \
libvirt_configure should not be under a dist_xxx variable, because it is
generated. It's not source, it's a build result. It should be like this.
nodist_vdsmtool_SCRIPTS = \
libvirt_configure.sh \
$(NULL)
and we add
CLEANFILES = \
config.log \
$(nodist_vdsmtool_DATA) \
$(nodist_vdsmtool_SCRIPTS) \
$(NULL)
In this way the libvirt_configure.sh is generated from .in when we make, and
it is installed to vdsm/tool with 0755 permission when we make install, at
last we can remove the 0755 attribute from the vdsm.spec.in because make
install has already assigned the right permission bits to it. I think we
should reply on vdsm.spec as little as possible, because it's distro specific
mechanism.
Line 39:passwd.py \
Line 40:seboolsetup.py \
Line 41:service.py \
Line 42:vdsm-id.py \
File vdsm.spec.in
Line 978: %endif
Line 979: %{python_sitearch}/%{vdsm_name}/tool/dummybr.py*
Line 980: %{python_sitearch}/%{vdsm_name}/tool/nwfilter.py*
Line 981: %{python_sitearch}/%{vdsm_name}/tool/libvirt_configure.py*
Line 982: %attr(0755, -, -)
%{python_sitearch}/%{vdsm_name}/tool/libvirt_configure.sh*
If we write Makefile.am properly, attr 0755 is not needed here, and .sh*
should be .sh.
Line 983: %{python_sitearch}/%{vdsm_name}/tool/passwd.py*
Line 984: %{python_sitearch}/%{vdsm_name}/tool/seboolsetup.py*
Line 985: %{python_sitearch}/%{vdsm_name}/tool/service.py*
Line 986: %{python_sitearch}/%{vdsm_name}/tool/validate_ovirt_certs.py*
File vdsm/vdsmd.init.in
Line 29: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
Line 30: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump
Line 31: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup
Line 32: CORE_PATTERN=/proc/sys/kernel/core_pattern
Line 33: QEMU_DUMP_PATH=/var/log/core
QEMU_DUMP_PATH is not used in vdsmd.init.in, and it's used in
libvirt_configure.sh.in, so it can be moved there.
Line 34: NEEDED_SERVICES=iscsid multipathd ntpd wdmd sanlock network libvirtd
Line 35: supervdsmd
Line 36: CONFLICTING_SERVICES=libvirt-guests
Line 37: VDSM_TOOL=@BINDIR@/vdsm-tool
--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix for after_vm_dehibernate hook not being called
Arik Hadas has uploaded a new change for review.
Change subject: fix for after_vm_dehibernate hook not being called
..
fix for after_vm_dehibernate hook not being called
Due to what seems to be a copy-paste or typo problem, the
after_vm_hibernate hook was called instead of after_vm_dehibernate
hook after the vm is being dehibernated. This patch correct that call.
Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680
Signed-off-by: Arik Hadas aha...@redhat.com
---
M vdsm/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/15656/1
diff --git a/vdsm/hooks.py b/vdsm/hooks.py
index f188956..ddb230a 100644
--- a/vdsm/hooks.py
+++ b/vdsm/hooks.py
@@ -192,7 +192,7 @@
def after_vm_dehibernate(domxml, vmconf={}):
-return _runHooksDir(domxml, 'after_vm_hibernate', vmconf=vmconf,
+return _runHooksDir(domxml, 'after_vm_dehibernate', vmconf=vmconf,
raiseError=False)
--
To view, visit http://gerrit.ovirt.org/15656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix for after_vm_dehibernate hook not being called
Arik Hadas has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix for after_vm_dehibernate hook not being called
Michal Skrivanek has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added code coverage plugin
Yaniv Bronhaim has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 5: Dan, don't you prefer to have default entries for coverage in config.py.in? -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix for after_vm_dehibernate hook not being called
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1959/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2845/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2846/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix for after_vm_dehibernate hook not being called
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix for after_vm_dehibernate hook not being called .. fix for after_vm_dehibernate hook not being called Due to what seems to be a copy-paste or typo problem, the after_vm_hibernate hook was called instead of after_vm_dehibernate hook after the vm is being dehibernated. This patch correct that call. Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680 Signed-off-by: Arik Hadas aha...@redhat.com Reviewed-on: http://gerrit.ovirt.org/15656 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/hooks.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Arik Hadas: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6851c1253efe2fc4a9fbf4568b930b598df45680 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...
Dan Kenigsberg has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Looks good to me, approved Thanks, taken. -- To view, visit http://gerrit.ovirt.org/15445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad oma...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...
Dan Kenigsberg has submitted this change and it was merged. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. QoS feature: Adds bandwitdh elem to a network interface definition. NetworkInterfaceDevice can now generate xml definition for shaping incoming and outgoing traffic supported attributes are the following ones: average, burst and peak. Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Signed-off-by: Giuseppe Vallarelli gvall...@redhat.com Reviewed-on: http://gerrit.ovirt.org/15445 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/libvirtvmTests.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 3 files changed, 46 insertions(+), 2 deletions(-) Approvals: Giuseppe Vallarelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec7c61d2713270dc8e46ee01f155e2ad54c748a5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad oma...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: avoid service action redirections
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: avoid service action redirections .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: avoid service action redirections
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: avoid service action redirections .. vdsm-tool: avoid service action redirections Some smart init system will redirect actions to other init system when the service is not managed natively. This behaviour interferes the parsing of the service action output. Add a decorator _XXXNative to check if a service is managed by a certain init system. _XXXNative tag is then added to every action function to avoid execution of an action on a service that is not managed by that particular init system, so as to avoid redirections. An environment variable is also added for SysV actions to prevent redirection to SystemD, this is specific for those systems with co-existence of SystemD and SysV, and is no harm to those systems with only SysV or with co-existence of Upstart and SysV. Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0 Signed-off-by: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/15099 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/service.py 1 file changed, 75 insertions(+), 12 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/15099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: extend service module to check existence of a s...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: extend service module to check existence of a service .. vdsm-tool: extend service module to check existence of a service Add a service-is-managed command to check if a service is managed by either of the supported init systems. With the decorator _XXXNative in previous commit, the implementation of service-is-managed command is straight forward: just add _XXXNative tag to a action function that always succeeds. Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe Signed-off-by: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/15100 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/service.py 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/15100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: extend service module to check existence of a s...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: extend service module to check existence of a service .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmd.init: ajust libvirt log file
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsmd.init: ajust libvirt log file .. vdsmd.init: ajust libvirt log file Nowadays VDSM configure libvirt daemon to log into /var/log/libvirtd.log. This patch will make vdsm set the log file into the current default location for libvirt logs /var/log/libvirt/libvirtd.conf. Change-Id: Iee325d456cc3d184c0084c4bf547bc126a00938a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=755548 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14842 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee325d456cc3d184c0084c4bf547bc126a00938a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmd.init: ajust libvirt log file
Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init: ajust libvirt log file .. Patch Set 1: Looks good to me, approved Thanks, Douglas. -- To view, visit http://gerrit.ovirt.org/14842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee325d456cc3d184c0084c4bf547bc126a00938a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: modified the after/before_vm_dehibernate hooks to get parameters, and add 'backToSnapshot' parameter which is of boolean type that indicates whether the memory is restored from snapshot or not. -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion
Assaf Muller has uploaded a new change for review. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Added 3.2 to SupportedENGINES in dsaversion Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e Signed-off-by: Assaf Muller amul...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/15663/1 diff --git a/vdsm/dsaversion.py.in b/vdsm/dsaversion.py.in index 246a95a..d6e156b 100644 --- a/vdsm/dsaversion.py.in +++ b/vdsm/dsaversion.py.in @@ -33,7 +33,7 @@ 'version_name': version_name, 'software_version': software_version, 'software_revision': software_revision, -'supportedENGINEs': ['3.0', '3.1'], +'supportedENGINEs': ['3.0', '3.1', '3.2'], 'supportedProtocols': ['2.2', '2.3'], 'clusterLevels': ['3.0', '3.1', '3.2', '3.3'], } -- To view, visit http://gerrit.ovirt.org/15663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion
Assaf Muller has posted comments on this change. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion
Dan Kenigsberg has posted comments on this change. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Patch Set 1: Looks good to me, approved I believe this is indeed required due to vdsm's recent version bump. Without it, ovirt-3.2 does not recognize vdsm-4.11.z. /me should recall that in the future. -- To view, visit http://gerrit.ovirt.org/15663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for editBonding/removeBonding
..
Patch Set 9: (1 inline comment)
File vdsm/netmodels.py
Line 187: if name and nics: # New bonding or edit bonding.
Line 188: slaves = cls._objectivizeSlaves(name, configurator, nics,
mtu,
Line 189: _netinfo)
Line 190: if name in _netinfo.bondings and not options:
Line 191: mtu = max(netinfo.getMtu(name), mtu)
I believe this slipped past me. Probably the not options should be on a
separate if for the following statement.
Line 192: options =
_netinfo.bondings[name]['cfg'].get('BONDING_OPTS')
Line 193: elif name in _netinfo.bondings: # Implicit bonding.
Line 194: mtu = max(netinfo.getMtu(name), mtu)
Line 195: slaves = [Nic(nic, configurator, mtu=mtu,
_netinfo=_netinfo)
--
To view, visit http://gerrit.ovirt.org/15356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ab6fabb01d38c0e23a950bc5b693fe597b7d21c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1961/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2847/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding functional tests for networking
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Adding functional tests for networking
..
Patch Set 19: Fails; I would prefer that you didn't submit this
(5 inline comments)
File tests/functional/Makefile.am
Line 21: vdsmfunctestsdir = ${vdsmtestsdir}/functional
Line 22:
Line 23: dist_vdsmfunctests_PYTHON = \
Line 24:momTests.py \
Line 25:networkTests.py \
utils.py is missing here. Please verify your tests from the
/usr/share/vdsm/tests directory, too.
Line 26:sosPluginTests.py \
Line 27:xmlrpcTests.py \
Line 28:$(NULL)
File tests/functional/networkTests.py
Line 36: vdsm.save_config()
Line 37:
Line 38:
Line 39: @expandPermutations
Line 40: class NetworkTestShould(TestCaseBase):
NetworkTestShould is a surprising name. Classes should usually be named as a
noun. Could you think of a more conventional name?
Line 41:
Line 42: def setUp(self):
Line 43: self.vdsm_net = VdsProxy()
Line 44:
Line 67: status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
Line 68:bond=bond_name,
Line 69:nics=['whatever'],
Line 70:opts={'bridged':
bridged})
Line 71: self.assertEqual(status, neterrors.ERR_BAD_BONDING, msg)
on el6 I get
FAIL: testFailWithInvalidBondingName(bridged=False)
(networkTests.NetworkTestShould)
--
Traceback (most recent call last):
File /usr/share/vdsm/tests/testrunner.py, line 68, in wrapper
return f(self, *args)
File /usr/share/vdsm/tests/functional/networkTests.py, line 71, in
testFailWithInvalidBondingName
self.assertEqual(status, neterrors.ERR_BAD_BONDING, msg)
AssertionError: unknown nic: whatever
you'd better include the status in the msg (here and elsewhere) to help
debugging such occasions.
Line 72:
Line 73: def testFailWithInvalidBridgeName(self):
Line 74: invalid_bridge_names = ('a' * 16, 'a b', 'a\tb', 'a.b', 'a:b')
Line 75: for bridge_name in invalid_bridge_names:
File tests/functional/utils.py
Line 47: Creates a dummy interface, in a fixed number of attempts (100).
Line 48: The dummy interface created has a pseudo-random name (e.g. dummy_85
Line 49: in the format dummy_Number). Assumes root privileges.
Line 50:
Line 51:
I find the randomness hard to digest. But if we have to do it, let's not
re-invent the wheel:
for i in random.sample(xrange(100), 100):
name = dummy_name = 'dummy_%s' % i
if not ip_add_dummy():
return name
else:
raise SkipTest
Or even better, get a random string on module setup, and use it throughout your
tests:
DUMMY_PREFIX = random.sample(string.ascii_letters, 5)
This would make it easier to find out which unittets run owns which dummy.
Line 52: rc = -1
Line 53: attempts = 0
Line 54: dummy_name = None
Line 55:
File tests/testValidation.py
Line 107: ValidateRunningAsRoot decoration.
Line 108:
Line 109: @wraps(f)
Line 110: def wrapper(*args, **kwargs):
Line 111: cmd_modprobe = [modprobe.cmd, dummy]
The assignment can safely go under the condition.
Line 112: if not os.path.exists('/sys/module/dummy'):
Line 113: rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
Line 114: return f(*args, **kwargs)
Line 115: return wrapper
--
To view, visit http://gerrit.ovirt.org/14840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion
Amador Pahim has uploaded a new change for review. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Added 3.3 to SupportedENGINES in dsaversion Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Signed-off-by: Amador Pahim apa...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/15675/1 diff --git a/vdsm/dsaversion.py.in b/vdsm/dsaversion.py.in index d6e156b..6433fb6 100644 --- a/vdsm/dsaversion.py.in +++ b/vdsm/dsaversion.py.in @@ -33,7 +33,7 @@ 'version_name': version_name, 'software_version': software_version, 'software_revision': software_revision, -'supportedENGINEs': ['3.0', '3.1', '3.2'], +'supportedENGINEs': ['3.0', '3.1', '3.2', '3.3'], 'supportedProtocols': ['2.2', '2.3'], 'clusterLevels': ['3.0', '3.1', '3.2', '3.3'], } -- To view, visit http://gerrit.ovirt.org/15675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion
Douglas Schilling Landgraf has posted comments on this change. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion
Amador Pahim has posted comments on this change. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion
Dan Kenigsberg has submitted this change and it was merged. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Added 3.3 to SupportedENGINES in dsaversion Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Signed-off-by: Amador Pahim apa...@redhat.com Reviewed-on: http://gerrit.ovirt.org/15675 Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Amador Pahim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has submitted this change and it was merged. Change subject: introducing virtio-scsi support .. introducing virtio-scsi support Drive class: * makeName - map 'scsi' to 'sd' * getXML: - added 'sgio' flag [1] - device='lun' is used instead of device='disk' for supporting LUN passthrough (which can be used with virtio-scsi). Hence, adding 'driver' tag similarly to 'disk' device. LibvirtVm class: * getUnderlyingDriveInfo - get/set 'sgio' attribute. TestLibvirtvm class: * testControllerXML - test 'virtio-scsi' controller * testDriveXML: - test virtio-scsi image disk - test virtio-scsi LUN passthrough API Schema: * Updated: - VmDiskDeviceInterface - VmDiskDeviceType - VmControllerDevice [1] 'sgio': SCSI Generic IO - filtered/unfiltered (indicates whether the kernel will filter unprivileged SG_IO commands for the disk). Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Signed-off-by: Daniel Erez de...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14681 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M tests/libvirtvmTests.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 3 files changed, 58 insertions(+), 9 deletions(-) Approvals: Federico Simoncelli: Looks good to me, approved Daniel Erez: Verified Dan Kenigsberg: -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
Allon Mureinik has posted comments on this change. Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite. .. Patch Set 14: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01de7dc8bf0a903ebf94d9e33ffad9a195b7de Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Adding functional tests for networking
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: Adding functional tests for networking
..
Patch Set 19: (5 inline comments)
Dan, thanks for the useful feedback I need to understand why that test is
failing on your el6.
File tests/functional/Makefile.am
Line 21: vdsmfunctestsdir = ${vdsmtestsdir}/functional
Line 22:
Line 23: dist_vdsmfunctests_PYTHON = \
Line 24:momTests.py \
Line 25:networkTests.py \
I missed it :(
Line 26:sosPluginTests.py \
Line 27:xmlrpcTests.py \
Line 28:$(NULL)
File tests/functional/networkTests.py
Line 36: vdsm.save_config()
Line 37:
Line 38:
Line 39: @expandPermutations
Line 40: class NetworkTestShould(TestCaseBase):
Ok, it reads this way a network test should:
* add / delete network
* fail with invalid bonding name
It's a matter of style but I can change the name, I don't mind much.
Yes it's uncommon.
Line 41:
Line 42: def setUp(self):
Line 43: self.vdsm_net = VdsProxy()
Line 44:
Line 67: status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
Line 68:bond=bond_name,
Line 69:nics=['whatever'],
Line 70:opts={'bridged':
bridged})
Line 71: self.assertEqual(status, neterrors.ERR_BAD_BONDING, msg)
Ok good idea, I do not know why it fails, it works on my el6™
Line 72:
Line 73: def testFailWithInvalidBridgeName(self):
Line 74: invalid_bridge_names = ('a' * 16, 'a b', 'a\tb', 'a.b', 'a:b')
Line 75: for bridge_name in invalid_bridge_names:
File tests/functional/utils.py
Line 47: Creates a dummy interface, in a fixed number of attempts (100).
Line 48: The dummy interface created has a pseudo-random name (e.g. dummy_85
Line 49: in the format dummy_Number). Assumes root privileges.
Line 50:
Line 51:
I don't get what it's hard to digest. The pseudo-randomness is used to get a
possible unique name when for example N dummy if are created. Btw I find
random.sample an improvement over the use of randrange :-) . Dummies are
created and displaced per unit test. Thanks.
Line 52: rc = -1
Line 53: attempts = 0
Line 54: dummy_name = None
Line 55:
File tests/testValidation.py
Line 107: ValidateRunningAsRoot decoration.
Line 108:
Line 109: @wraps(f)
Line 110: def wrapper(*args, **kwargs):
Line 111: cmd_modprobe = [modprobe.cmd, dummy]
OK, np
Line 112: if not os.path.exists('/sys/module/dummy'):
Line 113: rc, out, err = utils.execCmd(cmd_modprobe, sudo=True)
Line 114: return f(*args, **kwargs)
Line 115: return wrapper
--
To view, visit http://gerrit.ovirt.org/14840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan
Federico Simoncelli has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 11: 1. the verb is an HSM vm-related verb where Image has no meaning: hotplugDisk, diskReplicateStart, etc. After all you're passing a diskSpecs not a PDIV. 2. it's not only about the name but it's about the signature, which should be (vmId, driveSpecs) and not (driveSpecs) 3. are you working with selinux enabled? I got a selinux error when I tried the patch, I didn't investigate much, anyway you could try to check if it can be fixed with sebool or if we need a bz -- To view, visit http://gerrit.ovirt.org/12003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...
Assaf Muller has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 2: (1 inline comment) File vdsm/Makefile.am Line 242: $(DESTDIR)$(sysconfdir)/sysctl.d/vdsm Line 243: Line 244: uninstall-data-sysctl: Line 245: $(RM) $(DESTDIR)$(sysconfdir)/sysctl.d/vdsm Line 246: This is incomplete work. Line 247: install-data-dhclient-hooks: Line 248: $(MKDIR_P) $(DESTDIR)$(sysconfdir)/dhcp/dhclient.d Line 249: $(INSTALL_DATA) sourceRouteDHCP.sh \ Line 250: $(DESTDIR)$(sysconfdir)/dhcp/dhclient.d/sourceRouteDHCP.sh -- To view, visit http://gerrit.ovirt.org/15528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 binary wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1966/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2852/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d315c3294fd7f058cdc840dea329d91a658a304 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: Multiple Gateways Feature
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 12: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1964/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2850/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1965/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2851/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added code coverage plugin
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1967/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2853/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added code coverage plugin
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
File lib/vdsm/config.py.in
Line 269:
Line 270: # Section: [code_coverage]
Line 271: ('code_coverage', [
Line 272:
Line 273: ('enabled', 'false', None),
please spend a few seconds to document the new elements. None - set to True
to enable code coverage measurements
Line 274:
Line 275: ('config_file', '', None),
Line 276:
Line 277: ]),
Line 271: ('code_coverage', [
Line 272:
Line 273: ('enabled', 'false', None),
Line 274:
Line 275: ('config_file', '', None),
Is the empty string a reasonable value? I think that something like
/etc/vdsm/coveragerc
makes more sense.
Line 276:
Line 277: ]),
Line 278: ]
Line 279:
--
To view, visit http://gerrit.ovirt.org/15545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lukas Bednar lbed...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Lukas Bednar lbed...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added code coverage plugin
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1968/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2854/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmd.init: Add init adapter
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (5 inline comments)
File vdsm/init/daemonAdapter
Line 38: help='Ajust nice according to configuration
file')
Line 39: parser.add_argument('-r', '--respawn-pid-file',
dest='respawnPidFile',
Line 40: default=None, metavar='respawn_pid_file_path',
Line 41: help='Run with respawn watchdog protection and
'
Line 42: 'specify the respawn pid file path')
1. Yes, my mistake. shell script can exec a command without fork. With respawn,
it forks VDSM, without respawn, it can exec VDSM directly.
2. Currently the pid file is created by VDSM itself. The SysV init wrapper does
not create the empty pid file nor delete the pid file after stop. Maybe it's a
bug... I think we can add a --no-pidfile option to VDSM main entry to skip
pidfile creation, but I'm not sure if the pidfile is used by other subsystems,
modules, tools, ... So in this patch, I kept all the pid related things the
same as it was.
Line 43: args = parser.parse_args(sys.argv[1:])
Line 44: return args
Line 45:
Line 46: if __name__ == '__main__':
Line 51: os.nice(config.getint('vars', 'vdsm_nice'))
Line 52: except OSError as e:
Line 53: sys.stderr.write(daemon adapter: failed to renice, %s %
e)
Line 54:
Line 55: if args.user is not None:
Good idea, we can have supervdsm renice vdsm, because -20 looks too extreme
even it is only at the start.
Line 56: userPw = pwd.getpwnam(args.user)
Line 57: os.environ.update({
Line 58: 'LOGNAME': userPw.pw_name,
Line 59: 'USER': userPw.pw_name,
Line 64:
Line 65: cmd = []
Line 66: if args.respawnPidFile:
Line 67: cmd += [os.path.join(P_VDSM, 'respawn'), '--minlifetime', '10',
Line 68: '--daemon', '--masterpid', args.respawnPidFile]
Sounds good.
Line 69:
Line 70: cmd.append(os.path.join(P_VDSM, 'vdsm'))
Line 71:
Line 72: env = os.environ
Line 82: os.open(/dev/null, os.O_RDONLY)
Line 83: os.close(1)
Line 84: os.open(/dev/null, os.O_WRONLY)
Line 85: os.close(2)
Line 86: os.open(/dev/null, os.O_WRONLY)
Done
Line 87:
Line 84: os.open(/dev/null, os.O_WRONLY)
Line 85: os.close(2)
Line 86: os.open(/dev/null, os.O_WRONLY)
Line 87:
Line 88: os.execve(cmd[0], cmd, env)
I think your first idea is better, use supervdsm to renice vdsm. The vdsm main
process passes its pid and required nice level to supervdsm, then supervice
renice the pid, simple and clean. Care must be taken to make sure the renice
action happens before vdsm forks any child.
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added code coverage plugin
Dan Kenigsberg has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lukas Bednar lbed...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RAM snapshots feature
Dan Kenigsberg has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
(A very partial review)
File vdsm/hooks.py
Line 188:
Line 189:
Line 190: def before_vm_dehibernate(domxml, vmconf={}, params={}):
Line 191: return _runHooksDir(domxml, 'before_vm_dehibernate',
vmconf=vmconf,
Line 192: params=params)
Please document the new params in the man page.
Line 193:
Line 194:
Line 195: def after_vm_dehibernate(domxml, vmconf={}, params={}):
Line 196: return _runHooksDir(domxml, 'after_vm_hibernate', vmconf=vmconf,
File vdsm/vm.py
Line 2859: self.setDownStatus(ERROR, 'failed to start libvirt vm')
Line 2860: return
Line 2861: self._domDependentInit()
Line 2862:
Line 2863: def _correctDiskVolumes(self, srcDomXML):
I think that update is a better term.
Line 2864:
Line 2865: Update each image in the given XML to point to the right
volume.
Line 2866: Each image should have a newer volume than the one that was
the
Line 2867: newer when the snapshot was taken, since we create new volume
Line 2870: for vmDrive in self._devices[DISK_DEVICES]:
Line 2871: if vmDrive.device == 'disk':
Line 2872: pathToImageDir = os.path.dirname(vmDrive.path)
Line 2873: pattern = '(' + pathToImageDir + '.*)\''
Line 2874: mo = re.search(pattern, srcDomXML)
Doing a blind re.replace on an XML is a bug waiting to happen. The XML has
structure and it is safer to use it. Please parse the XML and replace only the
element you expect. Unless, of course, you have a particular intention here.
Line 2875: if mo:
Line 2876: srcDomXML = srcDomXML.replace(mo.group(1),
vmDrive.path)
Line 2877: return srcDomXML
Line 2878:
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: add the BLOCK_SIZE constant
Douglas Schilling Landgraf has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia517ec858fb0d7ee45323b7e2a3584c0858222f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
