Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File lib/vdsm/config.py.in
Line 269:
Line 270: # Section: [code_coverage]
Line 271: ('code_coverage', [
Line 272:
Line 273: ('enabled', 'false', None),
please spend a few seconds to document the new elements. None -> "set to True
to enable code coverage measurements"
Line 274:
Line 275: ('config_file', '', None),
Line 276:
Line 277: ]),
Line 271: ('code_coverage', [
Line 272:
Line 273: ('enabled', 'false', None),
Line 274:
Line 275: ('config_file', '', None),
Is the empty string a reasonable value? I think that something like
/etc/vdsm/coveragerc
makes more sense.
Line 276:
Line 277: ]),
Line 278: ]
Line 279:
--
To view, visit http://gerrit.ovirt.org/15545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb465f7723abad9698aa86bedf2ffc25df55713
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lukas Bednar <lbed...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Lukas Bednar <lbed...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
