Change in vdsm[master]: vdsm: Refactoring the device dict creation

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Refactoring the device dict creation
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: Refactoring the device dict creation

2013-10-12 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: Refactoring the device dict creation
..


vdsm: Refactoring the device dict creation

The device dictionaries are created on multiple different locations and
explicitly.
To avoid this duplication we're now moving it to one location where we
define an immutable tuple of tuples and generate the dictionaries from
there.

Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19733
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/vm.py
1 file changed, 17 insertions(+), 25 deletions(-)

Approvals:
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..


Patch Set 3: Code-Review-1

(1 comment)


File vdsm/clientIF.py
Line 303: volPath = self._getUUIDSpecPath(drive[UUID])
Line 304: 
Line 305: # leave path == '' for empty cdrom and floppy drives ...
Line 306: elif (drive['device'] in ('cdrom', 'floppy') and
Line 307:   hasattr(drive, 'specParams') and
It's awfully confusing but here drive is a dict. Keep using 'in'.

Also, IMO we should not about ['specParams']['path']. Please explain why we 
should keep it.
Line 308:   drive.specParams.get('path', '') == '' and
Line 309:   drive.get('path', '') == ''):
Line 310: volPath = ''
Line 311: 


-- 
To view, visit http://gerrit.ovirt.org/20074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add IPv6 support to configNetwork

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Add IPv6 support to configNetwork
..


Patch Set 6: Code-Review+1

(1 comment)


File tests/functional/networkTests.py
Line 1424: {'nic': nic, 'bootproto': 'static', 'ipv6addr': 
IPv6_ADDRESS,
Line 1425:  'ipv6gateway': IPv6_GATEWAY, 'ipaddr': IP_ADDRESS,
Line 1426:  'gateway': IP_GATEWAY,
Line 1427:  'netmask': prefix2netmask(int(IP_CIDR))}}
Line 1428: for network in networks:
for network, netdict in networks.iteritems()

is more stylish.
Line 1429: with self.vdsm_net.pinger():
Line 1430: status, msg = self.vdsm_net.setupNetworks(
Line 1431: {network: networks[network]}, {}, {})
Line 1432: self.assertEqual(status, SUCCESS, msg)


-- 
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: add logging to _getUnderlyingDriveInfo

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..


Patch Set 4: Code-Review-1

(1 comment)


File vdsm/vm.py
Line 4673:   'address': address, 'type': devType, 
'boot': boot}
Line 4674: 
Line 4675: # display indexed pairs of ordered values from 2 dicts
Line 4676: logfunc = lambda a, b: dict((k, (v, getattr(b, k) if 
hasattr(b, k)
Line 4677:  else None)) for (k, v) in 
a.items())
I prefer that you fix d.__str__ to print only the fields that we care about.
Line 4678: 
Line 4679: self.log.debug('Found drive with attributes %s', 
deviceDict)
Line 4680: for d in self._devices[DISK_DEVICES]:
Line 4681: if d.path == devPath:


-- 
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I884e6b25c5bcb71ee24ad9ebad8df7c2775c5e19
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add Patch class for fixture monkey patching

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add Patch class for fixture monkey patching
..


Patch Set 2:

(2 comments)


File tests/monkeypatch.py
Line 30: #
Line 31: # class TestSomething():
Line 32: #
Line 33: # def setUp(self):
Line 34: # self.patch = monkeypatch.Patch([
A class decorator could also help avoid initializing a data member out of 
__init__.
Line 35: # (subprocess, 'Popen', lambda x: None),
Line 36: # (os, 'chown', lambda *x: 0)
Line 37: # ])
Line 38: #



File tests/monkeypatchTests.py
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
I love tests and examples, but this test is as complex as the tested feature, 
which is to be used only in other tests.
Line 21: from testrunner import VdsmTestCase
Line 22: 
Line 23: import monkeypatch
Line 24: 


-- 
To view, visit http://gerrit.ovirt.org/19881
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 3:

Thanks Sandro for fixing this patch. I still cannot take it since it depends on 
a faulty patch.

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bugfix: UpdateVmDevice QoS

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: bugfix: UpdateVmDevice QoS
..


Patch Set 6:

(1 comment)


File vdsm.spec.in
Line 117: Requires: libvirt-daemon-driver-nwfilter
Line 118: Requires: libvirt-daemon-driver-qemu
Line 119: %else
Line 120: %if 0%{?rhel}
Line 121: Requires: libvirt = 0.10.2-29.el6
Or https://bugzilla.redhat.com/show_bug.cgi?id=1017198 is solved.
Line 122: %else
Line 123: Requires: libvirt = 1.0.2-1
Line 124: %endif
Line 125: %endif


-- 
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches