Dan Kenigsberg has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
....................................................
File tests/functional/networkTests.py
Line 1424: {'nic': nic, 'bootproto': 'static', 'ipv6addr':
IPv6_ADDRESS,
Line 1425: 'ipv6gateway': IPv6_GATEWAY, 'ipaddr': IP_ADDRESS,
Line 1426: 'gateway': IP_GATEWAY,
Line 1427: 'netmask': prefix2netmask(int(IP_CIDR))}}
Line 1428: for network in networks:
for network, netdict in networks.iteritems()
is more stylish.
Line 1429: with self.vdsm_net.pinger():
Line 1430: status, msg = self.vdsm_net.setupNetworks(
Line 1431: {network: networks[network]}, {}, {})
Line 1432: self.assertEqual(status, SUCCESS, msg)
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Petr Šebek <pse...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
