Change in vdsm[master]: Add iproute2 configurator
Mark Wu has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bugfix: UpdateVmDevice QoS
..
bugfix: UpdateVmDevice QoS
QoS was not handled in method Vm._updateInterfaceDevice.
Inbound/outbound is kept in current state if related parameter is missing in
specParams. It is deleted if it is in specParams but empty ({'inbound':{}}).
Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Bug-Url: https://bugzilla.redhat.com/1002300
Signed-off-by: Petr Sebek pse...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19545
Reviewed-by: Eyal Edri ee...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm.spec.in
M vdsm/vm.py
2 files changed, 35 insertions(+), 12 deletions(-)
Approvals:
Eyal Edri: Looks good to me, but someone else must approve
Petr Šebek: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Dan Kenigsberg has posted comments on this change. Change subject: bugfix: UpdateVmDevice QoS .. Patch Set 6: Code-Review+2 Dependency is finally available http://mirror.centos.org/centos-6/6.5/os/x86_64/Packages/libvirt-0.10.2-29.el6.x86_64.rpm -- To view, visit http://gerrit.ovirt.org/19545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
oVirt Jenkins CI Server has posted comments on this change. Change subject: bugfix: UpdateVmDevice QoS .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/70/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom
Michal Skrivanek has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 16: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5053/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/71/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 20: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5942/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5054/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/72/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 16: There's still outstanding comments by Yaniv (I haven't forgotten them). -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5851/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5943/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5055/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
Martin Polednik has posted comments on this change. Change subject: clientIF: Fix use of getConfDevices .. Patch Set 2: Verified+1 manually verified that the function is passed the same parameters as before using log messages inside the functions automated functional test is currently not possible due to expcetions in recoverExistingVms being caught and logged, making the test pass even when failure occurs -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added netinfoTests:testGetEmpty
Antoni Segura Puimedon has posted comments on this change. Change subject: Added netinfoTests:testGetEmpty .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb1d18eeb697de6bf8d35ab9748a61324fde9ac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: report migration status in migrateStatuses()
Dan Kenigsberg has abandoned this change. Change subject: vdsm: report migration status in migrateStatuses() .. Abandoned going to be reported by getAllVmStats -- To view, visit http://gerrit.ovirt.org/15125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idc32fa00eaa1b90c3ba9d0afffdeb1cdd8150f9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: migration progress: count memRemaining also
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5852/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5944/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5056/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f37a507ead4cccf835302d25cd02eb344bbcb1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: migration progress: count memRemaining also
Martin Polednik has posted comments on this change. Change subject: vdsm: migration progress: count memRemaining also .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/15124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f37a507ead4cccf835302d25cd02eb344bbcb1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File client/vdsClient.py
Line 1922: 'Stops the emulation and destroys the virtual
machine.'
Line 1923: ' This is not a shutdown.'
Line 1924: )),
Line 1925: 'shutdown': (serv.do_shutdown,
Line 1926: ('vmId delay message '
missing delay description
Line 1927: '[timeout:int] [reboot:bool] [force:bool]',
Line 1928: 'Stops the emulation and graceful shutdown the
virtual',
Line 1929: ' machine.',
Line 1930: 'o timeout: number of seconds to wait before
proceeding '
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1725: self.chain.start()
Line 1726: return {'status': {'code': doneCode['code'],
Line 1727:'message':
self.desc['returnMsg']}}
Line 1728: else:
Line 1729: return errCode['noGraceful']
something like no more callback to try is better, e.g. if you use force and
it fails, or the callbacks are empty
Line 1730: except Exception:
Line 1731: self.vm.log.error({action} failed.format(**self.desc),
Line 1732: exc_info=True)
Line 1733: message = 'Failed to {action} VM.'
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1726: return {'status': {'code': doneCode['code'],
Line 1727:'message':
self.desc['returnMsg']}}
Line 1728: else:
Line 1729: return errCode['noGraceful']
Line 1730: except Exception:
Comment: If we reach this point it means that force was not passed.
Line 1731: self.vm.log.error({action} failed.format(**self.desc),
Line 1732: exc_info=True)
Line 1733: message = 'Failed to {action} VM.'
Line 1734: if not self.force:
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Federico Simoncelli has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 35: Code-Review+1 I see just minor comments. +1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncproc: make read synchronous
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncproc: make read synchronous .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5853/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5945/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5057/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 4: Code-Review-1
(2 comments)
File vdsm/vm.py
Line 2451: 'message': 'Machine shut down'}}
Line 2452:
Line 2453: def pmWakeup(self):
Line 2454: try:
Line 2455: self._connection.virDomainPMWakeup()
shouldn't this be something like:
self._dom.pMWakeup(...)
Line 2456: except:
Line 2457: self.log.error(Wake up failed, exc_info=True)
Line 2458: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2459: 'message': 'Failed to wake up VM.'}}
Line 2465: targets = {'mem': libvirt.VIR_NODE_SUSPEND_TARGET_MEM,
Line 2466:'disk': libvirt.VIR_NODE_SUSPEND_TARGET_DISK,
Line 2467:'hybrid':
libvirt.VIR_NODE_SUSPEND_TARGET_HYBRID}
Line 2468:
Line 2469:
self._connection.virDomainPMSuspendForDuration(targets[target],
shouldn't this be something like:
self._dom.pMSuspendForDuration(...)
Line 2470:0, 0)
Line 2471: except:
Line 2472: self.log.error(Suspend failed, exc_info=True)
Line 2473: return {'status': {'code':
errCode['exist']['status']['code'],
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Federico Simoncelli has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 14: (1 comment) File vdsm_api/vdsmapi-schema.json Line 1002: 'emulatedMachines': ['str'], 'ISCSIInitiatorName': 'str', Line 1003: 'HBAInventory': 'HbaInventory', 'vmTypes': ['VmType'], Line 1004: 'memSize': 'uint', 'reservedMem': 'uint', Line 1005: 'guestOverhead': 'uint', 'netConfigDirty': 'bool', Line 1006: 'rngSources': ['str']}} this should be a list of VmRngDeviceSource Line 1007: Line 1008: ## Line 1009: # @Host.getCapabilities: Line 1010: # -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Martin Sivák has abandoned this change. Change subject: Allow setting just a single value in MoM policy .. Abandoned This is not needed in ovirt-3.3. -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom
Federico Simoncelli has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(6 comments)
File lib/vdsm/tool/upgrade.py
Line 41:
Line 42: To get more functionality you may use this module's 'upgrade'
Line 43: decorator. It removes all boilerplate code, makes sure to run
Line 44: the upgrade only if needed and to automatically call 'seal'
Line 45: if no exception was thrown.
Done
Line 46:
Line 47: def __init__(self, upgradeName):
Line 48: self.upgradeName = upgradeName
Line 49: self.upgradeFilePath = os.path.join(constants.P_VDSM_LIB,
Line 45: if no exception was thrown.
Line 46:
Line 47: def __init__(self, upgradeName):
Line 48: self.upgradeName = upgradeName
Line 49: self.upgradeFilePath = os.path.join(constants.P_VDSM_LIB,
Done
Line 50: upgrade,
self.upgradeName)
Line 51: try:
Line 52: logging.config.fileConfig(LOGGER_CONF_FILE)
Line 53: self.log = logging.getLogger('upgrade')
Line 51: try:
Line 52: logging.config.fileConfig(LOGGER_CONF_FILE)
Line 53: self.log = logging.getLogger('upgrade')
Line 54: except Exception:
Line 55: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Done
Line 56: level=logging.DEBUG)
Line 57: logging.error(Could not init proper logging,
exc_info=True)
Line 58: self.log = logging
Line 59:
Line 63: def seal(self):
Line 64:
Line 65: Mark the upgrade as a success
Line 66:
Line 67: touchFile(self.upgradeFilePath)
Done
Line 68: self.log.debug(Upgrade %s successfully performed %
self.upgradeName)
Line 69:
Line 70: def __enter__(self):
Line 71:
Line 73: will still be output to that logger. However, logging done by
accessing
Line 74: logging directly (Thus using the root logger) will be
'hijacked'
Line 75: to the Upgrade's log instead.
Line 76:
Line 77: self.oldRoot = logging.root
New approach implemented in the following patch sets.
Line 78: logging.root = self.log
Line 79: return self
Line 80:
Line 81: def __exit__(self, type, value, traceback):
Line 91: upgrade.log.debug(Running upgrade %s %
upgradeName)
Line 92: try:
Line 93: f(*args, **kwargs)
Line 94: except Exception:
Line 95: upgrade.log.exception(Failed to run %s %
Done
Line 96: upgradeName)
Line 97: return 1
Line 98: else:
Line 99: upgrade.seal()
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Douglas Schilling Landgraf has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 2: Looks good to me but please click on verified if you tested your patch and it worked. Also, you might want to add your name in AUTHORS as a contributor. -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 17: Verified+1 All outstanding comments handled. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 17: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5854/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5947/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5058/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/73/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5855/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5059/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/74/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Humble Devassy Chirammal has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 1: (3 comments) Commit Message Line 3: AuthorDate: 2013-08-11 12:45:33 +0530 Line 4: Commit: Humble Chirammal hchir...@redhat.com Line 5: CommitDate: 2013-08-11 12:53:03 +0530 Line 6: Line 7: hooks: macbind - This hook support binding specified Done Line 8: mac address to custom/other bridge than the currently defined Line 9: bridge in ovirt. This hook is also capable of binding Line 10: a mac address to openvswitch bridge. Line 11: File vdsm_hooks/macbind/README Line 1: macbind vdsm hook: Line 2: Line 3: This hook goes through all of the VM's interfaces and manipulate its Done Line 4: XML file acccording to the input. This can be used to attach a VM nic Line 5: to a specific bridge which is available in the hypervisor for 'that' VM run Line 6: or permanently. Line 7: Line 11: than the defined/default bridge for that NIC. Line 12: Line 13: Line 14: Syntax: Line 15:macbind=macaddress-brName-portType,... As discussed, this feature is per VM and not per virtual nic. User have an option to change the attachment of one or more virtual nic to different bridges in that specific 'vm run', even-though the vnic is permanently attached to a different bridge. Also, there had a user requirement for this feature and they didnt find any issues to achieve the goal with this patch. Line 16: Line 17: where: Line 18: Line 19: macaddress: specify a macaddress which need to be attached to the VM -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Timothy Asir has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5856/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5948/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5060/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
Amador Pahim has uploaded a new change for review.
Change subject: vdsm-hooks: fix malformed libvirt xml
..
vdsm-hooks: fix malformed libvirt xml
Missing snapshot=no attribute is leding Storage Live Migration
to fail.
This patch adds snapshot=no attribute to vdsm-hooks adding
disks/directlun.
Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036111
Signed-off-by: Amador Pahim apa...@redhat.com
---
M vdsm_hooks/directlun/before_vm_start.py
M vdsm_hooks/scratchpad/before_vm_start.py
M vdsm_hooks/vmdisk/before_vm_start.py
3 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/21913/1
diff --git a/vdsm_hooks/directlun/before_vm_start.py
b/vdsm_hooks/directlun/before_vm_start.py
index bde62a2..4de5875 100755
--- a/vdsm_hooks/directlun/before_vm_start.py
+++ b/vdsm_hooks/directlun/before_vm_start.py
@@ -25,7 +25,7 @@
def createDiskElement(domxml, devpath, lunid, options):
'''
-disk device=disk type=block
+disk device=disk type=block snapshot=no
source dev=/dev/mapper/lunid/
target bus=virtio dev=vda/
driver cache=none error_policy=stop name=qemu type=raw/
@@ -35,6 +35,7 @@
disk = domxml.createElement('disk')
disk.setAttribute('device', 'disk')
disk.setAttribute('type', 'block')
+disk.setAttribute('snapshot', 'no')
source = domxml.createElement('source')
source.setAttribute('dev', devpath)
diff --git a/vdsm_hooks/scratchpad/before_vm_start.py
b/vdsm_hooks/scratchpad/before_vm_start.py
index 2f2fe3f..2e5ddc6 100755
--- a/vdsm_hooks/scratchpad/before_vm_start.py
+++ b/vdsm_hooks/scratchpad/before_vm_start.py
@@ -53,7 +53,7 @@
def add_disk(domxml, path):
'''
Create libvirt xml node
-disk device=disk type=file
+disk device=disk type=file snapshot=no
source file=[path to image]/
driver cache=writeback error_policy=stop type=raw/
/disk
@@ -62,6 +62,7 @@
disk = domxml.createElement('disk')
disk.setAttribute('device', 'disk')
disk.setAttribute('type', 'file')
+disk.setAttribute('snapshot', 'no')
source = domxml.createElement('source')
source.setAttribute('file', path)
diff --git a/vdsm_hooks/vmdisk/before_vm_start.py
b/vdsm_hooks/vmdisk/before_vm_start.py
index 0d3ee0a..c08c645 100755
--- a/vdsm_hooks/vmdisk/before_vm_start.py
+++ b/vdsm_hooks/vmdisk/before_vm_start.py
@@ -27,7 +27,7 @@
def createDiskElement(domxml, devpath, drivertype):
'''
-disk device=disk type=file
+disk device=disk type=file snapshot=no
source file=/net/myhost/myimage.img/
target bus=virtio dev=vda/
driver cache=none error_policy=stop name=qemu type=qcow2/
@@ -37,6 +37,7 @@
disk = domxml.createElement('disk')
disk.setAttribute('device', 'disk')
disk.setAttribute('type', 'file')
+disk.setAttribute('snapshot', 'no')
source = domxml.createElement('source')
source.setAttribute('file', devpath)
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-hooks: fix malformed libvirt xml .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5949/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5061/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
Federico Simoncelli has posted comments on this change. Change subject: clientIF: Fix use of getConfDevices .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
Assaf Muller has posted comments on this change. Change subject: Quarantine ovirt-3.0.0 network upgrade .. Patch Set 3: (1 comment) File vdsm/clientIF.py Line 394: # we prefer running this code in external thread to avoid blocking Line 395: # API response. Line 396: self._initializingLibvirt() Line 397: Line 398: vdsmVms = self._getVDSMVms() caps.CpuTopology makes a call to libvirt so I kept the comment where it is. Line 399: #Recover Line 400: for v in vdsmVms: Line 401: vmId = v.UUIDString() Line 402: if not self._recoverVm(vmId): -- To view, visit http://gerrit.ovirt.org/20803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
Shahar Havivi has posted comments on this change. Change subject: vdsm-hooks: fix malformed libvirt xml .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
Dan Kenigsberg has submitted this change and it was merged. Change subject: clientIF: Fix use of getConfDevices .. clientIF: Fix use of getConfDevices getConfDevices was merged into buildConfDevices in commit Ifd3a209967f97a55fe861c4446e8f93e1a1da08e Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Signed-off-by: Yeela Kaplan ykap...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21832 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Martin Polednik mpole...@redhat.com Tested-by: Martin Polednik mpole...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/clientIF.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Improve logging
Ohad Basan has posted comments on this change. Change subject: domainMonitor: Improve logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
Antoni Segura Puimedon has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 3:
(2 comments)
File init/vdsmd_init_common.sh.in
Line 200: return 0
Line 201: }
Line 202:
Line 203: task_upgrade_300_nets(){
Line 204: $VDSM_TOOL upgrade-3.0.0-networks
I agree with Dan. Better catch and stop.
Line 205: }
Line 206: pre-start tasks end
Line 207:
Line 208:
File lib/vdsm/tool/upgrade_300_networks.py
Line 26: from vdsm.tool import expose
Line 27: from vdsm.tool.upgrade import Upgrade
Line 28:
Line 29: sys.path.append(/usr/share/vdsm)
Line 30: from netconf import ifcfg
Rather the opposite should happen. And vdsm-tool should reside in P_VDSM anyway.
Line 31:
Line 32:
Line 33: def isNeeded(networks, bridges):
Line 34: return (MANAGEMENT_NETWORK not in networks and
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm-hooks: fix malformed libvirt xml .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5062/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge This hook
support binding specified mac address to custom/other bridge than the currently
defined bridge in ovirt. This hook is also capable of binding a mac address to
openvswitch bridge.
..
Patch Set 3:
(1 comment)
Some suggestion to get the parsing for free.
File vdsm_hooks/macbind/README
Line 11: than the defined/default bridge for that NIC.
Line 12:
Line 13:
Line 14: Syntax:
Line 15:macbind=macaddress-brName-portType,...
For consistency with other networking hooks (like vmfex one) I'd appreciate if
the syntax would change to:
{'xx:xx:xx:xx:xx:xx': {'bridge': brName, 'portType': port}, ...}
then for reading it, one would do:
macbindDefs = ast.literal_eval(os.environ['macbind'])
port types could be probably constants as well.
Line 16: where:
Line 17:
Line 18: macaddress: specify a macaddress which need to be attached to the VM
Line 19: brName: Bridge Name available in hypervisor
--
To view, visit http://gerrit.ovirt.org/17895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncproc: make read synchronous
Antoni Segura Puimedon has posted comments on this change. Change subject: asyncproc: make read synchronous .. Patch Set 2: (1 comment) File lib/vdsm/utils.py Line 897 Line 898 Line 899 Line 900 Line 901 Why is this comment line removed? -- To view, visit http://gerrit.ovirt.org/21897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Assaf Muller has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 3: Wouldn't it make more sense to implement this hook per vnic? (You can use per-device custom properties introduced in 3.3). -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(2 comments)
File client/vdsClient.py
Line 1922: 'Stops the emulation and destroys the virtual
machine.'
Line 1923: ' This is not a shutdown.'
Line 1924: )),
Line 1925: 'shutdown': (serv.do_shutdown,
Line 1926: ('vmId delay message '
Done
Line 1927: '[timeout:int] [reboot:bool] [force:bool]',
Line 1928: 'Stops the emulation and graceful shutdown the
virtual',
Line 1929: ' machine.',
Line 1930: 'o timeout: number of seconds to wait before
proceeding '
File vdsm/vm.py
Line 1726: return {'status': {'code': doneCode['code'],
Line 1727:'message':
self.desc['returnMsg']}}
Line 1728: else:
Line 1729: return errCode['noGraceful']
Line 1730: except Exception:
Done
Line 1731: self.vm.log.error({action} failed.format(**self.desc),
Line 1732: exc_info=True)
Line 1733: message = 'Failed to {action} VM.'
Line 1734: if not self.force:
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 36: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5859/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5063/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Antoni Segura Puimedon has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 3: @Assaf, this was already discussed on the previous patch sets and they want it per VM. -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
Sergey Gotliv has posted comments on this change. Change subject: vdsm-hooks: fix malformed libvirt xml .. Patch Set 1: Code-Review+1 (3 comments) Commit Message Line 4: Commit: Amador Pahim apa...@redhat.com Line 5: CommitDate: 2013-12-02 09:58:01 -0300 Line 6: Line 7: vdsm-hooks: fix malformed libvirt xml Line 8: This is not a malformed xml. This patch is preventing creation of a snapshot of direct lun, right? Line 9: Missing snapshot=no attribute is leding Storage Live Migration Line 10: to fail. Line 11: This patch adds snapshot=no attribute to vdsm-hooks adding Line 12: disks/directlun. Line 6: Line 7: vdsm-hooks: fix malformed libvirt xml Line 8: Line 9: Missing snapshot=no attribute is leding Storage Live Migration Line 10: to fail. s/leding/leading Line 11: This patch adds snapshot=no attribute to vdsm-hooks adding Line 12: disks/directlun. Line 13: Line 14: Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Line 8: Line 9: Missing snapshot=no attribute is leding Storage Live Migration Line 10: to fail. Line 11: This patch adds snapshot=no attribute to vdsm-hooks adding Line 12: disks/directlun. Adding disks. Line 13: Line 14: Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036111 -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-hooks: fix malformed libvirt xml
Sergey Gotliv has posted comments on this change. Change subject: vdsm-hooks: fix malformed libvirt xml .. Patch Set 1: Adding maintainers. -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Assaf Muller has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 3: Alright. -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
oVirt Jenkins CI Server has posted comments on this change. Change subject: Quarantine ovirt-3.0.0 network upgrade .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5860/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5952/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5064/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/75/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
Assaf Muller has posted comments on this change. Change subject: Quarantine ovirt-3.0.0 network upgrade .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/20803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: declate alignmentScanTests as broken
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: declate alignmentScanTests as broken .. Patch Set 1: Code-Review+1 Since there are more reports than just jenkins, I switch my vote. -- To view, visit http://gerrit.ovirt.org/21871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: Add missing snapshot=no attribute to disk el...
Sergey Gotliv has posted comments on this change. Change subject: vdsm hooks: Add missing snapshot=no attribute to disk ellements. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: Add missing snapshot=no attribute to disk el...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: Add missing snapshot=no attribute to disk ellements. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5953/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5065/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6422c45450ffc65e4fe84ab7d66a30a285dd42a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Yaniv Bronhaim has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Yaniv Bronhaim has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added netinfoTests:testGetEmpty
Dan Kenigsberg has posted comments on this change. Change subject: Added netinfoTests:testGetEmpty .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb1d18eeb697de6bf8d35ab9748a61324fde9ac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster: correct parameter for creating hookpath in verb hoo...
Dan Kenigsberg has posted comments on this change. Change subject: gluster: correct parameter for creating hookpath in verb hookAdd. .. Patch Set 4: Code-Review+2 same as master -- To view, visit http://gerrit.ovirt.org/21538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Nir Soffer has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14:
(2 comments)
File vdsm/caps.py
Line 214: return ''
Line 215:
Line 216:
Line 217: def _getRngSources():
Line 218: sources = []
it could be nicer to have
return [source for (source, path) in RNG_SOURCES.iteritems()
if os.path.exists(path)]
(non blocker, just quicker, nicer and more pythonic).
Line 219: for source, path in RNG_SOURCES.items():
Line 220: if os.path.exists(path):
Line 221: sources.append(source)
Line 222:
File vdsm_api/vdsmapi-schema.json
Line 2693: #
Line 2694: # Since: 4.12.0
Line 2695: ##
Line 2696: {'enum': 'VmRngDeviceSource',
Line 2697: 'data': ['random', 'hwrng']}
it's going to be new in v4.14.0
Line 2698:
Line 2699: ##
Line 2700: # @VmRngDeviceSpecParams:
Line 2701: #
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 6: Ok, I'm convinced that we have to maintain the specParam nonsese (though it could be better if the explanation was in the commit message itself). Please send an empty specParam[path] in one of the functional/virtTests to verify this is not broken again. We have to increase the test coverage. -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: new option to show VDSM configuration
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: new option to show VDSM configuration .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5954/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5066/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: new option to show VDSM configuration
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsClient: new option to show VDSM configuration .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c3f2d2588d3963c66bad42e469e78f1393104b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Improve logging when pool is destroyed
Nir Soffer has uploaded a new change for review. Change subject: sp: Improve logging when pool is destroyed .. sp: Improve logging when pool is destroyed When pool is destroyed, it tries to stop monitoring domains. I suspect that this is the root cause of bug 1032925. This patch adds proper logging to this thread to prove my theory. The real fix seems to be deleting __del__ as we already stop monitoring domains when pool is disconnected. Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b Bug-Url: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/sp.py 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/21932/1 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 31e0bcd..6253bb7 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -142,7 +142,13 @@ def __del__(self): if len(self.domainMonitor.poolMonitoredDomains) 0: -threading.Thread(target=self.stopMonitoringDomains).start() +@utils.traceback(on=self.log.name) +def run(): +self.log.info(Stop monitoring domains for %s, self.spUUID) +self.stopMonitoringDomains() +thread = threading.Thread(name=StoragePoolCleanupThread, + target=run) +thread.start() @unsecured def forceFreeSpm(self): -- To view, visit http://gerrit.ovirt.org/21932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Improve logging when pool is destroyed
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Improve logging when pool is destroyed .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5955/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5067/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Dan Kenigsberg has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 1: Code-Review-1 Please rebase... -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: sp: Improve logging when pool is destroyed
Nir Soffer has uploaded a new change for review. Change subject: sp: Improve logging when pool is destroyed .. sp: Improve logging when pool is destroyed When pool is destroyed, it tries to stop monitoring domains. I suspect that this is the root cause of bug 1032925. This patch adds proper logging to this thread to prove my theory. The real fix seems to be deleting __del__ as we already stop monitoring domains when pool is disconnected. Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b Bug-Url: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/sp.py 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/21933/1 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 8bab500..e6eca00 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -145,8 +145,13 @@ return self.spmRole, self.getSpmLver(), self.getSpmId() def __del__(self): -if len(self.domainMonitor.monitoredDomains) 0: -threading.Thread(target=self.stopMonitoringDomains).start() +if len(self.domainMonitor.poolMonitoredDomains) 0: +def run(): +self.log.info(Stop monitoring domains for %s, self.spUUID) +self.stopMonitoringDomains() +thread = threading.Thread(name=StoragePoolCleanupThread, + target=run) +thread.start() @unsecured def forceFreeSpm(self): -- To view, visit http://gerrit.ovirt.org/21933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia63a8b5553ad98886240217d4ad0e37c0b197c3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge This hoo...
Dan Kenigsberg has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge This hook support binding specified mac address to custom/other bridge than the currently defined bridge in ovirt. This hook is also capable of binding a mac address to openvswitch bridge. .. Patch Set 3: Code-Review-1 (1 comment) Thanks for this hook. I'd like to have this functionality. But if we are to maintain the hook, I should understand why per-nic is not feasible. http://gerrit.ovirt.org/#/c/17895/1/vdsm_hooks/macbind/README does not answer me. Commit Message Line 3: AuthorDate: 2013-08-11 12:45:33 +0530 Line 4: Commit: Humble Chirammal hchir...@redhat.com Line 5: CommitDate: 2013-12-02 18:21:56 +0530 Line 6: Line 7: hooks: macbind - Attach vm nics to specified bridge Add a newline between subject and content. Please use the new per-device custom properties (then it would work for hot plugged nic too), or explain why you cannot. Line 8: This hook support binding specified Line 9: mac address to custom/other bridge than the currently defined Line 10: bridge in ovirt. This hook is also capable of binding Line 11: a mac address to openvswitch bridge. -- To view, visit http://gerrit.ovirt.org/17895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Improve logging
Ayal Baron has posted comments on this change. Change subject: domainMonitor: Improve logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Improve logging
Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Improve logging .. domainMonitor: Improve logging We have logs in domain monitor thread, and we can see when a monitor starts or stops, but we don't have any info which thread triggered the operation. This patch adds info level log messages when starting and stopping domain monitoring, revealing the caller thread. Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Relates-To: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21904 Reviewed-by: Sergey Gotliv sgot...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Ohad Basan oba...@redhat.com Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Verified Sergey Gotliv: Looks good to me, but someone else must approve Ohad Basan: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 3: Update commit message after discussion with Federico. -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5864/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5068/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5956/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Refix vm unpausing during recovery
Federico Simoncelli has posted comments on this change. Change subject: vm: Refix vm unpausing during recovery .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbfbed22f1787f727884eeed72d2b15835ebe2dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Improve logging
Hello Ayal Baron, Sergey Gotliv, Ohad Basan, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21936 to review the following change. Change subject: domainMonitor: Improve logging .. domainMonitor: Improve logging We have logs in domain monitor thread, and we can see when a monitor starts or stops, but we don't have any info which thread triggered the operation. This patch adds info level log messages when starting and stopping domain monitoring, revealing the caller thread. Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Relates-To: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21904 Reviewed-by: Sergey Gotliv sgot...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Ohad Basan oba...@redhat.com Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/21936/1 diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py index ffa5e00..ac01e8b 100644 --- a/vdsm/storage/domainMonitor.py +++ b/vdsm/storage/domainMonitor.py @@ -90,6 +90,7 @@ if sdUUID in self._domains: return +self.log.info(Start monitoring %s, sdUUID) domainThread = DomainMonitorThread(weakref.proxy(self), sdUUID, hostId, self._interval) domainThread.start() @@ -102,6 +103,7 @@ # Eg: when a domain is detached the domain monitor is stopped and # the host id is released. If the monitor didn't actually exit it # might respawn a new acquire host id. +self.log.info(Stop monitoring %s, sdUUID) try: self._domains[sdUUID].stop() except KeyError: @@ -113,6 +115,7 @@ return self._domains[sdUUID].getStatus() def close(self): +self.log.info(Stopping domain monitors) for sdUUID in self._domains.keys(): self.stopMonitoring(sdUUID) -- To view, visit http://gerrit.ovirt.org/21936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Improve logging
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Improve logging .. Patch Set 1: Verified+1 Verified in CI by Ohad Bassan. -- To view, visit http://gerrit.ovirt.org/21936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 14: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix exception when shutdown() called on vm in 'Down' state
Greg Padgett has uploaded a new change for review. Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state .. vm: Fix exception when shutdown() called on vm in 'Down' state Attempting to call the shutdown() method on a VM which is in 'Down' state resulted in an exception if called through xmlrpclib. Instead, adopt the convention used by similar APIs such as migrate() and return errCode['noVM']. Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698 Bug-Url: https://bugzilla.redhat.com/1027297 Signed-off-by: Greg Padgett gpadg...@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/21937/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index e8d5954..4ff5e27 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2488,7 +2488,7 @@ try: now = time.time() if self.lastStatus == 'Down': -return +return errCode['noVM'] if self.guestAgent and self.guestAgent.isResponsive(): self._guestEventTime = now self._guestEvent = 'Powering down' -- To view, visit http://gerrit.ovirt.org/21937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix exception when shutdown() called on vm in 'Down' state
Greg Padgett has posted comments on this change. Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix exception when shutdown() called on vm in 'Down' state
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5865/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5957/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Improve logging
Sergey Gotliv has posted comments on this change. Change subject: domainMonitor: Improve logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5866/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5070/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/76/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5958/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Itamar Heim has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move get-conf-item/set-conf-item to vdsm-tool
Itamar Heim has abandoned this change. Change subject: move get-conf-item/set-conf-item to vdsm-tool .. Abandoned -- To view, visit http://gerrit.ovirt.org/7695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5c64de097bbaea6a8cf862b43243377e10e00391 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make misc.pgrep for general usage
Itamar Heim has abandoned this change. Change subject: make misc.pgrep for general usage .. Abandoned -- To view, visit http://gerrit.ovirt.org/11033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2034b04a4787d2f222cb98dfe3ffcdbb2a94ebb8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Itamar Heim has abandoned this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Abandoned -- To view, visit http://gerrit.ovirt.org/9655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I86977c1b717d63de21ba4818c6b66e43976d65de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Kaul yk...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
