Change in vdsm[master]: update NIC: having no custom properies is valid
Assaf Muller has posted comments on this change.
Change subject: update NIC: having no custom properies is valid
..
Patch Set 2: Code-Review+1
Looks like this is the only params.get('custom') usage... What a weird miss.
--
To view, visit http://gerrit.ovirt.org/22922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: update NIC: having no custom properies is valid
Dan Kenigsberg has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: update NIC: having no custom properies is valid
Dan Kenigsberg has submitted this change and it was merged. Change subject: update NIC: having no custom properies is valid .. update NIC: having no custom properies is valid Older Engines, that preceded per-vNIC custom properties (Vdsm commit 38b1f8fb) do not send the custom element at all. This has to be interpreted exactly as an empty custom element. Bug-Url: https://bugzilla.redhat.com/1047646 Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22922 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Assaf Muller amul...@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: update NIC: having no custom properies is valid
Hello Vinzenz Feenstra, Assaf Muller, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22950
to review the following change.
Change subject: update NIC: having no custom properies is valid
..
update NIC: having no custom properies is valid
Older Engines, that preceded per-vNIC custom properties (Vdsm commit
38b1f8fb) do not send the custom element at all. This has to be
interpreted exactly as an empty custom element.
Bug-Url: https://bugzilla.redhat.com/1047646
Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/22922
Reviewed-by: Francesco Romani from...@redhat.com
Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-by: Assaf Muller amul...@redhat.com
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/22950/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 8f48bca..6b2de55 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3161,7 +3161,7 @@
if network == '':
network = DUMMY_BRIDGE
linkValue = 'down'
-custom = params.get('custom')
+custom = params.get('custom', {})
netsToMirror = params.get('portMirroring',
netConf.get('portMirroring', []))
--
To view, visit http://gerrit.ovirt.org/22950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: update NIC: having no custom properies is valid
Dan Kenigsberg has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: update NIC: having no custom properies is valid
Assaf Muller has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review-1
(14 comments)
Commit Message
Line 4: Commit: Roy Golan rgo...@redhat.com
Line 5: CommitDate: 2014-01-02 13:51:18 +0200
Line 6:
Line 7: set the # of vcpus for a VM (hot plug/unplug)
Line 8:
We have bug-url. This line is redundant.
This is a new important feature. It deserves a better explanation and reasoning.
Line 9: RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
Line 10:
Line 11: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
File debian/vdsm.dirs
Line 51: usr/libexec/vdsm/hooks/before_vm_migrate_source
Line 52: usr/libexec/vdsm/hooks/before_vm_pause
Line 53: usr/libexec/vdsm/hooks/before_vm_set_ticket
Line 54: usr/libexec/vdsm/hooks/before_vm_start
Line 55: usr/libexec/vdsm/hooks/before_set_num_of_cpus
Keep sorted
Line 56: usr/libexec/vdsm/hooks/after_set_num_of_cpus
Line 57: var/lib/libvirt/qemu/channels
Line 58: var/lib/vdsm
Line 59: var/lib/vdsm/netconfback
File lib/vdsm/define.py
Line 131: 'message': 'Wrong resize disk parameter'}},
Line 132: 'transientErr': {'status': {
Line 133: 'code': 59,
Line 134: 'message': 'Action not permitted on a VM with transient
disks'}},
Line 135: 'setNumberOfCpus': {'status': {
All the error names end with err. Please conform.
Line 136: 'code': 60,
Line 137: 'message': 'Failed to set the number of cpus'}},
Line 138: 'recovery': {'status': {
Line 139: 'code': 99,
File tests/vmTests.py
Line 55: converted = element.toprettyxml()
Line 56: else:
Line 57: elem = ET.fromstring(element.toprettyxml())
Line 58: converted = re.sub(' /', '/',
Line 59:ET.tostring(elem.find(./%s % path)))
Unrelated, it seems.
Line 60: self.assertEqual(
Line 61: re.sub('\n\s*', ' ', converted).strip(' '),
Line 62: re.sub('\n\s*', ' ', expectedXML).strip(' '))
Line 63:
File tests/vmTestsData.py
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: CONF_TO_DOMXML = ({
Why was this changed? I'd like to see further elements added to this list.
Line 22: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 23: 'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512',
Line 24: 'displayPort': '-1', 'vmName': 'testVm',
Line 25: 'display': 'vnc', 'emulatedMachine': 'pc',
File vdsm/API.py
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
How can any of them be None? None cannot be transported over xmlrpc.
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
File vdsm/hooks.py
Line 297:
Line 298:
Line 299: def before_set_num_of_cpus(vmconf={}, params={}):
Line 300: return _runHooksDir(None, 'before_set_num_of_cpus', vmconf=vmconf,
Line 301: params=params, raiseError=False)
Before Hooke *should* raise errors.
Line 302:
Line 303:
Line 304: def after_set_num_of_cpus(vmconf={}, params={}):
Line 305: return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
File vdsm/vm.py
Line 77: RNG_DEVICES = 'rng'
Line 78: WATCHDOG_DEVICES = 'watchdog'
Line 79: CONSOLE_DEVICES = 'console'
Line 80: SMARTCARD_DEVICES = 'smartcard'
Line 81: CPU_DEVICES = 'cpu'
Is this ever used?
Line 82:
Line 83:
Line 84: def isVdsmImage(drive):
Line 85: return all(k in drive.keys() for k in ('volumeID', 'domainID',
'imageID',
Line 897: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 898: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 899: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', '160'))
Please define 160 as a CONSTANT. Is there any side effect of always using the
greatest maximum?
Line 902: # hotplug cpu requires a maximum number which is
Change in vdsm[master]: supervdsmServer: Cleaner way to wait for signals
Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsmServer: Cleaner way to wait for signals .. supervdsmServer: Cleaner way to wait for signals supervdsmServer was using silly way to wait for termination, working around Python bug. This patch use the standard way to wait until termination signal is received, eliminating the workaround. Change-Id: I7f0a1fdd518df1524441fd856fc764f8dbd7cf79 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22719 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/supervdsmServer 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f0a1fdd518df1524441fd856fc764f8dbd7cf79 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: Return recovery error until hsm is ready .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Remove unnecessary device is disk check in prepare...
Sergey Gotliv has posted comments on this change. Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath .. Patch Set 2: Michal, Please, read Ayal's comments in http://gerrit.ovirt.org/#/c/21973/, especially a part about that removal. In the bottom line, do you familiar with the PDIV that is not a disk? I think that the right question is why we have this check there in the first place. making this method symmetric to prepare is not what this patch is about. it is about preventing improper logging that is causing a lot of confusion for users. So symmetry can be handled separately. With regards to *how* it should be handled, it looks like the right thing to do is not to add drive['device'] == 'disk' test here but rather remove it from prepare. In addition, prepare and teardown are not symmetrical in many other ways. prepareVolumePath is preparing floppies, cdrom etc which teardown is not taking care of. the 'teardown' for floppy is _cleanupFloppy etc. -- To view, visit http://gerrit.ovirt.org/22363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Unify checks for vdsm image
Sergey Gotliv has posted comments on this change. Change subject: vm: Unify checks for vdsm image .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa109a19aeec56f09ed2e6d64dee636c7779d426 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/195/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/197/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/198/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
Eyal Edri has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
Eyal Edri has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: Verified+1 Code-Review-1 works on the jenkins job: http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/label=fedora19/198/console -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing python-cpopen requirement
Eyal Edri has posted comments on this change. Change subject: Changing python-cpopen requirement .. Patch Set 1: of course pending pushing that pkg to fedora + el6 repos. -- To view, visit http://gerrit.ovirt.org/22936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I543a51c9ed2a9612a4dde7a46810963f9ae279db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
