Change in vdsm[master]: BindingXmlRPC - do_PUT to return execution result in headers
Liron Ar has posted comments on this change. Change subject: BindingXmlRPC - do_PUT to return execution result in headers .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/27997/1/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 116: HEADER_DOMAIN = 'Storage-Domain-Id' Line 117: HEADER_IMAGE = 'Image-Id' Line 118: HEADER_VOLUME = 'Volume-Id' Line 119: HEADER_TASK_ID = 'Task-Id' Line 120: HEADER_CODE = 'Code' Code and Message are not specific enough, and not consistent with other nam I'll change it, Error prefix isn't good enough because it can also be used for succes..so i'll add the status prefix. Line 121: HEADER_MESSAGE = 'Message' Line 122: HEADER_CONTENT_LENGTH = 'content-length' Line 123: HEADER_CONTENT_TYPE = 'content-type' Line 124: Line 169: response = image.downloadFromStream(methodArgs, Line 170: upload_finished, Line 171: volUUID) Line 172: Line 173: code, message, task = self._parse_response(response) This function does not help anyone. There is nothing to parse - this is jus 1. i prefer to keep this function to get the results easily from the dictionary rather than accessing it multiple times here and save the duplication, imo it's clearer, remove unneeded details from the code and makes it easier to understand. my preference is to have it. 2._sendResponseHeaders - right we send the task-id back only if there's one present, so i don't want to have multiple checks of the code (in and out of that function to know wether we should wait for the event), therefore i prefer to keep the logic here as-is. you can look in the uploadToStream patch to see how it's done there - http://gerrit.ovirt.org/26741. there's no current need for that method imo. Line 174: Line 175: if code != 0: Line 176: self.send_response(httplib.INTERNAL_SERVER_ERROR) Line 177: else: Line 191: except Exception: Line 192: self.send_error(httplib.INTERNAL_SERVER_ERROR, Line 193: error during execution, exc_info=True) Line 194: Line 195: @staticmethod Do not add static methods, there is no reason to call this outside of this I'l remove it. Line 196: def _parse_response(response): Line 197: return response['status']['code'], \ Line 198: response['status']['message'], \ Line 199: response['uuid'] -- To view, visit http://gerrit.ovirt.org/27997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b13f44a65cb2c794c458b03ba361bf0af92120 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
Liron Ar has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/26759/6/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:
Line 74:methodArgs.get(headers, {}))
Line 75:
Line 76:
Line 77: def streamDownloadImage(dstImgPath, methodArgs):
Line 78: totalSize = streamGetSize(methodArgs)
This is nice change, but not related to this patch.
after the logic was exported this is no longer bytes_lef. it's related to this
patch as in this patch the logic was exported out of it in this one, so leaving
the old irrelevant name is incorrect and should be done in this patch.
Line 79: stream = methodArgs['fileObj']
Line 80:
Line 81: cmd = [constants.EXT_DD, of=%s % dstImgPath, bs=%s %
constants.MEGAB]
Line 82: p = utils.execCmd(cmd, sudo=False, sync=False,
Line 99: raise
Line 100:
Line 101:
Line 102: def _copyData(inFile, outFile, totalSize):
Line 103: bytesToRead = totalSize
The name changes are not related to extracting this function.
after we choose the names inFile and outFile it was requested by Federico to
change this name as well. it can be in this patch.
Line 104: while totalSize 0:
Line 105: toRead = min(BUFFER_SIZE, totalSize)
Line 106:
Line 107: try:
Line 107: try:
Line 108: data = inFile.read(toRead)
Line 109: except Exception as e:
Line 110: log.error(error while attempting to read input data)
Line 111: raise se.MiscFileReadException(str(e))
This change is good but not related to extracting this function.
it was added following your comment in patchset#1 to change the exception
handling here (so instead the logs were added), i prefer to keep it if we are
already adding a new method in this change.
Line 112:
Line 113: if not data:
Line 114: error = partial data %s from %s % \
Line 115: (bytesToRead - totalSize, bytesToRead)
Line 113: if not data:
Line 114: error = partial data %s from %s % \
Line 115: (bytesToRead - totalSize, bytesToRead)
Line 116: log.error(error)
Line 117: raise se.MiscFileReadException(error)
This change is good but not related to extracting this function.
it was added following your comment in patchset#1 to change the exception
handling here (so instead the logs were added), i prefer to keep it if we are
already adding a new method in this change.
Line 118:
Line 119: outFile.write(data)
Line 120: # outFile may not be a real file object but a wrapper.
Line 121: # To ensure that we don't use more memory as the input buffer
size
--
To view, visit http://gerrit.ovirt.org/26759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Put hotplug=no for virtual devices
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: Put hotplug=no for virtual devices .. Patch Set 3: Verified+1 We can consider this as verified as the following patch in the series was verified by QE with together with this patch. -- To view, visit http://gerrit.ovirt.org/27980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Replace expensive calls to isMounted with os.path.ism...
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Replace expensive calls to isMounted with os.path.ismount .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9400/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/904/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082ea21ea3760fee1949c62da3b0ccfd82f9ce93 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nfsSD: Remove unneeded and expensive mount check
Michal Skrivanek has posted comments on this change. Change subject: nfsSD: Remove unneeded and expensive mount check .. Patch Set 1: Code-Review+1 are you sure you run exactly the same workload both times? If so then the difference in absolute number of calls (e.g. _parseFstabLine) is an order of magnitude less than before. Still the parsing looks quite excessive so indeed we should look into why is it called so often -- To view, visit http://gerrit.ovirt.org/28089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c617c3e9b9e24b5404a197427551408f659549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add a function to execute a qemu monitor command
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Add a function to execute a qemu monitor command .. Patch Set 1: Code-Review-1 First: I don't see where this _internalQMPMonitorCommand is used. Secondly we rather should not do this at all and rather contribute a patch to libvirt to introduce a new API which gives us what we need instead. I know livemerge is important, but I am strongly opposed to use the monitor channel in regards to the tainted portion -- To view, visit http://gerrit.ovirt.org/27950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e9e07ba0c236c0938b129ae90af825f18f0e644 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add a function to execute a qemu monitor command
Francesco Romani has posted comments on this change. Change subject: virt: Add a function to execute a qemu monitor command .. Patch Set 1: Well, I'd like to not have pieces of code which may tickle dangerous temptations. -- To view, visit http://gerrit.ovirt.org/27950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e9e07ba0c236c0938b129ae90af825f18f0e644 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: support persistent lvs
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: support persistent lvs .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9405/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/905/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Prevent ifup from failing due to existing dhclient
Dan Kenigsberg has submitted this change and it was merged. Change subject: ifcfg: Prevent ifup from failing due to existing dhclient .. ifcfg: Prevent ifup from failing due to existing dhclient When configuring a device with bootproto=dhcp it is possible that the device, if pre-existent, had a running dhclient instance that would make ifup fail. This is especially true in the oVirt deployment flow when we configure the management network over a device that very likely already had a dhclient running. Up until now this has not hit us hard (though it has polluted logs) due to the fact that we ifup dhcp in asyncronous mode and return success before the failure. Bug-Url: https://bugzilla.redhat.com/1100264 Change-Id: Icc4116e1064a00aa891003c9c8fdaea61dabca2c Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28038 Reviewed-by: Martin Pavlik xpavl...@gmail.com Tested-by: Martin Pavlik xpavl...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/configurators/dhclient.py M vdsm/network/configurators/ifcfg.py 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Martin Pavlik: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4116e1064a00aa891003c9c8fdaea61dabca2c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Pavlik xpavl...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Put hotplug=no for virtual devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: ifcfg: Put hotplug=no for virtual devices .. ifcfg: Put hotplug=no for virtual devices In el6 systems, udev can trigger an ifup call when a device is created. The issue with the triggering is that when we create a virtual device, e.g. a vlan, we do so via ifup, so what will happen is: we write ethX.Y initscripts creates the vlan device with id Y on top of ethX. udev detects the new device | Process 1 | Process 2 initscripts finished doing udev calls initscripts' ifup ifup, possibly calling dhclientfor the new vlan device initscripts possibly calls dhclient The issue is that the two processes can do the dhclient in whichever order and one dhclient will prevent the other from succeeding. Only one ifup should be called for each device, so we need hotplug=no to prevent Process 2 from succeeding in its ifup. Our current usage of ifcfg files does not set hotplug=no so that when the user replaces a physical card by hot-unplugging and hot-plugging there will be an auto configuration. This behavior is maintained by the fact that we only set hotplug=no for those devices for which we control the whole life cycle, i.e., vlans, bonds and bridges. Bug-Url: https://bugzilla.redhat.com/1097818 Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27980 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/configurators/ifcfg.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Put hotplug=no for virtual devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: Put hotplug=no for virtual devices .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1346/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: support persistent lvs
Sandro Bonazzola has posted comments on this change. Change subject: lvm: support persistent lvs .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Prevent ifup from failing due to existing dhclient
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: Prevent ifup from failing due to existing dhclient .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1347/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc4116e1064a00aa891003c9c8fdaea61dabca2c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Pavlik xpavl...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Improve loop devices resolving
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Improve loop devices resolving .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9399/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8468/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/906/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40c0bd772327248e6fe08189dada043ea1c6c080 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9398/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8467/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/907/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nfsSD: Remove unneeded and expensive mount check
oVirt Jenkins CI Server has posted comments on this change. Change subject: nfsSD: Remove unneeded and expensive mount check .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9397/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8466/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/908/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c617c3e9b9e24b5404a197427551408f659549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9253/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9396/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8465/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/909/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 20:
(3 comments)
sorry, did not save my draft messages
http://gerrit.ovirt.org/#/c/27258/20/vdsm/API.py
File vdsm/API.py:
Line 709: def setCpuTuneQuota(self, quota):
Line 710: v = self._cif.vmContainer.get(self._UUID)
Line 711: if not v:
Line 712: return errCode['noVM']
Line 713: return v.setCpuTuneQuota(quota)
Kobi, take a look in vdsm_api/vdsmapi-schema.json
Done
Line 714:
Line 715: def setCpuTunePeriod(self, period):
Line 716: v = self._cif.vmContainer.get(self._UUID)
Line 717: if not v:
http://gerrit.ovirt.org/#/c/27258/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4404: else:
Line 4405: ret['vcpu_user_limit'] = 100
Line 4406:
Line 4407: except (AttributeError, libvirt.libvirtError):
Line 4408: # Metadata is not set, nothing to do, set the defaults
I believe Dan refers to the fact that you report 100 instead of none.
Okay, setting the 100 is the same as no value at all, and will save us the None
check in the calling side.
Line 4409: self.log.debug('Domain Metadata is not set')
Line 4410: ret['vcpu_user_limit'] = 100
Line 4411: return ret
Line 4412:
Line 4503: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4504: return self.reportError(key='noVM', entity='vcpu
period')
Line 4505: return self.reportError(msg=e.message, entity='vcpu
period')
Line 4506:
Line 4507: def reportError(self, key='Err', msg=None, entity=None):
Use _reportError
Done
Line 4508: self.log.error(Set new +entity+ failed, exc_info=True)
Line 4509: if msg is None:
Line 4510: error = errCode[key]
Line 4511: else:
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: stop non-vdsm dhclient before we run our own
Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2: stop non-vdsm dhclient before we run our own .. Patch Set 5: Verified+1 Verified by doing: dhclient eth1 vdsClient -s 0 addNetwork bridge=foo nics=eth1 bootproto=dhcp After that I checked the logs and saw that there is no dhclient errors in supervdsm.log and instead there is the 'dhclient -x eth1' -- To view, visit http://gerrit.ovirt.org/28039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9bbca6e2039f5c5ef4ee6172a2c0d9d35ebdbb0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop wasteful time.sleep() in releaseVm
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: drop wasteful time.sleep() in releaseVm .. vm: drop wasteful time.sleep() in releaseVm After inspection of the libvirt code, turns out the time.sleep(30) we currently have in the releaseVm flow is redundant and wasteful. Libvirt (1.2.x) already has hardcoded timeout to handle the QEMU process termination, and this patch leverages that. Before this patch, the sequence of events triggered by the dom.destroy() call in the worst case scenario (QEMU not responding) is: - send SIGTERM (clean shutdown request) - wait 10s (libvirt, hardcoded) - (fails) - log error (libvirt, vdsm) - wait 30s (vdsm) - send SIGTERM (clean shutdown request) - wait 10s (libvirt) - (fails) - log error (libvirt) - send SIGKILL (forced shutdown request) - wait 5s( libvirt, hardcoded) total time: 10+30+10+5 = 55s (all hardcoded!) With this patch, the flow becomes: - send SIGTERM (clean shutdown request) - wait 10s (libvirt, hardcoded) - (fails) - log error (libvirt, vdsm) - send SIGTERM (clean shutdown request) - wait 10s (libvirt) - (fails) - log error (libvirt) - send SIGKILL (forced shutdown request) - wait 5s( libvirt, hardcoded) total time: 10+10+5 = 25s (no values hardcoded in VDSM) Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Bug-Url: https://bugzilla.redhat.com/1091389 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27175 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop wasteful time.sleep() in releaseVm
Dan Kenigsberg has posted comments on this change. Change subject: vm: drop wasteful time.sleep() in releaseVm .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop wasteful time.sleep() in releaseVm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop wasteful time.sleep() in releaseVm .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1348/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25794217e63dd4c755d9c141a2e941e4baa6fd3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2: stop non-vdsm dhclient before we run our own
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2: stop non-vdsm dhclient before we run our own .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1411/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9406/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8475/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9bbca6e2039f5c5ef4ee6172a2c0d9d35ebdbb0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: fix version to family parameter name
Antoni Segura Puimedon has uploaded a new change for review. Change subject: ipwrapper: fix version to family parameter name .. ipwrapper: fix version to family parameter name In commit e435e680fdae8f1baaf8dac549c72db32c07549f there is a change to add ipv6 support to various ipwrapper functions. During the review process it was suggested to change the parameter from 'version' to 'family' but I missed one of the parameters. Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M lib/vdsm/ipwrapper.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/28095/1 diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py index c8d6b36..632c6eb 100644 --- a/lib/vdsm/ipwrapper.py +++ b/lib/vdsm/ipwrapper.py @@ -509,8 +509,8 @@ return _execCmd(command) -def routeAdd(route, version=4, dev=None): -command = [_IP_BINARY.cmd, '-%s' % version, 'route', 'add'] +def routeAdd(route, family=4, dev=None): +command = [_IP_BINARY.cmd, '-%s' % family, 'route', 'add'] command += route if dev is not None: command += ['dev', dev] -- To view, visit http://gerrit.ovirt.org/28095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 20:
(4 comments)
http://gerrit.ovirt.org/#/c/27258/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4389:
Line 4390: def _getUserCpuTuneInfo(self):
Line 4391: ret = {}
Line 4392: try:
Line 4393: domain = self._connection.lookupByUUIDString(self.id)
the _dom object is a reference to libvirt. If it's ever becomes stale, it's
Done
Line 4394:
Line 4395: if domain:
Line 4396: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Line 4397: metadataCpuLimit = domain.metadata(2, vcpuLimitUri,
0)
Line 4392: try:
Line 4393: domain = self._connection.lookupByUUIDString(self.id)
Line 4394:
Line 4395: if domain:
Line 4396: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
what is this URI? I see nothing there. Is it documented anywhere?
will add documentation
Line 4397: metadataCpuLimit = domain.metadata(2, vcpuLimitUri,
0)
Line 4398:
Line 4399: if metadataCpuLimit:
Line 4400: pattern = ^vcpulimit(.*)/vcpulimit
Line 4396: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Line 4397: metadataCpuLimit = domain.metadata(2, vcpuLimitUri,
0)
Line 4398:
Line 4399: if metadataCpuLimit:
Line 4400: pattern = ^vcpulimit(.*)/vcpulimit
The string looks like an xml element. If it is a real xml, it should confor
Since the input is hard coded and known I feel we can skip all xml validations
Line 4401: metadataCpuLimit = re.search(pattern,
Line 4402: metadataCpuLimit,
re.M)
Line 4403: ret['vcpu_user_limit'] =
metadataCpuLimit.group(1)
Line 4404: else:
Line 4475: def setCpuTuneQuota(self, quota):
Line 4476:
Line 4477: if self._dom is None:
Line 4478: return self.reportError(entity='vcpu quota')
Line 4479: try:
I see no fix
you are right, forgot to extract the int, now it is fixed
Line 4480: quota = int(quota)
Line 4481: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4482: return {'status': doneCode}
Line 4483: except ValueError:
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect kdump status
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Collect kdump status .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9407/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8476/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68d7a2a24fdaad74255004af0f327197eaee65f2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9249/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9392/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8461/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/911/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9394/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8463/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/912/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9393/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8462/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/913/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica6cb0fee5802c664548011c38e358529b155333 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Francesco Romani has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 37: Doing this way we will be out of luck with fedora 20 and with fedora 19 with virt-preview, as they both provide libvirt 1.1.3 which will provide ABORT_ON_EIO_ERROR but not the filetransfer disable option. However, I can amend the _getVersionInfo helper to deal with this case. -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: fix version to family parameter name
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: fix version to family parameter name .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9265/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8477/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 22: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9266/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9409/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8478/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/910/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: introducing uploadImageToStream
Liron Ar has abandoned this change. Change subject: core: introducing uploadImageToStream .. Abandoned -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Francesco Romani has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 37: changes: * no functional behaviour, reworked the dependencies handling. Dropped strict spec-file dependency except for RHEL, handle cluster compatibility at run time. -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9267/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9410/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/914/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: fix device hooks post migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: graphdev: fix device hooks post migration .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9269/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8481/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6643f81cc5cff1a282da607e7e5759a97b081c7a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: update the _devices field
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: graphdev: update the _devices field .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9270/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9413/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8482/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a2133742a5515dc1077cd935ad7d1e37410e44 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/26300/20/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 144: _, client_socket = self.pending_connections[fd] Line 145: data = client_socket.recv(4096, socket.MSG_PEEK) Line 146: except socket.error as e: Line 147: if e.errno not in (errno.EAGAIN, errno.EINPROGRESS): Line 148: self.log.warn(Not able to read data) Please take a look at logging module. You can see that: But this is not documented - probably this was done for backward compatibility. To avoid confusion, we should use only the documented form. Since this module is new, there is only one correct form for this module. Line 149: client_socket.close() Line 150: return Line 151: Line 152: handler = self.detect_protocol(data) -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: reorganize the graphic devices lookup
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorganize the graphic devices lookup .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9271/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9414/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8483/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231087647e515a1f310de45b659e512444bd0a1d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Stomp support .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9268/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9411/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/641/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: graphdev: rename a parameter for clarity
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: graphdev: rename a parameter for clarity .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8484/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3716b48a5fbe5beebb819754d0f500b097f04677 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 22: Code-Review-1
(5 comments)
http://gerrit.ovirt.org/#/c/27258/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4375:
Line 4376: def _getUserCpuTuneInfo(self):
Line 4377: ret = {}
Line 4378: try:
Line 4379: domain = self._dom
There's no benefit in defining this variable, which is used only once.
Line 4380:
Line 4381: if domain:
Line 4382: # A unique URL to define the cpu limit parameter at
the metadata section of libvirt
Line 4383: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Line 4379: domain = self._dom
Line 4380:
Line 4381: if domain:
Line 4382: # A unique URL to define the cpu limit parameter at
the metadata section of libvirt
Line 4383: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Is this URL yours to use? In my opinion, it is not descriptive enough, and it
certainly leads to nowhere when browsing to it. What is this bit of metadata?
Which components use it? What is its format and meaning? Which component owns
it?
Line 4384: metadataCpuLimit = domain.metadata(2, vcpuLimitUri,
0)
Line 4385:
Line 4386: if metadataCpuLimit:
Line 4387: pattern = ^vcpulimit(.*)/vcpulimit
Line 4393:
Line 4394: except (AttributeError, libvirt.libvirtError):
Line 4395: # Metadata is not set, nothing to do, set the defaults
Line 4396: self.log.debug('Domain Metadata is not set')
Line 4397: ret['vcpu_user_limit'] = 100
I am not convinced that reporting a value that is not truly there is a good
thing to do.
Line 4398: return ret
Line 4399:
Line 4400: def _getCpuTuneInfo(self):
Line 4401: ret = {}
Line 4416: ret['vcpu_period'] = 1000
Line 4417:
Line 4418: except (AttributeError, libvirt.libvirtError):
Line 4419: # Metadata is not set, nothing to do, set the defaults
Line 4420: self.log.debug('Domain Metadata is not set')
please add exc_info=True so we can tell which error took place.
Please reduce the size of the try-except block, or eliminate it altogether.
Line 4421: ret['vcpu_quota'] = -1
Line 4422: ret['vcpu_period'] = 1000
Line 4423: return ret
Line 4424:
Line 4468: try:
Line 4469: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4470: return {'status': doneCode}
Line 4471: except libvirt.libvirtError as e:
Line 4472: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
why do we need this special handling of VIR_ERR_NO_DOMAIN? Do we expect the VM
to be destroyed while this verb is being run?
Line 4473: return self._reportError(key='noVM', entity='vcpu
quota')
Line 4474: return self._reportError(msg=e.message, entity='vcpu
quota')
Line 4475:
Line 4476: def setCpuTunePeriod(self, period):
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 38: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/642/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 38: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9417/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8486/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27820/3/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 86: self.context = False Line 87: self.sectionStart = sectionStart Line 88: self.sectionEnd = sectionEnd Line 89: self.prefix = prefix Line 90: self.version = version here, or in http://gerrit.ovirt.org/#/c/27821/4 Done: http://gerrit.ovirt.org/#/c/27821/ Line 91: Line 92: def __enter__(self): Line 93: if self.context: Line 94: raise RuntimeError(can only enter once) -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
Dan Kenigsberg has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 38: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9418/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8487/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve the logging when destroying domains
Dan Kenigsberg has posted comments on this change. Change subject: vm: improve the logging when destroying domains .. Patch Set 1: (1 comment) Maybe I should review the following patches in order to understand this one... http://gerrit.ovirt.org/#/c/28023/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4316: self._dom.destroyFlags( Line 4317: libvirt.VIR_DOMAIN_DESTROY_GRACEFUL) Line 4318: except libvirt.libvirtError as e: Line 4319: self.log.warning(Failed to destroy VM '%s' Line 4320: gracefully, self.conf['vmId']) even as a stepping stone - this patch should add logging of the specific error that took place (exc_info=True is the simplest way to do that). Line 4321: if (e.get_error_code() == Line 4322:libvirt.VIR_ERR_OPERATION_FAILED): Line 4323: self._dom.destroy() Line 4324: except libvirt.libvirtError as e: -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
Vinzenz Feenstra has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 38: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Antoni Segura Puimedon has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 6: Verified+1 Verified by running all the functional tests (including the new one from this patch: tonif2001 tests (5a4de6f) # ./run_tests_local.sh -x functional/networkTests.py nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$'] NetworkTest testAddDelBondedNetwork(kwargs=False) OK testAddDelBondedNetwork(kwargs=True)OK testAddDelNetwork(kwargs=False) OK testAddDelNetwork(kwargs=True) OK testAddNetworkBondWithManyVlans(kwargs=False) OK testAddNetworkBondWithManyVlans(kwargs=True)OK testAddNetworkManyVlans(kwargs=False) OK testAddNetworkManyVlans(kwargs=True)OK testAddNetworkVlan(kwargs=False)OK testAddNetworkVlan(kwargs=True) OK testAddNetworkVlanBond(kwargs=False)OK testAddNetworkVlanBond(kwargs=True) OK testAddVlanedBridgeless OK testAddVlanedBridgeless_oneCommand OK testAfterNetworkSetupHook OK testBeforeNetworkSetupHook OK testBondHwAddress(kwargs=False) OK testBondHwAddress(kwargs=True) OK testBrokenBridgelessNetReplacement OK testDelNetworkBondAccumulation OK testDelNetworkWithMTU(kwargs=False) OK testDelNetworkWithMTU(kwargs=True) OK testDelWithoutAdd(kwargs=False) OK testDelWithoutAdd(kwargs=True) OK testDhclientLeases(kwargs='default')SKIP : No firewall service detected. testDhclientLeases(kwargs='local') SKIP : No firewall service detected. testEditWithoutAdd(kwargs=False)OK testEditWithoutAdd(kwargs=True) OK testFailWithInvalidBondingName(kwargs=False)OK testFailWithInvalidBondingName(kwargs=True) OK testFailWithInvalidBridgeName OK testFailWithInvalidIpConfig OK testFailWithInvalidNic(kwargs=False)OK testFailWithInvalidNic(kwargs=True) OK testFailWithInvalidParams(kwargs=False) OK testFailWithInvalidParams(kwargs=True) OK testGetRouteDeviceToOK testHonorBlockingDhcp OK testIPv6ConfigNetwork OK testIpLinkWrapper OK testLowerMtuDoesNotOverride OK testNoBridgeLeftovers OK testQosNetwork OK testRouteExists OK testRuleExists OK testSafeNetworkConfig(kwargs=False) OK testSafeNetworkConfig(kwargs=True) OK testSetupNetworksAddBadParams(bridged=False)OK testSetupNetworksAddBadParams(bridged=True) OK testSetupNetworksAddBondWithManyVlans(kwargs=False) OK testSetupNetworksAddBondWithManyVlans(kwargs=True) OK testSetupNetworksAddDelBondedNetwork(kwargs=False) OK testSetupNetworksAddDelBondedNetwork(kwargs=True) OK testSetupNetworksAddDelDhcp(kwargs=False) SKIP : No firewall service detected. testSetupNetworksAddDelDhcp(kwargs=True)SKIP : No firewall service detected. testSetupNetworksAddManyVlans(kwargs=False) OK testSetupNetworksAddManyVlans(kwargs=True) OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Yoav Kleinberger has uploaded a new change for review.
Change subject: tests: use 'localhost' explicitly in test
..
tests: use 'localhost' explicitly in test
Previously tests could on some machines (in case the machine has a
non-default hostname). Now, since we use 'localhost' explicitly, this
will not happen.
Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Signed-off-by: Yoav Kleinberger yklei...@redhat.com
---
M tests/functional/storageTests.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/28107/1
diff --git a/tests/functional/storageTests.py b/tests/functional/storageTests.py
index 80ba312..76ca91d 100644
--- a/tests/functional/storageTests.py
+++ b/tests/functional/storageTests.py
@@ -79,7 +79,8 @@
isSSL = config.getboolean('vars', 'ssl')
if isSSL and os.geteuid() != 0:
raise SkipTest(Must be root to use SSL connection to server)
-self.s = vdscli.connect(useSSL=isSSL)
+address = 'localhost:%s' % config.get('addresses', 'management_port')
+self.s = vdscli.connect(hostPort=address, useSSL=isSSL)
def assertVdsOK(self, vdsResult):
# code == 0 means OK
--
To view, visit http://gerrit.ovirt.org/28107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Yoav Kleinberger has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 6: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1413/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8488/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
Dan Kenigsberg has submitted this change and it was merged. Change subject: spice: allow to disable the to clipboard copypaste .. spice: allow to disable the to clipboard copypaste since version 0.9.3, libvirt allows to optionally disable copy and paste in the spice protocolol: http://libvirt.org/formatdomain.html#elementsGraphics this patch expose this capability in VDSM, in the VM definition. The new parameter is optional and enabled by default for backward compatibility. No XML changes are produced at all unless the new parameter is specified. Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Bug-Url: https://bugzilla.redhat.com/1052959 Bug-Url: https://bugzilla.redhat.com/800155 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26916 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com --- M tests/vmTests.py M vdsm/virt/vm.py M vdsm_api/vdsmapi-schema.json 3 files changed, 50 insertions(+), 7 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 39: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1349/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Nir Soffer has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Vinzenz Feenstra has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 38: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve the logging when destroying domains
Francesco Romani has posted comments on this change. Change subject: vm: improve the logging when destroying domains .. Patch Set 1: (1 comment) This patch should be good enough on isolation, so will fix. http://gerrit.ovirt.org/#/c/28023/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4316: self._dom.destroyFlags( Line 4317: libvirt.VIR_DOMAIN_DESTROY_GRACEFUL) Line 4318: except libvirt.libvirtError as e: Line 4319: self.log.warning(Failed to destroy VM '%s' Line 4320: gracefully, self.conf['vmId']) even as a stepping stone - this patch should add logging of the specific er Right, will fix. Line 4321: if (e.get_error_code() == Line 4322:libvirt.VIR_ERR_OPERATION_FAILED): Line 4323: self._dom.destroy() Line 4324: except libvirt.libvirtError as e: -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9420/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8489/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 22:
(5 comments)
http://gerrit.ovirt.org/#/c/27258/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4375:
Line 4376: def _getUserCpuTuneInfo(self):
Line 4377: ret = {}
Line 4378: try:
Line 4379: domain = self._dom
There's no benefit in defining this variable, which is used only once.
Done
Line 4380:
Line 4381: if domain:
Line 4382: # A unique URL to define the cpu limit parameter at
the metadata section of libvirt
Line 4383: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Line 4379: domain = self._dom
Line 4380:
Line 4381: if domain:
Line 4382: # A unique URL to define the cpu limit parameter at
the metadata section of libvirt
Line 4383: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
Is this URL yours to use? In my opinion, it is not descriptive enough, and
the URL is used as a namespace, the purpose of this URL is only to serve as a
unique key to the place in the Metadata where the data is stored.
Since this is the first time we use the Metadata section of libvirt I took the
liberty of constructing a pattern that make sense to me
(project/param/nameOfParam)
I will add reference to the documentation
Line 4384: metadataCpuLimit = domain.metadata(2, vcpuLimitUri,
0)
Line 4385:
Line 4386: if metadataCpuLimit:
Line 4387: pattern = ^vcpulimit(.*)/vcpulimit
Line 4393:
Line 4394: except (AttributeError, libvirt.libvirtError):
Line 4395: # Metadata is not set, nothing to do, set the defaults
Line 4396: self.log.debug('Domain Metadata is not set')
Line 4397: ret['vcpu_user_limit'] = 100
I am not convinced that reporting a value that is not truly there is a good
I get what you are saying, not sure this is worth the trouble (handling it on
the calling side)
Line 4398: return ret
Line 4399:
Line 4400: def _getCpuTuneInfo(self):
Line 4401: ret = {}
Line 4416: ret['vcpu_period'] = 1000
Line 4417:
Line 4418: except (AttributeError, libvirt.libvirtError):
Line 4419: # Metadata is not set, nothing to do, set the defaults
Line 4420: self.log.debug('Domain Metadata is not set')
please add exc_info=True so we can tell which error took place.
Done
Line 4421: ret['vcpu_quota'] = -1
Line 4422: ret['vcpu_period'] = 1000
Line 4423: return ret
Line 4424:
Line 4468: try:
Line 4469: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4470: return {'status': doneCode}
Line 4471: except libvirt.libvirtError as e:
Line 4472: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
why do we need this special handling of VIR_ERR_NO_DOMAIN? Do we expect the
Done
Line 4473: return self._reportError(key='noVM', entity='vcpu
quota')
Line 4474: return self._reportError(msg=e.message, entity='vcpu
quota')
Line 4475:
Line 4476: def setCpuTunePeriod(self, period):
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8490/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/915/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 23: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9279/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9422/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8491/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/916/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: introducing uploadImageToStream
Liron Ar has restored this change. Change subject: core: introducing uploadImageToStream .. Restored -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9423/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8492/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8493/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
Yaniv Bronhaim has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
Yaniv Bronhaim has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
mooli tayer has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/27823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb6094d8a1feeb45630d29e36ecad2ddfac1fca Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9426/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8495/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3783bf50d55c54ec38c3240f66b4a14296f244a8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9425/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8494/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: use qemuimg and remove custom qemuConvert
Dan Kenigsberg has submitted this change and it was merged. Change subject: volume: use qemuimg and remove custom qemuConvert .. volume: use qemuimg and remove custom qemuConvert This patch removes the custom qemuConvert implementation. It is safe to drop the ddWatchCopy part because: - it was initially introduced to workaround a bug in qemu-img that was preventing it from working with raw volumes on block devices [1] - it was later on used to try and maintain the preallocation of a volume on file domains, but it was covering only one specific case (raw to raw) and in the most common case of copyCollapsed (cow chain to raw) was using qemu-img (not maintaining the preallocation) - given bz#1097843 we are trying to phase out preallocation on file domains because it is hard (or sometimes impossible) to guarantee, This patch has just shown that there are at least two cases where we were (and are) not able to guarantee preallocation (mergeSnapshot and copyCollapsed). [1] the problem is that qemu-img is designed to maintain sparseness when possible. This means that if it fails to detect that the destination is a block device then it will seek instead of writing zeroes, leving some of the previous data in place. This has been fixed since some time and Kevin Wolf mentioned that the code is now really explicit about this case being handled (force to write zeroes if the destination is raw on a block device). Moreover vdsm has been already relying on qemu-img to convert cow to raw and it seems that we never hit any issue. Related-To: http://bugzilla.redhat.com/1097843 Change-Id: Ic27770241495e21737f926b1820494377467383b Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26921 Reviewed-by: Kevin Wolf kwolf%redhat@gtempaccount.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/image.py M vdsm/storage/volume.py 2 files changed, 17 insertions(+), 47 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Kevin Wolf: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic27770241495e21737f926b1820494377467383b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: use qemuimg and remove custom qemuConvert
Dan Kenigsberg has posted comments on this change. Change subject: volume: use qemuimg and remove custom qemuConvert .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27770241495e21737f926b1820494377467383b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 4: Code-Review+2 Escalating score -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. vdsm-tool: add unprefixLines() to configfile.py. New method removes 'prefix' from each line starting with it. No editing is done on new content added by this config file. This method will be used to remove '# VDSM backup' comments put inside libvirt logrotate file. Changed doc string of prefixLines to reflect the link between the two methods. Tests included (see testPrefixIdempotencey in toolTests.py). unprefixLines is the reverse function of prefixLines so that unprefixLines(prefixLines(file)) = file. Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27737 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configfile.py M tests/toolTests.py 2 files changed, 53 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8496/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9428/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8497/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve documentation
Dan Kenigsberg has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 5: Code-Review+2 Escalating score -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve documentation
Dan Kenigsberg has submitted this change and it was merged. Change subject: ConfigFile.py: improve documentation .. ConfigFile.py: improve documentation Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27819 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configfile.py 1 file changed, 32 insertions(+), 14 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 7: Code-Review+2 Escalating score -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: prefix private methods and properties with _ .. vdsm-tool: prefix private methods and properties with _ Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27821 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configfile.py M tests/toolTests.py 2 files changed, 74 insertions(+), 74 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
Dan Kenigsberg has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 5: Code-Review+2 Escalating score -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
Dan Kenigsberg has submitted this change and it was merged. Change subject: ConfigFile.py: include default section wrapping comments. .. ConfigFile.py: include default section wrapping comments. Since ConfigFile.py represents common operations on config files it should also include the default comments vdsm inserts. Only version has no default to allow different callares have different configuration version. Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27820 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configfile.py M tests/toolTests.py 2 files changed, 39 insertions(+), 29 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
Dan Kenigsberg has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 8: Code-Review+2 Escalating score -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
Dan Kenigsberg has submitted this change and it was merged. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. ConfigFile.py: provide backward compatibility with '# by vdsm' comments. see 'Backward compatibility:' at ConfigFile doc for detailed description. Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27822 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configfile.py M tests/toolTests.py 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
Martin Sivák has uploaded a new change for review.
Change subject: Fix memShared units when reported from MOM
..
Fix memShared units when reported from MOM
MOM reports the ksm_pages_sharing value in raw pages.
Both VDSM and engine expect megabytes, so this patch adds
the necessary conversion.
Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072030
Signed-off-by: Martin Sivak msi...@redhat.com
---
M vdsm/momIF.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/28115/1
diff --git a/vdsm/momIF.py b/vdsm/momIF.py
index c1e00ef..6641521 100644
--- a/vdsm/momIF.py
+++ b/vdsm/momIF.py
@@ -21,6 +21,8 @@
import logging
import threading
from vdsm.config import config
+from API import PAGE_SIZE_BYTES
+from define import Mbytes
try:
import mom
@@ -51,11 +53,16 @@
self.start()
def getKsmStats(self):
+
+Get information about KSM and convert memory data from page
+based values to MiB.
+
stats = self._mom.getStatistics()['host']
ret = {}
ret['ksmState'] = bool(stats['ksm_run'])
ret['ksmPages'] = stats['ksm_pages_to_scan']
-ret['memShared'] = stats['ksm_pages_sharing']
+ret['memShared'] = stats['ksm_pages_sharing'] * PAGE_SIZE_BYTES
+ret['memShared'] /= Mbytes
ret['ksmCpu'] = stats['ksmd_cpu_usage']
return ret
--
To view, visit http://gerrit.ovirt.org/28115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák msi...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: use qemuimg and remove custom qemuConvert
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: use qemuimg and remove custom qemuConvert .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1350/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27770241495e21737f926b1820494377467383b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Dan Kenigsberg has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28107/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-26 14:33:09 +0300 Line 6: Line 7: tests: use 'localhost' explicitly in test Line 8: Line 9: Previously tests could on some machines (in case the machine has a English issue here? I fail to parse the sentence. Line 10: non-default hostname). Now, since we use 'localhost' explicitly, this Line 11: will not happen. Line 12: Line 13: Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Dan Kenigsberg has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 79: isSSL = config.getboolean('vars', 'ssl')
Line 80: if isSSL and os.geteuid() != 0:
Line 81: raise SkipTest(Must be root to use SSL connection to
server)
Line 82: address = 'localhost:%s' % config.get('addresses',
'management_port')
Line 83: self.s = vdscli.connect(hostPort=address, useSSL=isSSL)
vdscli.connect() has a heuristic that should do the right thing. could you
explain better what's the bug there?
Line 84:
Line 85: def assertVdsOK(self, vdsResult):
Line 86: # code == 0 means OK
Line 87: self.assertEquals(
--
To view, visit http://gerrit.ovirt.org/28107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1351/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/643/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/917/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve documentation
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1352/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9430/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8499/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb6094d8a1feeb45630d29e36ecad2ddfac1fca Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1353/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9288/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9431/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8500/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods and properties with _
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods and properties with _ .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1354/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve documentation
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9289/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9432/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8501/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
