Change in vdsm[master]: http protocol detection
Nir Soffer has posted comments on this change.
Change subject: http protocol detection
..
Patch Set 2:
(1 comment)
This will be very nice when implemented.
http://gerrit.ovirt.org/#/c/27839/2/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 220: def stop(self):
Line 221: if self.xmlBinding:
Line 222: self.xmlBinding.stop()
Line 223:
Line 224:
To complete this:
- Move detector to BindingXMLRPC, which is currently the server used also for
http
- Fix the logger name after the move- Create this detector with the
xmlbindings, just like the XMLDetector.
- Implment handleSocket
In a future patch we should create another server for the http.
This is critical since without this this patch will break storage http flows
like uploading/downloading images.
Line 225: class _HttpDetector():
Line 226: log = logging.getLogger("protocolDetector.XmlDetector")
Line 227: name = "http"
Line 228:
--
To view, visit http://gerrit.ovirt.org/27839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f899cbab4d95ebd184bf32f3ccec1f4fa0e49bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 204: Line 205: server = utils.SimpleThreadedXMLRPCServer( Line 206: requestHandler=RequestHandler, Line 207: logRequests=True) Line 208: utils.closeOnExec(server.socket.fileno()) > I am not really sure what you mean here. We are using Python XMLRPCServer, which is baed on a base tcp server, creating a socket in its __init__. See /usr/lib64/python2.7/SocketServer.py line 413. We do not need this socket because we separated nicely the accept part from the request handling part. So our server should override __init__ to make sure we do not create a listening socket. Looking at the horrible Python code we are using , I think this should be deferred to another patch, and the correct solution is not inheriting from XMLRPCServer, but instead write 20 lines server that take request from a queue and process them in a new thread. The way it is implemented here is fragile and impossible to understand with so many level of inheritance through so many modules (this, utils, SimpleXMLRCPServer, BaseHTTPServer, SocketServer). Line 209: Line 210: return server Line 211: Line 212: def _registerFunctions(self): -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: wrong message formatting leads to an exception
Francesco Romani has posted comments on this change. Change subject: vm: wrong message formatting leads to an exception .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib789adb51cd4ca112489d55b6e10f69698a4a3ac Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class
Francesco Romani has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1e8605786c41920f5c5f171e42fb9a12474dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/24/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 148: else:
Line 149: cls._instance = clientIF(irs, log)
Line 150: return cls._instance
Line 151:
Line 152: def _prepareProtocolDetecton(self):
> To be honest this is the way it was designed. I am not arguing whether it w
ok
Line 153: host = config.get('addresses', 'management_ip')
Line 154: port = config.getint('addresses', 'management_port')
Line 155: sslctx = None
Line 156: if config.getboolean('vars', 'ssl'):
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(2 comments)
Critical error handling issue in the detector thread.
http://gerrit.ovirt.org/#/c/26300/24/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 54: def _set_non_blocking(self, fd):
Line 55: flags = fcntl.fcntl(fd, fcntl.F_GETFL, 0)
Line 56: flags = flags | os.O_NONBLOCK
Line 57: fcntl.fcntl(fd, fcntl.F_SETFL, flags)
Line 58:
Please use vdsm.utils.traceback on all threads run functions. This ensures that
if your thread dies because of unhandled exception, you will get a nice
traceback in the log, just like the one you get when you run python code in the
shell.
For example:
from vdsm.utils import traceback
@traceback(on=log.name)
def serve_forever(self):
...
This should be on *all* threads. If a thread has a try block covering all the
code, you can replace it with the decorator.
Line 59: def serve_forever(self):
Line 60: self._required_size = max(h.required_size for h in
self._handlers)
Line 61: self._is_running = True
Line 62: self._poller.register(self._socket, self.READ_ONLY_MASK)
Line 62: self._poller.register(self._socket, self.READ_ONLY_MASK)
Line 63: self._poller.register(self._read_fd, self.READ_ONLY_MASK)
Line 64: self._next_cleanup = time.time() + self.CLEANUP_INTERVAL
Line 65: try:
Line 66: while self._is_running:
Critical: any error thrown in lower level functions or in this code will cause
this thread to exit. This is nice for debugging (assuming you are using
@traceback), but unacceptable for production. If this thread exit, engine will
have to soft-fence vdsm.
To fix this, I suggest to extract the logic of the while block into its own
method, (e.g. _process_events), and handle *any* exception around it:
try:
while self._is_running:
try:
self._process_events()
except Exception:
logging.exception("Unhandled exception")
finally:
self._cleanup()
This has another advantage, in the current code, all temporary variables scope
is the entire life time of this thread. For example, fd and event are kept even
after they are processed, until the next event is received. This pattern leads
to surprising bugs later. See http://gerrit.ovirt.org/22136
Line 67: timeout = max(self._next_cleanup - time.time(), 0)
Line 68: events = self._poller.poll(timeout)
Line 69:
Line 70: for fd, event in events:
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmcli: Add a contrib command line client alternative
Francesco Romani has posted comments on this change. Change subject: vdsmcli: Add a contrib command line client alternative .. Patch Set 1: Code-Review+1 very cool! I don't know how much this is far-fetched, but I'd like to automaticcally build options, commands etc. from the schema (I volunteer for that!) -- To view, visit http://gerrit.ovirt.org/28152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5574b2b34f0b7b2174e9da0c4487f812ff20f5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8567/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/650/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9501/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9355/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib628b10c3b9743bb9fef5cbf41195e69ff851efd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Darshan N has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/26343/8/vdsm/gluster/gfapi.py File vdsm/gluster/gfapi.py: Line 24: Line 25: @makePublic Line 26: def volumeStatsInfoGet(volumeName, volumeServer="localhost"): Line 27: vol = gfapi.Volume(volumeServer, volumeName) Line 28: vol_init = vol.mount() > rc would be better than vol_init Done Line 29: Line 30: if vol_init != 0: Line 31: errMsg = "Failed to mount volume" Line 32: raise ge.GlusterVolumeStatsInfoGetFailedException(err=[errMsg]) Line 26: def volumeStatsInfoGet(volumeName, volumeServer="localhost"): Line 27: vol = gfapi.Volume(volumeServer, volumeName) Line 28: vol_init = vol.mount() Line 29: Line 30: if vol_init != 0: > Does non-zero return value has meaning? Done Line 31: errMsg = "Failed to mount volume" Line 32: raise ge.GlusterVolumeStatsInfoGetFailedException(err=[errMsg]) Line 33: Line 34: # f_blocks = Total number of blocks -- To view, visit http://gerrit.ovirt.org/26343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib628b10c3b9743bb9fef5cbf41195e69ff851efd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm_config: move download certificate
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 1: yes -- To view, visit http://gerrit.ovirt.org/28164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm_config: move download certificate
Alon Bar-Lev has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 1: Code-Review+1 clean cherry-pick, right? -- To view, visit http://gerrit.ovirt.org/28164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(1 comment)
Waiting for the next version
http://gerrit.ovirt.org/#/c/26300/24/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 219: if not self._enabled:
Line 220: self.log.debug('cannot run prepareForShutdown twice')
Line 221: return errCode['unavail']
Line 222:
Line 223: self.acceptor.stop()
> It is exactly as suggested. We need to stop it somewhere and this is the pl
My comment was very wrong. I was interrupted while writing it and forgot to fix
it later. Sorry for the noise.
Line 224: self.xmlDetector.stop()
Line 225: self.stompDetector.stop()
Line 226:
Line 227: self._enabled = False
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: wrong message formatting leads to an exception
Daniel Erez has posted comments on this change. Change subject: vm: wrong message formatting leads to an exception .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib789adb51cd4ca112489d55b6e10f69698a4a3ac Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class
Daniel Erez has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1e8605786c41920f5c5f171e42fb9a12474dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Verified+1 Verified by using vdsClient getHardwareInformation verb and engine webadmin, locally changed dmidecodeUtil to omit several keys and everything worked as expected, keys were not reported vdsClient and webadmin showed no information. -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vdsm_config: move download certificate
Hello Alon Bar-Lev, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28164
to review the following change.
Change subject: vdsm_config: move download certificate
..
vdsm_config: move download certificate
DHCP servers might delay to deliver the ip address
and we can't download the engine certificate from
vdsm-config stage. This patch is moving the download
certificate from vdsm-config to vdsm-reg-setup.
Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065368
Signed-off-by: Alon Bar-Lev
Signed-off-by: Douglas Schilling Landgraf
Reviewed-on: http://gerrit.ovirt.org/26718
Reviewed-by: Dan Kenigsberg
---
M vdsm_reg/deployUtil.py.in
M vdsm_reg/vdsm-config
M vdsm_reg/vdsm-reg-setup.in
M vdsm_reg/vdsm-reg.conf.in
4 files changed, 133 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/28164/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in
index 3e16557..2a6522a 100644
--- a/vdsm_reg/deployUtil.py.in
+++ b/vdsm_reg/deployUtil.py.in
@@ -1683,18 +1683,30 @@
return [chain[depth] for depth in sorted(chain.keys())]
-def getRhevmCert(IP, port):
+def getRhevmCert(IP, port, output=None):
"""Aquire CA certificate from SSL handshake
This certificate is saved to a file and later used
to validate HTTPS connections with the engine web
server.
+Args:
+IP -- IP address to collect the SSL chain
+port -- Port to connect
+output -- Path to save the ssl chain
+
+Returns:
+True or False
"""
try:
chain = getChainFromSSL((IP, int(port)))
ca = chain[-1]
-_, _, engineWebCACert = certPaths('')
+
+if output is None:
+_, _, engineWebCACert = certPaths('')
+else:
+engineWebCACert = output
+
dirName = os.path.dirname(engineWebCACert)
if not os.path.exists(dirName):
os.makedirs(dirName)
diff --git a/vdsm_reg/vdsm-config b/vdsm_reg/vdsm-config
index 5e4d16c..711227c 100755
--- a/vdsm_reg/vdsm-config
+++ b/vdsm_reg/vdsm-config
@@ -90,22 +90,24 @@
sed --copy -i
"s/\(^vdc_host_name=\)\(..*$\)/\1${vdc_managment_server}/" \
/etc/vdsm-reg/vdsm-reg.conf
- res=`python "$DEPLOY_UTIL" --node-cleanup`
- ret_val=$?
- echo "$res" >> $LOG 2>&1
- if [ ! $ret_val -eq 0 ];then
- echo "Node cleanup failed" >> $LOG 2>&1
- fi
-
if [ "$vdc_managment_server" != "$vdc_managment_port"
]; then
sed --copy -i
"s/\(^vdc_host_port=\)\(..*$\)/\1${vdc_managment_port}/" \
/etc/vdsm-reg/vdsm-reg.conf
fi
- res=`python "$DEPLOY_UTIL" --download-rhevm-cert
--server-address="$vdc_managment_server" --server-port="$vdc_managment_port"
--fingerprint="$management_server_fingerprint"`
+ if [ ! -z "$management_server_fingerprint" ]; then
+ echo "checkpoint
4::management_server_fingerprint: ${management_server_fingerprint}" >> $LOG 2>&1
+ sed --copy -i "/^fingerprint=/d" \
+ /etc/vdsm-reg/vdsm-reg.conf
+ echo
"fingerprint=${management_server_fingerprint}" \
+ >> /etc/vdsm-reg/vdsm-reg.conf
+ fi
+
+ res=`python "$DEPLOY_UTIL" --node-cleanup`
ret_val=$?
echo "$res" >> $LOG 2>&1
if [ ! $ret_val -eq 0 ];then
+ echo "Node cleanup failed" >> $LOG 2>&1
mv "$tmp_vdsm_reg_conf"
/etc/vdsm-reg/vdsm-reg.conf
echo "Rebooting ... " >> $LOG 2>&1
/sbin/reboot
diff --git a/vdsm_reg/vdsm-reg-setup.in b/vdsm_reg/vdsm-reg-setup.in
index b7d1a9b..0b70a3e 100644
--- a/vdsm_reg/vdsm-reg-setup.in
+++ b/vdsm_reg/vdsm-reg-setup.in
@@ -19,11 +19,16 @@
import logging
import logging.config
import urllib
+import shutil
import ssl
+import tempfile
from config import config
import deployUtil
import createDaemon
from deployUtil import MGT_BRIDGE_NAME
+
+from ConfigParser import NoOptionError
+from ovirtnode import ovirtfunctions
TICKET_RETRIES=3
DEFAULT_CONFIG_FILE="/etc/vdsm-reg/vdsm-reg.conf"
@@ -40,6 +45,14 @@
self.fInitOK = True
self.vdcURL = "None"
self.vdcName = config.get('vars', 'vdc_host_name')
+
+try:
+self.cfg_fprint = config.get('vars', 'fingerprint')
+except NoOptionError:
+
Change in vdsm[ovirt-3.4]: vdsm_config: move download certificate
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class
Dan Kenigsberg has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 2: Code-Review+2 We must add a unit test (or a functional test) so that something like this does not happen again. -- To view, visit http://gerrit.ovirt.org/28131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1e8605786c41920f5c5f171e42fb9a12474dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sriov hook: allow VFs with nonzero pci domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: sriov hook: allow VFs with nonzero pci domain .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8566/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9500/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9354/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b75134a7f6bdb10f8d808b4dcda6856befe705 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sriov hook: allow VFs with nonzero pci domain
Dan Kenigsberg has uploaded a new change for review.
Change subject: sriov hook: allow VFs with nonzero pci domain
..
sriov hook: allow VFs with nonzero pci domain
This patch is the smallest change needed to expose a host nic with non-zero pci
domain to a guest.
The hook does a questionable detour via libvirt in order to extract the pci
address of the specified nic. This begs for simplification in a follow up patch.
Change-Id: Ie2b75134a7f6bdb10f8d808b4dcda6856befe705
Signed-off-by: Dan Kenigsberg
---
M vdsm_hooks/sriov/before_vm_start.py
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/28162/1
diff --git a/vdsm_hooks/sriov/before_vm_start.py
b/vdsm_hooks/sriov/before_vm_start.py
index c23797b..e3b1de1 100755
--- a/vdsm_hooks/sriov/before_vm_start.py
+++ b/vdsm_hooks/sriov/before_vm_start.py
@@ -26,7 +26,7 @@
def getDeviceDetails(addr):
''' investigate device by its address and return
-[bus, slot, function] list
+[domain, bus, slot, function] list
'''
connection = libvirtconnection.get(None)
@@ -34,6 +34,8 @@
devXml = minidom.parseString(nodeDevice.XMLDesc(0))
+domain = hex(int(
+devXml.getElementsByTagName('domain')[0].firstChild.nodeValue))
bus = hex(int(devXml.getElementsByTagName('bus')[0].firstChild.nodeValue))
slot = hex(int(
devXml.getElementsByTagName('slot')[0]
@@ -45,10 +47,10 @@
sys.stderr.write('sriov: bus=%s slot=%s function=%s\n' %
(bus, slot, function))
-return (bus, slot, function)
+return (domain, bus, slot, function)
-def createSriovElement(domxml, bus, slot, function):
+def createSriovElement(domxml, domain, bus, slot, function):
'''
create host device element for libvirt domain xml:
@@ -69,7 +71,7 @@
address = domxml.createElement('address')
address.setAttribute('type', 'pci')
-address.setAttribute('domain', '0')
+address.setAttribute('domain', domain)
address.setAttribute('bus', bus)
address.setAttribute('slot', slot)
address.setAttribute('function', function)
@@ -139,9 +141,10 @@
devpath = os.path.realpath(SYS_NIC_PATH % nic + '/device')
addr = getPciAddress(devpath)
-bus, slot, function = getDeviceDetails(addr)
+domain, bus, slot, function = getDeviceDetails(addr)
-interface = createSriovElement(domxml, bus, slot, function)
+interface = createSriovElement(
+domxml, domain, bus, slot, function)
sys.stderr.write('sriov: VF %s xml: %s\n' %
(nic, interface.toxml()))
--
To view, visit http://gerrit.ovirt.org/28162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2b75134a7f6bdb10f8d808b4dcda6856befe705
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: added missing diskReplicate slot in Drive class
Nir Soffer has posted comments on this change. Change subject: vm: added missing diskReplicate slot in Drive class .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd1e8605786c41920f5c5f171e42fb9a12474dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Nir Soffer has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 5: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28124/5/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 529: runCommand(_exportfs.cmd, '-u', '127.0.0.1:%s' % path)
Line 530:
Line 531:
Line 532: def listNFS():
Line 533: return runCommand([_exportfs.cmd])
This will fail because you send a list.
Line 534:
Line 535:
Line 536: def cleanNFSLeftovers(pathPrefix):
Line 537: pathPattern = pathPrefix + "*"
Line 542: try:
Line 543: unexportNFS(export)
Line 544: except TestRunnerError as e:
Line 545: logging.warning("Failed to unexport NFS entry %s: %s",
Line 546: export, e, exc_info=True)
logging.exception is better here.
Line 547: else:
Line 548: shutil.rmtree(export, ignore_errors=True)
Line 549:
Line 550:
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: introducing uploadImageToStream
Federico Simoncelli has posted comments on this change. Change subject: core: introducing uploadImageToStream .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/26741/10/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 119: HEADER_VOLUME = 'Volume-Id' Line 120: HEADER_TASK_ID = 'Task-Id' Line 121: HEADER_CODE = 'Status-Code' Line 122: HEADER_MESSAGE = 'Status-Message' Line 123: HEADER_SIZE = 'Size' This should be "Range" to be coherent with HTTP. Line 124: HEADER_CONTENT_LENGTH = 'content-length' Line 125: HEADER_CONTENT_TYPE = 'content-type' Line 126: Line 127: class RequestException(): -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: BindingXMLRPC - exporting logic out from do_PUT.
Federico Simoncelli has posted comments on this change. Change subject: core: BindingXMLRPC - exporting logic out from do_PUT. .. Patch Set 10: Code-Review+1 (1 comment) More or less ok. Needs a deeper review for a +2. http://gerrit.ovirt.org/#/c/26740/10/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 199: def _waitForEvent(event): Line 200: while not event.is_set(): Line 201: event.wait() Line 202: Line 203: def _getIntHeader(self, headerName, missingError): > I don't like passing the error code for the exception here. Waiting for Fed Ugly but we can live with it. We're on rush. Line 204: value = self.headers.getheader( Line 205: headerName) Line 206: if not value: Line 207: raise self.RequestException( -- To view, visit http://gerrit.ovirt.org/26740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bb1b0a4cb85ce822929f1907847dd63eb69fc2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: generify "streamDownloadImage" related methods
Federico Simoncelli has posted comments on this change. Change subject: core: generify "streamDownloadImage" related methods .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c73374681b5a5fc9fd0cb81020138fb5c8bfe69 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
Federico Simoncelli has posted comments on this change. Change subject: core: imageSharing - export logic to functions .. Patch Set 9: Code-Review+1 Seems fine. I want to do another deeper review soon. -- To view, visit http://gerrit.ovirt.org/26759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BindingXmlRPC - do_PUT to return execution result in headers
Federico Simoncelli has posted comments on this change. Change subject: BindingXmlRPC - do_PUT to return execution result in headers .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27997/3/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 177: self.send_header(self.HEADER_TASK_ID, response['uuid']) Line 178: else: Line 179: self.send_response(httplib.INTERNAL_SERVER_ERROR) Line 180: Line 181: self._send_response_headers(response) What I remember we agreed upon was to try and adhere to HTTP standards. On error: - send_response INTERNAL_SERVER_ERROR (ok) - send the error information in the body On success: - send the task id in the headers Line 182: self.end_headers() Line 183: Line 184: except socket.timeout: Line 185: self.send_error(httplib.REQUEST_TIMEOUT, -- To view, visit http://gerrit.ovirt.org/27997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b13f44a65cb2c794c458b03ba361bf0af92120 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/tests/jsonRpcHelper.py File tests/jsonRpcHelper.py: Line 1: import httplib No copyright?! Line 2: import logging Line 3: import os Line 4: import socket Line 5: import threading -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/vdsm/rpc/__init__.py File vdsm/rpc/__init__.py: Line 15: # along with this program; if not, write to the Free Software Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # This copyright is pointless :-) -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/vdsm/sslUtils.py File vdsm/sslUtils.py: Line 45: # M2C do not provide message peek so Line 46: # we buffer first consumed message Line 47: def read(self, size=4096, flag=None): Line 48: result = None Line 49: if flag == 2: 2 should be socket.MSG_PEEK - right? Line 50: self._data = self.connection.read(size) Line 51: result = self._data Line 52: else: Line 53: if self._data: -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 11: # Line 12: # You should have received a copy of the GNU General Public Line 13: # License along with this program; if not, write to the Free Software Line 14: # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Line 15: General naming issue for later - the naming can be simplfied by naming this module "stomp", and the classes to Reactor, Detector etc. User code will do: import stomp sr = stomp.Reactor() Much nicer than the Java like repetition: import stompReactor sr = stompReactor.StompReactor() Or the namspace polution: from stompReactor import StompRactor Line 16: import asyncore Line 17: import os Line 18: import threading Line 19: import logging -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/26300/24/vdsm/rpc/BindingJsonRpc.py File vdsm/rpc/BindingJsonRpc.py: Line 45: def start(self): Line 46: t = threading.Thread(target=self.server.serve_requests, Line 47: name='JsonRpcServer') Line 48: t.setDaemon(True) Line 49: t.start() Look how clean this is when threading code is encapsulated - the acceptor should use same code. Line 50: Line 51: def startReactor(self, reactor): Line 52: reactorName = reactor.__class__.__name__ Line 53: t = threading.Thread(target=reactor.process_requests, -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(2 comments)
http://gerrit.ovirt.org/#/c/26300/24/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 897: (self.setupNetworks, 'setupNetworks'),
Line 898: (self.ping, 'ping'),
Line 899: (self.setSafeNetworkConfig, 'setSafeNetworkConfig'),
Line 900: (self.fenceNode, 'fenceNode'),
Line 901: (self.stop, 'prepareForShutdown'),
Nice! I hated that name - but why the string is not updated?
Line 902: (self.setLogLevel, 'setLogLevel'),
Line 903: (self.setMOMPolicy, 'setMOMPolicy'),
Line 904: (self.setMOMPolicyParameters,
'setMOMPolicyParameters'),
Line 905: (self.setHaMaintenanceMode, 'setHaMaintenanceMode'),
Line 1060: try:
Line 1061: method, rest = data.split(" ", 1)
Line 1062: except ValueError:
Line 1063: return False
Line 1064: return method == "POST" and rest.startswith("/RPC2")
Need to check with engine that all rpc calls do use "/RPC2", and not "/" -
critical.
Line 1065:
Line 1066: def handleSocket(self, client_socket, socket_address):
Line 1067: self.xml_binding.add_socket(client_socket, socket_address)
Line 1068: self.log.debug("xml over http detected from %s",
socket_address)
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(18 comments)
First look in clientIF
- ImportError handling is not acceptable - must fix.
- Adding variables without initializing them in __init__ - must fix
- Extract few small methods from the huge _prepareProtocolDetector
- Start everything in one place - nice to have
- Use _private for stuff which is private - nice to have
http://gerrit.ovirt.org/#/c/26300/24/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 204:
Line 205: server = utils.SimpleThreadedXMLRPCServer(
Line 206: requestHandler=RequestHandler,
Line 207: logRequests=True)
Line 208: utils.closeOnExec(server.socket.fileno())
The server should not have a socket after this change - it this works it means
that you did not modify the original server correctly, so it will not create a
socket.
Line 209:
Line 210: return server
Line 211:
Line 212: def _registerFunctions(self):
http://gerrit.ovirt.org/#/c/26300/24/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 109: self.irs.prepareForShutdown()
Line 110: if self.mom:
Line 111: self.mom.stop()
Line 112: raise
Line 113: self._prepareProtocolDetecton()
Did you mean prepareProtocolDetector?
Line 114:
Line 115: @property
Line 116: def ready(self):
Line 117: return (self.irs is None or self.irs.ready) and not
self._recovery
Line 148: else:
Line 149: cls._instance = clientIF(irs, log)
Line 150: return cls._instance
Line 151:
Line 152: def _prepareProtocolDetecton(self):
This does not belong to this class - all this setup should be at the
application level, and this class should get whatever object it need to perform
its duty.
Since this is a huge change without this, I guess we should defer this change.
Line 153: host = config.get('addresses', 'management_ip')
Line 154: port = config.getint('addresses', 'management_port')
Line 155: sslctx = None
Line 156: if config.getboolean('vars', 'ssl'):
Line 152: def _prepareProtocolDetecton(self):
Line 153: host = config.get('addresses', 'management_ip')
Line 154: port = config.getint('addresses', 'management_port')
Line 155: sslctx = None
Line 156: if config.getboolean('vars', 'ssl'):
Please extract this block to its own method (e.g. _createSSLContext)
Line 157: truststore_path = config.get('vars', 'trust_store_path')
Line 158: key_file = truststore_path + '/keys/vdsmkey.pem'
Line 159: cert_file = truststore_path + '/certs/vdsmcert.pem'
Line 160: ca_cert = truststore_path + '/certs/cacert.pem'
Line 160: ca_cert = truststore_path + '/certs/cacert.pem'
Line 161: sslctx = SSLContext(cert_file, key_file, ca_cert)
Line 162: default_bridge = config.get("vars", "default_bridge")
Line 163:
Line 164: self.acceptor = MultiProtocolAcceptor(host, port, sslctx)
Please rename to self._acceptor and initialize in __init__ to None
Line 165: if config.getboolean('vars', 'xmlrpc_enable'):
Line 166: try:
Line 167: from BindingXMLRPC import BindingXMLRPC
Line 168: from BindingXMLRPC import XmlDetector
Line 161: sslctx = SSLContext(cert_file, key_file, ca_cert)
Line 162: default_bridge = config.get("vars", "default_bridge")
Line 163:
Line 164: self.acceptor = MultiProtocolAcceptor(host, port, sslctx)
Line 165: if config.getboolean('vars', 'xmlrpc_enable'):
Please extract this block to its own method (e.g. _prepareXMLRPCBinding)
Line 166: try:
Line 167: from BindingXMLRPC import BindingXMLRPC
Line 168: from BindingXMLRPC import XmlDetector
Line 169:
Line 168: from BindingXMLRPC import XmlDetector
Line 169:
Line 170: xml_binding = BindingXMLRPC(self, self.log, host,
Line 171: default_bridge)
Line 172: xml_binding.start()
Why not start this in start()?
Line 173: self.xmlDetector = XmlDetector(xml_binding)
Line 174: self.acceptor.add_detector(self.xmlDetector)
Line 175: except ImportError:
Line 176: self.log.error('Unable to load the xmlrpc server
module. '
Line 169:
Line 170: xml_binding = BindingXMLRPC(self, self.log, host,
Line 171: default_bridge)
Line 172: xml_binding.start()
Line 173: self.xmlDetector = XmlDetector(xml_binding)
Please rename to self._xmlDetector and initialize in __init__ to None
Line 174: self.acceptor.add_detector(self.xmlDetector)
Line 17
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: (2 comments) http://gerrit.ovirt.org/#/c/26300/24/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 59: def serve_forever(self): Line 60: self._required_size = max(h.required_size for h in self._handlers) Line 61: self._is_running = True Line 62: self._poller.register(self._socket, self.READ_ONLY_MASK) Line 63: self._poller.register(self._read_fd, self.READ_ONLY_MASK) > I do not see value of moving this code to __init__. Am I missing something? The value is having initialization code in one place, and simplifying this method which is the most complex in this class. Line 64: self._next_cleanup = time.time() + self.CLEANUP_INTERVAL Line 65: try: Line 66: while self._is_running: Line 67: timeout = max(self._next_cleanup - time.time(), 0) Line 91: client_socket.close() Line 92: Line 93: self._poller.unregister(self._socket) Line 94: self._poller.unregister(self._read_fd) Line 95: self._socket.close() > I think that we started to walk in circles. We moved this code to finally b Having this code in stop was not correct, because it may be called by another thread. Before this code was complete (removing pending connections), this seemed short enough to fit here, but now this block of code looks little too big, and deserve a method. Line 96: Line 97: def _cleanup_pending_connections(self): Line 98: for _, (accepted, client_socket) in self._pending_connections.items(): Line 99: if time.time() - accepted > self.CLEANUP_INTERVAL: -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Replace expensive calls to isMounted with os.path.ism...
Nir Soffer has posted comments on this change. Change subject: mount: Replace expensive calls to isMounted with os.path.ismount .. Patch Set 1: We check if the domain if mounted before we try to access it. The only way os.path.ismount will block, is when the nfs server does not respond, or the mount is stale. In these cases, in the old code, we would block on some dd process or some other code trying to access the storage, while after this patch, we will block on the mount check. So this should not change the semantics and should not be a regression. But I agree that this is not the best way to go. -- To view, visit http://gerrit.ovirt.org/28091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082ea21ea3760fee1949c62da3b0ccfd82f9ce93 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: support persistent lvs
Nir Soffer has posted comments on this change. Change subject: lvm: support persistent lvs .. Patch Set 6: Code-Review-1 Jiri, please split the activation and refresh code to separate patch. If this patch will only skip lvs with the persistent tag, I think we have good chance to merge it fast. Activating/refreshing the lvs in hosted engine agent should be easy using sudo, this is the way vdsm activate lvs while running as vdsm. -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jiří Moskovčák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
(12 comments)
Very nice code, some issues left, and logging should be improved, to make it
easier to debug.
http://gerrit.ovirt.org/#/c/26300/24/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 29: from vdsm.sslUtils import SSLServerSocket
Line 30:
Line 31:
Line 32: class MultiProtocolAcceptor:
Line 33: log = logging.getLogger("protocolDetector.MultiProtocolAcceptor")
This logger name is little too long, and this make it harder to use the logs.
The module name is not needed since all the messages already contain the module
name.
Should we use "vds.MultiProtocolAcceptor" or "vds.Acceptor"?
Line 34:
Line 35: READ_ONLY_MASK = (select.POLLIN | select.POLLPRI | select.POLLHUP
Line 36: | select.POLLERR)
Line 37: CLEANUP_INTERVAL = 30.0
Line 48: self._poller = select.poll()
Line 49: self._socket = self._create_socket(host, port)
Line 50: self._pending_connections = {}
Line 51: self._handlers = []
Line 52: self._next_cleanup = 0
Please initialize here also all variables.
Python does not care when you add instance variables, but this pattern is bad
practice and make the code harder to maintain and understand.
Looks like _required_size and _running are missing. _rquired_size should be
initialized to None so failure to initialize later will raise when calling recv.
Line 53:
Line 54: def _set_non_blocking(self, fd):
Line 55: flags = fcntl.fcntl(fd, fcntl.F_GETFL, 0)
Line 56: flags = flags | os.O_NONBLOCK
Line 49: self._socket = self._create_socket(host, port)
Line 50: self._pending_connections = {}
Line 51: self._handlers = []
Line 52: self._next_cleanup = 0
Line 53:
Lets move public methods at the top (__init__, serve_forever, stop,
add_detector) and private method at the bottom.
Line 54: def _set_non_blocking(self, fd):
Line 55: flags = fcntl.fcntl(fd, fcntl.F_GETFL, 0)
Line 56: flags = flags | os.O_NONBLOCK
Line 57: fcntl.fcntl(fd, fcntl.F_SETFL, flags)
Line 56: flags = flags | os.O_NONBLOCK
Line 57: fcntl.fcntl(fd, fcntl.F_SETFL, flags)
Line 58:
Line 59: def serve_forever(self):
Line 60: self._required_size = max(h.required_size for h in
self._handlers)
Lets log this important event:
logging.debug("Acceptor running")
We may have log on the thread starting this in a thread, but this log will tell
us when the acceptor thread is ready.
I would also log required_size, for easier debugging:
self.log.debug("Using required_size=%d", self.required_size)
Line 61: self._is_running = True
Line 62: self._poller.register(self._socket, self.READ_ONLY_MASK)
Line 63: self._poller.register(self._read_fd, self.READ_ONLY_MASK)
Line 64: self._next_cleanup = time.time() + self.CLEANUP_INTERVAL
Line 59: def serve_forever(self):
Line 60: self._required_size = max(h.required_size for h in
self._handlers)
Line 61: self._is_running = True
Line 62: self._poller.register(self._socket, self.READ_ONLY_MASK)
Line 63: self._poller.register(self._read_fd, self.READ_ONLY_MASK)
Can we register these descriptor in __init__?
Line 64: self._next_cleanup = time.time() + self.CLEANUP_INTERVAL
Line 65: try:
Line 66: while self._is_running:
Line 67: timeout = max(self._next_cleanup - time.time(), 0)
Line 81: now = time.time()
Line 82: if now > self._next_cleanup:
Line 83: self._next_cleanup = now + self.CLEANUP_INTERVAL
Line 84: self._cleanup_pending_connections()
Line 85: finally:
Lets log this important event:
logging.debug("Acceptor stopped")
We must log stop both from stop() and here, because stop method may be called
from another thread. We like to know which thread stopped the acceptor, and we
like to know when it actually woke up and stopped.
Line 86: for handler in self._handlers:
Line 87: handler.stop()
Line 88:
Line 89: for _, (_, client_socket) in
self._pending_connections.items():
Line 91: client_socket.close()
Line 92:
Line 93: self._poller.unregister(self._socket)
Line 94: self._poller.unregister(self._read_fd)
Line 95: self._socket.close()
Lets move all the finally block into _cleanup or _shutdown method
Line 96:
Line 97: def _cleanup_pending_connections(self):
Line 98: for _, (accepted, client_socket) in
self._pending_connections.items():
Line 99: if time.time() - accepted > self.CLEANUP_INTERVAL:
Line 105: if handler.detect(data):
Line 106: return handler
Line 107: raise _Ca
Change in vdsm[master]: lvm: support persistent lvs
Federico Simoncelli has posted comments on this change. Change subject: lvm: support persistent lvs .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27880/6//COMMIT_MSG Commit Message: Line 7: lvm: support persistent lvs Line 8: Line 9: Using the special tag allows others to add their own LVs into Line 10: vdsm controlled storage without having to change the vdsm. Line 11: The special tagged LVs are activated when startMonitoringDomain > Not activating them means that hosted agent will have to start vdsm, connec > why? and how do you suggest to do it since vdsm deactivates it? I don't like > the idea of vdsm deactivating it and someone else activating it... I suggest that your patch should only make sure that vdsm is not deactivating the tagged LVs. I don't think it's vdsm storage duty to manage LVs that we don't own. Line 12: is called (that's what hosted engine does) so everyone who Line 13: wants to add it's own LVs should call it to make sure the Line 14: LVs are activated. Line 15: -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jiří Moskovčák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nfsSD: Remove unneeded and expensive mount check
Federico Simoncelli has posted comments on this change. Change subject: nfsSD: Remove unneeded and expensive mount check .. Patch Set 1: Code-Review+2 Fine, the isMounted check seems redundant since we already check for the specific ESTALE errno. -- To view, visit http://gerrit.ovirt.org/28089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c617c3e9b9e24b5404a197427551408f659549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Replace expensive calls to isMounted with os.path.ism...
Federico Simoncelli has posted comments on this change. Change subject: mount: Replace expensive calls to isMounted with os.path.ismount .. Patch Set 1: Code-Review-1 At first look this is a no-go since ismount gets stuck (ok we're using oop but having to wait 2 minutes is a regression). -- To view, visit http://gerrit.ovirt.org/28091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082ea21ea3760fee1949c62da3b0ccfd82f9ce93 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmcli: Add a contrib command line client alternative
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmcli: Add a contrib command line client alternative .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9353/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5574b2b34f0b7b2174e9da0c4487f812ff20f5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Nir Soffer has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 542: try:
Line 543: unexportNFS(export)
Line 544: except TestRunnerError as e:
Line 545: logging.warning("Failed to unexport NFS entry %s: %s",
Line 546: export, e)
> Not too important here, but generally, exc_info=True gives valuable informa
If we like the exception here, I think we should use the standard
logging.exception().
Line 547: else:
Line 548: shutil.rmtree(export, ignore_errors=True)
Line 549:
Line 550:
http://gerrit.ovirt.org/#/c/28124/4/tests/testrunner.py
File tests/testrunner.py:
Line 392: raise AssertionError(msg)
Line 393:
Line 394:
Line 395: def runCommand(*args):
Line 396: process = subprocess.Popen(args, stderr=subprocess.PIPE,
> it's a bad practice. what is the use of continuing it?
I also think that it is time to improve the code instead of keeping the old way.
However, if Dan insist, we can replace the Popen call here with:
process = execCmd(args, sync=False, raw=True)
This will keep only one place referring to execCmd and we can replace it later
with Popen if needed.
Line 397:stdout=subprocess.PIPE)
Line 398: output, error = process.communicate()
Line 399: if process.returncode != 0:
Line 400: raise TestRunnerError("subprocess failed: returncode=%s:
stderr=%r" %
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8564/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9498/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9352/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
Federico Simoncelli has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 13: Ping Saggi? Can you point us to any issue/bug we were addressing with AsyncProc? -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmcli: Add a contrib command line client alternative
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsmcli: Add a contrib command line client alternative
..
vdsmcli: Add a contrib command line client alternative
This command line client is built by hand for the convenience of
developers and requires the click library:
pip install click
It easily supports commands and subcommands. For example:
vdsmcli network
is a command and 'show' and 'add' are its subcommands.
Examples:
toniel602 ~ # vdsmcli network show -k nics -k networks
= Nics
eth6
eth5
eth4
eth3
eth2
eth1
= Networks
foo
or
toniel602 ~ # vdsmcli --verbode --pprint network show -k networks
= Networks
===
foo
===
{'addr': '',
'bootproto4': 'none',
'bridged': False,
'gateway': '',
'iface': 'bond42',
'interface': 'bond42',
'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:8796/64',
'fe80::201:a4ff:feac:8796/64'],
'ipv6gateway': 'fe80:52:0:223c::3fe',
'mtu': '1500',
'netmask': ''}
addition
toniel602 ~ # ./cvdsm.py -v -p network add foo --bridgeless --nic eth4
--nic eth5 --bond bond42
Networks: {u'foo': {'bonding': u'bond42', 'bridged': False}}
Bonds: {u'bond42': {'nics': (u'eth4', u'eth5')}}
Succeeded. Done
One could extend it with a vm command so that it was easy to do:
vdsmcli vm hotplug 34f5f608-91ed-48d1-af31-c3a3d788678e nic --mac
00:11:22:33:44:55 --model virtio
Change-Id: Ie5574b2b34f0b7b2174e9da0c4487f812ff20f5b
Signed-off-by: Antoni S. Puimedon
---
A contrib/vdsmcli.py
1 file changed, 113 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/28152/1
diff --git a/contrib/vdsmcli.py b/contrib/vdsmcli.py
new file mode 100644
index 000..2255201
--- /dev/null
+++ b/contrib/vdsmcli.py
@@ -0,0 +1,113 @@
+#!/usr/bin/env python2
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+"""This is a command line client for vdsm."""
+
+from pprint import pformat
+
+import click
+
+from vdsm import netinfo, vdscli
+
+_NET_DEVICE_TYPES = ('networks', 'bridges', 'vlans', 'bondings', 'nics')
+
+
+class Options(object):
+def __init__(self, verbose=None, pprint=None):
+self.verbose = verbose
+self.pprint = pprint
+
+
+@click.group()
+@click.option('-v', '--verbose', is_flag=True)
+@click.option('-p', '--pprint', is_flag=True)
+@click.pass_context
+def cli(ctx, verbose, pprint):
+ctx.obj = Options(verbose, pprint)
+
+
+@cli.group()
+@click.pass_obj
+def network(options):
+"""Network actions and information displaying."""
+pass
+
+
+@network.command(help='Configure network')
+@click.pass_obj
+@click.option('--bridged/--bridgeless', default=True)
+@click.option('--vlan', default=None, type=click.INT)
+@click.option('--bond', default=None)
+@click.option('--bond-opts', default=None)
+@click.option('--nic', multiple=True)
+@click.argument('name')
+@click.argument('extra_attributes', required=False, nargs=-1)
+def add(options, bridged, vlan, bond, bond_opts, nic, name, extra_attributes):
+conn = vdscli.connect()
+networks = {name: {'bridged': bridged}}
+if vlan:
+networks[name]['vlan'] = vlan
+if len(nic) == 1:
+networks[name]['nic'] = nic[0]
+if bond:
+networks[name]['bonding'] = bond
+bonds = {bond: {'nics': nic}}
+if bond_opts:
+bonds[bond]['options'] = bond_opts
+else:
+bonds = {}
+
+for key, value in (elem.split('=') for elem in extra_attributes):
+networks[name][key] = value
+
+if options.verbose:
+click.echo('Networks: %s' % (pformat(networks) if options.pprint else
+ networs))
+click.echo('Bonds: %s' % (pformat(bonds) if options.pprint else bonds))
+result = conn.setupNetworks(networks, bonds, {'connectivityCheck': False})
+code = result['status']['code']
+message = result['status']['message']
+click.echo('%s. %s' %
Change in vdsm[master]: vdsm-tool: Change upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9351/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Change upgrade mechanism
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: Upon further examination, this was missing logs, because logger was ignoring DEBUG level logs, fixed in http://gerrit.ovirt.org/#/c/27481, Here is a comparison of old logs (lhs) and new logs (rhs): http://www.diffchecker.com/f65qrxae Also changed the order of checks in upgrades to match the original code, upgrade function is only reached if there is any sense to run it (previously, it checked inside upgrade func). -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8561/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/951/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9495/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9349/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8562/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/952/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9496/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9350/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Yoav Kleinberger has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/28124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 542: try:
Line 543: unexportNFS(export)
Line 544: except TestRunnerError as e:
Line 545: logging.warning("Failed to unexport NFS entry %s: %s",
Line 546: export, e)
> Not too important here, but generally, exc_info=True gives valuable informa
Done
Line 547: else:
Line 548: shutil.rmtree(export, ignore_errors=True)
Line 549:
Line 550:
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect kdump status
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
> Well, I could, but I don't care about reason, I just need to know that kdum
I see but it helps debugging having the stack.
Line 427: return kdumpStatus
Line 428:
Line 429:
Line 430: @utils.memoized
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d7a2a24fdaad74255004af0f327197eaee65f2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28124/4/tests/testrunner.py
File tests/testrunner.py:
Line 392: raise AssertionError(msg)
Line 393:
Line 394:
Line 395: def runCommand(*args):
Line 396: process = subprocess.Popen(args, stderr=subprocess.PIPE,
> All over the code we use the utils.execCmd wrapper (together with its slow
it's a bad practice. what is the use of continuing it?
bear in mind that this is just the first of many patches that are intended to
bring the tests into shape: In general these tests are infected with bad
practices (and totally wrong assertions). We should not conform to them - we
should fix them, step by step.
I suggest to continue in a future patch and remove all the execCmd from the
tests.
I'm up to it if you are. don't you agree?
Line 397:stdout=subprocess.PIPE)
Line 398: output, error = process.communicate()
Line 399: if process.returncode != 0:
Line 400: raise TestRunnerError("subprocess failed: returncode=%s:
stderr=%r" %
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Always use OOP when padding snapshot's memory volume
Dan Kenigsberg has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26538/4//COMMIT_MSG
Commit Message:
Line 7: Always use OOP when padding snapshot's memory volume
Line 8:
Line 9: We used to use OOP when padding snapshot's memory volume only if the
Line 10: storage type was NFS. In order to determine if the storage type is NFS
Line 11: we had to call the costly (and possibly failing) getStorageDomainInfo
when is it failing? why do we want to continue with the padding if it has
failed?
Line 12: method. Since other file based storage types can theoretically suffer
Line 13: from the same problems as the ones NFS suffer from, it seems safer to
Line 14: use OOP for all of them and not perform that costly call.
Line 15:
http://gerrit.ovirt.org/#/c/26538/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3725: '_srcDomXML': self._dom.XMLDesc(0),
Line 3726: 'elapsedTimeOffset': time.time() -
self._startTime}
Line 3727:
Line 3728: def _padMemoryVolume(memoryVolPath, sdUUID):
Line 3729: if not utils.isBlockDevice(memoryVolPath):
isBlockDevice() does os.stats() which may hang forever on top of NFS.
Line 3730: oop.getProcessPool(sdUUID).fileUtils. \
Line 3731: padToBlockSize(memoryVolPath)
Line 3732:
Line 3733: snap = xml.dom.minidom.Element('domainsnapshot')
--
To view, visit http://gerrit.ovirt.org/26538
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas
Gerrit-Reviewer: Arik Hadas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sign sanlock not configured when service down and stop recon...
Alon Bar-Lev has posted comments on this change. Change subject: Sign sanlock not configured when service down and stop reconfigure of force .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28007/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 193: Line 194: return configured Line 195: Line 196: def reconfigureOnForce(self): Line 197: return False > but it is called "reconfigure on force" so with --force it will always reco this is: override = args.force and c.reconfigureOnForce() so we want to return True to allow reconfigure at force. Line 198: Line 199: Line 200: __configurers = ( Line 201: LibvirtModuleConfigure(), -- To view, visit http://gerrit.ovirt.org/28007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect kdump status
Martin Peřina has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 58:
Line 59:
Line 60: _KDUMP_STATUS_PATH = '/sys/kernel/kexec_crash_loaded'
Line 61: _KDUMP_CONFIG_PATH = '/etc/kdump.conf'
Line 62:
> why do you need this here? you use it only once
You told me in patch set 2 to move them into constant :-(
Line 63:
Line 64: class OSName:
Line 65: UNKNOWN = 'unknown'
Line 66: OVIRT = 'oVirt Node'
Line 420: with open(_KDUMP_CONFIG_PATH, 'r') as f:
Line 421: for line in f:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
> afaik more common to take latest config and not the first
if '/sys/kernel/kexec_crash_loaded' contains 1, there shouldn't be any error in
/etc/kdump.conf, otherwise kdump service wouldn't start. To confirm, that
fence_kdump is configured, I just need to know that it contains line starting
with "fence_kdump_nodes".
Btw "fence_kdump_nodes" value will be set during host deploy ...
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
Line 427: return kdumpStatus
Line 428:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
> As yaniv shared, you can use logging.erro/debug/('', exc_info=True)
Well, I could, but I don't care about reason, I just need to know that kdump is
configured and running. If it's not, sysadmin should look into machine and fix
the problem.
Line 427: return kdumpStatus
Line 428:
Line 429:
Line 430: @utils.memoized
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d7a2a24fdaad74255004af0f327197eaee65f2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 542: try:
Line 543: unexportNFS(export)
Line 544: except TestRunnerError as e:
Line 545: logging.warning("Failed to unexport NFS entry %s: %s",
Line 546: export, e)
Not too important here, but generally, exc_info=True gives valuable information
on where the exception came from.
Line 547: else:
Line 548: shutil.rmtree(export, ignore_errors=True)
Line 549:
Line 550:
http://gerrit.ovirt.org/#/c/28124/4/tests/testrunner.py
File tests/testrunner.py:
Line 392: raise AssertionError(msg)
Line 393:
Line 394:
Line 395: def runCommand(*args):
Line 396: process = subprocess.Popen(args, stderr=subprocess.PIPE,
All over the code we use the utils.execCmd wrapper (together with its slow and
possibly-broken communicate()). Despite this being only for tests, please
conform with the rest of the code.
Line 397:stdout=subprocess.PIPE)
Line 398: output, error = process.communicate()
Line 399: if process.returncode != 0:
Line 400: raise TestRunnerError("subprocess failed: returncode=%s:
stderr=%r" %
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
Dan Kenigsberg has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 4: Code-Review-1 manual rebase required. -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
Dan Kenigsberg has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect kdump status
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 416:
Line 417: if kdumpStatus == 1:
Line 418: # check if fence_kdump is configured
Line 419: kdumpStatus = 0
Line 420: with open(_KDUMP_CONFIG_PATH, 'r') as f:
> no need for constants if you use those only once
Hello,
I think constants are good to be used but in this case indeed you don't need.
However, I would use local constants in _getKdumpStatus() for:
-1 - UNKNOWN (it's set if some error appears during status check)
0 - DISABLED (kdump is not loaded or fence_kdump is not configured)
1 - ENABLED (kdump is loaded properly and fence_kdump is configured)
_KDUMP_ERROR = -1
_KDUMP_DISABLE = 0
_KDUMP_ENABLE = 1
Other approach is use docstring or even constanst + docstring.
Line 421: for line in f:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
> 1. but if kdumpStatus was 1 but fence_kdump config path throws IOERROR, you
As yaniv shared, you can use logging.erro/debug/('', exc_info=True)
Line 427: return kdumpStatus
Line 428:
Line 429:
Line 430: @utils.memoized
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d7a2a24fdaad74255004af0f327197eaee65f2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sign sanlock not configured when service down and stop recon...
Yaniv Bronhaim has posted comments on this change. Change subject: Sign sanlock not configured when service down and stop reconfigure of force .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28007/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 193: Line 194: return configured Line 195: Line 196: def reconfigureOnForce(self): Line 197: return False > and I claim htat the reconfigure of this module should run with or without but it is called "reconfigure on force" so with --force it will always reconfigure the module .. not sure i understand you correctly Line 198: Line 199: Line 200: __configurers = ( Line 201: LibvirtModuleConfigure(), -- To view, visit http://gerrit.ovirt.org/28007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_config: move download certificate
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 35: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1363/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_config: move download certificate
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm_config: move download certificate .. vdsm_config: move download certificate DHCP servers might delay to deliver the ip address and we can't download the engine certificate from vdsm-config stage. This patch is moving the download certificate from vdsm-config to vdsm-reg-setup. Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065368 Signed-off-by: Alon Bar-Lev Signed-off-by: Douglas Schilling Landgraf Reviewed-on: http://gerrit.ovirt.org/26718 Reviewed-by: Dan Kenigsberg --- M vdsm_reg/deployUtil.py.in M vdsm_reg/vdsm-config M vdsm_reg/vdsm-reg-setup.in M vdsm_reg/vdsm-reg.conf.in 4 files changed, 133 insertions(+), 10 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_config: move download certificate
Dan Kenigsberg has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 34: Code-Review+2 I think we can take this now, and worry about the ovirt-patch -- To view, visit http://gerrit.ovirt.org/26718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: use 'localhost' explicitly in test
Yoav Kleinberger has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 79: isSSL = config.getboolean('vars', 'ssl')
Line 80: if isSSL and os.geteuid() != 0:
Line 81: raise SkipTest("Must be root to use SSL connection to
server")
Line 82: address = 'localhost:%s' % config.get('addresses',
'management_port')
Line 83: self.s = vdscli.connect(hostPort=address, useSSL=isSSL)
> Please explain what fails on your host, and what is different in this test
I investigated the failure and this is what I found:
vdscli.py gets the hostname by parsing the ssl certificate on the machine you
run it on.
usually, this name is resolvable into an IP by all relevant machines. On my
development environment, this name is not defined in our local DNS (I use
/etc/hosts on my other machines to access it). This is why it fails. You can
blame my improper configuration, but please read on before deciding.
Since vdscli clearly assumes that it is running on the very machine that it
will later try to communicate with (it accesses /etc/pki/vdsm) - this is
totally unneeded and overly implicit. BTW, the SSL verification is lacking,
since I can, in fact, connect using SSL to 'localhost', but that is another
issue.
However, I don't need to fix vdscli.py. I can totally avoid this implicit stuff
by passing
'localhost', which makes the test explicit and more readable.
So I'm still in favor of this change.
Line 84:
Line 85: def assertVdsOK(self, vdsResult):
Line 86: # code == 0 means OK
Line 87: self.assertEquals(
--
To view, visit http://gerrit.ovirt.org/28107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix wrong use of assertions
Vered Volansky has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: Use bond5 in functional network tests.
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Use bond5 in functional network tests. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1430/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9494/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9348/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: Use bond5 in functional network tests.
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Use bond5 in functional network tests. .. Patch Set 1: (1 comment) ERR_BAD_BONDING is the exception we are getting now. http://gerrit.ovirt.org/#/c/28141/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 493: for index in range(VLAN_COUNT)] Line 494: with dummyIf(1) as nics: Line 495: firstVlan, firstVlanId = NET_VLANS[0] Line 496: status, msg = self.vdsm_net.addNetwork(firstVlan, vlan=firstVlanId, Line 497:nics=nics, opts=opts) As a bond5 does not exist (bond0 did, which was assumed), ERR_BAD_BONDING is raised instead. Line 498: self.assertEquals(status, SUCCESS, msg) Line 499: with nonChangingOperstate(nics[0]): Line 500: for netVlan, vlanId in NET_VLANS[1:]: Line 501: status, msg = self.vdsm_net.addNetwork(netVlan, -- To view, visit http://gerrit.ovirt.org/28141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Stomp support .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/648/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9346/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: Use bond5 in functional network tests.
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Use bond5 in functional network tests. .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8559/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1429/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9493/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9347/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/647/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9491/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9345/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove and re-create bonds when they are not to be de...
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. Patch Set 8: (1 comment) I will retest http://gerrit.ovirt.org/24456/ with bond5, see http://gerrit.ovirt.org/28141. http://gerrit.ovirt.org/#/c/28062/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1940: network[NETWORK_NAME]['ipaddr']) Line 1941: self.assertEqual(len( Line 1942: self.vdsm_net.netinfo.bondings[BONDING_NAME]['ipv4addrs']), 1) Line 1943: Line 1944: # Redefine the ip address > in the original bug, what was happening was Thank you, Toni. Line 1945: network[NETWORK_NAME]['ipaddr'] = '1.1.1.3' Line 1946: status, msg = self.vdsm_net.setupNetworks(network, bonds, NOCHK) Line 1947: self.assertEqual(status, SUCCESS, msg) Line 1948: self.assertNetworkExists(NETWORK_NAME) -- To view, visit http://gerrit.ovirt.org/28062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: Use bond5 in functional network tests.
Ondřej Svoboda has uploaded a new change for review. Change subject: networkTests: Use bond5 in functional network tests. .. networkTests: Use bond5 in functional network tests. bond0, originally used in the tests, is one of netinfo.REQUIRED_BONDINGS, which are never deleted. In one approach to resetting bonding options, this is done by deleting the bond -- bond0 would be unaffected. Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391 Signed-off-by: Ondřej Svoboda --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/28141/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index a572a33..e17f2e4 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -49,7 +49,7 @@ NETWORK_NAME = 'test-network' VLAN_ID = '27' -BONDING_NAME = 'bond0' +BONDING_NAME = 'bond5' IP_ADDRESS = '240.0.0.1' IP_NETWORK = '240.0.0.0' IP_ADDRESS_IN_NETWORK = '240.0.0.50' -- To view, visit http://gerrit.ovirt.org/28141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0adcd83658c6a6b744cb42faf4fb075e32e3b391 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect kdump status
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7: Code-Review-1
(5 comments)
no tests?
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 58:
Line 59:
Line 60: _KDUMP_STATUS_PATH = '/sys/kernel/kexec_crash_loaded'
Line 61: _KDUMP_CONFIG_PATH = '/etc/kdump.conf'
Line 62:
why do you need this here? you use it only once
Line 63:
Line 64: class OSName:
Line 65: UNKNOWN = 'unknown'
Line 66: OVIRT = 'oVirt Node'
Line 416:
Line 417: if kdumpStatus == 1:
Line 418: # check if fence_kdump is configured
Line 419: kdumpStatus = 0
Line 420: with open(_KDUMP_CONFIG_PATH, 'r') as f:
no need for constants if you use those only once
Line 421: for line in f:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 420: with open(_KDUMP_CONFIG_PATH, 'r') as f:
Line 421: for line in f:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
afaik more common to take latest config and not the first
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
Line 427: return kdumpStatus
Line 428:
Line 422: if line.startswith('fence_kdump_nodes'):
Line 423: kdumpStatus = 1
Line 424: break
Line 425: except (IOError, OSError, ValueError):
Line 426: kdumpStatus = -1
1. but if kdumpStatus was 1 but fence_kdump config path throws IOERROR, you set
it to -1.. which is not true.
2. you can check if file exists first
3. don't you prefer to print here stacktrace? or log what was wrong ?
Line 427: return kdumpStatus
Line 428:
Line 429:
Line 430: @utils.memoized
http://gerrit.ovirt.org/#/c/25926/7/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 1132: # snapshotting (new in version 4.15.0)
Line 1133: #
Line 1134: # @kdumpStatus: The current status of kdump configuration
for the host:
Line 1135: # enabled (1), disabled(0), unknown(-1)
Line 1136: # (new in version 4.15.0)
why not enum? or as with SELinuxStatus
Line 1137: # Since: 4.15.0
Line 1138: #
Line 1139: # Notes: Since ovirt-engine cannot parse software versions in
'x.y.z' format,
Line 1140: #the current API truncates @software_version to 'x.y'.
--
To view, visit http://gerrit.ovirt.org/25926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d7a2a24fdaad74255004af0f327197eaee65f2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8556/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/949/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9490/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9344/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove and re-create bonds when they are not to be de...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8555/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1428/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9343/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
Adam Litke has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix memShared units when reported from MOM
Martin Sivák has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/28115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Lookup conf and device by path
Adam Litke has posted comments on this change. Change subject: virt: Lookup conf and device by path .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f63715cd5142ffaf21ae9ba8d451175ae09be0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove and re-create bonds when they are not to be de...
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. Patch Set 9: Verified+1 Only removed an extra import, copying score. -- To view, visit http://gerrit.ovirt.org/28062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove and re-create bonds when they are not to be de...
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/28062/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1940: network[NETWORK_NAME]['ipaddr']) Line 1941: self.assertEqual(len( Line 1942: self.vdsm_net.netinfo.bondings[BONDING_NAME]['ipv4addrs']), 1) Line 1943: Line 1944: # Redefine the ip address > What is the motivation for changing the address twice? in the original bug, what was happening was setting 1.1.1.1 configured 1.1.1.1 setting 1.1.1.2 configured 1.1.1.2 as secondary and 1.1.1.1 as primary setting 1.1.1.3 configured 1.1.1.3 as secondary and 1.1.1.2 as primary I wanted to go through the whole scenario. Line 1945: network[NETWORK_NAME]['ipaddr'] = '1.1.1.3' Line 1946: status, msg = self.vdsm_net.setupNetworks(network, bonds, NOCHK) Line 1947: self.assertEqual(status, SUCCESS, msg) Line 1948: self.assertNetworkExists(NETWORK_NAME) http://gerrit.ovirt.org/#/c/28062/8/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 38: from vdsm.netconfpersistence import RunningConfig Line 39: Line 40: from . import Configurator, dhclient, getEthtoolOpts, libvirt Line 41: from ..errors import ConfigNetworkError, ERR_FAILED_IFUP Line 42: from ..models import Nic, Bond, Bridge, IpConfig > In this revision, Bond is unused, please remove it :-) Done Line 43: from ..sourceroute import StaticSourceRoute, DynamicSourceRoute Line 44: import dsaversion # TODO: Make parent package import when vdsm is a package Line 45: Line 46: -- To view, visit http://gerrit.ovirt.org/28062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 24: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8554/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/948/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9488/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9342/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Dan Kenigsberg has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 201: required_size = 7
Line 202:
Line 203: def __init__(self, json_binding):
Line 204: self.json_binding = json_binding
Line 205: self.reactor = self.json_binding.createStompReactor()
> Initial design was that there is an instance of reactor per detector. There
Ok, it should work in the way you describe, but still letting the detector
manage the reactor looks strange, and does not belong in this module.
If you put the detector in the jsonrpc module, I would not complain that it
knows about the reactor and json rpc internals. For this module, a detector is
something that expose the detection interface (require_size, detect,
handleSocket, stop).
Line 206: self.json_binding.startReactor(self.reactor)
Line 207:
Line 208: def detect(self, data):
Line 209: return data.startswith("CONNECT") or data.startswith("SEND")
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BindingXmlRPC - do_PUT to return execution result in headers
Nir Soffer has posted comments on this change.
Change subject: BindingXmlRPC - do_PUT to return execution result in headers
..
Patch Set 3:
(1 comment)
Looks ok except the fact that the status code and error message are optional,
some errors will have them and some don't.
http://gerrit.ovirt.org/#/c/27997/3/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 195: response['status']['message'])
Line 196:
Line 197: def send_error(self, error, message, exc_info=False):
Line 198: try:
Line 199: self.log.error(message, exc_info=exc_info)
If our apis includes Status-Code and Error-Message headers, they should be
included for every error, to make integration with 3rd party easier.
Client code will like to get these headers on each request, just like xmlrpc
client code expect the same keys in the dictionary on each request.
If we do not need this info because we have the http status code, then why are
we returning these headers?
Line 200: self.send_response(error)
Line 201: self.end_headers()
Line 202: except Exception:
Line 203: self.log.error("failed to return response",
--
To view, visit http://gerrit.ovirt.org/27997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25b13f44a65cb2c794c458b03ba361bf0af92120
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Liron Ar
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: introducing uploadImageToStream
Nir Soffer has posted comments on this change. Change subject: core: introducing uploadImageToStream .. Patch Set 10: (2 comments) Looks good, one typo and one missing empty line. http://gerrit.ovirt.org/#/c/26741/10/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 146: uploadFinishedEvent, operationEndCallback = \ Line 147: self._createEventWithCallback() Line 148: Line 149: # Optional header Line 150: volUUID = self.headers.getheader(self.HEADER_VOLUME) An empty line before calling im.uploadToStream would help reading this. Line 151: response = img.uploadToStream(methodArgs, Line 152: operationEndCallback, Line 153: startEvent, volUUID) Line 154: Line 170: startEvent.set() Line 171: self._waitForEvent(uploadFinishedEvent) Line 172: Line 173: except self.RequestException as e: Line 174: # This is an expected exception, so tranceback is unneeded tranceback -> traceback Line 175: self.send_error(e.httpStatusCode, e.errorMessage) Line 176: except Exception: Line 177: self.send_error(httplib.INTERNAL_SERVER_ERROR, Line 178: "error during execution", -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
Nir Soffer has posted comments on this change. Change subject: core: imageSharing - export logic to functions .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 5: We can use argparse, but if we want to preserve the usage of all @exposed commands, we'd have to change how usage output is generated and add it to argparse as epilog, can change it if it is an issue. -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: imageSharing - export logic to functions .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/947/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: BindingXMLRPC - exporting logic out from do_PUT.
Nir Soffer has posted comments on this change. Change subject: core: BindingXMLRPC - exporting logic out from do_PUT. .. Patch Set 10: Code-Review+1 (1 comment) There is one issue with _getIntHeader implementation. http://gerrit.ovirt.org/#/c/26740/10/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 199: def _waitForEvent(event): Line 200: while not event.is_set(): Line 201: event.wait() Line 202: Line 203: def _getIntHeader(self, headerName, missingError): I don't like passing the error code for the exception here. Waiting for Federico review about this. Line 204: value = self.headers.getheader( Line 205: headerName) Line 206: if not value: Line 207: raise self.RequestException( -- To view, visit http://gerrit.ovirt.org/26740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bb1b0a4cb85ce822929f1907847dd63eb69fc2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Xavi Francisco Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_tests: add reusing dhclient owned iface
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_tests: add reusing dhclient owned iface .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1362/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ceb7dcc853d2d2683c36327143175795de56854 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: BindingXMLRPC - exporting logic out from do_PUT.
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: BindingXMLRPC - exporting logic out from do_PUT. .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/945/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9339/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bb1b0a4cb85ce822929f1907847dd63eb69fc2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_tests: add reusing dhclient owned iface
Dan Kenigsberg has submitted this change and it was merged. Change subject: net_tests: add reusing dhclient owned iface .. net_tests: add reusing dhclient owned iface https://bugzilla.redhat.com/1100264 showed us that we are lacking testing of interface reusing, specifically about reusing dhclient owned devices. This patch covers this hole in our test coverage. Change-Id: I5ceb7dcc853d2d2683c36327143175795de56854 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/28049 Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ceb7dcc853d2d2683c36327143175795de56854 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_tests: add reusing dhclient owned iface
Dan Kenigsberg has posted comments on this change. Change subject: net_tests: add reusing dhclient owned iface .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ceb7dcc853d2d2683c36327143175795de56854 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: generify "streamDownloadImage" related methods
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: generify "streamDownloadImage" related methods .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8551/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/944/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9484/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9338/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c73374681b5a5fc9fd0cb81020138fb5c8bfe69 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: introducing uploadImageToStream
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: introducing uploadImageToStream .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8549/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/943/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9483/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9337/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2df4d3a16f39bf80281d7669ed31fd8369bada5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: imageSharing - export logic to functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: imageSharing - export logic to functions .. Patch Set 8: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8548/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/942/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9336/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/26759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861b40cc62c3332b887b64c2525fc512cdc6a22a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9335/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Xavi Francisco Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
