Change in vdsm[master]: vdsm: add support for hostdev passthrough
Francesco Romani has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough .. Patch Set 10: Was version 10 just a rebase? -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough .. Patch Set 10: No, we realized that the libvirt device XML is not usable as hostdev XML, therefore adding the need to generate it in VDSM. Consider version 10 as WIP as it needs a bit more analysis. Also, i'll probably keep it to pci passthrough currently, adding usb and more importantly scsi (more difficult) in separate patches. -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: ignore LVs with special tag
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: ignore LVs with special tag .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9683/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1069/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: libvirtconnection: connect to xen, if it is available
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: libvirtconnection: connect to xen, if it is available
..
xen: libvirtconnection: connect to xen, if it is available
Change-Id: I6cc6474b012d900fe3c5e1dab7a1e3e815ae01c3
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/libvirtconnection.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/28350/1
diff --git a/lib/vdsm/libvirtconnection.py b/lib/vdsm/libvirtconnection.py
index b1332db..983287f 100644
--- a/lib/vdsm/libvirtconnection.py
+++ b/lib/vdsm/libvirtconnection.py
@@ -29,6 +29,7 @@
from . import constants, utils
log = logging.getLogger()
+XEN = os.path.exists('/proc/xen')
class _EventLoop:
@@ -124,7 +125,7 @@
libvirt.VIR_ERR_INTERNAL_ERROR,
libvirt.VIR_ERR_NO_CONNECT,
libvirt.VIR_ERR_INVALID_CONN)
-if edom in EDOMAINS and ecode in ECODES:
+if not XEN and edom in EDOMAINS and ecode in ECODES:
try:
__connections.get(id(target)).pingLibvirt()
except libvirt.libvirtError as e:
@@ -148,7 +149,10 @@
conn = __connections.get(id(target))
if not conn:
log.debug('trying to connect libvirt')
-conn = _open_qemu_connection()
+if XEN:
+conn = libvirt.open('xen:///')
+else:
+conn = _open_qemu_connection()
__connections[id(target)] = conn
setattr(conn, 'pingLibvirt', getattr(conn, 'getLibVersion'))
--
To view, visit http://gerrit.ovirt.org/28350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cc6474b012d900fe3c5e1dab7a1e3e815ae01c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: do not attempt to read underlying device info
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: do not attempt to read underlying device info
..
xen: do not attempt to read underlying device info
Xen's device information is quite different than what Vdsm currently
expects and needs. They lack bus address, alias, and driver.
With this patch, Vdsm-on-Xen does not even attempt to read this
information, which means that it would not be able to inract with the
underlying devices.
This is a hack which I do not expect getting into Vdsm proper. Much
deeper refactoring is required to handle Xen devices.
Change-Id: Ifae785c5caa2e37fb8968ead570502e935f7900f
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/28352/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 21662bc..6a0d035 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2921,7 +2921,8 @@
raise Exception('destroy() called before Vm started')
self._getUnderlyingVmInfo()
-self._getUnderlyingVmDevicesInfo()
+if not libvirtconnection.XEN:
+self._getUnderlyingVmDevicesInfo()
self._updateAgentChannels()
# Currently there is no protection agains mirroring a network twice,
--
To view, visit http://gerrit.ovirt.org/28352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifae785c5caa2e37fb8968ead570502e935f7900f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: refactor: open a new connection in specia...
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtconnection: refactor: open a new connection in special
function
..
libvirtconnection: refactor: open a new connection in special function
This patch splits opening of a new connection to qemu:///system into a
new function, distinct of further decorations. get() is a cumbersome
function that could use some trimming.
Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/libvirtconnection.py
1 file changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/28348/1
diff --git a/lib/vdsm/libvirtconnection.py b/lib/vdsm/libvirtconnection.py
index 31b6a3a..b1332db 100644
--- a/lib/vdsm/libvirtconnection.py
+++ b/lib/vdsm/libvirtconnection.py
@@ -77,6 +77,24 @@
__connectionLock = threading.Lock()
+def _open_qemu_connection():
+def req(credentials, user_data):
+passwd = file(constants.P_VDSM_LIBVIRT_PASSWD).readline().rstrip(\n)
+for cred in credentials:
+if cred[0] == libvirt.VIR_CRED_AUTHNAME:
+cred[4] = constants.SASL_USERNAME
+elif cred[0] == libvirt.VIR_CRED_PASSPHRASE:
+cred[4] = passwd
+return 0
+
+auth = [[libvirt.VIR_CRED_AUTHNAME, libvirt.VIR_CRED_PASSPHRASE],
+req, None]
+
+libvirtOpen = functools.partial(
+libvirt.openAuth, 'qemu:///system', auth, 0)
+return utils.retry(libvirtOpen, timeout=10, sleep=0.2)
+
+
def get(target=None, killOnFailure=True):
Return current connection to libvirt or open a new one.
Use target to get/create the connection object linked to that object.
@@ -126,25 +144,11 @@
raise
return wrapper
-def req(credentials, user_data):
-passwd = file(constants.P_VDSM_LIBVIRT_PASSWD).readline().rstrip(\n)
-for cred in credentials:
-if cred[0] == libvirt.VIR_CRED_AUTHNAME:
-cred[4] = constants.SASL_USERNAME
-elif cred[0] == libvirt.VIR_CRED_PASSPHRASE:
-cred[4] = passwd
-return 0
-
-auth = [[libvirt.VIR_CRED_AUTHNAME, libvirt.VIR_CRED_PASSPHRASE],
-req, None]
-
with __connectionLock:
conn = __connections.get(id(target))
if not conn:
-libvirtOpenAuth = functools.partial(libvirt.openAuth,
-'qemu:///system', auth, 0)
log.debug('trying to connect libvirt')
-conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
+conn = _open_qemu_connection()
__connections[id(target)] = conn
setattr(conn, 'pingLibvirt', getattr(conn, 'getLibVersion'))
--
To view, visit http://gerrit.ovirt.org/28348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _findLiveSnapshotSupport: do not assume that guest features...
Dan Kenigsberg has uploaded a new change for review.
Change subject: _findLiveSnapshotSupport: do not assume that guest features
exist
..
_findLiveSnapshotSupport: do not assume that guest features exist
Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/caps.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/28349/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index c5458e6..a4caa13 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -191,8 +191,11 @@
None if libvirt does not report the live
snapshot support (as in version = 1.2.2),
'''
-features = guest.getElementsByTagName('features')[0]
-for feature in features.childNodes:
+features = guest.getElementsByTagName('features')
+if not features:
+return None
+
+for feature in features[0].childNodes:
if feature.nodeName == 'disksnapshot':
value = feature.getAttribute('default')
if value.lower() == 'on':
--
To view, visit http://gerrit.ovirt.org/28349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: hook: let oVirt run VMs on Xen hosts
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: hook: let oVirt run VMs on Xen hosts
..
xen: hook: let oVirt run VMs on Xen hosts
With this hook installed (and previous hacks applied) it is possible to
start oVirt VMs as Xen domU HVM guests.
Note that this hook has undergone very limited testing: migration was
not attempted, as well as no shared storage.
The hook is known to be limited, as it does not support qcow images, or
spice; no emulated devices, no hotplugging nor virtio. It is expected to
serve as a proof of concept and as a basis to further experimentation by
other parties.
Change-Id: Iaabda72bebde98d2884fe9fcfe87d266e2dcdde0
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M configure.ac
M debian/Makefile.am
A debian/vdsm-hook-xen.docs
A debian/vdsm-hook-xen.install
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/xen/Makefile.am
A vdsm_hooks/xen/after_get_caps.py
A vdsm_hooks/xen/before_vm_start.py
A vdsm_hooks/xen/empty.test.xml
10 files changed, 343 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/28353/1
diff --git a/configure.ac b/configure.ac
index 5e7f333..0d5bcaf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -310,6 +310,7 @@
vdsm_hooks/vmdisk/Makefile
vdsm_hooks/vmfex/Makefile
vdsm_hooks/vmfex_dev/Makefile
+ vdsm_hooks/xen/Makefile
vdsm_reg/Makefile
])
diff --git a/debian/Makefile.am b/debian/Makefile.am
index 00b0d33..b65dd70 100644
--- a/debian/Makefile.am
+++ b/debian/Makefile.am
@@ -87,6 +87,8 @@
vdsm-hook-vmfex.install \
vdsm-hook-vmfex-dev.docs \
vdsm-hook-vmfex-dev.install \
+vdsm-hook-xen.docs \
+vdsm-hook-xen.install \
vdsm.install \
vdsm.postinst \
vdsm.postrm \
diff --git a/debian/vdsm-hook-xen.docs b/debian/vdsm-hook-xen.docs
new file mode 100644
index 000..5ecd9c6
--- /dev/null
+++ b/debian/vdsm-hook-xen.docs
@@ -0,0 +1 @@
+COPYING
diff --git a/debian/vdsm-hook-xen.install b/debian/vdsm-hook-xen.install
new file mode 100644
index 000..917f772
--- /dev/null
+++ b/debian/vdsm-hook-xen.install
@@ -0,0 +1,2 @@
+usr/libexec/vdsm/hooks/before_device_create/70_xen
+usr/libexec/vdsm/hooks/after_get_caps/70_xen
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 35617ab..46d3d71 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -600,6 +600,16 @@
%description hook-vmdisk
Hook adds additional disk image for a VM (raw or qcow2)
+%package hook-xen
+Summary:Rum an oVirt VM as a Xen domU
+BuildArch: noarch
+Requires: %{name}
+
+%description hook-xen
+VDSM hook that allow oVirt to run its VMs as Xen domU.
+Install this hook on a Xen dom0 with HVM support, and add the host to Engine.
+
+
%if 0%{?with_gluster}
%package gluster
Summary:Gluster Plugin for VDSM
@@ -1385,7 +1395,13 @@
%{_libexecdir}/%{vdsm_name}/hooks/before_device_create/50_vmfex
%{_libexecdir}/%{vdsm_name}/hooks/before_device_migrate_destination/50_vmfex
%{_libexecdir}/%{vdsm_name}/hooks/before_nic_hotplug/50_vmfex
-%endif
+
+%files hook-xen
+%defattr(-, root, root, -)
+%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/70_xen
+%{_libexecdir}/%{vdsm_name}/hooks/after_get_caps/70_xen
+
+%endif # with_hooks
%files debug-plugin
%defattr(-, root, root, -)
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 5e4d731..ef5a22a 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -48,6 +48,7 @@
vmdisk \
vmfex \
vmfex_dev \
+ xen \
$(NULL)
endif
diff --git a/vdsm_hooks/xen/Makefile.am b/vdsm_hooks/xen/Makefile.am
new file mode 100644
index 000..c6c76ca
--- /dev/null
+++ b/vdsm_hooks/xen/Makefile.am
@@ -0,0 +1,42 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+include $(top_srcdir)/build-aux/Makefile.subs
+
+CLEANFILES = \
+ config.log
+
+EXTRA_DIST = \
+ after_get_caps.py \
+ before_vm_start.py \
+ empty.test.xml \
+ $(NULL)
+
+install-data-local:
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_start
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_get_caps
+
Change in vdsm[master]: xen: use qemu connection, as compareCPU is unavailable via xen
Dan Kenigsberg has uploaded a new change for review. Change subject: xen: use qemu connection, as compareCPU is unavailable via xen .. xen: use qemu connection, as compareCPU is unavailable via xen This patch is required until compareCPU is implemented by libvirt's xenlight driver. Change-Id: Ib86a325910aa57847fef194d7c4bd7c7854e2852 Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/caps.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/28351/1 diff --git a/vdsm/caps.py b/vdsm/caps.py index a4caa13..a27f582 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -368,7 +368,10 @@ @utils.memoized def _getCompatibleCpuModels(): -c = libvirtconnection.get() +if libvirtconnection.XEN: +c = libvirtconnection._open_qemu_connection() +else: +c = libvirtconnection.get() allModels = _getAllCpuModels() def compatible(model, vendor): -- To view, visit http://gerrit.ovirt.org/28351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib86a325910aa57847fef194d7c4bd7c7854e2852 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade_unified: fix for nicless and bridges with vnics
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
upgrade_unified: fix for nicless and bridges with vnics
The upgrade script had a mistake when dealing with bridged networks
that made it not consider bridgeless networks nor bridges that had
vnics on them.
This bug would have made that a bridge with nic eth2 and several
vnics would have setup a network targetting:
'eth2vnet0vnet1'
Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/tool/unified_persistence.py
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/28354/1
diff --git a/lib/vdsm/tool/unified_persistence.py
b/lib/vdsm/tool/unified_persistence.py
index 46bf8e2..d4222e6 100644
--- a/lib/vdsm/tool/unified_persistence.py
+++ b/lib/vdsm/tool/unified_persistence.py
@@ -64,10 +64,20 @@
networks[network]['bridged'] = netParams['bridged']
# Determine devices: nic/bond - vlan - bridge
-physicalDevice = .join(netParams['ports']) if \
-netParams.get('ports') else netParams.get('interface')
-topLevelDevice = netParams['iface'] if \
-netParams['bridged'] else physicalDevice
+topLevelDevice = netParams['iface']
+if netParams['bridged']:
+devices = (netinfo.nics.keys() + netinfo.vlans.keys() +
+ netinfo.bondings.keys())
+nonVnicPorts = [dev for dev in netParams['ports'] if
+dev in devices]
+# A network should only ever have (at most) an underlying
+# device hierarchy
+if nonVnicPorts:
+physicalDevice, = nonVnicPorts
+else:
+physicalDevice = None # vdsm allows nicless VM nets
+else:
+physicalDevice = topLevelDevice
# Copy ip addressing information
bootproto = str(getIfaceCfg(topLevelDevice).get('BOOTPROTO'))
@@ -96,7 +106,7 @@
# Is the physical device a bond or a nic?
if physicalDevice in netinfo.bondings:
networks[network]['bonding'] = physicalDevice
-else:
+elif physicalDevice in netinfo.nics:
networks[network]['nic'] = physicalDevice
return networks
--
To view, visit http://gerrit.ovirt.org/28354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade_unified: fix for nicless and bridges with vnics
Antoni Segura Puimedon has posted comments on this change. Change subject: upgrade_unified: fix for nicless and bridges with vnics .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade_unified: fix for nicless and bridges with vnics
Antoni Segura Puimedon has posted comments on this change.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
Patch Set 1:
Verified manually trying several network configurations:
Add nicless net
toniel602 ~ # vdsClient -s 0 addNetwork bridge=nicless nics= bootproto=none
Done
Add bridged, vlanned, bonded network
toniel602 ~ # vdsClient -s 0 addNetwork bridge=bar nics=eth3,eth4
bonding=bond0 vlan=15
Done
Add another port to the bridge (simulates having a vnet device)
toniel602 ~ # ip link add vnet0 link eth1 type macvlan
toniel602 ~ # brctl addif bar vnet0
Check that the vnet is not reported and that the nicless network does not
report a value-less nic key.
In [36]: unified_persistence._getNetInfo()
Out[36]:
({'bar': {'bonding': 'bond0',
'bridged': True,
'defaultRoute': False,
'mtu': 1500,
'stp': False,
'vlan': '15'},
'nicless': {'bridged': True,
'defaultRoute': False,
'mtu': 1500,
'stp': False}},
{'bond0': {'nics': ['eth3', 'eth4'], 'options': 'mode=802.3ad
miimon=150'}})
Try with simple brided and bridgeless networks over a nic:
toniel602 ~ # vdsClient -s 0 addNetwork bridge=other nics=eth3
bootproto=none
Done
toniel602 ~ # vdsClient -s 0 addNetwork bridge=otherbrless nics=eth4
bootproto=none bridged=False
Done
In [18]: unified_persistence._getNetInfo()
Out[18]:
({'other': {'bridged': True,
'defaultRoute': False,
'mtu': 1500,
'nic': 'eth3',
'stp': False},
'otherbrless': {'bridged': False,
'defaultRoute': False,
'mtu': 1500,
'nic': u'eth4'}},
{})
Then a bridged vlanned:
toniel602 ~ # vdsClient -s 0 addNetwork bridge=bar nics=eth3 vlan=15
Done
In [24]: unified_persistence._getNetInfo()
Out[24]:
({'bar': {'bridged': True,
'defaultRoute': False,
'mtu': 1500,
'nic': 'eth3',
'stp': False,
'vlan': '15'}},
{})
--
To view, visit http://gerrit.ovirt.org/28354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: replace magic number
..
virt: migration: replace magic number
replace a magic constant with the symbolic name to clarify
the intent of the code.
What the code does is to check the migration job is still active.
The symbolic name was found by checking the docs:
http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo
(beware of misalinged comments).
'jobType' can be one of
http://libvirt.org/html/libvirt-libvirt.html#virDomainJobType
Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/migration.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/28356/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index b5d840d..76f0922 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -468,7 +468,7 @@
' Refer to RHBZ#919201.',
dataRemaining / Mbytes, self._lowmark / Mbytes)
-if jobType != 0:
+if jobType != libvirt.VIR_DOMAIN_JOB_NONE:
self.progress = update_progress(dataRemaining, dataTotal)
self._vm.log.info('Migration Progress: %s seconds elapsed,'
' %s%% of data processed' %
--
To view, visit http://gerrit.ovirt.org/28356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _findLiveSnapshotSupport: do not assume that guest features...
oVirt Jenkins CI Server has posted comments on this change. Change subject: _findLiveSnapshotSupport: do not assume that guest features exist .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9538/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: rename helper function
..
virt: migration: rename helper function
rename helper function to be a bit more consistent
with the new style guidelines.
Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/28355/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index ca73f75..b5d840d 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -424,7 +424,7 @@
if self._lastProgressTime is None:
self._lastProgressTime = time.time()
-def calculateProgress(remaining, total):
+def update_progress(remaining, total):
if remaining == 0 and total:
return 100
progress = 100 - 100 * remaining / total if total else 0
@@ -469,7 +469,7 @@
dataRemaining / Mbytes, self._lowmark / Mbytes)
if jobType != 0:
-self.progress = calculateProgress(dataRemaining, dataTotal)
+self.progress = update_progress(dataRemaining, dataTotal)
self._vm.log.info('Migration Progress: %s seconds elapsed,'
' %s%% of data processed' %
(timeElapsed / 1000, self.progress))
--
To view, visit http://gerrit.ovirt.org/28355
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: refactor: open a new connection in specia...
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: refactor: open a new connection in special function .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9537/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 16: Verified+1 fixed a rebase glitch which cause an AttributeError (MONITOR_INTERVAL vs MIGRATION_MONITOR_INTERVAL) Verified together with 25977, 25978, 25979 by running migrations back and fort between a couple of hypervisors and observing the progress is still reporting and inspecting the logs. -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Code-Review+1 i believe this is much better than the last modification for ppc. faqemu still has its merit for automated tests on x86 platform too -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Francesco Romani has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 1: Verified+1 trivial. Verified by doing a migration, just to rule out spelling mistakes (seems OK) -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Francesco Romani has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 1: Verified+1 trivial. Verified by running a migration just to rule out spelling mistakes. -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: libvirtconnection: connect to xen, if it is available
oVirt Jenkins CI Server has posted comments on this change. Change subject: xen: libvirtconnection: connect to xen, if it is available .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9539/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cc6474b012d900fe3c5e1dab7a1e3e815ae01c3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: use qemu connection, as compareCPU is unavailable via xen
oVirt Jenkins CI Server has posted comments on this change. Change subject: xen: use qemu connection, as compareCPU is unavailable via xen .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9687/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9540/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86a325910aa57847fef194d7c4bd7c7854e2852 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Francesco Romani has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 17: Verified+1 Verified with 25976, 25978, 25979 by running migrations and by inspecting the logs, being the downtime information not exposed anywere else. -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 18: Verified+1 Verified with 25976, 25977 and 25979 by running a few migrations. -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 17: s/25979/26279/ -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 18: s/25979/26279/ -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 16: s/25979/26279/ -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 7: Verified+1 Verified with 25976, 25977, 25978 running migrations a few times and observing the migration progress (logs, UI) and the downtime (logs) being updated. -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: do not attempt to read underlying device info
oVirt Jenkins CI Server has posted comments on this change. Change subject: xen: do not attempt to read underlying device info .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9688/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9541/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifae785c5caa2e37fb8968ead570502e935f7900f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: refactor: open a new connection in specia...
Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: refactor: open a new connection in special function .. Patch Set 1: Verified+1 Verified by running unit tests. Has no functional effect. -- To view, visit http://gerrit.ovirt.org/28348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xen: hook: let oVirt run VMs on Xen hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: xen: hook: let oVirt run VMs on Xen hosts .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9542/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaabda72bebde98d2884fe9fcfe87d266e2dcdde0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _findLiveSnapshotSupport: do not assume that guest features...
Dan Kenigsberg has posted comments on this change. Change subject: _findLiveSnapshotSupport: do not assume that guest features exist .. Patch Set 1: Verified+1 Verified to have no effect on qemu:///system connections, and to return None (as expected) on xen:/// connections. -- To view, visit http://gerrit.ovirt.org/28349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _findLiveSnapshotSupport: do not assume that guest features...
Francesco Romani has posted comments on this change. Change subject: _findLiveSnapshotSupport: do not assume that guest features exist .. Patch Set 1: Code-Review+1 there is probably room for a beautification, but this can surely wait future patches. -- To view, visit http://gerrit.ovirt.org/28349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade_unified: fix for nicless and bridges with vnics
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade_unified: fix for nicless and bridges with vnics .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9690/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9543/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9544/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 18: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Vinzenz Feenstra has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9545/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9546/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9694/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9547/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9695/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9548/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has uploaded a new change for review. Change subject: vm: fix odd migration progress reporting .. vm: fix odd migration progress reporting migration progress should not start from 100, otherwise the user will see smething like: progress: 100 - 0% ... X% ... 100% A real-word scenario that shows the need for this patch is the following: If during the the initialization of migration we experience some delay, for example DNS resolve issues, libvirt returns 0 for all the progress values, and that incorrectly triggered the old shortcut, leading to an incorrect initial progress value of 100. Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Bug-Url: https://bugzilla.redhat.com/1104670 Signed-off-by: Francesco Romani from...@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/28362/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 69f7cb4..a21d08b 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -765,7 +765,7 @@ def run(self): def calculateProgress(remaining, total): -if remaining == 0: +if remaining == 0 and total: return 100 progress = 100 - 100 * remaining / total if total else 0 return progress if (progress 100) else 99 -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has posted comments on this change. Change subject: vm: fix odd migration progress reporting .. Patch Set 1: this patch is not the same of master due to recent refactorings. -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has abandoned this change. Change subject: vm: fix odd migration progress reporting .. Abandoned will do proper cherry-pick to make automation happy -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Hello Tomas Jelinek, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28363 to review the following change. Change subject: vm: fix odd migration progress reporting .. vm: fix odd migration progress reporting migration progress should not start from 100, otherwise the user will see smething like: progress: 100 - 0% ... X% ... 100% A real-word scenario that shows the need for this patch is the following: If during the the initialization of migration we experience some delay, for example DNS resolve issues, libvirt returns 0 for all the progress values, and that incorrectly triggered the old shortcut, leading to an incorrect initial progress value of 100. Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27465 Tested-by: Tomas Jelinek tjeli...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/28363/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 69f7cb4..a21d08b 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -765,7 +765,7 @@ def run(self): def calculateProgress(remaining, total): -if remaining == 0: +if remaining == 0 and total: return 100 progress = 100 - 100 * remaining / total if total else 0 return progress if (progress 100) else 99 -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9696/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9549/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: ensure that master domain is active
Federico Simoncelli has posted comments on this change. Change subject: sp: ensure that master domain is active .. Patch Set 2: Verified+1 Verified: * it is impossible to connect to a pool where the master domain is attached (and not active) * other flows seems unaffected (still possible to connect to a regular storage pool) -- To view, visit http://gerrit.ovirt.org/28331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: prevent master demotion on activation
Federico Simoncelli has posted comments on this change. Change subject: sp: prevent master demotion on activation .. Patch Set 2: Verified+1 Verified (regular flow only): * it is possible to activate a storage domain -- To view, visit http://gerrit.ovirt.org/28332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47a0c3ea16bcdefa99899e04c453eaf995344dfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: ensure that master domain is active
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: ensure that master domain is active .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9697/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1070/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: ensure that master domain is active
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: ensure that master domain is active .. sp: ensure that master domain is active It's not possible to be connected to a pool where the master domain is attached (and not active). In case the engine tries to send a domain map (memory backend) in which the master domain is attached the operation should fail. Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28331 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/sp.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: ensure that master domain is active
Dan Kenigsberg has posted comments on this change. Change subject: sp: ensure that master domain is active .. Patch Set 2: Code-Review+2 Seems reasonable to me. -- To view, visit http://gerrit.ovirt.org/28331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: ensure that master domain is active
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: ensure that master domain is active .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1385/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e8fe07ebf8e59e9b028678fecd0a24578348b6c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: prevent master demotion on activation
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: prevent master demotion on activation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9551/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1071/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47a0c3ea16bcdefa99899e04c453eaf995344dfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mutipath: Remove unneeded and dangerous -r parameter
Dan Kenigsberg has submitted this change and it was merged. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. mutipath: Remove unneeded and dangerous -r parameter Since commit dbf2089488 (Jul 9 2013) multipath call was change to use the -r flag, forcing a reload of the device map. This was tested to fix a case where new lun is created on the storage server, while a host was connected, and the new device is not available when issuing the getDeviceList command. According to a comment on gerrit, the change was tested for ISCSI and FC storage types, but there is no documentation of the testing procedure. The related bug was verified, but has no information about how it was verified. We have two related bugs: - Bug 1078879 tell us that invoking multipath with the -r flag sometimes triggers a segfault in the multipathd daemon. In the bug, multipath developer suggests that as long as multipathd daemon is running, there is no need to invoke multipath to detect new devices, and multipath -r really isn't useful for much of anything. - Bug 1071654 tell us that devices rescanning is broken on FC storage domains (although the -r flag is used). I reproduced this bug using storage QE FC server. This patch removes the -r flag. To be on the safe side, I left the multipath call as it was since the first multipath commit in 2009. We will work with kernel and multipath developers further on removing this call if it is indeed unneeded. Bug-Url: https://bugzilla.redhat.com/1078879 Relates-to: https://bugzilla.redhat.com/1071654 Relates-to: http://gerrit.ovirt.org/17263 Change-Id: I880ab5343df3e0030638901e188320b20570747d Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27242 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com --- M vdsm/storage/multipath.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880ab5343df3e0030638901e188320b20570747d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mutipath: Remove unneeded and dangerous -r parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1386/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I880ab5343df3e0030638901e188320b20570747d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix memShared units when reported from MOM
Dan Kenigsberg has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 1: I do not really mind this patch, but strictly speaking, the ovirt-3.3 branch is no longer supported. We try to direct our energy to future-facing branches. -- To view, visit http://gerrit.ovirt.org/28267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: IGNORE: testing gerrit triggered jobs
David Caro has abandoned this change. Change subject: IGNORE: testing gerrit triggered jobs .. Abandoned -- To view, visit http://gerrit.ovirt.org/26570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic8946fd09d50e68f5111860a90572c12d14c7326 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro dcaro...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28379 to review the following change. Change subject: hsm: unify vm ovf management lock .. hsm: unify vm ovf management lock Taking one lock per VM definition could be extremely slow (especially when the engine sends 100 ovf). In one case it took more than 3 minutes to take 76 locks. This patch unifies the VM locks into a generic one. There was no real advantage in the current implementation, in fact if by any chance updateVM was stuck trying to persist a VM definition it is understood that also removeVM would get stuck at file-system level. Moreover storing 100 ovf is a quite fast operation (if it doesn't get stuck) and it is not supposed to starve removeVM. Multiple removeVM calls are still executed in parallel because the generic lock is acquired in shared mode. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1103844 Relates-To: https://bugzilla.redhat.com/show_bug.cgi?id=1100527 Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28068 Reviewed-by: Dan Kenigsberg dan...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/28379/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 8b8850b..7178ce2 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1348,10 +1348,7 @@ if not sdUUID or sdUUID == sd.BLANK_UUID: sdUUID = pool.masterDomain.sdUUID -vmUUIDs = [vmDesc['vm'] for vmDesc in vmList] -vmUUIDs.sort() -for vmUUID in vmUUIDs: -vars.task.getExclusiveLock(STORAGE, %s_%s % (vmUUID, sdUUID)) +vars.task.getExclusiveLock(STORAGE, vms_ + sdUUID) pool.updateVM(vmList=vmList, sdUUID=sdUUID) @public @@ -1373,7 +1370,9 @@ pool = self.getPool(spUUID) if not sdUUID or sdUUID == sd.BLANK_UUID: sdUUID = pool.masterDomain.sdUUID -vars.task.getExclusiveLock(STORAGE, %s_%s % (vmUUID, sdUUID)) + +vars.task.getSharedLock(STORAGE, vms_ + sdUUID) +vars.task.getExclusiveLock(STORAGE, vms_%s_%s % (vmUUID, sdUUID)) pool.removeVM(vmUUID=vmUUID, sdUUID=sdUUID) @public -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Dan Kenigsberg has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28320/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-06-03 12:16:37 +0200
Line 6:
Line 7: faqemu hook: move memory limitation to config
Line 8:
Line 9: Qemu supports more than 20 MB memory[1], removing the need for hardcoded
Your patch seems fine, but the commit message is misleading. The memory limit
of faqemu is unrelated to [1]. It was simply a means to start the least-costly
qemu process - which cannot even run any meaningful guest. That's why it's only
a fake qemu.
This patch makes it possible to have true guests running in emulating
(non-virtualizing) qemu, by adhering to Engine-supplied memory size. That's
fine.
Line 10: memory limit. This patch allows faqemu memory to be either unchanged,
Line 11: or limited by the configuration file. Usage of 20 MB memory is
required
Line 12: when running faqemu with system kernel/initramfs combo.
Line 13:
http://gerrit.ovirt.org/#/c/28320/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 182:
Line 183: ('fake_kvm_architecture', 'x86_64',
Line 184: 'Choose the target architecture of the fake KVM mode'),
Line 185:
Line 186: ('fake_kvm_memory', '262144', None),
this changes the default behavior for x86_64 users of faqemu; their processes
would start consuming 10 times more memory.
We could notify them, and have them edit vdsm.conf before usage. Alternatively,
we could set fake_kvm_memory.x86_64 and fake_kvm_memory.ppc64 to maintain
current behaviour.
Also, please avoid (very natural) laziness, and document any new variable such
as this (the third tuple element is intended for that).
Line 187:
Line 188: ('xmlrpc_enable', 'true', 'Enable the xmlrpc server'),
Line 189:
Line 190: ('xmlrpc_http11', 'true',
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: prevent master demotion on activation
Dan Kenigsberg has posted comments on this change. Change subject: sp: prevent master demotion on activation .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28332/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1041: Line 1042: # Domain conversion requires the links to be present Line 1043: self._refreshDomainLinks(dom) Line 1044: Line 1045: # This should never happen because we're not deactivating the Why should we comply with misguided request of Engine? It's safer to return an error and give Engine the opportunity to correct its ways. I am guessing that this is what happens currently - the master domain demotior would cause the spm to drop its role, and a new master domain would have to be reconstructed. Line 1046: # current master in deactivateStorageDomain if a new master is Line 1047: # not provided. It is also impossible to connect to a pool Line 1048: # where the master domain is not active. Anyway to be on the Line 1049: # safe side we must prevent the current master domain from -- To view, visit http://gerrit.ovirt.org/28332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47a0c3ea16bcdefa99899e04c453eaf995344dfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop ominous log for libvirt errors
Dan Kenigsberg has abandoned this change. Change subject: drop ominous log for libvirt errors .. Abandoned I reserve the right to restore this patch, and remove the needless log line. -- To view, visit http://gerrit.ovirt.org/17324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icd2a53ffee7fb78cb1c8d171093e93e233ed5ad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: janitorial: format log messages lazily
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: janitorial: format log messages lazily .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9699/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1440/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9552/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac858d31e363483776ba73fd2f0ae9b0907cd52b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu: move hook logic out of vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu: move hook logic out of vdsm .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9700/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8767/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d0079491f707b0abd3fbbe2d47f63697dac9c5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: janitorial: format log messages lazily
Dan Kenigsberg has posted comments on this change. Change subject: net: janitorial: format log messages lazily .. Patch Set 2: Verified+1 Passes the network functional tests, no functional change. -- To view, visit http://gerrit.ovirt.org/28249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac858d31e363483776ba73fd2f0ae9b0907cd52b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
