Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 1:
(4 comments)
3 out of 4 comments where fixed.
need info on 1 comment
http://gerrit.ovirt.org/#/c/28462/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4493: return {'status': doneCode}
Line 4494:
Line 4495: def setCpuTuneQuota(self, quota):
Line 4496:
Line 4497: if self._dom is None:
Why do you have this check? it can happen only if setCpuTuneQuota is calle
Done
Line 4498: return self._reportError(entity='vcpu quota')
Line 4499:
Line 4500: quota = int(quota)
Line 4501: try:
Line 4499:
Line 4500: quota = int(quota)
Line 4501: try:
Line 4502: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4503: return {'status': doneCode}
Keeping try-block as short as possible is a good practice. Please call retu
Done
Line 4504: except libvirt.libvirtError as e:
Line 4505: return self._reportError(msg=e.message, entity='vcpu
quota')
Line 4506:
Line 4507: def setCpuTunePeriod(self, period):
Line 4518: entity='vcpu period')
Line 4519: except libvirt.libvirtError as e:
Line 4520: return self._reportError(msg=e.message, entity='vcpu
period')
Line 4521:
Line 4522: def _reportError(self, key='Err', msg=None, entity=None):
please be kind to your reviewer, and separate this refactoring from the add
can you elaborate, what exactly should be done with this function?
Line 4523: self.log.error(Set new + entity + failed,
exc_info=True)
Line 4524: if msg is None:
Line 4525: error = errCode[key]
Line 4526: else:
Line 4519: except libvirt.libvirtError as e:
Line 4520: return self._reportError(msg=e.message, entity='vcpu
period')
Line 4521:
Line 4522: def _reportError(self, key='Err', msg=None, entity=None):
Line 4523: self.log.error(Set new + entity + failed,
exc_info=True)
this explodes if entity has its default value of None.
Done
Line 4524: if msg is None:
Line 4525: error = errCode[key]
Line 4526: else:
Line 4527: error = {'status': {'code': errCode[key]
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9786/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1128/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28473
to review the following change.
Change subject: Setting enum for isconfigured return value and change override
semantics
..
Setting enum for isconfigured return value and change override semantics
isconfigured now returns CONFIGURED, NOT_CONFIGURED and NOT_SURE. This to
ease and clarify the override semantics.
If module returns CONFIGURED it means that also on force vdsm won't need to
reconfigure it, as the module configured properly. Although if configured
returns NOT_SURE, it means, vdsm already configured the module, but on
force we desire to override those configuration to defaults.
Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1088805
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/28007
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/tool/configurator.py
1 file changed, 57 insertions(+), 47 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/28473/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 37fd416..bb1999b 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -21,13 +21,26 @@
import sys
import grp
import argparse
+import pwd
from .. import utils
from . import service, expose
from ..constants import P_VDSM_EXEC, QEMU_PROCESS_GROUP, VDSM_GROUP
+# Declare state of configuration
+#
+# CONFIGURED = Module is set properly without any required changes on
+# force.
+# NOT_CONFIGURED = Module is not set properly for VDSM and need to be
+# configured.
+# NOT_SURE = VDSM configured module already but on force configure vdsm
+# will set configurations to defaults parameters.
+#
+CONFIGURED, NOT_CONFIGURED, NOT_SURE = range(3)
+
class _ModuleConfigure(object):
+
def __init__(self):
pass
@@ -44,10 +57,7 @@
pass
def isconfigured(self):
-return True
-
-def reconfigureOnForce(self):
-return True
+return NOT_CONFIGURED
class LibvirtModuleConfigure(_ModuleConfigure):
@@ -101,9 +111,9 @@
try:
self._exec_libvirt_configure(check_if_configured)
-return True
+return NOT_SURE
except RuntimeError:
-return False
+return NOT_CONFIGURED
class SanlockModuleConfigure(_ModuleConfigure):
@@ -146,47 +156,47 @@
True if sanlock service is configured, False if sanlock service
requires a restart to reload the relevant supplementary groups.
-configured = False
-try:
-with open(/var/run/sanlock/sanlock.pid, r) as f:
-sanlock_pid = f.readline().strip()
-with open(os.path.join('/proc', sanlock_pid, 'status'),
- r) as sanlock_status:
-proc_status_group_prefix = Groups:\t
-for status_line in sanlock_status:
-if status_line.startswith(proc_status_group_prefix):
-groups = [int(x) for x in
- status_line[len(proc_status_group_prefix):].
- strip().split( )]
-break
+configured = NOT_CONFIGURED
+groups = [g.gr_name for g in grp.getgrall()
+ if 'sanlock' in g.gr_mem]
+gid = pwd.getpwnam('sanlock').pw_gid
+groups.append(grp.getgrgid(gid).gr_name)
+if all(group in self.SANLOCK_GROUPS for group in groups):
+configured = NOT_SURE
+
+if configured == NOT_SURE:
+try:
+with open(/var/run/sanlock/sanlock.pid, r) as f:
+sanlock_pid = f.readline().strip()
+with open(os.path.join('/proc', sanlock_pid, 'status'),
+ r) as sanlock_status:
+proc_status_group_prefix = Groups:\t
+for status_line in sanlock_status:
+if status_line.startswith(proc_status_group_prefix):
+groups = [int(x) for x in
+ status_line[
+ len(proc_status_group_prefix):].
+ strip().split( )]
+break
+else:
+raise RuntimeError(
+Unable to find sanlock service groups
+)
+
+is_sanlock_groups_set = True
+for g in self.SANLOCK_GROUPS:
+if grp.getgrnam(g)[2] not in groups:
+is_sanlock_groups_set = False
+if is_sanlock_groups_set:
+
Change in vdsm[master]: faqemu: move hook logic out of vdsm
Antoni Segura Puimedon has posted comments on this change. Change subject: faqemu: move hook logic out of vdsm .. Patch Set 4: Code-Review-1 (1 comment) Only a very minor nit. Otherwise looks good. http://gerrit.ovirt.org/#/c/27705/4/vdsm_hooks/faqemu/after_get_caps.py File vdsm_hooks/faqemu/after_get_caps.py: Line 1: #!/usr/bin/python /usr/bin/env python2 Line 2: # Line 3: # Copyright 2014 Red Hat, Inc. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify -- To view, visit http://gerrit.ovirt.org/27705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d0079491f707b0abd3fbbe2d47f63697dac9c5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...
Yaniv Bronhaim has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 1: Verified+1 few changes from master to avoid backports of http://gerrit.ovirt.org/#/c/26080 and http://gerrit.ovirt.org/#/c/26565/ -- To view, visit http://gerrit.ovirt.org/28473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 35:
(6 comments)
comments fixed
http://gerrit.ovirt.org/#/c/27258/35/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 30: import tempfile
Line 31: import threading
Line 32: import time
Line 33: import xml.dom.minidom
Line 34: import re
is it used?
Done
Line 35:
Line 36: # 3rd party libs imports
Line 37: import libvirt
Line 38:
Line 267: def _sampleCpuTune(self):
Line 268: infos = self._dom.schedulerParameters()
Line 269: infos['vcpuCount'] =
self._dom.vcpusFlags(libvirt.VIR_DOMAIN_MEM_CURRENT)
Line 270:
Line 271: vcpuLimitUri = 'http://ovirt.org/vm/tune/1.0'
This string should be defined as a CONSTANT. Maybe in the module level.
Done
Line 272: metadataCpuLimit = self._dom.metadata(2, vcpuLimitUri, 0)
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 268: infos = self._dom.schedulerParameters()
Line 269: infos['vcpuCount'] =
self._dom.vcpusFlags(libvirt.VIR_DOMAIN_MEM_CURRENT)
Line 270:
Line 271: vcpuLimitUri = 'http://ovirt.org/vm/tune/1.0'
Line 272: metadataCpuLimit = self._dom.metadata(2, vcpuLimitUri, 0)
Use libvirt.VIR_DOMAIN_METADATA_ELEMENT constant instead on magic 2.
Done
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 276: metadataCpuLimitXML.getElementsByTagName('vcpulimit')
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 276: metadataCpuLimitXML.getElementsByTagName('vcpulimit')
Line 277: value = nodeList[0].childNodes[0].data
if metadataCpuLimit is None, value is not going to be set, and the followin
Done
Line 278:
Line 279: infos['vcpuLimit'] = value
Line 280: return infos
Line 281:
Line 342: ret['vcpu_period'] = 1000
Line 343: else:
Line 344: ret['vcpu_period'] = eInfo['vcpu_period']
Line 345:
Line 346: except (AttributeError, libvirt.libvirtError):
nothing in the try block can raise libvirtError; I cannot find any Attribut
If nothing throws exception here, I will remove the try/except block.
the numbers are not invented, the quota -1 means, do not use a quota, and
period 1000 is a valid period, it does not matter which valid value since the
quota is -1.
Line 347: # Metadata is not set, set the defaults
Line 348: self.log.debug('Domain Metadata is not set',
exc_info=True)
Line 349: ret['vcpu_quota'] = -1
Line 350: ret['vcpu_period'] = 1000
Line 2694: stats['network'] = decStats[var]
Line 2695: elif var == 'balloonInfo':
Line 2696: stats['balloonInfo'] = decStats[var]
Line 2697: elif var == 'vcpu_quota':
Line 2698: stats['vcpu_quota'] = decStats[var]
non-dictionary elements do not need explicit handling here
Done
Line 2699: elif var == 'vcpu_period':
Line 2700: stats['vcpu_period'] = decStats[var]
Line 2701: elif var == 'cpu_count':
Line 2702: stats['cpu_count'] = decStats[var]
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 36: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9787/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8849/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9634/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/654/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...
Yaniv Bronhaim has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 1: -Verified something wrong.. :/ wait with it -- To view, visit http://gerrit.ovirt.org/28473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: move isVdsmImage into utils
..
janitorial: move isVdsmImage into utils
this patch moves vdsm/virt/vm.isVdsmImage into utils without code
changes.
The move has little oif any benefit on its own, but it is a preliminary
step to the move of VmSamplingThread from vm.py to sampling.py.
Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af
Signed-off-by: Francesco Romani from...@redhat.com
---
M lib/vdsm/utils.py
M vdsm/clientIF.py
M vdsm/virt/vm.py
3 files changed, 15 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/28477/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 4e60acf..95ce617 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -104,6 +104,18 @@
return stat.S_ISBLK(os.stat(path).st_mode)
+def isVdsmImage(drive):
+
+Tell if drive looks like a vdsm image
+
+:param drive: drive to check
+:type drive: dict or vm.Drive
+:return: bool
+
+required = ('domainID', 'imageID', 'poolID', 'volumeID')
+return all(k in drive for k in required)
+
+
def touchFile(filePath):
http://www.unix.com/man-page/POSIX/1posix/touch/
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index ea950b6..8811fa5 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -249,7 +249,7 @@
if type(drive) is dict:
device = drive['device']
# PDIV drive format
-if device == 'disk' and vm.isVdsmImage(drive):
+if device == 'disk' and utils.isVdsmImage(drive):
res = self.irs.prepareImage(
drive['domainID'], drive['poolID'],
drive['imageID'], drive['volumeID'])
@@ -336,7 +336,7 @@
def teardownVolumePath(self, drive):
res = {'status': doneCode}
try:
-if vm.isVdsmImage(drive):
+if utils.isVdsmImage(drive):
res = self.irs.teardownImage(drive['domainID'],
drive['poolID'], drive['imageID'])
except TypeError:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7bb1f94..fabd0db 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -45,6 +45,7 @@
from vdsm.config import config
from vdsm.define import ERROR, NORMAL, doneCode, errCode
from vdsm.netinfo import DUMMY_BRIDGE
+from vdsm.utils import isVdsmImage
from storage import outOfProcess as oop
from storage import sd
from storage import fileUtils
@@ -87,18 +88,6 @@
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
TPM_DEVICES = 'tpm'
-
-
-def isVdsmImage(drive):
-
-Tell if drive looks like a vdsm image
-
-:param drive: drive to check
-:type drive: dict or vm.Drive
-:return: bool
-
-required = ('domainID', 'imageID', 'poolID', 'volumeID')
-return all(k in drive for k in required)
def _filterSnappableDiskDevices(diskDeviceXmlElements):
--
To view, visit http://gerrit.ovirt.org/28477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: do not access devices directly outside Vm
Francesco Romani has uploaded a new change for review.
Change subject: virt: do not access devices directly outside Vm
..
virt: do not access devices directly outside Vm
VmStatsThread used to access directly the _devices and conf
fields of vm.Vm.
This patch does a little cleanup by introducing helper getters
to mediate the access to the devices for the Vm clients,
VmStatsThread being the first.
this patch add little benefit on its own but paves the road
to extract VmStatsThread from vm.py and put it in sampling.py.
Change-Id: I4313da06153fd9f2db90315d16b242352a127d01
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 20 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/28478/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index fabd0db..0e6f291 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -205,7 +205,7 @@
# Avoid queries from storage during recovery process
return
-for vmDrive in self._vm._devices[DISK_DEVICES]:
+for vmDrive in self._vm.getDiskDevices():
self._vm.updateDriveVolume(vmDrive)
def _sampleCpu(self):
@@ -218,7 +218,7 @@
return
diskSamples = {}
-for vmDrive in self._vm._devices[DISK_DEVICES]:
+for vmDrive in self._vm.getDiskDevices():
diskSamples[vmDrive.name] = self._vm._dom.blockStats(vmDrive.name)
return diskSamples
@@ -232,14 +232,14 @@
# 'rd_bytes': 85172430L, 'flush_operations': 0L,
# 'wr_operations': 0L, 'wr_bytes': 0L}
diskLatency = {}
-for vmDrive in self._vm._devices[DISK_DEVICES]:
+for vmDrive in self._vm.getDiskDevices():
diskLatency[vmDrive.name] = self._vm._dom.blockStatsFlags(
vmDrive.name, flags=libvirt.VIR_TYPED_PARAM_STRING_OKAY)
return diskLatency
def _sampleNet(self):
netSamples = {}
-for nic in self._vm._devices[NIC_DEVICES]:
+for nic in self._vm.getNicDevices():
netSamples[nic.name] = self._vm._dom.interfaceStats(nic.name)
return netSamples
@@ -281,9 +281,8 @@
sInfo, eInfo, sampleInterval = self.sampleBalloon.getStats()
-for dev in self._vm.conf['devices']:
-if dev['type'] == BALLOON_DEVICES and \
-dev['specParams']['model'] != 'none':
+for dev in self._vm.getBalloonDevicesConf():
+if dev['specParams']['model'] != 'none':
balloon_target = dev.get('target', max_mem)
break
else:
@@ -330,7 +329,7 @@
if sInfo is None:
return
-for nic in self._vm._devices[NIC_DEVICES]:
+for nic in self._vm.getNicDevices():
if nic.name.startswith('hostdev'):
continue
@@ -345,7 +344,7 @@
def _getDiskStats(self, stats):
sInfo, eInfo, sampleInterval = self.sampleDisk.getStats()
-for vmDrive in self._vm._devices[DISK_DEVICES]:
+for vmDrive in self._vm.getDiskDevices():
dName = vmDrive.name
dStats = {}
try:
@@ -393,7 +392,7 @@
'writeLatency': str(writeLatency),
'flushLatency': str(flushLatency)}
-for vmDrive in self._vm._devices[DISK_DEVICES]:
+for vmDrive in self._vm.getDiskDevices():
dName = vmDrive.name
dLatency = {'readLatency': '0',
'writeLatency': '0',
@@ -5069,6 +5068,17 @@
if dev.get('type') == GRAPHICS_DEVICES:
return dev
+def getDiskDevices(self):
+return self._devices[DISK_DEVICES]
+
+def getNicDevices(self):
+return self._devices[NIC_DEVICES]
+
+def getBalloonDevicesConf(self):
+for dev in self.conf['devices']:
+if dev['type'] == BALLOON_DEVICES:
+yield dev
+
def _getNetworkIp(network):
try:
--
To view, visit http://gerrit.ovirt.org/28478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4313da06153fd9f2db90315d16b242352a127d01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: get rid of _getStatsInternal
Francesco Romani has posted comments on this change. Change subject: virt: stats: get rid of _getStatsInternal .. Patch Set 10: Verified+1 manually rebased; verified by re-running the tests. -- To view, visit http://gerrit.ovirt.org/26557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I469759b86115d80bad62c3449fe9084d5f2e550b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Francesco Romani has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 4: Code-Review+1 codewise this patch looks good; The only thing left which I'd like to discuss a bit further is the sampling frequency. -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: get rid of _getStatsInternal
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: get rid of _getStatsInternal .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9789/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8851/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/656/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/26557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I469759b86115d80bad62c3449fe9084d5f2e550b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: move VmStatsThread away from vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: move VmStatsThread away from vm.py .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9788/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8850/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9635/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/655/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/26792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd18288b94c7593ddd2a5e6a1314b6be7a7d8f92 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9790/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8852/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/657/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1129/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: do not access devices directly outside Vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: do not access devices directly outside Vm .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9791/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8853/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/658/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4313da06153fd9f2db90315d16b242352a127d01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: use info log level to report missing checksum
Federico Simoncelli has posted comments on this change. Change subject: storage: use info log level to report missing checksum .. Patch Set 1: Code-Review-1 The warning must remain a warning. What we should do is to check if we need to display it or not, because when the metadata is empty (e.g. bz1073989) there's also no checksum to check. The metadata being empty is something expected and it may deserve just a debug message. -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add direct import of advancedstats helpers
Francesco Romani has uploaded a new change for review.
Change subject: vm: add direct import of advancedstats helpers
..
vm: add direct import of advancedstats helpers
This is purely a transitional patch towards
the move of VmStatsThread from vm.py to sampling.py.
This patch adds directly import of the VmStatsThread
dependencies, in order to make the move of such class
exactly a trivial matter of cut/paste plus fixing imports,
with exactly zero changes needed to VmStatsThread itself.
Thus the final patch will be more easily
verifiable.
Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/28480/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0e6f291..3b8a16b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -45,6 +45,7 @@
from vdsm.config import config
from vdsm.define import ERROR, NORMAL, doneCode, errCode
from vdsm.netinfo import DUMMY_BRIDGE
+from vdsm.sampling import AdvancedStatsFunction, AdvancedStatsThread
from vdsm.utils import isVdsmImage
from storage import outOfProcess as oop
from storage import sd
@@ -147,44 +148,44 @@
pass
-class VmStatsThread(sampling.AdvancedStatsThread):
+class VmStatsThread(AdvancedStatsThread):
MBPS_TO_BPS = 10 ** 6 / 8
def __init__(self, vm):
-sampling.AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
+AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
self._vm = vm
self.highWrite = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._highWrite,
config.getint('vars', 'vm_watermark_interval')))
self.updateVolumes = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._updateVolumes,
config.getint('irs', 'vol_size_sample_interval')))
self.sampleCpu = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._sampleCpu,
config.getint('vars', 'vm_sample_cpu_interval'),
config.getint('vars', 'vm_sample_cpu_window')))
self.sampleDisk = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._sampleDisk,
config.getint('vars', 'vm_sample_disk_interval'),
config.getint('vars', 'vm_sample_disk_window')))
self.sampleDiskLatency = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._sampleDiskLatency,
config.getint('vars', 'vm_sample_disk_latency_interval'),
config.getint('vars', 'vm_sample_disk_latency_window')))
self.sampleNet = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._sampleNet,
config.getint('vars', 'vm_sample_net_interval'),
config.getint('vars', 'vm_sample_net_window')))
self.sampleBalloon = (
-sampling.AdvancedStatsFunction(
+AdvancedStatsFunction(
self._sampleBalloon,
config.getint('vars', 'vm_sample_balloon_interval'),
config.getint('vars', 'vm_sample_balloon_window')))
--
To view, visit http://gerrit.ovirt.org/28480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add direct import of advancedstats helpers
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add direct import of advancedstats helpers .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9793/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8855/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/660/ : The patch does not pass the virt functional tests -- To view, visit http://gerrit.ovirt.org/28480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: move VmStatsThread away from vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: move VmStatsThread away from vm.py .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9792/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8854/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/659/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/26792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd18288b94c7593ddd2a5e6a1314b6be7a7d8f92 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Francesco Romani has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 4: Sorry, forgot to add: please add unit tests; there are examples in capsTests.py and vmTests.py you can use. -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Maybe its worth to print usage on ExtraArgsError? -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Collect vm numa node runtime pin information
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/28134/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 173: ('vm_sample_vcpu_pin_interval', '2',
Line 174: 'How often should we sample each vcpu runtime pinning to '
Line 175: 'which physical cpu core.'),
Line 176:
Line 177: ('vm_sample_vcpu_pin_window', '2', None),
come to think of it - is there any need in a window here (and for balloon too)?
Can we set it to a hard-coded 0?
Line 178:
Line 179: ('trust_store_path', '@TRUSTSTORE@',
Line 180: 'Where the certificates and keys are situated.'),
Line 181:
http://gerrit.ovirt.org/#/c/28134/4/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 174: def getVmPid(self, vmName):
Line 175: pidFile = /var/run/libvirt/qemu/%s.pid % vmName
Line 176: return open(pidFile).read()
Line 177:
Line 178: def _getVcpuPid(self, vmName):
it's better to keep supervdsmServer free of function-specific code. Please move
this function's implementation to a new module, and add a unit test for it.
Is there a libvirt API to extract the info? (I suppose not)
Line 179: runFile = /var/run/libvirt/qemu/%s.xml % vmName
Line 180: runInfo = xml.dom.minidom.parse(runFile)
Line 181: vCpus = runInfo.getElementsByTagName('vcpus')[0]
Line 182: vCpuSet = vCpus.getElementsByTagName('vcpu')
http://gerrit.ovirt.org/#/c/28134/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 428: self._log.exception(Disk %s latency not
available, dName)
Line 429:
Line 430: stats[dName].update(dLatency)
Line 431:
Line 432: def _getVmNumaNodeRuntimeInfo(self, stats):
can you shed this function to a new numa modules? vm.py is monstrously big. I
think that putting it in its own module would make it easier to write it in a
more testable way.
Line 433:
Line 434: Collect vm numa nodes runtime pinning to which host numa nodes
Line 435: information.
Line 436: Host numa node topology:
--
To view, visit http://gerrit.ovirt.org/28134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Collect vm numa node runtime pin information
Dan Kenigsberg has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 4: Francesco, what do you think about the sampling rate? 2 seconds is quite often I suppose. How frequently do you expect numa positioning to change? How often is it measured by Engine? -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has uploaded a new change for review.
Change subject: Refactoring reportError func
..
Refactoring reportError func
Extracting it from inner function to class level function.
Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Signed-off-by: Kobi Ianko kia...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/28482/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4a6813e..ff0d3ed 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4471,26 +4471,17 @@
def setBalloonTarget(self, target):
-def reportError(key='balloonErr', msg=None):
-self.log.error(Set new balloon target failed, exc_info=True)
-if msg is None:
-error = errCode[key]
-else:
-error = {'status': {'code': errCode[key]
- ['status']['code'], 'message': msg}}
-return error
-
if self._dom is None:
-return reportError()
+return self._reportError(entity='balloon target')
try:
target = int(target)
self._dom.setMemory(target)
except ValueError:
-return reportError(msg='an integer is required for target')
+return self._reportError(msg='an integer is required for target',
entity='balloon target')
except libvirt.libvirtError as e:
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return reportError(key='noVM')
-return reportError(msg=e.message)
+return self._reportError(key='noVM', entity='balloon target')
+return self._reportError(msg=e.message,entity='balloon target')
else:
for dev in self.conf['devices']:
if dev['type'] == BALLOON_DEVICES and \
@@ -4500,6 +4491,16 @@
self.saveState()
return {'status': doneCode}
+def _reportError(self, key='Err', msg=None, entity=None):
+if entity is not None:
+self.log.error(Set new + entity + failed, exc_info=True)
+if msg is None:
+error = errCode[key]
+else:
+error = {'status': {'code': errCode[key]
+['status']['code'], 'message': msg}}
+return error
+
def _getUnderlyingDeviceAddress(self, devXml):
Obtain device's address from libvirt
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 3: Removed error function to external patch -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9794/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8856/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9641/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/661/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9795/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9642/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1130/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Additional oop functionality
Dima Kuznetsov has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27641/11/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 144: oct(mode))) Line 145: Line 146: def padToBlockSize(self, path): Line 147: size = _IOProcessOs(self._iop).stat(path).st_size Line 148: newSize = 512 * ((size + 511) / 512) Maybe this would be a bit more clear? newSize = 512 * int(ceil(size / 512.0)) Also, 512 is ok for all filesystems? Not sure if relevant, but there is fs block-size in statfs-f_bsize. (man 2 statfs) Line 149: log.debug(Truncating file %s to %d bytes, path, newSize) Line 150: truncateFile(self._iop, path, newSize) Line 151: Line 152: def validateAccess(self, targetPath, perms=(os.R_OK | os.W_OK | os.X_OK)): -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add isOvirtNode function.
Hello Alon Bar-Lev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28486
to review the following change.
Change subject: utils: add isOvirtNode function.
..
utils: add isOvirtNode function.
Change-Id: I82207f674f9d1854f9f0804de611073a794c
Signed-off-by: Alon Bar-Lev alo...@redhat.com
---
M lib/vdsm/utils.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/28486/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 4e60acf..77fafda 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -1105,6 +1105,14 @@
sys.exit(-3)
+@memoized
+def isOvirtNode():
+return (
+os.path.exists('/etc/rhev-hypervisor-release') or
+glob.glob('/etc/ovirt-node-*-release')
+)
+
+
# Copied from
# http://docs.python.org/2.6/library/itertools.html?highlight=grouper#recipes
def grouper(iterable, n, fillvalue=None):
--
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82207f674f9d1854f9f0804de611073a794c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add block job info to VM stats
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add block job info to VM stats
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/26634/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 161: ('vm_sample_net_window', '2', None),
Line 162:
Line 163: ('vm_sample_jobs_interval', '15', None),
Line 164:
Line 165: ('vm_sample_jobs_window', '2', None),
Have you tried with 1? In theory this should be 1 but I don't know if it breaks
something in AdvancedStatsFunction.
Line 166:
Line 167: ('trust_store_path', '@TRUSTSTORE@',
Line 168: 'Where the certificates and keys are situated.'),
Line 169:
http://gerrit.ovirt.org/#/c/26634/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4853: ret = self._dom.blockJobInfo(dev['name'], 0)
Line 4854: if not ret:
Line 4855: self.log.debug(Block Job for vm:%s, img:%s has
ended,
Line 4856:self.conf['vmId'], dev['imageID'])
Line 4857: self._vm.setDiskBlockJob(dev, None)
I needed a little to understand this, maybe using clearDiskBlockJob is clearer.
Line 4858: continue
Line 4859:
Line 4860: jobID = job['jobID']
Line 4861: jobs[jobID] = {'id': jobID, 'jobType': 'block',
--
To view, visit http://gerrit.ovirt.org/26634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7278c0f06a2a06c8a8d680cf64746de3f73a389
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add isOvirtNode function.
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add isOvirtNode function. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9796/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9643/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1131/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82207f674f9d1854f9f0804de611073a794c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add isOvirtNode function.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add isOvirtNode function.
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/28486/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1105: sys.exit(-3)
Line 1106:
Line 1107:
Line 1108: @memoized
Line 1109: def isOvirtNode():
if you are going to use the new apis, I guess there should be more standard way
of obtaining the information by import one of the packages and calling
something. we should stop performing this check physically.
Line 1110: return (
Line : os.path.exists('/etc/rhev-hypervisor-release') or
Line 1112: glob.glob('/etc/ovirt-node-*-release')
Line 1113: )
--
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82207f674f9d1854f9f0804de611073a794c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9797/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8859/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: check if mount specification is a symlink
Nir Soffer has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 2: There is a corner case when your code will not do the right thing. It is quite unlikely to be used, but it still possible: if you mount /dev/./sda1 in /proc/mounts you'll have the normalized path instead, so /dev/sda1. self.fs_spec is already normlized in Mount.__init__ - so this code should work in this case. Should I rebase this patch match your change? Since the patch was not finished yet, and you don't need it for an older version, rebasing on master would make it easier to review and verify. -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Dan Kenigsberg has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/28482/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4476: try:
Line 4477: target = int(target)
Line 4478: self._dom.setMemory(target)
Line 4479: except ValueError:
Line 4480: return self._reportError(msg='an integer is required for
target', entity='balloon target')
please adhere to PEP8.
Line 4481: except libvirt.libvirtError as e:
Line 4482: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4483: return self._reportError(key='noVM', entity='balloon
target')
Line 4484: return self._reportError(msg=e.message,entity='balloon
target')
Line 4490: # persist the target value to make it consistent after
recovery
Line 4491: self.saveState()
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
Please add a docstring explaining what this function does and where it can be
called (only within an except cause!)
The default values for your args do not make sense. errCode['Err'] is
undefined. Why should we have these default values at all?
I'd drop the entity arg completely. I don't think it adds any information
that is not already available in the traceback.
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
please use self.log.exception() that does not need an explicity exc_info=True.
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4499: else:
Line 4500: error = {'status': {'code': errCode[key]
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 11: Code-Review+1 Why it take so much time to merge such trivial change? -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9798/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8860/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9645/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Yaniv Bronhaim has uploaded a new change for review. Change subject: pep8 and logic fix for commit 36136c1 .. pep8 and logic fix for commit 36136c1 1. Didn't catch in validation pep8 1.4.6 violation 2. Didn't catch wrong group validation on my environment Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/28488/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 027cf52..f149952 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -182,7 +182,7 @@ if SANLOCK_USER in g.gr_mem] gid = pwd.getpwnam(SANLOCK_USER).pw_gid groups.append(grp.getgrgid(gid).gr_name) -if all(group in self.SANLOCK_GROUPS for group in groups): +if all(group in groups for group in self.SANLOCK_GROUPS): configured = NOT_SURE if configured == NOT_SURE: @@ -194,10 +194,11 @@ proc_status_group_prefix = Groups:\t for status_line in sanlock_status: if status_line.startswith(proc_status_group_prefix): -groups = [int(x) for x in - status_line[ - len(proc_status_group_prefix):]. - strip().split( )] +groups = [ +int(x) for x in status_line[ +len( +proc_status_group_prefix +):].strip().split( )] break else: raise InvalidConfig( -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9799/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9646/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3783bf50d55c54ec38c3240f66b4a14296f244a8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
oVirt Jenkins CI Server has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9800/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9801/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9648/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make pyflakes-0.8 happier
Dan Kenigsberg has posted comments on this change. Change subject: Make pyflakes-0.8 happier .. Patch Set 1: Verified+1 Code-Review+2 Passes unit and functional tests; elevate pyflakes-0.8's pains. -- To view, visit http://gerrit.ovirt.org/28468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I507cb00a47279a6b119f280a1ac787c2071f681f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9802/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8864/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9649/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make pyflakes-0.8 happier
Dan Kenigsberg has submitted this change and it was merged. Change subject: Make pyflakes-0.8 happier .. Make pyflakes-0.8 happier Without this patch, pyflakes-0.8.1 complains about ./vdsm/network/sourceroute.py:153: list comprehension redefines 'rule' from line 146 I do not agree with this complaint of newer pyflakes versions, but I do not mind enough to fight it. Change-Id: I507cb00a47279a6b119f280a1ac787c2071f681f Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28468 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M vdsm/network/sourceroute.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I507cb00a47279a6b119f280a1ac787c2071f681f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make pyflakes-0.8 happier
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make pyflakes-0.8 happier .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1405/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I507cb00a47279a6b119f280a1ac787c2071f681f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 3: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9803/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8865/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9650/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1132/ : NOT_BUILT -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: adding gfs2 symlink test
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: adding gfs2 symlink test .. Patch Set 4: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9804/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8866/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9651/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/27514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f3d6333921505846f345d015907e5f6174af4f8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 3: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9805/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8867/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9652/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1133/ : NOT_BUILT -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: check if mount specification is a symlink
Nir Soffer has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 3: Code-Review+1 Thanks Enrico! -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 3: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9806/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8868/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9653/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1134/ : NOT_BUILT -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Check if mount specification is a symlink
Nir Soffer has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: This version cleans up the commit message and the comments (adding missing dot). This also will allow our CI to run the tests, since Enrico is not in our whitelist (yet?). -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9807/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8869/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9654/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1135/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9779/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9626/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1136/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/26123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Yaniv Bronhaim has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28488/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 196: if status_line.startswith(proc_status_group_prefix): Line 197: groups = [ Line 198: int(x) for x in status_line[ Line 199: len( Line 200: proc_status_group_prefix You do not need new line here. it passes pep8, in one line it doesn't Line 201: ):].strip().split( )] Line 202: break Line 203: else: Line 204: raise InvalidConfig( -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: move metadata dict creation to volume.py
Liron Ar has uploaded a new change for review.
Change subject: volume: move metadata dict creation to volume.py
..
volume: move metadata dict creation to volume.py
Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b
Signed-off-by: Liron Aravot lara...@redhat.com
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 16 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/28492/1
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 81331fa..d448e00 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -574,20 +574,12 @@
try:
meta = misc.readblock(lvm.lvPath(vgname, sd.METADATA),
offs * VOLUME_METASIZE, VOLUME_METASIZE)
-out = {}
-for l in meta:
-if l.startswith(EOF):
-return out
-if l.find(=) 0:
-continue
-key, value = l.split(=)
-out[key.strip()] = value.strip()
+return self.metadata2dict(meta)
except Exception as e:
self.log.error(e, exc_info=True)
raise se.VolumeMetadataReadError(%s: %s % (metaId, e))
-return out
def setMetadata(self, meta, metaId=None):
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 654818e..6b655b8 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -294,20 +294,11 @@
try:
f = self.oop.directReadLines(metaPath)
-out = {}
-for l in f:
-if l.startswith(EOF):
-return out
-if l.find(=) 0:
-continue
-key, value = l.split(=)
-out[key.strip()] = value.strip()
+return self.metadata2dict(f)
except Exception as e:
self.log.error(e, exc_info=True)
raise se.VolumeMetadataReadError(%s: %s % (metaId, e))
-
-return out
@classmethod
def __putMetadata(cls, metaId, meta):
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 3a5ed8e..aed932e 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -814,6 +814,20 @@
pass
+
+def metadata2dict(self, meta):
+out = {}
+for l in meta:
+if l.startswith(EOF):
+return out
+if l.find(=) 0:
+continue
+key, value = l.split(=)
+out[key.strip()] = value.strip()
+
+return out
+
+
def metadata2info(self, meta):
return {
uuid: self.volUUID,
--
To view, visit http://gerrit.ovirt.org/28492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar lara...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: support multi line metadata values
Liron Ar has uploaded a new change for review.
Change subject: volume: support multi line metadata values
..
volume: support multi line metadata values
Currently when creating the metadata dict it's assumed that each value
can be in a single line only while it's not necessarily true.
Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe
Signed-off-by: Liron Aravot lara...@redhat.com
---
M vdsm/storage/blockVolume.py
M vdsm/storage/volume.py
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/28493/1
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index d448e00..d7cf020 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -580,7 +580,6 @@
self.log.error(e, exc_info=True)
raise se.VolumeMetadataReadError(%s: %s % (metaId, e))
-
def setMetadata(self, meta, metaId=None):
Set the meta data hash as the new meta data of the Volume
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index aed932e..bfc1ff1 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -814,19 +814,27 @@
pass
-
def metadata2dict(self, meta):
out = {}
+key = None
+value = None
+
+def put(key, value):
+out[key.strip()] = \n.join(value).strip()
+
for l in meta:
if l.startswith(EOF):
-return out
+break
if l.find(=) 0:
+value.append(l)
continue
+if key:
+put(key, value)
key, value = l.split(=)
-out[key.strip()] = value.strip()
+value = [value]
+put(key, value)
return out
-
def metadata2info(self, meta):
return {
--
To view, visit http://gerrit.ovirt.org/28493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar lara...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9808/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9655/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/663/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8869/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9654/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1135/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9812/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Yaniv Bronhaim has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 1: -Code-Review ahhh i also brake the tests! damnit what's wrong with me -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Yaniv Bronhaim has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 1: Verified-1 -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9809/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/664/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: move metadata dict creation to volume.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: move metadata dict creation to volume.py .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9810/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8872/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9657/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1137/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: support multi line metadata values
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: support multi line metadata values .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9811/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1138/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify condition
Dan Kenigsberg has uploaded a new change for review. Change subject: net models: simplify condition .. net models: simplify condition Bond.objectivize() is always called with a non-None bonding name. No need to complicate an internal condition to validate this. Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/models.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/28496/1 diff --git a/vdsm/network/models.py b/vdsm/network/models.py index 7cc5fef..339ec38 100644 --- a/vdsm/network/models.py +++ b/vdsm/network/models.py @@ -233,7 +233,7 @@ @classmethod def objectivize(cls, name, configurator, options, nics, mtu, _netinfo, destroyOnMasterRemoval=None): -if name and nics: # New bonding or edit bonding. +if nics: # New bonding or edit bonding. slaves = cls._objectivizeSlaves(name, configurator, _nicSort(nics), mtu, _netinfo) if name in _netinfo.bondings: -- To view, visit http://gerrit.ovirt.org/28496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
Dan Kenigsberg has uploaded a new change for review.
Change subject: net models: simplify error condition
..
net models: simplify error condition
An attempt to add a bonding device with no nics ends with a different
error, depending whether the bond is already define in the kernel or
not. This surprising behaviour means that the functional test
testFailWithBadParam fails if BONDING_NAME is removed from the kernel.
This patch unifies the error code, returning ERR_BAD_PARAMS in both
cases.
Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/network/models.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/28497/1
diff --git a/vdsm/network/models.py b/vdsm/network/models.py
index 339ec38..015cefb 100644
--- a/vdsm/network/models.py
+++ b/vdsm/network/models.py
@@ -251,9 +251,8 @@
for nic in _netinfo.getNicsForBonding(name)]
options = _netinfo.bondings[name]['cfg'].get('BONDING_OPTS')
else:
-raise ConfigNetworkError(ne.ERR_BAD_BONDING,
- 'Bonding %s not specified and it is not '
- 'already on the system' % name)
+slaves = []
+
if not slaves:
raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Missing required nics'
' for bonding device.')
--
To view, visit http://gerrit.ovirt.org/28497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9626/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1136/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9815/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
Nir Soffer has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 3: Code-Review-1 Please fix pep8 violations: lib/vdsm/tool/configurator.py:226:17: E128 continuation line under-indented for visual indent lib/vdsm/tool/configurator.py:243:5: E303 too many blank lines (2) -- To view, visit http://gerrit.ovirt.org/26123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: move metadata dict creation to volume.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: move metadata dict creation to volume.py .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9659/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9813/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: support multi line metadata values
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: support multi line metadata values .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8875/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9660/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9814/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Check if mount specification is a symlink
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9812/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9654/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1135/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8876/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Enrico Tagliavini enrico.tagliav...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8877/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1446/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9816/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/28482/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4476: try:
Line 4477: target = int(target)
Line 4478: self._dom.setMemory(target)
Line 4479: except ValueError:
Line 4480: return self._reportError(msg='an integer is required for
target', entity='balloon target')
please adhere to PEP8.
sure thing :)
Line 4481: except libvirt.libvirtError as e:
Line 4482: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4483: return self._reportError(key='noVM', entity='balloon
target')
Line 4484: return self._reportError(msg=e.message,entity='balloon
target')
Line 4490: # persist the target value to make it consistent after
recovery
Line 4491: self.saveState()
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
Please add a docstring explaining what this function does and where it can
My thoughts are that this should be done on a different patch, and does not
relate directly to the feature
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
please use self.log.exception() that does not need an explicity exc_info=Tr
same here.
I'll be happy to do it once my duties are done.
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4499: else:
Line 4500: error = {'status': {'code': errCode[key]
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify condition .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8878/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1448/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9818/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie79511ddc2b9890e832175b046c1f32f609580ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Yaniv Bronhaim has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net models: simplify error condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8879/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1447/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9817/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ba2dcecbfa40f9268e8c3da0562f491a32c3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8880/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9819/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8881/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1449/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9820/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8882/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9821/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: move metadata dict creation to volume.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: move metadata dict creation to volume.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8883/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9822/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26c495d437fe327a4029fe1dae087d182ba6611b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: support multi line metadata values
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: support multi line metadata values .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8884/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9668/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1142/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9823/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 37: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8885/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9669/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/666/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9824/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Dan Kenigsberg has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 3: Code-Review+2 Rushing this fix it, hopefully fixing all the cited issues. -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8 and logic fix for commit 36136c1 .. pep8 and logic fix for commit 36136c1 1. Didn't catch in validation pep8 1.4.6 violation 2. Didn't catch wrong group validation on my environment 3. Fix isconfigured tests Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28488 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 16 insertions(+), 11 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8886/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9670/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9825/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 and logic fix for commit 36136c1
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8 and logic fix for commit 36136c1 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1406/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f08ca619415275fb15a1ebd63e5f25e97a0753 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28482/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4490: # persist the target value to make it consistent after
recovery
Line 4491: self.saveState()
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
My thoughts are that this should be done on a different patch, and does not
done, part from the 'Err', I have no idea what was the poet intentions, prefer
not to change this at this point.
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4492: return {'status': doneCode}
Line 4493:
Line 4494: def _reportError(self, key='Err', msg=None, entity=None):
Line 4495: if entity is not None:
Line 4496: self.log.error(Set new + entity + failed,
exc_info=True)
same here.
Done
Line 4497: if msg is None:
Line 4498: error = errCode[key]
Line 4499: else:
Line 4500: error = {'status': {'code': errCode[key]
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Kobi Ianko k...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26768/4/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 199: Line 200: # Check for a stale parent UUID in the volume tags and correct it. Line 201: # This happens after a live merge finishes since we cannot update LV Line 202: # tags as HSM. Line 203: children = self.getChildren() getChildren() and BlockVolume() production are going to to take place for e deleteImage is implemented differently (it's not relying on calling volume.delete on each volume). Line 204: if children: Line 205: child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID, Line 206: children[0]) Line 207: metaParent = child.getMetaParam(volume.PUUID) Line 202: # tags as HSM. Line 203: children = self.getChildren() Line 204: if children: Line 205: child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID, Line 206: children[0]) possibly-silly question: are we sure there is no snapshot (a second child) yes, here we need to loop on all the children. Line 207: metaParent = child.getMetaParam(volume.PUUID) Line 208: tagParent = child.getParent() Line 209: if metaParent != tagParent: Line 210: self.log.debug(Updating stale PUUID LV tag from %s to %s for -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
mooli tayer has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 24: (3 comments) http://gerrit.ovirt.org/#/c/27298/24/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 42: P_VDSM Line 43: from vdsm.config import config Line 44: Line 45: if utils.isOvirtNode(): Line 46: from ovirt.node.utils.fs import Config as NodeCfg node Line 47: Line 48: Line 49: class InvalidConfig(UsageError): Line 50: raise when invalid configuration passed Line 204: if os.path.isfile(TARGET): Line 205: oldmod = os.stat(TARGET).st_mode Line 206: Line 207: if utils.isOvirtNode(): Line 208: NodeCfg().unpersist(TARGET) node Line 209: shutil.copyfile(packaged, TARGET) Line 210: if utils.isOvirtNode(): Line 211: NodeCfg().persist(TARGET) Line 212: Line 309: Line 310: delete a file if it exists. Line 311: Line 312: utils.rmFile(content['path']) Line 313: if utils.isOvirtNode(): node Line 314: NodeCfg().unpersist(content['path']) Line 315: Line 316: def _unprefixAndRemoveSection(self, path): Line 317: -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Itamar Heim has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 8: ping -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move all guest agents related cleanup together
Itamar Heim has posted comments on this change. Change subject: virt: Move all guest agents related cleanup together .. Patch Set 5: ping -- To view, visit http://gerrit.ovirt.org/26280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99da4b5b9dcb160974205ebbb3c6d6727415e617 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: add reduceStorageDomain command
Itamar Heim has posted comments on this change. Change subject: block: add reduceStorageDomain command .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/26574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I467fc12d3787929b9c0e35f8806402f72f493368 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
Itamar Heim has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactoring reportError func
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8887/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9826/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
Francesco Romani has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 3: rebased -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Log unhandled exception for new Thread
Itamar Heim has posted comments on this change. Change subject: ifcfg: Log unhandled exception for new Thread .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/23085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce44b4586e85438898fcdcd2d62d80813caa5ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volumeTests: add BlockDomainMetadataSlotTest
Itamar Heim has posted comments on this change. Change subject: volumeTests: add BlockDomainMetadataSlotTest .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/26266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ff018625443ce7cf75d3edf11644544e7f23dde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Itamar Heim has posted comments on this change. Change subject: block: use the contextmanager for getVolumeMetadataSlot .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/25988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 38: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el// : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/668/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9827/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
