Change in vdsm[master]: xmlrpc: Disable unwanted BaseHTTPServer logging
Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: Disable unwanted BaseHTTPServer logging .. xmlrpc: Disable unwanted BaseHTTPServer logging BaseHTTPServer log incoming requests to stderr, which is redirected to /dev/null in production. During the tests, stderr is used to display test results. In both cases, the default http logging is useless, and we have our own logging. Change-Id: I83ad9723854a4646cc2a5cf23e1a335a82d4f94f Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28772 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/rpc/BindingXMLRPC.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ad9723854a4646cc2a5cf23e1a335a82d4f94f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable unwanted BaseHTTPServer logging
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Disable unwanted BaseHTTPServer logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ad9723854a4646cc2a5cf23e1a335a82d4f94f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix FakeClientIF interface
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix FakeClientIF interface .. tests: Fix FakeClientIF interface clientIF was missing the ready property, which caused random failures on jenkinks: AttributeError: FakeClientIf instance has no attribute 'ready' Change-Id: I3b26f5c9373e92a7de3bbbc2f4ed682dce70b92d Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28771 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/jsonRpcHelper.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b26f5c9373e92a7de3bbbc2f4ed682dce70b92d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix FakeClientIF interface
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix FakeClientIF interface .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b26f5c9373e92a7de3bbbc2f4ed682dce70b92d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable unwanted BaseHTTPServer logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Disable unwanted BaseHTTPServer logging .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1449/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ad9723854a4646cc2a5cf23e1a335a82d4f94f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix FakeClientIF interface
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix FakeClientIF interface .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1450/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b26f5c9373e92a7de3bbbc2f4ed682dce70b92d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify why scsiKey parameter is not passed on
Allon Mureinik has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG Commit Message: Line 6: Line 7: clarify why scsiKey parameter is not passed on Line 8: Line 9: In this patch I add comments to make plain that the scsiKey parameter is Line 10: a legacy from older code. This will hopefully save time for the next guy I suggest to use the word person instead of guy :-) +1 on using gender neutral terms. person is definitely better than guy, but how about using the more meaningful developer Line 11: who goes on this wild goose chase through the code. Line 12: Line 13: Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Correct and faster list2cmdline
Federico Simoncelli has posted comments on this change. Change subject: utils: Correct and faster list2cmdline .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27548/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 731: Line 732: if not printable: Line 733: printable = command Line 734: Line 735: execCmdLogger.debug(%s (cwd %s), _list2cmdline(printable), cwd) Ok, I',ll handle this in a following patch - this is a general issue and we Yes it seems something that belongs to another patch. Line 736: Line 737: p = CPopen(command, close_fds=True, cwd=cwd, env=env, Line 738:deathSignal=deathSignal, childUmask=childUmask) Line 739: if not sync: -- To view, visit http://gerrit.ovirt.org/27548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Antoni Segura Puimedon has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 7: Code-Review+1 I've concentrated mostly in the ctypes interface and it looks good. -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28700/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 820: else: Line 821: continue Line 822: info.update(_devinfo(dev, ipaddrs)) Line 823: if dev.isBOND(): Line 824: _bondOptsForIfcfg(info) Here you are passing the info dictionary of all devices and in _bondOptsForIfcfg it expects the info dictionary of a single device. In any case, I really preferred the previous version of the patch. I feel that this bonOptsIfcfg addendum does not belong to the same patch. Line 825: Line 826: _cfgBootprotoCompat(d) Line 827: Line 828: return d -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve the logging when destroying domains
Francesco Romani has posted comments on this change. Change subject: vm: improve the logging when destroying domains .. Patch Set 3: rebased. -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: narrow down try/except block in releaseVm
Francesco Romani has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm .. Patch Set 4: narrowed down the try/except block even more. -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: narrow down try/except block in releaseVm
Francesco Romani has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28024/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4569: Failed to destroy VM '%s' gracefully, Line 4570: self.conf['vmId'], exc_info=True) Line 4571: if (e.get_error_code() == Line 4572:libvirt.VIR_ERR_OPERATION_FAILED): Line 4573: self._dom.destroy() This is the only thing that can raise libvirtError. So please narrow the tr Done Line 4574: except libvirt.libvirtError as e: Line 4575: self.log.warning(Failed to destroy VM '%s', Line 4576: self.conf['vmId'], exc_info=True) Line 4577: -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: abort and report error if domain destroy fails
Francesco Romani has posted comments on this change. Change subject: vm: abort and report error if domain destroy fails .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: extract the vm destroy in a method
Francesco Romani has posted comments on this change. Change subject: vm: extract the vm destroy in a method .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91de9dc310cd563396e0f646533ba986bcb7e35e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: mutipath: Remove unneeded and dangerous -r parameter
Yaniv Bronhaim has submitted this change and it was merged. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. mutipath: Remove unneeded and dangerous -r parameter Since commit dbf2089488 (Jul 9 2013) multipath call was change to use the -r flag, forcing a reload of the device map. This was tested to fix a case where new lun is created on the storage server, while a host was connected, and the new device is not available when issuing the getDeviceList command. According to a comment on gerrit, the change was tested for ISCSI and FC storage types, but there is no documentation of the testing procedure. The related bug was verified, but has no information about how it was verified. We have two related bugs: - Bug 1078879 tell us that invoking multipath with the -r flag sometimes triggers a segfault in the multipathd daemon. In the bug, multipath developer suggests that as long as multipathd daemon is running, there is no need to invoke multipath to detect new devices, and multipath -r really isn't useful for much of anything. - Bug 1071654 tell us that devices rescanning is broken on FC storage domains (although the -r flag is used). I reproduced this bug using storage QE FC server. This patch removes the -r flag. To be on the safe side, I left the multipath call as it was since the first multipath commit in 2009. We will work with kernel and multipath developers further on removing this call if it is indeed unneeded. Bug-Url: https://bugzilla.redhat.com/1108553 Relates-to: https://bugzilla.redhat.com/1071654 Relates-to: http://gerrit.ovirt.org/17263 Change-Id: I880ab5343df3e0030638901e188320b20570747d Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27242 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28668 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/multipath.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, approved Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880ab5343df3e0030638901e188320b20570747d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pthreading: Monkeypatch threading module first
Yaniv Bronhaim has posted comments on this change. Change subject: pthreading: Monkeypatch threading module first .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d327d0fd7c78edef62ecd43999651a475fee4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: mutipath: Remove unneeded and dangerous -r parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: mutipath: Remove unneeded and dangerous -r parameter .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/230/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I880ab5343df3e0030638901e188320b20570747d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: extract the vm destroy in a method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: extract the vm destroy in a method .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9292/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5158/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3316/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91de9dc310cd563396e0f646533ba986bcb7e35e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 20:
(3 comments)
http://gerrit.ovirt.org/#/c/25978/20/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 62: self._tunneled = utils.tobool(tunneled)
Line 63: self._abortOnError = utils.tobool(abortOnError)
Line 64: self._dstqemu = dstqemu
Line 65: self._downtime = int(kwargs.get('downtime') or
Line 66: config.get('vars', 'migration_downtime'))
Is this related? Because eventually this may be better:
Not stricly related, will split in a (trivial) patch.
I like the current code slightly more because, as you pointed out, the
short-circuit behaviour of the 'or' operator.
Line 67: self.status = {
Line 68: 'status': {
Line 69: 'code': 0,
Line 70: 'message': 'Migration in progress'},
Line 298:'with miguri %s', duri, muri)
Line 299:
Line 300: with migrationMonitor(self._vm,
Line 301: startTime,
Line 302: self._downtime) as
self._monitorThread:
Setting self._monitorThread in the as part is surprising, while the old c
I agree your version is better in every way. Will change accordingly.
Line 303: if self._vm.hasSpice and
self._vm.conf.get('clientIp'):
Line 304: SPICE_MIGRATION_HANDOVER_TIME = 120
Line 305:
self._vm._reviveTicket(SPICE_MIGRATION_HANDOVER_TIME)
Line 306:
Line 340: monitorThread.start()
Line 341: try:
Line 342: yield monitorThread
Line 343: finally:
Line 344: monitorThread.stop()
This can be much more useful as general utility for things that you can sta
Right. Will change.
Line 345:
Line 346:
Line 347: class MonitorThread(threading.Thread):
Line 348: _MONITOR_TICK = 1.0 # unit: seconds
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify why scsiKey parameter is not passed on
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG Commit Message: Line 6: Line 7: clarify why scsiKey parameter is not passed on Line 8: Line 9: In this patch I add comments to make plain that the scsiKey parameter is Line 10: a legacy from older code. This will hopefully save time for the next guy I suggest to use the word person instead of guy :-) Done Line 11: who goes on this wild goose chase through the code. Line 12: Line 13: Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Line 6: Line 7: clarify why scsiKey parameter is not passed on Line 8: Line 9: In this patch I add comments to make plain that the scsiKey parameter is Line 10: a legacy from older code. This will hopefully save time for the next guy +1 on using gender neutral terms. Done Line 11: who goes on this wild goose chase through the code. Line 12: Line 13: Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: narrow down try/except block in releaseVm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10234/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5160/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3318/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify why scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 2: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9296/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10080/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1291/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 19: rebased -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve the logging when destroying domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: improve the logging when destroying domains .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/864/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5161/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3319/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 20: rebased -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify why scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 3: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9297/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10081/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10237/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1292/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 10: rebased -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Francesco Romani has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 21: addressed comments from Federico and Nir. -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Francesco Romani has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Antoni Segura Puimedon has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9298/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/865/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10238/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3322/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: abort and report error if domain destroy fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: abort and report error if domain destroy fails .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9293/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10233/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5159/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3317/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9299/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/866/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3323/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/867/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10240/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3324/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
Xavi Francisco has posted comments on this change. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. Patch Set 3: Verified+1 To verify: 1. Pick a NFS storage domain 2. (Optional) Backup the metadata file 3. Clear the contents of the metadata file 4. Empty metadata message will appear in logs -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/28244/9/vdsm_reg/vdsm-upgrade
File vdsm_reg/vdsm-upgrade:
Line 16: from xml.sax import saxutils
Line 17:
Line 18:
Line 19: def _format_msg(msg_line):
Line 20: _XML_QUOTES = {': '~'}
is _XML_QUOTES really necessary?
Line 21:
Line 22: msg = BSTRAP component='ovirt-node-upgrade' \
Line 23: status='OK' message=%s/ % \
Line 24: saxutils.quoteattr(msg_line, _XML_QUOTES)
--
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9301/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3325/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9302/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10086/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/869/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10242/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5168/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3326/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10087/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10243/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3327/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Francesco Romani has uploaded a new change for review. Change subject: vm: fix guest agent stats field .. vm: fix guest agent stats field In commit 068fc28d I mistakenly removed an explicit int() conversion because I overlooked the code, and thought the result was going to be an int() anyway. I was wrong, and the result is a float, which breaks the schema which dictates the affected field to be an uint. This patch restores the explicit conversion to make the code compliant with the schema again. Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Signed-off-by: Francesco Romani from...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/28781/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 4b00c51..d66458d 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2811,7 +2811,7 @@ int(self.conf['memSize']) * 100) else: memUsage = 0 -stats['memUsage'] = utils.convertToStr(memUsage) +stats['memUsage'] = utils.convertToStr(int(memUsage)) return stats def isMigrating(self): -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Vinzenz Feenstra has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Martin Sivák has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Kobi Ianko has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
mooli tayer has uploaded a new change for review. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. configurator.py: fix _removeFile to do as described in its doc string. Prevent warning on non existent files. Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Signed-off-by: Mooli Tayer mta...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/28782/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index c8373fb..cc79506 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -318,9 +318,10 @@ delete a file if it exists. -utils.rmFile(content['path']) -if utils.isOvirtNode(): -NodeCfg().unpersist(content['path']) +if os.path.exists(content['path']): +utils.rmFile(content['path']) +if utils.isOvirtNode(): +NodeCfg().unpersist(content['path']) def _unprefixAndRemoveSection(self, path): -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28782/1//COMMIT_MSG Commit Message: Line 6: Line 7: configurator.py: fix _removeFile to do as described in its doc string. Line 8: Line 9: Prevent warning on non existent files. Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109569 Line 11: Change-Id: I0436832ae63891c097038ef2b76606c30c40328a -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28782/1//COMMIT_MSG Commit Message: Line 7: configurator.py: fix _removeFile to do as described in its doc string. Line 8: Line 9: Prevent warning on non existent files. Line 10: Line 11: Change-Id: I0436832ae63891c097038ef2b76606c30c40328a bug url here.. -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9304/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10088/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3328/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28782/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-06-16 12:15:55 +0300 Line 4: Commit: Mooli Tayer mta...@redhat.com Line 5: CommitDate: 2014-06-16 12:15:55 +0300 Line 6: Line 7: configurator.py: fix _removeFile to do as described in its doc string. it's Line 8: Line 9: Prevent warning on non existent files. Line 10: Line 11: Change-Id: I0436832ae63891c097038ef2b76606c30c40328a -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3329/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Francesco Romani has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Verified+1 Verified: unpatched VDSM the field is reported with the decimal part; on a patched VDSM the field is an integer. -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently
Xavi Francisco has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Bala.FA has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: report clusterLevel 3.5
Dan Kenigsberg has uploaded a new change for review. Change subject: report clusterLevel 3.5 .. report clusterLevel 3.5 Change-Id: I230ec3c309b70fa641cdac3eb18aa7c533e4f3f7 Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/28793/1 diff --git a/vdsm/dsaversion.py.in b/vdsm/dsaversion.py.in index 269798a..b2442f2 100644 --- a/vdsm/dsaversion.py.in +++ b/vdsm/dsaversion.py.in @@ -1,5 +1,5 @@ # -# Copyright 2007-2011 Red Hat, Inc. +# Copyright 2007-2014 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -33,7 +33,7 @@ 'version_name': version_name, 'software_version': software_version, 'software_revision': software_revision, -'supportedENGINEs': ['3.0', '3.1', '3.2', '3.3', '3.4'], +'supportedENGINEs': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], 'supportedProtocols': ['2.2', '2.3'], -'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4'], +'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], } -- To view, visit http://gerrit.ovirt.org/28793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I230ec3c309b70fa641cdac3eb18aa7c533e4f3f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Get size information of a gluster volume.
..
gluster: Get size information of a gluster volume.
New vdsm gluster verb to get free, used and total size of
gluster volume. This verb uses libgfapi to get the statistics
related to volume. This patch makes use of ctypes to utilize
the libgfapi. This patch also enhances glusterVolumeStatus
verb to return volume size info as well when status option
is set to detail.
verb: glusterVolumeStatsInfoGet
Output format:
{sizeTotal: LONG as STR, sizeFree: LONG as STR, sizeUsed: LONG as STR}
Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857
Signed-off-by: darshan n dnara...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/28581
Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com
Reviewed-by: Bala.FA barum...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M client/vdsClientGluster.py
M vdsm.spec.in
M vdsm/gluster/Makefile.am
M vdsm/gluster/__init__.py
M vdsm/gluster/api.py
M vdsm/gluster/exception.py
A vdsm/gluster/gfapi.py
M vdsm/gluster/vdsmapi-gluster-schema.json
8 files changed, 221 insertions(+), 1 deletion(-)
Approvals:
Bala.FA: Looks good to me, but someone else must approve
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Darshan N: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 7: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Correct and faster list2cmdline
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Correct and faster list2cmdline .. utils: Correct and faster list2cmdline subprocess.list2cmdline dominates the profile on idle vdsm with many storage domains, using more than 10% of cpu time. We use this function to format commands in the log, so it is possible to copy the command to the shell and run for debugging. Turns out that this is undocumented function used on Windows to convert argument list to string compatible with the MS C runtime. Using repr(), it works on Linux for simple commands, but does not get quoting right with complex commands. This patch replaces the function with a correct, simple and efficient implementation compatible with Linux shells. The new function should not be used with repr(), which render its output useless. I tested this patch on Fedora 19 machine connected to 30 storage domains, running 10 minutes profiling session as spm. Without this patch subprocess.list2cmdline() is the most expensive function responsible for 12.5% of cpu time: Thu Jun 5 23:15:18 2014vdsmd.prof 2139104 function calls (2202966 primitive calls) in 16.652 seconds Ordered by: internal time List reduced from 1785 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 21511.8160.0012.1400.001 subprocess.py:579(list2cmdline) 97/1281.4070.015 11.0040.086 threading.py:753(Thread.run) 102210.4940.0001.0280.000 __init__.py:242(LogRecord.__init__) 53970.4780.0001.5750.000 misc.py:125(findCaller) 85080.4220.0000.6410.000 spark.py:211(Parser.buildState) 503360.4040.0000.4630.000 genericpath.py:85(_splitext) 32657/326640.2730.0000.8150.000 misc.py:110(_shouldLogSkip) 500950.2710.0000.2710.000 pthread.py:95(Lock.lock) 21470.2660.0000.5170.000 subprocess.py:1406(CPopen._communicate_with_poll) 50331/503360.2380.0000.7080.000 posixpath.py:104(splitext) With this patch, utils._list2cmdline() uses only fraction of the cpu time: 21580.0850.0000.1180.000 utils.py:652(_list2cmdline) Note: the profile was performed with older version of this patch, the current version is simpler more efficient. Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27548 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/utils.py M tests/utilsTests.py 2 files changed, 59 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
Dan Kenigsberg has submitted this change and it was merged. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. persistentDict: Do not warn about missing checksum when metadata is empty When parsing the storage metadata, when none is present, accept the metadata as valid and log that there's no metadata. In this case do not log a warning informing no checksum is found as there is no metadata. Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Bug-Url: https://bugzilla.redhat.com/1073989 Signed-off-by: Xavi Francisco xfran...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27528 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/persistentDict.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Xavi Francisco: Verified Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
Dan Kenigsberg has submitted this change and it was merged. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. persistentDict: Do not warn about missing checksum when metadata is empty When parsing the storage metadata, when none is present, accept the metadata as valid and log that there's no metadata. In this case do not log a warning informing no checksum is found as there is no metadata. Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Bug-Url: https://bugzilla.redhat.com/1073989 Signed-off-by: Xavi Francisco xfran...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27528 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/persistentDict.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Xavi Francisco: Verified Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Get size information of a gluster volume. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1451/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5d622738ae955eb4002f56fc73adb4f07f0b857 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: report clusterLevel 3.5
oVirt Jenkins CI Server has posted comments on this change. Change subject: report clusterLevel 3.5 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9306/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10090/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10246/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3330/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230ec3c309b70fa641cdac3eb18aa7c533e4f3f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Correct and faster list2cmdline
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Correct and faster list2cmdline .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1452/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume.
Darshan N has abandoned this change. Change subject: gluster: Get size information of a gluster volume. .. Abandoned in some other patch -- To view, visit http://gerrit.ovirt.org/26343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib628b10c3b9743bb9fef5cbf41195e69ff851efd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persistentDict: Do not warn about missing checksum when meta...
oVirt Jenkins CI Server has posted comments on this change. Change subject: persistentDict: Do not warn about missing checksum when metadata is empty .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1453/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6627fef453a62603d93bfb8aee66ebedcbbf190 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: narrow down try/except block in releaseVm
Dan Kenigsberg has posted comments on this change. Change subject: vm: narrow down try/except block in releaseVm .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28024/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4570: if (e.get_error_code() == Line 4571:libvirt.VIR_ERR_OPERATION_FAILED): Line 4572: try: Line 4573: self._dom.destroy() Line 4574: except libvirt.libvirtError as e: this makes it clear that we have a serious bug! if we swallow this error here, we report that destroy succeeded, but the VM may be lurking below, munching its disk. I think we'd better drop this try block, as well as re-raise the error in case it was not VIR_ERR_OPERATION_FAILED. Line 4575: self.log.warning(Failed to destroy VM '%s', Line 4576: self.conf['vmId'], exc_info=True) Line 4577: Line 4578: if not self.cif.mom: -- To view, visit http://gerrit.ovirt.org/28024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_detection: reuse address so that VDSM doesn't have ...
Yeela Kaplan has posted comments on this change. Change subject: protocol_detection: reuse address so that VDSM doesn't have to wait after a crash .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10149c619ce7441a1b9eb62bc6806ec997c579c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Francesco Romani has uploaded a new change for review.
Change subject: tests: type checking for primitive types
..
tests: type checking for primitive types
This patch adds type checking for the return types of the API.
Only primitive types (bool, *int, float, str) are supported;
full type checking, including enum values and types defined
in the schema, will be implemented in future patches.
This will help avoiding future mistakes like the one fixed in
http://gerrit.ovirt.org/#/c/28781/1
Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/vmApiTests.py
1 file changed, 54 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/28802/1
diff --git a/tests/vmApiTests.py b/tests/vmApiTests.py
index a616d45..4c84d59 100644
--- a/tests/vmApiTests.py
+++ b/tests/vmApiTests.py
@@ -40,6 +40,36 @@
vm._vmStats.stop()
+def isBool(value):
+return value in ('true', 'false')
+
+
+def isInt(value):
+try:
+return str(int(value)) == value
+except ValueError:
+return False
+
+
+def isFloat(value):
+try:
+float(value)
+return True
+except ValueError:
+return False
+
+
+def isStr(value):
+return isinstance(value, str)
+
+
+PRIMITIVE_TYPES = {
+'bool': isBool,
+'int': isInt, 'uint': isInt,
+'float': isFloat,
+'str': isStr}
+
+
class TestVmStats(TestCaseBase):
@utils.memoized
def _getAPI(self):
@@ -50,16 +80,36 @@
return vdsmapi.get_api(apiPath)
def assertVmStatsSchemaCompliancy(self, schema, stats):
+def isOptional(apiItem):
+return apiItem[0] == '*'
+
+def getApiItemName(apiItem):
+return apiItem[1:] if isOptional(apiItem) else apiItem
+
+def assertTypeCompliancy(stats, apiName, apiType):
+if apiName in ('displayPort', 'displaySecurePort',
+ 'guestCPUCount'):
+# known exceptions. FIXME: fix these.
+return
+if isinstance(apiType, str) and apiType in PRIMITIVE_TYPES:
+self.assertTrue(
+PRIMITIVE_TYPES[apiType](stats[apiName]),
+%s (%s) is not %s % (
+apiName, str(stats[apiName]), apiType))
+# TODO: more type checking
+
api = self._getAPI()
ref = api['types'][schema]['data']
for apiItem, apiType in ref.items():
-if apiItem[0] == '*':
+apiName = getApiItemName(apiItem)
+if isOptional(apiItem):
# optional, may be absent and it is fine
-self.assertTrue(stats.get(apiItem[1:], True))
+if apiName in stats:
+assertTypeCompliancy(stats, apiName, apiType)
else:
# mandatory
-self.assertIn(apiItem, stats)
-# TODO: type checking
+self.assertIn(apiName, stats)
+assertTypeCompliancy(stats, apiName, apiType)
def testDownStats(self):
with FakeVM() as fake:
--
To view, visit http://gerrit.ovirt.org/28802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_detection: reuse address so that VDSM doesn't have ...
Dan Kenigsberg has posted comments on this change. Change subject: protocol_detection: reuse address so that VDSM doesn't have to wait after a crash .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10149c619ce7441a1b9eb62bc6806ec997c579c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_detection: reuse address so that VDSM doesn't have ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: protocol_detection: reuse address so that VDSM doesn't have to wait after a crash .. protocol_detection: reuse address so that VDSM doesn't have to wait after a crash Change-Id: Ic10149c619ce7441a1b9eb62bc6806ec997c579c Signed-off-by: Saggi Mizrahi smizr...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28740 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Tested-by: Yeela Kaplan ykap...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/protocoldetector.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yeela Kaplan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic10149c619ce7441a1b9eb62bc6806ec997c579c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix FakeGuestAgent field
Francesco Romani has uploaded a new change for review. Change subject: tests: fix FakeGuestAgent field .. tests: fix FakeGuestAgent field fix guestIPs, which is supposed to be A space separated string of assigned IPv4 addresses and not a list. Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Signed-off-by: Francesco Romani from...@redhat.com --- M tests/vmTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/28801/1 diff --git a/tests/vmTests.py b/tests/vmTests.py index 483a270..b48aa84 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -836,7 +836,7 @@ 'session': 'Unknown', 'memUsage': 0, 'appsList': [], -'guestIPs': [], +'guestIPs': '', 'guestFQDN': '', 'disksUsage': [], 'netIfaces': [], -- To view, visit http://gerrit.ovirt.org/28801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split API schema conformancy tests
Francesco Romani has uploaded a new change for review.
Change subject: tests: split API schema conformancy tests
..
tests: split API schema conformancy tests
this patch splits the VM API schema tests from the main unit tests body
with no functional changes.
Change-Id: I38d1d68ee1a556a9a1f484f436217a463c8705aa
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/Makefile.am
A tests/vmApiTests.py
M tests/vmTests.py
3 files changed, 81 insertions(+), 51 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/28800/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 0d696e9..156e1da 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -74,6 +74,7 @@
transportWrapperTests.py \
utilsTests.py \
vdsClientTests.py \
+ vmApiTests.py \
vmTestsData.py \
vmTests.py \
volumeTests.py \
diff --git a/tests/vmApiTests.py b/tests/vmApiTests.py
new file mode 100644
index 000..a616d45
--- /dev/null
+++ b/tests/vmApiTests.py
@@ -0,0 +1,80 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from contextlib import contextmanager
+import os
+import os.path
+
+from virt import vmexitreason
+from vdsm import define
+from testrunner import VdsmTestCase as TestCaseBase
+from vdsm import utils
+from rpc import vdsmapi
+
+from vmTests import FakeVM
+
+
+@contextmanager
+def ensureVmStats(vm):
+vm._initVmStats()
+try:
+yield vm
+finally:
+vm._vmStats.stop()
+
+
+class TestVmStats(TestCaseBase):
+@utils.memoized
+def _getAPI(self):
+testPath = os.path.realpath(__file__)
+dirName = os.path.split(testPath)[0]
+apiPath = os.path.join(
+dirName, '..', 'vdsm', 'rpc', 'vdsmapi-schema.json')
+return vdsmapi.get_api(apiPath)
+
+def assertVmStatsSchemaCompliancy(self, schema, stats):
+api = self._getAPI()
+ref = api['types'][schema]['data']
+for apiItem, apiType in ref.items():
+if apiItem[0] == '*':
+# optional, may be absent and it is fine
+self.assertTrue(stats.get(apiItem[1:], True))
+else:
+# mandatory
+self.assertIn(apiItem, stats)
+# TODO: type checking
+
+def testDownStats(self):
+with FakeVM() as fake:
+fake.setDownStatus(define.ERROR, vmexitreason.GENERIC_ERROR)
+self.assertVmStatsSchemaCompliancy('ExitedVmStats',
+ fake.getStats())
+
+def testRunningStats(self):
+vmParams = {
+'displayPort': -1, 'displaySecurePort': -1, 'display': 'qxl',
+'displayIp': '127.0.0.1', 'vmType': 'kvm', 'devices': {},
+'memSize': 1024,
+# HACKs
+'pauseCode': 'NOERR'}
+with FakeVM(vmParams) as fake:
+with ensureVmStats(fake):
+self.assertVmStatsSchemaCompliancy('RunningVmStats',
+ fake.getStats())
diff --git a/tests/vmTests.py b/tests/vmTests.py
index b142661..483a270 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -21,7 +21,6 @@
from contextlib import contextmanager
from itertools import product
-import os.path
import re
import shutil
import tempfile
@@ -38,7 +37,6 @@
import caps
from vdsm import utils
from vdsm import libvirtconnection
-from rpc import vdsmapi
from monkeypatch import MonkeyPatch, MonkeyPatchScope
from vmTestsData import CONF_TO_DOMXML_X86_64
from vmTestsData import CONF_TO_DOMXML_PPC64
@@ -1081,55 +1079,6 @@
libvirt.VIR_DOMAIN_EVENT_IO_ERROR_NONE)
self.assertTrue(fake._guestCpuRunning)
self.assertNotIn('pauseCode', fake.conf) # no error recorded
-
-
-@contextmanager
-def ensureVmStats(vm):
-vm._initVmStats()
-try:
-yield vm
-finally:
-vm._vmStats.stop()
-
-
-class TestVmStats(TestCaseBase):
-@utils.memoized
-def _getAPI(self):
-testPath = os.path.realpath(__file__)
-dirName = os.path.split(testPath)[0]
-apiPath = os.path.join(
-
Change in vdsm[master]: protocol_detection: reuse address so that VDSM doesn't have ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocol_detection: reuse address so that VDSM doesn't have to wait after a crash .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1454/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10149c619ce7441a1b9eb62bc6806ec997c579c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split API schema conformancy tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: split API schema conformancy tests .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9307/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10091/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10247/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5173/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3331/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38d1d68ee1a556a9a1f484f436217a463c8705aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: split API schema conformancy tests
Francesco Romani has posted comments on this change. Change subject: tests: split API schema conformancy tests .. Patch Set 1: Verified+1 Verified by running the tests and building the packages (make rpm) without any issue. -- To view, visit http://gerrit.ovirt.org/28800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38d1d68ee1a556a9a1f484f436217a463c8705aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix FakeGuestAgent field
Francesco Romani has posted comments on this change. Change subject: tests: fix FakeGuestAgent field .. Patch Set 1: Verified+1 Verified by running the existing tests (OK, no regressions) and with http://gerrit.ovirt.org/#/c/28802/1 which implements stricter checks. -- To view, visit http://gerrit.ovirt.org/28801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Francesco Romani has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 1: Verified+1 Verified running the tests themselves. -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix FakeGuestAgent field
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: fix FakeGuestAgent field .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9308/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10249/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5175/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged// : SUCCESS -- To view, visit http://gerrit.ovirt.org/28801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10092/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5174/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3332/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 3: (1 comment) Patch set 3 vs 1. http://gerrit.ovirt.org/#/c/28700/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 820: else: Line 821: continue Line 822: info.update(_devinfo(dev, ipaddrs)) Line 823: if dev.isBOND(): Line 824: _bondOptsForIfcfg(info) Here you are passing the info dictionary of all devices and in _bondOptsFor The patch set 1 was not yet correct though :-( If you take a look at it, in _bondinfo I forgot one thing: 'cfg' dictionary is not yet there, it is added later in _devinfo. So I moved all backwards compatibility to a single function. I only pass the current bond dictionary to it, as returned by _bondinfo and enriched by common information in _devinfo. Line 825: Line 826: _cfgBootprotoCompat(d) Line 827: Line 828: return d -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Dan Kenigsberg has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: fix guest agent stats field .. vm: fix guest agent stats field In commit 068fc28d I mistakenly removed an explicit int() conversion because I overlooked the code, and thought the result was going to be an int() anyway. I was wrong, and the result is a float, which breaks the schema which dictates the affected field to be an uint. This patch restores the explicit conversion to make the code compliant with the schema again. Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28781 Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Martin Sivák msi...@redhat.com Reviewed-by: Kobi Ianko k...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Kobi Ianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix guest agent stats field
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix guest agent stats field .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1455/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9310/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3334/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: docstring update
Nir Soffer has posted comments on this change. Change subject: vdsm: docstring update .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28806/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 30: from fnmatch import fnmatch Line 31: from SimpleXMLRPCServer import \ Line 32: SimpleXMLRPCRequestHandler, \ Line 33: SimpleXMLRPCServer, \ Line 34: SimpleXMLRPCDispatcher How is this related to better documentation? Line 35: from Queue import Queue Line 36: from StringIO import StringIO Line 37: from weakref import proxy Line 38: import SocketServer Line 49: import platform Line 50: import select Line 51: import shutil Line 52: import signal Line 53: import socket Unused import? Line 54: import stat Line 55: import threading Line 56: import time Line 57: import zombiereaper -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 50: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9311/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/872/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1293/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: docstring update
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: docstring update .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10100/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5182/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1295/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
Kobi Ianko has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 50: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: sslTests updated to use sslutils
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: sslTests updated to use sslutils .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10259/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5185/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3343/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I630acc8f2e29764c35a77f45ab6f08eef46433ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop needless configurable
Dan Kenigsberg has uploaded a new change for review.
Change subject: virt: drop needless configurable
..
virt: drop needless configurable
There is no need to keep more than one sample of balloon size, but our
sampling framework can handle no less than two samples, but only the
last sample is used. In any case, we should not expose the number of
samples to the end user, it only complicates the config file with no
benefit.
Change-Id: I6e66f18706761ada045799f0f6d488a2c9ef6553
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/config.py.in
M vdsm/virt/vm.py
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/28808/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 76d77a1..09113f5 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -168,8 +168,6 @@
('vm_sample_balloon_interval', '15', None),
-('vm_sample_balloon_window', '2', None),
-
('vm_sample_jobs_interval', '15', None),
# TODO: Change this to 1 once AdvancedStatsFunction can support it
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d66458d..774a47c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -209,7 +209,7 @@
sampling.AdvancedStatsFunction(
self._sampleBalloon,
config.getint('vars', 'vm_sample_balloon_interval'),
-config.getint('vars', 'vm_sample_balloon_window')))
+2))
self.sampleVmJobs = (
sampling.AdvancedStatsFunction(
self._sampleVmJobs,
--
To view, visit http://gerrit.ovirt.org/28808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e66f18706761ada045799f0f6d488a2c9ef6553
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5183/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: docstring update
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: docstring update .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10104/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5186/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1296/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop needless configurable
Francesco Romani has posted comments on this change. Change subject: virt: drop needless configurable .. Patch Set 1: Code-Review+1 Makes sense to me. Please note that the whole framework is under review, expect change proposals soon. -- To view, visit http://gerrit.ovirt.org/28808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e66f18706761ada045799f0f6d488a2c9ef6553 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9313/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10252/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5178/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3336/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 4: Verified+1 Backwards-compatibility function is now split, as before, to make the patch as small as possible. Tested together with http://gerrit.ovirt.org/#/c/28592/12 Unit and functional network tests passed again. -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add 'bootproto4' to all devices
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Add 'bootproto4' to all devices .. Patch Set 12: Verified+1 Just rebased on top of http://gerrit.ovirt.org/#/c/28700/4 Unit and functional network tests passed again. Please note a comment on patch set 11. -- To view, visit http://gerrit.ovirt.org/28592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e8a4afa7759d37b9bd5c68a18d38baecfe94a6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in its d...
Nir Soffer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in its doc string. .. Patch Set 1: Looks ok - can you fix the commit message? -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10102/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5184/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3342/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
