Change in vdsm[master]: Force vdsm to stay with libvirt <= 1.2.7
oVirt Jenkins CI Server has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/334/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11441/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12385/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/350/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: implement VM.sdIds as read-only property
Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32796/1//COMMIT_MSG Commit Message: Line 8: Line 9: Changed the VM object sdIds list attribute. It used to be a list that kept a copy of the storage domains in use in an additional list (with all the difficulties of keeping the list in sync). That list has been replaced with a property that returns the storage domains in use getting them directly from the the vm devices in use. Line 10: Line 11: Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Line 12: Bug-Url: https://bugzilla.redhat.com/1094518 This is not enough to close this bug, so better make this Relates-To: instead of Bug-Url: Unless you plan a series of patches redesigning the current mess. -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabio Pliger Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: implement VM.sdIds as read-only property
Nir Soffer has posted comments on this change.
Change subject: vm: implement VM.sdIds as read-only property
..
Patch Set 1:
(6 comments)
Nice!
http://gerrit.ovirt.org/#/c/32796/1/tests/vmTests.py
File tests/vmTests.py:
Line 1303: "specParams": {
Line 1304: "ioTune": {
Line 1305: "total_bytes_sec": ,
Line 1306: "total_iops_sec": }
Line 1307: }},
Please fix the indentation of the closing braces:
a: {
b: {
c: "v"
}
}
Line 1308: log=self.log,
Line 1309: index=0,
Line 1310: device="hdd",
Line 1311: path="/dev/dummy",
Line 1315:
Line 1316: # Make the drive look like a VDSM volume
Line 1317: required = ('domainID', 'imageID', 'poolID', 'volumeID')
Line 1318: for p in required:
Line 1319: setattr(drives[0], p, "1")
Why do we need this loop here? I think you can create the drive with this
values like a read drive is created.
Line 1320:
Line 1321: with FakeVM() as machine:
Line 1322: dom = FakeDomain()
Line 1323: machine._dom = dom
Line 1321: with FakeVM() as machine:
Line 1322: dom = FakeDomain()
Line 1323: machine._dom = dom
Line 1324: ids = []
Line 1325: for drive in drives:
> I prefer that the expected output is explicitly written instead of re-gener
+1
Line 1326: ids.append(drive.domainId)
Line 1327: machine._devices[drive.type].append(drive)
Line 1328:
Line 1329: self.assertEqual(machine.sdId, ids)
Line 1325: for drive in drives:
Line 1326: ids.append(drive.domainId)
Line 1327: machine._devices[drive.type].append(drive)
Line 1328:
Line 1329: self.assertEqual(machine.sdId, ids)
We don't care about drives order, use a set().
Line 1330:
Line 1331: def testGetUnderlyingGraphicsDeviceInfo(self):
Line 1332: port = '6000'
Line 1333: tlsPort = '6001'
http://gerrit.ovirt.org/#/c/32796/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2867: # So, to get proper device objects during VM recovery
flow
Line 2868: # we must to have updated conf before VM run
Line 2869: self.saveState()
Line 2870: else:
Line 2871: pass
> I think this block can be removed entirely.
+1
Line 2872: # Note that we do not start disk stats collection here
since
Line 2873: # in the recovery flow irs may not be ready yet.
Line 2874: # Disk stats collection is started from clientIF at the
end
Line 2875: # of the recovery process.
Line 5597: def sdIds(self):
Line 5598: """
Line 5599: Returns a list of the ids of the storage domains in use by
the VM.
Line 5600: """
Line 5601: return [device.domainID for device in
self._devices[DISK_DEVICES]]
> Not all the disks are vdsm images, therefore not all of them have domainID.
We don't care about the order of devices, and number of disk in each domain, so
you should return a set().
Line 5602:
Line 5603:
Line 5604: class LiveMergeCleanupThread(threading.Thread):
Line 5605: def __init__(self, vm, jobId, drive, doPivot):
--
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: implement VM.sdIds as read-only property
Federico Simoncelli has posted comments on this change.
Change subject: vm: implement VM.sdIds as read-only property
..
Patch Set 1:
(7 comments)
http://gerrit.ovirt.org/#/c/32796/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-09-10 23:27:17 +0200
Line 6:
Line 7: vm: implement VM.sdIds as read-only property
Line 8:
Line 9: Changed the VM object sdIds list attribute. It used to be a list that
kept a copy of the storage domains in use in an additional list (with all the
difficulties of keeping the list in sync). That list has been replaced with a
property that returns the storage domains in use getting them directly from the
the vm devices in use.
Commit message should respect the 72 columns limit.
Line 10:
Line 11: Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Line 12: Bug-Url: https://bugzilla.redhat.com/1094518
http://gerrit.ovirt.org/#/c/32796/1/tests/vmTests.py
File tests/vmTests.py:
Line 1308: log=self.log,
Line 1309: index=0,
Line 1310: device="hdd",
Line 1311: path="/dev/dummy",
Line 1312: type=vm.DISK_DEVICES,
I don't recall, can't you add domainID (etc) here?
Line 1313: iface="ide")
Line 1314: ]
Line 1315:
Line 1316: # Make the drive look like a VDSM volume
Line 1309: index=0,
Line 1310: device="hdd",
Line 1311: path="/dev/dummy",
Line 1312: type=vm.DISK_DEVICES,
Line 1313: iface="ide")
Maybe you could add another drive that doesn't contain domainID to check that
we're not failing. (Code as it is now will crash iiuc)
Line 1314: ]
Line 1315:
Line 1316: # Make the drive look like a VDSM volume
Line 1317: required = ('domainID', 'imageID', 'poolID', 'volumeID')
Line 1315:
Line 1316: # Make the drive look like a VDSM volume
Line 1317: required = ('domainID', 'imageID', 'poolID', 'volumeID')
Line 1318: for p in required:
Line 1319: setattr(drives[0], p, "1")
Please use uuids for consistency.
Line 1320:
Line 1321: with FakeVM() as machine:
Line 1322: dom = FakeDomain()
Line 1323: machine._dom = dom
Line 1321: with FakeVM() as machine:
Line 1322: dom = FakeDomain()
Line 1323: machine._dom = dom
Line 1324: ids = []
Line 1325: for drive in drives:
I prefer that the expected output is explicitly written instead of re-generated
with the same algorithm used in the code.
Line 1326: ids.append(drive.domainId)
Line 1327: machine._devices[drive.type].append(drive)
Line 1328:
Line 1329: self.assertEqual(machine.sdId, ids)
http://gerrit.ovirt.org/#/c/32796/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2867: # So, to get proper device objects during VM recovery
flow
Line 2868: # we must to have updated conf before VM run
Line 2869: self.saveState()
Line 2870: else:
Line 2871: pass
I think this block can be removed entirely.
Line 2872: # Note that we do not start disk stats collection here
since
Line 2873: # in the recovery flow irs may not be ready yet.
Line 2874: # Disk stats collection is started from clientIF at the
end
Line 2875: # of the recovery process.
Line 5597: def sdIds(self):
Line 5598: """
Line 5599: Returns a list of the ids of the storage domains in use by
the VM.
Line 5600: """
Line 5601: return [device.domainID for device in
self._devices[DISK_DEVICES]]
Not all the disks are vdsm images, therefore not all of them have domainID.
Line 5602:
Line 5603:
Line 5604: class LiveMergeCleanupThread(threading.Thread):
Line 5605: def __init__(self, vm, jobId, drive, doPivot):
--
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make: Run fast checks before slow ones
oVirt Jenkins CI Server has posted comments on this change. Change subject: make: Run fast checks before slow ones .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5805/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3964/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove duplicate names
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove duplicate names .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5804/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3963/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make: Run fast checks before slow ones
Dan Kenigsberg has posted comments on this change. Change subject: make: Run fast checks before slow ones .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make: Run fast checks before slow ones
Dan Kenigsberg has submitted this change and it was merged. Change subject: make: Run fast checks before slow ones .. make: Run fast checks before slow ones Previously the slow tests where run before the fast pyflakes and pep8 checks, so developer discover unused arguments or whitespace issues only after 1-2 minutes instead of few seconds. Now make check runs the fast checks before the slow ones, saving developer time. This is implemented by extracting the unrelated checks from check-local into separate phony targets. This is useful when debugging specific issues or when creating automated jobs that run specific checks. Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/32532 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M Makefile.am 1 file changed, 26 insertions(+), 15 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove duplicate names
Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Remove duplicate names .. tool: Remove duplicate names The configurators modules were duplicating the module name in the class name: libvirt.Libvrit This is not only ugly, but does not describe what this class is. Now all the configurtors modules define a Configurator class instead: libvirt.Configurator This also has the nice property that it is now harder to import class names into other modules, so people will import the modules instead. Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/31775 Reviewed-by: Francesco Romani Reviewed-by: Antoni Segura Puimedon Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/certificates.py M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/sanlock.py M tests/toolTests.py 5 files changed, 17 insertions(+), 17 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove duplicate names
Dan Kenigsberg has posted comments on this change. Change subject: tool: Remove duplicate names .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: implement VM.sdIds as read-only property
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property .. Patch Set 1: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11452/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12396/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1651/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12241/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabio Pliger Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem i...
Yaniv Bronhaim has posted comments on this change. Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps .. Patch Set 2: wrong bug attached.. -- To view, visit http://gerrit.ovirt.org/32574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Disable queuing on all multipath devices
Nir Soffer has posted comments on this change.
Change subject: multipath: Disable queuing on all multipath devices
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32277/3/vdsm/storage/vdsm-multipath.rules.in
File vdsm/storage/vdsm-multipath.rules.in:
Line 15: #
Line 16: # See
https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html-single/DM_Multipath/index.html#queueifnopath_issues
Line 17: #
Line 18:
Line 19: ACTION=="add|change", ENV{DM_UUID}=="mpath-?*", RUN+="@DMSETUP_PATH@
message $env{DM_NAME} 0 fail_if_no_path"
> This looks good but I think we should come up with a common fix for both fa
I tried this in http://gerrit.ovirt.org/32582, but it does not work - see my
comment there.
--
To view, visit http://gerrit.ovirt.org/32277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bfe68f4a8d233afe1bb787ce028ffb4c167469b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Disable queuing on all multipath devices
Nir Soffer has posted comments on this change. Change subject: multipath: Disable queuing on all multipath devices .. Patch Set 3: Verified-1 When a device is unmapped on the server, multipath detect the failure and reconfigure the device as part of the recovery process. This overwrites the fail_if_no_path setup that this patch is doing, which lead to the usual couple of minutes blocking. This must be solved within multipath. In the meantime we can use http://gerrit.ovirt.org/31875, which should help in most cases until we have a real solution from multipath. -- To view, visit http://gerrit.ovirt.org/32277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bfe68f4a8d233afe1bb787ce028ffb4c167469b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Use frozenset instead of set
Nir Soffer has posted comments on this change. Change subject: tests: Use frozenset instead of set .. Patch Set 5: No, I don't have a development environment with Python 2.6, but some of the jenkins machines may run this version, and I did not see any failures. -- To view, visit http://gerrit.ovirt.org/31786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Require latest ioprocess
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Require latest ioprocess .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/159/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09de4d0dec19903109be407dee3e8d1fde439404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: when optional argument value is None fixing args fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: when optional argument value is None fixing args fails .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11451/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12240/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c99b3d98a105cc738e6cdd524a889a61dff670d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ethtool_opts: provide a way to apply to all slaves
oVirt Jenkins CI Server has posted comments on this change. Change subject: ethtool_opts: provide a way to apply to all slaves .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/158/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Require latest ioprocess
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require latest ioprocess .. Patch Set 2: Verified+1 Code-Review+2 rebase. make rpm still flies. -- To view, visit http://gerrit.ovirt.org/32571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09de4d0dec19903109be407dee3e8d1fde439404 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Require latest ioprocess
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Require latest ioprocess .. spec: Require latest ioprocess Latest IOProcess(0.12) includes a new patch for the python bindings that deals with a memory leak. Change-Id: I09de4d0dec19903109be407dee3e8d1fde439404 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124369 Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/32571 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09de4d0dec19903109be407dee3e8d1fde439404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem i...
Yaniv Bronhaim has posted comments on this change. Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps .. Patch Set 5: got confused with the cloning process -- To view, visit http://gerrit.ovirt.org/32444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Require latest ioprocess
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require latest ioprocess .. Patch Set 1: Verified+1 Indeed http://mirrors.ukfast.co.uk/sites/dl.fedoraproject.org/pub/epel/7/x86_64/i/ioprocess-0.12.0-2.el7.x86_64.rpm -- To view, visit http://gerrit.ovirt.org/32571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09de4d0dec19903109be407dee3e8d1fde439404 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ethtool_opts: provide a way to apply to all slaves
Dan Kenigsberg has submitted this change and it was merged. Change subject: ethtool_opts: provide a way to apply to all slaves .. ethtool_opts: provide a way to apply to all slaves There was a hole in the feature that this hook services in that it was not possible to apply some opts to all the slaves in the cases when the combination of settings was not appliable to all the slaves in a single ethtool command. This patch solves the bug by adding a special device name that the admin can use when defining the custom network opts, i.e., '*' that will mean that the special device name will be replaced with each of the slave names, one at a time, and run as many ethtool procs as there are slaves in the bond. Bug-Url: https://bugzilla.redhat.com/1126478 Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/32784 Reviewed-by: Dan Kenigsberg --- M vdsm/hooking.py M vdsm_hooks/ethtool_options/README M vdsm_hooks/ethtool_options/ethtool_options.py 3 files changed, 60 insertions(+), 21 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/157/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: revert: libvirt is happy with redefinition of an existing nw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/285/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ethtool_opts: provide a way to apply to all slaves
Antoni Segura Puimedon has posted comments on this change. Change subject: ethtool_opts: provide a way to apply to all slaves .. Patch Set 1: Verified+1 Verified again with the same process as I did for master -- To view, visit http://gerrit.ovirt.org/32784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/67/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/284/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/156/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/283/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: revert: libvirt is happy with redefinition of an existing nw...
Dan Kenigsberg has posted comments on this change. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: revert: libvirt is happy with redefinition of an existing nw...
Dan Kenigsberg has submitted this change and it was merged. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. revert: libvirt is happy with redefinition of an existing nwfilter Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Bug-Url: https://bugzilla.redhat.com/1138807 Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/32691 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32697 Tested-by: Dan Kenigsberg --- M lib/vdsm/tool/nwfilter.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ethtool_opts: provide a way to apply to all slaves
Dan Kenigsberg has posted comments on this change. Change subject: ethtool_opts: provide a way to apply to all slaves .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has submitted this change and it was merged. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Do not add the memtune/min_guarantee element to the libvirt xml VDSM does not need to put the min_guarantee to the libvirt XML. It was only set and then nobody was accessing it. It will break compatibility with tools that read data through libvirt directly, but we do not officially support that anyway. This part will fix all new VMs. Old VMs need a migration hook that will be included as another patch. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32774 Reviewed-by: Adam Litke Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32789 --- M tests/vmTests.py M tests/vmTestsData.py M vdsm/vm.py 3 files changed, 0 insertions(+), 25 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Revert "Force vdsm to stay with libvirt <= 1.2.7" This is not needed anymore and also breaks live merge. This reverts commit 93a3d2b9b2fd699e733cb1f19b792137ead28627. Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32787 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Dan Kenigsberg has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Dan Kenigsberg has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Revert "Force vdsm to stay with libvirt <= 1.2.7" This breaks live merge and is not needed now. This reverts commit 4573eca868c7d13f36265bbe4901b4f2716311e3. Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32786 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has submitted this change and it was merged. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Do not add the memtune/min_guarantee element to the libvirt xml VDSM does not need to put the min_guarantee to the libvirt XML. It was only set and then nobody was accessing it. It will break compatibility with tools that read data through libvirt directly, but we do not officially support that anyway. This part will fix all new VMs. Old VMs need a migration hook that will be included as another patch. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32774 Reviewed-by: Adam Litke Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32788 --- M tests/vmTests.py M tests/vmTestsData.py M vdsm/virt/vm.py 3 files changed, 0 insertions(+), 25 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
Martin Sivák has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
Martin Sivák has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Verified+1 All tests pass, also verified on F19 with 3.4 setup. -- To view, visit http://gerrit.ovirt.org/32789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/66/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Do not add the memtune/min_guarantee element to the libvirt xml
Hello Adam Litke, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32789
to review the following change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Do not add the memtune/min_guarantee element to the libvirt xml
VDSM does not need to put the min_guarantee to the libvirt XML.
It was only set and then nobody was accessing it. It will break
compatibility with tools that read data through libvirt directly,
but we do not officially support that anyway.
This part will fix all new VMs. Old VMs need a migration
hook that will be included as another patch.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Signed-off-by: Martin Sivak
Reviewed-on: http://gerrit.ovirt.org/32774
Reviewed-by: Adam Litke
Reviewed-by: Francesco Romani
Reviewed-by: Dan Kenigsberg
---
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/vm.py
3 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/32789/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index fc56f1a..73f2b6a 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -112,9 +112,6 @@
1048576
1048576
160
-
- 524288
-
"""
diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index d95fe58..cd03c76 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -38,9 +38,6 @@
1048576
1048576
160
-
-524288
-
@@ -107,9 +104,6 @@
1048576
1048576
160
-
-524288
-
@@ -156,9 +150,6 @@
65536
65536
160
-
-16384
-
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 16037fa..3dccdf8 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -979,9 +979,6 @@
160
-
-0
-
"""
@@ -1017,16 +1014,6 @@
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
vcpu.setAttrs(**{'current': self._getSmp()})
-
-memSizeGuaranteedKB = str(1024 * int(
-self.conf.get('memGuaranteedSize', '0')
-))
-
-memtune = XMLElement('memtune')
-self.dom.appendChild(memtune)
-
-memtune.appendChildWithArgs('min_guarantee',
-text=memSizeGuaranteedKB)
self._devices = XMLElement('devices')
self.dom.appendChild(self._devices)
--
To view, visit http://gerrit.ovirt.org/32789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Do not add the memtune/min_guarantee element to the libvirt xml
Hello Adam Litke, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32788
to review the following change.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Do not add the memtune/min_guarantee element to the libvirt xml
VDSM does not need to put the min_guarantee to the libvirt XML.
It was only set and then nobody was accessing it. It will break
compatibility with tools that read data through libvirt directly,
but we do not officially support that anyway.
This part will fix all new VMs. Old VMs need a migration
hook that will be included as another patch.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Signed-off-by: Martin Sivak
Reviewed-on: http://gerrit.ovirt.org/32774
Reviewed-by: Adam Litke
Reviewed-by: Francesco Romani
Reviewed-by: Dan Kenigsberg
---
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/virt/vm.py
3 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/32788/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index aa73a6e..32fa5e0 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -194,9 +194,6 @@
1048576
1048576
160
-
- 524288
-
"""
diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index 69d2c6b..c14efe9 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -39,9 +39,6 @@
1048576
1048576
160
-
-524288
-
@@ -108,9 +105,6 @@
1048576
1048576
160
-
-524288
-
@@ -155,9 +149,6 @@
65536
65536
160
-
-16384
-
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7d2f98c..0f9e4ce 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -721,9 +721,6 @@
160
-
-0
-
"""
@@ -759,16 +756,6 @@
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
vcpu.setAttrs(**{'current': self._getSmp()})
-
-memSizeGuaranteedKB = str(1024 * int(
-self.conf.get('memGuaranteedSize', '0')
-))
-
-memtune = XMLElement('memtune')
-self.dom.appendChild(memtune)
-
-memtune.appendChildWithArgs('min_guarantee',
-text=memSizeGuaranteedKB)
self._devices = XMLElement('devices')
self.dom.appendChild(self._devices)
--
To view, visit http://gerrit.ovirt.org/32788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5803/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3962/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has posted comments on this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has uploaded a new change for review. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Revert "Force vdsm to stay with libvirt <= 1.2.7" This is not needed anymore and also breaks live merge. This reverts commit 93a3d2b9b2fd699e733cb1f19b792137ead28627. Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Signed-off-by: Martin Sivak --- M vdsm.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/32787/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index d797f25..7af6d59 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -137,9 +137,6 @@ Requires: libvirt >= 0.10.2-29.el6_5.4 %else Requires: libvirt >= 1.0.2-1 -# Remove once the following bug is solved -# https://bugzilla.redhat.com/show_bug.cgi?id=1138340 -Conflicts: libvirt >= 1.2.8-1 %endif %endif Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has reverted this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 3: Reverted This patchset was reverted in change: Id08f4e1c61d6b20518570ccafad847ce446fee9d -- To view, visit http://gerrit.ovirt.org/32787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: revert Gerrit-Change-Id: Id08f4e1c61d6b20518570ccafad847ce446fee9d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has uploaded a new change for review. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Revert "Force vdsm to stay with libvirt <= 1.2.7" This breaks live merge and is not needed now. This reverts commit 4573eca868c7d13f36265bbe4901b4f2716311e3. Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Signed-off-by: Martin Sivak --- M vdsm.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/32786/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 1d83e23..a789f01 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -148,9 +148,6 @@ Requires: libvirt >= 0.10.2-29.el6_5.4 %else Requires: libvirt >= 1.0.2-1 -# Remove once the following bug is solved -# https://bugzilla.redhat.com/show_bug.cgi?id=1138340 -Conflicts: libvirt >= 1.2.8-1 %endif %endif Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "Force vdsm to stay with libvirt <= 1.2.7"
Martin Sivák has reverted this change. Change subject: Revert "Force vdsm to stay with libvirt <= 1.2.7" .. Patch Set 3: Reverted This patchset was reverted in change: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 -- To view, visit http://gerrit.ovirt.org/32786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: revert Gerrit-Change-Id: Iffa726906cc8fe4f8ba7f5be377a51d19ee46078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves
oVirt Jenkins CI Server has posted comments on this change. Change subject: ethtool_opts: provide a way to apply to all slaves .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5802/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3961/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ethtool_opts: provide a way to apply to all slaves
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
ethtool_opts: provide a way to apply to all slaves
There was a hole in the feature that this hook services in that it
was not possible to apply some opts to all the slaves in the
cases when the combination of settings was not appliable to all
the slaves in a single ethtool command.
This patch solves the bug by adding a special device name that
the admin can use when defining the custom network opts, i.e.,
'*' that will mean that the special device name will be replaced
with each of the slave names, one at a time, and run as many ethtool
procs as there are slaves in the bond.
Bug-Url: https://bugzilla.redhat.com/1126478
Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Signed-off-by: Antoni S. Puimedon
---
M vdsm/hooking.py
M vdsm_hooks/ethtool_options/README
M vdsm_hooks/ethtool_options/ethtool_options.py
3 files changed, 60 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/32784/1
diff --git a/vdsm/hooking.py b/vdsm/hooking.py
index 6b17ae7..4712ca3 100644
--- a/vdsm/hooking.py
+++ b/vdsm/hooking.py
@@ -69,6 +69,10 @@
f.write(json.dumps(data))
+def log(message):
+sys.stderr.write(message + '\n')
+
+
def exit_hook(message, return_code=2):
"""
Exit the hook with a given message, which will be printed to the standard
diff --git a/vdsm_hooks/ethtool_options/README
b/vdsm_hooks/ethtool_options/README
index e15b71b..db8272e 100644
--- a/vdsm_hooks/ethtool_options/README
+++ b/vdsm_hooks/ethtool_options/README
@@ -10,6 +10,18 @@
In the oVirt UI edit custom network properties and, for the key 'ethtool_opts'
set the command line parameters that one would pass to the ethtool command
line application. E.g.:
-'--coalesce ethX rx-usecs 14 sample_interval 3 --offload ethX rx on lro on
tso off --change ethX speed 1000 duplex half'
-If it is for a bond with em1 and em2, it could look like:
+'--coalesce ethX rx-usecs 14 sample-interval 3 --offload ethX rx on lro on
tso off --change ethX speed 1000 duplex half'
+
+Note that it is possible to substitute the ethX name of the NIC with a '*' and
+the hook will fill in the right nic name for you.
+
+bonding
+
+For bondings there are two options:
+a) Pick which devices to apply something on (subject to the command actually
+ being appliable with a single ethtool call):
+ If it is for a bond with em1 and em2, it could look like:
'--offload em2 rx on --offload em1 tx on'
+b) Apply to all the bond slaves:
+'--coalesce * rx-usecs 14 sample_interval 3'
+ This would execute an ethtool process for each slave.
diff --git a/vdsm_hooks/ethtool_options/ethtool_options.py
b/vdsm_hooks/ethtool_options/ethtool_options.py
index 58f19bf..e533719 100644
--- a/vdsm_hooks/ethtool_options/ethtool_options.py
+++ b/vdsm_hooks/ethtool_options/ethtool_options.py
@@ -32,7 +32,13 @@
'/usr/bin/ethtool', # Arch
)
+ALL_SLAVES = '*' # wildcard to make the hook resolve the nics to modify
+
Subcommand = namedtuple('Subcommand', ('name', 'device', 'flags'))
+
+
+class EthtoolError(Exception):
+pass
def _test_cmd_with_nics(nics, ethtool_opts):
@@ -40,17 +46,25 @@
'custom': ethtool_opts,
'bootproto': 'dhcp', 'STP': 'no', 'bridged': 'true'}
-_validate_dev_ownership(nics, 'test_net',
-(item for item in
- net_attrs['custom']['ethtool_opts'].split(' ') if
- item))
+for subcommand in _parse_into_subcommands(
+net_attrs['custom']['ethtool_opts'].split(' ')):
+_validate_dev_ownership(nics, 'test_net', subcommand)
def test():
opts = {'ethtool_opts':
-'--coalesce em1 rx-usecs 14 sample_interval 3 '
+'--coalesce em1 rx-usecs 14 sample-interval 3 '
'--offload em2 rx on lro on tso off '
'--change em1 speed 1000 duplex half'}
+# Test subcmd split
+print(opts['ethtool_opts'])
+print('splits into: ')
+for subcmd in _parse_into_subcommands(opts['ethtool_opts'].split()):
+command = ([ETHTOOL_BINARY.cmd] + [subcmd.name, subcmd.device] +
+ subcmd.flags)
+print(''),
+print(command)
+
# Test with the correct nics
nics = ('em1', 'em2')
try:
@@ -87,9 +101,19 @@
"""Applies ethtool_options to the network if necessary"""
options = attrs['custom'].get('ethtool_opts')
if options is not None:
-tokens = options.split(' ')
-_validate_dev_ownership(_net_nics(attrs), network, tokens)
-_set_ethtool_opts(network, tokens)
+nics = _net_nics(attrs)
+for subcmd in _parse_into_subcommands(options.split()):
+if subcmd.device == ALL_SLAVES:
+expanded_nics = n
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has submitted this change and it was merged. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Do not add the memtune/min_guarantee element to the libvirt xml VDSM does not need to put the min_guarantee to the libvirt XML. It was only set and then nobody was accessing it. It will break compatibility with tools that read data through libvirt directly, but we do not officially support that anyway. This part will fix all new VMs. Old VMs need a migration hook that will be included as another patch. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32774 Reviewed-by: Adam Litke Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M tests/vmTests.py M tests/vmTestsData.py M vdsm/virt/vmxml.py 3 files changed, 0 insertions(+), 25 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 5: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11450/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12239/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves
Dan Kenigsberg has submitted this change and it was merged. Change subject: ethtool_opts: provide a way to apply to all slaves .. ethtool_opts: provide a way to apply to all slaves There was a hole in the feature that this hook services in that it was not possible to apply some opts to all the slaves in the cases when the combination of settings was not appliable to all the slaves in a single ethtool command. This patch solves the bug by adding a special device name that the admin can use when defining the custom network opts, i.e., '*' that will mean that the special device name will be replaced with each of the slave names, one at a time, and run as many ethtool procs as there are slaves in the bond. Bug-Url: https://bugzilla.redhat.com/1126478 Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/32508 Reviewed-by: Dan Kenigsberg --- M vdsm/hooking.py M vdsm_hooks/ethtool_options/README M vdsm_hooks/ethtool_options/ethtool_options.py 3 files changed, 60 insertions(+), 21 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves
Antoni Segura Puimedon has posted comments on this change.
Change subject: ethtool_opts: provide a way to apply to all slaves
..
Patch Set 7: Verified+1
Verified by doing:
In [23]: c.setupNetworks({'ethtool': {'nic': 'p1p4', 'bridged': False,
'custom': {'ethtool_opts': '--offload * rxvlan on txvlan on --coalesce *
rx-usecs 18'}}}, {'bond11': {'remove': True}}, {'connectivityCheck': False})
Which results in:
➜ vdsm git:(d8dd403) ethtool --show-offload p1p4
Features for p1p4:
rx-checksumming: on
tx-checksumming: on
tx-checksum-ipv4: on
tx-checksum-ip-generic: off [fixed]
tx-checksum-ipv6: on
tx-checksum-fcoe-crc: off [fixed]
tx-checksum-sctp: off [fixed]
scatter-gather: on
tx-scatter-gather: on
tx-scatter-gather-fraglist: off [fixed]
tcp-segmentation-offload: on
tx-tcp-segmentation: on
tx-tcp-ecn-segmentation: on
tx-tcp6-segmentation: on
udp-fragmentation-offload: off [fixed]
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off [fixed]
rx-vlan-offload: on <---
tx-vlan-offload: on <---
ntuple-filters: off [fixed]
receive-hashing: on
highdma: on [fixed]
rx-vlan-filter: off [fixed]
vlan-challenged: off [fixed]
tx-lockless: off [fixed]
netns-local: off [fixed]
tx-gso-robust: off [fixed]
tx-fcoe-segmentation: off [fixed]
tx-gre-segmentation: off [fixed]
tx-ipip-segmentation: off [fixed]
tx-sit-segmentation: off [fixed]
tx-udp_tnl-segmentation: off [fixed]
tx-mpls-segmentation: off [fixed]
fcoe-mtu: off [fixed]
tx-nocache-copy: off
loopback: off [fixed]
rx-fcs: off [fixed]
rx-all: off [fixed]
tx-vlan-stag-hw-insert: off [fixed]
rx-vlan-stag-hw-parse: off [fixed]
rx-vlan-stag-filter: off [fixed]
l2-fwd-offload: off [fixed]
busy-poll: off [fixed]
➜ vdsm git:(d8dd403) ethtool --show-coalesce p1p4
Coalesce parameters for p1p4:
Adaptive RX: off TX: off
stats-block-usecs: 36
sample-interval: 0
pkt-rate-low: 0
pkt-rate-high: 0
rx-usecs: 18 <---
rx-frames: 12
rx-usecs-irq: 18
rx-frames-irq: 2
tx-usecs: 80
tx-frames: 20
tx-usecs-irq: 18
tx-frames-irq: 2
rx-usecs-low: 0
rx-frame-low: 0
tx-usecs-low: 0
tx-frame-low: 0
rx-usecs-high: 0
rx-frame-high: 0
tx-usecs-high: 0
tx-frame-high: 0
➜ vdsm git:(d8dd403)
After that, try with bonds and the wildcard:
➜ vdsm git:(d8dd403) ethtool --show-offload p1p4
Features for p1p4:
rx-checksumming: on
tx-checksumming: on
tx-checksum-ipv4: on
tx-checksum-ip-generic: off [fixed]
tx-checksum-ipv6: on
tx-checksum-fcoe-crc: off [fixed]
tx-checksum-sctp: off [fixed]
scatter-gather: on
tx-scatter-gather: on
tx-scatter-gather-fraglist: off [fixed]
tcp-segmentation-offload: on
tx-tcp-segmentation: on
tx-tcp-ecn-segmentation: on
tx-tcp6-segmentation: on
udp-fragmentation-offload: off [fixed]
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off [fixed]
rx-vlan-offload: off <---
tx-vlan-offload: on
ntuple-filters: off [fixed]
receive-hashing: on
highdma: on [fixed]
rx-vlan-filter: off [fixed]
vlan-challenged: off [fixed]
tx-lockless: off [fixed]
netns-local: off [fixed]
tx-gso-robust: off [fixed]
tx-fcoe-segmentation: off [fixed]
tx-gre-segmentation: off [fixed]
tx-ipip-segmentation: off [fixed]
tx-sit-segmentation: off [fixed]
tx-udp_tnl-segmentation: off [fixed]
tx-mpls-segmentation: off [fixed]
fcoe-mtu: off [fixed]
tx-nocache-copy: off
loopback: off [fixed]
rx-fcs: off [fixed]
rx-all: off [fixed]
tx-vlan-stag-hw-insert: off [fixed]
rx-vlan-stag-hw-parse: off [fixed]
rx-vlan-stag-filter: off [fixed]
l2-fwd-offload: off [fixed]
busy-poll: off [fixed]
➜ vdsm git:(d8dd403) ethtool --show-offload p1p3
Features for p1p3:
rx-checksumming: on
tx-checksumming: on
tx-checksum-ipv4: on
tx-checksum-ip-generic: off [fixed]
tx-checksum-ipv6: on
tx-checksum-fcoe-crc: off [fixed]
tx-checksum-sctp: off [fixed]
scatter-gather: on
tx-scatter-gather:
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Dan Kenigsberg has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: Code-Review+1 fine for me, I see the missing pieces will be handled in followup patches. -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Martin Sivák has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: Verified+1 I verified that after this is applied then all new VMs have no sign of min_guarantee in the libvirt XML and vdsClient -s 0 getAllVmStats still properly reports balloon_min. That means MOM will be happy as well. -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: revert: libvirt is happy with redefinition of an existing nw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/155/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure iSCSI iface.net_ifacename
Amador Pahim has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 8: -Verified Running some more tests. -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
Yeela Kaplan has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 4:
(10 comments)
http://gerrit.ovirt.org/#/c/31501/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 318: 'Process pool configuration.'),
Line 319:
Line 320: ('process_pool_timeout', '60', None),
Line 321:
Line 322: ('ioprocess_timeout', '60', 'TTL of IOProcess that is not
renewed'),
> TTL of an unused IOProcess instance
Done
Line 323:
Line 324: ('process_pool_max_slots_per_domain', '10', None),
Line 325:
Line 326: ('process_pool_max_queued_slots_per_domain', '10', None),
http://gerrit.ovirt.org/#/c/31501/4/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 46:
Line 47: _oopImpl = RFH
Line 48:
Line 49: DEFAULT_TIMEOUT = config.getint("irs", "process_pool_timeout")
Line 50: DEF_IOPROC_TIMEOUT = config.getint("irs", "ioprocess_timeout")
> process_pool_timeout and ioprocess_timeout are confusing as they mean compl
Done
Line 51: HELPERS_PER_DOMAIN = config.getint("irs",
"process_pool_max_slots_per_domain")
Line 52: MAX_QUEUED = config.getint("irs",
"process_pool_max_queued_slots_per_domain")
Line 53:
Line 54: _procPoolLock = threading.Lock()
Line 67: _oopImpl = RFH
Line 68:
Line 69:
Line 70: def getProcessPool(clientName):
Line 71: try:
> There are two different logic paths intertwined and that makes following wh
Done
Line 72: if _oopImpl == IOPROC:
Line 73: with _procPoolLock:
Line 74: for item in _procPool.items():
Line 75: if (time.time() - item[1][0]) > DEF_IOPROC_TIMEOUT
and \
Line 69:
Line 70: def getProcessPool(clientName):
Line 71: try:
Line 72: if _oopImpl == IOPROC:
Line 73: with _procPoolLock:
> 74-78 could be it's own function [cleanIdleIOProcesses()] to simplify thing
Done
Line 74: for item in _procPool.items():
Line 75: if (time.time() - item[1][0]) > DEF_IOPROC_TIMEOUT
and \
Line 76: item[0] != clientName:
Line 77: del _procPool[item[0]]
Line 71: try:
Line 72: if _oopImpl == IOPROC:
Line 73: with _procPoolLock:
Line 74: for item in _procPool.items():
Line 75: if (time.time() - item[1][0]) > DEF_IOPROC_TIMEOUT
and \
> You could only get time.time() once before the loop to save on system calls
Done
Line 76: item[0] != clientName:
Line 77: del _procPool[item[0]]
Line 78:
Line 79: procref = _refProcPool[clientName]
Line 75: if (time.time() - item[1][0]) > DEF_IOPROC_TIMEOUT
and \
Line 76: item[0] != clientName:
Line 77: del _procPool[item[0]]
Line 78:
Line 79: procref = _refProcPool[clientName]
> you could just do:
Done
Line 80: proc = procref()
Line 81: if proc is None:
Line 82: raise KeyError
Line 83: else:
Line 77: del _procPool[item[0]]
Line 78:
Line 79: procref = _refProcPool[clientName]
Line 80: proc = procref()
Line 81: if proc is None:
> We don't want another leak.
Done
Line 82: raise KeyError
Line 83: else:
Line 84: _procPool[clientName] = (time.time(), proc)
Line 85: return proc
Line 83: else:
Line 84: _procPool[clientName] = (time.time(), proc)
Line 85: return proc
Line 86: else:
Line 87: return _rfhPool[clientName]
> don't you need that also under the _procPoolLock?
Done
Line 88: except KeyError:
Line 89: with _procPoolLock:
Line 90: if _oopImpl == IOPROC:
Line 91: proc =
_OopWrapper(IOProcess(max_threads=HELPERS_PER_DOMAIN,
Line 90: if _oopImpl == IOPROC:
Line 91: proc =
_OopWrapper(IOProcess(max_threads=HELPERS_PER_DOMAIN,
Line 92: timeout=DEFAULT_TIMEOUT,
Line 93:
max_queued_requests=MAX_QUEUED))
Line 94: _procPool[clientName] = (time.time(), proc)
> See previous comments
Done
Line 95: _refProcPool[clientName] = weakref.ref(proc)
Line 96: procref = _refProcPool[clientName]
Line 97:
Line 98: return procref()
Line 99: else:
Line 100: _rfhPool[clientName] = _OopWrapper(
Line 101: RemoteFileHandlerPool(HELPERS_PER_DOMAIN))
Line 102:
Line 103: return _rfhPool[clientName]
> i'd put all of it under "with _procPoolLock"
Done
Line 1
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: bad wording. s/the filtering you added may be sufficient/this patch could be good enough for migrations already/ -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11449/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12393/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1650/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12238/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Francesco Romani has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: The simple creation flow looks OK. I'm concerned with migrations, both live migrations and hibernation/restore (both these paths happen to share a lot of common code) At glance, the filtering you added may be sufficient. Otherwise, we probably need to filter out the configuration param 'memGuaranteedSize' in the Vm.__init__() method - maybe with an added warning. -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12392/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1649/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12237/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove duplicate names
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Remove duplicate names .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Use frozenset instead of set
Yaniv Bronhaim has posted comments on this change. Change subject: tests: Use frozenset instead of set .. Patch Set 5: did you verify with python 2.6? -- To view, visit http://gerrit.ovirt.org/31786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11447/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12391/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1648/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12236/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/154/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Adam Litke has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Martin Sivák has posted comments on this change. Change subject: Do not add the memtune/min_guarantee element to the libvirt xml .. Patch Set 1: Verified-1 oops, I forgot to reset the tree, just second -- To view, visit http://gerrit.ovirt.org/32774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml
Martin Sivák has uploaded a new change for review.
Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
..
Do not add the memtune/min_guarantee element to the libvirt xml
VDSM does not need to put the min_guarantee to the libvirt XML.
It was only set and then nobody was accessing it. It will break
compatibility with tools that read data through libvirt directly,
but we do not officially support that anyway.
This part will fix all new VMs. Old VMs need a migration
hook that will be included as another patch.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Signed-off-by: Martin Sivak
---
M tests/vmTests.py
M tests/vmTestsData.py
A vdsm/virt/libvirt_migration_hook.py
M vdsm/virt/vmxml.py
4 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/32774/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 7ece7dd..a5f3446 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -214,9 +214,6 @@
1048576
1048576
160
-
- 524288
-
"""
diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index 2714616..3316598 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -38,9 +38,6 @@
1048576
1048576
160
-
-524288
-
@@ -106,9 +103,6 @@
1048576
1048576
160
-
-524288
-
@@ -153,9 +147,6 @@
65536
65536
160
-
-16384
-
diff --git a/vdsm/virt/libvirt_migration_hook.py
b/vdsm/virt/libvirt_migration_hook.py
new file mode 100644
index 000..b9307bc
--- /dev/null
+++ b/vdsm/virt/libvirt_migration_hook.py
@@ -0,0 +1 @@
+__author__ = 'msivak'
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index f3d942b..8ea6904 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -186,16 +186,6 @@
vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
vcpu.setAttrs(**{'current': self._getSmp()})
-memSizeGuaranteedKB = str(1024 * int(
-self.conf.get('memGuaranteedSize', '0')
-))
-
-memtune = Element('memtune')
-self.dom.appendChild(memtune)
-
-memtune.appendChildWithArgs('min_guarantee',
-text=memSizeGuaranteedKB)
-
self._devices = Element('devices')
self.dom.appendChild(self._devices)
--
To view, visit http://gerrit.ovirt.org/32774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Force vdsm to stay with libvirt <= 1.2.7
Martin Sivák has abandoned this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Abandoned -- To view, visit http://gerrit.ovirt.org/32741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: revert: libvirt is happy with redefinition of an existing nw...
Yaniv Bronhaim has posted comments on this change. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. Patch Set 1: revert of what patch? -- To view, visit http://gerrit.ovirt.org/32697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified_persistence: only consider bonds created/touched by vdsm .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/153/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sampling: do not produce stats for missing disks
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: do not produce stats for missing disks .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/152/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: unified_persistence: only consider bonds created/touched by vdsm .. unified_persistence: only consider bonds created/touched by vdsm When upgrading a system to unified persistence we were considering any non empty bond as a bond to persist under unified persistence. This was not consistent with our implementation of ifcfg.flush that only considers ifcfg files with the vdsm authoring header. The patch fixes the behavior by making ifcfg flush and unified_persistence upgrade consistent in it's ownership semantics, i.e., we will not touch nor consider for persistence files not markedly authored by vdsm. A side effect of the lack of consistency was that a bond that was providing connectivity to a machine could be made to be onboot no if it was not immediately the backing device of ovirtmgmt. Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22 Bug-Url: https://bugzilla.redhat.com/1128140 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/32703 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32769 --- M lib/vdsm/tool/unified_persistence.py 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem i...
Dan Kenigsberg has submitted this change and it was merged. Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps .. ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps Vdsm currently checks only /etc/redhat-release path which exists over fedora installation for ppc arch but not on PowerKVM platforms. Over PowerKVM platforms we should read /etc/ibm_powerkvm-release to retrieve the release version. Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/32444 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32574 --- M vdsm/caps.py 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: revert: libvirt is happy with redefinition of an existing nw...
Dan Kenigsberg has submitted this change and it was merged. Change subject: revert: libvirt is happy with redefinition of an existing nwfilter .. revert: libvirt is happy with redefinition of an existing nwfilter Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Bug-Url: https://bugzilla.redhat.com/1138807 Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/32691 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32696 --- M lib/vdsm/tool/nwfilter.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ab71951ae4edef750be9a4f944e3180d568c91 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sampling: do not produce stats for missing disks
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: do not produce stats for missing disks .. sampling: do not produce stats for missing disks Adding of a new disk using hotplug (hotplugDisk verb) can trigger an error during the stats reporting (getVmStats verb). This error is transient, so it was likely got unnoticed so far. When a disk is hot-plugged, VDSM correctly updates the list of the drives of a VM. When stats for such a VM are asked, VDSM iterates over the list of the drives of a VM, and looks up for disk samples of each drive. The stats are collected (by default) every 60s, and VDSM considers the oldest and the newest samples; so, until the oldest set of samples collected includes values for the hotplugged disk, we will have an error. We have a vulerabilility window up to (sampling_window * sampling_interval) in the worst case. With default values this is 2 * 60s = 120s. After that, everything goes back to normality, and the stats for the new disk are reported correctly. This patch fixes this issue by just ignoring stats for disks which are part of a VM, but for which samples aren't yet available. Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881 Bug-Url: https://bugzilla.redhat.com/1119051 Signed-off-by: Francesco Romani Reviewed-on: http://gerrit.ovirt.org/30029 Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/32749 --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/32749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sampling: do not produce stats for missing disks
Dan Kenigsberg has posted comments on this change. Change subject: sampling: do not produce stats for missing disks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
Dan Kenigsberg has posted comments on this change. Change subject: unified_persistence: only consider bonds created/touched by vdsm .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Force vdsm to stay with libvirt <= 1.2.7
oVirt Jenkins CI Server has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/151/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Force vdsm to stay with libvirt <= 1.2.7
oVirt Jenkins CI Server has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/65/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/282/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Force vdsm to stay with libvirt <= 1.2.7
oVirt Jenkins CI Server has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/64/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Force vdsm to stay with libvirt <= 1.2.7
Dan Kenigsberg has submitted this change and it was merged. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Force vdsm to stay with libvirt <= 1.2.7 Libvirt removed silent support for min_guarantee parameter when running on Qemu. This prevents us from starting any new VMs or migrating VMs to hosts with newer versions of libvirt. See https://bugzilla.redhat.com/show_bug.cgi?id=1122455 for the libvirt reasoning. This patch should force hosts to stay with older versions of libvirt until this is resolved. Label: ovirt-3.5-only Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32764 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Force vdsm to stay with libvirt <= 1.2.7
Dan Kenigsberg has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Force vdsm to stay with libvirt <= 1.2.7
Dan Kenigsberg has posted comments on this change. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
Antoni Segura Puimedon has posted comments on this change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
Patch Set 1:
In [2]: unified_persistence._getNetInfo()
Out[2]: ({}, {'bond11': {'nics': ['eth3', 'eth4'], 'options': 'miimon=150
mode=0'}})
Install new version
In [3]: reload(unified_persistence)
Out[3]:
In [4]: unified_persistence._getNetInfo()
Out[4]: ({}, {})
In [5]:
--
To view, visit http://gerrit.ovirt.org/32769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sampling: do not produce stats for missing disks
Francesco Romani has posted comments on this change.
Change subject: sampling: do not produce stats for missing disks
..
Patch Set 1: Verified+1
Verified the same way as master patch:
TOji> 15:10:17 root [~]$ vdsClient localhost getAllVmStats | grep disk
disks = {'vda': {'readLatency': '0', 'apparentsize': '11811160064',
'writeLatency': '35406502', 'imageID': 'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0',
'flushLatency': '103058324', 'readRate': '0.00', 'truesize': '11811160064',
'writeRate': '6660.92'}, 'hdc': {'readLatency': '0', 'apparentsize': '0',
'writeLatency': '0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '0',
'writeRate': '0.00'}}
hotplugged a new disk through Engine
TOji> 15:10:25 root [~]$ vdsClient localhost getAllVmStats | grep disk
disks = {'vda': {'readLatency': '0', 'apparentsize': '11811160064',
'writeLatency': '0', 'imageID': 'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0',
'flushLatency': '0', 'readRate': '0.00', 'truesize': '11811160064',
'writeRate': '0.00'}, 'vdb': {'readLatency': '0', 'apparentsize': '1073741824',
'writeLatency': '0', 'imageID': '84142b8c-7c06-4767-9ff9-16f43597fbad',
'flushLatency': '0', 'readRate': '0.00', 'truesize': '1073741824', 'writeRate':
'0.00'}, 'hdc': {'readLatency': '0', 'apparentsize': '0', 'writeLatency': '0',
'flushLatency': '0', 'readRate': '0.00', 'truesize': '0', 'writeRate': '0.00'}}
hotUNplugged a new disk through Engine
TOji> 15:16:27 root [~]$ vdsClient localhost getAllVmStats | grep disk
disks = {'vda': {'readLatency': '0', 'apparentsize': '11811160064',
'writeLatency': '0', 'imageID': 'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0',
'flushLatency': '0', 'readRate': '0.00', 'truesize': '11811160064',
'writeRate': '0.00'}, 'hdc': {'readLatency': '0', 'apparentsize': '0',
'writeLatency': '0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '0',
'writeRate': '0.00'}}
No error spotted in vdsm.log
--
To view, visit http://gerrit.ovirt.org/32749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Force vdsm to stay with libvirt <= 1.2.7
Dan Kenigsberg has submitted this change and it was merged. Change subject: Force vdsm to stay with libvirt <= 1.2.7 .. Force vdsm to stay with libvirt <= 1.2.7 Libvirt removed silent support for min_guarantee parameter when running on Qemu. This prevents us from starting any new VMs or migrating VMs to hosts with newer versions of libvirt. See https://bugzilla.redhat.com/show_bug.cgi?id=1122455 for the libvirt reasoning. This patch should force hosts to stay with older versions of libvirt until this is resolved. Label: ovirt-3.5-only Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32763 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e7ba73a5a8f1407b077754fc768653a6e29efc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
Antoni Segura Puimedon has posted comments on this change. Change subject: unified_persistence: only consider bonds created/touched by vdsm .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11446/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12390/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12235/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32769
to review the following change.
Change subject: unified_persistence: only consider bonds created/touched by vdsm
..
unified_persistence: only consider bonds created/touched by vdsm
When upgrading a system to unified persistence we were considering
any non empty bond as a bond to persist under unified persistence.
This was not consistent with our implementation of ifcfg.flush that
only considers ifcfg files with the vdsm authoring header.
The patch fixes the behavior by making ifcfg flush and
unified_persistence upgrade consistent in it's ownership semantics,
i.e., we will not touch nor consider for persistence files not
markedly authored by vdsm.
A side effect of the lack of consistency was that a bond that was
providing connectivity to a machine could be made to be onboot no
if it was not immediately the backing device of ovirtmgmt.
Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22
Bug-Url: https://bugzilla.redhat.com/1128140
Signed-off-by: Antoni S. Puimedon
Reviewed-on: http://gerrit.ovirt.org/32703
Reviewed-by: Dan Kenigsberg
---
M lib/vdsm/tool/unified_persistence.py
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/32769/1
diff --git a/lib/vdsm/tool/unified_persistence.py
b/lib/vdsm/tool/unified_persistence.py
index c59531c..1733c97 100644
--- a/lib/vdsm/tool/unified_persistence.py
+++ b/lib/vdsm/tool/unified_persistence.py
@@ -16,13 +16,13 @@
#
# Refer to the README and COPYING files for full details of the license
#
-
+import errno
import logging
from .. import utils
from ..config import config
from ..netconfpersistence import RunningConfig
-from ..netinfo import NetInfo, getIfaceCfg, getDefaultGateway
+from ..netinfo import NET_CONF_PREF, NetInfo, getIfaceCfg, getDefaultGateway
from . import expose
from .upgrade import apply_upgrade
@@ -116,7 +116,7 @@
bondings = {}
for bonding, bondingParams in netinfo.bondings.iteritems():
# If the bond is unused, skip it
-if not bondingParams['slaves']:
+if not bondingParams['slaves'] or not _owned(bonding):
continue
bondings[bonding] = {'nics': bondingParams['slaves']}
@@ -145,6 +145,20 @@
runningConfig.store()
+def _owned(devname):
+try:
+with open(NET_CONF_PREF + devname) as conf:
+content = conf.read()
+except IOError as ioe:
+if ioe.errno == errno.ENOENT:
+return False
+else:
+raise
+else:
+return (content.startswith('# Generated by VDSM version') or
+content.startswith('# automatically generated by vdsm'))
+
+
def isNeeded():
return config.get('vars', 'net_persistence') == 'unified'
--
To view, visit http://gerrit.ovirt.org/32769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure iSCSI iface.net_ifacename
oVirt Jenkins CI Server has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11445/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12389/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12234/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
