Change in vdsm[master]: tool: remove AUTHOR from vdsm-tool manual page.
mooli tayer has posted comments on this change. Change subject: tool: remove AUTHOR from vdsm-tool manual page. .. Patch Set 5: anybody understands those jenkins fialures on /create-rpms(fc20)|(fc21).*merged jobs? Locally rpm builds fine with this patch on fe20 (and el6.4) -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use with statement to take care of unclosed files
Yaniv Bronhaim has posted comments on this change. Change subject: use with statement to take care of unclosed files .. Patch Set 1: Code-Review+1 did you try grep '.read()' /usr/share/vdsm/* and see that you covered all the open calls ? -- To view, visit http://gerrit.ovirt.org/31717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c33b22aa9828245c4598622ae6870f13b797036 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/403/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/420/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12670/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2007/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12515/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 4: using template and not replace, remove debug print, rename CONF_VERSION LATEST_CONF_VERSION at tests. -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/33492/4/vdsm/storage/vdsm-lvm.rules.in
File vdsm/storage/vdsm-lvm.rules.in:
Line 20: # The libvirt image label is required to allow qemu to access volumes.
Libvirt
Line 21: # sets this label on volumes when starting a vm, but on recent EL and
Fedora
Line 22: # releases, the label is lost after refreshing a logical volume, and
vm get
Line 23: # paused. This rule ensures that the label exist after device changes.
See
Line 24: # https://bugzilla.redhat.com/1127460
What's the bz of the underlying component?
Line 25: #
Line 26: # TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax
is
Line 27: # supported. See https://bugzilla.redhat.com/1015300
Line 28:
--
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12516/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
Yaniv Bronhaim has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
Dan Kenigsberg has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 4: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
Dan Kenigsberg has submitted this change and it was merged. Change subject: tool-tests: use variable from conf version in template files. .. tool-tests: use variable from conf version in template files. Replace LATEST_CONF_VERSION with current value from libvirt configure. This will save having to update all toolTests_*.conf files each time we bump a version. Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/32713 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/toolTests.py M tests/toolTests_lconf_ssl.conf M tests/toolTests_libvirt_logrotate.conf M tests/toolTests_libvirtd.conf M tests/toolTests_qemu_sanlock.conf M tests/toolTests_qemu_ssl.conf 6 files changed, 16 insertions(+), 14 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.
mooli tayer has abandoned this change. Change subject: tool: bump CONF_VERSION to 4.17. .. Abandoned This patch is unwanted. We prefer to have old installations keep logging configuration, and apply change 31135 only to new ones. -- To view, visit http://gerrit.ovirt.org/32707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I496392fa3a69b3a83a3f9b3934248e0b4fb4dab6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/240/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4033/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/43/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/39/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/45/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/19/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: No need to 'import threading'
Ondřej Svoboda has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 1: Verified+1 VDSM compiles. -- To view, visit http://gerrit.ovirt.org/33497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
Hello Ondřej Svoboda, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33522 to review the following change. Change subject: vdsm: No need to 'import threading' .. vdsm: No need to 'import threading' This fixes the build after vdsm: making PM 'on' and 'off' sync. Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Signed-off-by: Ondřej Svoboda osvob...@redhat.com --- M vdsm/API.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/33522/1 diff --git a/vdsm/API.py b/vdsm/API.py index 6378f2c..7815c42 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -26,7 +26,6 @@ import sys import copy import time -import threading import logging from network.errors import ConfigNetworkError -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: No need to 'import threading'
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 1: Code-Review-1 Please resend with the Change-Id of http://gerrit.ovirt.org/#/c/33496/ -- To view, visit http://gerrit.ovirt.org/33497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
Eli Mesika has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm: No need to 'import threading' .. vdsm: No need to 'import threading' This fixes the build after vdsm: making PM 'on' and 'off' sync. Change-Id: Id306f8c897efd6985aaf260d168376c9f1f031e3 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33496 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Reviewed-on: http://gerrit.ovirt.org/33522 Reviewed-by: Eli Mesika emes...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/API.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 5: @dcaro, hi FYI: Different failures in create-rpms-* jobs. One of the configured repositories failed (epel-testing) and others -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: No need to 'import threading'
Ondřej Svoboda has abandoned this change. Change subject: vdsm: No need to 'import threading' .. Abandoned Yaniv pushed this one with the correct Change-Id (the same as in master). -- To view, visit http://gerrit.ovirt.org/33497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 2: Code-Review-1 Please repost with the same Change-Id as in master. -- To view, visit http://gerrit.ovirt.org/33489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: No need to 'import threading'
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: No need to 'import threading' .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/22/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/18/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/17/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/22/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id03208158486a8b0741dbe40d517f437a687fdbd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Nir Soffer has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/33492/4/vdsm/storage/vdsm-lvm.rules.in
File vdsm/storage/vdsm-lvm.rules.in:
Line 20: # The libvirt image label is required to allow qemu to access volumes.
Libvirt
Line 21: # sets this label on volumes when starting a vm, but on recent EL and
Fedora
Line 22: # releases, the label is lost after refreshing a logical volume, and
vm get
Line 23: # paused. This rule ensures that the label exist after device changes.
See
Line 24: # https://bugzilla.redhat.com/1127460
What's the bz of the underlying component?
That bz does not exists yet, since we don't know what is the underlying
component responsible for this. I think libvirt is the right component, as they
manage the label.
Line 25: #
Line 26: # TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax
is
Line 27: # supported. See https://bugzilla.redhat.com/1015300
Line 28:
--
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Move functionality from storage.misc
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 4: Code-Review-1 just fix multipath.py to work with utils -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c547e3ac2ecf19359c32f7e717ad7b098bfbca4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert 'Create default multipath.conf during install'
Yaniv Bronhaim has posted comments on this change. Change subject: Revert 'Create default multipath.conf during install' .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/30978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2da0442bbcc5e33123c47d0a9f1e825fe47d1cf Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Federico Simoncelli has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/33492/4/vdsm/storage/vdsm-lvm.rules.in
File vdsm/storage/vdsm-lvm.rules.in:
Line 20: # The libvirt image label is required to allow qemu to access volumes.
Libvirt
Line 21: # sets this label on volumes when starting a vm, but on recent EL and
Fedora
Line 22: # releases, the label is lost after refreshing a logical volume, and
vm get
Line 23: # paused. This rule ensures that the label exist after device changes.
See
Line 24: # https://bugzilla.redhat.com/1127460
That bz does not exists yet, since we don't know what is the underlying com
We have now the bz:
https://bugzilla.redhat.com/show_bug.cgi?id=1147910
Line 25: #
Line 26: # TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax
is
Line 27: # supported. See https://bugzilla.redhat.com/1015300
Line 28:
--
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
dump-bonding-defaults reads bonding option defaults (per mode) and saves them
to /var/lib/vdsm/bonding-defaults.json. VDSM loads the file once at runtime
and refers to this static information of defaults when reporting bonding
options of bonds in the system.
As the bonding defaults are bound to the used kernel it is the responsibility
of the packager (or the sysadmin in customized setups) to regenerate the file
by running (during the build, or installation, respectively):
vdsm-tool dump-bonding-defaults
It is currently not advised to run the tool on startup because NetworkManager
may ifup the reference bond, making the tool unable to determine all options.
Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142701
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M debian/vdsm-python.install
M debian/vdsm.install
M init/vdsmd_init_common.sh.in
M lib/vdsm/netinfo.py
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/dump_bonding_defaults.py
M tests/netinfoTests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/bonding-defaults.json
M vdsm/sudoers.vdsm.in
11 files changed, 543 insertions(+), 48 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/33528/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 0294be8..42f08c2 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -17,6 +17,7 @@
./usr/lib/python2.7/dist-packages/vdsm/sslutils.py
./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
./usr/lib/python2.7/dist-packages/vdsm/tool/dummybr.py
+./usr/lib/python2.7/dist-packages/vdsm/tool/dump_bonding_defaults.py
./usr/lib/python2.7/dist-packages/vdsm/tool/configurator.py
./usr/lib/python2.7/dist-packages/vdsm/tool/load_needed_modules.py
./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index c97b8dd..4a0b976 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -23,6 +23,7 @@
./lib/udev/rules.d/61-vdsm-lvm.rules
./usr/lib/python2.7/dist-packages/sos/plugins/vdsm.py
./usr/lib/python2.7/dist-packages/vdsmapi.py
+./var/lib/vdsm/bonding-defaults.json
./usr/libexec/vdsm/curl-img-wrap
./usr/libexec/vdsm/ovirt_functions.sh
./usr/libexec/vdsm/persist-vdsm-hooks
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 298b658..49e9f19 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -100,6 +100,11 @@
}
+task_dump_bonding_defaults(){
+${VDSM_TOOL} dump-bonding-defaults
+}
+
+
task_tune_system(){
@SYSCTL_PATH@ -q -p /etc/sysctl.d/vdsm.conf
}
@@ -228,6 +233,10 @@
case $1 in
--pre-start)
+# If dump_bonding_defaults is desired (for the uneliminable possibility
+# of added bonding options or tweaked kernel defaults) it has to be run
+# after load_needed_modules (modprobe bonding).
+# NetworkManager must not crash on nmcli conn delete.
run_tasks \
mkdirs \
configure_coredump \
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 5dc2cd6..f98dcea 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -24,12 +24,11 @@
from datetime import datetime
from functools import partial
from itertools import chain
+import json
import logging
import os
-import random
import shlex
import socket
-import string
import struct
from xml.dom import minidom
@@ -47,7 +46,7 @@
from . import libvirtconnection
from .netconfpersistence import RunningConfig
from .netlink import iter_addrs, iter_links
-from .utils import execCmd, memoized, CommandPath
+from .utils import memoized
NET_CONF_DIR = '/etc/sysconfig/network-scripts/'
@@ -69,6 +68,7 @@
BONDING_MASTERS = '/sys/class/net/bonding_masters'
BONDING_SLAVES = '/sys/class/net/%s/bonding/slaves'
BONDING_OPT = '/sys/class/net/%s/bonding/%s'
+BONDING_DEFAULTS = constants.P_VDSM_LIB + 'bonding-defaults.json'
BRIDGING_OPT = '/sys/class/net/%s/bridge/%s'
_BONDING_FAILOVER_MODES = frozenset(('1', '3'))
_BONDING_LOADBALANCE_MODES = frozenset(('0', '2', '4', '5', '6'))
@@ -78,7 +78,6 @@
))
_IFCFG_ZERO_SUFFIXED = frozenset(
('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
-_TEE_BINARY = CommandPath('tee', constants.EXT_TEE)
LIBVIRT_NET_PREFIX = 'vdsm-'
DEFAULT_MTU = '1500'
@@ -187,7 +186,7 @@
return opts
-def _realBondOpts(bond):
+def realBondOpts(bond):
Return a dictionary in the same format as bondOpts(). Exclude entries that
are not bonding options, e.g. 'ad_num_ports' or 'slaves'.
@@ -522,47 +521,14 @@
return paddr
-def _randomIfaceName():
-MAX_LENGTH = 15
-CHARS = string.ascii_lowercase +
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has abandoned this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Abandoned Submitted with a Change-Id different from master. Lesson learned, the correct command for submission is git-review -t tool-bondingdefaults-3.5 ovirt-3.5 -- To view, visit http://gerrit.ovirt.org/33489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 1: Verified+1 Code-Review-1 Yaniv, we do not want to push this now, please wait until 3.5.1 (I'll remove my -1 then and let you know). Reporting of bonding options works and we don't upset or are not upset by NetworkManager anymore. QoS unit tests and functional testSetupNetworksOverDhcpIface failed. Toni is aware of the former, I will try to debug the latter. These are unrelated. -- To view, visit http://gerrit.ovirt.org/33528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit/11/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/33528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11728/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12672/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12517/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: hotunplug spelling issue
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/33484/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 446: 'VM_getStats': {'ret': 'statsList'},
Line 447: 'VM_hotplugDisk': {'ret': 'vmList'},
Line 448: 'VM_hotplugNic': {'ret': 'vmList'},
Line 449: 'VM_hotunplugDisk': {'ret': 'vmList'},
Line 450: 'VM_hotunplugNic': {'ret': 'vmList'},
omg!
Line 451: 'VM_mergeStatus': {'ret': 'mergeStatus'},
Line 452: 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
Line 453: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Line 454: 'VM_getIoTunePolicy': {'ret': 'ioTunePolicyList'},
--
To view, visit http://gerrit.ovirt.org/33484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33529 to review the following change. Change subject: networkTests: BOND_NAME constant changed to bond11 .. networkTests: BOND_NAME constant changed to bond11 getVdsCaps on rhel6 reports bond0-4 as existing regardless of their true existence (see _report_legacy_bondings). This confuses the testing changes in upcoming patches, hence we prefer to test a bond name with no legacy burdens. Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa Signed-off-by: Petr Horáček phora...@redhat.com Reviewed-on: http://gerrit.ovirt.org/31332 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/33529/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 141b47b..cbc6d0a 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -46,7 +46,7 @@ NETWORK_NAME = 'test-network' VLAN_ID = '27' -BONDING_NAME = 'bond0' +BONDING_NAME = 'bond11' IP_ADDRESS = '240.0.0.1' IP_NETWORK = '240.0.0.0' IP_ADDRESS_IN_NETWORK = '240.0.0.50' -- To view, visit http://gerrit.ovirt.org/33529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add tests for hostdev module
Martin Polednik has abandoned this change. Change subject: vdsm: add tests for hostdev module .. Abandoned -- To view, visit http://gerrit.ovirt.org/31766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I15ba986c77ec710f6becd0244e86d27ec2023e27 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/32313/10/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 106: for name, params in libvirt_devices.items():
Line 107: if caps and params['capability'] not in caps:
Line 108: continue
Line 109:
Line 110: devices[name] = {'params': params}
if name in device_to_vm:
devices[name]['vmId'] = device_to_vm[name]
Line 111: try:
Line 112: devices[name]['vmId'] = device_to_vm[name]
Line 113: except KeyError:
Line 114: pass
--
To view, visit http://gerrit.ovirt.org/32313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has uploaded a new change for review.
Change subject: toolTests: Fix pyflakes error.
..
toolTests: Fix pyflakes error.
At change 32713 I introduced a pyflakes violation:
./tests/toolTests.py:309: undefined name 'Libvirt'
Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84
Signed-off-by: Mooli Tayer mta...@redhat.com
---
M tests/toolTests.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/33531/1
diff --git a/tests/toolTests.py b/tests/toolTests.py
index 058c038..67d9f6b 100644
--- a/tests/toolTests.py
+++ b/tests/toolTests.py
@@ -306,7 +306,8 @@
with open(os.path.join(dirName,
'toolTests_%s.conf' % type_)) as template:
data = template.read()
-data = data % {'LATEST_CONF_VERSION': Libvirt.CONF_VERSION}
+data = data % {
+'LATEST_CONF_VERSION': libvirt.Configurator.CONF_VERSION}
with open(self.test_env[file_], 'w') as testConf:
testConf.write(data)
--
To view, visit http://gerrit.ovirt.org/33531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
Antoni Segura Puimedon has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: Code-Review+1 Although I wouldn't say that it is to fix a pyflakes error, the code was erroneous before this patch. -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
Dan Kenigsberg has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: Code-Review+2 This time, please apply more care to verification. -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
oVirt Jenkins CI Server has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12518/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: BOND_NAME constant changed to bond11 .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33529/2//COMMIT_MSG Commit Message: Line 12: Line 13: This confuses the testing changes in upcoming Line 14: patches, hence we prefer to test a bond name with Line 15: no legacy burdens. Line 16: please explain why this is needed for a backport - do we really intend to backport these upcoming patches? Also, please first backport to ovirt-3.5 branch. Line 17: Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa Line 18: Signed-off-by: Petr Horáček phora...@redhat.com Line 19: Reviewed-on: http://gerrit.ovirt.org/31332 Line 20: Reviewed-by: Dan Kenigsberg dan...@redhat.com -- To view, visit http://gerrit.ovirt.org/33529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Francesco Romani has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33482/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 538: if isVdsmImage(vmDrive): Line 539: dStats['imageID'] = vmDrive.imageID Line 540: elif GUID in vmDrive: Line 541: dStats['lunGUID'] = vmDrive.GUID Line 542: if sInfo is not None and eInfo is not None and ( Just to make sure we are not hiding real errors - is eInfo expected to be N Yes, if a disk disappears - hotunplug being the easiest case I think. A disk disappearing is most likely the cause of the issue you faced - can you describe the flow so I can test this fix? Line 543: vmDrive.name in sInfo and vmDrive.name in eInfo): Line 544: # will be None if sampled during recovery Line 545: dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo, Line 546: sampleInterval)) Line 539: dStats['imageID'] = vmDrive.imageID Line 540: elif GUID in vmDrive: Line 541: dStats['lunGUID'] = vmDrive.GUID Line 542: if sInfo is not None and eInfo is not None and ( Line 543: vmDrive.name in sInfo and vmDrive.name in eInfo): The original code had unneeded parenthesis around the last two checks - thi No big deal aout the first two cleanups, will push them. Line 544: # will be None if sampled during recovery Line 545: dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo, Line 546: sampleInterval)) Line 547: except (AttributeError, TypeError, ZeroDivisionError): -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1700/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12519/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: checking again. -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: -Verified one sec -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
Meni Yakove has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
David Caro has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 5: Three issues I see: A real one related to the code: ./tests/toolTests.py:309: undefined name 'Libvirt' One related to stall yum metadata (or so it seems): failure: repodata/c5c33bcb408dc935d117c85c76835f93eaadde4a333523ebd404a8b9b9707f33-primary.sqlite.bz2 from epel-testing: [Errno 256] No more mirrors to try. And one related to gluster rpms on el6: error: lua script failed: [string %pretrans(glusterfs-libs-3.4.0.57rhs-1.el6_5.x86_64)]:40: bad argument #2 to 'error' (number expected, got boolean) The first you should fix, the second I should fix, and the third needs some input from someone from gluster, do you know anyone there on gluster? -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: hotunplug spelling issue .. jsonrpc: hotunplug spelling issue Bug-Url: https://bugzilla.redhat.com/1147458 Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/33484 Reviewed-by: Oved Ourfali oourf...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Meni Yakove myak...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/rpc/Bridge.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Meni Yakove: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: Verified+1 Ran on fe20 and el6.4: make clean make rpm NOSE_EXCLUDE=.* On el6.4: clean checkout. install rpms. $ sudo vdsm-tool removeConf ... $ sudo cat /etc/libvirt/libvirtd.conf| grep -i vdsm $ $ sudo vdsm-tool configure --force $ sudo cat /etc/libvirt/libvirtd.conf| grep -i vdsm ## beginning of configuration section by vdsm-4.13.0 ca_file=/etc/pki/vdsm/certs/cacert.pem cert_file=/etc/pki/vdsm/certs/vdsmcert.pem key_file=/etc/pki/vdsm/keys/vdsmkey.pem ## end of configuration section by vdsm-4.13.0 -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: hotunplug spelling issue
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: hotunplug spelling issue
Yaniv Bronhaim has submitted this change and it was merged. Change subject: jsonrpc: hotunplug spelling issue .. jsonrpc: hotunplug spelling issue Bug-Url: https://bugzilla.redhat.com/1147458 Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/33532 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/rpc/Bridge.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix pyflakes error.
mooli tayer has posted comments on this change. Change subject: toolTests: Fix pyflakes error. .. Patch Set 1: NO NOSE_EXCLUDE.* ! -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. qemuimg: Create qcow2 compat 0.10 images when converting existing images Commit 1f7c3ac2c handled only creation of new images. This patch adds the required -o compat=0.10 option when converting existing images. _supports_qcow2_compat() accepts a command argument and invokes the specific command to detect if the compat option is supported. Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Bug-Url: https://bugzilla.redhat.com/1139707 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33349 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33494 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/qemuimg.py 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, approved Federico Simoncelli: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Yaniv Bronhaim has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
Yaniv Bronhaim has posted comments on this change.
Change subject: Run configure during post install when upgrading from
vdsm-4.10.x
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/33450/3/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line 744:
Line 745: if grep -q '^vdsm-4\.10\.'
%{_localstatedir}/lib/%{vdsm_name}/upgraded_version;
Line 746: then
Line 747: %{_libexecdir}/%{vdsm_name}/upgrade_320_conf.sh configure
I'll add quotes
Line 748: fi
Line 749:
Line 750: %preun
Line 751: if [ $1 -eq 0 ]; then
--
To view, visit http://gerrit.ovirt.org/33450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/78/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/79/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: hotunplug spelling issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: hotunplug spelling issue .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5874/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4034/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/44/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/40/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/46/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/20/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: qemuimg: Create qcow2 compat 0.10 images
Tal Nisan has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: Guys, can we go forward with this patch? -- To view, visit http://gerrit.ovirt.org/33022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 5: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix undefined name usage introduced by 32713.
Dan Kenigsberg has submitted this change and it was merged. Change subject: toolTests: Fix undefined name usage introduced by 32713. .. toolTests: Fix undefined name usage introduced by 32713. pyflakes complained: ./tests/toolTests.py:309: undefined name 'Libvirt'. Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33531 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/toolTests.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. vdsm_reg: Make vdsm-reg persist the management bridge it creates In the vdsm_reg flow, for the oVirt node, the management bridge is created using addNetworks. This puts the management network in the RunningConfig ( /var/run/vdsm/netconf/nets ). Then it notifies the engine of the registration request. When the engine approves the request, it starts the deployment, part of which is to start vdsmd. In the common init tasks of vdsmd there is the restore_nets task that, if /var/run/vdsm/nets_restored does not exist, it will clear all the networks in RunningConfig and configure again those in PersistentConfig. The issue is that in a clean installation there won't be any PersistentConfig, and thus the system will lose connectivity. In order to solve this issue, the best course of action is to persist RunningConfig as PersistentConfig as soon as the management network has been created by vdsm-reg (and strictly before the registration request is sent to the engine). Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Bug-Url: https://bugzilla.redhat.com/1144639 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33411 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Run configure during pre install when upgrading from vdsm-4....
Yaniv Bronhaim has restored this change. Change subject: Run configure during pre install when upgrading from vdsm-4.10.x .. Restored better than having specific fix for 3.4 - http://gerrit.ovirt.org/#/c/33450/ -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Nir Soffer has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33482/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 538: if isVdsmImage(vmDrive): Line 539: dStats['imageID'] = vmDrive.imageID Line 540: elif GUID in vmDrive: Line 541: dStats['lunGUID'] = vmDrive.GUID Line 542: if sInfo is not None and eInfo is not None and ( Yes, if a disk disappears - hotunplug being the easiest case I think. A dis I don't remember what was the flow. I saw this when testing live storage migration (move disk while vm is running) with iscsi storage domains. Line 543: vmDrive.name in sInfo and vmDrive.name in eInfo): Line 544: # will be None if sampled during recovery Line 545: dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo, Line 546: sampleInterval)) -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
Dan Kenigsberg has submitted this change and it was merged. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. addNetwork script: Prevent empty bond and vlan from reaching RunningConfig The consumers of the addNetwork script pass empty parameters, e.g. in order to fill the positional arguments that the script takes. The problem with that is that those parameters were being passed to addNetwork without modification, and that includes the _alterNetworkConfig wrapper that makes addNetwork requests reach runningConfig (and eventually PersistentConfig). Due to the issue above, a stored network could contain entries like 'bonding': '' and 'vlan': '' that would mess with selective network restoration. Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Bug-Url: https://bugzilla.redhat.com/1144639 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33510 Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/api.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
Dan Kenigsberg has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Nir Soffer has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33482/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 539: dStats['imageID'] = vmDrive.imageID Line 540: elif GUID in vmDrive: Line 541: dStats['lunGUID'] = vmDrive.GUID Line 542: if (sInfo and vmDrive.name in sInfo and Line 543:eInfo and vmDrive.name in eInfo): I think pep8 would not like this, eInfo should be indented one extra space. Line 544: # will be None if sampled during recovery Line 545: dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo, Line 546: sampleInterval)) Line 547: except (AttributeError, TypeError, ZeroDivisionError): -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
Dan Kenigsberg has posted comments on this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Patch Set 3: Code-Review-1 Copying the old bash logic is unsustainable -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: addNetwork script: Prevent empty bond and vlan from reaching
RunningConfig
..
addNetwork script: Prevent empty bond and vlan from reaching RunningConfig
The consumers of the addNetwork script pass empty parameters, e.g.
in order to fill the positional arguments that the script takes. The
problem with that is that those parameters were being passed to
addNetwork without modification, and that includes the
_alterNetworkConfig wrapper that makes addNetwork requests reach
runningConfig (and eventually PersistentConfig).
Due to the issue above, a stored network could contain entries like
'bonding': '' and 'vlan': '' that would mess with selective network
restoration.
Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3
Bug-Url: https://bugzilla.redhat.com/1144639
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/network/api.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/33542/1
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 0565624..8b37808 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -752,6 +752,12 @@
kwargs = _parseKwargs(sys.argv[3:])
if 'nics' in kwargs:
kwargs['nics'] = kwargs['nics'].split(',')
+# Remove empty vlan and bonding so that they don't make it to
+# _alterRunningConfig
+if 'vlan' in kwargs and kwargs['vlan'] == '':
+del kwargs['vlan']
+if 'bonding' in kwargs and kwargs['bonding'] == '':
+del kwargs['bonding']
addNetwork(bridge, **kwargs)
elif sys.argv[1] == 'del':
bridge = sys.argv[2]
--
To view, visit http://gerrit.ovirt.org/33542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...
Dan Kenigsberg has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libguestfs: rename virtsparsify to guestfs
Martin Polednik has uploaded a new change for review.
Change subject: libguestfs: rename virtsparsify to guestfs
..
libguestfs: rename virtsparsify to guestfs
http://gerrit.ovirt.org/#/c/28328/16 added way to use libguestfs
virt-sparsify functionality to VDSM. In order to use more than just
sparsify, it's feasible to rename the module virtsparsify-guestfs and
use it for more future functionality.
Change-Id: I07a7f4d5ebd5d8c16df4a35904a8bdf80f77e7b9
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
R lib/vdsm/guestfs.py
M vdsm.spec.in
M vdsm/storage/image.py
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/33543/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 1158db2..d98254b 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -35,5 +35,5 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/vdsm-id.py
./usr/lib/python2.7/dist-packages/vdsm/utils.py
./usr/lib/python2.7/dist-packages/vdsm/vdscli.py
-./usr/lib/python2.7/dist-packages/vdsm/virtsparsify.py
+./usr/lib/python2.7/dist-packages/vdsm/guestfs.py
./usr/lib/python2.7/dist-packages/vdsm/xmlrpc.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 4bebf28..377d17a 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -35,7 +35,7 @@
sslutils.py \
utils.py \
vdscli.py \
- virtsparsify.py \
+ guestfs.py \
xmlrpc.py \
$(NULL)
diff --git a/lib/vdsm/virtsparsify.py b/lib/vdsm/guestfs.py
similarity index 100%
rename from lib/vdsm/virtsparsify.py
rename to lib/vdsm/guestfs.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cd1c0e4..dde6d31 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1228,7 +1228,7 @@
%{python_sitearch}/%{vdsm_name}/sslutils.py*
%{python_sitearch}/%{vdsm_name}/utils.py*
%{python_sitearch}/%{vdsm_name}/vdscli.py*
-%{python_sitearch}/%{vdsm_name}/virtsparsify.py*
+%{python_sitearch}/%{vdsm_name}/guestfs.py*
%{python_sitearch}/%{vdsm_name}/xmlrpc.py*
%{python_sitearch}/%{vdsm_name}/tool/__init__.py*
%if 0%{?with_systemd}
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 9855a26..974ba66 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -26,7 +26,7 @@
import volume
from vdsm import qemuimg
-from vdsm import virtsparsify
+from vdsm import guestfs
from sdc import sdCache
import sd
import misc
@@ -574,11 +574,11 @@
srcFormat = volume.fmt2str(srcVolume.getFormat())
dstFormat = volume.fmt2str(dstVolume.getFormat())
-virtsparsify.sparsify(srcVolume.getVolumePath(),
- tmpVolume.getVolumePath(),
- dstVolume.getVolumePath(),
- src_format=srcFormat,
- dst_format=dstFormat)
+guestfs.sparsify(srcVolume.getVolumePath(),
+ tmpVolume.getVolumePath(),
+ dstVolume.getVolumePath(),
+ src_format=srcFormat,
+ dst_format=dstFormat)
except Exception:
self.log.exception('Unexpected error sparsifying %s',
tmpVolUUID)
--
To view, visit http://gerrit.ovirt.org/33543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07a7f4d5ebd5d8c16df4a35904a8bdf80f77e7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix undefined name usage introduced by 32713.
oVirt Jenkins CI Server has posted comments on this change. Change subject: toolTests: Fix undefined name usage introduced by 32713. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/242/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5875/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4035/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/45/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/41/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/47/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/21/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
Martin Polednik has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 12: Verified+1 verified by * running ./run_tests_local hostdevTests.py * make check * in combination with http://gerrit.ovirt.org/#/c/32316/ (manually on the host) - works as expected -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libguestfs: rename virtsparsify to guestfs
Martin Polednik has abandoned this change. Change subject: libguestfs: rename virtsparsify to guestfs .. Abandoned -- To view, visit http://gerrit.ovirt.org/33543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I07a7f4d5ebd5d8c16df4a35904a8bdf80f77e7b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sysprep: implement virt-sysprep functionality
Martin Polednik has uploaded a new change for review.
Change subject: sysprep: implement virt-sysprep functionality
..
sysprep: implement virt-sysprep functionality
Virt-sysprep is a utility to mount qcow2/raw images and remove
host specific data on them. This patch allows virt-sysprep to be called
from within VDSM via sysprepImage verb.
Change-Id: I6815e101bd1f037bf21c9233b18e86f3667cce6e
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M client/vdsClient.py
M lib/vdsm/guestfs.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
8 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/33545/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index dafca9e..c52132e 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1370,6 +1370,13 @@
return status['status']['code'], status['status']['message']
return 0, status['uuid']
+def sysprepImage(self, args):
+(spUUID, sdUUID, imgUUID) = args
+status = self.s.sysprepImage(spUUID, sdUUID, imgUUID)
+if status['status']['code']:
+return status['status']['code'], status['status']['message']
+return 0, status['uuid']
+
def cloneImageStructure(self, args):
spUUID, sdUUID, imgUUID, dstSdUUID = args
image = self.s.cloneImageStructure(spUUID, sdUUID, imgUUID, dstSdUUID)
@@ -2533,6 +2540,11 @@
'free space on image to free space on storage '
'domain using virt-sparsify'
)),
+'sysprepImage': (serv.sysprepImage,
+ ('spUUID sdUUID imgUUID'
+ 'Erase host specific data from image using '
+ 'virt-sparsify'
+ )),
'cloneImageStructure': (serv.cloneImageStructure,
('spUUID sdUUID imgUUID dstSdUUID',
'Clone an image structure from a source '
diff --git a/lib/vdsm/guestfs.py b/lib/vdsm/guestfs.py
index dd1cfdd..0c5b361 100644
--- a/lib/vdsm/guestfs.py
+++ b/lib/vdsm/guestfs.py
@@ -25,6 +25,8 @@
# Fedora, EL6
_VIRTSPARSIFY = utils.CommandPath(virt-sparsify,
/usr/bin/virt-sparsify,)
+_VIRTSYSPREP = utils.CommandPath(virt-sysprep,
+ /usr/bin/virt-sysprep,)
class Error(Exception):
@@ -61,3 +63,21 @@
if rc != 0:
raise Error(rc, err)
+
+
+def sysprep(volume, vol_format=None):
+
+Sysprep the 'src_vol' volume (src_format) using libguestfs virt-sysprep
+
+volume: path of base volume
+format: format of base volume ('raw' or `qcow2')
+
+cmd = [_VIRTSPARSIFY.cmd, '-a ' + volume]
+
+if vol_format:
+cmd.extend((--format, vol_format))
+
+rc, _, err = utils.execCmd(cmd, deathSignal=signal.SIGKILL)
+
+if rc != 0:
+raise Error(rc, err)
diff --git a/vdsm/API.py b/vdsm/API.py
index a1129b3..767cba2 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -870,6 +870,10 @@
tmpVolUUID, dstSdUUID, dstImgUUID,
dstVolUUID)
+def sysprep(self, volUUID):
+return self._irs.sysprepImage(self._spUUID, self._sdUUID, self._UUID,
+ volUUID)
+
def cloneStructure(self, dstSdUUID):
return self._irs.cloneImageStructure(self._spUUID, self._sdUUID,
self._UUID, dstSdUUID)
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index f2dcbdf..df0c899 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -690,6 +690,10 @@
image = API.Image(imgUUID, spUUID, sdUUID)
return image.sparsify(tmpVolUUID, dstSdUUID, dstImgUUID, dstVolUUID)
+def imageSysprep(self, spUUID, sdUUID, imgUUID):
+image = API.Image(imgUUID, spUUID, sdUUID)
+return image.sparsify(imgUUID)
+
def imageCloneStructure(self, spUUID, sdUUID, imgUUID, dstSdUUID):
image = API.Image(imgUUID, spUUID, sdUUID)
return image.cloneStructure(dstSdUUID)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index cde80ff..a5e8e6f 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1638,6 +1638,20 @@
dstImgUUID, dstVolUUID)
@public
+def sysprepImage(self, spUUID, sdUUID, imgUUID, volUUID):
+
+Reduce sparse image size by converting free space on image to free
+space on storage domain using virt-sparsify.
+
+
+pool = self.getPool(spUUID)
+
+vars.task.getSharedLock(STORAGE, sdUUID)
+
+self._spmSchedule(spUUID, sysprepImage, pool.sparsifyImage,
+
Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...
oVirt Jenkins CI Server has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit/12/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/33542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestfs: rename virtsparsify to guestfs
Martin Polednik has uploaded a new change for review.
Change subject: guestfs: rename virtsparsify to guestfs
..
guestfs: rename virtsparsify to guestfs
Virt-sparsify was implemented as a single functionality from libguestfs
library, but in order to support more libguestfs functionality
without needing module for each functionality it makes sense to name
the module guestfs (without lib as the path itself is lib/vdsm/... -
lib/vdsm/guestfs.py)
Change-Id: Id2d965b74371db8e9112f47e8f31e5d24e9d4029
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
R lib/vdsm/guestfs.py
M vdsm.spec.in
M vdsm/storage/image.py
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/33544/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 1158db2..d98254b 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -35,5 +35,5 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/vdsm-id.py
./usr/lib/python2.7/dist-packages/vdsm/utils.py
./usr/lib/python2.7/dist-packages/vdsm/vdscli.py
-./usr/lib/python2.7/dist-packages/vdsm/virtsparsify.py
+./usr/lib/python2.7/dist-packages/vdsm/guestfs.py
./usr/lib/python2.7/dist-packages/vdsm/xmlrpc.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 4bebf28..377d17a 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -35,7 +35,7 @@
sslutils.py \
utils.py \
vdscli.py \
- virtsparsify.py \
+ guestfs.py \
xmlrpc.py \
$(NULL)
diff --git a/lib/vdsm/virtsparsify.py b/lib/vdsm/guestfs.py
similarity index 100%
rename from lib/vdsm/virtsparsify.py
rename to lib/vdsm/guestfs.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cd1c0e4..dde6d31 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1228,7 +1228,7 @@
%{python_sitearch}/%{vdsm_name}/sslutils.py*
%{python_sitearch}/%{vdsm_name}/utils.py*
%{python_sitearch}/%{vdsm_name}/vdscli.py*
-%{python_sitearch}/%{vdsm_name}/virtsparsify.py*
+%{python_sitearch}/%{vdsm_name}/guestfs.py*
%{python_sitearch}/%{vdsm_name}/xmlrpc.py*
%{python_sitearch}/%{vdsm_name}/tool/__init__.py*
%if 0%{?with_systemd}
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 9855a26..974ba66 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -26,7 +26,7 @@
import volume
from vdsm import qemuimg
-from vdsm import virtsparsify
+from vdsm import guestfs
from sdc import sdCache
import sd
import misc
@@ -574,11 +574,11 @@
srcFormat = volume.fmt2str(srcVolume.getFormat())
dstFormat = volume.fmt2str(dstVolume.getFormat())
-virtsparsify.sparsify(srcVolume.getVolumePath(),
- tmpVolume.getVolumePath(),
- dstVolume.getVolumePath(),
- src_format=srcFormat,
- dst_format=dstFormat)
+guestfs.sparsify(srcVolume.getVolumePath(),
+ tmpVolume.getVolumePath(),
+ dstVolume.getVolumePath(),
+ src_format=srcFormat,
+ dst_format=dstFormat)
except Exception:
self.log.exception('Unexpected error sparsifying %s',
tmpVolUUID)
--
To view, visit http://gerrit.ovirt.org/33544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2d965b74371db8e9112f47e8f31e5d24e9d4029
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Nir Soffer has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 5: Verified+1 Version 5 fix the comments to refer to the systemd-udevd bug url, and update the commit message. No behavior changes, copying the verified flag. -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 5: ps thanks dcaro -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...
Douglas Schilling Landgraf has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 5: The first was fixed 33531. regarding the gluster issue not really. Yaniv/Danken? -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33492/5/vdsm/storage/vdsm-lvm.rules.in
File vdsm/storage/vdsm-lvm.rules.in:
Line 23: # paused. This rule ensures that the label exist after device changes.
See
Line 24: # https://bugzilla.redhat.com/1147910
Line 25: #
Line 26: # TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax
is
Line 27: # supported. See https://bugzilla.redhat.com/1015300
Only after discussing this with Federico do I realize that this is a security
issue - it removes sVirt's protection against cross-qemu attacks.
Since the systemd bug is unrelated to el6, this patch has net negative affect
on el6 (which is still our main platform). Thus, it should not be merged as it
is now.
For Fedora/EL7 we have two bad options:
* keep thin provisioning broken, until https://bugzilla.redhat.com/1147910 is
fixed.
* effectively disable svirt. (which can be done in a simpler fashion, I
suppose, with a libvirtd.conf tweak).
Line 28:
Line 29: # add event is processed on coldplug only, so we need change, too.
Line 30: ACTION!=add|change, GOTO=lvm_end
Line 31:
--
To view, visit http://gerrit.ovirt.org/33492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates
..
vdsm_reg: Make vdsm-reg persist the management bridge it creates
In the vdsm_reg flow, for the oVirt node, the management bridge is
created using addNetworks. This puts the management network in the
RunningConfig ( /var/run/vdsm/netconf/nets ). Then it notifies the
engine of the registration request.
When the engine approves the request, it starts the deployment, part
of which is to start vdsmd. In the common init tasks of vdsmd there is
the restore_nets task that, if /var/run/vdsm/nets_restored does not
exist, it will clear all the networks in RunningConfig and configure
again those in PersistentConfig. The issue is that in a clean
installation there won't be any PersistentConfig, and thus the system
will lose connectivity.
In order to solve this issue, the best course of action is to persist
RunningConfig as PersistentConfig as soon as the management network
has been created by vdsm-reg (and strictly before the registration
request is sent to the engine).
Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Bug-Url: https://bugzilla.redhat.com/1144639
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm_reg/deployUtil.py.in
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/33541/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in
index ad91e54..34c671e 100644
--- a/vdsm_reg/deployUtil.py.in
+++ b/vdsm_reg/deployUtil.py.in
@@ -52,6 +52,7 @@
P_LIB_SYSTEMD = '/lib/systemd/systemd-'
P_ROOT_SSH = pwd.getpwnam('root').pw_dir + '/.ssh'
P_ROOT_AUTH_KEYS = P_ROOT_SSH + '/authorized_keys'
+P_VDSM_CONF = '/etc/vdsm/vdsm.conf'
P_VDSM_NODE_ID = '/etc/vdsm/vdsm.id'
P_SBIN = '/sbin/'
P_USR_BIN = '/usr/bin/'
@@ -85,6 +86,8 @@
ERR_NO_ROUTE = 7
SCRIPT_NAME_ADD = addNetwork
SCRIPT_NAME_DEL = delNetwork
+SCRIPT_NAME_GET_CONFIG = get-conf-item
+SCRIPT_NAME_STORE_NET_CONFIG = vdsm-store-net-config
IFACE_CONFIG = /etc/sysconfig/network-scripts/ifcfg-
MGT_BRIDGE_NAME = ovirtmgmt
REMOTE_SSH_KEY_FILE = ('/engine.ssh.key.txt',)
@@ -1109,8 +1112,24 @@
# Save current config by removing the undo files:
try:
-if fReturn and not fIsOvirt:
-setSafeVdsmNetworkConfig()
+if fReturn:
+if fIsOvirt:
+out, err, ret = _logExec(
+[os.path.join(vdsmDir, SCRIPT_NAME_GET_CONFIG),
+ P_VDSM_CONF, 'vars', 'net_persistence', 'ifcfg'])
+if ret:
+raise Exception('Failed to retrieve vdsm persistence '
+'mode. Stderr: %s' % err)
+
+net_persistence = out.strip()
+out, err, ret = _logExec(
+[os.path.join(vdsmDir, SCRIPT_NAME_STORE_NET_CONFIG),
+ net_persistence])
+if ret:
+raise Exception('Failed to persist vdsm networking '
+'configuration. Stderr: %s' % err)
+else:
+setSafeVdsmNetworkConfig()
except:
logging.debug(traceback.format_exc())
--
To view, visit http://gerrit.ovirt.org/33541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
Yaniv Bronhaim has abandoned this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Abandoned -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add functionality to acquire host devices
Martin Polednik has posted comments on this change.
Change subject: vdsm: add functionality to acquire host devices
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/32389/1/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 23:
Line 24: from vdsm import libvirtconnection
Line 25:
Line 26:
Line 27: DETACHABLE_DEVICES = ('usb', 'pci')
these are capabilities, not devices, right? if so, please rename.
agreed
Line 28:
Line 29:
Line 30: def _parse_device_params(device_xml):
Line 31: params = {}
Line 120:
Line 121: return devices
Line 122:
Line 123:
Line 124: def acquire(device_name):
What about this name? Libvirt calls the action detach. Why should not we?
This function is to be called inside device's constructor, the difference is
that the libvirt sees that stack from below:
[host [device1 device2 device3]] - libvirt really does dettach the device, but
from VDSM's pov:
[libvirt [device1 device2 device3]] - [vm1 vm2 vm3] here, we're acquiring the
device from libvirt and giving it to one of our VMs
Line 125: device =
libvirtconnection.get().nodeDeviceLookupByName(device_name)
Line 126: device_params = _parse_device_params(device)
Line 127:
Line 128: if device_params['capability'] in DETACHABLE_DEVICES:
Line 124: def acquire(device_name):
Line 125: device =
libvirtconnection.get().nodeDeviceLookupByName(device_name)
Line 126: device_params = _parse_device_params(device)
Line 127:
Line 128: if device_params['capability'] in DETACHABLE_DEVICES:
I'm a bit surprised: it is quite dangerous to silently ignore an action, ju
Acquire will be called by any device - even non-detachable (at least to get
device_params) and we therefore have to limit devices for which the real detach
is called
Line 129: device.dettach()
Line 130:
--
To view, visit http://gerrit.ovirt.org/32389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I530fed56831314286942b8afa62900208812bfb5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Log the correct error when creating a volume fails
Yeela Kaplan has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33301/1/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 435: srcVolUUID, volPath) Line 436: except (se.VolumeAlreadyExists, se.CannotCreateLogicalVolume) as e: Line 437: cls.log.error(Failed to create volume %s: %s, volPath, e) Line 438: vars.task.popRecovery() Line 439: raise e if you are already touching this code, then it will be a good to use only 'raise' so that we don't mess up with the original stack trace Line 440: # When the volume format is raw what the guest sees is the apparent Line 441: # size of the file/device therefore if the requested size doesn't Line 442: # match the apparent size (eg: physical extent granularity in LVM) Line 443: # we need to update the size value so that the metadata reflects -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/243/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5876/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4036/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/46/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/42/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/48/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/22/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: addNetwork script: Prevent empty bond and vlan from reaching...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. addNetwork script: Prevent empty bond and vlan from reaching RunningConfig The consumers of the addNetwork script pass empty parameters, e.g. in order to fill the positional arguments that the script takes. The problem with that is that those parameters were being passed to addNetwork without modification, and that includes the _alterNetworkConfig wrapper that makes addNetwork requests reach runningConfig (and eventually PersistentConfig). Due to the issue above, a stored network could contain entries like 'bonding': '' and 'vlan': '' that would mess with selective network restoration. Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Bug-Url: https://bugzilla.redhat.com/1144639 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33542 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm/network/api.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Log the correct error when creating a volume fails
Federico Simoncelli has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/25/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/21/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/20/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/25/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: remove AUTHOR from vdsm-tool manual page.
mooli tayer has uploaded a new change for review. Change subject: tool: remove AUTHOR from vdsm-tool manual page. .. tool: remove AUTHOR from vdsm-tool manual page. lists authors of the documentation or program. Use of an AUTHORS section is strongly discouraged. Generally, it is better not to clutter every page with a list of (over time potentially numer‐ ous) authors; if you write or significantly amend a page, add a copyright notice as a comment in the source file. If you are the author of a device driver and want to include an address for reporting bugs, place this under the BUGS section. see man 7 man-pages from the man-pages package . Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146469 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33455 Reviewed-by: Dan Kenigsberg dan...@redhat.com (cherry picked from commit 970e74691c172cbe25c8e1f47ec2d1fc43b9783c) --- M vdsm-tool/vdsm-tool.1.in 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/33548/1 diff --git a/vdsm-tool/vdsm-tool.1.in b/vdsm-tool/vdsm-tool.1.in index f64025b..68dfaf7 100644 --- a/vdsm-tool/vdsm-tool.1.in +++ b/vdsm-tool/vdsm-tool.1.in @@ -182,8 +182,6 @@ .B vdsm-id Prints the host UUID. .RE -.SH AUTHOR -Author list .SH BUGS Report bugs to http://bugzilla.redhat.com .SH COPYRIGHT -- To view, visit http://gerrit.ovirt.org/33548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: mooli tayer mta...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
oVirt Jenkins CI Server has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/47/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/43/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/49/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/23/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Log the correct error when creating a volume fails
Nir Soffer has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33301/1/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 435: srcVolUUID, volPath) Line 436: except (se.VolumeAlreadyExists, se.CannotCreateLogicalVolume) as e: Line 437: cls.log.error(Failed to create volume %s: %s, volPath, e) Line 438: vars.task.popRecovery() Line 439: raise e if you are already touching this code, then it will be a good to use only ' I will handle it in another patch. Line 440: # When the volume format is raw what the guest sees is the apparent Line 441: # size of the file/device therefore if the requested size doesn't Line 442: # match the apparent size (eg: physical extent granularity in LVM) Line 443: # we need to update the size value so that the metadata reflects -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: dump domain xml when change is detected
Francesco Romani has uploaded a new change for review.
Change subject: virt: dump domain xml when change is detected
..
virt: dump domain xml when change is detected
The Domain XML should not change often during the lifetime of a VM.
Nevertheless, it is greatly helpful to have up-to-date information
when troubleshooting issues.
This patch logs the domain XML whenever a change is detected, to improve
the debuggability of VDSM.
Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/33549/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ad8cb0e..e728902 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4492,8 +4492,11 @@
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
getElementsByTagName('devices')[0]
-self._devXmlHash = hash(devxml.toxml())
-
+xmlHash = hash(devxml.toxml())
+if xmlHash != self._devXmlHash:
+self.log.debug('changed device configuration:\n%s',
+ self._lastXMLDesc)
+self._devXmlHash = xmlHash
return self._lastXMLDesc
def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/33549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
