Change in vdsm[master]: dumpStorageTable: less statement-like prints
Ido Barkan has posted comments on this change. Change subject: dumpStorageTable: less statement-like prints .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01c8053e8545d033de2bfab34b0cade16de9823c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16182/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15382/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16352/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1158/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1060/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Dan Kenigsberg has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Ido Barkan has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16181/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15381/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16351/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1157/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1059/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16180/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15380/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16350/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1156/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1058/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16179/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15379/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16349/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1155/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1057/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2593/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16178/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15378/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16348/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1154/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Ido Barkan has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 2: -Code-Review (2 comments) https://gerrit.ovirt.org/#/c/38249/2//COMMIT_MSG Commit Message: Line 9: This implementation uses the SRIOV supporting libvirt API only Line 10: when agine is passing a MAC addredss for the interface. otherwise, Line 11: vdsm defaults to the standard host device API. Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF) Line 13: devices can be assigned in this manner. > SR-IOV devices -> SR-IOV network devices (other SR-IOV devices cannot be as Done Line 14: Line 15: Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hwclass.py File vdsm/virt/vmdevices/hwclass.py: Line 33: CONSOLE = 'console' Line 34: SMARTCARD = 'smartcard' Line 35: TPM = 'tpm' Line 36: HOSTDEV = 'hostdev' Line 37: INTERFACE = 'interface' > Also, do you really need your own hwclass? If you could use hostdev and onl I used host HostDevice. It's rebased on your changed. -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: children count of is 0 which broke a condition .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15377/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1153/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Dan Kenigsberg has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38179/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-26 18:45:59 +0200 Line 6: Line 7: virt: Avoid pointless extension requests Line 8: Line 9: When a drive was extended up to the maximum volume size, the current Consider a slight textual change. """ After a drive is extended to the maximum volume size, if the guest keeps writing, the image may pass the drive's watermark for early extension. On this condition, current ... Line 10: extend logic is trying to extend the drive every 2 seconds. This Line 11: results in fruitless extensions failing in lvextend because the Line 12: requested size is equal to the current size. These extension requests Line 13: may delay real requests, perform unneeded io, and fill up the log with -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: children count of is 0 which broke a condition .. Patch Set 2: There's nothing "exceptional" in bridge. We have VM networks and host-only network, and we can have an if-else to differ between the two. -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
Meni Yakove has posted comments on this change.
Change subject: netinfo: children count of is 0 which broke a
condition
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38294/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 112: for net, netname in allNets:
Line 113: if netname.startswith(LIBVIRT_NET_PREFIX):
Line 114: netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 115: nets[netname] = {}
Line 116: xml = etree.fromstring(net.XMLDesc(0))
> Why not use
try:
nets[netname]['iface'] = xml.find('.//interface').get('dev')
nets[netname]['bridged'] = False
except AttributeError:
nets[netname]['bridge'] = xml.find('.//bridge').get('name')
nets[netname]['bridged'] = True
Line 117: interface = xml.find('.//interface')
Line 118: if interface is not None:
Line 119: nets[netname]['iface'] = interface.get('dev')
Line 120: nets[netname]['bridged'] = False
--
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Genadi Chereshnya
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Meni Yakove
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
Meni Yakove has posted comments on this change.
Change subject: netinfo: children count of is 0 which broke a
condition
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38294/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 112: for net, netname in allNets:
Line 113: if netname.startswith(LIBVIRT_NET_PREFIX):
Line 114: netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 115: nets[netname] = {}
Line 116: xml = etree.fromstring(net.XMLDesc(0))
Why not use
try:
interface = xml.find('.//interface')
nets[netname]['iface'] = interface.get('dev')
nets[netname]['bridged'] = False
except AttributeError:
nets[netname]['bridge'] = xml.find('.//bridge').get('name')
nets[netname]['bridged'] = True
Line 117: interface = xml.find('.//interface')
Line 118: if interface is not None:
Line 119: nets[netname]['iface'] = interface.get('dev')
Line 120: nets[netname]['bridged'] = False
--
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Genadi Chereshnya
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Meni Yakove
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: children count of is 0 which broke a condition .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38294/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-02 19:06:51 +0100 Line 4: Commit: Ondřej Svoboda Line 5: CommitDate: 2015-03-02 20:58:20 +0100 Line 6: Line 7: netinfo: children count of is 0 which broke a condition could you add that nicless network is perfectly valid definition in Vdsm. We need a unit test for netinfo.networks(). Line 8: Line 9: Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: children count of is 0 which broke a condition .. Patch Set 2: Verified+1 This version (which correctly calls "interfaces" an "interface" now) runs as well as the previous one. -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: children count of is 0 which broke a c...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: children count of is 0 which broke a condition .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15376/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1152/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: 'interface' may be an empty element, so fix an exis...
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: 'interface' may be an empty element, so fix an
existence test
..
Patch Set 1: Verified+1
Functional tests can now run, before most of them errored out with:
Traceback (most recent call last):
File "/usr/share/vdsm/rpc/BindingXMLRPC.py", line 1162, in wrapper
res = f(*args, **kwargs)
File "/usr/share/vdsm/rpc/BindingXMLRPC.py", line 471, in getCapabilities
ret = api.getCapabilities()
File "/usr/share/vdsm/API.py", line 1286, in getCapabilities
c = caps.get()
File "/usr/share/vdsm/caps.py", line 645, in get
caps.update(netinfo.get())
File "/usr/lib/python2.7/site-packages/vdsm/netinfo.py", line 705, in get
libvirt_nets = networks()
File "/usr/lib/python2.7/site-packages/vdsm/netinfo.py", line 122, in
networks
nets[netname]['bridge'] = xml.find('.//bridge').get('name')
AttributeError: 'NoneType' object has no attribute 'get'
which was a consequence of the wrong test on non-emptiness of 'interface(s)'.
Looking at the name – it should be changed to just 'interface'.
--
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Genadi Chereshnya
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Meni Yakove
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: 'interface' may be an empty element, so fix an exis...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: 'interface' may be an empty element, so fix an existence test .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16175/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15375/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1151/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Genadi Chereshnya Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: 'interface' may be an empty element, so fix an exis...
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: 'interface' may be an empty element, so fix an
existence test
..
netinfo: 'interface' may be an empty element, so fix an existence test
A network's interface was previously obtained by getElementsByTagName() which
returns a list. ElementTree's find(), however, returns the first element of
such a list (unlike findall() which is a counterpart of getElementsByTagName).
Since the 'interface' element may be empty and its boolean value is tied to
the number of its subelements we have to check against None this time,
otherwise 0 (the length) is interpreted as a negative condition.
An example of an empty 'interface':
Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Signed-off-by: Ondřej Svoboda
---
M lib/vdsm/netinfo.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/38294/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 007f127..0e06503 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -115,7 +115,9 @@
nets[netname] = {}
xml = etree.fromstring(net.XMLDesc(0))
interfaces = xml.find('.//interface')
-if interfaces:
+# len() called on an empty Element like ""
+# returns 0 so we have to test against None
+if interfaces is not None:
nets[netname]['iface'] = interfaces.get('dev')
nets[netname]['bridged'] = False
else:
--
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: test: remove bond with removed enslaved nics
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: test: remove bond with removed enslaved nics .. network: test: remove bond with removed enslaved nics Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba656 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/38083 Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba656 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: fix network service status checking
Dan Kenigsberg has submitted this change and it was merged. Change subject: init: fix network service status checking .. init: fix network service status checking In init file, we check if network service is running by its status return code. Problem is, that this code is "always" 0, therefore we never start network service when needed (for example, it's not autostarted on CentOS 6). `service network status` returns lists of configured and active devices, if the list of active devices (on the last row) does not contains all VDSM's ONBOOT=yes devices, it means, that network service did not start our devices and we should call service network start. Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/38173 Reviewed-by: Dan Kenigsberg --- M init/sysvinit/vdsmd.init.in 1 file changed, 39 insertions(+), 2 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Remove AsyncChat
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Remove AsyncChat .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16174/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1150/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2592/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16173/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1073/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15373/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1149/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1056/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37097/4/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 88: if self.accepting: Line 89: self.handle_accept() Line 90: return Line 91: Line 92: if not self.connected: > please change to elif not just call parent Line 93: if self.connecting: Line 94: self.handle_connect_event() Line 95: Line 96: self.handle_read() -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37097/4/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 88: if self.accepting: Line 89: self.handle_accept() Line 90: return Line 91: Line 92: if not self.connected: please change to elif not Line 93: if self.connecting: Line 94: self.handle_connect_event() Line 95: Line 96: self.handle_read() -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Remove AsyncChat
Dan Kenigsberg has submitted this change and it was merged. Change subject: asyncore: Remove AsyncChat .. asyncore: Remove AsyncChat No one uses it. Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Signed-off-by: Saggi Mizrahi Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/37096 Reviewed-by: Dan Kenigsberg --- M lib/yajsonrpc/betterAsyncore.py 1 file changed, 0 insertions(+), 217 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Remove AsyncChat
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Remove AsyncChat .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Martin Polednik has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/38249/2//COMMIT_MSG
Commit Message:
Line 9: This implementation uses the SRIOV supporting libvirt API only
Line 10: when agine is passing a MAC addredss for the interface. otherwise,
Line 11: vdsm defaults to the standard host device API.
Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF)
Line 13: devices can be assigned in this manner.
> what do you mean?
SR-IOV devices -> SR-IOV network devices (other SR-IOV devices cannot be
assigned in this manner)
Line 14:
Line 15: Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 101:
Line 102: """
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
> from libvirt docs:
will try to formulate something, also related to generic passthrough (though
we're using default driver which for generic is VFIO)
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
> well, optional arguments are there so we can forget about them, arn't they?
have to admit that I thought we're consistent in this, but we aren't so feel
free to leave it as it is.
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 110:
https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hwclass.py
File vdsm/virt/vmdevices/hwclass.py:
Line 33: CONSOLE = 'console'
Line 34: SMARTCARD = 'smartcard'
Line 35: TPM = 'tpm'
Line 36: HOSTDEV = 'hostdev'
Line 37: INTERFACE = 'interface'
> Because you defined your own hwclass, you also need to reflect the routines
Also, do you really need your own hwclass? If you could use hostdev and only
use a mac as a flag (meaning you would break the rule of self.device -> xml
element for greater good) then no changes need to be done and nothing will be
forget from the routine.
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Remove AsyncChat
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: Remove AsyncChat .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/37096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Remove AsyncChat
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Remove AsyncChat .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib21fd40753bec81968528aad730c384823802b87 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: fix network service status checking
Petr Horáček has posted comments on this change. Change subject: init: fix network service status checking .. Patch Set 3: Verified+1 With this change network service is started when needed. -- To view, visit https://gerrit.ovirt.org/38173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
Yaniv Bronhaim has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37097/5/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 151: self._messageHandler = msgHandler
Line 152: self.check_read()
Line 153:
Line 154: def check_read(self):
Line 155: self._stompConn._dispatcher.handle_read_event()
indentation
Line 156:
Line 157: def send(self, message):
Line 158: self.log.debug("Sending response")
Line 159: res = stomp.Frame(stomp.Command.MESSAGE,
--
To view, visit https://gerrit.ovirt.org/37097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Dan Kenigsberg has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 297: """
Line 298: return getattr(
Line 299: self.__impl,
Line 300: "next_check_interval",
Line 301: lambda d: None
d->s would have hinted that the arg to this lambda is a "self"
Line 302: )(self)
Line 303:
Line 304: def recv(self, buffer_size):
Line 305: try:
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 399: n += 1
Line 400:
Line 401: return n
Line 402:
Line 403: def setHeartBeat(self, outgoing, incoming=0):
Please document that "outgoing" is in milliseconds.
Line 404: if incoming != 0:
Line 405: raise ValueError("incoming heart-beat not supported")
Line 406:
Line 407: self._update_outgoing_heartbeat()
Line 448: def next_check_interval(self, dispatcher):
Line 449: if self._outgoingHeartBeat == 0:
Line 450: return None
Line 451:
Line 452: return max(self._outgoing_heartbeat_expiration_interval, 0)
function call missing!
self._outgoing_heartbeat_expiration_interval()
The fact that this has passed without detection shows that the unit tests are
not good enough. Please improve.
Line 453:
Line 454: def handle_write(self, dispatcher):
Line 455: if self._outbuf is None:
Line 456: try:
--
To view, visit https://gerrit.ovirt.org/37057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: test: remove bond with removed enslaved nics
Petr Horáček has posted comments on this change. Change subject: network: test: remove bond with removed enslaved nics .. Patch Set 2: Verified+1 New test passes -- To view, visit https://gerrit.ovirt.org/38083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba656 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps.py: Drop support for Fedora 19
Michal Skrivanek has posted comments on this change. Change subject: caps.py: Drop support for Fedora 19 .. Patch Set 1: Code-Review+1 looks good to go? or what other F19 references you mean? -- To view, visit https://gerrit.ovirt.org/34191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/37055/6/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 364: Line 365: def process_requests(self): Line 366: self._isRunning = True Line 367: while self._isRunning: Line 368: asyncore.loop(use_poll=True, map=self._map, count=1, timeout=.5) Please reorder args (even when passing by name, life is easier when using the definition order) Line 369: Line 370: for key, dispatcher in self._map.items(): Line 371: del self._map[key] Line 372: dispatcher.close() -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules
Martin Polednik has posted comments on this change. Change subject: hostdev: fix creation and deletion of multiple udev rules .. Patch Set 2: Verified+1 Manually verified using detach/reattach on nic with 4 ports behind (unfortunately non-ACS) switch. The VFIO endpoints and rule files were spawned as expected, and removed after the test ran. -- To view, visit https://gerrit.ovirt.org/38208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move AsyncoreEvent to betterAsyncore
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Move AsyncoreEvent to betterAsyncore .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd3dc881091535328646ca1eeaac85f711885fc6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Bind the dispatcher implementation
Dan Kenigsberg has posted comments on this change. Change subject: betterAsyncore: Bind the dispatcher implementation .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/35252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If24df908104e3bf4e991f7b21b3459646286f581 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Bind the dispatcher implementation
Dan Kenigsberg has submitted this change and it was merged. Change subject: betterAsyncore: Bind the dispatcher implementation .. betterAsyncore: Bind the dispatcher implementation This patch modifies the way the implementation is accessed in the dispatcher. It binds all the methods on __init__() saving time during each method call. Change-Id: If24df908104e3bf4e991f7b21b3459646286f581 Signed-off-by: Saggi Mizrahi Reviewed-on: https://gerrit.ovirt.org/35252 Reviewed-by: Piotr Kliczewski Reviewed-by: Yaniv Bronhaim Reviewed-by: Yeela Kaplan Tested-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M lib/yajsonrpc/betterAsyncore.py 1 file changed, 31 insertions(+), 30 deletions(-) Approvals: Piotr Kliczewski: Verified; Looks good to me, but someone else must approve Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If24df908104e3bf4e991f7b21b3459646286f581 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change _AsyncoreEvent to use EventFD
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f035e9a0587f5f407ad0efe9353c53b7674ffd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
Dan Kenigsberg has posted comments on this change. Change subject: infra: Introduce EventFD support .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/37051/5/lib/vdsm/infra/eventfd/tests.py File lib/vdsm/infra/eventfd/tests.py: Line 37: efd = eventfd.EventFD(value) Line 38: tools.assert_equals(efd.read(), value) Line 39: Line 40: Line 41: def test_write(): Only the default flags=0 is being tested here. Line 42: value = 10 Line 43: efd = eventfd.EventFD() Line 44: efd.write(value) -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16172/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15372/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16342/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1148/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
Dan Kenigsberg has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/37051/5/lib/vdsm/infra/eventfd/__init__.py
File lib/vdsm/infra/eventfd/__init__.py:
Line 37:
Line 38: libc = ctypes.CDLL("libc.so.6", use_errno=True)
Line 39:
Line 40: EFD_SEMAPHORE = 0001,
Line 41: EFD_CLOEXEC = 0200,
please use modern octal literals 0o0200 etc
Line 42: EFD_NONBLOCK = 4000
Line 43:
Line 44:
Line 45: class EventFD(object):
Line 120: o
for symmetry: why is fd opened by libc, and closed by os.close(2)?
--
To view, visit https://gerrit.ovirt.org/37051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: make _should_keep_bridge robust against missing running...
Petr Horáček has posted comments on this change. Change subject: api: make _should_keep_bridge robust against missing running/persistent cfg .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13a225f406e6140463e1ded2008de8444fc4e9e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Ido Barkan has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/38249/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: network: support PCI passthrough of SR-IOV network interfaces.
Line 8:
Line 9: This implementation uses the SRIOV supporting libvirt API only
Line 10: when agine is passing a MAC addredss for the interface. otherwise,
> typo: engine, address, capital O
Done
Line 11: vdsm defaults to the standard host device API.
Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF)
Line 13: devices can be assigned in this manner.
Line 14:
Line 9: This implementation uses the SRIOV supporting libvirt API only
Line 10: when agine is passing a MAC addredss for the interface. otherwise,
Line 11: vdsm defaults to the standard host device API.
Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF)
Line 13: devices can be assigned in this manner.
> s/devices/network interfaces (in order to avoid collision with generic SR-I
what do you mean?
Line 14:
Line 15: Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 23: from . import hwclass
Line 24:
Line 25:
Line 26: class HostDevice(core.Base):
Line 27: __slots__ = ('name', '_deviceParams', '_mac_address')
> For the sake of consistence, I would use macAddr as in network.py.
Done
Line 28:
Line 29: def __init__(self, conf, log, **kwargs):
Line 30: super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: self._deviceParams = {}
Line 39: self._deviceParams = detach_detachable(self.name)
Line 40:
Line 41: def getXML(self):
Line 42: if self._mac_address:
Line 43: return self._build_network_host_device()
> What about _build_interface_xml and _build_generic_xml (and possibly create
Done
Line 44: else:
Line 45: return self._build_standard_host_device()
Line 46:
Line 47: def _build_standard_host_device(self):
Line 101:
Line 102: """
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
> What is the behaviour of having driver='vfio' on a host that doesn't suppor
from libvirt docs:
To use VFIO device assignment rather than traditional/legacy KVM device
assignment (VFIO is a new method of device assignment that is compatible with
UEFI Secure Boot), a type='hostdev' interface can have an optional driver
sub-element with a name attribute set to "vfio". To use legacy KVM device
assignment you can set name to "kvm" (or simply omit the element,
since "kvm" is currently the default)
So I am not sure. Can you ask libvirt mailing list what they suggest? I guess
this code will be called on SRIOV supporting hosts only.
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
> I would explicitely state that text=None.
well, optional arguments are there so we can forget about them, arn't they?
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 110:
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15371/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1147/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Michal Skrivanek has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Martin Polednik has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 4: Verified+1 Manually verified by inspecting caps on vtd host. -- To view, visit https://gerrit.ovirt.org/37701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] EVENTS
Yaniv Bronhaim has posted comments on this change. Change subject: [WIP] EVENTS .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38069/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 212: Line 213: def _createAcceptor(self, host, port): Line 214: sslctx = self._createSSLContext() Line 215: Line 216: self._acceptor = MultiProtocolAcceptor( having reactor instance in multiProtocolAcceptor should be one separate patch. please split Line 217: self._reactor, Line 218: host, Line 219: port, Line 220: sslctx Line 330: binding.start() Line 331: self.thread = threading.Thread( Line 332: target=self._reactor.process_requests, Line 333: name='Reactor thread' Line 334: ) not related Line 335: self.thread.setDaemon(True) Line 336: self.thread.start() Line 337: Line 338: def _getUUIDSpecPath(self, uuid): -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: fix creation and deletion of multiple udev rules .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15370/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1146/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Martin Polednik has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 2: Code-Review-1
(7 comments)
Also make sure you understand and implement the routine for such device, in
order to support unmanaged mode. As far as I understand, this should be
required as you're creating new hwclass - please see
https://gerrit.ovirt.org/#/c/37700/4/vdsm/virt/vm.py.
https://gerrit.ovirt.org/#/c/38249/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: network: support PCI passthrough of SR-IOV network interfaces.
Line 8:
Line 9: This implementation uses the SRIOV supporting libvirt API only
Line 10: when agine is passing a MAC addredss for the interface. otherwise,
typo: engine, address, capital O
Line 11: vdsm defaults to the standard host device API.
Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF)
Line 13: devices can be assigned in this manner.
Line 14:
Line 9: This implementation uses the SRIOV supporting libvirt API only
Line 10: when agine is passing a MAC addredss for the interface. otherwise,
Line 11: vdsm defaults to the standard host device API.
Line 12: Only SR-IOV (Single Root I/O Virtualization) virtual function (VF)
Line 13: devices can be assigned in this manner.
s/devices/network interfaces (in order to avoid collision with generic SR-IOV)
Line 14:
Line 15: Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 23: from . import hwclass
Line 24:
Line 25:
Line 26: class HostDevice(core.Base):
Line 27: __slots__ = ('name', '_deviceParams', '_mac_address')
For the sake of consistence, I would use macAddr as in network.py.
Line 28:
Line 29: def __init__(self, conf, log, **kwargs):
Line 30: super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: self._deviceParams = {}
Line 39: self._deviceParams = detach_detachable(self.name)
Line 40:
Line 41: def getXML(self):
Line 42: if self._mac_address:
Line 43: return self._build_network_host_device()
What about _build_interface_xml and _build_generic_xml (and possibly create
instead of build)? Because we're only creating XML elements, not really
building the device.
Line 44: else:
Line 45: return self._build_standard_host_device()
Line 46:
Line 47: def _build_standard_host_device(self):
Line 101:
Line 102: """
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
What is the behaviour of having driver='vfio' on a host that doesn't support
legacy passthrough? Does such host even support SR-IOV? It's possible that we
could simply omit this element.
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 103: interface = self.createXmlElem(hwclass.INTERFACE,
hwclass.HOSTDEV)
Line 104: interface.setAttrs(managed='no')
Line 105: interface.appendChildWithArgs('driver', name='vfio')
Line 106: source = interface.appendChildWithArgs('source')
Line 107: source.appendChildWithArgs('address',
**self._deviceParams['address'])
I would explicitely state that text=None.
Line 108: if self._mac_address:
Line 109: interface.appendChildWithArgs('mac',
address=self._mac_address)
Line 110:
https://gerrit.ovirt.org/#/c/38249/2/vdsm/virt/vmdevices/hwclass.py
File vdsm/virt/vmdevices/hwclass.py:
Line 33: CONSOLE = 'console'
Line 34: SMARTCARD = 'smartcard'
Line 35: TPM = 'tpm'
Line 36: HOSTDEV = 'hostdev'
Line 37: INTERFACE = 'interface'
Because you defined your own hwclass, you also need to reflect the routines of
host device on startup/vmdestroy and implement XML parsing - see
https://gerrit.ovirt.org/#/c/37700/4/vdsm/virt/vm.py
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1145/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1055/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16168/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15368/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1144/ : FAILURE -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
Darshan N has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 25: Verified+1 -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Nir Soffer has posted comments on this change.
Change subject: janitorial: introduce the 'response' module
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/37912/2/lib/vdsm/response.py
File lib/vdsm/response.py:
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21:
Line 22: from vdsm.define import errCode
In the next version it would be nice to move errCode here and call it ERRORS.
Line 23:
Line 24:
Line 25: def error(key, message=None):
Line 26: if not message:
Line 21:
Line 22: from vdsm.define import errCode
Line 23:
Line 24:
Line 25: def error(key, message=None):
key is little too abstract, "name" makes this more clear that we get the error
code by the error name.
Line 26: if not message:
Line 27: return errCode[key]
Line 28: else:
Line 29: return {'status':
Line 23:
Line 24:
Line 25: def error(key, message=None):
Line 26: if not message:
Line 27: return errCode[key]
Returning the mutable dict in errCode[key] is dangerous. The caller an modify
it by mistake and break the next response.
Line 28: else:
Line 29: return {'status':
Line 30: {'code': errCode[key]['status']['code'],
Line 27: return errCode[key]
Line 28: else:
Line 29: return {'status':
Line 30: {'code': errCode[key]['status']['code'],
Line 31: 'message': message}}
So:
status = errcode[key]["status"]
return {
"status": {
"code": status["code"],
"message": message or status["message"]
}
}
And we should kill errCode soon - there is no reason to keep this. we need a
dict of tuples {"name": (code, message), ...}
--
To view, visit https://gerrit.ovirt.org/37912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: remove _reportError
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: remove _reportError .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2591/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16337/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1143/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: make _should_keep_bridge robust against missing running...
Ido Barkan has posted comments on this change. Change subject: api: make _should_keep_bridge robust against missing running/persistent cfg .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13a225f406e6140463e1ded2008de8444fc4e9e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/170/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/170/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit/38/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: add the response.success() helper .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2590/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16166/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15366/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16336/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1142/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
Dan Kenigsberg has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. network: store non-Vdsm ifcfgs with unified persistence Unified restoration first removes everything in the running config and then tries to regenerate everything that's in the persisted config, problem is, that original devices are not persisted. In this patch we (temporarily) use ifcfg persistence for non-Vdsm devices (even when unified persistence is set), so we are able to restore them. Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Bug-Url: https://bugzilla.redhat.com/1197668 Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/37453 Reviewed-by: Ondřej Svoboda Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/38240 --- M vdsm/network/configurators/ifcfg.py M vdsm/vdsm-restore-net-config M vdsm/vdsm-store-net-config.in 3 files changed, 25 insertions(+), 11 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2589/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1141/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove obfuscated use of errCode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: remove obfuscated use of errCode .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2588/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16164/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15364/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1140/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/513/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2587/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15363/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16333/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1139/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1054/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
Dan Kenigsberg has submitted this change and it was merged. Change subject: api: correct the order of parameters in _bridge_reconfigured .. api: correct the order of parameters in _bridge_reconfigured The wrong order was harmless because both parameters are passed to != which is commutative. Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727 Signed-off-by: Ondřej Svoboda Reviewed-on: https://gerrit.ovirt.org/38256 Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M vdsm/network/api.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
Dan Kenigsberg has posted comments on this change. Change subject: api: correct the order of parameters in _bridge_reconfigured .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove obfuscated use of errCode
Francesco Romani has uploaded a new change for review.
Change subject: vm: remove obfuscated use of errCode
..
vm: remove obfuscated use of errCode
_changeBlockDev used to return error code in a funny
convoluted way. This patch simplifies it using a plain
unsurprising errCode usage, with no changes in the final
output.
Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/38267/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 3f194b0..cd90ae1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3741,9 +3741,7 @@
except Exception:
self.log.debug("updateDeviceFlags failed", exc_info=True)
self.cif.teardownVolumePath(drivespec)
-return {'status': {'code': errCode['changeDisk']['status']['code'],
- 'message': errCode['changeDisk']['status']
- ['message']}}
+return errCode['changeDisk']
if vmDev in self.conf:
self.cif.teardownVolumePath(self.conf[vmDev])
--
To view, visit https://gerrit.ovirt.org/38267
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: add the response.success() helper
..
janitorial: add the response.success() helper
This patch augments the response module with the success()
helper, so VDSM code has now a nicer and cleaner alternative
to the bare doneCode which was used before.
response.success() also allows caller code to augment the
response code with custom fields, as it is done many times
in Vm class.
Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a
Signed-off-by: Francesco Romani
---
M lib/vdsm/response.py
M vdsm/virt/vm.py
2 files changed, 41 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/38270/1
diff --git a/lib/vdsm/response.py b/lib/vdsm/response.py
index 7b0ba4e..aaac08e 100644
--- a/lib/vdsm/response.py
+++ b/lib/vdsm/response.py
@@ -19,7 +19,13 @@
#
-from vdsm.define import errCode
+from vdsm.define import doneCode, errCode
+
+
+def success(**kwargs):
+res = {'status': doneCode}
+res.update(kwargs)
+return res
def error(key, message=None):
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4be63ce..92cfac3 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -42,7 +42,7 @@
from vdsm import utils
from vdsm.compat import pickle
from vdsm.config import config
-from vdsm.define import ERROR, NORMAL, doneCode
+from vdsm.define import ERROR, NORMAL
from vdsm.netinfo import DUMMY_BRIDGE
from storage import outOfProcess as oop
from storage import sd
@@ -1600,7 +1600,7 @@
del self.conf['pauseCode']
except KeyError:
pass
-return {'status': doneCode, 'output': ['']}
+return response.success(output=[''])
finally:
if not guestCpuLocked:
self._guestCpuLock.release()
@@ -1617,7 +1617,7 @@
guestCpuLocked=True)
self._logGuestCpuStatus('pause')
self._lastStatus = afterState
-return {'status': doneCode, 'output': ['']}
+return response.success(output=[''])
finally:
if not guestCpuLocked:
self._guestCpuLock.release()
@@ -2368,7 +2368,7 @@
self.hotunplugNic({'nic': nicParams})
return response.error('hotplugNic', e.message)
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
def _lookupDeviceByAlias(self, devType, alias):
for dev in self._devices[devType][:]:
@@ -2426,7 +2426,7 @@
with self.setLinkAndNetwork(netDev, netConf, linkValue, network,
custom, specParams):
with self.updatePortMirroring(netConf, netsToMirror):
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
except (LookupError,
SetLinkAndNetworkError,
UpdatePortMirroringError) as e:
@@ -2597,7 +2597,7 @@
hooks.after_nic_hotunplug(nicXml, self.conf,
params=nic.custom)
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
def setNumberOfCpus(self, numberOfCpus):
@@ -2618,7 +2618,7 @@
self.conf['smp'] = str(numberOfCpus)
self.saveState()
hooks.after_set_num_of_cpus()
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
def updateVmPolicy(self, params):
"""
@@ -2714,7 +2714,7 @@
else:
return response.error('updateVmPolicyErr', e.message)
-return {'status': doneCode}
+return response.success()
def _getVmPolicy(self):
"""
@@ -2819,7 +2819,7 @@
found_device.name, xml)
found_device._deviceXML = xml
-return {'status': doneCode}
+return response.success()
def _createTransientDisk(self, diskParams):
if (diskParams.get('shared', None) !=
@@ -2903,7 +2903,7 @@
hooks.after_disk_hotplug(driveXml, self.conf,
params=drive.custom)
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
def hotunplugDisk(self, params):
if self.isMigrating():
@@ -2960,7 +2960,7 @@
params=drive.custom)
self._cleanupDrives(drive)
-return {'status': doneCode, 'vmList': self.status()}
+return response.success(vmList=self.status())
def _readPauseCode(self):
state, reason = self._dom.state(0)
@@ -3282,7 +3282,7 @@
# If all the drives are the current ones, r
Change in vdsm[master]: janitorial: vm: remove _reportError
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: vm: remove _reportError
..
janitorial: vm: remove _reportError
Vm._reportError was an early attempt to build what
we have now with response.error().
With the new code in place there is no more reason
to use it, so this patch removes it.
Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 15 insertions(+), 27 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/38269/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index cd392c7..4be63ce 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -42,7 +42,7 @@
from vdsm import utils
from vdsm.compat import pickle
from vdsm.config import config
-from vdsm.define import ERROR, NORMAL, doneCode, errCode
+from vdsm.define import ERROR, NORMAL, doneCode
from vdsm.netinfo import DUMMY_BRIDGE
from storage import outOfProcess as oop
from storage import sd
@@ -2650,15 +2650,15 @@
if not params:
self.log.error("updateVmPolicy got an empty policy.")
-return self._reportError(key='MissParam',
- msg="updateVmPolicy got an empty policy.")
+return response.error('MissParam',
+ 'updateVmPolicy got an empty policy.')
#
# Get the current QoS block
metadata_modified = False
qos = self._getVmPolicy()
if qos is None:
-return self._reportError(key='updateVmPolicyErr')
+return response.error('updateVmPolicyErr')
#
# Process provided properties, remove property after it is processed
@@ -2712,8 +2712,7 @@
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
return response.error('noVM')
else:
-return self._reportError(key='updateVmPolicyErr',
- msg=e.message)
+return response.error('updateVmPolicyErr', e.message)
return {'status': doneCode}
@@ -2771,9 +2770,9 @@
found_device = self._findDeviceByNameOrPath(device_name,
device_path)
if found_device is None:
-return self._reportError(
-key='updateIoTuneErr',
-msg="Device {} not found".format(device_name))
+return response.error(
+'updateIoTuneErr',
+"Device {} not found".format(device_name))
# Merge the update with current values
dom = found_device.getXML()
@@ -2799,8 +2798,7 @@
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
return response.error('noVM')
else:
-return self._reportError(key='updateIoTuneErr',
- msg=e.message)
+return response.error('updateIoTuneErr', e.message)
# Update both the ioTune arguments and device xml DOM
# so we are still up-to-date
@@ -3956,7 +3954,7 @@
def setBalloonTarget(self, target):
if self._dom is None:
-return self._reportError(key='balloonErr')
+return response.error('balloonErr')
try:
target = int(target)
self._dom.setMemory(target)
@@ -3980,8 +3978,8 @@
try:
self._dom.setSchedulerParameters({'vcpu_quota': int(quota)})
except ValueError:
-return self._reportError(key='cpuTuneErr',
- msg='an integer is required for period')
+return response.error('cpuTuneErr',
+ 'an integer is required for period')
except libvirt.libvirtError as e:
return self._reportException(key='cpuTuneErr', msg=e.message)
return {'status': doneCode}
@@ -3990,21 +3988,11 @@
try:
self._dom.setSchedulerParameters({'vcpu_period': int(period)})
except ValueError:
-return self._reportError(key='cpuTuneErr',
- msg='an integer is required for period')
+return response.error('cpuTuneErr',
+ 'an integer is required for period')
except libvirt.libvirtError as e:
return self._reportException(key='cpuTuneErr', msg=e.message)
return {'status': doneCode}
-
-def _reportError(self, key, msg=None):
-"""
-Produce an error status.
-"""
-if msg is None:
-error = errCode[key]
-else:
-error = response.error(key, msg)
-return error
def _reportException(self, key, msg=None):
"""
@@ -4012,7 +4000,7
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: vm: switch to response.error()
..
janitorial: vm: switch to response.error()
response.error() offers a nicer and cleaner
way to report error responses instead of the bare
errCode['something'], even when we are fine with
the default generic message.
This patch makes use of response.error() all across
vm.py.
Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 62 insertions(+), 62 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/38268/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e7fbcf2..cd392c7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1589,7 +1589,7 @@
if self.lastStatus in (vmstatus.MIGRATION_SOURCE,
vmstatus.SAVING_STATE, vmstatus.DOWN):
self.log.error('cannot cont while %s', self.lastStatus)
-return errCode['unexpected']
+return response.error('unexpected')
self._underlyingCont()
self._setGuestCpuRunning(self._isDomainRunning(),
guestCpuLocked=True)
@@ -1638,7 +1638,7 @@
def shutdown(self, delay, message, reboot, timeout, force):
if self.lastStatus == vmstatus.DOWN:
-return errCode['noVM']
+return response.error('noVM')
delay = int(delay)
@@ -1913,13 +1913,13 @@
try:
if self.isMigrating():
self.log.warning('vm already migrating')
-return errCode['exist']
+return response.error('exist')
if self.hasTransientDisks():
-return errCode['transientErr']
+return response.error('transientErr')
# while we were blocking, another migrationSourceThread could have
# taken self Down
if self._lastStatus == vmstatus.DOWN:
-return errCode['noVM']
+return response.error('noVM')
self._migrationSourceThread = migration.SourceThread(
self, **params)
self._migrationSourceThread.start()
@@ -1940,11 +1940,11 @@
return self._migrationSourceThread.status
except libvirt.libvirtError as e:
if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
-return errCode['migCancelErr']
+return response.error('migCancelErr')
raise
except AttributeError:
if self._dom is None:
-return errCode['migCancelErr']
+return response.error('migCancelErr')
raise
finally:
self._guestCpuLock.release()
@@ -2317,7 +2317,7 @@
def hotplugNic(self, params):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
nicParams = params['nic']
nic = vmdevices.network.Interface(self.conf, self.log, **nicParams)
@@ -2336,7 +2336,7 @@
nicXml = hooks.after_nic_hotplug_fail(
nicXml, self.conf, params=nic.custom)
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return errCode['noVM']
+return response.error('noVM')
return response.error('hotplugNic', e.message)
else:
# FIXME! We may have a problem here if vdsm dies right after
@@ -2524,7 +2524,7 @@
response['vmList'] = self.status()
return response
else:
-return errCode['updateDevice']
+return response.error('updateDevice')
def updateDevice(self, params):
if params.get('deviceType') == hwclass.NIC:
@@ -2532,11 +2532,11 @@
elif params.get('deviceType') == hwclass.GRAPHICS:
return self._updateGraphicsDevice(params)
else:
-return errCode['noimpl']
+return response.error('noimpl')
def hotunplugNic(self, params):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
nicParams = params['nic']
@@ -2583,7 +2583,7 @@
except libvirt.libvirtError as e:
self.log.exception("Hotunplug failed")
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return errCode['noVM']
+return response.error('noVM')
# Restore NIC device in vm's conf and _devices
if nicDev:
with self._confLock:
@@ -2602,7 +2602,7 @@
def setNumberOfCpus(self, numberOfCpus):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
self.log.debug("Setting number of c
Change in vdsm[master]: vm: rename vm.status() for clarity
Francesco Romani has posted comments on this change. Change subject: vm: rename vm.status() for clarity .. Patch Set 1: Code-Review-1 after bz1196327 we need a new approach here. Will keep only as reference, once new patches are posted will abandon. -- To view, visit https://gerrit.ovirt.org/34869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ed259f67eb83a0d73873309f94a1f0e30680963 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: introduce real status() method
Francesco Romani has posted comments on this change. Change subject: vm: introduce real status() method .. Patch Set 1: Code-Review-1 after bz1196327 we need a new approach here. Will keep only as reference, once new patches are posted will abandon. -- To view, visit https://gerrit.ovirt.org/34870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cea61b5f831d20e3da10c62d4092d296a1b6db4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Michal Skrivanek has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37509/7/vdsm/v2v.py File vdsm/v2v.py: Line 219: Line 220: def _handle_process_input(self, proc): Line 221: re_copy_disk = re.compile(r'.*(Copying disk \d+/\d+).*') Line 222: while not self._abort: Line 223: line = proc.stdout.readline() > This is my point exactly - parsing output should be separated from the flow well, we're parsing just one line with the copy progress, that's it Line 224: Line 225: if line == '': Line 226: self._handle_process_errors(proc) Line 227: break -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add missing empty line
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add missing empty line .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/288/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/665/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/292/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/292/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/282/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6511/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/696/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332a1a6b9323e00dd8e62eefc969e5d52660b9f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
Ido Barkan has posted comments on this change. Change subject: api: correct the order of parameters in _bridge_reconfigured .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: add method to get all registered VMs
Francesco Romani has posted comments on this change. Change subject: clientIF: add method to get all registered VMs .. Patch Set 19: Verified+1 trivial patch, also (at least partially) covered by tests. Will be good building block also to cleanup the getVMList situation. Verified through tests and while benchmarking the new bulk stats code. -- To view, visit https://gerrit.ovirt.org/36719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c6926b6bb3b5b14df8eb1ed59c347775422c1 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Darshan N has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
Ondřej Svoboda has posted comments on this change.
Change subject: api: correct the order of parameters in _bridge_reconfigured
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38256/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 753: if k not in ('bonding', 'nic', 'mtu'))
Line 754:
Line 755: def _bridge_reconfigured(current_conf, required_conf):
Line 756: return (_bridge_only_config(current_conf) !=
Line 757: _bridge_only_config(required_conf))
> nit: why the double change? only line 755 should be changed
I wanted to impose the same order both on parameters and on their usage in the
function. Personally, I find it easier to read.
Line 758:
Line 759: if currently_bridged and
_bridge_reconfigured(network_running_config,
Line 760: network_attrs):
Line 761: logging.debug("the bridge is being reconfigured")
--
To view, visit https://gerrit.ovirt.org/38256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
Ido Barkan has posted comments on this change.
Change subject: api: correct the order of parameters in _bridge_reconfigured
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38256/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 753: if k not in ('bonding', 'nic', 'mtu'))
Line 754:
Line 755: def _bridge_reconfigured(current_conf, required_conf):
Line 756: return (_bridge_only_config(current_conf) !=
Line 757: _bridge_only_config(required_conf))
nit: why the double change? only line 755 should be changed
Line 758:
Line 759: if currently_bridged and
_bridge_reconfigured(network_running_config,
Line 760: network_attrs):
Line 761: logging.debug("the bridge is being reconfigured")
--
To view, visit https://gerrit.ovirt.org/38256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add missing empty line
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add missing empty line .. tests: Add missing empty line Change-Id: I332a1a6b9323e00dd8e62eefc969e5d52660b9f0 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/38248 Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M tests/miscTests.py 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/38248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I332a1a6b9323e00dd8e62eefc969e5d52660b9f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add missing empty line
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add missing empty line .. Patch Set 2: I don't mind them -- To view, visit https://gerrit.ovirt.org/38248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332a1a6b9323e00dd8e62eefc969e5d52660b9f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add missing empty line
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add missing empty line .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332a1a6b9323e00dd8e62eefc969e5d52660b9f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: vm: graphics console listen on all ifs
Frank Kobzik has abandoned this change. Change subject: hooks: vm: graphics console listen on all ifs .. Abandoned -- To view, visit https://gerrit.ovirt.org/35661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Frank Kobzik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Petr Horáček has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 2: Code-Review+1 Verified+1 New test name's style breaks previous ones, but i like it more than camel case. Passed network's functional tests (new test passed only with this patch). Passed unit tests. -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
oVirt Jenkins CI Server has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15362/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1138/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: restore_nets: during rollback, ignore removal of a missing bond
Petr Horáček has posted comments on this change. Change subject: restore_nets: during rollback, ignore removal of a missing bond .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/38211/1//COMMIT_MSG Commit Message: Line 19: alraedy already https://gerrit.ovirt.org/#/c/38211/1/vdsm/network/api.py File vdsm/network/api.py: Line 585: > How about: if name not in _netinfo.bondings: you are right Line 594: % > should it be "% name" in place of "% bonding" ? yep, that was a problem -- To view, visit https://gerrit.ovirt.org/38211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b863ffd829026f9ea3030ac77e57cf6521fe6ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
Petr Horáček has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 1: Passed network's functional tests. Successfully restored rewritten non-vdsm devices. -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: store non-Vdsm ifcfgs with unified persistence
Petr Horáček has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
