Change in vdsm[master]: vm: drive: allow error policy fine tuning
Nir Soffer has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 8:
(6 comments)
https://gerrit.ovirt.org/#/c/38009/8/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 272: io=threads name=qemu type=raw/
Line 273:
Line 274:
Line 275: @permutations([['stop', 'stop'], ['report', 'report'],
Line 276: ['ignore', 'ignore'], ['enospace', 'enospace']])
We can simplify the permutations, as policy == expected:
@permuatations([[stop, report, ...])
def test_xxx(self, policy):
...
Line 277: @MonkeyPatch(utils, 'isBlockDevice', lambda path: False)
Line 278: def test_supported_policy(self, policy, expected):
Line 279: conf = drive_config(errorPolicy=policy)
Line 280: drive = Drive({}, self.log, **conf)
Line 275: @permutations([['stop', 'stop'], ['report', 'report'],
Line 276: ['ignore', 'ignore'], ['enospace', 'enospace']])
Line 277: @MonkeyPatch(utils, 'isBlockDevice', lambda path: False)
Line 278: def test_supported_policy(self, policy, expected):
Line 279: conf = drive_config(errorPolicy=policy)
Actually this test the combination of propagateErrors='off' and the new policy.
Line 280: drive = Drive({}, self.log, **conf)
Line 281: xml = find_xml_element(drive.getXML().toxml(), './driver')
Line 282: self.assertXMLEqual(xml, self.EXPECTED_XML % expected)
Line 283:
Line 281: xml = find_xml_element(drive.getXML().toxml(), './driver')
Line 282: self.assertXMLEqual(xml, self.EXPECTED_XML % expected)
Line 283:
Line 284: @permutations([['stop', 'stop'], ['report', 'report'],
Line 285: ['ignore', 'ignore'], ['enospace', 'enospace']])
Same as previous test
Line 286: @MonkeyPatch(utils, 'isBlockDevice', lambda path: False)
Line 287: def test_supported_policy_override_legacy(self, policy, expected):
Line 288: conf = drive_config(errorPolicy=policy, propagateErrors='on')
Line 289: drive = Drive({}, self.log, **conf)
Line 287: def test_supported_policy_override_legacy(self, policy, expected):
Line 288: conf = drive_config(errorPolicy=policy, propagateErrors='on')
Line 289: drive = Drive({}, self.log, **conf)
Line 290: xml = find_xml_element(drive.getXML().toxml(), './driver')
Line 291: self.assertXMLEqual(xml, self.EXPECTED_XML % expected)
The first two tests are identical, we can replace them with one test using
permutations:
@permutaions([
[stop, on], [stop, off],
[enospace, on], [enospace, off],
[report, on], [report, off],
[ignore, on], [ignore, off],
])
def test_policy(sefl, policy, propagateErrors):
...
Line 292:
Line 293: @permutations([[''], [None], [1], ['foobar']])
Line 294: @MonkeyPatch(utils, 'isBlockDevice', lambda path: False)
Line 295: def test_unsupported_policy(self, policy):
https://gerrit.ovirt.org/#/c/38009/8/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 354: driverAttrs['type'] = 'raw'
Line 355:
Line 356: driverAttrs['cache'] = self.cache
Line 357:
Line 358: self._setDriverAttrErrorPolicy(driverAttrs)
This would be nicer and more testable:
driverAttrs['error_policy'] = self.errorPolicy
@property
def errorPolicy(self):
if hasattr('_errorPolicy'):
return self._errorPolicy
else if (self.propagateErrors == 'on' or
utils.tobool(self.propagateErrors)):
return enospace
else:
return stop
Line 359:
Line 360: diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 361:
Line 362: if hasattr(self, 'specParams') and 'ioTune' in
self.specParams:
Line 369: return diskelem
Line 370:
Line 371: def _setDriverAttrErrorPolicy(self, driverAttrs):
Line 372: if hasattr(self, 'errorPolicy'):
Line 373: if self.errorPolicy in _ERROR_POLICIES:
Lets validate when setting errorPolicy. A drive raising in getXML() is not very
useful object.
@errorPolicy.setter
def errorPolicy(self, value):
if value not in _ERROR_POLICIES:
raise ...
self._errorPolicy = value
Line 374: driverAttrs['error_policy'] = self.errorPolicy
Line 375: else:
Line 376: raise ValueError(unsupported Error Policy '%s,
Line 377: self.errorPolicy)
--
To view, visit https://gerrit.ovirt.org/38009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1234ab15fc87ad75dfeae197d058eec23accbc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: rebased. No code changes (as gerrit itself confirms) so I don't know why score was lost. -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15518/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16488/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16492/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: add the response.success() helper .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15521/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16491/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
Francesco Romani has posted comments on this change. Change subject: janitorial: add the response.success() helper .. Patch Set 6: addressed comments from Nir. -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: remove _reportError
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: remove _reportError .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16490/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38268/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-23 18:22:11 +0100 Line 4: Commit: Francesco Romani from...@redhat.com Line 5: CommitDate: 2015-03-06 09:39:58 +0100 Line 6: Line 7: janitorial: vm: switch to response.error() janitorial: - vm: Line 8: Line 9: response.error() offers a nicer and cleaner Line 10: way to report error responses instead of the bare Line 11: errCode['something'], even when we are fine with -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: switch to response.error()
Francesco Romani has posted comments on this change. Change subject: vm: switch to response.error() .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38268/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-23 18:22:11 +0100 Line 4: Commit: Francesco Romani from...@redhat.com Line 5: CommitDate: 2015-03-06 09:39:58 +0100 Line 6: Line 7: janitorial: vm: switch to response.error() janitorial: - vm: Done Line 8: Line 9: response.error() offers a nicer and cleaner Line 10: way to report error responses instead of the bare Line 11: errCode['something'], even when we are fine with -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16331/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15531/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16501/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Francesco Romani has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38449/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-06 12:41:58 +0100 Line 4: Commit: pkliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-03-06 14:53:32 +0100 Line 6: Line 7: api: introducing short parameter for getVMList verb s/short/onlyUUID Line 8: Line 9: Due to vdsm sending only an array of vmids in a response to getVMList Line 10: the engine asks separately using VM.getStats which creates unnecessery Line 11: load. In order to fix this issue we introduce new parameter 'onlyUUID' -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing onlyUUID parameter for getVMList verb
Dan Kenigsberg has posted comments on this change. Change subject: api: introducing onlyUUID parameter for getVMList verb .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing onlyUUID parameter for getVMList verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: introducing onlyUUID parameter for getVMList verb .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15535/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16505/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15534/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16504/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Francesco Romani has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 3: Code-Review+1 thanks for the changes -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in vmpowerdown
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: use the response module in vmpowerdown
..
janitorial: use the response module in vmpowerdown
This patch makes vmpowerdown.py use the response
module.
Change-Id: I314d4b15eb6c6104cc7bb2e58ad07ca08d868c66
Signed-off-by: Francesco Romani from...@redhat.com
---
M lib/vdsm/response.py
M tests/responseTests.py
M vdsm/virt/vmpowerdown.py
3 files changed, 15 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/38445/1
diff --git a/lib/vdsm/response.py b/lib/vdsm/response.py
index bded95e..0984680 100644
--- a/lib/vdsm/response.py
+++ b/lib/vdsm/response.py
@@ -22,10 +22,10 @@
from vdsm.define import errCode
-def success(**kwargs):
+def success(message=None, **kwargs):
kwargs[status] = {
code: 0,
-message: Done
+message: message or Done
}
return kwargs
diff --git a/tests/responseTests.py b/tests/responseTests.py
index 3579b45..c806445 100644
--- a/tests/responseTests.py
+++ b/tests/responseTests.py
@@ -52,6 +52,14 @@
self.assertEqual(res, {status: doneCode})
+def test_success_with_message(self):
+MESSAGE = the message was overwritten
+res = response.success(message=MESSAGE)
+
+template = doneCode
+self.assertEqual(res[status][code], template[code])
+self.assertEqual(res[status][message], MESSAGE)
+
def test_success_with_args(self):
res = response.success(a=1, b=2)
diff --git a/vdsm/virt/vmpowerdown.py b/vdsm/virt/vmpowerdown.py
index 2382a88..aae927d 100644
--- a/vdsm/virt/vmpowerdown.py
+++ b/vdsm/virt/vmpowerdown.py
@@ -19,8 +19,8 @@
#
import libvirt
+from vdsm import response
from vdsm import utils
-from vdsm.define import doneCode, errCode
class VmPowerDown(object):
@@ -69,15 +69,12 @@
self.event.clear()
self.chain.start()
-return {'status': {'code': doneCode['code'],
- 'message': self.returnMsg}}
+return response.success(message=self.returnMsg)
else:
# No tools, no ACPI
-return {
-'status': {
-'code': errCode['exist']['status']['code'],
-'message': 'VM without ACPI or active oVirt guest agent. '
- 'Try Forced Shutdown.'}}
+return response.error('exist',
+ message='VM without ACPI or active oVirt '
+ 'guest agent. Try Forced Shutdown.')
class VmShutdown(VmPowerDown):
--
To view, visit https://gerrit.ovirt.org/38445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I314d4b15eb6c6104cc7bb2e58ad07ca08d868c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15517/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16487/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in vmpowerdown
Nir Soffer has posted comments on this change.
Change subject: janitorial: use the response module in vmpowerdown
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/38445/1/lib/vdsm/response.py
File lib/vdsm/response.py:
Line 24:
Line 25: def success(message=None, **kwargs):
Line 26: kwargs[status] = {
Line 27: code: 0,
Line 28: message: message or Done
Should move into the patch adding the response.success()
Line 29: }
Line 30: return kwargs
Line 31:
Line 32:
https://gerrit.ovirt.org/#/c/38445/1/tests/responseTests.py
File tests/responseTests.py:
Line 57: res = response.success(message=MESSAGE)
Line 58:
Line 59: template = doneCode
Line 60: self.assertEqual(res[status][code], template[code])
Line 61: self.assertEqual(res[status][message], MESSAGE)
This should move into the patch adding response.success()
Line 62:
Line 63: def test_success_with_args(self):
Line 64: res = response.success(a=1, b=2)
Line 65:
https://gerrit.ovirt.org/#/c/38445/1/vdsm/virt/vmpowerdown.py
File vdsm/virt/vmpowerdown.py:
Line 73: else:
Line 74: # No tools, no ACPI
Line 75: return response.error('exist',
Line 76: message='VM without ACPI or active
oVirt '
Line 77: 'guest agent. Try Forced
Shutdown.')
Can move into the patch replacing doneCode with response.success()
Line 78:
Line 79:
Line 80: class VmShutdown(VmPowerDown):
Line 81: returnMsg = 'Machine shutting down'
--
To view, visit https://gerrit.ovirt.org/38445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314d4b15eb6c6104cc7bb2e58ad07ca08d868c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: janitorial: use the response module
Nir Soffer has posted comments on this change. Change subject: v2v: janitorial: use the response module .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in migration
Nir Soffer has posted comments on this change. Change subject: janitorial: use the response module in migration .. Patch Set 1: Code-Review+1 Can we merge all the patches using response.success() into same patch? -- To view, visit https://gerrit.ovirt.org/38446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4642a1f0e0544e8d78cba6865425e14f63eea5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Michal Skrivanek has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38449/2/vdsm/API.py
File vdsm/API.py:
Line 1386: ret = {'status': doneCode,
Line 1387:'vmList': [v.status(fullStatus)
Line 1388: for v in self._cif.vmContainer.values()
Line 1389: if not vmSet or v.id in vmSet]}
Line 1390: if short:
Please add a
# REQUIRED_FOR: engine-3.5.0 only
Line 1391: return {'status': doneCode,
Line 1392: 'vmList': [v['vmId'] for v in ret['vmList']]}
Line 1393: return ret
Line 1394:
--
To view, visit https://gerrit.ovirt.org/38449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of IO statistics
Dan Kenigsberg has posted comments on this change. Change subject: virt: Additional reporting of IO statistics .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of IO statistics
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Additional reporting of IO statistics .. virt: Additional reporting of IO statistics As per request, we're now additionally reporting: - Read and write operations per VM and disk - Read and written bytes per VM and disk Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Bug-Url: https://bugzilla.redhat.com/1172153 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38366 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vm.py 2 files changed, 20 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Martin Polednik has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 11: Verified+1 addressed comment, other than that verification still the same -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Dan Kenigsberg has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38412/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 484: stats['cpuUser'] = self._usagePercentage( Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) unlike _usagePercentage(), we have no chance of ZeroDivisionError here. Even TypeError can be ruled out as of line 476. So please place out of try-block. Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + I do not think we care about cpu_time. According to our own docs (I did not dive into libvirt's, so please verify) it is the wall time spent by the VM. We do not care about this, if the guest laid dormant. This feature is about reporting the resources consumed by the VM, which is the sum of user and system time. Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 493: self._log.exception(CPU stats not available: %s, e) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: add hostdev device definition .. hostdev: add hostdev device definition Using hostdev infrastructure for attaching a detaching devices to/from host and passing them to VMs, this patch introduces the device endpoint that is used for passing devices to VMs via libvirt's hostdev element Change-Id: I51f6713cf76914d8626718071598421bc1731722 Signed-off-by: Martin Polednik mpoled...@redhat.com Reviewed-on: https://gerrit.ovirt.org/37700 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M vdsm.spec.in M vdsm/hostdev.py M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vm.py M vdsm/virt/vmdevices/Makefile.am M vdsm/virt/vmdevices/__init__.py A vdsm/virt/vmdevices/hostdevice.py M vdsm/virt/vmdevices/hwclass.py 9 files changed, 215 insertions(+), 13 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 11: Code-Review+2 Raising Francesco's score. Thanks. -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logs: improve VDSM logs human-readability
Michal Skrivanek has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: yeah, the patch looks orphaned...Yoav, ping? -- To view, visit https://gerrit.ovirt.org/28869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Marina Kalinin m...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Francesco Romani has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38449/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3605: # @fullStatus: #optional When set to False return limited info Line 3606: # Line 3607: # @vmList: #optional Filter the results by a list of UUIDs Line 3608: # Line 3609: # @short: #optional determines whether we need short of full status It would be more noble to define VmInfo as +1 Dan's suggestion here also address my comment below Line 3610: # Line 3611: # Returns: Line 3612: # A list of VmInfos Line 3613: # -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Francesco Romani has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Francesco Romani has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 2:
(3 comments)
I think we can't do much better considering the timeline. But I think we should
improve a bit the docs in this patch, to make loud and clear that we must
remove this and do things properly and safely for 3.6.x.
Let's just improve docs then. This way current verification will still be valid.
https://gerrit.ovirt.org/#/c/38449/2/vdsm/API.py
File vdsm/API.py:
Line 1388: for v in self._cif.vmContainer.values()
Line 1389: if not vmSet or v.id in vmSet]}
Line 1390: if short:
Line 1391: return {'status': doneCode,
Line 1392: 'vmList': [v['vmId'] for v in ret['vmList']]}
I believe I see why you do that here and why you do it this way - we are
extremely tight on time, and basically just moving the code which was in
Brdige.py seems the safer way.
I can't offer better alternatives given the current constraints, but I think it
is fair enough to ask to
add a comment here mentioning the relevant BZs, to
make very loud and clear why we found ourselves in need to add such an ugly
workaround.
Something like
BZ#XYZABC workaround to ensure backward compatibility with
3.5.x Engines or whatever wording you prefer
Line 1393: return ret
Line 1394:
Line 1395: def getExternalVMs(self, uri, username, password):
Line 1396:
https://gerrit.ovirt.org/#/c/38449/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3605: # @fullStatus: #optional When set to False return limited info
Line 3606: #
Line 3607: # @vmList: #optional Filter the results by a list of UUIDs
Line 3608: #
Line 3609: # @short: #optional determines whether we need short of full
status
this documentation could be improved, because we need to reduce the future
risk. We need to convey that this applies only if fullStatus=False. So, what
about something like:
if returning limited info, limits the output only to the bare minimum
information, a list of UUIDs of the running VMs
wording can be improved of course.
Line 3610: #
Line 3611: # Returns:
Line 3612: # A list of VmInfos
Line 3613: #
Line 3614: # Since: 4.10.0
Line 3615: ##
Line 3616: {'command': {'class': 'Host', 'name': 'getVMList'},
Line 3617: 'data': {'*fullStatus': 'bool','*vmList': ['UUID'], '*short':
'bool'},
Line 3618: 'returns': ['VmInfo']}
please note that this is now a lie, because if
fullStatus=False and short=True the output will be an undocumented list of
strings.
We know why, we know why it is hard to fix, but we should document this to
avoid further damage, IMO.
Line 3619:
Line 3620: ##
Line 3621: # @GuestDiskMappingInfo:
Line 3622: #
--
To view, visit https://gerrit.ovirt.org/38449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Vinzenz Feenstra has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: Even though vdsClient is a tempting reason, it could also do count itself ;-) But just btw I think that this patch is the wrong place to discuss the RFE, that should be done in the link BUG IMHO -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1105/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15533/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1088/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drive: allow error policy fine tuning
Martin Polednik has posted comments on this change. Change subject: vm: drive: allow error policy fine tuning .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1234ab15fc87ad75dfeae197d058eec23accbc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ravi Nori rn...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of IO statistics
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of IO statistics .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Martin Polednik has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/37700/10/vdsm/hostdev.py File vdsm/hostdev.py: Line 185: def detach_detachable(device_name, only_get_params=False): Line 186: libvirt_device, device_params = _get_device_ref_and_params(device_name) Line 187: Line 188: if only_get_params: Line 189: return device_params I think it would be better (= nicer and more readable) if we instead add a very true, done! Line 190: Line 191: iommu_group = device_params['iommu_group'] Line 192: Line 193: if device_params['capability'] in _UDEV_REQUIRING_CAPS: -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
Dan Kenigsberg has posted comments on this change.
Change subject: api: introducing short parameter for getVMList verb
..
Patch Set 2: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/38449/2//COMMIT_MSG
Commit Message:
Line 9: Due to vdsm sending only an array of vmids in a response to getVMList
Line 10: the engine asks separately using VM.getStats which creates unnecessery
Line 11: load. In order to fix this issue we introduce new parameter 'short'
Line 12: which is set to True by default. Older engines still want to get an
Line 13: array of vmids. For xmlrpc and newer engines which provides 'short' set
Please use a less ambiguous wording:
For xmlrpc, and for newer engines which provides ...
current text made me think but xmlrpc does not send 'short'!.
Line 14: as False map of vmids and statuses is returned.
Line 15:
Line 16:
Line 17: Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
https://gerrit.ovirt.org/#/c/38449/2/vdsm/API.py
File vdsm/API.py:
Line 1378:
Line 1379: return dict(status=doneCode)
Line 1380:
Line 1381: # VM-related functions
Line 1382: def getVMList(self, fullStatus=False, vmList=(), short=True):
You may consider this tedious, but I wish to reconsider the name. short is
very generic, and does suggest to the reader what's the expected behaviour.
short is also easily confused with VmShortStatus.
How about having onlyUUID=False as default?
Line 1383: return a list of known VMs with full (or partial) config
each
Line 1384: # To improve complexity, convert 'vms' to set(vms)
Line 1385: vmSet = set(vmList)
Line 1386: ret = {'status': doneCode,
Line 1382: def getVMList(self, fullStatus=False, vmList=(), short=True):
Line 1383: return a list of known VMs with full (or partial) config
each
Line 1384: # To improve complexity, convert 'vms' to set(vms)
Line 1385: vmSet = set(vmList)
Line 1386: ret = {'status': doneCode,
the code would be slightly nicer with another temp var:
vmlist = [v.status(fullStatus) ... ]
if onlyUUID:
vmlist = [v['vmId'] for v in vmlist]
Line 1387:'vmList': [v.status(fullStatus)
Line 1388: for v in self._cif.vmContainer.values()
Line 1389: if not vmSet or v.id in vmSet]}
Line 1390: if short:
Line 1386: ret = {'status': doneCode,
Line 1387:'vmList': [v.status(fullStatus)
Line 1388: for v in self._cif.vmContainer.values()
Line 1389: if not vmSet or v.id in vmSet]}
Line 1390: if short:
Please add a
# REQUIRED_FOR: engine-3.5.0
so future developers would know when this is not longer needed.
Line 1391: return {'status': doneCode,
Line 1392: 'vmList': [v['vmId'] for v in ret['vmList']]}
Line 1393: return ret
Line 1394:
https://gerrit.ovirt.org/#/c/38449/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3605: # @fullStatus: #optional When set to False return limited info
Line 3606: #
Line 3607: # @vmList: #optional Filter the results by a list of UUIDs
Line 3608: #
Line 3609: # @short: #optional determines whether we need short of full
status
this documentation could be improved, because we need to reduce the future
It would be more noble to define VmInfo as
'union': ['VmDefinition', 'UUID', 'VmShortStatus']}
And mention that UUID is sad legacy for engine-3.5.0.
Line 3610: #
Line 3611: # Returns:
Line 3612: # A list of VmInfos
Line 3613: #
--
To view, visit https://gerrit.ovirt.org/38449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm:moved metadatasize as an optional param for pv create in...
Nir Soffer has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38188/3/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 691: pv = os.path.join(PV_PREFIX, pv) Line 692: return pv Line 693: Line 694: Line 695: def _createpv(devices, metadataSize=0, options=tuple()): I'm ok with allowing a pv without metadata area if you need that, but the default should not be no metadata. Lets keep this a required argument and change the code so it works for gluster use case. Line 696: Line 697: Size for pvcreate should be with units k|m|g Line 698: pvcreate on a dev that is already a PV but not in a VG returns rc = 0. Line 699: The device is re-created with the new parameters. Line 703: if options: Line 704: cmd.extend(options) Line 705: if metadataSize: Line 706: cmd.extend((--metadatasize, metadatasize, --metadatacopies, 2, Line 707: --metadataignore, y)) When called with metadatasize=0, metadatasize is 0m here (see line 701) so this will not do what you want. I think what we need is to remove line 701 and do: if metadatasize != 0: cmd.extend((--metadatasize, %sm % metadatasize, --metadatacopies, 2, --metadataignore, y)) Please verify that creating a pv without specifying metadata parameters actually does what you want. Line 708: cmd.extend(devices) Line 709: rc, out, err = _lvminfo.cmd(cmd, devices) Line 710: return rc, out, err Line 711: -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm:moved metadatasize as an optional param for pv create in...
Nir Soffer has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38188/3/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 703: if options: Line 704: cmd.extend(options) Line 705: if metadataSize: Line 706: cmd.extend((--metadatasize, metadatasize, --metadatacopies, 2, Line 707: --metadataignore, y)) When called with metadatasize=0, metadatasize is 0m here (see line 701) s I noticed that difference between metadatasize and metadataSize now - so your code does work, but we cannot keep this horrible confusing code here. Please remove metadatasize and use metadataSize to format the options. Line 708: cmd.extend(devices) Line 709: rc, out, err = _lvminfo.cmd(cmd, devices) Line 710: return rc, out, err Line 711: -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
Michal Skrivanek has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 49: Code-Review+1 with 7.1 out of the door is there still any reason to not merge it? Centos 7.1 will follow soon, now we can be really sure it is going to be before 3.6;-) -- To view, visit https://gerrit.ovirt.org/26917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 49 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] broker_support
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] broker_support .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15537/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16507/ : FAILURE -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Optimize stomp encoder\decoder
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Optimize stomp encoder\decoder .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16349/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15549/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16519/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: Introduce EventFD support .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/548/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/540/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16351/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1106/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15551/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16521/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1089/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Remove redundant code
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Remove redundant code .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15545/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16515/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b9fb4b4b4c5286733f8f4435ec6dcea04f96233 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
oVirt Jenkins CI Server has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15541/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16511/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] subscriptions
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] subscriptions .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16355/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/1/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16525/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: use the atomic dict.setdefault() instead for check an...
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: use the atomic dict.setdefault() instead for check and set .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16350/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15550/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16520/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e4925a78328c4ac6cd0b9fc8659d6a3ee27a8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: use monotonic timer instead of clock
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: use monotonic timer instead of clock .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15536/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16506/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15538/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16508/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16342/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16512/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move AsyncoreEvent to betterAsyncore
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move AsyncoreEvent to betterAsyncore .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16352/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15552/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16522/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd3dc881091535328646ca1eeaac85f711885fc6 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15543/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16513/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16353/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16523/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing onlyUUID parameter for getVMList verb
Dan Kenigsberg has submitted this change and it was merged. Change subject: api: introducing onlyUUID parameter for getVMList verb .. api: introducing onlyUUID parameter for getVMList verb Due to vdsm sending only an array of vmids in a response to getVMList the engine asks separately using VM.getStats which creates unnecessary load. In order to fix this issue we introduce a new parameter 'onlyUUID' which is set to True by default. Engine 3.5.0 still wants to get an array of vmids, but for all other versions we set 'onlyUUID' to False which returns map of vmids and statuses. Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1196735 Related-To: https://gerrit.ovirt.org/#/c/38448 Reviewed-on: https://gerrit.ovirt.org/38449 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Francesco Romani from...@redhat.com --- M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json 4 files changed, 20 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing onlyUUID parameter for getVMList verb
Francesco Romani has posted comments on this change. Change subject: api: introducing onlyUUID parameter for getVMList verb .. Patch Set 4: Verified+1 works for me: - patched VDSM with early 3.5.0 Engine (released, from rpms) - unpatched VDSM with patched Engine (master branch) - patched VDSM with patched Engine (no more storms of getVmStats) when relevant (first two bullet points) checked both XMLRPC and JSONRPC. Also run with vdsClient (thus XMLRPC) with no issues. -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Remove JsonRpcClientPool
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Remove JsonRpcClientPool .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15547/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16516/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b67ee2ccb3acfac17a538ad2177f53c0007656 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is read before slicing the buffer
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Make sure the \0 is read before slicing the buffer .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15544/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16514/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] EVENTS
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] EVENTS .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16354/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15554/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16524/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: add ability to get dictionary directly from JsonRpc...
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: add ability to get dictionary directly from JsonRpcRequest .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16348/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15548/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16518/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb7edc48aa7d773b54db9d43e9f5460920e8ea50 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Properly log and return an error if the threadFacto...
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Properly log and return an error if the threadFactory fails .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15546/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16517/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b579fa0e95397f1dc3b3e939a9040dc5bdef36d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15539/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16509/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Properly initialize RuntimeError for JsonRpcError
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15540/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16510/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] subscriptions
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] subscriptions .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16527/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change _AsyncoreEvent to use EventFD
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16356/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15556/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16526/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f035e9a0587f5f407ad0efe9353c53b7674ffd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: use the response module in migration .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16324/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15524/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16494/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4642a1f0e0544e8d78cba6865425e14f63eea5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in vmpowerdown
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: use the response module in vmpowerdown .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16323/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15523/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16493/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314d4b15eb6c6104cc7bb2e58ad07ca08d868c66 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: remove _reportError
Francesco Romani has posted comments on this change. Change subject: janitorial: vm: remove _reportError .. Patch Set 6: rebased -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Update required device-mapper-multipath version
Nir Soffer has posted comments on this change. Change subject: build: Update required device-mapper-multipath version .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38359/3//COMMIT_MSG Commit Message: Line 6: Line 7: build: Update required device-mapper-multipath version Line 8: Line 9: device-mapper-multipath-0.4.9-75.el6 solves segfault in multipath. Line 10: Changed vdsm spec fie to require that version. Please explain that the package is not available on Fedora 20, and the status on rhel 7 (fixed package available/not available/this bug never existed there). Line 11: Line 12: Change-Id: I6700630729d845603f1efe347ac07aac9ded7a92 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096197 -- To view, visit https://gerrit.ovirt.org/38359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6700630729d845603f1efe347ac07aac9ded7a92 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Avoid pointless extension requests .. virt: Avoid pointless extension requests After a drive is extended to the maximum volume size, if the guest keeps writing, the image may pass the drive's watermark for early extension. On this condition, current extend logic is trying to extend the drive every 2 seconds. This results in fruitless extensions failing in lvextend because the requested size is equal to the current size. These extension requests may delay real requests, perform unneeded io, and fill up the log with bogus errors and warnings. Now we check if the drive was fully extended and do not try to extend it further. Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Bug-Url: https://bugzilla.redhat.com/1195768 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38179 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Nir Soffer has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37912/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-18 15:52:27 +0100 Line 4: Commit: Francesco Romani from...@redhat.com Line 5: CommitDate: 2015-03-06 09:29:36 +0100 Line 6: Line 7: janitorial: introduce the 'response' module janitorial: - lib: Line 8: Line 9: It happens sometimes that it is needed to overwrite Line 10: the predefined error message with something more Line 11: specific to the circumstances. -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Francesco Romani has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37912/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-18 15:52:27 +0100 Line 4: Commit: Francesco Romani from...@redhat.com Line 5: CommitDate: 2015-03-06 09:29:36 +0100 Line 6: Line 7: janitorial: introduce the 'response' module janitorial: - lib: Done Line 8: Line 9: It happens sometimes that it is needed to overwrite Line 10: the predefined error message with something more Line 11: specific to the circumstances. -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: janitorial: use the response module
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: janitorial: use the response module .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16495/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Nir Soffer has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
Nir Soffer has posted comments on this change.
Change subject: janitorial: add the response.success() helper
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38270/6/lib/vdsm/response.py
File lib/vdsm/response.py:
Line 25: def success(**kwargs):
Line 26: kwargs[status] = {
Line 27: code: 0,
Line 28: message: Done
Line 29: }
This duplicates doneCode - either remove it or use it here.
Line 30: return kwargs
Line 31:
Line 32:
Line 33: def error(name, message=None):
--
To view, visit https://gerrit.ovirt.org/38270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Adds autobackup param in changelv and set the default v...
Nir Soffer has posted comments on this change.
Change subject: lvm: Adds autobackup param in changelv and set the default
value to false
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38195/2//COMMIT_MSG
Commit Message:
Line 19: of params in a tuple format and have some mandatory options.
Line 20: This will allow to break the lvm call if any thing called with
Line 21: different option values in the tuple list which are now mandatory
Line 22: to have some constant/'already defined' value.
Line 23: ex:- changelv(vg, lvs, ('-autobackup', 'y'))
I'm not sure what do you mean here - is there a conflict between the new option
and calling with ('autobackup', 'y')?
Line 24:
Line 25: Change-Id: I8190878fe071fad46800e666795b94779d745abf
--
To view, visit https://gerrit.ovirt.org/38195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@gmail.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: switch to response.error() .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15528/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16498/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
Darshan N has uploaded a new change for review.
Change subject: gluster: Adds new verb to setup geo-rep mount broker.
..
gluster: Adds new verb to setup geo-rep mount broker.
This patch adds a new verb to setup mount broker for
gluster geo-replication:
geoRepMountBrokerSetup: This verb takes user name,
group name and remote volume name as argument. and
sets the mount broker need for non-root geo-replication.
Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f
Signed-off-by: Darshan N dnara...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 105 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/38444/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 746a5be..5e8fd18 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -627,6 +627,18 @@
pp.pprint(status)
return status['status']['code'], status['status']['message']
+def do_glusterGeoRepMountBrokerSetup(self, args):
+params = self._eqSplit(args)
+userName = params.get('userName', '')
+remoteVolumeName = params.get('remoteVolumeName', '')
+groupName = params.get('groupName', '')
+
+status = self.s.glusterGeoRepMountBrokerSetup(userName,
+ groupName,
+ remoteVolumeName)
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
def getGlusterCmdDict(serv):
return \
@@ -1067,5 +1079,12 @@
'geoRepPubKeys=geo_replication_pub_keys',
'update geo replication public keys to authorized'
' keys file of user'
+ )),
+ 'glusterGeoRepMountBrokerSetup': (
+ serv.do_glusterGeoRepMountBrokerSetup,
+ ('userName=user_name'
+ 'remoteVolumeName=remote_volume_name'
+ 'groupName=group_name',
+ 'setup mount broker for geo replication'
))
}
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index ff2556e..66a42af 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -29,6 +29,7 @@
_SUCCESS = {'status': doneCode}
GEOREP_PUB_KEY_PATH = /var/lib/glusterd/geo-replication/common_secret.pem.pub
+MOUNT_BROKER_ROOT = /var/mountbroker-root
GLUSTER_RPM_PACKAGES = (
@@ -109,6 +110,21 @@
return
except IOError as e:
raise ge.GlusterGeoRepPublicKeyWriteFailedException(err=e)
+
+
+@makePublic
+def createMountBrokerRoot(userName):
+try:
+getpwnam(userName)
+except KeyError as e:
+raise ge.GlusterGeoRepUserNotFoundException(err=e)
+try:
+os.makedirs(MOUNT_BROKER_ROOT)
+os.chmod(MOUNT_BROKER_ROOT, 0711)
+except OSError:
+if not os.path.isdir(MOUNT_BROKER_ROOT):
+raise
+return
class GlusterApi(object):
@@ -504,6 +520,19 @@
def geoRepKeysUpdate(self, userName, geoRepPubKeys, options=None):
self.svdsmProxy.glusterUpdateGeoRepKeys(userName, geoRepPubKeys)
+@exportAsVerb
+def geoRepMountBrokerSetup(self, userName, groupName,
+ remoteVolumeName, options=None):
+self.svdsmProxy.glusterCreateMountBrokerRoot(userName)
+mountBrokerOptions = {'mountbroker-root': MOUNT_BROKER_ROOT,
+ 'geo-replication-log-group': groupName,
+ 'rpc-auth-allow-insecure': 'on'}
+for optionName, optionValue in mountBrokerOptions.iteritems():
+self.svdsmProxy.glusterExecuteMountBrokerOpt(optionName,
+ optionValue)
+self.svdsmProxy.glusterExecuteMountBrokerUserAdd(userName,
+ remoteVolumeName)
+
def getGlusterMethods(gluster):
l = []
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 1c749b5..c507c40 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -254,6 +254,10 @@
def geoRepKeysUpdate(self, userName, geoRepPubKeys):
return self._gluster.geoRepKeysUpdate(userName, geoRepPubKeys)
+def geoRepMountBrokerSetup(self, userName, groupName, remoteVolumeName):
+return self._gluster.geoRepMountBrokerSetup(userName, groupName,
+remoteVolumeName)
+
class GlusterSnapshot(GlusterApiBase):
def __init__(self):
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index cd4e433..d10d215 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -1345,3 +1345,28 @@
raise ge.GlusterGeoRepPublicKeyFileCreateFailedException(rc,
Change in vdsm[master]: janitorial: introduce the 'response' module
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/544/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/536/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1102/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15519/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1085/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Michal Skrivanek has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38420/2//COMMIT_MSG Commit Message: Line 8: Line 9: Adds number of incoming and outgoing VM migrations into HostStats. Line 10: Line 11: Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Line 12: Bug-Url: https://bugzilla.redhat.com/1113664 Pardon me, but cannot the client do the math by itself? it can. but since vdsm is doing it since ages it's simpler to just extend it a little instead of adding a new partially redundant calculation in engine (with the risk of not being compeltely in sync due to async updates and monitoring cycle in engine) plus a little benefit for vdsm - we can show it in vdsClient:) -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Avoid pointless extension requests
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Avoid pointless extension requests .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16327/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15527/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16497/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0665fb12dbba9d9d42777db4c43cc606b9708348 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: introducing short parameter for getVMList verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: introducing short parameter for getVMList verb .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15532/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16502/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: introduce the 'response' module
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: introduce the 'response' module .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/546/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/538/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16329/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1104/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16499/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1087/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm:moved metadatasize as an optional param for pv create in...
Timothy Asir has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: use the response module in migration
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: use the response module in migration
..
janitorial: use the response module in migration
This patch makes migration.py use the response module.
Change-Id: Iec4642a1f0e0544e8d78cba6865425e14f63eea5
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/migration.py
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/38446/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 6afa9d4..a4fe63a 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -25,11 +25,12 @@
import hooks
import kaxmlrpclib
+from vdsm import response
from vdsm import utils
from vdsm import vdscli
from vdsm.compat import pickle
from vdsm.config import config
-from vdsm.define import NORMAL, errCode, Mbytes
+from vdsm.define import NORMAL, Mbytes
from . import vmexitreason
from . import vmstatus
@@ -123,10 +124,10 @@
status = self.destServer.getVmStats(self._vm.id)
if not status['status']['code']:
self.log.error(Machine already exists on the destination)
-self.status = errCode['exist']
+self.status = response.error('exist')
except Exception:
self.log.exception(Error initiating connection)
-self.status = errCode['noConPeer']
+self.status = response.error('noConPeer')
def _setupRemoteMachineParams(self):
self._machineParams.update(self._vm.status())
@@ -174,7 +175,7 @@
def _recover(self, message):
if not self.status['status']['code']:
-self.status = errCode['migrateErr']
+self.status = response.error('migrateErr')
self.log.error(message)
if not self.hibernating:
try:
@@ -264,9 +265,8 @@
self._finishSuccessfully()
except libvirt.libvirtError as e:
if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED:
-self.status['status']['code'] = \
-errCode['migCancelErr']['status']['code']
-self.status['status']['message'] = 'Migration canceled'
+self.status = response.error('migCancelErr',
+ message='Migration canceled')
raise
finally:
if '_migrationParams' in self._vm.conf:
--
To view, visit https://gerrit.ovirt.org/38446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec4642a1f0e0544e8d78cba6865425e14f63eea5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Francesco Romani has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 7: addressed comments from Nir. -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Francesco Romani has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 4: Verified+1 addressed comments from Nir. Verified running the new tests. -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Francesco Romani has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: btw other than schema nitpicking, looks fine -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Dan Kenigsberg has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38420/2//COMMIT_MSG Commit Message: Line 8: Line 9: Adds number of incoming and outgoing VM migrations into HostStats. Line 10: Line 11: Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Line 12: Bug-Url: https://bugzilla.redhat.com/1113664 Pardon me, but cannot the client do the math by itself? We report all VMs' statuses in getVMList and getAllVMStats. Why does vdsm need to do anything else? The fact that we report the number of running VMs is a sad fact of the ancient past. Why do we need to add more of that? -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Nir Soffer has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
Nir Soffer has posted comments on this change. Change subject: janitorial: add the response.success() helper .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38270/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3387: self.cif.teardownVolumePath(memoryVol) Line 3388: Line 3389: # Returning quiesce to notify the manager whether the guest agent Line 3390: # froze and flushed the filesystems or not. Line 3391: quiesceFlag = ( quiesceFlag is correct, but I would call it guestDidQuiesce - this flag tell if we the guest did quiesce during this snapshot. Line 3392: snapFlags libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE Line 3393: == libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE) Line 3394: return response.success(quiesce=quiesceFlag) Line 3395: -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove _reportError
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: remove _reportError .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16330/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15530/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16500/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Francesco Romani has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38420/2/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2060:'momStatus': 'MOMStatus', '*haScore': 'int', Line 2061:'haStatus': 'HostedEngineStatus', '*bootTime': 'uint', Line 2062:'numaNodeMemFree': 'NumaNodeMemoryStatsMap', Line 2063:'cpuStatistics': 'CpuCoreStatsMap', Line 2064:'incomingVmMigrations': 'int', 'outgoingVmMigrations': 'int'}} just noticed: should be uint, in both places Line 2065: Line 2066: ## Line 2067: # @Host.getStats: Line 2068: # -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Update required device-mapper-multipath version
oVirt Jenkins CI Server has posted comments on this change. Change subject: build: Update required device-mapper-multipath version .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/545/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/537/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15526/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1086/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6700630729d845603f1efe347ac07aac9ded7a92 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: debug log for getAllVmStats() and getVMList()
Francesco Romani has posted comments on this change. Change subject: vm: debug log for getAllVmStats() and getVMList() .. Patch Set 3: Code-Review-1 Verified+1 commit message updated, rebased (but not yet on top of the log level change). Copied scores. -- To view, visit https://gerrit.ovirt.org/36732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23d9361568f51be9b70dab22d3a388f692011402 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: leave VM responsive when sampling ends
Francesco Romani has posted comments on this change. Change subject: vm: leave VM responsive when sampling ends .. Patch Set 3: Code-Review-1 Verified-1 for some reasons, gone neglected^Wunnoticed so far :( and also obsoleted by the bulk stats sampling -- To view, visit https://gerrit.ovirt.org/35902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee3205da94152bfd39197dae6c06d00c06e1d58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 12: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/37592/12/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 716:
Line 717: Runs Qemu in a subprocess and communicates with it, and monitors
Line 718: its behaviour.
Line 719:
Line 720:
unrelated
Line 721: log = logging.getLogger(vm.Vm)
Line 722: # limit threads number until the libvirt lock will be fixed
Line 723: _ongoingCreations = threading.BoundedSemaphore(4)
Line 724: DeviceMapping = ((hwclass.DISK, vmdevices.storage.Drive),
Line 2589: return {'status': doneCode, 'vmList': self.status()}
Line 2590:
Line 2591: def _getVcpuLimit(self):
Line 2592: qos = self._getVmPolicy()
Line 2593: if qos is not None:
'qos' may be == qos/qos, and in that case we'll blow up with IndexError
two lines below.
Line 2594: vcpuLimit = qos.getElementsByTagName(vcpuLimit)
Line 2595: self._vcpuLimit = vcpuLimit[0].childNodes[0].data
Line 2596:
Line 2597: def updateVmPolicy(self, params):
--
To view, visit https://gerrit.ovirt.org/37592
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make updateVolume a periodic operation
Francesco Romani has posted comments on this change. Change subject: virt: make updateVolume a periodic operation .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/37594/14/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 227: self._vm.isDomainReadyForCommands()) Line 228: Line 229: def __call__(self): Line 230: for vmDrive in self._vm.getDiskDevices(): Line 231: # TODO: If this block (it is actually possible?) if this block*S* (this == updateDriveVolume) Line 232: # we must make sure we don't overwrite good data Line 233: # with stale old data. -- To view, visit https://gerrit.ovirt.org/37594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
