Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value ......................................................................
Patch Set 12: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/37592/12/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 716: Line 717: Runs Qemu in a subprocess and communicates with it, and monitors Line 718: its behaviour. Line 719: """ Line 720: unrelated Line 721: log = logging.getLogger("vm.Vm") Line 722: # limit threads number until the libvirt lock will be fixed Line 723: _ongoingCreations = threading.BoundedSemaphore(4) Line 724: DeviceMapping = ((hwclass.DISK, vmdevices.storage.Drive), Line 2589: return {'status': doneCode, 'vmList': self.status()} Line 2590: Line 2591: def _getVcpuLimit(self): Line 2592: qos = self._getVmPolicy() Line 2593: if qos is not None: 'qos' may be == "<qos></qos>", and in that case we'll blow up with IndexError two lines below. Line 2594: vcpuLimit = qos.getElementsByTagName("vcpuLimit") Line 2595: self._vcpuLimit = vcpuLimit[0].childNodes[0].data Line 2596: Line 2597: def updateVmPolicy(self, params): -- To view, visit https://gerrit.ovirt.org/37592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
