Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1213/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17104/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/674/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17103/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/672/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 252: # with ValueError: invalid value Not Implemented for size error. Line 253: # at the end of vg create execution. Line 254: # So it is need to pass a size object for the latest version of Line 255: # vg create function and a numerical value for the older version of Line 256: # vg create. Actually passing size object is more good than numerical value because size Blivet Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1198568 Line 257: if stripeSize and isinstance(pvDeviceList[0].size, size.Size): Line 258: stripeSize = size.Size(%s MiB % stripeSize) Line 259: supportSizeObj = True Line 260: vg = _createVG(vgName, pvDeviceList, stripeSize) Line 255: # vg create function and a numerical value for the older version of Line 256: # vg create. Line 257: if stripeSize and isinstance(pvDeviceList[0].size, size.Size): Line 258: stripeSize = size.Size(%s MiB % stripeSize) Line 259: supportSizeObj = True Bala, I am waiting for your reply! I got it now and sent the updated patch Line 260: vg = _createVG(vgName, pvDeviceList, stripeSize) Line 261: Line 262: # The following calculation is based on the redhat storage performance doc Line 263: # http://docbuilder.usersys.redhat.com/22522 -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1231/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17277/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
Ido Barkan has uploaded a new change for review.
Change subject: split network restoration from vdsmd.service
..
split network restoration from vdsmd.service
Right now the task of doing network restoration is delegated to the vdsmd
service initialization. Since systemd does not expect that a long lived deamon
such as dhclient will stay alive after ExecStartPre stage, it might kill
dhclient, if that was spawned on dhcp persistent interfaces.
This patch splits systemd vdsm service into 2 dependant units:
1. vdsm-network.service which
upgrades unified persistence and 3.0.0 networks if needed and then restore
networks as its main mission
2. vdsmd.service which reconfigures the persistent network configuration of
vdsm using the configured net_configurator
Note that from now on, disabling vdsmd cannot render the machine inaccessible
as the vdsm networks will be started upon boot. Note also that since it is
inconvenient to implement logic on service files, vdsm-restore-net-config
learned how to no-op when nets_restored mark exists and this functionality was
removed from the bash part.
Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381
Bug-Url: https://bugzilla.redhat.com/1204782
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M .gitignore
M init/systemd/Makefile.am
A init/systemd/vdsm-network.service.in
M init/systemd/vdsmd.service.in
M init/sysvinit/vdsmd.init.in
M init/vdsmd_init_common.sh.in
M lib/vdsm/tool/restore_nets.py
M vdsm.spec.in
M vdsm/vdsm-restore-net-config
9 files changed, 85 insertions(+), 26 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/39127/1
diff --git a/.gitignore b/.gitignore
index c434554..55da53b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -26,6 +26,7 @@
init/systemd/systemd-vdsmd
init/systemd/vdsm-tmpfiles.d.conf
init/systemd/vdsmd.service
+init/systemd/vdsmd-network.service
init/sysvinit/supervdsmd.init
init/sysvinit/vdsmd.init
init/upstart/supervdsmd.upstart
diff --git a/init/systemd/Makefile.am b/init/systemd/Makefile.am
index 4a871df..3f721c5 100644
--- a/init/systemd/Makefile.am
+++ b/init/systemd/Makefile.am
@@ -23,8 +23,9 @@
nodist_noinst_DATA = \
supervdsmd.service \
systemd-vdsmd \
- vdsm-tmpfiles.d.conf \
vdsmd.service \
+ vdsm-network.service \
+ vdsm-tmpfiles.d.conf \
$(NULL)
CLEANFILES = \
@@ -37,6 +38,7 @@
systemd-vdsmd.in \
vdsm-tmpfiles.d.conf.in \
vdsmd.service.in \
+ vdsm-network.service.in \
$(NULL)
all-local: \
diff --git a/init/systemd/vdsm-network.service.in
b/init/systemd/vdsm-network.service.in
new file mode 100644
index 000..d863f1b
--- /dev/null
+++ b/init/systemd/vdsm-network.service.in
@@ -0,0 +1,16 @@
+[Unit]
+Description=Virtual Desktop Server Manager network restoration
+Wants=network.target
+Requires=libvirtd.service
+After=libvirtd.service
+
+[Service]
+Type=oneshot
+EnvironmentFile=-/etc/sysconfig/vdsm
+ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append
--logfile=@VDSMLOGDIR@/upgrade.log upgrade-unified-persistence
+ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append
--logfile=@VDSMLOGDIR@/upgrade.log upgrade-3.0.0-networks
+ExecStart=@VDSMDIR@/vdsm-restore-net-config
+RemainAfterExit=yes
+
+[Install]
+WantedBy=multi-user.target
\ No newline at end of file
diff --git a/init/systemd/vdsmd.service.in b/init/systemd/vdsmd.service.in
index 67f0dad..0f48cdf 100644
--- a/init/systemd/vdsmd.service.in
+++ b/init/systemd/vdsmd.service.in
@@ -1,7 +1,9 @@
[Unit]
Description=Virtual Desktop Server Manager
Requires=multipathd.service libvirtd.service time-sync.target \
- iscsid.service rpcbind.service supervdsmd.service sanlock.service
+ iscsid.service rpcbind.service supervdsmd.service sanlock.service \
+ vdsm-network.service
+After=vdsm-network.service
Conflicts=libvirt-guests.service ksmtuned.service
[Service]
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 2ba8011..efddeb4 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -141,6 +141,21 @@
fi
}
+restore_nets(){
+@PYTHON@ @VDSMDIR@/vdsm-restore-net-config || return 1
+return 0
+}
+
+unified_network_persistence_upgrade(){
+echo 'Upgrading to unified persistence if needed'
+$VDSM_TOOL ${UPGRADE_LOGGING_PARAMS} upgrade-unified-persistence
+}
+
+upgrade_300_nets(){
+echo 'Upgrading to v3.x networking if needed'
+$VDSM_TOOL ${UPGRADE_LOGGING_PARAMS} upgrade-3.0.0-networks
+}
+
start() {
test_already_running return 0
@@ -155,6 +170,10 @@
${VDSMD_INIT_COMMON} --pre-start || return 1
+unified_network_persistence_upgrade || return 1
+restore_nets || return 1
+upgrade_300_nets || return 1
+
echo $Starting up vdsm daemon:
DAEMON_COREFILE_LIMIT=unlimited NICELEVEL=${NICE_LOWEST} daemon \
--user=vdsm @VDSMDIR@/daemonAdapter -0
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
Ido Barkan has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
automat...@ovirt.org has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 1: * Update tracker::#1204782::OK * Check Bug-Url::OK * Check Public Bug::#1204782::OK, public bug * Check Product::#1204782::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1204782::OK, correct target release 3.5.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
Yaniv Bronhaim has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 1: Code-Review-2 err didn't notice that.. sorry but I already took https://gerrit.ovirt.org/#/c/39081/ . next time -- To view, visit https://gerrit.ovirt.org/39127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
automat...@ovirt.org has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: basic scaffolding tests for getUnderlying*
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: basic scaffolding tests for getUnderlying* .. Patch Set 4: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17107/ -- To view, visit https://gerrit.ovirt.org/38976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7609d346d7cef41286674e4b1443856ab088bc4c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: basic scaffolding tests for getUnderlying*
automat...@ovirt.org has posted comments on this change. Change subject: tests: basic scaffolding tests for getUnderlying* .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7609d346d7cef41286674e4b1443856ab088bc4c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17105/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17106/ -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
automat...@ovirt.org has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1215/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1233/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/666/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 255: # vg create function and a numerical value for the older version of Line 256: # vg create. Line 257: if stripeSize and isinstance(pvDeviceList[0].size, size.Size): Line 258: stripeSize = size.Size(%s MiB % stripeSize) Line 259: supportSizeObj = True I couldn't catch your point. Could you please explain a bit more. Bala, I am waiting for your reply! Line 260: vg = _createVG(vgName, pvDeviceList, stripeSize) Line 261: Line 262: # The following calculation is based on the redhat storage performance doc Line 263: # http://docbuilder.usersys.redhat.com/22522 -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/664/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17277/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1213/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/665/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1232/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
Timothy Asir has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 252: # with ValueError: invalid value Not Implemented for size error. Line 253: # at the end of vg create execution. Line 254: # So it is need to pass a size object for the latest version of Line 255: # vg create function and a numerical value for the older version of Line 256: # vg create. This sounds like a bug in blivet - why are you trying to fix blivet bugs in Actually passing size object is more good than numerical value because size object will have more clarity. Also in the higher version using just a numerical value is depreciated and not recommended. So its good to use size object if its support otherwise we can go with only numerical value for peSize param. I can remove this or enhance this part later once blivet fixes this issue. Line 257: if stripeSize and isinstance(pvDeviceList[0].size, size.Size): Line 258: stripeSize = size.Size(%s MiB % stripeSize) Line 259: supportSizeObj = True Line 260: vg = _createVG(vgName, pvDeviceList, stripeSize) Line 276: # The latest blivet version accept a numerical value or size object Line 277: # for lv size and creates a lv map/obj in memory, however it fails Line 278: # with an unsupported operand type error at the end of execution. Line 279: # The lower version of blivet expects the lv size to be given as a Line 280: # numerical MiB value. This sounds like a bug in blivet - why are you trying to fix blivet bugs in Actually I want to use only size object because it will give more clarity about the value and can be converted easily. I will send enhancement later once blivet fixes the issue. Line 281: # So it is required to pass the value as a size obj for the latest Line 282: # one and its needed to pass numeric value for the older version to Line 283: # support backward compatibility. Line 284: if supportSizeObj: -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/673/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1214/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17278/ -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
Allon Mureinik has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/39119/3//COMMIT_MSG Commit Message: Line 8: Line 9: The previous code had few issues: Line 10: Line 11: - It used unlimited number of threads by default. This may lead to Line 12: creation of 100's of threads if you do not specify a value. s/100's/hundreds/, s/creation/the creation/ Line 13: - It used non-daemon threads, which could lead to unwanted delay during Line 14: vdsm shutdown. Line 15: - It tried to yield results before all arguments were handled. This Line 16: could lead to unwanted delay in argument processing, if the caller Line 19: number of values. Line 20: - If invalid maxthreads was given, the ValueError was intialized with a Line 21: tuple (Wrong input to function itmap: %s, maxthreads) instead of Line 22: a formatted string. Line 23: - It was too complicated. I'm not a fan of such vague statements. IMHO, either elaborate it or drop it. Line 24: Line 25: Changes: Line 26: Line 27: - The caller must specify the maximum number of threads. https://gerrit.ovirt.org/#/c/39119/3/tests/miscTests.py File tests/miscTests.py: Line 213: def dummy(arg): Line 214: raise err Line 215: Line 216: data = [1, 2, 3] Line 217: self.assertEqual(list(misc.itmap(dummy, data, 4)), [err] * len(data)) Just for the fun of it, I'd add a test with maxthreads = 2 ( len(data)). Not that I expect it to fail, but I think it has a nice declarative value to show you thought of this usecase and verified it works properly. Line 218: Line 219: Line 220: class RotateFiles(TestCaseBase): Line 221: -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
Ido Barkan has abandoned this change. Change subject: split network restoration from vdsmd.service .. Abandoned -- To view, visit https://gerrit.ovirt.org/39127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: split network restoration from vdsmd.service
automat...@ovirt.org has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 1: * Update tracker::#1204782::OK -- To view, visit https://gerrit.ovirt.org/39127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix build error in F20 due to blivet version issue .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17104/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17278/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1214/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: make _ADDRESS and _PORT public
Nir Soffer has posted comments on this change. Change subject: vdscli: make _ADDRESS and _PORT public .. Patch Set 1: Code-Review+1 Lets merge this before the dump chains patch. -- To view, visit https://gerrit.ovirt.org/39055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d9f627e572df11f01600fd4ebc5e19f85fc5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1234/ -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port updateVolume .. Patch Set 24: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17115/ -- To view, visit https://gerrit.ovirt.org/37594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: periodic: port queryBlockJobs
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: periodic: port queryBlockJobs .. Patch Set 24: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17113/ -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 23: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17111/ -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 24: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17116/ -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 32: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17114/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: restore unresponsive on timeout when sampling .. Patch Set 13: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17112/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 34: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17109/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: dispatch work to VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: dispatch work to VMs .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0422bfce99d1e479cb5af49c7b37204ca7e295 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: periodic: port queryBlockJobs
automat...@ovirt.org has posted comments on this change. Change subject: vm: periodic: port queryBlockJobs .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: driver
Dan Kenigsberg has posted comments on this change. Change subject: virt: driver .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39034/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-23 11:48:31 +0100 Line 4: Commit: Petr Horáček phora...@redhat.com Line 5: CommitDate: 2015-03-23 11:48:31 +0100 Line 6: Line 7: virt: driver Please improve commit message, and add Bug-Url. Line 8: Line 9: Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
Piotr Kliczewski has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
automat...@ovirt.org has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1216/ -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: upgrade selinux dependency for gluster
Allon Mureinik has posted comments on this change. Change subject: spec: upgrade selinux dependency for gluster .. Patch Set 1: Verified+1 -Code-Review (sorry, wrong checkbox - meant Verified, not +1, of course) -- To view, visit https://gerrit.ovirt.org/39129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/675/ -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: devices: move device creation in a submodule
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: devices: move device creation in a submodule .. Patch Set 5: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/667/ -- To view, visit https://gerrit.ovirt.org/38077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/674/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/666/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17105/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1233/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17279/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1215/ : FAILURE -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateNumaInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port updateNumaInfo .. Patch Set 6: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17119/ -- To view, visit https://gerrit.ovirt.org/38598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f95eb81d5331432f9934b1a41f74ace37e902cd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: periodic: restore highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: periodic: restore highWrite monitoring .. Patch Set 24: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17118/ -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: dispatch work to VMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: dispatch work to VMs .. Patch Set 19: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17117/ -- To view, visit https://gerrit.ovirt.org/37885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0422bfce99d1e479cb5af49c7b37204ca7e295 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: heartbeat fix
Yaniv Bronhaim has posted comments on this change. Change subject: asyncore: heartbeat fix .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. gluster: Adds new verbs to setup gluster geo-replication. This patch adds two new verbs to setup gluster geo-replication: geoRepKeysGet: This verb executes the gsec create command and then reads the collected public keys generated by gsec create command. It returns the collected public key as a list of strings. geoReoKeysUpdate: This verb takes user name and public key collection as argument. It appends the public keys to the user's authorized_keys file. Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Signed-off-by: Darshan N dnara...@redhat.com Signed-off-by: Bala.FA barum...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38228 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClientGluster.py M vdsm/gluster/__init__.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 7 files changed, 179 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Code-Review+2 Raising -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
automat...@ovirt.org has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 23: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/676/ -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: upgrade selinux dependency for gluster
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/39129 to review the following change. Change subject: spec: upgrade selinux dependency for gluster .. spec: upgrade selinux dependency for gluster Upgrade the SELinux policy dependency in order to require a fix that prevents creating GlusterFS domains on EL7. Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Bug-Url: https://bugzilla.redhat.com/1205583 Signed-off-by: Allon Mureinik amure...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38414 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/39129/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 3aad811..dccfbdc 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -208,7 +208,7 @@ Requires: lvm2 Requires: python Requires: policycoreutils-python -Requires: selinux-policy-targeted = 3.12.1-153.el7_0.13 +Requires: selinux-policy-targeted = selinux-policy-3.13.1-16.el7 %else Requires: python Requires: device-mapper-multipath = 0.4.9-52 -- To view, visit https://gerrit.ovirt.org/39129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: upgrade selinux dependency for gluster
automat...@ovirt.org has posted comments on this change. Change subject: spec: upgrade selinux dependency for gluster .. Patch Set 1: * Update tracker::#1205583::OK * Check Bug-Url::OK * Check Public Bug::#1205583::OK, public bug * Check Product::#1205583::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1205583::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: upgrade selinux dependency for gluster
Allon Mureinik has posted comments on this change. Change subject: spec: upgrade selinux dependency for gluster .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move device configuration in a module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device configuration in a module .. Patch Set 12: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17279/ -- To view, visit https://gerrit.ovirt.org/36266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9b133a75cd4cb5d11b1f09aff711846eca33ff8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 32: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateNumaInfo
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: port updateNumaInfo .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f95eb81d5331432f9934b1a41f74ace37e902cd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: periodic: restore highWrite monitoring
automat...@ovirt.org has posted comments on this change. Change subject: vm: periodic: restore highWrite monitoring .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore unresponsive on timeout when sampling
automat...@ovirt.org has posted comments on this change. Change subject: vm: restore unresponsive on timeout when sampling .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateVolume
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: port updateVolume .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
automat...@ovirt.org has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 24: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 12: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17110/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: method to check if dom is ready for commands
automat...@ovirt.org has posted comments on this change. Change subject: vm: method to check if dom is ready for commands .. Patch Set 30: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
automat...@ovirt.org has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 23: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: method to check if dom is ready for commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: method to check if dom is ready for commands .. Patch Set 30: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17108/ -- To view, visit https://gerrit.ovirt.org/36721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 34: * Update tracker::#1139217::OK * Check Bug-Url::OK * Check Public Bug::#1139217::OK, public bug * Check Product::#1139217::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
Francesco Romani has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: Verified+1 this patch now allows 'make check' to pass on master. -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17120/ -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
Dan Kenigsberg has submitted this change and it was merged. Change subject: schema: temporarily skip getMigrationStatus .. schema: temporarily skip getMigrationStatus Commit b8df0ff261c unveiled an existing inconsistency betwen the return value of VM.getMigrationStatus() API and the schema. As result, schema validation tests, thus master, are broken. Investigation on Engine side suggests that Engine does not really cares about new keys, so we have the chance to properly fix, cleanup and modernize this verb with no hurry. However, to quickly unbreak master, this patch just skips the schema validation of the getMigrationStatus verb, until it is fully worked on. Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39062 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/schemaValidationTest.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
Dan Kenigsberg has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 23: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/668/ -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 3: Build Started (9/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/794/ -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: implement getUnderlyingRngDeviceInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: implement getUnderlyingRngDeviceInfo .. Patch Set 3: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/386/ -- To view, visit https://gerrit.ovirt.org/38982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I251bf72dcdb351318655908c493e9973b497b5ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: implement getUnderlyingRngDeviceInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: implement getUnderlyingRngDeviceInfo .. Patch Set 3: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/397/ -- To view, visit https://gerrit.ovirt.org/38982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I251bf72dcdb351318655908c493e9973b497b5ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Corrected return value of gluster volume snapshot c...
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected return value of gluster volume snapshot create .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/388/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4774/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/383/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/799/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/800/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22441d90291be5cb8aa0d5498021b9e9a678adfc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
Dan Kenigsberg has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: revert build dependency on non-existing blivet
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: revert build dependency on non-existing blivet .. Patch Set 2: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/802/ -- To view, visit https://gerrit.ovirt.org/39132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fc8f3c802e711a844b8aed0b927111cf0d593f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17122/ -- To view, visit https://gerrit.ovirt.org/39137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: implement getUnderlyingRngDeviceInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: implement getUnderlyingRngDeviceInfo .. Patch Set 3: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/398/ -- To view, visit https://gerrit.ovirt.org/38982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I251bf72dcdb351318655908c493e9973b497b5ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17284/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: implement getUnderlyingRngDeviceInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: implement getUnderlyingRngDeviceInfo .. Patch Set 3: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/795/ -- To view, visit https://gerrit.ovirt.org/38982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I251bf72dcdb351318655908c493e9973b497b5ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 4: Build Started (2/4) - http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/24/ -- To view, visit https://gerrit.ovirt.org/38865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Safer and simpler itmap
Nir Soffer has posted comments on this change. Change subject: misc: Safer and simpler itmap .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39119/3/tests/miscTests.py File tests/miscTests.py: Line 213: def dummy(arg): Line 214: raise err Line 215: Line 216: data = [1, 2, 3] Line 217: self.assertEqual(list(misc.itmap(dummy, data, 4)), [err] * len(data)) Just for the fun of it, I'd add a test with maxthreads = 2 ( len(data)). I will add permutations to test errors with len(data) -1, len(data), len(data) + 1 Line 218: Line 219: Line 220: class RotateFiles(TestCaseBase): Line 221: -- To view, visit https://gerrit.ovirt.org/39119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6116ac4003702c8e921cebaf494491a6f9afaf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: revert build dependency on non-existing blivet
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: revert build dependency on non-existing blivet .. Patch Set 2: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/803/ -- To view, visit https://gerrit.ovirt.org/39132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fc8f3c802e711a844b8aed0b927111cf0d593f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Max Kovgan m...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
