Change in vdsm[master]: iscsi: Fix minimal timeout when performing scsi scan
Francesco Romani has posted comments on this change. Change subject: iscsi: Fix minimal timeout when performing scsi scan .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39256/2//COMMIT_MSG Commit Message: Line 13: can see that we wait for about 12 milliseconds instead of 2 seconds. Line 14: Line 15: Without the minimal wait, creating a storage domain may fail after Line 16: disconnecting and reconnecting from the storage server, and trying to Line 17: access the vg before the multiapth device was created. typo: should be multipath Line 18: Line 19: The root cause is commit 66c24c1996 (iscsi: Iscsi rescan cleanup), which Line 20: replaced blocking scsi scan and interrupt-safe wait loop with Line 21: non-blocking scsi scan and single unsafe time.sleep(). -- To view, visit https://gerrit.ovirt.org/39256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c62ed29c67698d689f8a345e6a740363c77c0d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 37: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17375/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 15: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17202/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: numa: move activation check in the caller
Francesco Romani has uploaded a new change for review.
Change subject: virt: numa: move activation check in the caller
..
virt: numa: move activation check in the caller
The existing NUMA position reporting code is activated
only if a VM is configured with 'virtual NUMA', referred
in the code as 'guest Numa Node'.
If this configuration is absent, the NUMA sampling just
does nothing.
Besides naming, this makes the code a bit harder to read
and to reason about, since often readers assume NUMA positioning
reporting always executed.
To make this easier to read, and to make room for future patches
which want to move NUMA sampling in periodic operations,
we move this check into the calling site(s), with no other intended
changes in the flow of code.
Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/numaUtilsTests.py
M vdsm/numaUtils.py
M vdsm/virt/vm.py
3 files changed, 22 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/39261/1
diff --git a/tests/numaUtilsTests.py b/tests/numaUtilsTests.py
index f872f3d..5a5a8ff 100644
--- a/tests/numaUtilsTests.py
+++ b/tests/numaUtilsTests.py
@@ -72,5 +72,6 @@
with fake.VM(VM_PARAMS) as testvm:
testvm._vmStats = fake.VmStatsThread(testvm)
expectedResult = {'0': [0, 1], '1': [0, 1]}
+self.assertTrue(testvm.hasGuestNumaNode)
vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(testvm)
self.assertEqual(expectedResult, vmNumaNodeRuntimeMap)
diff --git a/vdsm/numaUtils.py b/vdsm/numaUtils.py
index 01a4270..761a083 100644
--- a/vdsm/numaUtils.py
+++ b/vdsm/numaUtils.py
@@ -67,24 +67,23 @@
vmNumaNodeRuntimeMap = {}
-if 'guestNumaNodes' in vm.conf:
-vcpu_to_pcpu = _get_mapping_vcpu_to_pcpu(vm)
-if vcpu_to_pcpu:
-vm_numa_placement = defaultdict(set)
+vcpu_to_pcpu = _get_mapping_vcpu_to_pcpu(vm)
+if vcpu_to_pcpu:
+vm_numa_placement = defaultdict(set)
-vcpu_to_pnode = supervdsm.getProxy().getVcpuNumaMemoryMapping(
-vm.conf['vmName'].encode('utf-8'))
-pcpu_to_pnode = _get_mapping_pcpu_to_pnode()
-vcpu_to_vnode = _get_mapping_vcpu_to_vnode(vm)
+vcpu_to_pnode = supervdsm.getProxy().getVcpuNumaMemoryMapping(
+vm.conf['vmName'].encode('utf-8'))
+pcpu_to_pnode = _get_mapping_pcpu_to_pnode()
+vcpu_to_vnode = _get_mapping_vcpu_to_vnode(vm)
-for vcpu_id, pcpu_id in vcpu_to_pcpu.iteritems():
-vnode_index = str(vcpu_to_vnode[vcpu_id])
-vm_numa_placement[vnode_index].add(pcpu_to_pnode[pcpu_id])
-vm_numa_placement[vnode_index].update(
-vcpu_to_pnode.get(vcpu_id, ()))
+for vcpu_id, pcpu_id in vcpu_to_pcpu.iteritems():
+vnode_index = str(vcpu_to_vnode[vcpu_id])
+vm_numa_placement[vnode_index].add(pcpu_to_pnode[pcpu_id])
+vm_numa_placement[vnode_index].update(
+vcpu_to_pnode.get(vcpu_id, ()))
-vmNumaNodeRuntimeMap = dict((k, list(v)) for k, v in
-vm_numa_placement.iteritems())
+vmNumaNodeRuntimeMap = dict((k, list(v)) for k, v in
+vm_numa_placement.iteritems())
return vmNumaNodeRuntimeMap
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index dc226fb..af624cc 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -258,7 +258,9 @@
Numa CPU assignments.
-vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
+vmNumaNodeRuntimeMap = {}
+if self._vm.hasGuestNumaNode:
+numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
return vmNumaNodeRuntimeMap
def _sampleDisk(self):
@@ -5024,6 +5026,10 @@
statsAge)
stats['monitorResponse'] = '-1'
+@property
+def hasGuestNumaNode(self):
+return 'guestNumaNodes' in self.conf
+
class LiveMergeCleanupThread(threading.Thread):
def __init__(self, vm, jobId, drive, doPivot):
--
To view, visit https://gerrit.ovirt.org/39261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
automat...@ovirt.org has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 26: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17200/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 15: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17376/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 37: * Update tracker::#1139217::OK * Check Bug-Url::OK * Check Public Bug::#1139217::OK, public bug * Check Product::#1139217::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 2: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17374/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 37: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17201/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 17: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17399/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17227/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 4: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17223/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
automat...@ovirt.org has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: restore highWrite monitoring
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: restore highWrite monitoring .. Patch Set 29: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: restore highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: restore highWrite monitoring .. Patch Set 29: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17229/ -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: restore highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: restore highWrite monitoring .. Patch Set 29: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17403/ -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: drop now unused code .. Patch Set 29: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17228/ -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
automat...@ovirt.org has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: periodic bulk stats sampling .. Patch Set 39: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17398/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: periodic bulk stats sampling .. Patch Set 39: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17224/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 18: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17400/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: drop now unused code .. Patch Set 29: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17402/ -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (1/6) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17401/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 17: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17225/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 18: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17226/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop now unused code
automat...@ovirt.org has posted comments on this change. Change subject: virt: drop now unused code .. Patch Set 29: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
Francesco Romani has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 2: Verified+1 verified just booting a VM on a patched VDSM: Thread-259::DEBUG::2015-03-27 11:03:51,600::sampling::467::vm.Vm::(run) vmId=`96721047-f7cf-4b0a-b828-412a242afdbb`::Stats thread started -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/405/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/411/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/782/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4791/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (9/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/412/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/816/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
automat...@ovirt.org has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/810/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
Dan Kenigsberg has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: make _initVmStats public .. virt: make _initVmStats public A followup patch want to add an explicit stopVmStats method. Currently, we have a private helper to start the Vm Stats Thread: _initVmStats. It could be surprising to have a private method to start and a public one to stop, so this patch renames _initVmStats into startVmStats to make the flows symmetric, with no further changes in the code flow. Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39036 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmApiTests.py M vdsm/virt/vm.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/815/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
Dan Kenigsberg has submitted this change and it was merged. Change subject: clientIF: stop VmStatsThread on shutdown .. clientIF: stop VmStatsThread on shutdown Explicitily stop VmStatsThreads when VDSM is shutting down. This patch makes the flow faster and safer when libvirtd crashes Without this patch, the VmStatsThread exit on shutdown because they find Vm._dom equals None, and they exit with a stacktrace as soon as they woke up for their polling. With this patch, we make things explicit. Relates-To: https://bugzilla.redhat.com/1203210 Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39038 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/clientIF.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
automat...@ovirt.org has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
Dan Kenigsberg has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/412/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
Francesco Romani has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 2: Verified+1 verified that VmStatsThread is stopped both using clean shutdown from Engine and by abruptingly killing QEMU from a root shell. In both cases: Thread-558::DEBUG::2015-03-27 11:12:14,578::sampling::445::vm.Vm::(stop) vmId=`fd62f2fd-b378-4d39-af76-d047fa2c645e`::Stop statistics collection Thread-332::DEBUG::2015-03-27 11:12:14,579::sampling::476::vm.Vm::(run) vmId=`fd62f2fd-b378-4d39-af76-d047fa2c645e`::Stats thread finished -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: packaging: bump libvirt requirements
Francesco Romani has posted comments on this change. Change subject: packaging: bump libvirt requirements .. Patch Set 3: OK on RHEL 7.1: HOji 11:46:18 root [~]$ rpm -qi vdsm Name: vdsm Version : 4.17.0 Release : 583.git888e8eb.el7 Architecture: x86_64 Install Date: Fri 27 Mar 2015 11:44:55 AM CET Group : Applications/System Size: 3394076 License : GPLv2+ Signature : (none) Source RPM : vdsm-4.17.0-583.git888e8eb.el7.src.rpm Build Date : Fri 27 Mar 2015 11:44:50 AM CET Build Host : hoji.rokugan.lan Relocations : (not relocatable) URL : http://www.ovirt.org/wiki/Vdsm Summary : Virtual Desktop Server Manager Description : The VDSM service is required by a Virtualization Manager to manage the Linux hosts. VDSM manages and monitors the host's storage, memory and networks as well as virtual machine creation, other host administration tasks, statistics gathering, and log collection. HOji 11:46:20 root [~]$ rpm -qR vdsm | grep libvirt libvirt-client libvirt-daemon = 1.2.8-15.el7 libvirt-daemon-config-nwfilter libvirt-daemon-driver-network libvirt-daemon-driver-nwfilter libvirt-daemon-driver-qemu libvirt-lock-sanlock libvirt-python HOji 11:46:25 root [~]$ cat /etc/redhat-release Red Hat Enterprise Linux Server release 7.1 (Maipo) -- To view, visit https://gerrit.ovirt.org/38538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie63d27705f47690f9788228a2af207e0f439c04a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Fix minimal timeout when performing scsi scan
Nir Soffer has posted comments on this change. Change subject: iscsi: Fix minimal timeout when performing scsi scan .. Patch Set 2: Code-Review-1 Testing on rhev-h show that we do sleep now 2 seconds as designed, but it does not fix the failure in the createStorageDomain flow. We are using *no* minTimeout since Sep 2013, and never seen issues related to it, so a better fix may be to remove the minimal timeout after rescan and the iscsi_rescan_minimal_timeout option. -- To view, visit https://gerrit.ovirt.org/39256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c62ed29c67698d689f8a345e6a740363c77c0d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/401/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: add stopVmStats method .. vm: add stopVmStats method Add a method to allow clients of Vm class to shutdown the VmStatsThread. Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39037 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make _initVmStats public
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make _initVmStats public .. Patch Set 3: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/400/ -- To view, visit https://gerrit.ovirt.org/39036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19ed15cc6743dba3baee13643ac39a5814b8ade Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 3: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4793/ -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/811/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/783/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
Francesco Romani has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 2: Verified+1 verification: - runned a patched VDSM (including all three patches in the series) - booted 4 VMs - killed libvirt using kill -ABRT $LIBVIRT_PID - inspected vdsm logs: found MainThread::DEBUG::2015-03-27 11:18:43,317::vmchannels::192::vds::(stop) VM channels listener was stopped. MainThread::DEBUG::2015-03-27 11:18:43,331::sampling::445::vm.Vm::(stop) vmId=`65365b4c-da8f-4fc3-82de-e0e43054bbe5`::Stop statistics collection MainThread::DEBUG::2015-03-27 11:18:43,346::sampling::445::vm.Vm::(stop) vmId=`7b6fc7c8-b351-4b93-8972-03dbc7aaa5a2`::Stop statistics collection Thread-821::DEBUG::2015-03-27 11:18:43,347::sampling::476::vm.Vm::(run) vmId=`65365b4c-da8f-4fc3-82de-e0e43054bbe5`::Stats thread finished MainThread::DEBUG::2015-03-27 11:18:43,348::sampling::445::vm.Vm::(stop) vmId=`a7769b63-5cb9-4d48-8c3c-ac8395e2a202`::Stop statistics collection Thread-811::DEBUG::2015-03-27 11:18:43,348::sampling::476::vm.Vm::(run) vmId=`7b6fc7c8-b351-4b93-8972-03dbc7aaa5a2`::Stats thread finished MainThread::DEBUG::2015-03-27 11:18:43,349::sampling::445::vm.Vm::(stop) vmId=`96721047-f7cf-4b0a-b828-412a242afdbb`::Stop statistics collection Thread-786::DEBUG::2015-03-27 11:18:43,349::sampling::476::vm.Vm::(run) vmId=`a7769b63-5cb9-4d48-8c3c-ac8395e2a202`::Stats thread finished MainThread::DEBUG::2015-03-27 11:18:43,350::sampling::445::vm.Vm::(stop) vmId=`e6ebae82-e9d8-4791-81c6-d7eb1d943bb3`::Stop statistics collection Thread-857::DEBUG::2015-03-27 11:18:43,350::sampling::476::vm.Vm::(run) vmId=`96721047-f7cf-4b0a-b828-412a242afdbb`::Stats thread finished MainThread::INFO::2015-03-27 11:18:43,351::momIF::87::MOM::(stop) Shutting down MOM VDSM was correctly restarted shortly after. -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Michal Skrivanek has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 5:
(4 comments)
https://gerrit.ovirt.org/#/c/36701/5/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 119: if self.hibernating:
Line 120: return
Line 121:
Line 122: # FIXME: The port will depend on the binding being used.
Line 123: # This assumes xmlrpc
so this is not valid anymore?
Line 124: hostPort = vdscli.cannonizeHostPort(
Line 125: self._dst,
Line 126: config.getint('addresses', 'management_port'))
Line 127: self.remoteHost, port = hostPort.rsplit(':', 1)
Line 129: try:
Line 130: client_socket = self._createSocket(port)
Line 131: reactor = self._vm.cif.getReactor(stomp)
Line 132: self._destServer = jsonrpcvdscli.connect(reactor,
client_socket)
Line 133: self.log.debug('Initiating connection with destination')
why do you drop the log of hostport as in the original code? Now it's only in
the except case below
Line 134: self._destServer.ping()
Line 135:
Line 136: except Exception:
Line 137: if config.getboolean('vars', 'ssl'):
Line 130: client_socket = self._createSocket(port)
Line 131: reactor = self._vm.cif.getReactor(stomp)
Line 132: self._destServer = jsonrpcvdscli.connect(reactor,
client_socket)
Line 133: self.log.debug('Initiating connection with destination')
Line 134: self._destServer.ping()
can we factor this out in a helper function/method?
well, this whole method is a helper method...
anyway - does it do a real ping or something else? why?
Line 135:
Line 136: except Exception:
Line 137: if config.getboolean('vars', 'ssl'):
Line 138: self._destServer = vdscli.connect(
Line 134: self._destServer.ping()
Line 135:
Line 136: except Exception:
Line 137: if config.getboolean('vars', 'ssl'):
Line 138: self._destServer = vdscli.connect(
so now we have an implicit fallback to XMLRPC?
Line 139: hostPort,
Line 140: useSSL=True,
Line 141: TransportClass=kaxmlrpclib.TcpkeepSafeTransport)
Line 142: else:
--
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown
automat...@ovirt.org has posted comments on this change. Change subject: clientIF: stop VmStatsThread on shutdown .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add stopVmStats method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add stopVmStats method .. Patch Set 3: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4792/ -- To view, visit https://gerrit.ovirt.org/39037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I008b94a65dc2f24426f1c3ecdb256005b74b3bde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: convert print statements to functions
Francesco Romani has posted comments on this change.
Change subject: convert print statements to functions
..
Patch Set 3:
(15 comments)
initial review. Most (but not all) comments boil down to two points
- sometimes 'from __future__ ...' seems not needed, as it seems the only change
in a file
- sometimes 'from __future__' is nicely put as first line after the copyright
block and before all imports, sometimes it is the very first line of the file.
Why the latter? I see no problems with the former, and I like it more.
https://gerrit.ovirt.org/#/c/37997/3/client/vdsClient.py
File client/vdsClient.py:
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20: from __future__ import print_function
I didn't expect this but on second thought, why not?
Line 21: import sys
Line 22: import ast
Line 23: import getopt
Line 24: import traceback
https://gerrit.ovirt.org/#/c/37997/3/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 18: #
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21:
Line 22: from __future__ import print_function
do we need this there or it is just for consistency?
Line 23: import xmlrpclib
Line 24: import os
Line 25: import re
Line 26: import sys
https://gerrit.ovirt.org/#/c/37997/3/tests/cPopenTests.py
File tests/cPopenTests.py:
Line 1: from __future__ import print_function
why up here?
Line 2: #
Line 3: # Copyright 2012 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
https://gerrit.ovirt.org/#/c/37997/3/tests/fileSDTests.py
File tests/fileSDTests.py:
Line 1: from __future__ import print_function
why up here?
Line 2: #
Line 3: # Copyright 2014 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
https://gerrit.ovirt.org/#/c/37997/3/tests/miscTests.py
File tests/miscTests.py:
Line 1: from __future__ import print_function
why up here?
Line 2: #
Line 3: # Copyright 2012 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
https://gerrit.ovirt.org/#/c/37997/3/tests/scheduleTests.py
File tests/scheduleTests.py:
Line 1: from __future__ import print_function
same, why up here?
Line 2: #
Line 3: # Copyright 2014 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
https://gerrit.ovirt.org/#/c/37997/3/tests/sslTests.py
File tests/sslTests.py:
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: from __future__ import print_function
do we need this or it is just for consistency?
Line 22: import errno
Line 23: import os
Line 24: import re
Line 25: import SimpleXMLRPCServer
https://gerrit.ovirt.org/#/c/37997/3/vdsm/hooks.py
File vdsm/hooks.py:
Line 1: from __future__ import print_function
same, why up here?
Line 2: #
Line 3: # Copyright 2010-2011 Red Hat, Inc.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
https://gerrit.ovirt.org/#/c/37997/3/vdsm/network/api.py
File vdsm/network/api.py:
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20: from __future__ import print_function
do we need this or it is just for consistency?
Line 21: from functools import wraps
Line 22: import errno
Line 23: import inspect
Line 24: import sys
https://gerrit.ovirt.org/#/c/37997/3/vdsm/storage/threadPool.py
File vdsm/storage/threadPool.py:
Line 1: from __future__ import print_function
why up here?
Line 2: #
Line 3: # Adapted by Red Hat from
Line 4: #
http://code.activestate.com/recipes/203871-a-generic-programming-thread-pool/
Line 5: # Author: Tim Lesher
https://gerrit.ovirt.org/#/c/37997/3/vdsm_hooks/allocate_net/before_device_create.py
File vdsm_hooks/allocate_net/before_device_create.py:
Line 17: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA
Line 18: #
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: from __future__ import print_function
do we need this or it is for consistency's sake?
Line 22: import os
Line 23: import random
Line 24:
Line 25: from xml.dom import minidom
https://gerrit.ovirt.org/#/c/37997/3/vdsm_hooks/ethtool_options/ethtool_options.py
File vdsm_hooks/ethtool_options/ethtool_options.py:
Line 62: print('splits into: ')
Line 63: for subcmd in
_parse_into_subcommands(opts['ethtool_opts'].split()):
Line 64: command = ([ETHTOOL_BINARY.cmd] + [subcmd.name, subcmd.device]
+
Line 65:subcmd.flags)
Line 66: print((''), end=' ')
why the 'end' parameter? Can't see the benefit, can you please elaborate?
Line 67: print(command)
Line 68:
Line 69: # Test with the correct nics
Change in vdsm[master]: vm: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 27: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17382/ -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 37: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17375/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17376/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 35: Build Started (2/6) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17380/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateNumaInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port updateNumaInfo .. Patch Set 9: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17383/ -- To view, visit https://gerrit.ovirt.org/38598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f95eb81d5331432f9934b1a41f74ace37e902cd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce support for periodic operations
Francesco Romani has posted comments on this change. Change subject: virt: introduce support for periodic operations .. Patch Set 26: -Verified version 26 also changes how executor and scheduler are stopped, thus requires (little) more verification. -- To view, visit https://gerrit.ovirt.org/37593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17200/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17374/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 16: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17390/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: numa: move activation check in the caller
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: numa: move activation check in the caller .. Patch Set 2: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17389/ -- To view, visit https://gerrit.ovirt.org/39261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 38: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17214/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
automat...@ovirt.org has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 17: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17217/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: numa: move activation check in the caller
automat...@ovirt.org has posted comments on this change. Change subject: virt: numa: move activation check in the caller .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: numa: move activation check in the caller
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: numa: move activation check in the caller .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17215/ -- To view, visit https://gerrit.ovirt.org/39261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 16: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17216/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port queryBlockJobs
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: port queryBlockJobs .. Patch Set 28: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 38: * Update tracker::#1139217::OK * Check Bug-Url::OK * Check Public Bug::#1139217::OK, public bug * Check Product::#1139217::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: periodic bulk stats sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: periodic bulk stats sampling .. Patch Set 38: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17388/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 3: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17387/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 3: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17213/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop now unused code
Francesco Romani has posted comments on this change. Change subject: virt: drop now unused code .. Patch Set 29: Verified+1 rebased, copied score -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 36: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1251/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (3/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/685/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (4/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1252/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (5/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/693/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 36: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17393/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1233/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: split up stats production .. Patch Set 37: Build Started (6/6) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1234/ -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's driver element
Francesco Romani has posted comments on this change. Change subject: virt: keep libvirt's driver element .. Patch Set 5: Commenting code is a good step forward, but comment on line 4511 reads # If a driver was reported, pass it back to libvirt. I really appreciate the good intentions, but this helps little since it translates the code -which is already pretty self-explanatory- in english What ispuzzling me of is _why_ and _when_ this 'driver' is being reported. There is any good reason or it is just libvirt being lunatic? :) Again, I see no reason to stop this patch, I just want to learn more about this matter. For that, a RTFM (but with some meaningful starting point please, not just generic reference to the docs!) is fine for me. -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's driver element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's driver element .. Patch Set 6: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/404/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's driver element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's driver element .. Patch Set 6: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/410/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's driver element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's driver element .. Patch Set 6: Build Started (9/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/815/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: keep libvirt's driver element
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: keep libvirt's driver element .. Patch Set 6: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/399/ -- To view, visit https://gerrit.ovirt.org/39034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
Piotr Kliczewski has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38806/8/tests/functional/vdscliTests.py File tests/functional/vdscliTests.py: Line 26: from vdsm import vdscli Line 27: Line 28: Line 29: class ConnectTest(TestCaseBase): Line 30: We have 2 tests run for useSSL true and false. Please use permutations and get rid of code duplication. Line 31: @ValidateRunningAsRoot Line 32: def testTimeoutSafeTransport(self): Line 33: c = vdscli.connect(useSSL=True, Line 34:tsPath='/etc/pki/vdsm', -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: dispatch work to VMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: dispatch work to VMs .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17385/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0422bfce99d1e479cb5af49c7b37204ca7e295 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: numa: move activation check in the caller
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: numa: move activation check in the caller .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17386/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1b94c2b45b0cbd4455d4fff719b932173536af3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port updateNumaInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port updateNumaInfo .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17209/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17383/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f95eb81d5331432f9934b1a41f74ace37e902cd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: restore unresponsive on timeout when sampling .. Patch Set 17: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17391/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
automat...@ovirt.org has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 36: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
