Change in vdsm[master]: spec: Update libvrit-daemon and libvirt-python requirements

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Update libvrit-daemon and libvirt-python requirements
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/744/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17504/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1311/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17678/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/754/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1296/ 
: FAILURE

-- 
To view, visit https://gerrit.ovirt.org/39551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/38281/15//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-03-19 10:12:17 +0200
Line 4: Commit: Ido Barkan ibar...@redhat.com
Line 5: CommitDate: 2015-04-05 09:32:40 +0300
Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
This is actually Introducing vdsm-tool dump-volume-chains
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
Line 10: volumes and prints them in an ordered fashion with optional
Line 11: additional info per volume.


Line 5: CommitDate: 2015-04-05 09:32:40 +0300
Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
This script - This command
Line 10: volumes and prints them in an ordered fashion with optional
Line 11: additional info per volume.
Line 12: 
Line 13: Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404


Line 6: 
Line 7: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
Line 8: 
Line 9: This script queries VDSM about the existing structure of image
Line 10: volumes and prints them in an ordered fashion with optional
Remove optional
Line 11: additional info per volume.
Line 12: 
Line 13: Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/743/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17501/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1310/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17675/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1292/ 
: FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/753/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Update libvrit-daemon and libvirt-python requirements

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Update libvrit-daemon and libvirt-python requirements
..


Patch Set 3:

Build Started (6/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/754/

-- 
To view, visit https://gerrit.ovirt.org/39551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/38281/15/tests/vdsmDumpChainsTests.py
File tests/vdsmDumpChainsTests.py:

Line 24: 
Line 25: 
Line 26: class GetVolumeChainTests(TestCaseBase):
Line 27: def test_empty(self):
Line 28: self.assertEqual(_build_volume_chain([], 0), [])
All the tests fail because you changed the signature of _build_volume_chains.

See http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17641/console
Line 29: 
Line 30: def test_only_base_volume(self):
Line 31: self.assertEqual(_build_volume_chain([(_BLANK_UUID, 'a')], 0), 
['a'])
Line 32: 


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: v2v: make sure not virt-v2v processes leftovers

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: v2v: make sure not virt-v2v processes leftovers
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/37938/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 117: else:
Line 118: with _lock:
Line 119: del _jobs[jobId]
Line 120: if _jobs:
Line 121: kill_zombie_jobs()
We don't need this, when ImportVM thread dies, the virt-v2v process it started 
gets a SIGKILL.
Line 122: return {'status': doneCode, 'ovf': ovf}
Line 123: 
Line 124: 
Line 125: def kill_zombie_jobs():


-- 
To view, visit https://gerrit.ovirt.org/37938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4788fdc57bae4047b2f83bcb56b790df58c46814
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: build: Update required device-mapper-multipath version

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: build: Update required device-mapper-multipath version
..


Patch Set 7:

(1 comment)

I think this is ready.

https://gerrit.ovirt.org/#/c/38359/7/vdsm.spec.in
File vdsm.spec.in:

Line 214: Requires: sanlock = 2.8, sanlock-python
Line 215: 
Line 216: %if 0%{?rhel}
Line 217: %if 0%{?rhel} = 7
Line 218: Requires: device-mapper-multipath = 0.4.9-68
 Need to wait till this hits CentOS repos.
On my Centos 7.1:

   # yum info device-mapper-multipath | egrep 'Version|Release'
   Version : 0.4.9
   Release : 77.el7
Line 219: Requires: e2fsprogs
Line 220: Requires: fence-agents-all
Line 221: Requires: lvm2
Line 222: Requires: python


-- 
To view, visit https://gerrit.ovirt.org/38359
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6700630729d845603f1efe347ac07aac9ded7a92
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: v2v: make sure not virt-v2v processes leftovers

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: v2v: make sure not virt-v2v processes leftovers
..


Patch Set 1:

Mihcal, if vdsm crashes, the kernel is responsible to kill the virt-v2v 
processes. Vdsm is not supervising the kernel.

-- 
To view, visit https://gerrit.ovirt.org/37938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4788fdc57bae4047b2f83bcb56b790df58c46814
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/38281/15/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 206: print('Images volume chains (base volume first)')
Line 207: for img_uuid, vol_chain in image_chains.iteritems():
Line 208: print('')
Line 209: _print_line(img_uuid, 'image:')
Line 210: 
An empty line here will make the output more clear.
Line 211: if isinstance(vol_chain, ChainError):
Line 212: chain_err = vol_chain
Line 213: _print_line(chain_err.description)
Line 214: _print_line('Volumes and children:')


Line 222: _print_line('- ' + vol)
Line 223: try:
Line 224: _print_vol_info(volumes_info[vol])
Line 225: except KeyError:
Line 226: _print_line(no volume info for volume %s % 
(vol,))
I think this is not possible like in the chain error code path. For each volume 
in an image we get volume info from vdsm in _get_volume_chains.
Line 227: print('')
Line 228: 
Line 229: 
Line 230: def _print_vol_info(volume_info):


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 3: Code-Review-1

Please wait until the master version is merged, and then backport the patch 
from master. Otherwise this patch may be missing fixes from master, or metadata 
added when when patch is merged to master.

-- 
To view, visit https://gerrit.ovirt.org/39555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: v2v: Introduce OutputParser

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: v2v: Introduce OutputParser
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/39360
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f3d610d704d0b922e38073edcc813cbc27fe83
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...

2015-04-05 Thread amureini
Allon Mureinik has posted comments on this change.

Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using 
hardware iSCSI)
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/38354/6//COMMIT_MSG
Commit Message:

Line 21: 
Line 22: This patch is fixing the code to allow missing
Line 23: /sys/devices/platform/hostN/sessionS.
Line 24: 
Line 25: Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Amit - please add yourself as a signed-off


-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread ibarkan
Ido Barkan has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 14: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/38281/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 122: 
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(server.getVolumeInfo, sd_uuid, sp_uuid, 
img_uuid,
Line 125:vol_uuid)
Line 126: return defaultdict(_missing_volume_key, res['info'])
 Not sure about wrapping in this level. This is great for printing, but may 
Done
Line 127: 
Line 128: 
Line 129: def _get_volumes_chains(server, sd_uuid):
Line 130: sp_uuid = _get_sp_uuid(server)


Line 131: images_uuids = _get_all_images(server, sd_uuid)
Line 132: 
Line 133: image_chains = {}  # {image_uuid - vol_chain}
Line 134: # {vol_uuid- vol_info}
Line 135: volumes_info = defaultdict(lambda: 
defaultdict(_missing_volume_key))
 I'm not sure this is good idea, better to handle missing volume into with s
this was a bad idea. better to wrap the volume info values dict right before we 
print them.
Line 136: 
Line 137: for img_uuid in images_uuids:
Line 138: volumes = _get_volumes_for_image(server, img_uuid, sd_uuid, 
sp_uuid)
Line 139: 


Line 216: _print_line('Volumes and children:')
Line 217: print('')
Line 218: for parent, child in chain_err.volumes_children:
Line 219: _print_line('- %s - %s' % (parent, child))
Line 220: _print_vol_info(volumes_info[child])
 If we use default dict only in the volume info, we can do:
child volume info must exist at this point. On the other hand, it's parent info 
might not.
Line 221: print('')
Line 222: else:
Line 223: for vol in vol_chain:
Line 224: _print_line('- ' + vol)


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread ibarkan
Ido Barkan has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/38281/13/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 201: 
Line 202: _LINE_FORMAT = '{0:^13}{1}'
Line 203: 
Line 204: 
Line 205: def _print_vol_info(child, volumes_info):
 _print_vol_info only needs to know about a single volume info
Done
Line 206: info_fmt = status: {status}, voltype: {voltype}, format: 
{format},  \
Line 207:legality: {legality}, type: {type}
Line 208: try:
Line 209: formatted_info = info_fmt.format(**volumes_info[child])


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (6/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1284/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (4/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/735/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (2/6) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17641/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (5/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1302/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (1/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/743/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..


Patch Set 15:

Build Started (3/6) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17467/

-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vladik Romanovsky vladik.romanov...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Dary yd...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 7:

Build Started (1/2) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17473/

-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 7:

Build Started (2/2) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17647/

-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: unused import
..

unused import

Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/39540/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 0deb99a..0dc5539 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -36,7 +36,6 @@
 from vdsm import sysctl
 from vdsm.utils import CommandPath, RollbackContext, execCmd, pgrep, running
 
-import caps
 from network import api, errors, tc
 from network.configurators.ifcfg import Ifcfg
 from network.sourceroute import StaticSourceRoute


-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..

DhclientLeases does not need to be skipped if el6 (el6 is not
supported anymore)

Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/39538/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index cf00854..35a1854 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1859,10 +1859,6 @@
 @cleanupNet
 @RequireVethMod
 def testDhclientLeases(self, (family, dateFormat)):
-el6 = _system_is_el6()
-if el6 and family == 6:
-raise SkipTest(el6's dnsmasq does not support DHCPv6)
-
 dhcpv4_ifaces = set()
 dhcpv6_ifaces = set()
 with vethIf() as (server, client):


-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..

delete_dhclient_leases does not need to consider el6 anymore

Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/dhcp.py
M tests/functional/networkTests.py
2 files changed, 6 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/39535/1

diff --git a/tests/functional/dhcp.py b/tests/functional/dhcp.py
index 68a9d4c..47f8e0d 100644
--- a/tests/functional/dhcp.py
+++ b/tests/functional/dhcp.py
@@ -34,7 +34,6 @@
 _DHCLIENT_TIMEOUT = 10
 _WAIT_FOR_STOP_TIMEOUT = 2
 DHCLIENT_LEASE = '/var/lib/dhclient/dhclient{0}--{1}.lease'
-DHCLIENT_LEASE_EL6 = '/var/lib/dhclient/dhclient{0}-{1}.leases'
 
 
 class DhcpError(Exception):
@@ -158,9 +157,8 @@
 return executable == _DHCLIENT_BINARY.cmd
 
 
-def delete_dhclient_leases(iface, dhcpv4=False, dhcpv6=False, el6=False):
-lease_file = DHCLIENT_LEASE_EL6 if el6 else DHCLIENT_LEASE
+def delete_dhclient_leases(iface, dhcpv4=False, dhcpv6=False):
 if dhcpv4:
-rmFile(lease_file.format('', iface))
+rmFile(DHCLIENT_LEASE.format('', iface))
 if dhcpv6:
-rmFile(lease_file.format('6', iface))
+rmFile(DHCLIENT_LEASE.format('6', iface))
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 8671244..cc63895 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1827,8 +1827,7 @@
 self.assertRuleDoesNotExist(rule)
 finally:
 dhcp.delete_dhclient_leases(
-NETWORK_NAME if bridged else right, dhcpv4, dhcpv6,
-el6)
+NETWORK_NAME if bridged else right, dhcpv4, dhcpv6)
 
 @cleanupNet
 @RequireVethMod
@@ -1868,12 +1867,10 @@
 with dnsmasqDhcp(left, el6):
 try:
 setup_test_network(dhcp=True)
-dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True,
-el6=el6)
+dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True)
 setup_test_network(dhcp=False)
 finally:
-dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True,
-el6=el6)
+dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True)
 
 @permutations([[(4, 'default')], [(4, 'local')], [(6, None)]])
 @cleanupNet


-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 1:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2844/

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17474/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17648/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2840/ 
: There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: unused import
..


Patch Set 1:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2845/

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17475/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17649/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2841/ 
: There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove testLegacyBonds. we don't support el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove testLegacyBonds. we don't support el6 anymore
..


Patch Set 1:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17650/

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17477/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17651/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2843/ 
: There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 1:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17652/

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Using vdsm-tool restore-conf in init script instead of direc...

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Using vdsm-tool restore-conf in init script instead of direct 
call
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23304769f87af8c696555e9e256957a9d855665
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread nsoffer
Hello Adam Litke,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/39543

to review the following change.

Change subject: spec: Simplify libvirt dependencies
..

spec: Simplify libvirt dependencies

We had complicated if else mess that makes it hard to understand, and
impossible to require the right version for each supported platform.

Now we have a rule for each platform version, and we can just remove the
rule when we stop supporting a platform, without breaking anything else.

Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Relates-To: https://bugzilla.redhat.com/1158563
Relates-To: https://bugzilla.redhat.com/1176673
Signed-off-by: Adam Litke ali...@redhat.com
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/39543/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index ec0b377..e03cefd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -191,15 +191,19 @@
 Requires: libvirt-daemon-driver-nwfilter
 Requires: libvirt-daemon-driver-qemu
 %endif
-%if 0%{?rhel}
+
 %if 0%{?rhel} = 7
 Requires: libvirt-daemon = 1.2.8-15.el7
-%else
+%endif
+
+%if 0%{?rhel} == 6
 Requires: libvirt = 0.10.2-29.el6_5.4
-%endif # rhel 7
-%else # fedora
+%endif
+
+%if 0%{?fedora} = 20
 Requires: libvirt = 1.2.9
 %endif
+
 Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client
 
 # iscsi-intiator versions


-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Using vdsm-tool restore-conf in init script instead of direc...

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Using vdsm-tool restore-conf in init script instead of direct 
call
..


Patch Set 4: -Verified

-- 
To view, visit https://gerrit.ovirt.org/39497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23304769f87af8c696555e9e256957a9d855665
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: Using vdsm-tool restore-conf in init script instead of direc...

2015-04-05 Thread ibarkan
Ido Barkan has posted comments on this change.

Change subject: Using vdsm-tool restore-conf in init script instead of direct 
call
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/39496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23304769f87af8c696555e9e256957a9d855665
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 2:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2848/

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: Using vdsm-tool restore-conf in init script instead of direc...

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Using vdsm-tool restore-conf in init script instead of direct 
call
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/39496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23304769f87af8c696555e9e256957a9d855665
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: Using vdsm-tool restore-conf in init script instead of direc...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Using vdsm-tool restore-conf in init script instead of direct 
call
..


Patch Set 7:

* Update tracker::#1208752::OK
* Set MODIFIED::bug 1208752#1208752IGNORE, not oVirt prod but Red Hat 
Enterprise Virtualization Manager

-- 
To view, visit https://gerrit.ovirt.org/39496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23304769f87af8c696555e9e256957a9d855665
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 2:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17656/

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove support for legacy bodnds.

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove support for legacy bodnds.
..


Patch Set 2:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17658/

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 2:

Build Started (4/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1304/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: unused import
..


Patch Set 2:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17659/

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 3:

Build Started (3/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/738/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 3:

Build Started (4/6) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17662/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: unused import
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17485/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17659/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2850/ 
: There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: SDM: add the copyVolumeData command

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: SDM: add the copyVolumeData command
..


Patch Set 9:

Build Started (2/2) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17664/

-- 
To view, visit https://gerrit.ovirt.org/38501
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30e44a6332ec343f64793b0fedaf9ef75a872cac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tmp5

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tmp5
..


Patch Set 1:

Build Started (2/2) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17665/

-- 
To view, visit https://gerrit.ovirt.org/39546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46f61df9350b111e0ddee681ce073345709d3b56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: SDM: add the copyVolumeData command

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: SDM: add the copyVolumeData command
..


Patch Set 9:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17490/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17664/ : FAILURE

-- 
To view, visit https://gerrit.ovirt.org/38501
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30e44a6332ec343f64793b0fedaf9ef75a872cac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tmp

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tmp
..


Patch Set 1:

Build Started (2/2) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17666/

-- 
To view, visit https://gerrit.ovirt.org/39547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67a2fa5af269a4e7043c1bda9eb24b9f3f8ea248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: tmp

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tmp
..


Patch Set 1:

Build Started (2/2) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17667/

-- 
To view, visit https://gerrit.ovirt.org/39548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47c816e9d453dca595fc7abb4a84b301c34fc624
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: v2v: Job related actions

2015-04-05 Thread shavivi
Shahar Havivi has posted comments on this change.

Change subject: v2v: Job related actions
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/39361/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 198: job = _get_job(job_id)
Line 199: job.abort()
Line 200: _remove_job(job_id)
Line 201: except ClientError as e:
Line 202: logging.info('Job %r cannot abort job, error: %r', job_id, e)
 Since all ClientError include now the job id, we don't have to log it here.
Done
Line 203: return errCode[e.err_name]
Line 204: return {'status': doneCode}
Line 205: 
Line 206: 


-- 
To view, visit https://gerrit.ovirt.org/39361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Update libvrit-daemon and libvirt-python requirements

2015-04-05 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: spec: Update libvrit-daemon and libvirt-python requirements
..


Patch Set 1:

Testing availability of the packages:

Centos 7.1

[root@dhcp-1-49 ~]# cat /etc/redhat-release 
CentOS Linux release 7.1.1503 (Core) 
[root@dhcp-1-49 ~]# rpm -q libvirt-daemon
libvirt-daemon-1.2.8-16.el7_1.2.x86_64
[root@dhcp-1-49 ~]# rpm -q libvirt-python
libvirt-python-1.2.8-7.el7_1.1.x86_64

RHEL 7.1

[root@voodoo6 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.1 (Maipo)
[root@voodoo6 ~]# rpm -q libvirt-daemon
libvirt-daemon-1.2.8-16.el7_1.3.x86_64
[root@voodoo6 ~]# rpm -q libvirt-python
libvirt-python-1.2.8-7.el7_1.1.x86_64

Fedora 21

[root@voodoo7 ~]# cat /etc/redhat-release 
Fedora release 21 (Twenty One)
[root@voodoo7 ~]# rpm -q libvirt-daemon
libvirt-daemon-1.2.9.2-1.fc21.x86_64
[root@voodoo7 ~]# rpm -q libvirt-python
libvirt-python-1.2.9-2.fc21.x86_64

Fedora 22 - based on Allon comment.

-- 
To view, visit https://gerrit.ovirt.org/39551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5:

Build Started (5/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/743/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5:

Build Started (4/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1310/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/39553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/751/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/743/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17501/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1310/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17675/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1292/ 
: FAILURE

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
..


Patch Set 1:

wahhht how pyflakes and pep8 don't say anything !??!

-- 
To view, visit https://gerrit.ovirt.org/39553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
..


Patch Set 1:

please post to 3.5 as well

-- 
To view, visit https://gerrit.ovirt.org/39553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5:

Build Started (6/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1292/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Update libvrit-daemon and libvirt-python requirements

2015-04-05 Thread amureini
Allon Mureinik has posted comments on this change.

Change subject: spec: Update libvrit-daemon and libvirt-python requirements
..


Patch Set 2: Code-Review+1

Assuming you verified all these rpms are available, +1.

-- 
To view, visit https://gerrit.ovirt.org/39551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571cc86e0f478b4169f398a6d54c96fc8bb4da30
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: spec: Simplify libvirt dependencies

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: Simplify libvirt dependencies
..


Patch Set 5: -Verified

Build Started (6/6) - 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/752/

-- 
To view, visit https://gerrit.ovirt.org/39543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ba0be799ffd23402536e7ef1e7d70f4a8aa797
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/39554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review.

Change subject: vdsm-tool: Remove unneeded imp import
..

vdsm-tool: Remove unneeded imp import

In commit 07beba9e139 (Hack vdsm =4.16.x for vdsm-tool import issues
during upgrade) two imp imports were added. This patch removes the
standard import at the top and leave the import close to the hack.

Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm-tool/vdsm-tool
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/39554/1

diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 1ebc9ae..58c84f5 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -21,7 +21,6 @@
 
 import os
 import sys
-import imp
 import getopt
 import logging
 import textwrap


-- 
To view, visit https://gerrit.ovirt.org/39554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: vdsm-tool: Remove unneeded imp import

2015-04-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: Remove unneeded imp import
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59916f7a199d052af71de7e11f9af9f9e31a5afa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: iscsi: Finding iscsi's host to read netdev attribute fix.

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsi: Finding iscsi's host to read netdev attribute fix.
..


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17473/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17647/ : FAILURE

-- 
To view, visit https://gerrit.ovirt.org/38354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.5]: Hack vdsm =4.16.x for vdsm-tool import issues during upgrade

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Hack vdsm =4.16.x for vdsm-tool import issues during upgrade
..


Patch Set 11:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/205/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/30/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/206/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/199/ : 
SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17478/

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17474/

-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: unused import
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..

testBrokenNetworkReplacement does not need to consider el6 anymore

Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/39539/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 35a1854..0deb99a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -196,12 +196,6 @@
 del attrs['d']
 
 
-def _system_is_el6():
-# REQUIRED_FOR: el6
-return (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
-and caps.osversion()['version'].startswith('6'))
-
-
 @expandPermutations
 class NetworkTest(TestCaseBase):
 
@@ -1922,14 +1916,7 @@
 self.assertEqual(status, SUCCESS, msg)
 self.assertNetworkExists(NETWORK_NAME)
 if bridged:
-if _system_is_el6():
-execCmd([EXT_IFDOWN, NETWORK_NAME])
-rc, _, err = execCmd([EXT_BRCTL, 'delbr', NETWORK_NAME])
-if rc != 0:
-raise self.failureException(failed to delete bridge 
-err:%s, err)
-else:
-ipwrapper.linkDel(NETWORK_NAME)
+ipwrapper.linkDel(NETWORK_NAME)
 else:
 ipwrapper.linkDel(nic + '.' + VLAN_ID)
 


-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..


Patch Set 1:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2840/

-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove testLegacyBonds. we don't support el6 anymore

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: remove testLegacyBonds. we don't support el6 anymore
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17477/

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: unused import
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17479/

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..

dnsmasqDhcp does not need to consider el6 anymore

Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 7 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/39536/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index cc63895..b968cf6 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -105,18 +105,16 @@
 
 
 @contextmanager
-def dnsmasqDhcp(interface, el6=False):
+def dnsmasqDhcp(interface):
 Manages the life cycle of dnsmasq as a DHCP server.
 
 'el6' parameter serves to disable DHCPv6 functionality on EL6 where it is
 not supported, and avoids warning on --bind-interfaces switch elsewhere.
 dhcpServer = dhcp.Dnsmasq()
 try:
-dhcpv6_range_from, dhcpv6_range_to = (
-(None, None) if el6 else (DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO))
+dhcpv6_range_from, dhcpv6_range_to = DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO
 dhcpServer.start(interface, DHCP_RANGE_FROM, DHCP_RANGE_TO,
- dhcpv6_range_from, dhcpv6_range_to, router=IP_GATEWAY,
- bind_dynamic=not el6)
+ dhcpv6_range_from, dhcpv6_range_to, router=IP_GATEWAY)
 except dhcp.DhcpError as e:
 raise SkipTest(e)
 
@@ -1751,15 +1749,11 @@
 @cleanupNet
 @RequireVethMod
 def testSetupNetworksAddDelDhcp(self, (bridged, families)):
-el6 = _system_is_el6()
-if el6 and 6 in families:
-raise SkipTest(el6's dnsmasq does not support DHCPv6)
-
 with vethIf() as (left, right):
 veth.setIP(left, IP_ADDRESS, IP_CIDR)
 veth.setIP(left, IPv6_ADDRESS, IPv6_CIDR, 6)
 veth.setLinkUp(left)
-with dnsmasqDhcp(left, el6):
+with dnsmasqDhcp(left):
 dhcpv4 = 4 in families
 dhcpv6 = 6 in families
 bootproto = 'dhcp' if dhcpv4 else 'none'
@@ -1863,8 +1857,7 @@
 with vethIf() as (left, right):
 veth.setIP(left, IP_ADDRESS, IP_CIDR)
 veth.setLinkUp(left)
-el6 = _system_is_el6()
-with dnsmasqDhcp(left, el6):
+with dnsmasqDhcp(left):
 try:
 setup_test_network(dhcp=True)
 dhcp.delete_dhclient_leases(NETWORK_NAME, dhcpv4=True)
@@ -1887,7 +1880,7 @@
 veth.setIP(server, IPv6_ADDRESS, IPv6_CIDR, 6)
 veth.setLinkUp(server)
 
-with dnsmasqDhcp(server, el6):
+with dnsmasqDhcp(server):
 
 with namedTemporaryDir(dir='/var/lib/dhclient') as dir:
 dhclient_runner = dhcp.DhclientRunner(
@@ -2170,7 +2163,7 @@
 with vethIf() as (server, client):
 veth.setIP(server, IP_ADDRESS, IP_CIDR)
 veth.setLinkUp(server)
-with dnsmasqDhcp(server, _system_is_el6()):
+with dnsmasqDhcp(server):
 with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir:
 # Start a non-vdsm owned dhclient for the 'client' iface
 dhclient_runner = dhcp.DhclientRunner(


-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17475/

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove testLegacyBonds. we don't support el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove testLegacyBonds. we don't support el6 anymore
..


Patch Set 1:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17476/

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove testLegacyBonds. we don't support el6 anymore

2015-04-05 Thread ibarkan
Ido Barkan has uploaded a new change for review.

Change subject: remove testLegacyBonds. we don't support el6 anymore
..

remove testLegacyBonds. we don't support el6 anymore

Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/39537/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index b968cf6..cf00854 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -359,16 +359,6 @@
 for elem in elems:
 self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem)))
 
-def testLegacyBonds(self):
-if not _system_is_el6():
-raise SkipTest('legacy bonds are expected only on el6')
-
-for b in caps._REQUIRED_BONDINGS:
-# assertBondExists is not used here since we do not care about
-# whether the bond exists in the running config; we only need it to
-# be reported to legacy Engines.
-self.assertIn(b, self.vdsm_net.netinfo.bondings)
-
 def assert_active_slave_exists(self, bondName, nics):
 netinfo = self.vdsm_net.netinfo
 self.assertIn(bondName, netinfo.bondings)


-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 1:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2843/

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: delete_dhclient_leases does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: delete_dhclient_leases does not need to consider el6 anymore
..


Patch Set 1:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17648/

-- 
To view, visit https://gerrit.ovirt.org/39535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aae489f11d1c5f63d9079e5059627038bef0954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 1:

Build Started (3/3) - 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17651/

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove testLegacyBonds. we don't support el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove testLegacyBonds. we don't support el6 anymore
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17476/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17650/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2842/ 
: There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 2:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17483/

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove support for legacy bodnds.

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: remove support for legacy bodnds.
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 2:

Build Started (2/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17481/

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: remove support for legacy bodnds.

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: remove support for legacy bodnds.
..


Patch Set 2:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17484/

-- 
To view, visit https://gerrit.ovirt.org/39537
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf77d87138c0359fe0bafc0342dd49edb44c600
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: DhclientLeases does not need to be skipped if el6 (el6 is no...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: DhclientLeases does not need to be skipped if el6 (el6 is not 
supported anymore)
..


Patch Set 2:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2846/

-- 
To view, visit https://gerrit.ovirt.org/39538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850a00f5c4fa078031ba32d152cba2d4463a994b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: dnsmasqDhcp does not need to consider el6 anymore
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: unused import

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: unused import
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e56dd2af6681d67dbdc5a0467db8f1ce673ab2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: disconnecting a port from a bridge should not consider el6 a...

2015-04-05 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: disconnecting a port from a bridge should not consider el6 
anymore
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e126b4986d81d8b3bb831f7d6145cde83645d2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: testBrokenNetworkReplacement does not need to consider el6 a...

2015-04-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: testBrokenNetworkReplacement does not need to consider el6 
anymore
..


Patch Set 2:

Build Started (1/3) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17482/

-- 
To view, visit https://gerrit.ovirt.org/39539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cae3d1580631a592bcdb19381466b5d76e751d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


  1   2   3   4   >