Change in vdsm[master]: vm: Streamline names in diskReplicateStart
Francesco Romani has posted comments on this change. Change subject: vm: Streamline names in diskReplicateStart .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc3ead0616718b1fd6dd877ad98a4fcfce9e5af2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Separate validation from getXML
Francesco Romani has posted comments on this change. Change subject: virt: Separate validation from getXML .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00916c13850e335fb13e74a13b52b71560bfb797 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy
Francesco Romani has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbafbfeb61f392bf420caa4589df7cdac92a6568 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
Piotr Kliczewski has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 1: This mechanism was built to allow each and every client to send heartbeats if configured to do so. Each client provide information how much time has left for him to send it. Having a collection of times we need to use min() to find which one is the soonest and configure io loop to wake up at this time. -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Improve spacing
Francesco Romani has posted comments on this change. Change subject: virt: Improve spacing .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94b751112db67398891820035a9ec06abed59c3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: Build Started (6/7) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/42/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Handle gluster exceptions in json rpc mode.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: -Verified Build Started (1/7) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17898/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.SampleVMs
automat...@ovirt.org has posted comments on this change. Change subject: tests: add tests for sampling.SampleVMs .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: periodic sampling using bulk stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: stats: periodic sampling using bulk stats .. Patch Set 54: * Update tracker::#1139217::OK * Check Bug-Url::OK * Check Public Bug::#1139217::OK, public bug * Check Product::#1139217::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 54 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: periodic sampling using bulk stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: periodic sampling using bulk stats .. Patch Set 54: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17897/ -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 54 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set defualt device in __init__
Francesco Romani has posted comments on this change. Change subject: virt: Set defualt device in __init__ .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/40063/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-20 09:19:43 +0300 Line 4: Commit: Nir Soffer nsof...@redhat.com Line 5: CommitDate: 2015-04-21 00:43:45 +0300 Line 6: Line 7: virt: Set defualt device in __init__ typo: defualt vs default Line 8: Line 9: Set Drive.device in __init__ instead of getXML(). Line 10: Line 11: Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6 https://gerrit.ovirt.org/#/c/40063/1/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 321 Line 322 Line 323 Line 324 Line 325 not sure why it was that way, most likely a relic of past times. Anyway, the new way looks just better. -- To view, visit https://gerrit.ovirt.org/40063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: Build Started (4/7) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/814/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: authors: add myself as contributor
automat...@ovirt.org has posted comments on this change. Change subject: authors: add myself as contributor .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85864a92967a4c46237b71afb36f15597b22256 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port highWrite monitoring
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: port highWrite monitoring .. Patch Set 44: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: Build Started (5/7) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1359/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 16: -Verified Build Started (1/7) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17899/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port queryBlockJobs
automat...@ovirt.org has posted comments on this change. Change subject: virt: periodic: port queryBlockJobs .. Patch Set 41: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: authors: add myself as contributor
oVirt Jenkins CI Server has posted comments on this change. Change subject: authors: add myself as contributor .. Patch Set 5: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17900/ -- To view, visit https://gerrit.ovirt.org/39877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85864a92967a4c46237b71afb36f15597b22256 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 35: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17901/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: Build Started (2/7) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/805/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
automat...@ovirt.org has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: drop {Advanced,Vm}StatsThread
automat...@ovirt.org has posted comments on this change.
Change subject: virt: stats: drop {Advanced,Vm}StatsThread
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia724c94867f470d32f063a1b177e73d2382e6525
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop AdvancedStatsFunction
automat...@ovirt.org has posted comments on this change. Change subject: virt: drop AdvancedStatsFunction .. Patch Set 44: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move TimeoutError into virt.errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move TimeoutError into virt.errors .. Patch Set 14: Build Started (3/7) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1371/ -- To view, visit https://gerrit.ovirt.org/39332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add tests for sampling.SampleVMs .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17896/ -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: virt: periodic: allow zero period
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: virt: periodic: allow zero period .. Patch Set 22: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17895/ -- To view, visit https://gerrit.ovirt.org/39247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0eed4f25ad91bed68f24be293e9b93b0cda1a5 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract Drive.diskType property
Francesco Romani has posted comments on this change. Change subject: virt: Extract Drive.diskType property .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Extract helpers for major XML elements
Francesco Romani has posted comments on this change. Change subject: virt: Extract helpers for major XML elements .. Patch Set 1: Code-Review+1 nice refactoring -- To view, visit https://gerrit.ovirt.org/40066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop AdvancedStatsFunction
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: drop AdvancedStatsFunction .. Patch Set 44: -Code-Review -Verified Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17905/ -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 14: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17906/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port queryBlockJobs
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port queryBlockJobs .. Patch Set 41: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17904/ -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: drop {Advanced,Vm}StatsThread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: drop {Advanced,Vm}StatsThread
..
Patch Set 14:
Build Started (1/2) -
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17902/
--
To view, visit https://gerrit.ovirt.org/39284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia724c94867f470d32f063a1b177e73d2382e6525
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17903/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port highWrite monitoring .. Patch Set 44: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17907/ -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Stop supporting engine 3.3
Dan Kenigsberg has posted comments on this change. Change subject: Stop supporting engine 3.3 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida4f7faea6877897b5d746b2aa2e250b38a32ab6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Stop supporting engine 3.3
Nir Soffer has posted comments on this change. Change subject: Stop supporting engine 3.3 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida4f7faea6877897b5d746b2aa2e250b38a32ab6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm
Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 2: Code-Review-1 Welcome back! However, we need to require python-2.7.5-18.el7_1.1 and python-2.6.6-56.el6. the latter is not really needed on master (where we no longer care about el6), but would be required in a backport - I'd love to fix the process leak in ovirt-3.5, too. -- To view, visit https://gerrit.ovirt.org/39780 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I938a1f2bc70fceab2c69bc8b3d8c0724a9da7720 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Remove validateStorageServerConnection
Nir Soffer has posted comments on this change. Change subject: storage: Remove validateStorageServerConnection .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: DONTMERGE: jsonrpc: debug log
oVirt Jenkins CI Server has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 35: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18072/ -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18073/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17903/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: drop {Advanced,Vm}StatsThread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: drop {Advanced,Vm}StatsThread
..
Patch Set 14:
Build Started (2/2) -
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18074/
--
To view, visit https://gerrit.ovirt.org/39284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia724c94867f470d32f063a1b177e73d2382e6525
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port queryBlockJobs
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port queryBlockJobs .. Patch Set 41: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18075/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17904/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 14: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18077/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Handle gluster exceptions in json rpc mode.
Bala.FA has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: Please verify this patch set. -- To view, visit https://gerrit.ovirt.org/39937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Handle gluster exceptions in json rpc mode.
Bala.FA has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: -Verified -- To view, visit https://gerrit.ovirt.org/39937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (11/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/53/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix busy read loop [2/3]
Dan Kenigsberg has posted comments on this change. Change subject: protocoldetector: Fix busy read loop [2/3] .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/39997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5a04b471846a85e2af63402c96dfd31dfe03644 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix has_expired check [3/3]
Dan Kenigsberg has posted comments on this change. Change subject: protocoldetector: Fix has_expired check [3/3] .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/39998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6758db22a6ac2d63f7df0c745d4f4484448bf7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix has_expired check [3/3]
Dan Kenigsberg has submitted this change and it was merged. Change subject: protocoldetector: Fix has_expired check [3/3] .. protocoldetector: Fix has_expired check [3/3] Detector uses utils.monotonic_time(), which has a typical rsolution of 10 milliseconds. This cause next_check_internal() to return 0 while has_expired() returns False. This cause a busy poll loop until utils.monotonic_time() returns a larger value, which takes typically 10 milliseconds. Now has_expired() returns True when reaching the deadline, eliminating the busy loop. Comparing test_reject_very_slow_client profiles before and after this change show that the busy loop was eliminated. This change is a rather small improvement, eliminating 100-500 functions calls per connection on my laptop, probably more on fast servers. Sat Apr 18 16:54:48 2015test-use-ssl-before.prof 743 function calls (750 primitive calls) in 0.006 seconds Ordered by: call count List reduced from 186 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 340.0000.0000.0050.000 betterAsyncore.py:139(Dispatcher._delegate_call) 220.0000.0000.0000.000 socket.py:223(meth) 180.0000.0000.0000.000 __init__.py:598(Logger.filter) 160.0000.0000.0000.000 betterAsyncore.py:69(Dispatcher.next_check_interval) 160.0000.0000.0010.000 betterAsyncore.py:51(Dispatcher.readable) 160.0000.0000.0000.000 betterAsyncore.py:54(Dispatcher.writable) 160.0000.0000.0000.000 utils.py:1220(monotonic_time) 130.0000.0000.0000.000 pthreading.py:66(RLock.acquire) 130.0000.0000.0000.000 pthread.py:95(RLock.lock) 110.0000.0000.0000.000 posixpath.py:51(normcase) Sat Apr 18 16:55:09 2015test-no-ssl-before.prof 1002 function calls (1009 primitive calls) in 0.007 seconds Ordered by: call count List reduced from 139 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 930.0010.0000.0020.000 betterAsyncore.py:139(Dispatcher._delegate_call) 460.0000.0000.0010.000 betterAsyncore.py:51(Dispatcher.readable) 460.0000.0000.0010.000 betterAsyncore.py:54(Dispatcher.writable) 460.0000.0000.0010.000 betterAsyncore.py:69(Dispatcher.next_check_interval) 450.0000.0000.0000.000 utils.py:1220(monotonic_time) 240.0000.0000.0000.000 betterAsyncore.py:159(AsyncoreEvent.writable) 240.0000.0000.0000.000 asyncore.py:416(AsyncoreEvent.__getattr__) 240.0000.0000.0000.000 protocoldetector.py:60(_AcceptorImpl.readable) 240.0000.0000.0000.000 betterAsyncore.py:79(lambda) 240.0000.0000.0000.000 asyncore.py:324(AsyncoreEvent.readable) Sat Apr 18 17:16:19 2015test-use-ssl-after.prof 649 function calls (656 primitive calls) in 0.007 seconds Ordered by: call count List reduced from 187 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 220.0000.0000.0010.000 socket.py:223(meth) 180.0000.0000.0000.000 __init__.py:598(Logger.filter) 180.0000.0000.0040.000 betterAsyncore.py:139(Dispatcher._delegate_call) 130.0000.0000.0000.000 pthreading.py:66(RLock.acquire) 130.0000.0000.0000.000 pthread.py:95(RLock.lock) 110.0000.0000.0000.000 posixpath.py:51(normcase) 100.0000.0000.0000.000 threading.py:1153(currentThread) 90.0000.0000.0000.000 __init__.py:713(MyMemoryHandler.format) 90.0000.0000.0000.000 process.py:59(current_process) 90.0000.0000.0000.000 __init__.py:693(MyMemoryHandler.acquire) Sat Apr 18 17:16:31 2015test-no-ssl-after.prof 524 function calls (531 primitive calls) in 0.006 seconds Ordered by: call count List reduced from 140 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 170.0000.0000.0010.000 socket.py:223(meth) 160.0000.0000.0000.000 __init__.py:598(Logger.filter) 130.0000.0000.0010.000 betterAsyncore.py:139(Dispatcher._delegate_call) 110.0000.0000.0000.000 pthreading.py:66(RLock.acquire) 110.0000.0000.0000.000 pthread.py:95(RLock.lock) 90.0000.0000.0000.000 posixpath.py:51(normcase) 90.0000.0000.0000.000 threading.py:1153(currentThread)
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (10/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/508/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix busy read loop [2/3]
automat...@ovirt.org has posted comments on this change. Change subject: protocoldetector: Fix busy read loop [2/3] .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5a04b471846a85e2af63402c96dfd31dfe03644 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Make socket blocking after detection
Dan Kenigsberg has posted comments on this change. Change subject: protocoldetector: Make socket blocking after detection .. Patch Set 3: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix has_expired check [3/3]
automat...@ovirt.org has posted comments on this change. Change subject: protocoldetector: Fix has_expired check [3/3] .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6758db22a6ac2d63f7df0c745d4f4484448bf7f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (3/12) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/876/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix busy poll loop [1/3]
Dan Kenigsberg has submitted this change and it was merged. Change subject: protocoldetector: Fix busy poll loop [1/3] .. protocoldetector: Fix busy poll loop [1/3] Watching top during protocoldetector tests show very high (100%) cpu usage during the slow client test. Profiling test_detect_slow_client test show that the reactor is running a busy poll loop: Sat Apr 18 15:43:05 2015test-use-ssl.prof 191917 function calls (191928 primitive calls) in 0.367 seconds Ordered by: internal time List reduced from 197 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 65980.0910.0000.3250.000 asyncore.py:170(poll2) 329870.0740.0000.1430.000 betterAsyncore.py:139(Dispatcher._delegate_call) 65980.0360.0000.1600.000 betterAsyncore.py:209(Reactor._get_timeout) 65980.0240.0000.0290.000 asyncore.py:416(AsyncoreEvent.__getattr__) 131940.0220.0000.0640.000 betterAsyncore.py:69(Dispatcher.next_check_interval) 65980.0150.0000.3430.000 asyncore.py:205(loop) 65970.0120.0000.0680.000 asyncore.py:105(readwrite) 131940.0120.0000.0570.000 betterAsyncore.py:51(Dispatcher.readable) 131940.0120.0000.0690.000 betterAsyncore.py:54(Dispatcher.writable) 65950.0110.0000.0290.000 protocoldetector.py:87(_ProtocolDetector.next_check_interval) Sat Apr 18 15:46:09 2015test-no-ssl.prof 184319 function calls (184329 primitive calls) in 0.359 seconds Ordered by: internal time List reduced from 148 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 63400.0900.0000.3200.000 asyncore.py:170(poll2) 316960.0730.0000.1390.000 betterAsyncore.py:139(Dispatcher._delegate_call) 63400.0350.0000.1550.000 betterAsyncore.py:209(Reactor._get_timeout) 63400.0220.0000.0260.000 asyncore.py:416(AsyncoreEvent.__getattr__) 126780.0220.0000.0620.000 betterAsyncore.py:69(Dispatcher.next_check_interval) 63400.0150.0000.3380.000 asyncore.py:205(loop) 126780.0120.0000.0570.000 betterAsyncore.py:51(Dispatcher.readable) 63390.0120.0000.0640.000 asyncore.py:105(readwrite) 126780.0120.0000.0680.000 betterAsyncore.py:54(Dispatcher.writable) 63380.0110.0000.0280.000 protocoldetector.py:87(_ProtocolDetector.next_check_interval) The root cause is not implementing writable() method, inheriting the writable() method from asyncore.dispatcher, returning True. The reactor poll the sockets for POLLOUT, and since a socket is always writable if you never write to it, the reactor is waking up immediately. This creates a busy loop, invoking poll 6340 times for handling one connection, sending one line. Now we implement writable(), so the reactor wakes up only when data can be read from a socket, or when a dispatcher has expired. Profiling same test after this show expected behavior: Sat Apr 18 15:53:40 2015test-use-ssl-after.prof 686 function calls (697 primitive calls) in 0.005 seconds Ordered by: internal time List reduced from 199 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 40.0010.0000.0010.000 asyncore.py:416(AsyncoreEvent.__getattr__) 20.0000.0000.0000.000 pthread.py:129(Cond.wait) 90.0000.0000.0000.000 __init__.py:242(LogRecord.__init__) 40.0000.0000.0000.000 socket.py:185(_socketobject.__init__) 40.0000.0000.0040.001 asyncore.py:170(poll2) 240.0000.0000.0000.000 socket.py:223(meth) 160.0000.0000.0040.000 betterAsyncore.py:139(Dispatcher._delegate_call) 10.0000.0000.0040.004 protocoldetectorTests.py:184(AcceptorTests.check_slow_client) 150.0000.0000.0000.000 pthread.py:95(RLock.lock) 10.0000.0000.0000.000 ssl.py:294(SSLSocket.close) Sat Apr 18 16:23:43 2015test-no-ssl-after.prof 541 function calls (551 primitive calls) in 0.006 seconds Ordered by: internal time List reduced from 145 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 20.0020.0010.0020.001 threading.py:561(_Event.__init__) 80.0000.0000.0010.000 __init__.py:242(LogRecord.__init__) 20.0000.0000.0000.000 pthread.py:129(Cond.wait) 10.0000.0000.0010.001 protocoldetectorTests.py:184(AcceptorTests.check_slow_client)
Change in vdsm[master]: protocoldetector: Fix busy poll loop [1/3]
automat...@ovirt.org has posted comments on this change. Change subject: protocoldetector: Fix busy poll loop [1/3] .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id18d87d10db63f216699bd60ee82fd3ff08e7624 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (7/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/495/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (2/12) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/913/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (1/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/505/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
automat...@ovirt.org has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
Dan Kenigsberg has submitted this change and it was merged. Change subject: protocoldetector: Fix next_check_interval .. protocoldetector: Fix next_check_interval Commit b25dbdcce4 (Have the protocol detector use the Reactor) added the check_next_interval() interface, returning the timeout until the next check. However the implementation in some of the dispatchers was wrong, always returning 0. This cause the event loop to run a busy polling loop instead of waiting until the next dispatcher check time. Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: https://gerrit.ovirt.org/39994 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dima Kuznetsov dkuzn...@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/sslutils.py M vdsm/protocoldetector.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (6/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/499/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (9/12) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/911/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (4/12) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4885/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix next_check_interval
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix next_check_interval .. Patch Set 2: Build Started (8/12) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/909/ -- To view, visit https://gerrit.ovirt.org/39994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix busy poll loop [1/3]
Dan Kenigsberg has posted comments on this change. Change subject: protocoldetector: Fix busy poll loop [1/3] .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/39996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id18d87d10db63f216699bd60ee82fd3ff08e7624 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
[oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4887 - Still Failing!
Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4887/ Build Number: 4887 Build Status: Still Failing Triggered By: Triggered by Gerrit: https://gerrit.ovirt.org/39997 - Changes Since Last Success: - Changes for Build #4875 [Martin Sivak] Fix the CPU quota MOM policy computations Changes for Build #4876 [Dan Kenigsberg] unbreak pyflex test Changes for Build #4877 [Nir Soffer] tests: Fix detector read loop Changes for Build #4878 [Martin Polednik] hostdev: remove usb detach/reattach calls Changes for Build #4879 [ndarshan] gluster: adds a verb to check if a gluster volume is empty Changes for Build #4880 [ibar...@redhat.com] delete_dhclient_leases does not need to consider el6 anymore Changes for Build #4881 [ibar...@redhat.com] dnsmasqDhcp does not need to consider el6 anymore Changes for Build #4882 [ibar...@redhat.com] remove support for legacy bonds. Changes for Build #4883 [ibar...@redhat.com] DhclientLeases does not need to be skipped if el6 (el6 is not Changes for Build #4884 [Francesco Romani] virt: vmxml: remove writexml hack Changes for Build #4885 [Nir Soffer] protocoldetector: Fix next_check_interval Changes for Build #4886 [Nir Soffer] protocoldetector: Fix busy poll loop [1/3] [Nir Soffer] protocoldetector: Fix busy read loop [2/3] [Nir Soffer] protocoldetector: Fix has_expired check [3/3] Changes for Build #4887 - Failed Tests: - No tests ran. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 6: Build Started (3/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/513/ -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Nir Soffer has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 26: Code-Review+1 There is one extra empty line, but it is time to merge :-) -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Fix has_expired check [3/3]
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Fix has_expired check [3/3] .. Patch Set 2: Build Started (10/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/56/ -- To view, visit https://gerrit.ovirt.org/39998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6758db22a6ac2d63f7df0c745d4f4484448bf7f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 6: Build Started (4/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/510/ -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 6: Build Started (5/12) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/918/ -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add convertExternalVm for XmlRpc
Nir Soffer has posted comments on this change.
Change subject: v2v: Add convertExternalVm for XmlRpc
..
Patch Set 2: Code-Review-1
(4 comments)
Need to fix password handling and and docs, and make names match the schema or
the help.
https://gerrit.ovirt.org/#/c/40003/2/client/vdsClient.py
File client/vdsClient.py:
Line 1926:
Line 1927: def convertExternalVm(self, args):
Line 1928: validateArgTypes(args, [str, str, str, parse_dict, str],
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
- password should be auth (match the help, this raw auth string)
- properties should be vminfo (match the schema)
- job_id should be jobid (match the schema)
Line 1931: password = getAuthFromArgs(args, password)
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
Line 1934: if response['status']['code'] != 0:
Line 1927: def convertExternalVm(self, args):
Line 1928: validateArgTypes(args, [str, str, str, parse_dict, str],
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
Line 1931: password = getAuthFromArgs(args, password)
Should be:
password = getPassword(auth)
If we like to support also plain password:
if auth.startswith('auth='):
password = getPassword(auth)
else:
password = auth
Not sure that we do want this - need to check what other verb support.
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
Line 1934: if response['status']['code'] != 0:
Line 1935: return response['status']['code'],
response['status']['message']
Line 1929: requiredArgsNumber=5)
Line 1930: uri, username, password, properties, job_id = args
Line 1931: password = getAuthFromArgs(args, password)
Line 1932: response = self.s.convertExternalVm(uri, username, password,
Line 1933: properties, job_id)
same
Line 1934: if response['status']['code'] != 0:
Line 1935: return response['status']['code'],
response['status']['message']
Line 1936: return 0, 'Job started'
Line 1937:
Line 2818: 'Argumemnts:',
Line 2819: ' uri: uri of external system (vmware etc)',
Line 2820: ' username: login name for given uri',
Line 2821: ' auth: password for given uri, can be: ',
Line 2822: 'file:path or auth=env:name or
auth=pass:password',
Are you sure this is the expected input?
I think it should be:
auth=file:path or auth=env:name or auth=pass:password
Do we want to support plain password also?
Please check other code using this auth mechanism and be consistent.
Line 2823: ' vminfo: string dictionary, parameter for
import:',
Line 2824: '{vmName: name,',
Line 2825: ' poolId:, Guid,',
Line 2826: ' domainId: Guid,',
--
To view, visit https://gerrit.ovirt.org/40003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: authors: add myself as contributor
oVirt Jenkins CI Server has posted comments on this change. Change subject: authors: add myself as contributor .. Patch Set 6: Build Started (3/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/515/ -- To view, visit https://gerrit.ovirt.org/39877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85864a92967a4c46237b71afb36f15597b22256 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: authors: add myself as contributor
oVirt Jenkins CI Server has posted comments on this change. Change subject: authors: add myself as contributor .. Patch Set 6: Build Started (7/12) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/506/ -- To view, visit https://gerrit.ovirt.org/39877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85864a92967a4c46237b71afb36f15597b22256 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Verified+1 verified positive flows using tests and run a patched VDSM. -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: authors: add myself as contributor
oVirt Jenkins CI Server has posted comments on this change. Change subject: authors: add myself as contributor .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18071/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17900/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85864a92967a4c46237b71afb36f15597b22256 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17909/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/39796/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 2457: {'type': 'VmDiskDeviceSpecParams',
Line 2458: 'data': {'*path': 'str'
Line 2459: '*ioTune': 'VmDiskDeviceIoTuneParams',
Line 2460: '*pinToIoThread': 'uint'}}
Line 2461:
this change is fine, but numOfIoThreads was gone, and we still need it. Ple
yeah, right, restored
Line 2462: ##
Line 2463: # @VmDiskDeviceTuneParams:
Line 2464: #
Line 2465: # Extra parameters for VM disk devices. At least one
https://gerrit.ovirt.org/#/c/39796/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 362: driverAttrs['type'] = 'qcow2'
Line 363: elif self.format:
Line 364: driverAttrs['type'] = 'raw'
Line 365:
Line 366: if hasattr(self, 'specParams') and \
we usually prefer to write like
Done
Line 367:'pinToIoThread' in self.specParams:
Line 368: driverAttrs['iothread'] =
str(self.specParams['pinToIoThread'])
Line 369:
Line 370: driverAttrs['cache'] = self.cache
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: avoid periodic operations on DOWN vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: avoid periodic operations on DOWN vms .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17906/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: port highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: periodic: port highWrite monitoring .. Patch Set 44: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18078/ -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 4: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17912/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: fix call to super ctor
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: fix call to super ctor .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
automat...@ovirt.org has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 8: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 5: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17913/ -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
automat...@ovirt.org has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 4: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17911/ -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
automat...@ovirt.org has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
automat...@ovirt.org has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 4: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17910/ -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 4: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18084/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18081/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Tomas Jelinek tjeli...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
